July 2005 - Development - lists.drupal.org

[drupal-devel] [task] Enhanced upload administration
by Junyor 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/25756 Project: Drupal Version: cvs Component: upload.module Category: tasks Priority: normal Assigned to: Junyor Reported by: Junyor Updated by: Junyor Status: patch Attachment: http://drupal.org/files/issues/drupal-4-6.upload.junyor.patch (4.84 KB) I've found the need to have some administration for file attachments. Here's a demo patch of some of the proposed added functionality. This functionality should easily allow users to get a list of the files they've uploaded, so they can get rid of old files if they reach their size limit. Changes: - Added an 'administer uploaded files' permission - Added admin/uploads and 'my uploads', which list uploaded files Planned changes: - statistics for the 'my uploads' and admin/uploads pages with total size of uploaded files and size limit - functionality to delete/rename files (using checkboxes to select multiple files) Please comment on code quality, current functionality, and planned functionality. Thanks. Patch applies to 4.6 and HEAD. Junyor

9 42

[drupal-devel] [task] introduce node autofill
by Bèr Kessels 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/27530 Post a follow up: http://drupal.org/project/comments/add/27530 Project: Drupal Version: cvs Component: node system Category: tasks Priority: normal Assigned to: Bèr Kessels Reported by: Bèr Kessels Updated by: Bèr Kessels Status: patch Attachment: http://drupal.org/files/issues/node_autocomplete.patch (1.25 KB) This patch introduces an autofill for node titles. It is not yet used anywhere, but at least we have the node/autofill url available where contribs &c can query for node titles. Bèr Kessels

5 9

[drupal-devel] [bug] hook_delete_confirm -- custom controls for modules during delete cycle
by thehunmonkgroup 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/26649 Post a follow up: http://drupal.org/project/comments/add/26649 Project: Drupal Version: 4.6.2 Component: base system Category: bug reports Priority: normal Assigned to: thehunmonkgroup Reported by: thehunmonkgroup Updated by: thehunmonkgroup Status: patch Attachment: http://drupal.org/files/issues/node_module_hook_delete_confirm.patch (547 bytes) the proposed patch creates a hook_delete_confirm, which is called from node_delete during the confirmation cycle. this hook allows modules to inject custom control structures into the deletion process, as they don't currently have this ability. this is needed, for example, in the eventrepeat.module that i'm creating, which handles repeating/recurring events for event.module. without a solution such as this, there is no way for the module to put in options for different kinds of deletions--ex. 'this occurance only', 'this and all future occurances', 'all occurances'. click here [1] for a screenshot of what this hook looks like in action... i've tested this patch and it works great, even when multiple modules are calling hook_delete_confirm. i'd also be happy to write the documentation for hook_delete_confirm if this patch gets accepted. [1] http://www.apartmentlines.com/hook_delete_confirm_screenshot.PNG thehunmonkgroup

14 40

[drupal-devel] [feature] Dependency system to solve forum without comment problem
by chx 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/18447 Project: Drupal Version: cvs Component: system.module Category: feature requests Priority: normal Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/depend.patch (3.22 KB) As discussed on the developer list. This was surprisingly easy. There is still an issue: t('The configuration options have been saved.') is displayed more than once if there is a dependency forced module switch on. I have tried something (you'll see) for some reason it does not work. Number of page reloads can be decreased if Drupal could be reinitialized after system_listing_save instead of redirecting but I doubt this would be feasible. Although I marked this is feature request, this is more a usability issue (for the forum-comment dependency) and as a side effect it is a useful feature, too (for any other module "bundles"). I want criticism! I'd like to get torn apart by wild animals. Heavy! Eaten by some squirrels. chx

14 45

[drupal-devel] [task] Admin help in core modules
by Robin Monks 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/26139 Project: Drupal Version: 4.6.2 Component: other Category: tasks Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks Status: patch Attachment: http://drupal.org/files/issues/4-6-2-helptext.patch (126.02 KB) This patch adds help text to all core modules per the information at http://drupal.org/node/24768. This patch should be applied to 4.6.x and CVS HEAD. Robin Robin Monks

9 23

[drupal-devel] [bug] Queue module does not count the last submitted vote correctly
by leongtd 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/27303 Post a follow up: http://drupal.org/project/comments/add/27303 Project: Drupal Version: 4.6.2 Component: queue.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: leongtd Updated by: leongtd Status: patch Attachment: http://drupal.org/files/issues/drupal-4.6.2-queue-vote-fix.patch (438 bytes) Queue module does not count the last submitted vote correctly. After the user has submitted a vote, it wouldn't count as the vaild vote until another user vote in. Steps of reproduce: - If the promotion threshold is set as 1. - First user press +1 vote Actual results: - The vote just submitted won't get counted and the post won't be promoted until second user vote +1 again. Expected results: - The vote should count and the promotion should be immediate. Attached is the code to fix the problem. leongtd

2 1

[drupal-devel] [feature] Improved styling of autocomplete matches
by Thox 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/24932 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Thox Updated by: Thox Status: patch Attachment: http://drupal.org/files/issues/autocomplete_8.patch (1.39 KB) I'd like the autocomplete matches to be underlined (or styled in some way) so that users can see which part of the strings returned was actually matched. See Screenshot [1]. [1] http://photos14.flickr.com/19139302_0acb27f00d_o.png Thox

6 10

[drupal-devel] [feature] Speed up Drupal and improve scalability: On demand module loading
by Jose A Reyero 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/27901 Post a follow up: http://drupal.org/project/comments/add/27901 Project: Drupal Version: cvs Component: module system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Jose A Reyero Updated by: Jose A Reyero Status: patch (code needs review) Attachment: http://drupal.org/files/issues/on_demand_module_loading.patch (7.8 KB) As Drupal grows bigger, there is too much code not really needed parsed for each request. Also, installing more and more modules presents serious scalability issues, as all the enabled modules are included always for each non cached page. This is a first attempt to keep track of *all* module hooks, and only load modules when they're really needed. I guess it may need some polishing but the idea is simple enough. Currently, as the hook_menu is implemented by most of the modules, and it is called most of the times, the potential performance improvement introduced by this mechanism may be small. But the thing is, once he have some system for on demand module loading, hooks can be reworked in the future, to have some real performance boost. I.e. hook_menu could be easily split in two 'hook_menu' and 'hook_menu_dynamic', thus really reducing acually loaded modules. As I said, this is a first step. If there's some interest in this kind of features, I have some other things in the works aimed at performance and scalability, like: - (Simple) Rework of menu system to take real advantage of on demand module loading - Expand menu items to be able to include some file where the callback is in - Extend module loading for 'loading on path', and maybe 'loading split modules' - Some API loader, kind of api_invoke.... Jose A Reyero

6 10

[drupal-devel] [feature] Add Referrer Banning
by Robin Monks 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/27787 Post a follow up: http://drupal.org/project/comments/add/27787 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks Status: patch Attachment: http://drupal.org/files/issues/referring_banning_with_stat_fix.patch (7.9 KB) The attached patch adds the following features to Drupal HEAD: - Setting Access Permissions by referrer. The attached patch fixes the following bugs: - Port numbers on same domain cause Drupal to mark an external referrer This patch changes the following modules, by function: - user.module -- user_admin_access_check Now allows checking based on referrer. -- _user_admin_access_form Now has options for banning based on referrer. -- user_admin_access Now lists referrer bans. -- user_help Show referrer banning in documentation. - bootstrap.inc -- _drupal_bootstrap Checks to ensure user is not banned by referrer. - statistics.module -- statistics_top_referrers Has "quick-links" for banning referring domain. Fixes port issue. I have tested this module and it works correctly on Drupal HEAD. Robin Robin Monks

11 16

[drupal-devel] [task] Integrate primary links with menu navigation
by adrian 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/22215 Project: Drupal Version: 4.6.0 Component: theme system Category: tasks Priority: critical Assigned to: Anonymous Reported by: adrian Updated by: adrian Status: patch Attachment: http://drupal.org/files/issues/menu_patch.diff (7.58 KB) Here is the first version of the patch that uses the menu system to generate the primary and secondary navigational links. The navigation menu should by default be used as the source for the primary / secondary navigation (currently only in bluemarine, templates need to be modified to use this functionality). Furthermore, the css used sucks .. and we will need someone to write proper default css for us to make it at least presentable in the absence of theme css. The navlinks aren't really useful if there are more than 5 links in a menu, so admin/ looks utterly horrible. This code is copied and adjusted from Bér's primary links module, and Adrian Simmons cleaned up the CSS a bit. Bér didn't have any css with the module, so I had to rip it from his webschuur.com site. adrian

7 12