October 2008 - Development - lists.drupal.org

How to post bug reports and patches
by Markus Kalkbrenner 06 Nov '08

06 Nov '08

Hi, This is my first post to this list so I will introduce myself first. My name is Markus Kalkbrenner. I'm developing software for more than 15 years and participating in open source projects since 7 years. Two years ago I started working with drupal and posted my first bug reports and patches. Currently I'm asking myself which is the right strategy to contribute patches and get them committed to CVS because most of the time I'm still working with drupal 5 and find bugs there. Just some examples: Posted 4 month ago for drupal 5.7: http://drupal.org/node/229411 node_view() incompatible to php5 I was asked to add more comments to my patch and drumm found out that the same bug still exists in drupal 6. So I added the comments but nothing happend. Neither in D5 nor in D6. Posted 3 month ago for drupal 5.8 http://drupal.org/node/287063 node_delete memory leak and wrong order of commands In a different bug I was told to post the bugs for drupal 6 to get them handled faster and finally backported to drupal 5. So I switched the version for this issue to D6 and added an additional patch for it. But no reaction. Posted 3 month ago for drupal 6.dev http://drupal.org/node/298768 Ensure that entries are written to watchdog table and http://drupal.org/node/298678 Impossible to lock two MySQL tables From my point of view these are two serious issues which are the reason for several other bug reports. I found them in drupal 5 but discovered that they still exist in D6 and D7. So I decided to post them for D6 because this is the current stable version. Unfortunately I didn't see any reaction so far. Please don't get me wrong. I really like drupal and will keep on contributing patches because I want to improve it. But maybe I'm doing something wrong or you just have no time to maintain the stable versions. So for me the current situation is like a "bad user experience". Markus

31 69

Re: [development] Error running SimpleTest on new installation
by Dave Reid 03 Nov '08

03 Nov '08

That SimpleTest error happens when the first test fails. Since the test didn't complete, it's test_id does not get saved. If more than one tests pass, a valid test_id is saved. I have an issue report for this bug at http://drupal.org/node/325824*. * Dave* * > That particular error is usually caused by a bug in one of the unit tests you ran causing simpletest to hiccup. I've seen it a couple of times, and it's sometimes sporadic, unfortunately. It could be a bug in simpletest itself. I've not ruled that out yet. > > See if you can narrow it down to a single test that's causing the problem. If you can establish a pattern (a particular test, more than X tests, some particular phase of the moon, etc.) then file a bug report for the appropriate module (which could be simpletest itself). If you need more help narrowing it down, stop by #Drupal on IRC. Simpletest is high in the mind of most core devs of late, so there's a good chance you'll find someone who can give you more detailed help tracking down the problem. > > Thank you for helping make Drupal better! > > --Larry Garfield > > On Thu, 30 Oct 2008 13:16:11 -0400, "Sookocheff, Kevin" <Kevin.Sookocheff(a)cbsa-asfc.gc.ca> wrote: > >> Hello, >> >> I had checked out a fresh version of Drupal from CVS this morning and >> each time I run some SimpleTest test cases I receive the following >> error: >> >> Undefined index: test_id in _simpletest_batch_finished() (line 423 of >> E:\xampp\htdocs\drupal_test\modules\simpletest\simpletest.module). >> >> I am new to Drupal development and want to get started by writing some >> tests and reviewing patches. Does anyone have an idea about fixing the >> above problem so that I can get started? >> >> Thanks, >> Kevin

2 1

Re: [development] The static $perm variable in user_access reset erroneously
by Ron Parker 01 Nov '08

01 Nov '08

On Fri , Oct 31, 2008 at 12:27 AM, David Metzler < metzlerd(a)metzlerd.com >wrote: > It sounds like you're suggesting that $perm, a static variable within > user_access() is being modified without user_access being called, but within > a single page load. That doesn't seem possible in PHP, unless there is a > PHP bug. Static variables are supposed to be local in scope to the > functions that create them. To prove beyond a shadow of doubt, put a $debug > statement in at the very beginning of the function user_access and another > at the very end of the function. (just before the return). If what you're This is exactly what I'm suggesting. I put debug statements in user_access, node_content_access, and my OGUR function so that I would see every time they were accessed, and what was in them. To briefly summarize, I have a role "GroupAdmin" which is dynamically added to the $user object. It contains the "create story content" permission. I issue the command to clear the $perm cache: user_access('ClearCache', NULL, TRUE) This is followed by a module_invoke command (which, in turn will again call user_access): module_invoke('node_content', 'access', 'create', 'story', $user) The problem is that the $perm variable in the second user_access call should contain the values from the first user_access call, and it doesn't. It is still set, as it should be, but the variables are different. Here are the results of my debugging: I noticed that even when my hook_init() clears the $perm variable: • user_access('', NULL, TRUE) • ogur roles loaded into user object (hook_init) • user_access | string = • user_access | static $perm is NOT already set • user_access | $perm set for uid 3 (test01) • user_access | string = | $perm values = 0,1,2,0,1,2,4,5,7,8,9,10,4,5,6,7,8,9,10,0,0,1,2,3,4 • user_access | roles returned: (authenticated user,Devel,Group Member,Group Contributor,Group Admin) • user_access | permissions returned: (access comments,access content,view uploaded files,view advanced help index,view advanced help popup,view advanced help topic,post comments,post comments without approval,search content,use advanced search,subscribe to newsletters,view links in block,create page content,create story content,delete own page content,delete own story content,edit own page content,edit own story content,upload files,configure member roles,access devel information,display source code,execute php code,switch users,view devel_node_access information) The very next call to user_access does NOT contain the correct permissions: • user_access('access content') • user_access | string = access content | $perm values = 0,1,2,3,4,5,6,7,8,9,10,0,1,2,3,4 ( note that all the permmissions from above are NOT here - the only ones missing are those granted by the dynamically assigned roles ) • user_access | static $perm is already set • user_access | roles returned: (authenticated user,Devel,Group Member,Group Contributor,Group Admin) • user_access | permissions returned: (view advanced help index,view advanced help popup,view advanced help topic,access comments,post comments,post comments without approval,access content,search content,use advanced search,subscribe to newsletters,view links in block,access devel information,display source code,execute php code,switch users,view devel_node_access information) Another test: This is the page loaded: http://mysite.com/node/ognodeadd?type=story&gids[]=24 User should be able to create story. This is what debug returns: • ogur roles loaded into user object (ognodeadd) • ogur | ognodeadd roles returned: (authenticated user,Devel,Group Member,Group Contributor, Group Admin ) These are the correct roles for this user in this group. • ogur | module to call = node_content | type = story • ogur | Preparing to call module_invoke • ogur | Calling user_access('ClearCache', NULL, TRUE) • user_access | string = ClearCache • user_access | static $perm is NOT already set • user_access | $perm set for uid 3 (test01) • user_access | string = ClearCache | $perm values = 0,1,2,0,1,2,4,5,7,8,9,10,4,5,6,7,8,9,10,0,0,1,2,3,4 • user_access | roles returned: (authenticated user,Devel,Group Member,Group Contributor,Group Admin) This is correct. • user_access | permissions returned: (access comments,access content,view uploaded files,view advanced help index,view advanced help popup,view advanced help topic,post comments,post comments without approval,search content,use advanced search,subscribe to newsletters,view links in block, create page content,create story content,delete own page content,delete own story content,edit own page content,edit own story content,upload files ,configure member roles,access devel information,display source code,execute php code,switch users,view devel_node_access information) The above are the permissions that $perm should have the next time user_access is ran. It will run again when module_invoke() is called. Below is what comes back the very next time user_access is called. • ogur | Calling module_invoke('node_content', 'access', 'create', 'story', $user) • node_content_access | type = story | op = create • node_content_access | roles returned: (authenticated user,Devel,Group Member,Group Contributor,Group Admin) • user_access | string = create story content | $perm values = 0,1,2,3,4,5,6,7,8,9,10,0,1,2,3,4 • user_access | static $perm is already set • user_access | roles returned: (authenticated user,Devel,Group Member,Group Contributor, Group Admin ) This is correct. • user_access | permissions returned: (view advanced help index,view advanced help popup,view advanced help topic,access comments,post comments,post comments without approval,access content,search content,use advanced search,subscribe to newsletters,view links in block,access devel information,display source code,execute php code,switch users,view devel_node_access information) Note that the "Group Admin" role permissions are not included here. They should be the same as from from the ClearCache user_access command above. It appears that the above permissions have been cached somewhere else. • ogur | module_invoke called • ogur | ognodeadd roles returned: (authenticated user,Devel,Group Member,Group Contributor,Group Admin) • ogur | module_invoke access returns false Access should be true here. Installed devel module. There are four user_access SQL queries that appear on this page: 1.16 1 user_access SELECT p.perm FROM role r INNER JOIN permission p ON p.rid = r.rid WHERE r.rid IN (2,8) 0.77 3 user_access SELECT p.perm FROM role r INNER JOIN permission p ON p.rid = r.rid WHERE r.rid IN (2,8,3,4,7) 0.76 3 user_access SELECT p.perm FROM role r INNER JOIN permission p ON p.rid = r.rid WHERE r.rid IN (2,8,3,4,7) 0.72 3 user_access SELECT p.perm FROM role r INNER JOIN permission p ON p.rid = r.rid WHERE r.rid IN (2,8,3,4,7)

3 3

Error running SimpleTest on new installation
by Sookocheff, Kevin 31 Oct '08

31 Oct '08

Hello, I had checked out a fresh version of Drupal from CVS this morning and each time I run some SimpleTest test cases I receive the following error: Undefined index: test_id in _simpletest_batch_finished() (line 423 of E:\xampp\htdocs\drupal_test\modules\simpletest\simpletest.module). I am new to Drupal development and want to get started by writing some tests and reviewing patches. Does anyone have an idea about fixing the above problem so that I can get started? Thanks, Kevin

2 2

Re: [development] The static $perm variable in user_access
by Ron Parker 31 Oct '08

31 Oct '08

The static $perm variable in user_access() contains the permissions that users have. When user_access('ClearCache', NULL, TRUE) is executed, the static $perm value is emptied and re-filled with permissions from the current roles in the $user object . Theorectically, when user_access() is next called, assuming the $ user object contains the same roles, the $perm variable should contain the same permissions which were cached in the first call. This is what happened in Drupal 5.x and the earlier versions of 6.x. This is NOT happening (at least consistently) in the most recent versions of the user.module . I've written a bunch of debug code in the user, node and ogur modules and now have more details. I am printing the output of user_access () every time it is called. When I issue: user_access('ClearCache', NULL, TRUE) Static $perm variable is cleared and re-filled with permissions from current $user object. This is correct. When module_invoke () is immediately executed next: module_invoke('node_content', 'access', 'create', 'story', $user) It will now make another call to user_access() : user_access('create story content', $user) The $user object still contains the same roles. The $perm variable now contains values. This is correct. But the values in $perm are NOT the same as those inserted during the ClearCache call above! They have changed, and NOT from the user_access() function (which I am monitoring)! So the question is: Why has this $perm value changed? So far, I've found this behaviour occurs with OGUR when one of the following modules is installed: • taxonomy_access • tac_lite • menu_breadcrumb • admin_menu I so far am unable to discover what it is about these modules which is causing this problem. This did not occur in 5.x and earlier 6.x versions of Drupal. Please, please, please help! -ron

3 2

adding objects and submit data in a node_form()
by Aldo Martinez Selleras 31 Oct '08

31 Oct '08

hi! i want modify a node_form() function, but, i need to a direct relation between a node and a term in the taxonomy vocabulary, them, i want to add fieldset with a checkbox relation of the terms in the category, now, my question is it, how i add the information in the term_node table when submit the form ?? i hope u understand me. -- ---------------------- Aldo Martinez Selleras Administrador del Nodo CITMATEL GND Camaguey Tel: 32-291661 E-mail: aldo(a)caonao.cu Linux User #364356

3 2

Digg widget for Drupal.org Packt award story
by Robert Douglass 31 Oct '08

31 Oct '08

Hi everyone, congrats to all on our sweep of the Packt Open Source CMS awards. Really gerat news. Here's the code for the Digg widget to the Drupal.org story. Let's work together to get this onto the front page of Digg: <div style="float:left; margin-right:1.5em;"> <script>digg_url = 'http://digg.com/software/Drupal_Best_Open_Source_CMS_WINNER' ; </script><script src="http://digg.com/api/diggthis.js"> </div>

1 0

Looking for local gov, neighborhood association uses of Drupal
by Steven Clift 31 Oct '08

31 Oct '08

Noting the discussion of Federal government uses of Drupal, are any of you aware of any good examples of local government or neighborhood association uses of Drupal? I am in particular interested in examples which make public meetings more accessible (perhaps allowing comments on agenda items/documents), host active community calendars, or have set up personalized "what's new" e-mail update options. Also reply to: clift(a)publicus.net Thanks, Steven Clift http://stevenclift.com

3 2

Re: [development] Looking for local gov, neighborhood association uses of Drupal
by Alex Urevick-Ackelsberg 31 Oct '08

31 Oct '08

We helped to build, and currently maintain, a site for the Town and Village of Rhinebeck, NY. http://rhinebeck-ny.gov -- Alex Urevick-Ackelsberg Partner ZivTech, LLC http://zivtech.com alex(a)zivtech.com (917) 407-9086 > ---------- Forwarded message ---------- > From: Steven Clift <slc(a)publicus.net> > To: development(a)drupal.org > Date: Thu, 30 Oct 2008 14:34:09 -0500 > Subject: [development] Looking for local gov, neighborhood association uses > of Drupal > Noting the discussion of Federal government uses of Drupal, are any of you > aware of any good examples of local government or neighborhood association > uses of Drupal? > > I am in particular interested in examples which make public meetings more > accessible (perhaps allowing comments on agenda items/documents), host > active community calendars, or have set up personalized "what's new" e-mail > update options. > > Also reply to: clift(a)publicus.net > > Thanks, > Steven Clift > http://stevenclift.com > > >

1 0

Turning custom_url_rewrite_* into hooks?
by Steven Surowiec 30 Oct '08

30 Oct '08

I've working on a custom module for a project that makes use of custom_url_rewrite to open up linking shortcuts through the url() function and I was wondering if there is any specific reason this functionality isn't a regular hook? I know I could probably use URL aliases for what I'm trying to do but requires me to not have to worry about managing hundreds, possibly thousands, of URL aliases just to open up this type of functionality. Maybe I'm just mis-using this functionality but it seems like it might be worth while to consider.

4 3