July 2008 - Development - lists.drupal.org

clone a node
by Lluís 22 Jul '08

22 Jul '08

I have developed a custom module with custom node types and I need to make users able to clone nodes; would this be a good way to do so? $clone=node_load($value); $clone->is_new = true; $clone->uid = $user->uid; unset($clone->nid); unset($clone->vid); node_save($clone); -- *La vida és com una moneda, la pots gastar en el que vulguis però només una vegada. *La felicitat ha de ser compatible, compartible i cooperativa. *Envellim quan els records superen les il·lusions. *Als llocs desconeguts només s'hi arriba per camins desconeguts. *Abans d'imprimir aquest missatge, pensa en el medi ambient.

3 4

Issues with selecting radio buttons with JQuery
by Dan Robinson 22 Jul '08

22 Jul '08

Folks, Help appreciated - I'm building a node form where the form will reveal/hide portions depending on the users choices. To do this I'm using jQuery to manipulate the DOM. I'm having a lot of issues with the radio buttons. What I want to do is have a message pop up if the user selects a particular radio button (in this case a "no" choice of a "Yes/No" "set"). For this to work I need to attach an "onClick" handle to the "no" radio button and when the user clicks evaluate and display the message. Because of a series of interrelated issues I've tried a number of approaches. The one I'm working on now is: - I'm using the form APIs "radios" - an issue here is that "radios" define the actual radio buttons in an array and it doesn't look like there is a way to assign an id attribute using the forms api (as a matter of fact there is code in form.inc which explicitly strips out an ID at that level). - I assign an onClick handler to the "radios" - #attributes' => array('onClick' => 'CitizenClick()') - On form load I assign an id to the specific radio button I'm interested in - $("[name=CitizenQ][value=no]").attr('id', 'CitizenNoButton'); - In CitizenClick() I check and take action depending - if ( $("#CitizenNoButton").attr('checked') ) { - Please note that although I could do all this without an "id" and by selecting the "name" instead of the "id" - it was very slow Everything works - EXCEPT - I am placing the radio buttons inside of a fieldset thusly - $form['Qualifyers'] = array( '#type' => 'fieldset', '#tree' => TRUE, '#weight' => 1, ); $form['Qualifyers']['CitizenQ'] = array( '#type' => 'radios', '#title' => t('Are you a U.S. Citizen?'), '#default_value' => 1, '#options' => array('yes' => t('Yes'), 'no' => t('No')), '#attributes' => array('onClick' => 'CitizenClick()'), ); If I don't place it within the fieldset I can select the radio with - $("[name=CitizenQ][value=no]") However withing the fieldset I can't get this to work - $("[name=Qualifyers[CitizenQ]][value=no]") I assumed the above wouldn't work because the "[]" are special characters so I tried escaping them - $("[name=Qualifyers\\[CitizenQ\\]][value=no]") Still no joy - I have been beating my head against this for a while and would appreciate some assistance - also if I've approached this in a fundamentally wrong way please let me know. Thanks! Dan

5 6

Peculiar behavior of collapsible fieldset titles
by Syscrusher 22 Jul '08

22 Jul '08

I've got a set of forms in Drupal 5 that are working correctly but have an odd cosmetic error that I've been unable to track down. The code worked in Drupal 4.7. Basically, I am assigning the title of some collapsible fieldsets dynamically -- specifically, it's a project number and name that result from a database query. The title should look like this: Subtasks for Project #1234 (Redesign Office LAN) For some reason, the titles are perfect when the fieldsets are expanded but empty when collapsed (that is, they look like this): Subtasks for # () I think I know *what* is happening -- that is, the function that builds the $form array is being called twice and has the variable unpopulated one of the two times -- but I'm at a loss to figure out how that could be happening. The database query not only populates the title of the fieldset, but also its very presence depends on a row being retrieved. So I would think that if the database query were somehow being skipped, the fieldset would be entirely missing, not just empty! Has anyone seen something like this before? I realize I haven't given enough detail or code to troubleshoot it entirely -- I'm not asking someone to do my debugging for me, just looking for someone out there who has seen something similar and can tell me in general terms what might be happening. Thanks if anyone has suggestions. Kind regards, Scott -- Syscrusher <syscrusher(a)4th.com>

2 2

[PATCH] drupal/filter: fix broken multi-line HTML tags
by Jeremy Kerr 22 Jul '08

22 Jul '08

Currently, the filter module will mis-handle HTML tags that span more than one line. For example: <a href="#" >link</a> Will be filtered to: <a href="#" >link</a> This is caused by the attempt to match '.>' in filter_xss(). Since the . doesn't (by default) match a newline, the filter will try to escape the closing > on the <a> tag. This results in aggregated feeds with badly-formed HTML. This change removes the . match, so that a newline as the last character in a opening HTML tag is accepted. So that we always require at least one character in a tag, we also change the [^>]* to [^>]+ Signed-off-by: Jeremy Kerr <jk(a)ozlabs.org> --- modules/filter/filter.module | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: drupal-6.2/modules/filter/filter.module =================================================================== --- drupal-6.2.orig/modules/filter/filter.module 2008-07-01 09:28:22.000000000 +1000 +++ drupal-6.2/modules/filter/filter.module 2008-07-22 09:24:48.000000000 +1000 @@ -983,7 +983,7 @@ function filter_xss($string, $allowed_ta ( <(?=[^a-zA-Z!/]) # a lone < | # or - <[^>]*.(>|$) # a string that starts with a <, up until the > or the end of the string + <[^>]+(>|$) # a string that starts with a <, up until the > or the end of the string | # or > # just a > )%x', '_filter_xss_split', $string);

2 2

Drupal Tough Love #2: Signatures for Forums 5.x-2.3
by Morbus Iff 21 Jul '08

21 Jul '08

In case you missed it, a new Drupal Tough Love is up: http://www.drupaltoughlove.com/review/signatures-for-forums It has caused a few changes, and issues, for Coder.module and core. And there's one issue that I still haven't gotten around to making, which Benjamin Melançon brings up - core's uid should, in fact, be considered unsigned in all tables, but isn't (ex. node.install). -- Morbus Iff ( i've got the creme filling ) Technical: http://www.oreillynet.com/pub/au/779 Enjoy: http://www.disobey.com/ and http://www.videounderbelly.com/ aim: akaMorbus / skype: morbusiff / icq: 2927491 / jabber.org: morbus

1 0

Scour.com invite from Sambasiva Rao
by Sambasiva Rao 20 Jul '08

20 Jul '08

Hey, Did you hear about Scour? It is the next gen search engine with Google/Yahoo/MSN results and user comments all on one page. Best of all we get paid for using it by earning points with every search, comment and vote. The points are redeemable for Visa gift cards! It's like earning credit card or airline points just for searching! Hit the link below to join for free and we will both get points! http://scour.com/invite/sanaari/ I know you'll like it! - Sambasiva Rao

7 6

Memcache critical issues blocking D6 upgrade
by Robert Douglass 19 Jul '08

19 Jul '08

Anyone interested in the health and future of the memcache module: Please look at the critical issues for memcache DRUPAL-5--1-7: http://tinyurl.com/5flw54 I want to make a DRUPAL-5--1-8 release that fixes these issues before upgrading to Drupal 6. Please lend your support. Robert Douglass rob(a)robshouse.net The RobsHouse.net Newsletter: http://robshouse.net/newsletter/robshousenet-newsletter

2 2

Advcache module needs some love.
by Robert Douglass 19 Jul '08

19 Jul '08

Hi all, I'd like to do a DRUPAL-5--1-8 release of advcache but there are some bugs. I could use eyeballs on the queue. When we get the queue down I'll look into a DRUPAL-6 version. http://tinyurl.com/5q4537 Robert Douglass rob(a)robshouse.net The RobsHouse.net Newsletter: http://robshouse.net/newsletter/robshousenet-newsletter

1 0

no date / time types in schema API
by augustin (beginner) 17 Jul '08

17 Jul '08

Hi, http://en.wikibooks.org/wiki/SQL_dialects_reference/Data_structure_definiti… All (but one) SQL dialects have a date type. However, Drupal's Schema API does not seem to have a type for date only: http://drupal.org/node/159605 It causes schema.module to complain: no type for Schema type date:normal. I am concerned that with the new Schema API, my modules may not install properly anymore. (how can it install a table where a column has an unsupported type?) Is this a purposeful omission? I just found this issue: http://drupal.org/node/200953 so others noticed, too :) How are you all coping with the lack of time/date data type? What workarounds do you use? I could use the data type datetime, but then I have to worry about truncating the time part which I do not need. I use substr() to truncate the part I don't want, but coder.module complains about it (says I should use drupal_substr() while substr() is quicker and safe in this case). There is probably a better way to truncate the time part (please say), but it feels a shame to have to deal with the extraneous time part when Schema API could easily handle date types. Blessings, Augustin.

11 19

gotcha: menu wildcards, foreach() and MENU_SUGGESTED_ITEM
by augustin (beginner) 17 Jul '08

17 Jul '08

Hello, I just noticed a bug in directory.module, and I see the exact same bug in tagadelic.module. This bug involves the new menu system. In D5, we used to be able to dynamically create a series of menu items with a foreach loop within hook_menu(). When upgrading to D6, the tendency has been to remove the foreach loop, and replace the arg(n) with a wildcard loader, but it is the wrong solution. In most cases, you don't want to remove the foreach() loop you had in D5. Within D6, it is perfectly ok to have a loop, recursively declaring several well defined menu items, e.g. one item for each vocabulary. When you have such a loop, do not use the wildcard loader. For a detailed example see this issue: http://drupal.org/node/283198 I have updated the documentation in the handbook. Blessings, Augustin.

4 5