August 2009 - Development - lists.drupal.org

Possible security issue in Drupal with previous/next thread in forum
by Jean-Michel Pouré 26 Aug '09

26 Aug '09

Dear all, I hope that this is the right place to post. My issue http://drupal.org/node/559424 was closed with a "Wron't fix" answer. On my server, a query returns 21000 rows in 7412 ms. Just to be able to display previous and next forum thread. The number of rows seems too large. I double-checked on my testing server with 650.000 posts and the devel module + pgadmin3. Kind regards, Jean-Michel

3 3

Drupal 7 node_example.module
by Dale McGladdery 25 Aug '09

25 Aug '09

I'm working on a Drupal 7 update to the node_example.module. Issue: http://drupal.org/node/508342 I have a working D7 version of node_example.module. Before I post my replacement candidate I'm hoping for answers to a couple of questions. If you have a comment, please respond in the issue queue (http://drupal.org/node/508342) so we retain a record of the conversation. Q1: The Drupal 6 example (http://api.drupal.org/api/drupal/developer--examples--node_example.module) provided SQL for creating a database table required for the module. I've created a .install file and Schema API definition for the module (for my own testing sanity). Since using schema is best practice, I would like to include the .install file in the example. Comments/Objections? Q2: If the Schema API is used, which database update method is better for the example: drupal_write_record() (Schema API) or db_insert()/db_update()? I've used db_insert and db_update because they seem the best follow-on from the Drupal 6 example. However, I don't know if this is a situation where drupal_write_record() is best practice. Thanks in advance, everyone. Looking forward to feedback in http://drupal.org/node/508342 .

1 0

control bars for swf videos ?????
by Neeraja 25 Aug '09

25 Aug '09

Hi, Is it possible to have control bars for the swf videos? I have a swf video file and I uploaded it using the following-but could not get the control bars. I have experimented on drupal5.x and drupal6.x with the video module, swf tools, flash node , flash video module and the media players- on http://drupal.org/node/303203. Thanks Neeraja

2 1

Using the Forms API to post information to an external source
by Brian Vuyk 25 Aug '09

25 Aug '09

Hello all. For one of my clients, we have a long multistep form that we use to collect information for a user and enroll him / her in a course. One thing we would like to do is POST some information to an external API. Is it possible, using the FAPI, to POST data to an external source? I was going to user $form['#method'], however, that only allows internal paths. Worst case scenario, I could create a custom submit callback which POSTS the data over using CURL, but I am hoping to find a more elegant solution. Any suggestions? Thanks in advance, Brian

3 6

easy way to check if a value has changed (nodeapi)
by Hans Langouche 25 Aug '09

25 Aug '09

Hi there, I'm working on a (node) profile system that has a checkbox to allow people to be informed by postal mail. If checked the system sends a mail with the details to a certain email address. Of course this email shouldn't be sent every time the profile is updated, but only when the checkbox was previously unchecked (if it was checked allready, nothing should happen). For the moment I'm thinking of creating a second (hidden) value to which I compare on 'update' and sync with the actual value after the check. But I'm thinking there must be an easier way, but can't find it in documentation or by inspecting $node on 'update'. Tnx, HnLn

7 7

Will this work in Postgres?
by Nancy Wichmann 24 Aug '09

24 Aug '09

Okay, all you Postgres experts who want to be helpful, here's a question for you: I'm trying to select all revisions of nodes that have revisions other than the current one that are older than a given time and of a selected type(s). The following query does what I need in MySql, will it work in Postgres? SELECT r.nid, r.vid, r.timestamp, DATE( FROM_UNIXTIME(r.timestamp)) AS 'date', n.title, n.type FROM {node_revisions} r INNER JOIN {node} n ON r.nid = n.nid WHERE n.nid IN ( SELECT r.nid FROM {node_revisions} r INNER JOIN {node} n ON r.nid = n.nid AND r.vid <> n.vid WHERE r.timestamp <1248708062 AND n.type IN ('page', 'story') ) ORDER BY r.nid, r.timestamp DESC >From looking at the PG docs, I see that "DATE( FROM_UNIXTIME( r.timestamp ) ) AS 'date'" probably needs to be changed to "CAST(r.timestamp AS date) AS 'date'" and I can do that in my code. The funny thing is that the MySql docs mention doing the same, but it returns a NULL. Nancy E. Wichmann, PMP Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr.

2 1

filtering empty dates in views
by Lluís 24 Aug '09

24 Aug '09

I have a custom module with a custom date. After searching through drupal.org I save dates as timestamps in integer fields. Now I need to create a view filtering nodes with empty date; how should I do this? I have added to views_handler_filter_numeric.inc (views_handler_filter_date.inc depends on it) the option to choose greater, equal, less..., null and not null. Is this the correct way? any other ideas? -- *La vida és com una taronja, què esperes a exprimir-la? *Si creus que l'educació és cara, prova la ignorància. *La vida és com una moneda, la pots gastar en el que vulguis però només una vegada. *Abans d'imprimir aquest missatge, pensa en el medi ambient.

1 0

Should it go in core?
by robert crowther 22 Aug '09

22 Aug '09

I don't really know much about the workings of Drupal organisation, but maybe someone could tell me this? Do a set of criteria exist for entry to core? A recent thread, 'How everyone could win' raised the issue of Views in core. I'm sure this has been posted several times, along with several other threads about 'I'd like this in core/shouldn't core have.../I'm never stand for having such and such in core/I've got those core blues/core, she's your baby now' etc. I know criteria can seem, well, legalistic, but they do tidy up such discussions. e.g. If one of the criteria were a minimum spec machine that Drupal could run on, we could all stop talking about whether modules were too heavy for core, or justified, and just argue for raising or lowering the criteria spec. Another example, if a criteria was, 'Must not subvert or bypass existing provision' - hey, now I'm not saying that SHOULD be a criteria - then if a proposed module does such a thing, the action would be clear. Core would have to move in that direction, or the proposed code revised towards core.

3 6

If you want to debug tests
by Karoly Negyesi 22 Aug '09

22 Aug '09

Use debug() or $this->verbose() for longer messages. debug() is also useable outside of testing. These are quite new but quite good :D

1 0

Prioritizing for code freeze
by Jennifer Hodgdon 21 Aug '09

21 Aug '09

We have, at this moment, 223 "patches to review" issues, 1698 "patch queue" issues, and 357 "critical issues" for D7, according to the Contributor Links block on drupal.org. It's hard to figure out what to focus on, given so many choices. So I'm thinking about priorities for the upcoming code freeze (Sept 1, right?). My understanding is that all new features for Drupal would need to be patched, reviewed, and committed before the code freeze, or they would be pushed back to Drupal 8. Those are easy to find, using the Category field of the issue queue. But my understanding is that also any API changes would need to be patched, reviewed, and committed before the code freeze, and there wasn't any obvious way I knew of to find them. So, I've introduced a new issue tag, "API change", which will help identify those issues, if people start marking their issues accordingly. Thoughts? So am I way off base, or shouldn't we be focusing our patching and review efforts on these areas between now and Sept 1, and leaving the bug fixes (even "critical" bug fixes) for after the freeze? Is there anything else that also cannot wait until after the code freeze? --Jennifer -- Jennifer Hodgdon * Poplar ProductivityWare www.poplarware.com Drupal, WordPress, and custom Web programming

6 11