February 2005 - Development - lists.drupal.org

[drupal-devel] [bug] Remove some cruft
by killes 21 Feb '05

21 Feb '05

Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org Status: patch Attachment: http://drupal.org/files/issues/remove-cruft.patch (2.98 KB) This patch remove some cruft from core: - three lines of dead code from node module - taxonomy_node_has_term() function. Was used nowhere. - definitions of page table. killes(a)www.drop.org -- View: http://drupal.org/node/17687 Edit: http://drupal.org/project/comments/add/17687

1 0

[drupal-devel] [task] Support for Taxonomy Images in theme settings.
by grohk 21 Feb '05

21 Feb '05

-Project: Taxonomy image +Project: Drupal -Version: cvs +Version: cvs -Component: Code +Component: system.module -Category: support requests +Category: tasks Priority: normal Assigned to: Anonymous Reported by: Anonymous Updated by: grohk -Status: active +Status: patch Attachment: http://drupal.org/files/issues/system_module_taxonomy_images.patch (507 bytes) Trying to keep this idea alive by resectioning to the correct place (I think) and freshening the patch against the latest CVS system.module. Please forgive me it this is inappropriate, but I think this patch is important for many users. grohk Previous comments: ------------------------------------------------------------------------ December 7, 2004 - 11:11 : Anonymous Attachment: http://drupal.org/files/issues/system_taxonomy_images.patch (727 bytes) This patch adds a checkbox on admin/themes/settings to toggle display of taxonomy images, only if this module is installed and activated. I've also sent a patch to phptemplate theme engine that it uses this checkbox to fill a new variable usable for templates. ------------------------------------------------------------------------ December 7, 2004 - 11:19 : Anonymous PHPtemplate patch that uses this new checkbox: http://drupal.org/node/14028 ------------------------------------------------------------------------ December 7, 2004 - 11:23 : Anonymous Patch for box_grey theme: http://drupal.org/node/14029 ------------------------------------------------------------------------ December 14, 2004 - 21:45 : jxs2151 I am unable to get this working after applying all three patches. When patching the phptemplate engine I get this error: patching file phptemplate.engine Hunk #1 succeeded at 73 (offset 1 line). Hunk #2 FAILED at 239. Hunk #3 succeeded at 237 (offset -23 lines). 1 out of 3 hunks FAILED -- saving rejects to file phptemplate.engine.rej The checkbox for allowing Taxonomy images in posts appears, I created the category, uploaded the image. I can view the image by direct reference in a url, it just does not show up on the page. ------------------------------------------------------------------------ December 16, 2004 - 19:50 : carlosparamio Attachment: http://drupal.org/files/issues/phptemplate_taxonomy_images_0.patch (1.31 KB) It seems that phptemplate.engine file has changed a little. Here is a new patch. When this patch was applied, then you can use the array $taxonomy_images[] in your node.tpl.php theme template to access to the image files for correspondant terms. For example, $taxonomy_images[0] to access to the image file for the first term. This is what box_grey patch does. ------------------------------------------------------------------------ December 16, 2004 - 19:52 : carlosparamio Attachment: http://drupal.org/files/issues/phptemplate_taxonomy_images_4.5.0.patch (1.13 KB) And here is a patch for Drupal 4.5.0 release also. -- View: http://drupal.org/node/14027 Edit: http://drupal.org/project/comments/add/14027

1 0

[drupal-devel] Glossary paged
by Maykel Moya 21 Feb '05

21 Feb '05

I'd like to make glossary not one page, but many pages, one for letter. Could you point me please to some documentation I should previously read to achieve my goal? Regards, mike

4 3

[drupal-devel] [task] Extend db_query()
by chx 21 Feb '05

21 Feb '05

Project: Drupal Version: cvs Component: database system Category: tasks Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: chx Status: patch Do I need to say +1? chx Previous comments: ------------------------------------------------------------------------ February 21, 2005 - 13:48 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/db-query.patch (2.16 KB) We should make our database abstraction layer more robust and ensure that module authors can use it without string manipulations inside the query. Several queries use implode() to get their arguments into the query. This is undesirable as we rely on the module author to check the keys and values of such arrays for exploitation attempts. I have created the attached patch which shouldbe able to allow us to not use implode anymore. A minor problem is that all inserted values will be treated as strings. This might be a problem with PostgreSQL at least. However, the same strategy is already used in Drupal core without any complaints I know of. Summary: This patch will alow us to simplify some code in node.module, user.module, taxonomy.module and probably others. ------------------------------------------------------------------------ February 21, 2005 - 18:03 : killes(a)www.drop.org It's a patch. ------------------------------------------------------------------------ February 21, 2005 - 18:19 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/db-query_0.patch (2.07 KB) Squeezed out two lines of code after consultation with Karoly. Adds only 10 loc (plus some docs). -- View: http://drupal.org/node/17656 Edit: http://drupal.org/project/comments/add/17656

1 0

[drupal-devel] [task] Extend db_query()
by killes 21 Feb '05

21 Feb '05

Project: Drupal Version: cvs Component: database system Category: tasks Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org Status: patch Attachment: http://drupal.org/files/issues/db-query_0.patch (2.07 KB) Squeezed out two lines of code after consultation with Karoly. Adds only 10 loc (plus some docs). killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ February 21, 2005 - 13:48 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/db-query.patch (2.16 KB) We should make our database abstraction layer more robust and ensure that module authors can use it without string manipulations inside the query. Several queries use implode() to get their arguments into the query. This is undesirable as we rely on the module author to check the keys and values of such arrays for exploitation attempts. I have created the attached patch which shouldbe able to allow us to not use implode anymore. A minor problem is that all inserted values will be treated as strings. This might be a problem with PostgreSQL at least. However, the same strategy is already used in Drupal core without any complaints I know of. Summary: This patch will alow us to simplify some code in node.module, user.module, taxonomy.module and probably others. ------------------------------------------------------------------------ February 21, 2005 - 18:03 : killes(a)www.drop.org It's a patch. -- View: http://drupal.org/node/17656 Edit: http://drupal.org/project/comments/add/17656

1 0

[drupal-devel] [task] Extend db_query()
by killes 21 Feb '05

21 Feb '05

Project: Drupal Version: cvs Component: database system Category: tasks Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org -Status: active +Status: patch It's a patch. killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ February 21, 2005 - 13:48 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/db-query.patch (2.16 KB) We should make our database abstraction layer more robust and ensure that module authors can use it without string manipulations inside the query. Several queries use implode() to get their arguments into the query. This is undesirable as we rely on the module author to check the keys and values of such arrays for exploitation attempts. I have created the attached patch which shouldbe able to allow us to not use implode anymore. A minor problem is that all inserted values will be treated as strings. This might be a problem with PostgreSQL at least. However, the same strategy is already used in Drupal core without any complaints I know of. Summary: This patch will alow us to simplify some code in node.module, user.module, taxonomy.module and probably others. -- View: http://drupal.org/node/17656 Edit: http://drupal.org/project/comments/add/17656

1 0

[drupal-devel] node_access_where_sql()
by Chris Cook 21 Feb '05

21 Feb '05

I'm debugging an issue in the project module on Drupal cvs. Most node queries use the node_access_where_sql() function like so. "SELECT foo FROM bar WHERE " . node_access_where_sql() . " AND criteria = true" However, the first test in the function returns nothing which will obviously result in an invalid query. Shouldn't the function return a value of "0" or something so that queries will always be valid? http://drupaldocs.org/api/head/function/node_access_where_sql

5 6

[drupal-devel] CVS log messages
by Tim Altman 21 Feb '05

21 Feb '05

Greetings, Did the CVS log message mails get turned off? I haven't seen one on the list since February 7th and I didn't see a post about any changes. I checked out the CVS RSS feed, but it doesn't show the changed files, so it's a bit difficult to tell what the log messages are referring to. -- Tim Altman

1 0

[drupal-devel] db_rewrite_sql handbook update
by Negyesi Karoly 21 Feb '05

21 Feb '05

If you have a module which queries the node table or implements a node type and holds the information in its own table with a nid field, then the following applies. The functions node_access_join_sql() and node_access_where_sql() should not be used any more but the SELECT-queries should be wrapped in a db_rewrite_sql() call. If you have used DISTINCT(nid) -- because of node_access_join_sql() -- you no longer need it, replace it simply with n.nid. If you have SELECT *, please replace it with SELECT n.nid, n.* -- this way the db_rewrite_sql() function can rewrite the query to use DISTINCT(nid) should there be a need for it. Always use table name before the field names, especially before nid because other tables may be JOINed during the rewrite process. Example: <?php // Drupal 4.5: $nodes = db_query_range('SELECT DISTINCT(n.nid) FROM {node} n '. node_access_join_sql() .' WHERE '. node_access_where_sql() .' AND n.promote = 1 AND n.status = 1 ORDER BY n.created DESC', 0, 15); // Drupal 4.6: $nodes = db_query_range(db_rewrite_sql('SELECT n.nid FROM {node} n WHERE n.promote = 1 AND n.status = 1 ORDER BY n.created DESC'), 0, 15); ?> If you are not using the node table, then you shall pass the table name from which you SELECTing the nodes. For example <?php $result = db_query(db_rewrite_sql("SELECT f.nid, f.* from {files} f WHERE filepath = '%s'", 'f'), $file); ?> note the 'f' parameter of db_rewrite_sql().

1 0

[drupal-devel] [task] usability: Group user related menu items more logically +fix help text links
by andremolnar 21 Feb '05

21 Feb '05

Project: Drupal Version: cvs Component: user system Category: tasks Priority: normal Assigned to: Anonymous Reported by: andremolnar Updated by: andremolnar Status: patch Attachment: http://drupal.org/files/issues/user_module_1.patch (10.64 KB) As per the discussion at: http://lists.drupal.org/archives/drupal-devel/2005-02/msg00302.html (settings inconsistencies) This patch implements the suggestions show in the screenshot (found in the link above). It also adjusts a few coding convention inconsistencies that I have noticed (e.g. unnecissary passing of form [edit] data between functions) Though more code could be cleaned in user module this was just a start to meet the primary goals of this patch. Finally the help text found in hook_help are now linked properly with their associated pages, and links within the text now take you to the proper pages. Dries: if you would like to test drive this on my demo site, contact me and I can set you up with an admin account. Other testers are welcome. andre andremolnar -- View: http://drupal.org/node/17025 Edit: http://drupal.org/project/comments/add/17025

2 2