April 2005 - Development - lists.drupal.org

[drupal-devel] [task] improve theme system
by Bèr Kessels 29 Apr '05

29 Apr '05

Issue status update for http://drupal.org/node/21517 Project: Drupal Version: cvs Component: theme system Category: tasks Priority: normal Assigned to: stefan nagtegaal Reported by: stefan nagtegaal Updated by: Bèr Kessels Status: patch and another +1 Bèr Kessels Previous comments: ------------------------------------------------------------------------ April 28, 2005 - 17:21 : stefan nagtegaal The theme system is very inconsistent and not clean. In a steady stream of patches i'll try to make the theme system clean and let most of the theme functions behave the same.. One of the main goals is, that when writing themes in PHPTemplate for example, the way how things are being returned is different from theme function to theme function.. Let's try to unify this, so theming will be more efficient, simpler and more consistent.. ------------------------------------------------------------------------ April 28, 2005 - 17:40 : stefan nagtegaal Attachment: http://drupal.org/files/issues/cleaner_themable_help.patch (1.99 KB) The attached patch does: - remove unused function theme_help() and theme_error(); - added a wrapper function drupal_get_help() inside common.inc (for consistency with drupal_get_title(), drupal_get_breadcrumb(), etc); - reimplemented theme_help(), only this time for a more consistent way for themers; This patch makes it easier to theme the page specific helptexts for drupal. To change your PHP-based themes, you can do: <?php - if ($help = menu_get_active_help()) { - $output .= '<small>'. $help .'</small><hr />'; - } + $output .= theme('help', drupal_get_help()); ?> To change your PHP-Template based theme: <?php if ($help): ?> <?php print $help; ?> <?php endif; ?> becomes a simple: <?php print $help; ?> If this patch is accepted i'll try to make the functions for returning the local tasks and the status messages behave the same.. Overriding the <div class="help">...</div> could be done through deifinig your own theme_help() function in your theme or template.php file. ------------------------------------------------------------------------ April 28, 2005 - 17:44 : dikini +1 from me it makes help text themeable it uses semantic markup, which is good practice, or as some say the Right Way ------------------------------------------------------------------------ April 28, 2005 - 18:00 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/cleaner_themable_help_0.patch (1.99 KB) The patch had DOS line endings and wouldn't apply. I fully support this patch. +1 ------------------------------------------------------------------------ April 28, 2005 - 19:38 : adrian I completely +1 this. ------------------------------------------------------------------------ April 28, 2005 - 22:07 : stefan nagtegaal Attachment: http://drupal.org/files/issues/phptemplate_drupal_get_help.patch (816 bytes) Because Adrian +1's this, his reward is a proper patch against PHPTemplate, sorry I forgot this one... here it is, a really simple one liner which does the job... <?php Index: phptemplate.engine =================================================================== RCS file: /cvs/drupal/contributions/theme-engines/phptemplate/phptemplate.engine,v retrieving revision 1.24.2.1 diff -u -F^f -r1.24.2.1 phptemplate.engine --- phptemplate.engine 23 Apr 2005 01:04:53 -0000 1.24.2.1 +++ phptemplate.engine 28 Apr 2005 21:03:59 -0000 @@ -219,7 +219,7 @@ function phptemplate_page($content) { 'tabs' => theme('menu_local_tasks'), 'messages' => theme_status_messages(), 'layout' => $layout, - 'help' => menu_get_active_help(), + 'help' => theme('help', drupal_get_help()), 'styles' => theme_get_styles(), 'mission' => $mission, 'is_front' => $frontpage, ?> ------------------------------------------------------------------------ April 28, 2005 - 22:35 : walkah looks good to me. +1 ------------------------------------------------------------------------ April 28, 2005 - 22:45 : chx +1.

1 0

[drupal-devel] Wrap every function call in module_invoke
by Karoly Negyesi 29 Apr '05

29 Apr '05

Hi! I put split.php into my sandbox (contributions/sandbox/chx/) which wraps every module-defined function call for all modules in m(). It's a bit rough, mkdir calls are missing, but for testing it's OK. Drop it into your Drupal installation directory, create files/modules and let it go. I have copied module_invoke and named it m() -- if someone needs, I can roll a patch ;) I have tried a little ab and I have measured about 3% percent of performance loss: Time per request: 5846.368 [ms] (mean) Time per request: 1169.274 [ms] (mean, across all concurrent requests) Time per request: 6033.208 [ms] (mean) Time per request: 1206.642 [ms] (mean, across all concurrent requests) However, I think it worths it. As some of you know, I am planning to introduce a "split" mode so only those functions are loaded which are called. This will surely cure memory limit problems. I do not yet know about peformance -- we'll have a lot of small .inc files which needs to be read instead of a few huges one, but the total amount of read is a lot smaller and the parsing will be lot less. We shall see. Second, if we want to, we can be _real_ modular after this: every function can be "overwritten" this way if we define say module_overwrites_originalfunctionname to be an overwrite of originalfunctionname and get module_invoke to the overwrite. If we think it does not worth it then it could be a contrib project after all.

1 0

[drupal-devel] [bug] admin/node/book produces a blank page
by puregin 29 Apr '05

29 Apr '05

Issue status update for http://drupal.org/node/21441 Project: Drupal Version: cvs Component: book.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: moshe weitzman Updated by: puregin -Status: active +Status: patch Attachment: http://drupal.org/files/issues/book.module_blank_admin_page.patch (488 bytes) The function book_admin_view() does not return a non-empty string if $nid is zero, which is the default value if /admin/node/book is visited. The attached patch returns 'No book selected.'. There's probably a better way to do this. puregin Previous comments: ------------------------------------------------------------------------ April 27, 2005 - 11:20 : moshe weitzman probably a result of the recent patch where we return content instead of print.

1 0

[drupal-devel] [task] improve theme system
by chx 28 Apr '05

28 Apr '05

Issue status update for http://drupal.org/node/21517 Project: Drupal Version: cvs Component: theme system Category: tasks Priority: normal Assigned to: stefan nagtegaal Reported by: stefan nagtegaal Updated by: chx Status: patch +1. chx Previous comments: ------------------------------------------------------------------------ April 28, 2005 - 17:21 : stefan nagtegaal The theme system is very inconsistent and not clean. In a steady stream of patches i'll try to make the theme system clean and let most of the theme functions behave the same.. One of the main goals is, that when writing themes in PHPTemplate for example, the way how things are being returned is different from theme function to theme function.. Let's try to unify this, so theming will be more efficient, simpler and more consistent.. ------------------------------------------------------------------------ April 28, 2005 - 17:40 : stefan nagtegaal Attachment: http://drupal.org/files/issues/cleaner_themable_help.patch (1.99 KB) The attached patch does: - remove unused function theme_help() and theme_error(); - added a wrapper function drupal_get_help() inside common.inc (for consistency with drupal_get_title(), drupal_get_breadcrumb(), etc); - reimplemented theme_help(), only this time for a more consistent way for themers; This patch makes it easier to theme the page specific helptexts for drupal. To change your PHP-based themes, you can do: <?php - if ($help = menu_get_active_help()) { - $output .= '<small>'. $help .'</small><hr />'; - } + $output .= theme('help', drupal_get_help()); ?> To change your PHP-Template based theme: <?php if ($help): ?> <?php print $help; ?> <?php endif; ?> becomes a simple: <?php print $help; ?> If this patch is accepted i'll try to make the functions for returning the local tasks and the status messages behave the same.. Overriding the <div class="help">...</div> could be done through deifinig your own theme_help() function in your theme or template.php file. ------------------------------------------------------------------------ April 28, 2005 - 17:44 : dikini +1 from me it makes help text themeable it uses semantic markup, which is good practice, or as some say the Right Way ------------------------------------------------------------------------ April 28, 2005 - 18:00 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/cleaner_themable_help_0.patch (1.99 KB) The patch had DOS line endings and wouldn't apply. I fully support this patch. +1 ------------------------------------------------------------------------ April 28, 2005 - 19:38 : adrian I completely +1 this. ------------------------------------------------------------------------ April 28, 2005 - 22:07 : stefan nagtegaal Attachment: http://drupal.org/files/issues/phptemplate_drupal_get_help.patch (816 bytes) Because Adrian +1's this, his reward is a proper patch against PHPTemplate, sorry I forgot this one... here it is, a really simple one liner which does the job... <?php Index: phptemplate.engine =================================================================== RCS file: /cvs/drupal/contributions/theme-engines/phptemplate/phptemplate.engine,v retrieving revision 1.24.2.1 diff -u -F^f -r1.24.2.1 phptemplate.engine --- phptemplate.engine 23 Apr 2005 01:04:53 -0000 1.24.2.1 +++ phptemplate.engine 28 Apr 2005 21:03:59 -0000 @@ -219,7 +219,7 @@ function phptemplate_page($content) { 'tabs' => theme('menu_local_tasks'), 'messages' => theme_status_messages(), 'layout' => $layout, - 'help' => menu_get_active_help(), + 'help' => theme('help', drupal_get_help()), 'styles' => theme_get_styles(), 'mission' => $mission, 'is_front' => $frontpage, ?> ------------------------------------------------------------------------ April 28, 2005 - 22:35 : walkah looks good to me. +1

1 0

[drupal-devel] [task] improve theme system
by walkah 28 Apr '05

28 Apr '05

Issue status update for http://drupal.org/node/21517 Project: Drupal Version: cvs Component: theme system Category: tasks Priority: normal Assigned to: stefan nagtegaal Reported by: stefan nagtegaal Updated by: walkah Status: patch looks good to me. +1 walkah Previous comments: ------------------------------------------------------------------------ April 28, 2005 - 11:21 : stefan nagtegaal The theme system is very inconsistent and not clean. In a steady stream of patches i'll try to make the theme system clean and let most of the theme functions behave the same.. One of the main goals is, that when writing themes in PHPTemplate for example, the way how things are being returned is different from theme function to theme function.. Let's try to unify this, so theming will be more efficient, simpler and more consistent.. ------------------------------------------------------------------------ April 28, 2005 - 11:40 : stefan nagtegaal Attachment: http://drupal.org/files/issues/cleaner_themable_help.patch (1.99 KB) The attached patch does: - remove unused function theme_help() and theme_error(); - added a wrapper function drupal_get_help() inside common.inc (for consistency with drupal_get_title(), drupal_get_breadcrumb(), etc); - reimplemented theme_help(), only this time for a more consistent way for themers; This patch makes it easier to theme the page specific helptexts for drupal. To change your PHP-based themes, you can do: <?php - if ($help = menu_get_active_help()) { - $output .= '<small>'. $help .'</small><hr />'; - } + $output .= theme('help', drupal_get_help()); ?> To change your PHP-Template based theme: <?php if ($help): ?> <?php print $help; ?> <?php endif; ?> becomes a simple: <?php print $help; ?> If this patch is accepted i'll try to make the functions for returning the local tasks and the status messages behave the same.. Overriding the <div class="help">...</div> could be done through deifinig your own theme_help() function in your theme or template.php file. ------------------------------------------------------------------------ April 28, 2005 - 11:44 : dikini +1 from me it makes help text themeable it uses semantic markup, which is good practice, or as some say the Right Way ------------------------------------------------------------------------ April 28, 2005 - 12:00 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/cleaner_themable_help_0.patch (1.99 KB) The patch had DOS line endings and wouldn't apply. I fully support this patch. +1 ------------------------------------------------------------------------ April 28, 2005 - 13:38 : adrian I completely +1 this. ------------------------------------------------------------------------ April 28, 2005 - 16:07 : stefan nagtegaal Attachment: http://drupal.org/files/issues/phptemplate_drupal_get_help.patch (816 bytes) Because Adrian +1's this, his reward is a proper patch against PHPTemplate, sorry I forgot this one... here it is, a really simple one liner which does the job... <?php Index: phptemplate.engine =================================================================== RCS file: /cvs/drupal/contributions/theme-engines/phptemplate/phptemplate.engine,v retrieving revision 1.24.2.1 diff -u -F^f -r1.24.2.1 phptemplate.engine --- phptemplate.engine 23 Apr 2005 01:04:53 -0000 1.24.2.1 +++ phptemplate.engine 28 Apr 2005 21:03:59 -0000 @@ -219,7 +219,7 @@ function phptemplate_page($content) { 'tabs' => theme('menu_local_tasks'), 'messages' => theme_status_messages(), 'layout' => $layout, - 'help' => menu_get_active_help(), + 'help' => theme('help', drupal_get_help()), 'styles' => theme_get_styles(), 'mission' => $mission, 'is_front' => $frontpage, ?>

1 0

[drupal-devel] [task] improve theme system
by stefan nagtegaal 28 Apr '05

28 Apr '05

Issue status update for http://drupal.org/node/21517 Project: Drupal Version: cvs Component: theme system Category: tasks Priority: normal Assigned to: stefan nagtegaal Reported by: stefan nagtegaal Updated by: stefan nagtegaal Status: patch Attachment: http://drupal.org/files/issues/phptemplate_drupal_get_help.patch (816 bytes) Because Adrian +1's this, his reward is a proper patch against PHPTemplate, sorry I forgot this one... here it is, a really simple one liner which does the job... <?php Index: phptemplate.engine =================================================================== RCS file: /cvs/drupal/contributions/theme-engines/phptemplate/phptemplate.engine,v retrieving revision 1.24.2.1 diff -u -F^f -r1.24.2.1 phptemplate.engine --- phptemplate.engine 23 Apr 2005 01:04:53 -0000 1.24.2.1 +++ phptemplate.engine 28 Apr 2005 21:03:59 -0000 @@ -219,7 +219,7 @@ function phptemplate_page($content) { 'tabs' => theme('menu_local_tasks'), 'messages' => theme_status_messages(), 'layout' => $layout, - 'help' => menu_get_active_help(), + 'help' => theme('help', drupal_get_help()), 'styles' => theme_get_styles(), 'mission' => $mission, 'is_front' => $frontpage, ?> stefan nagtegaal Previous comments: ------------------------------------------------------------------------ April 28, 2005 - 18:21 : stefan nagtegaal The theme system is very inconsistent and not clean. In a steady stream of patches i'll try to make the theme system clean and let most of the theme functions behave the same.. One of the main goals is, that when writing themes in PHPTemplate for example, the way how things are being returned is different from theme function to theme function.. Let's try to unify this, so theming will be more efficient, simpler and more consistent.. ------------------------------------------------------------------------ April 28, 2005 - 18:40 : stefan nagtegaal Attachment: http://drupal.org/files/issues/cleaner_themable_help.patch (1.99 KB) The attached patch does: - remove unused function theme_help() and theme_error(); - added a wrapper function drupal_get_help() inside common.inc (for consistency with drupal_get_title(), drupal_get_breadcrumb(), etc); - reimplemented theme_help(), only this time for a more consistent way for themers; This patch makes it easier to theme the page specific helptexts for drupal. To change your PHP-based themes, you can do: <?php - if ($help = menu_get_active_help()) { - $output .= '<small>'. $help .'</small><hr />'; - } + $output .= theme('help', drupal_get_help()); ?> To change your PHP-Template based theme: <?php if ($help): ?> <?php print $help; ?> <?php endif; ?> becomes a simple: <?php print $help; ?> If this patch is accepted i'll try to make the functions for returning the local tasks and the status messages behave the same.. Overriding the <div class="help">...</div> could be done through deifinig your own theme_help() function in your theme or template.php file. ------------------------------------------------------------------------ April 28, 2005 - 18:44 : dikini +1 from me it makes help text themeable it uses semantic markup, which is good practice, or as some say the Right Way ------------------------------------------------------------------------ April 28, 2005 - 19:00 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/cleaner_themable_help_0.patch (1.99 KB) The patch had DOS line endings and wouldn't apply. I fully support this patch. +1 ------------------------------------------------------------------------ April 28, 2005 - 20:38 : adrian I completely +1 this.

1 0

[drupal-devel] [task] improve theme system
by adrian 28 Apr '05

28 Apr '05

Issue status update for http://drupal.org/node/21517 Project: Drupal Version: cvs Component: theme system Category: tasks Priority: normal Assigned to: stefan nagtegaal Reported by: stefan nagtegaal Updated by: adrian Status: patch I completely +1 this. adrian Previous comments: ------------------------------------------------------------------------ April 28, 2005 - 18:21 : stefan nagtegaal The theme system is very inconsistent and not clean. In a steady stream of patches i'll try to make the theme system clean and let most of the theme functions behave the same.. One of the main goals is, that when writing themes in PHPTemplate for example, the way how things are being returned is different from theme function to theme function.. Let's try to unify this, so theming will be more efficient, simpler and more consistent.. ------------------------------------------------------------------------ April 28, 2005 - 18:40 : stefan nagtegaal Attachment: http://drupal.org/files/issues/cleaner_themable_help.patch (1.99 KB) The attached patch does: - remove unused function theme_help() and theme_error(); - added a wrapper function drupal_get_help() inside common.inc (for consistency with drupal_get_title(), drupal_get_breadcrumb(), etc); - reimplemented theme_help(), only this time for a more consistent way for themers; This patch makes it easier to theme the page specific helptexts for drupal. To change your PHP-based themes, you can do: <?php - if ($help = menu_get_active_help()) { - $output .= '<small>'. $help .'</small><hr />'; - } + $output .= theme('help', drupal_get_help()); ?> To change your PHP-Template based theme: <?php if ($help): ?> <?php print $help; ?> <?php endif; ?> becomes a simple: <?php print $help; ?> If this patch is accepted i'll try to make the functions for returning the local tasks and the status messages behave the same.. Overriding the <div class="help">...</div> could be done through deifinig your own theme_help() function in your theme or template.php file. ------------------------------------------------------------------------ April 28, 2005 - 18:44 : dikini +1 from me it makes help text themeable it uses semantic markup, which is good practice, or as some say the Right Way ------------------------------------------------------------------------ April 28, 2005 - 19:00 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/cleaner_themable_help_0.patch (1.99 KB) The patch had DOS line endings and wouldn't apply. I fully support this patch. +1

1 0

[drupal-devel] [task] Make posting permission more granular.
by Gerhard Killesreiter 28 Apr '05

28 Apr '05

Issue status update for http://drupal.org/node/10426 Project: Drupal Version: cvs Component: comment.module Category: tasks Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: Gerhard Killesreiter Status: patch menesis, thanks for looking at the patch! Currently, we have two ways to determine permissions for a node. One is the general node_access function and one is the node specific function (eg book_access). I have implemented the comment permission check through the latter. This has two reasons: It does not change the current behaviour for those modules and it does not require database queries. I am open for discussion on it. Gerhard Killesreiter Previous comments: ------------------------------------------------------------------------ August 29, 2004 - 06:55 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/node-access-comment.patch (5 KB) There have been requests to private forums. I think the most straightforward way to allow them is by extending the node_access hook. The attached patch tries this. It assumes that my node object caching patch got committed. Afterwards loading a node twice won't be a performance issue anymore. The patch is untested, I'd like to get feedback on the implementation. ------------------------------------------------------------------------ August 31, 2004 - 16:53 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/node-access-comment_0.patch (5.02 KB) The patch is now tested. I think this needs a better explanations: The patch isn't only for forums (which still need some kind of taxonomy permissions) but applies to all nodes. You can set individual nodes to be commentable through the _access hook. This would be helpfull for a forum where only a selected role should be allowed to post, but others should read the announcements. ------------------------------------------------------------------------ September 4, 2004 - 08:57 : killes(a)www.drop.org The patch has a small problem: We need either to move this check <?php if ($op == 'comment' && $node->comment == 2 && user_access('post comments')) { return TRUE; } ?> before the db query (and thus taking away a bit of the power from that patch) or add a grant_comment column to the node_access table: alter table node_access add grant_comment tinyint(1) unsigned NOT NULL default '0'; ------------------------------------------------------------------------ September 5, 2004 - 10:42 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/node-access-comment_0_0.patch (4.78 KB) Keeping up with CVS. I'd like to receive some feedback on the resolution of the problme mentioned above. ------------------------------------------------------------------------ September 13, 2004 - 02:25 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/module_0.patch (7.1 KB) Keeping up with cvs. Node modules should implement _access('comment'). ------------------------------------------------------------------------ September 14, 2004 - 06:38 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/commentable.patch (7.89 KB) Had forgotten blog.module ------------------------------------------------------------------------ February 5, 2005 - 00:19 : Steven Is this patch still needed? Doesn't it tie comment.module unnecessarily into node.module? ------------------------------------------------------------------------ February 8, 2005 - 00:01 : killes(a)www.drop.org Yes, the patch is still needed. The patch actually removes more code from node.module than it adds. Both modules are essential to Drupal and some degree of interaction is tolerable, I think. You can still disable comment.module withou any ill effects. ------------------------------------------------------------------------ April 26, 2005 - 21:07 : Cvbge Hello I need to be able to a) post/reply etc on forums as anonymous user b) do not anon users to edit it's own (probably made by other anon users) forum posts c) do not allow anyone to post comments to any other node types AFAIK currently it's not possibile, but it'd be possibile with this patch, so I'd be glad it it was accepted. ------------------------------------------------------------------------ April 27, 2005 - 15:35 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/commentable_0.patch (8.85 KB) Updated patch. Note that the db upgrade path is missing. I'll add that after my revisions patch got committed. ------------------------------------------------------------------------ April 28, 2005 - 17:26 : menesis The patch looks strange to me, because of such changes in each module: <?php if ($op == 'comment') { if (user_access('post comments') && $node->comment == 2) { return TRUE; } } ?> They are not needed. I think they even negate the other parts of the patch, by always allowing to comment those node types. Usually hook_access deals only with permissions defined by that module, and not mess with other permissions, node module handles those anyway. So node-access-comment_0.patch [1] looks better than later patches, except the above last hunk in node.module. I might be wrong, and I haven't tested it... A big change and access modules need to be modified too... [1] http://drupal.org/files/issues/node-access-comment_0.patch

1 0

[drupal-devel] [task] Make posting permission more granular.
by menesis 28 Apr '05

28 Apr '05

Issue status update for http://drupal.org/node/10426 Project: Drupal Version: cvs Component: comment.module Category: tasks Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: menesis Status: patch The patch looks strange to me, because of such changes in each module: <?php if ($op == 'comment') { if (user_access('post comments') && $node->comment == 2) { return TRUE; } } ?> They are not needed. I think they even negate the other parts of the patch, by always allowing to comment those node types. Usually hook_access deals only with permissions defined by that module, and not mess with other permissions, node module handles those anyway. So node-access-comment_0.patch [1] looks better than later patches, except the above last hunk in node.module. I might be wrong, and I haven't tested it... A big change and access modules need to be modified too... [1] http://drupal.org/files/issues/node-access-comment_0.patch menesis Previous comments: ------------------------------------------------------------------------ August 29, 2004 - 09:55 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/node-access-comment.patch (5 KB) There have been requests to private forums. I think the most straightforward way to allow them is by extending the node_access hook. The attached patch tries this. It assumes that my node object caching patch got committed. Afterwards loading a node twice won't be a performance issue anymore. The patch is untested, I'd like to get feedback on the implementation. ------------------------------------------------------------------------ August 31, 2004 - 19:53 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/node-access-comment_0.patch (5.02 KB) The patch is now tested. I think this needs a better explanations: The patch isn't only for forums (which still need some kind of taxonomy permissions) but applies to all nodes. You can set individual nodes to be commentable through the _access hook. This would be helpfull for a forum where only a selected role should be allowed to post, but others should read the announcements. ------------------------------------------------------------------------ September 4, 2004 - 11:57 : killes(a)www.drop.org The patch has a small problem: We need either to move this check <?php if ($op == 'comment' && $node->comment == 2 && user_access('post comments')) { return TRUE; } ?> before the db query (and thus taking away a bit of the power from that patch) or add a grant_comment column to the node_access table: alter table node_access add grant_comment tinyint(1) unsigned NOT NULL default '0'; ------------------------------------------------------------------------ September 5, 2004 - 13:42 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/node-access-comment_0_0.patch (4.78 KB) Keeping up with CVS. I'd like to receive some feedback on the resolution of the problme mentioned above. ------------------------------------------------------------------------ September 13, 2004 - 05:25 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/module_0.patch (7.1 KB) Keeping up with cvs. Node modules should implement _access('comment'). ------------------------------------------------------------------------ September 14, 2004 - 09:38 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/commentable.patch (7.89 KB) Had forgotten blog.module ------------------------------------------------------------------------ February 5, 2005 - 03:19 : Steven Is this patch still needed? Doesn't it tie comment.module unnecessarily into node.module? ------------------------------------------------------------------------ February 8, 2005 - 03:01 : killes(a)www.drop.org Yes, the patch is still needed. The patch actually removes more code from node.module than it adds. Both modules are essential to Drupal and some degree of interaction is tolerable, I think. You can still disable comment.module withou any ill effects. ------------------------------------------------------------------------ April 27, 2005 - 00:07 : Cvbge Hello I need to be able to a) post/reply etc on forums as anonymous user b) do not anon users to edit it's own (probably made by other anon users) forum posts c) do not allow anyone to post comments to any other node types AFAIK currently it's not possibile, but it'd be possibile with this patch, so I'd be glad it it was accepted. ------------------------------------------------------------------------ April 27, 2005 - 18:35 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/commentable_0.patch (8.85 KB) Updated patch. Note that the db upgrade path is missing. I'll add that after my revisions patch got committed.

1 0

[drupal-devel] [task] improve theme system
by killes 28 Apr '05

28 Apr '05

Issue status update for http://drupal.org/node/21517 Project: Drupal Version: cvs Component: theme system Category: tasks Priority: normal Assigned to: stefan nagtegaal Reported by: stefan nagtegaal Updated by: killes(a)www.drop.org Status: patch Attachment: http://drupal.org/files/issues/cleaner_themable_help_0.patch (1.99 KB) The patch had DOS line endings and wouldn't apply. I fully support this patch. +1 killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ April 28, 2005 - 17:21 : stefan nagtegaal The theme system is very inconsistent and not clean. In a steady stream of patches i'll try to make the theme system clean and let most of the theme functions behave the same.. One of the main goals is, that when writing themes in PHPTemplate for example, the way how things are being returned is different from theme function to theme function.. Let's try to unify this, so theming will be more efficient, simpler and more consistent.. ------------------------------------------------------------------------ April 28, 2005 - 17:40 : stefan nagtegaal Attachment: http://drupal.org/files/issues/cleaner_themable_help.patch (1.99 KB) The attached patch does: - remove unused function theme_help() and theme_error(); - added a wrapper function drupal_get_help() inside common.inc (for consistency with drupal_get_title(), drupal_get_breadcrumb(), etc); - reimplemented theme_help(), only this time for a more consistent way for themers; This patch makes it easier to theme the page specific helptexts for drupal. To change your PHP-based themes, you can do: <?php - if ($help = menu_get_active_help()) { - $output .= '<small>'. $help .'</small><hr />'; - } + $output .= theme('help', drupal_get_help()); ?> To change your PHP-Template based theme: <?php if ($help): ?> <?php print $help; ?> <?php endif; ?> becomes a simple: <?php print $help; ?> If this patch is accepted i'll try to make the functions for returning the local tasks and the status messages behave the same.. Overriding the <div class="help">...</div> could be done through deifinig your own theme_help() function in your theme or template.php file. ------------------------------------------------------------------------ April 28, 2005 - 17:44 : dikini +1 from me it makes help text themeable it uses semantic markup, which is good practice, or as some say the Right Way

1 0