May 2005 - Development - lists.drupal.org

[drupal-devel] Release critical bugs for May 26, 2005
by drupal-devel＠drupal.org 26 May '05

26 May '05

/ bug reports email spam filtering does not "see" email addresses when they are NOT preceded by a word age: 18 weeks 4 days url: http://drupal.org/node/15654 / bug reports "Welcome to Drupal" page won't disappear after first post & proper access permissions age: 5 days 6 hours url: http://drupal.org/node/23296 In some case, "Recent comment" is not linked to THE COMMENT refered to. age: 1 week 14 hours url: http://drupal.org/node/23136 Tagging Issues age: 1 week 2 days url: http://drupal.org/node/23026 Can't submit forum post assigned: mohaqa age: 1 week 2 days url: http://drupal.org/node/22960 Error in TEMP DIRECTORY age: 1 week 3 days url: http://drupal.org/node/22916 PG_QUERY ERROR - LOCK TABLES - IMPLEMENTATION FAULT. age: 1 week 3 days url: http://drupal.org/node/22911 Full path and other information disclosure on DB connect error age: 1 week 4 days url: http://drupal.org/node/22872 Search memory limit problems after 4.6 upgrade age: 2 weeks 1 day url: http://drupal.org/node/22497 Warning: Wrong parameter count for mysql_connect() assigned: jselva(a)drupal.org age: 2 weeks 5 days url: http://drupal.org/node/22188 Podcasting feeds broken age: 3 weeks 1 day url: http://drupal.org/node/21924 Teaser problem assigned: childhood age: 5 weeks 1 day url: http://drupal.org/node/20843 UTF-8 node title gets truncated at wrong position age: 5 weeks 5 days url: http://drupal.org/node/20537 database table "term_node" not updated when removing a term from a node under editing and submitting age: 6 weeks 2 days url: http://drupal.org/node/20315 Attached files can not be deleted age: 6 weeks 2 days url: http://drupal.org/node/20307 Reassigning a node to a different term does not work properly age: 6 weeks 3 days url: http://drupal.org/node/20278 4.6 aggregator showing/not interpreting HTML tags age: 7 weeks 4 days url: http://drupal.org/node/19874 Search ranking broken on pgsql age: 8 weeks 2 days url: http://drupal.org/node/19629 New submit error, non-admin user, postgresql database assigned: adrian age: 11 weeks 1 day url: http://drupal.org/node/18552 When I delete a user, any forum in which s/he has commented also disappears. assigned: Jill6q age: 14 weeks 9 hours url: http://drupal.org/node/17428 OPML Import for Aggregator age: 16 weeks 6 days url: http://drupal.org/node/16282 Change to sesssion.inc violates UID database constraint age: 18 weeks 4 days url: http://drupal.org/node/15666 forum.module problem with postgresql v7.4.1 age: 19 weeks 2 days url: http://drupal.org/node/15411 PHP 5 gives error when session table has no session assigned: adschar age: 19 weeks 2 days url: http://drupal.org/node/15399 postgresql error age: 20 weeks 4 hours url: http://drupal.org/node/15175 Entering an empty title broke drupal age: 27 weeks 2 days url: http://drupal.org/node/12974 Argument NOT must be type boolean age: 27 weeks 2 days url: http://drupal.org/node/12950 Comments in approval queue still show up in tracker age: 31 weeks 4 days url: http://drupal.org/node/11647 Twin problems with comments assigned: Junyor age: 32 weeks 6 days url: http://drupal.org/node/11366 Prevent browser page caching of dynamic content assigned: mathias age: 1 year 14 weeks url: http://drupal.org/node/5900 / feature requests Provide a way to select a term from a vocabulary via a drop down list in a users profile age: 9 hours 54 min url: http://drupal.org/node/23601 Add a footer that is specific to a particular book, shown only on certain pages age: 7 weeks 6 days url: http://drupal.org/node/19757 moving pages en masse age: 7 weeks 6 days url: http://drupal.org/node/19754 Taxonomy module should use nodeapi 'load' age: 11 weeks 8 hours url: http://drupal.org/node/18631 Auto PHP memory maximisation age: 13 weeks 2 days url: http://drupal.org/node/17663 Don't reset existing password on request, prevent DoS password reset abuse age: 15 weeks 3 days url: http://drupal.org/node/16909 User info exposed to anonymous user age: 25 weeks 5 days url: http://drupal.org/node/13545 Allow named anchors to work without specifying full path to node age: 1 year 26 weeks url: http://drupal.org/node/4213 / support requests Please help me out i am stuck here :( assigned: neerajshokeen age: 2 weeks 4 days url: http://drupal.org/node/22227 Fatal error: Unknown column 'headers' in 'field list' query assigned: Eagle-i age: 10 weeks 1 day url: http://drupal.org/node/18928 Strange session behavior age: 10 weeks 3 days url: http://drupal.org/node/18821 user redirected to homepage when logging in age: 11 weeks 5 days url: http://drupal.org/node/18381 Problem with Forums age: 19 weeks 4 days url: http://drupal.org/node/15299 / bug reports search over fields.inc fields conceptual error age: 29 weeks 6 days url: http://drupal.org/node/12259 fields.inc screws up with multible multiselect fields age: 29 weeks 6 days url: http://drupal.org/node/12257 Start Time of Event is NOT Preserved age: 48 weeks 6 days url: http://drupal.org/node/8565 / bug reports Menu item not showing age: 33 weeks 5 days url: http://drupal.org/node/11210 / bug reports segmentation fault related to filestore age: 1 year 34 weeks url: http://drupal.org/node/3001 / support requests File store module - Overwriting Filename....Help needed assigned: harishkm age: 1 year 7 weeks url: http://drupal.org/node/6827 Unserialize error at line 104 age: 1 year 14 weeks url: http://drupal.org/node/5857 Filestore module- sql errors rectified assigned: harishkm age: 1 year 15 weeks url: http://drupal.org/node/5619 Filestore Module Problems unaddressed assigned: harishkm age: 1 year 17 weeks url: http://drupal.org/node/5365 / bug reports Gallery error age: 4 weeks 2 days url: http://drupal.org/node/21290 Fatal Error: variable_get() age: 9 weeks 3 days url: http://drupal.org/node/19189 No Gallery Image Block age: 9 weeks 6 days url: http://drupal.org/node/19045 Mini applet can't find gallery at url / age: 10 weeks 4 days url: http://drupal.org/node/18785 Fatal error: Undefined class name 'galleryembed' age: 13 weeks 1 day url: http://drupal.org/node/17746 / support requests Can't Embed Gallery into Drupal age: 12 weeks 3 days url: http://drupal.org/node/18029 / bug reports Drupal-4.4-rc breaks registration setups and groups.module age: 1 year 10 weeks url: http://drupal.org/node/6392 / bug reports Image module thumbnail/preview stop working after l10n age: 4 weeks 6 days url: http://drupal.org/node/21036 Cannot upload .jpgs age: 12 weeks 3 days url: http://drupal.org/node/18076 Wrongly formed html in image gallery age: 13 weeks 6 days url: http://drupal.org/node/17462 Image.Module does not know the correct filename age: 27 weeks 1 day url: http://drupal.org/node/13032 SAFE MODE Restriction in effect... age: 30 weeks 6 days url: http://drupal.org/node/11843 Uploading jpeg makes Imagemagick do high compression age: 32 weeks 3 days url: http://drupal.org/node/11445 Image module failing on Preview because of a blank node id age: 34 weeks 4 days url: http://drupal.org/node/11069 Similar problem with Directory Upload Slow age: 34 weeks 4 days url: http://drupal.org/node/11064 / support requests path problems on upgrading... age: 3 weeks 3 days url: http://drupal.org/node/21725 / bug reports Please update Node_Aggregator age: 9 weeks 5 days url: http://drupal.org/node/19096 Import doesn't like XML/RSS feeds with no Title element age: 51 weeks 4 days url: http://drupal.org/node/8128 / feature requests RSS items overwriting edited items age: 49 weeks 5 days url: http://drupal.org/node/8455 / bug reports Organic Groups subscription notifications are being sent to *all* group members instead of just group manager age: 3 weeks 4 days url: http://drupal.org/node/21635 / feature requests Notify.module ignores the true submission queue age: 1 year 30 weeks url: http://drupal.org/node/3765 / feature requests Internationalization support for PDF assigned: TheLibrarian age: 1 year 8 weeks url: http://drupal.org/node/6795 / bug reports Date for latest is incorrect age: 5 weeks 6 days url: http://drupal.org/node/20485 Invalid link to release files age: 13 weeks 3 days url: http://drupal.org/node/17625 blank page after install age: 16 weeks 1 day url: http://drupal.org/node/16575 "Page Not Found" when trying to view issues or add new release age: 24 weeks 6 days url: http://drupal.org/node/13815 Project pages display only title and description age: 27 weeks 6 hours url: http://drupal.org/node/13082 Fatal error: Cannot use string offset as an array in includes/tablesort.inc on line 113 assigned: publian age: 33 weeks 6 days url: http://drupal.org/node/11187 Can't create new project with issue tracker age: 40 weeks 21 hours url: http://drupal.org/node/10148 / support requests Help with everything - nothing seems to work in the latest build age: 26 weeks 2 days url: http://drupal.org/node/13310 / bug reports Can't get the inline tag to show series age: 2 weeks 1 day url: http://drupal.org/node/22520 / bug reports MySQL Error age: 8 weeks 6 days url: http://drupal.org/node/19413 javascrip downloads square.gif for every category age: 14 weeks 1 day url: http://drupal.org/node/17366 / bug reports SQL Errors during CRON run assigned: ankur age: 2 weeks 1 min url: http://drupal.org/node/22638 / feature requests Drupal Search usability improvement age: 6 days 21 hours url: http://drupal.org/node/23185

1 0

[drupal-devel] [feature] Add path user/{uid}/content to get a listing of one user's nodes
by robertDouglass 26 May '05

26 May '05

Issue status update for http://drupal.org/node/22183 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: robertDouglass Updated by: robertDouglass Status: patch Attachment: http://drupal.org/files/issues/usernodes.patch.txt (2.27 KB) This creates a new path user/{uid}/content which functions just like node, except it returns only one user's nodes. Minimally intrusive. Hopefully useful. Open to alternate suggestions on the path (should it be a path in the node module?) and the page title (currently "user content"). robertDouglass

7 11

[drupal-devel] [bug] Forum module's use of if in Postgresql
by adrian 26 May '05

26 May '05

Issue status update for http://drupal.org/node/23499 Project: Drupal Version: 4.6.0 Component: forum.module Category: bug reports Priority: normal Assigned to: patrickslee Reported by: cchamilt Updated by: adrian Status: patch hostmaster=# \df nullvalue List of functions Result data type | Schema | Name | Argument data types ------------------+------------+-----------+--------------------- boolean | pg_catalog | nullvalue | "any" But it doesn't matter to me =) adrian Previous comments: ------------------------------------------------------------------------ May 24, 2005 - 06:32 : cchamilt Postgresql function "if" is defined to return a boolean value, yet forum requests an integer - last_comment_uid. user error: query: SELECT n.nid, l.last_comment_timestamp, IF(l.last_comment_uid, cu.name, l.last_comment_name) as last_comment_name, l.last_comment_uid FROM node n, node_comment_statistics l /*! USE INDEX (node_comment_timestamp) */, users cu, term_node r WHERE n.nid = r.nid AND r.tid = 1 AND n.status = 1 AND n.type = 'forum' AND l.last_comment_uid = cu.uid AND n.nid = l.nid ORDER BY l.last_comment_timestamp DESC LIMIT 1 OFFSET 0 in /var/www/hosts/www.ambigc.com/htdocs/includes/database.pgsql.inc on line 62. warning: pg_query() [function.pg-query]: Query failed: ERROR: function if(integer, character varying, character varying) does not exist HINT: No function matches the given name and argument types. You may need to add explicit type casts. in /var/www/hosts/www.ambigc.com/htdocs/includes/database.pgsql.inc on line 45. ------------------------------------------------------------------------ May 25, 2005 - 00:07 : patrickslee Attachment: http://drupal.org/files/issues/forum.module_3.patch (2.69 KB) I have also encountered this bug and made a possible patch by replacing IF statements to CASE. A patch file is attached. ------------------------------------------------------------------------ May 25, 2005 - 00:28 : adrian There is an IF function defined in the database.pgsql function. On what page is this happening, as what might be happening is that the type isn't being picked up correctly. It's defined as IF(anyelement, anyelement, text) returns anyelement. IIRC. What I have seen happen is that it wants the text field to return integer, or vice versa. ------------------------------------------------------------------------ May 25, 2005 - 00:32 : patrickslee I found the definition in database.pgsql. It is like this: CREATE FUNCTION "if"(boolean, anyelement, anyelement) RETURNS anyelement AS ' SELECT CASE WHEN $1 THEN $2 ELSE $3 END; ' LANGUAGE 'sql'; So it is actually wanting boolean. ------------------------------------------------------------------------ May 25, 2005 - 00:43 : patrickslee So my patch will work, and we can make it easier by replacing the IF function to: IF(l.last_comment_uid 0 AND l.last_comment_uid NULL, cu.name, l.last_comment_name) BTW there is another place in forum.module use IF like this. ------------------------------------------------------------------------ May 25, 2005 - 00:45 : patrickslee Oops... my <>s are stolen. IF(l.last_comment_uid <> 0 AND l.last_comment_uid <> NULL, cu.name, l.last_comment_name) ------------------------------------------------------------------------ May 25, 2005 - 07:20 : cchamilt Yes that line works great. Thanks for your help! ------------------------------------------------------------------------ May 25, 2005 - 07:52 : patrickslee This patch shows another problem. The last post user will always show "Anonymous" or whatever you defined. Looking for solution... ------------------------------------------------------------------------ May 25, 2005 - 08:00 : patrickslee Use this line instead: IF(l.last_comment_uid <> 0 AND l.last_comment_uid <> NULL, cu.name, l.last_comment_name) Don't forget there are two places in forum.module need to be changed. ------------------------------------------------------------------------ May 25, 2005 - 08:10 : patrickslee Oh what have I done! I changed nothing! IF(l.last_comment_uid <> 0 AND l.last_comment_uid IS NOT NULL, cu.name, l.last_comment_name) ------------------------------------------------------------------------ May 25, 2005 - 12:12 : adrian perhaps we could also just add more wrapper functions for the specific types ? create or replace function IF (integer, anyelement, anyelement) returns anyelement as ' SELECT if (($1 0) AND NOT nullvalue($1), $2, $3); ' LANGUAGE 'sql'; Or something. ------------------------------------------------------------------------ May 25, 2005 - 12:41 : plj '' was missing. So what adrian actually means is this: CREATE OR REPLACE FUNCTION IF (integer, anyelement, anyelement) RETURNS anyelement AS ' SELECT if (($1 <> 0) AND NOT nullvalue($1), $2, $3); ' LANGUAGE 'sql'; I applied that and now forums work -- no module patches. PostgreSQL 7.4.7. ------------------------------------------------------------------------ May 25, 2005 - 12:45 : plj Sheesh. I meant that '<>' was missing. Gotta learn to use that preview button... ------------------------------------------------------------------------ May 25, 2005 - 23:53 : patrickslee Is nullvalue() a function? I cannot find it in neither postgres manual nor mysql manual. Use "IS NOT NULL" would be better as it is more standard-compatible. SO we have this: CREATE OR REPLACE FUNCTION IF (integer, anyelement, anyelement) RETURNS anyelement AS ' SELECT IF(($1 <> 0) AND $1 IS NOT NULL, $2, $3); ' LANGUAGE 'sql'; Looks we have a satisfying fix here. Is this fix going to be committed in CVS for next release?

1 0

[drupal-devel] [bug] Forum module's use of if in Postgresql
by patrickslee 25 May '05

25 May '05

Issue status update for http://drupal.org/node/23499 Project: Drupal Version: 4.6.0 Component: forum.module Category: bug reports Priority: normal Assigned to: patrickslee Reported by: cchamilt Updated by: patrickslee Status: patch Is nullvalue() a function? I cannot find it in neither postgres manual nor mysql manual. Use "IS NOT NULL" would be better as it is more standard-compatible. SO we have this: CREATE OR REPLACE FUNCTION IF (integer, anyelement, anyelement) RETURNS anyelement AS ' SELECT IF(($1 <> 0) AND $1 IS NOT NULL, $2, $3); ' LANGUAGE 'sql'; Looks we have a satisfying fix here. Is this fix going to be committed in CVS for next release? patrickslee Previous comments: ------------------------------------------------------------------------ May 24, 2005 - 16:32 : cchamilt Postgresql function "if" is defined to return a boolean value, yet forum requests an integer - last_comment_uid. user error: query: SELECT n.nid, l.last_comment_timestamp, IF(l.last_comment_uid, cu.name, l.last_comment_name) as last_comment_name, l.last_comment_uid FROM node n, node_comment_statistics l /*! USE INDEX (node_comment_timestamp) */, users cu, term_node r WHERE n.nid = r.nid AND r.tid = 1 AND n.status = 1 AND n.type = 'forum' AND l.last_comment_uid = cu.uid AND n.nid = l.nid ORDER BY l.last_comment_timestamp DESC LIMIT 1 OFFSET 0 in /var/www/hosts/www.ambigc.com/htdocs/includes/database.pgsql.inc on line 62. warning: pg_query() [function.pg-query]: Query failed: ERROR: function if(integer, character varying, character varying) does not exist HINT: No function matches the given name and argument types. You may need to add explicit type casts. in /var/www/hosts/www.ambigc.com/htdocs/includes/database.pgsql.inc on line 45. ------------------------------------------------------------------------ May 25, 2005 - 10:07 : patrickslee Attachment: http://drupal.org/files/issues/forum.module_3.patch (2.69 KB) I have also encountered this bug and made a possible patch by replacing IF statements to CASE. A patch file is attached. ------------------------------------------------------------------------ May 25, 2005 - 10:28 : adrian There is an IF function defined in the database.pgsql function. On what page is this happening, as what might be happening is that the type isn't being picked up correctly. It's defined as IF(anyelement, anyelement, text) returns anyelement. IIRC. What I have seen happen is that it wants the text field to return integer, or vice versa. ------------------------------------------------------------------------ May 25, 2005 - 10:32 : patrickslee I found the definition in database.pgsql. It is like this: CREATE FUNCTION "if"(boolean, anyelement, anyelement) RETURNS anyelement AS ' SELECT CASE WHEN $1 THEN $2 ELSE $3 END; ' LANGUAGE 'sql'; So it is actually wanting boolean. ------------------------------------------------------------------------ May 25, 2005 - 10:43 : patrickslee So my patch will work, and we can make it easier by replacing the IF function to: IF(l.last_comment_uid 0 AND l.last_comment_uid NULL, cu.name, l.last_comment_name) BTW there is another place in forum.module use IF like this. ------------------------------------------------------------------------ May 25, 2005 - 10:45 : patrickslee Oops... my <>s are stolen. IF(l.last_comment_uid <> 0 AND l.last_comment_uid <> NULL, cu.name, l.last_comment_name) ------------------------------------------------------------------------ May 25, 2005 - 17:20 : cchamilt Yes that line works great. Thanks for your help! ------------------------------------------------------------------------ May 25, 2005 - 17:52 : patrickslee This patch shows another problem. The last post user will always show "Anonymous" or whatever you defined. Looking for solution... ------------------------------------------------------------------------ May 25, 2005 - 18:00 : patrickslee Use this line instead: IF(l.last_comment_uid <> 0 AND l.last_comment_uid <> NULL, cu.name, l.last_comment_name) Don't forget there are two places in forum.module need to be changed. ------------------------------------------------------------------------ May 25, 2005 - 18:10 : patrickslee Oh what have I done! I changed nothing! IF(l.last_comment_uid <> 0 AND l.last_comment_uid IS NOT NULL, cu.name, l.last_comment_name) ------------------------------------------------------------------------ May 25, 2005 - 22:12 : adrian perhaps we could also just add more wrapper functions for the specific types ? create or replace function IF (integer, anyelement, anyelement) returns anyelement as ' SELECT if (($1 0) AND NOT nullvalue($1), $2, $3); ' LANGUAGE 'sql'; Or something. ------------------------------------------------------------------------ May 25, 2005 - 22:41 : plj '' was missing. So what adrian actually means is this: CREATE OR REPLACE FUNCTION IF (integer, anyelement, anyelement) RETURNS anyelement AS ' SELECT if (($1 <> 0) AND NOT nullvalue($1), $2, $3); ' LANGUAGE 'sql'; I applied that and now forums work -- no module patches. PostgreSQL 7.4.7. ------------------------------------------------------------------------ May 25, 2005 - 22:45 : plj Sheesh. I meant that '<>' was missing. Gotta learn to use that preview button...

1 0

[drupal-devel] [bug] Multiple Error IN DATABASE.PGSQL
by Cvbge 25 May '05

25 May '05

Issue status update for http://drupal.org/node/22909 Project: Drupal Version: cvs Component: postgresql database Category: bug reports Priority: critical Assigned to: Anonymous Reported by: kinai Updated by: Cvbge -Status: active +Status: patch Attachment: http://drupal.org/files/issues/database.pgsql.diff (1010 bytes) Attached patch should fix all errors. Cvbge Previous comments: ------------------------------------------------------------------------ May 15, 2005 - 15:33 : kinai Hello, Since my last post, i've updated my installation. database.pgsql contain multiple error : psql:database.pgsql:206: ERROR: the type «longtext» does not exist psql:database.pgsql:512: ERROR: syntax error on or near «CREATE» at character 46 psql:database.pgsql:513: ERROR: the relation «permission» does not exist psql:database.pgsql:703: ERROR: The column «changed» does not exist psql:database.pgsql:797: ERROR: The relation «permission» does not exist psql:database.pgsql:800: ERROR: The relation «permission» does not exist Someone could fix this error ??? Thanks, Kinaï ------------------------------------------------------------------------ May 15, 2005 - 15:35 : kinai a ";" missing line 503 in database.pgsql Change CREATE INDEX url_alias_src ON url_alias(src) to CREATE INDEX url_alias_src ON url_alias(src); kinaï ------------------------------------------------------------------------ May 15, 2005 - 15:47 : kinai To fix this problem, I think change below is needed : line 703 : CREATE INDEX users_changed_idx ON users(changed); to CREATE INDEX users_access_idx ON users(access); because no column changed exist in users table. In database.mysql, Index is created on access column -- -- Table structre for table 'contact' -- CREATE TABLE contact ( subject varchar(255) NOT NULL default '', recipients longtext NOT NULL default '', reply longtext NOT NULL default '' ); to CREATE TABLE contact ( subject varchar(255) NOT NULL default '', recipients text NOT NULL default '', reply text NOT NULL default '' ); because le longtext format don't exist on postgresql. This change is right ?

1 0

[drupal-devel] [bug] non-standard form fields
by killes 25 May '05

25 May '05

Issue status update for http://drupal.org/node/23531 Project: Drupal Version: cvs Component: user.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Alex Reisner Updated by: killes(a)www.drop.org Status: patch I like this approach, it removes hardcoded html form core modules. +1 killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ May 24, 2005 - 19:40 : Alex Reisner User.module manually creates several form fields (on lines 1091 and 1664) rather than calling the form_ functions in common.inc. The fields on line 1664 are lacking a class attribute and all are missing id attributes, making their appearances difficult to control. It strikes me as better if the form_ functions were used, but I don't know enough about user.module to know if this is possible. At least the class and id info should be added manually. Relevant code: *Line 1091* $group .= form_item(t('Password'), '<input type="password" class="form-password" name="edit[pass1]" size="12" maxlength="24" /> <input type="password" class="form-password" name="edit[pass2]" size="12" maxlength="24" />', t('Enter your new password twice if you want to change your current password, or leave it blank if you are happy with your current password.'), NULL, TRUE); *Line 1664* $rows[] = array('<input type="text" size="32" maxlength="64" name="edit[name]" />', '<input type="submit" name="op" value="'. t('Add role') .'" />'); ------------------------------------------------------------------------ May 24, 2005 - 20:12 : Robin Monks Attachment: http://drupal.org/files/issues/hard.coded.form.fields.patch (2.19 KB) This patch should take care of that. I was unable to get someone to review it, so it may have a rough spot. Robin ------------------------------------------------------------------------ May 24, 2005 - 22:31 : Dries IMO, the usability of the forms degrades with this patch. It makes them look weird-ish. ------------------------------------------------------------------------ May 25, 2005 - 06:20 : Steven We can use container-inline to put the two password boxes on one row, no? ------------------------------------------------------------------------ May 25, 2005 - 13:04 : Robin Monks That's a good thought, I'll try to make a patch with inline. Robin ------------------------------------------------------------------------ May 25, 2005 - 17:17 : Robin Monks Attachment: http://drupal.org/files/issues/form_password_confirm.patch (3.78 KB) Here is a much better way to approach confirm fields, via a new field type form_password_confirm(). I've tested this, and it works. It doesn't fix the second set of hard coded forms, I'll address them in a seporate patch. Robin ------------------------------------------------------------------------ May 25, 2005 - 17:41 : Robin Monks Attachment: http://drupal.org/files/issues/hard.coded.form.fields_0.patch (761 bytes) and for the second issue...

1 0

[drupal-devel] [bug] non-standard form fields
by Robin Monks 25 May '05

25 May '05

Issue status update for http://drupal.org/node/23531 Project: Drupal Version: cvs Component: user.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Alex Reisner Updated by: Robin Monks Status: patch Attachment: http://drupal.org/files/issues/hard.coded.form.fields_0.patch (761 bytes) and for the second issue... Robin Monks Previous comments: ------------------------------------------------------------------------ May 24, 2005 - 17:40 : Alex Reisner User.module manually creates several form fields (on lines 1091 and 1664) rather than calling the form_ functions in common.inc. The fields on line 1664 are lacking a class attribute and all are missing id attributes, making their appearances difficult to control. It strikes me as better if the form_ functions were used, but I don't know enough about user.module to know if this is possible. At least the class and id info should be added manually. Relevant code: *Line 1091* $group .= form_item(t('Password'), '<input type="password" class="form-password" name="edit[pass1]" size="12" maxlength="24" /> <input type="password" class="form-password" name="edit[pass2]" size="12" maxlength="24" />', t('Enter your new password twice if you want to change your current password, or leave it blank if you are happy with your current password.'), NULL, TRUE); *Line 1664* $rows[] = array('<input type="text" size="32" maxlength="64" name="edit[name]" />', '<input type="submit" name="op" value="'. t('Add role') .'" />'); ------------------------------------------------------------------------ May 24, 2005 - 18:12 : Robin Monks Attachment: http://drupal.org/files/issues/hard.coded.form.fields.patch (2.19 KB) This patch should take care of that. I was unable to get someone to review it, so it may have a rough spot. Robin ------------------------------------------------------------------------ May 24, 2005 - 20:31 : Dries IMO, the usability of the forms degrades with this patch. It makes them look weird-ish. ------------------------------------------------------------------------ May 25, 2005 - 04:20 : Steven We can use container-inline to put the two password boxes on one row, no? ------------------------------------------------------------------------ May 25, 2005 - 11:04 : Robin Monks That's a good thought, I'll try to make a patch with inline. Robin ------------------------------------------------------------------------ May 25, 2005 - 15:17 : Robin Monks Attachment: http://drupal.org/files/issues/form_password_confirm.patch (3.78 KB) Here is a much better way to approach confirm fields, via a new field type form_password_confirm(). I've tested this, and it works. It doesn't fix the second set of hard coded forms, I'll address them in a seporate patch. Robin

1 0

[drupal-devel] [bug] non-standard form fields
by Robin Monks 25 May '05

25 May '05

Issue status update for http://drupal.org/node/23531 Project: Drupal Version: cvs Component: user.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Alex Reisner Updated by: Robin Monks Status: patch Attachment: http://drupal.org/files/issues/form_password_confirm.patch (3.78 KB) Here is a much better way to approach confirm fields, via a new field type form_password_confirm(). I've tested this, and it works. It doesn't fix the second set of hard coded forms, I'll address them in a seporate patch. Robin Robin Monks Previous comments: ------------------------------------------------------------------------ May 24, 2005 - 17:40 : Alex Reisner User.module manually creates several form fields (on lines 1091 and 1664) rather than calling the form_ functions in common.inc. The fields on line 1664 are lacking a class attribute and all are missing id attributes, making their appearances difficult to control. It strikes me as better if the form_ functions were used, but I don't know enough about user.module to know if this is possible. At least the class and id info should be added manually. Relevant code: *Line 1091* $group .= form_item(t('Password'), '<input type="password" class="form-password" name="edit[pass1]" size="12" maxlength="24" /> <input type="password" class="form-password" name="edit[pass2]" size="12" maxlength="24" />', t('Enter your new password twice if you want to change your current password, or leave it blank if you are happy with your current password.'), NULL, TRUE); *Line 1664* $rows[] = array('<input type="text" size="32" maxlength="64" name="edit[name]" />', '<input type="submit" name="op" value="'. t('Add role') .'" />'); ------------------------------------------------------------------------ May 24, 2005 - 18:12 : Robin Monks Attachment: http://drupal.org/files/issues/hard.coded.form.fields.patch (2.19 KB) This patch should take care of that. I was unable to get someone to review it, so it may have a rough spot. Robin ------------------------------------------------------------------------ May 24, 2005 - 20:31 : Dries IMO, the usability of the forms degrades with this patch. It makes them look weird-ish. ------------------------------------------------------------------------ May 25, 2005 - 04:20 : Steven We can use container-inline to put the two password boxes on one row, no? ------------------------------------------------------------------------ May 25, 2005 - 11:04 : Robin Monks That's a good thought, I'll try to make a patch with inline. Robin

1 0

[drupal-devel] [task] Introduce Daylight Saving Time for Drupal
by killes 25 May '05

25 May '05

Issue status update for http://drupal.org/node/11077 Project: Drupal Version: cvs Component: base system Category: tasks Priority: normal Assigned to: crunchywelch Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org Status: patch jhriggs, gordon: Please have a look at crunchywelch's dst implementation for event.module (in 4.6 and cvs). We intend to push this into core. killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ September 26, 2004 - 05:01 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/dst.patch (6.04 KB) Many people have wanted to have a Daylight Saving Time setting in the past. If we use the "server time" modell (all times are displayed the same around the world) this isn't all that hard to do. I found a lot of usefull information here: http://webexhibits.org/daylightsaving/g.html The patch introduces a new DST setting and uses it if the "Configurable time zones" setting is switched off. ------------------------------------------------------------------------ September 26, 2004 - 06:40 : gordon This is a lovely patch, but you do realise that you have opened a can of worms. Daylight saving is a messy business, I had to write the Contestable Electricity billing for a company here in Australia which had multiple installations in multpile timezones, all with different daylight savings rules, which impacted upon the bill. The way that dst is legistated is very messy and here is Australia it is very messy. Daylight savings don't follow state lines, as some towns that are very close to the border may choose to follow the only the daylight saving period of the next state, and when we had the olympics NSW went into daylight savings months before anyone else. There are other examples of weird things like even the 1 hour forward is not also true. I know that in the 1999 change to daylight savings there was a small set of islands north of New Zealand that went ahead by 2 hours as they wanted to be the first into 2000. >From what I can see of your patch it only allows for a single daylight savings period for the entire system. Their can be situations where there can be users from multiple countries and in different timezones/dst. I think that entire timezone system needs to looked at again, and maybe re-implement it so that it will allow for dst. Maybe make it a bit more user friendly so instead of setting up the timezone by name much like how operating systems do it, and then this will automatically work out the timezone. +1 for this is something that would be good, but it still needs work. ------------------------------------------------------------------------ September 26, 2004 - 16:13 : Anonymous The patch works as it is now. I had good reason to limit its capability to the setting where users cannot chose their own timezone. ;) I also assume that a server administrator knows if he has dst or not. I also didn't (yet) cater for all countries where dst is in use mainly because some insist on not giving a sensible rule for the change dates. ------------------------------------------------------------------------ September 27, 2004 - 00:54 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/dst_0.patch (6.04 KB) The last comment was mine. After a code review by Kjartan I provide a slightly improved patch. I want to stress that solving the DST issue in a "suits everybody" manner isn't the intention of this patch. It solves the problem for people who have chosen to let all times on their site be displayed in the server's time setting. By covering a large portion of the earth's landmass I hope to be able to help most site admins. It would be possible to extend the patch to allow users to chose their DST setting, too. In my experience, however, users tend to not care about time settings at all. This may be EUrocentric though, as we have only one time zone. Feedback is welcome. ------------------------------------------------------------------------ September 27, 2004 - 23:12 : drumm +1 >From a code review I think this is an excellent solution. Could use a little more comments in the section that sets $node->date to explain the (probably good) reasoning behind that chunk of code. I don't have anything resembling a good set of tests so I did not apply the patch and try it. ------------------------------------------------------------------------ January 25, 2005 - 22:38 : killes(a)www.drop.org I just want to point out that this patch still applies and would make for a fine feature for Drupal 4.6... ------------------------------------------------------------------------ January 26, 2005 - 18:46 : alliax wouldn't hurt to have this feature in upcoming drupal. I would use it for sure, my users are from the same place, with dst ------------------------------------------------------------------------ April 28, 2005 - 18:12 : Sage This is an incredibly useful feature and I would like to see it incorporated into the next release (current release is 4.6.0). ------------------------------------------------------------------------ May 4, 2005 - 18:06 : syntaxerror Works beautifully.. I'm going to work on getting this to work with event.module. ------------------------------------------------------------------------ May 4, 2005 - 19:53 : crunchywelch I have just discussed with killes and rorris an enhancement to this patch which I will implement. We have proposed putting the ical timezone db (http://cvs.drupal.org/viewcvs/drupal/contributions/modules/ical/ical.sql?re…) in core. We will implement a DST field in that db for each zone which coreesponds with the zones in killes' patch here for dtermining whether a zone is currently in dst or not. Currently, the 5 zones in the drupal_is_dst() function in this patch will be the only regions assigned to timezones. If more regions are desired they can be submitted by the community. To be clear, this must be implemented before additional development on ical/event.module can proceed properly. We would like this to be in core for 4.7, and move one more step with timezone handling in event module to use this as well. Discuss! ------------------------------------------------------------------------ May 4, 2005 - 20:13 : tostinni I agree to put more specific region to DST as it's easier for someone to know which city DST he belongs than which DST Zone (Pacific Standard Time...). I like pretty much the way that windows manage this. +1 ------------------------------------------------------------------------ May 5, 2005 - 04:45 : Jaza The patch looks good... however, it doesn't take into account the fact that in Australia, DST starts and ends at 2am on Sunday morning. So these lines: case 4: // Australia // start of DST (last Sunday in October) $dststart = strtotime("-1 week sunday GMT", strtotime("1 november $year GMT")) + $timezone; // end of DST (last Sunday in March) $dstend = strtotime("-1 week sunday GMT", strtotime("1 april $year GMT")) + $timezone; break; Should read: case 4: // Australia // start of DST (last Sunday in October at 2am) $dststart = strtotime("-1 week sunday GMT", strtotime("1 november $year GMT")) + 7200 + $timezone; // end of DST (last Sunday in March at 2am) $dstend = strtotime("-1 week sunday GMT", strtotime("1 april $year GMT")) + 7200 + $timezone; break; There are also a whole lot more countries (and their specific DST rules) on http://webexhibits.org/daylightsaving/g.html than are implemented in this patch. I'd ultimately like to see an admin interface to let the webmaster add additional DST rules for whatever country they live in (or are developing for). These rules could be entered in raw PHP, or using a somewhat friendlier interface. Jaza. ------------------------------------------------------------------------ May 25, 2005 - 08:11 : Steven +1 on this patch. Catches most cases and at least provides a base for others to work on. ------------------------------------------------------------------------ May 25, 2005 - 09:13 : gordon Do not take this the wrong what, but when it comes to dst, this is exemely simplisict. What would be the best method of doing this is to use the Zone Info files from libc. These not only have all the dst splits, but also all the timezones, and would be the most acurate. Have a look at Sources of Time Zone and Daylight Savings Data [1] whcih has pointers to where all this information is. Did you know that Australia has 21 different Timezones and DST areas. If you could enter the same information from tzdata then this would be the altermate dst system [1] http://www.twinsun.com/tz/tz-link.htm ------------------------------------------------------------------------ May 25, 2005 - 14:25 : jhriggs There has sure been a lot of talk about DST and time zones lately. All I ask is that we hold off on committing anything for a bit. I am currently working on a project that will hopefully fix this issue completely, correctly, and once and for all. :-) I am in the process of writing a pure PHP library that will be released LGPL that uses the /real/ zoneinfo data files to handle any date (not just Unix timestamps) in any time zone. With this, site admins and/or users will be able to select their real time zone (America/New_York vs. our current GMT -500) and DST will inherently be handled without users having to change their settings. Much of the grunt work is already done. I still have to put all of the pieces together and make sure everything is well documented. As soon as I have tested everything to my satisfaction, I will role a Drupal patch that we can hopefully get tested and committed ASAP. Of course I want to see this get into Drupal first! ;-) I hope to have everything completed in the next couple of weeks, but based on the way things have been going lately, I can't make any promises. It will definitely be done before 4.7, though...whatever it takes! ------------------------------------------------------------------------ May 25, 2005 - 14:47 : gordon +1 This sounds great, but I think we will still need a pure php version that will be able to be used on hosted web sites where we will not be able to get you library installed. It doesn't need to be as effient as the php extension, as sites that at that big will be self hosted and be able to install this library. One question. Does you extension run on windows. If it does this is another reason to have a pure php version. This is really the method that should be employed. ------------------------------------------------------------------------ May 25, 2005 - 14:53 : jhriggs When I say "library," I just mean a collection of PHP files as opposed to a single file. There is nothing to be installed like an extension. This is pure PHP that will simply be part of the distribution (a handful of .php files placed inside includes/zoneinfo or something like that). As this is pure PHP, it will work anywhere PHP does. This will essentially give us the benefit and functionality of using the TZ variable on Unix without all of the problems associated with that (i.e. not knowing what zones are available and what there names are, not being available on Windows, etc.). ------------------------------------------------------------------------ May 25, 2005 - 15:27 : gordon This sounds good. If you would like someone who has done alot of stuff with timezones and dst (mainly in the contestable electricity inductry in australia, which is required for billing), I would be quite happy to take a look. The only problem that I see is that it sounds a little too messy for core. maybe this could be made into a contributed module that can be installed if people need the correct timezones. However this is how the dst and timezones need to be done if we want to get them correct. As I said before and I couldn't believe it, Australia has 21 different timezones and dst areas. The timezone database needs to be maintained.

1 0

[drupal-devel] [task] Introduce Daylight Saving Time for Drupal
by gordon 25 May '05

25 May '05

Issue status update for http://drupal.org/node/11077 Project: Drupal Version: cvs Component: base system Category: tasks Priority: normal Assigned to: crunchywelch Reported by: killes(a)www.drop.org Updated by: gordon Status: patch This sounds good. If you would like someone who has done alot of stuff with timezones and dst (mainly in the contestable electricity inductry in australia, which is required for billing), I would be quite happy to take a look. The only problem that I see is that it sounds a little too messy for core. maybe this could be made into a contributed module that can be installed if people need the correct timezones. However this is how the dst and timezones need to be done if we want to get them correct. As I said before and I couldn't believe it, Australia has 21 different timezones and dst areas. The timezone database needs to be maintained. gordon Previous comments: ------------------------------------------------------------------------ September 26, 2004 - 13:01 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/dst.patch (6.04 KB) Many people have wanted to have a Daylight Saving Time setting in the past. If we use the "server time" modell (all times are displayed the same around the world) this isn't all that hard to do. I found a lot of usefull information here: http://webexhibits.org/daylightsaving/g.html The patch introduces a new DST setting and uses it if the "Configurable time zones" setting is switched off. ------------------------------------------------------------------------ September 26, 2004 - 14:40 : gordon This is a lovely patch, but you do realise that you have opened a can of worms. Daylight saving is a messy business, I had to write the Contestable Electricity billing for a company here in Australia which had multiple installations in multpile timezones, all with different daylight savings rules, which impacted upon the bill. The way that dst is legistated is very messy and here is Australia it is very messy. Daylight savings don't follow state lines, as some towns that are very close to the border may choose to follow the only the daylight saving period of the next state, and when we had the olympics NSW went into daylight savings months before anyone else. There are other examples of weird things like even the 1 hour forward is not also true. I know that in the 1999 change to daylight savings there was a small set of islands north of New Zealand that went ahead by 2 hours as they wanted to be the first into 2000. >From what I can see of your patch it only allows for a single daylight savings period for the entire system. Their can be situations where there can be users from multiple countries and in different timezones/dst. I think that entire timezone system needs to looked at again, and maybe re-implement it so that it will allow for dst. Maybe make it a bit more user friendly so instead of setting up the timezone by name much like how operating systems do it, and then this will automatically work out the timezone. +1 for this is something that would be good, but it still needs work. ------------------------------------------------------------------------ September 27, 2004 - 00:13 : Anonymous The patch works as it is now. I had good reason to limit its capability to the setting where users cannot chose their own timezone. ;) I also assume that a server administrator knows if he has dst or not. I also didn't (yet) cater for all countries where dst is in use mainly because some insist on not giving a sensible rule for the change dates. ------------------------------------------------------------------------ September 27, 2004 - 08:54 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/dst_0.patch (6.04 KB) The last comment was mine. After a code review by Kjartan I provide a slightly improved patch. I want to stress that solving the DST issue in a "suits everybody" manner isn't the intention of this patch. It solves the problem for people who have chosen to let all times on their site be displayed in the server's time setting. By covering a large portion of the earth's landmass I hope to be able to help most site admins. It would be possible to extend the patch to allow users to chose their DST setting, too. In my experience, however, users tend to not care about time settings at all. This may be EUrocentric though, as we have only one time zone. Feedback is welcome. ------------------------------------------------------------------------ September 28, 2004 - 07:12 : drumm +1 >From a code review I think this is an excellent solution. Could use a little more comments in the section that sets $node->date to explain the (probably good) reasoning behind that chunk of code. I don't have anything resembling a good set of tests so I did not apply the patch and try it. ------------------------------------------------------------------------ January 26, 2005 - 06:38 : killes(a)www.drop.org I just want to point out that this patch still applies and would make for a fine feature for Drupal 4.6... ------------------------------------------------------------------------ January 27, 2005 - 02:46 : alliax wouldn't hurt to have this feature in upcoming drupal. I would use it for sure, my users are from the same place, with dst ------------------------------------------------------------------------ April 29, 2005 - 02:12 : Sage This is an incredibly useful feature and I would like to see it incorporated into the next release (current release is 4.6.0). ------------------------------------------------------------------------ May 5, 2005 - 02:06 : syntaxerror Works beautifully.. I'm going to work on getting this to work with event.module. ------------------------------------------------------------------------ May 5, 2005 - 03:53 : crunchywelch I have just discussed with killes and rorris an enhancement to this patch which I will implement. We have proposed putting the ical timezone db (http://cvs.drupal.org/viewcvs/drupal/contributions/modules/ical/ical.sql?re…) in core. We will implement a DST field in that db for each zone which coreesponds with the zones in killes' patch here for dtermining whether a zone is currently in dst or not. Currently, the 5 zones in the drupal_is_dst() function in this patch will be the only regions assigned to timezones. If more regions are desired they can be submitted by the community. To be clear, this must be implemented before additional development on ical/event.module can proceed properly. We would like this to be in core for 4.7, and move one more step with timezone handling in event module to use this as well. Discuss! ------------------------------------------------------------------------ May 5, 2005 - 04:13 : tostinni I agree to put more specific region to DST as it's easier for someone to know which city DST he belongs than which DST Zone (Pacific Standard Time...). I like pretty much the way that windows manage this. +1 ------------------------------------------------------------------------ May 5, 2005 - 12:45 : Jaza The patch looks good... however, it doesn't take into account the fact that in Australia, DST starts and ends at 2am on Sunday morning. So these lines: case 4: // Australia // start of DST (last Sunday in October) $dststart = strtotime("-1 week sunday GMT", strtotime("1 november $year GMT")) + $timezone; // end of DST (last Sunday in March) $dstend = strtotime("-1 week sunday GMT", strtotime("1 april $year GMT")) + $timezone; break; Should read: case 4: // Australia // start of DST (last Sunday in October at 2am) $dststart = strtotime("-1 week sunday GMT", strtotime("1 november $year GMT")) + 7200 + $timezone; // end of DST (last Sunday in March at 2am) $dstend = strtotime("-1 week sunday GMT", strtotime("1 april $year GMT")) + 7200 + $timezone; break; There are also a whole lot more countries (and their specific DST rules) on http://webexhibits.org/daylightsaving/g.html than are implemented in this patch. I'd ultimately like to see an admin interface to let the webmaster add additional DST rules for whatever country they live in (or are developing for). These rules could be entered in raw PHP, or using a somewhat friendlier interface. Jaza. ------------------------------------------------------------------------ May 25, 2005 - 16:11 : Steven +1 on this patch. Catches most cases and at least provides a base for others to work on. ------------------------------------------------------------------------ May 25, 2005 - 17:13 : gordon Do not take this the wrong what, but when it comes to dst, this is exemely simplisict. What would be the best method of doing this is to use the Zone Info files from libc. These not only have all the dst splits, but also all the timezones, and would be the most acurate. Have a look at Sources of Time Zone and Daylight Savings Data [1] whcih has pointers to where all this information is. Did you know that Australia has 21 different Timezones and DST areas. If you could enter the same information from tzdata then this would be the altermate dst system [1] http://www.twinsun.com/tz/tz-link.htm ------------------------------------------------------------------------ May 25, 2005 - 22:25 : jhriggs There has sure been a lot of talk about DST and time zones lately. All I ask is that we hold off on committing anything for a bit. I am currently working on a project that will hopefully fix this issue completely, correctly, and once and for all. :-) I am in the process of writing a pure PHP library that will be released LGPL that uses the /real/ zoneinfo data files to handle any date (not just Unix timestamps) in any time zone. With this, site admins and/or users will be able to select their real time zone (America/New_York vs. our current GMT -500) and DST will inherently be handled without users having to change their settings. Much of the grunt work is already done. I still have to put all of the pieces together and make sure everything is well documented. As soon as I have tested everything to my satisfaction, I will role a Drupal patch that we can hopefully get tested and committed ASAP. Of course I want to see this get into Drupal first! ;-) I hope to have everything completed in the next couple of weeks, but based on the way things have been going lately, I can't make any promises. It will definitely be done before 4.7, though...whatever it takes! ------------------------------------------------------------------------ May 25, 2005 - 22:47 : gordon +1 This sounds great, but I think we will still need a pure php version that will be able to be used on hosted web sites where we will not be able to get you library installed. It doesn't need to be as effient as the php extension, as sites that at that big will be self hosted and be able to install this library. One question. Does you extension run on windows. If it does this is another reason to have a pure php version. This is really the method that should be employed. ------------------------------------------------------------------------ May 25, 2005 - 22:53 : jhriggs When I say "library," I just mean a collection of PHP files as opposed to a single file. There is nothing to be installed like an extension. This is pure PHP that will simply be part of the distribution (a handful of .php files placed inside includes/zoneinfo or something like that). As this is pure PHP, it will work anywhere PHP does. This will essentially give us the benefit and functionality of using the TZ variable on Unix without all of the problems associated with that (i.e. not knowing what zones are available and what there names are, not being available on Windows, etc.).

1 0