May 2005 - Development - lists.drupal.org

[drupal-devel] [feature] Direct link to term page from taxonomy admin
by Junyor 14 May '05

14 May '05

Issue status update for http://drupal.org/node/22878 Project: Drupal Version: 4.6.0 Component: taxonomy.module Category: feature requests Priority: normal Assigned to: Junyor Reported by: Junyor Updated by: Junyor Status: patch Attachment: http://drupal.org/files/issues/taxonomy46.patch (857 bytes) This patch makes all terms on the taxonomy overview page links to the taxonomy term list page. I'm constantly wanting to go to a taxonomy term's list page from the taxonomy overview page and I've never been able to figure out why this feature didn't exist already. Here's the patch for 4.6. Junyor

1 1

[drupal-devel] A little about my morning. - Rant on Documentation
by Gordon Heydon 14 May '05

14 May '05

Hello, I had a fun morning. When I got up this morning I had an email from a client with a problem with the ecommerce module which was not sending out the email alerts to customers. In the end it turned out to be a problem with the payment gateway that I had developed for him. So here I am investigating/programming and fixing his problem before I could leave to go to another client, so doing some creative thinking and find the solution as fast as possible. This got me to thinking, and the main reason that this problem occured in the first place. Basically the problem was that "Documentation for contributed modules sux" (I am not singling out the ecommerce module, AFAIK it all sux). Basically I feel the problem is that there is no place for development/user/admin documention on drupal.org/drupaldoc.org for any of the docuementation that relates to the contributed modules. If there was something like this then the fact that the payment gateway module is required to call the functions to send the emails and may not have been making up a solution to a problem that I didn't know about on the fly. For a start I think that it would be good to have drupaldoc.org include all the documentation from the contributed modules. I know that a lot do not have the the phpdoc comments (I know that mine do not, but I would fix this if it is going to be used). Then maybe adding sections to the user and admin sections of the handbook so that the contributed modules can build documentation. This also means that people who cannot program or contrbute modules can contribute by writing documentation much like we do now for the core documentation. Just my thoughts. Gordon.

9 11

[drupal-devel] [bug] Remove leftover DISTINCT
by mathias 14 May '05

14 May '05

Issue status update for http://drupal.org/node/22857 Project: Drupal Version: cvs Component: tracker.module Category: bug reports Priority: normal Assigned to: mathias Reported by: mathias Updated by: mathias Status: patch Attachment: http://drupal.org/files/issues/tracker-distinct.patch (937 bytes) Chx confirmed that this DISTINCT is no longer needed now that db_rewrite_sql handles this. mathias

1 0

[drupal-devel] [bug] file_check_location is not working on Windows 2000
by ec 14 May '05

14 May '05

Issue status update for http://drupal.org/node/10885 Project: Drupal Version: cvs Component: file system Category: bug reports Priority: critical Assigned to: Anonymous Reported by: ccourtne Updated by: ec Status: patch BTW, IMHO this patch should be committed ASAP as it's solve the problem with upload.module that can't handle private directory outside drupal root. Tested on my sites ans work (for now ;-) like a charm. Regards. ec Previous comments: ------------------------------------------------------------------------ September 16, 2004 - 14:46 : ccourtne Currently file_check_location is always returning false when passed a file as the $source path. If a directory is passed in $soruce file_check_location works. I've tracked this down to realpath returning an empty string when passed a relative path which points to a file. This probably goes unnoticed if you are using the file.api's to construct relative paths to the druapl file directory since check_location failing just causes the durpal file directory to get added which is what you wanted in the first place. Replacing this line $source = realpath(dirname($source)); with this $source = realpath(dirname($source)); fixes it on my windows box using PHP 4.3.8. I don't have things set up to do patches on my windows boxes here at work yet. I'll submit a formal patch tonight. ------------------------------------------------------------------------ September 16, 2004 - 14:47 : ccourtne Dag nabit. Replace $source = realpath($source); with $source = realpath(dirname($source)); Craig ------------------------------------------------------------------------ September 16, 2004 - 14:56 : Anonymous Attachment: http://drupal.org/files/issues/file-inc-file_check_location.patch (639 bytes) The sooner there are patches, the better it is... I tested this approach on my server and it works. Steef ------------------------------------------------------------------------ September 17, 2004 - 02:34 : ccourtne Attachment: http://drupal.org/files/issues/checklocation.patch (666 bytes) Here is the patch. ------------------------------------------------------------------------ February 23, 2005 - 01:30 : dan90(a)drupal.org This also fixed my file upload problems with some nonstandard paths under Linux/apache, php 4.3.4 drupal 4.5.2. maybe we should remove mention of windows 2000? ------------------------------------------------------------------------ March 1, 2005 - 18:32 : killes(a)www.drop.org Still applies. ------------------------------------------------------------------------ April 18, 2005 - 12:10 : ec Is this patch still to be use with actual Drupal 4.6.0 ? Thanks. eric ------------------------------------------------------------------------ May 7, 2005 - 11:35 : Wes Cowley I hand applied the patch to my Linux based installation and it solved the problem I was having with filemanager/attachment. I assume it would fix the same problem I had with upload.module since the symptoms were identical. ------------------------------------------------------------------------ May 7, 2005 - 11:36 : Wes Cowley Meant to add, that was a 4.6.0 Linux installaion that this patch cleared up. ------------------------------------------------------------------------ May 14, 2005 - 08:59 : larryjhs Thanks, still, I'm a bit of a php newbie -- where do I put the patch -- into which bit of script? If it's not too obvious, tell me and I won't try! But if it's obvious, please give me the location L ------------------------------------------------------------------------ May 14, 2005 - 09:19 : ec This patch seem still to apply to 4.6 (I'm using it on my linux box too and it solve my problem with upload.module) it apply on "file.inc" that you will find in includes directory on top of your drupal root. Put the patch in the same directory as file.inc go in this directory too and apply the patch like this "patch -p0 < the_patch_to_apply" where patch is the command on *nix box. If you're not confortable you can either edit the file.inc by hand and make the change yourself, in the patch file, line beginning with "-" is the one to remove, line beginning with "+" is the one to add, other lines are the context so you're sure to find the right line. Hope this help. Regards.

1 0

[drupal-devel] [bug] file_check_location is not working on Windows 2000
by ec 14 May '05

14 May '05

Issue status update for http://drupal.org/node/10885 Project: Drupal Version: cvs Component: file system Category: bug reports Priority: critical Assigned to: Anonymous Reported by: ccourtne Updated by: ec Status: patch This patch seem still to apply to 4.6 (I'm using it on my linux box too and it solve my problem with upload.module) it apply on "file.inc" that you will find in includes directory on top of your drupal root. Put the patch in the same directory as file.inc go in this directory too and apply the patch like this "patch -p0 < the_patch_to_apply" where patch is the command on *nix box. If you're not confortable you can either edit the file.inc by hand and make the change yourself, in the patch file, line beginning with "-" is the one to remove, line beginning with "+" is the one to add, other lines are the context so you're sure to find the right line. Hope this help. Regards. ec Previous comments: ------------------------------------------------------------------------ September 16, 2004 - 14:46 : ccourtne Currently file_check_location is always returning false when passed a file as the $source path. If a directory is passed in $soruce file_check_location works. I've tracked this down to realpath returning an empty string when passed a relative path which points to a file. This probably goes unnoticed if you are using the file.api's to construct relative paths to the druapl file directory since check_location failing just causes the durpal file directory to get added which is what you wanted in the first place. Replacing this line $source = realpath(dirname($source)); with this $source = realpath(dirname($source)); fixes it on my windows box using PHP 4.3.8. I don't have things set up to do patches on my windows boxes here at work yet. I'll submit a formal patch tonight. ------------------------------------------------------------------------ September 16, 2004 - 14:47 : ccourtne Dag nabit. Replace $source = realpath($source); with $source = realpath(dirname($source)); Craig ------------------------------------------------------------------------ September 16, 2004 - 14:56 : Anonymous Attachment: http://drupal.org/files/issues/file-inc-file_check_location.patch (639 bytes) The sooner there are patches, the better it is... I tested this approach on my server and it works. Steef ------------------------------------------------------------------------ September 17, 2004 - 02:34 : ccourtne Attachment: http://drupal.org/files/issues/checklocation.patch (666 bytes) Here is the patch. ------------------------------------------------------------------------ February 23, 2005 - 01:30 : dan90(a)drupal.org This also fixed my file upload problems with some nonstandard paths under Linux/apache, php 4.3.4 drupal 4.5.2. maybe we should remove mention of windows 2000? ------------------------------------------------------------------------ March 1, 2005 - 18:32 : killes(a)www.drop.org Still applies. ------------------------------------------------------------------------ April 18, 2005 - 12:10 : ec Is this patch still to be use with actual Drupal 4.6.0 ? Thanks. eric ------------------------------------------------------------------------ May 7, 2005 - 11:35 : Wes Cowley I hand applied the patch to my Linux based installation and it solved the problem I was having with filemanager/attachment. I assume it would fix the same problem I had with upload.module since the symptoms were identical. ------------------------------------------------------------------------ May 7, 2005 - 11:36 : Wes Cowley Meant to add, that was a 4.6.0 Linux installaion that this patch cleared up. ------------------------------------------------------------------------ May 14, 2005 - 08:59 : larryjhs Thanks, still, I'm a bit of a php newbie -- where do I put the patch -- into which bit of script? If it's not too obvious, tell me and I won't try! But if it's obvious, please give me the location L

1 0

[drupal-devel] [bug] file_check_location is not working on Windows 2000
by larryjhs 14 May '05

14 May '05

Issue status update for http://drupal.org/node/10885 Project: Drupal Version: cvs Component: file system Category: bug reports Priority: critical Assigned to: Anonymous Reported by: ccourtne Updated by: larryjhs Status: patch Thanks, still, I'm a bit of a php newbie -- where do I put the patch -- into which bit of script? If it's not too obvious, tell me and I won't try! But if it's obvious, please give me the location L larryjhs Previous comments: ------------------------------------------------------------------------ September 16, 2004 - 13:46 : ccourtne Currently file_check_location is always returning false when passed a file as the $source path. If a directory is passed in $soruce file_check_location works. I've tracked this down to realpath returning an empty string when passed a relative path which points to a file. This probably goes unnoticed if you are using the file.api's to construct relative paths to the druapl file directory since check_location failing just causes the durpal file directory to get added which is what you wanted in the first place. Replacing this line $source = realpath(dirname($source)); with this $source = realpath(dirname($source)); fixes it on my windows box using PHP 4.3.8. I don't have things set up to do patches on my windows boxes here at work yet. I'll submit a formal patch tonight. ------------------------------------------------------------------------ September 16, 2004 - 13:47 : ccourtne Dag nabit. Replace $source = realpath($source); with $source = realpath(dirname($source)); Craig ------------------------------------------------------------------------ September 16, 2004 - 13:56 : Anonymous Attachment: http://drupal.org/files/issues/file-inc-file_check_location.patch (639 bytes) The sooner there are patches, the better it is... I tested this approach on my server and it works. Steef ------------------------------------------------------------------------ September 17, 2004 - 01:34 : ccourtne Attachment: http://drupal.org/files/issues/checklocation.patch (666 bytes) Here is the patch. ------------------------------------------------------------------------ February 23, 2005 - 00:30 : dan90(a)drupal.org This also fixed my file upload problems with some nonstandard paths under Linux/apache, php 4.3.4 drupal 4.5.2. maybe we should remove mention of windows 2000? ------------------------------------------------------------------------ March 1, 2005 - 17:32 : killes(a)www.drop.org Still applies. ------------------------------------------------------------------------ April 18, 2005 - 11:10 : ec Is this patch still to be use with actual Drupal 4.6.0 ? Thanks. eric ------------------------------------------------------------------------ May 7, 2005 - 10:35 : Wes Cowley I hand applied the patch to my Linux based installation and it solved the problem I was having with filemanager/attachment. I assume it would fix the same problem I had with upload.module since the symptoms were identical. ------------------------------------------------------------------------ May 7, 2005 - 10:36 : Wes Cowley Meant to add, that was a 4.6.0 Linux installaion that this patch cleared up.

1 0

[drupal-devel] install system phase 3: wizard api
by Adrian Rossouw 14 May '05

14 May '05

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey guys. I just had a thought regarding phase 3 of the install system (if you don't know what I am talking about, you should probably read this: http://drupal.org/node/22472) A wizard, as I have created it .. is essentially a very simple workflow tool. We want to integrate a workflow engine of some sort into Drupal for 4.7 do we not anyway? Perhaps it would be more constructive for us to focus our energies on that, and let the install wizard be driven by a Drupal wide workflow engine? - -- Adrian Rossouw Drupal developer and Bryght Guy http://drupal.org | http://bryght.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (Darwin) iD8DBQFCgWTLgegMqdGlkasRAktoAKC75UDcuOJJ14n9aZd9+6ziPdEg5wCglWXd ESsREO0pECSnxZ9mdTVjIvg= =Kdvk -----END PGP SIGNATURE-----

4 3

[drupal-devel] [bug] Grammar correction
by Cvbge 14 May '05

14 May '05

Issue status update for http://drupal.org/node/22804 Project: Drupal Version: 4.6.0 Component: comment.module Category: bug reports Priority: minor Assigned to: Anonymous Reported by: Cvbge Updated by: Cvbge Status: patch Attachment: http://drupal.org/files/issues/comment_module-grammar_fix.diff (2.19 KB) Below is a list of the latest comments posted your site. "posted /to/ your" is missing. Cvbge

2 4

Re: [drupal-devel] CiviCRM, Civicgroups, OG, Profile- Playing together
by David Geilhufe 13 May '05

13 May '05

>From our perspective (David, Lobo and Dave-CiviCRM team), and of CivicSpace, we would like to see as deep and wide integration of CiviCRM into CivicSpace/Drupal as possible. For those that are unfamiliar with CiviCRM, it provides a CRM repository tailored to the needs of non-profits, but relevant to other applications as well. It stores contacts, relationships, groups, and actions. It's API could be used to store CRM data for a volunteer management module, for example, or data on attendees for an events module. In our discussions with CivicSpace, the intention is that CiviCRM will become part of the CivicSpace release in 0.8.2. I'll let the CivicSpace guys define exactly what this means in roadmap terms. This suggests some immediate priorities: (1) Developers/people need to work with CiviCRM code and sandbox. (2) We need further discussion and ideally some consensus regarding interfaces and division of functionality between CiviCRM and the Drupal core modules which currently handle info about people. (3) Module developers should begin the porting/integration process. ************************************ CiviCRM Code and Repository http://sandbox.openngo.org/crm/ ************************************ Please visit the sandbox. Right now, you can download the code and get it fired up locally per the installation instructions (link at the sandbox site). Today, feel free to contribute workflow suggestions or other high level anlysis. Latter this week, we will be accepting bug reports on the 0.1 release. Our development team is still in the end stages of a feature freeze, so we are actively testing and fixing, but your contributions are INVALUABLE! ************************************ Drupal Core ************************************ Folks out in Drupal land- CiviCRM isn't just useful for CivicSpace applications. You might want to look at it to store sophistocated CRM data. But as Jason has said, there needs to be more discussion on how CiviCRM will interface with Drupal core modules like User and Profile. Our current plan is to implement user hooks which will keep CiviCRM contact data synchronized with Drupal 'users'. However, the best approach(es) for playing with Profile are less obvious. Do we duplicate and/or sync Profile data? This implies a tool for mapping Profile to CiviCRM fields since Profile doesn't have a 'known' data model. Or does it make sense for CiviCRM to "take over" the Profile functionality if it's installed? (We tend toword the latter approach to keep the model cleaner and provide the opportunity for deeper integration to a shared data model). We would love to get this discussion and decisions going anywhere it might be appropriate (drupal-dev, cs-dev, crm-dev). ************************************ Module Developers & Porting ************************************ The 0.1 API and feature set is fairly stable and it is a great time for module developers to start figuring out how to port their modules to using CiviCRM. It is critical to us to support module developers in the porting process. People should feel free to ask for API support on the CiviCRM development email list http://lists.objectledge.net/mailman/listinfo/crm-dev Module developers should also feel free to ask for (and contribute) API and data model changes. One of the big goals for CiviCRM is to help you build better, more powerful applications. The more people that begin the process now, the sooner CiviCRM can be deeply and widely integrated with CivicSpace/ Drupal. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ David Geilhufe CEO Social Source Foundation david -AT- socialsourcefoundation -DOT- org http://www.socialsourcefoundation.org/ Add me to your address book... <https://www.plaxo.com/add_me?u=34359748358&v0=19951&k0=-658465201> Connect with me on Linkedin... <http://www.linkedin.com/> >On 5/8/05, jasonwhat <jasonwhat(a)gmail.com> wrote: > >http://drupal.org/node/21940#comment-38421 In this >post I talk about some of the various modules out >there that let users create data about themselves, >data on other users, and relationships. What seems >clear to me is there is development going on in CS and >Drupal and Civicgroups of several similar user >managemnt and organanization tools. > >I brought this issue up here >http://civicspacelabs.org/home/node/12285 and realize >that maybe the CivicCRM is the to omnipotent api that >will unify all several modules. If I'm correct, the >CivicCRM won't just have it's own data fields, like >the current contact module in CS, but will share with >modules like profile once they are updated to work >with it. > >If CivicCRM seems like the place to unify all this >then I think there needs to be a more visible way to >get these module maintainers and developers involved >now. I do believe there is a mailing list for this, >but I mean a more visible acceptance from developers >that the CivicCRM is what they should be looking >towards, and coding towards as much as that is >possible. > >I might be stating the obvious here, but my fear is >that modules like "contact directory" >http://drupal.org/node/15863 will continue to be >developed duplicating the fothcoming CivicCRM. Or >maybe the module is great and will ultimately be an >important aspect of the CRM, but if so it would nice >to have that conversation started now, rather than >later. With all the posts about extending profile, or >searching profiles, referrals and invites, and organic >grouping, it would be nice for these developers to >join in the CivicCRM discussion and development, >rather than starting their own. > >I see that CivicCRM was discussed at FOSDEM, but I >don't know if a more general "user management" >discussion has taken place or not. I'm not sure if it >needs to, but just throwing these thoughts out to the >wolves.

5 5

[drupal-devel] [bug] Missing placeholder
by drumm 13 May '05

13 May '05

Issue status update for http://drupal.org/node/22806 Project: Drupal Version: 4.6.0 Component: upload.module Category: bug reports Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/upload.module_2.diff (1.31 KB) Just a simple em -> placeholder fix. drumm

1 0