May 2005 - Development - lists.drupal.org

[drupal-devel] MySQL 3, MySQL 4 and MySQL 5
by Dries Buytaert 04 May '05

04 May '05

At what point should we drop MySQL 3 support? MySQL 4 has been released on October 21, 2001 [1] and a MySQL 5 BETA release is already available from [2]. From my investigation, making MySQL 4 a requirement would allow us to use row-level locking and transactions, two features that are becoming increasingly important. If would allow us to get rid of the various MySQL errors, and would bring us one step closer to true database integrity. It would be nice if we could take advantage of these in Drupal 4.7. [1] http://www.mysql.com/news-and-events/news/article_81.html [2] http://dev.mysql.com/downloads/mysql/5.0.html Thoughts? -- Dries Buytaert :: http://www.buytaert.net/

8 12

[drupal-devel] [bug] admin/node/book produces a blank page
by RobinMonks 04 May '05

04 May '05

Issue status update for http://drupal.org/node/21441 Project: Drupal Version: cvs Component: book.module Category: bug reports Priority: normal -Assigned to: Anonymous +Assigned to: RobinMonks Reported by: moshe weitzman Updated by: RobinMonks Status: patch Attachment: http://drupal.org/files/issues/show error on book id not found_0.patch (2.04 KB) This patch corrects the function of admin/node/book. Robin RobinMonks Previous comments: ------------------------------------------------------------------------ April 27, 2005 - 19:20 : moshe weitzman probably a result of the recent patch where we return content instead of print. ------------------------------------------------------------------------ April 29, 2005 - 00:41 : puregin Attachment: http://drupal.org/files/issues/book.module_blank_admin_page.patch (488 bytes) The function book_admin_view() does not return a non-empty string if $nid is zero, which is the default value if /admin/node/book is visited. The attached patch returns 'No book selected.'. There's probably a better way to do this. ------------------------------------------------------------------------ May 1, 2005 - 16:03 : Dries Note that you have to wrap strings in t(). How about removing the books from the navigation menu, and returning an itemized list of books? ------------------------------------------------------------------------ May 2, 2005 - 13:30 : RobinMonks I also wrote a patch for this for issue http://drupal.org/node/21668 http://drupal.org/files/issues/show%20error%20on%20book%20id%20not%20found.… This patch returns an error whenever the book ID cannot be found, then redirects the user back to admin with the message. Robin

1 0

Re: [drupal-devel] [geeklog-devel] Re: Geeklog 1.3.12 - the next steps
by Michael Jervis 04 May '05

04 May '05

> I guess my main gripe with this is that it may break a few > layouts that expect usernames to be short. And it requires > changes in some of Geeklog's templates, which is always a bit > of a pain for our users. Perhaps the best compromise is to use $remoteusername if it's unique, and append @$Service (enlarging the field) if it isn't. I suspect in most cases it will be unique. Some cases it won't be, but I expect the main use of this is for people like me who run small personal sites with the odd bit of popular content that people might occasionally want to login to post to but not register with. As my registered (local) user base is tiny, the uniqueness is not too much of a problem. Or perhaps just use their $remoteusername in all cases and let geeklog user id uniqueness and a slight confusion work... > The only 2 remotely similar options you have are to remove a > user from the All Users and Logged-in Users groups (which > will give them an error message when they try to log in) or > to assign them an empty password (which you can't do from > within Geeklog) so that they are treated as non- approved members. Perhaps better user status is more important at this stage than remote authentication. > >0 - Banned. > >1 - Awaiting Activation > >2 - Awaiting Approval > >3 - Active > > > Someone actually pointed out to me the other day that you can > easily sign up someone else for a Geeklog site and that they > would then get notices, e.g. those sent from the "Mail Users" > admin panel, which would, from the victims point of view, > look like you're spamming them. > > So "activation" could also mean "has logged in as least once" > (or would that be a separate status?) and the options for > emailing users should default to only let you email "active" users. I was thinking that we could have email account activation as an option like it is with phpbb, vbulletin etc. I now realise that the password is emailed, so yes, the way you suggest would be best. When an account is created it is created at status 1 or 2. 1 if admin approval of accounts is not required, 2 otherwise. When an admin approves an account it moves to 1. When a user first logs in it moves to 3. When a user banned it moves to 0. So I think renumbering: 0 - banned 1 - Awaiting Approval - New accounts 2 - Awaiting Activation - New accounts that have been approved 3 - Active - New accounts, approved and logged in. If admin approval isn't enabled, then new accounts go straight to 2. > I guess I don't have to point out that all this has to be > carefully implemented and thoroughly tested to avoid security > issues ... Oh, can't we just do a sloppy hack and hack it into all live geeklog instances? Just for a laugh like... ;-) Geeklog's security is sorely missed (by me). > When you allow a few thousand people (how many members does > blogger.com > have?) to suddenly log in to your site, there's bound to be a > few that you may want to ban ... But, at current, they can still register and post and not be banned. We don't suddenly make the site more open for trolls. Well, ok just a LITTLE more open. Perhaps bans first, then remote auth? Mike

1 0

[drupal-devel] [bug] Missing <p> tag in block module
by factoryjoe 04 May '05

04 May '05

Issue status update for http://drupal.org/node/21939 Project: Drupal Version: 4.6.0 Component: block.module Category: bug reports Priority: minor Assigned to: Anonymous Reported by: factoryjoe Updated by: factoryjoe Status: patch Attachment: http://drupal.org/files/issues/block.module_1.patch (1.51 KB) There is a missing tag in the help text of the block module. Here's a patch to fix it. factoryjoe

1 0

Re: [drupal-devel] how Yahoo uses Drupal?
by Boerland Bert 03 May '05

03 May '05

-----Original Message----- From: drupal-devel-bounces(a)drupal.org > And for God's sake, can someone "blog this in a forum topic" (tm) and > promote it to drupal.org's front page? ;-) done (http://drupal.org/node/21930) my first posting I promoted myself so go easy on me but hard on the content/style/syntax/links etc.

1 0

[drupal-devel] Question on use of theme_pager() and related functions
by Scott Courtney 03 May '05

03 May '05

Is there a good example somewhere illustrating the correct use of calls to theme('pager',....)? I'm trying to use this function, and I've actually got it working except for one issue: I don't know how to tell it the actual number of rows that were returned from my database query. I see the "tags" array that can be passed, and it *looks* as if that would be the right thing to do. But node.module, statistics.module, and all the others I can find in Drupal core seem to always pass NULL for that parameter to theme_pager(). So I'm led to conclude that somehow theme_pager() gets this information from elsewhere in the "normal" case. The example modules, as luck would have it, don't use this feature. Suggestions? Scott -- ------------------------------------------------------------------------------ Scott Courtney | "I don't mind Microsoft making money. I mind them scott(a)4th.com | having a bad operating system." -- Linus Torvalds http://4th.com/ | ("The Rebel Code," NY Times, 21 February 1999) | PGP Public Key at http://4th.com/keys/scott.pubkey

4 4

Re: [drupal-devel] how Yahoo uses Drupal?
by Boerland Bert 03 May '05

03 May '05

-----Original Message----- From: drupal-devel-bounces(a)drupal.org [regarding y! and drupal] > This is a must read :) Well written, covering a broad spectrum from usability to pattern blogging and worth posting and promoting on drupal.org IMHO.

1 0

[drupal-devel] url aliases
by Gerhard Killesreiter 03 May '05

03 May '05

Hi there! The pathauto module has recently become popular. It introduces path aliases for a lot of urls and exposes a performance issue with Drupal's handling of url_aliases. There are two things that need investigation: - wouldn't using conf_url_rewrite be cheaper in some of this cases? - why do we load all patch aliases for each and every page load? It is probably not the sql query SELECT * FROM {url_alias} that is the problem, but the processing in php afterwards (looping over the results). This happens in drupal_get_path_map(). Is there any reason why we couldn't only select the alias we need? Currently, we need all the aliases because we want to make sure they can be used when creating links on the generated page. Wouldn't it be possible to 1) during processing collect all the urls that are going to be on a page and 2) only retreive the needed aliases based on this info? Cheers, Gerhard

2 1

[drupal-devel] Closing forums
by Robert Douglass 03 May '05

03 May '05

Is it still possible to close forums in 4.6? If not, we should remove misc/forum-closed.png. -R

3 3

[drupal-devel] [task] Placeholder for fine-grained-blog-edit-control path
by mattengland 03 May '05

03 May '05

Issue status update for http://drupal.org/node/21887 Project: Drupal Version: 4.6.0 Component: base system Category: tasks Priority: minor Assigned to: mattengland Reported by: mattengland Updated by: mattengland Status: patch Attachment: http://drupal.org/files/issues/blog-edit-control-patch-for-drupal-4.6.0-dat… (20.36 KB) As per http://drupal.org/node/21885 , I'm using this bug/issue submission as a simple placeholder for an uploaded file. I'm first doing and then asking for forgiveness later; I see no other place to upload files like this. I hope I'm not rubbing anybody the wrong way. -Matt mattengland

2 1