June 2005 - Development - lists.drupal.org

[drupal-devel] [bug] Table Prefix
by Jaza 23 Jun '05

23 Jun '05

Issue status update for http://drupal.org/node/25600 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: kubaZygmunt Updated by: Jaza Status: patch Attachment: http://drupal.org/files/issues/db_prefix_global.patch (582 bytes) Also noticed this bug, when trying to install a fresh CVS snapshot. Attached is my patch against CVS HEAD (same as kubaZygmunt's, basically). Jaza Previous comments: ------------------------------------------------------------------------ June 23, 2005 - 21:28 : kubaZygmunt Attachment: http://drupal.org/files/issues/bootstrap.diff (422 bytes) I've found that new cvs version doesn't get properly db_prefix. In bootstrap.inc (function _drupal_bootstrap($phase) ) I added another global variable $db_prefix, and then it goes . I don't know if my solution is good because on my local site I can't see any blocks and on my internet site I have some caching and I can't see anything :) ------------------------------------------------------------------------ June 23, 2005 - 22:45 : kubaZygmunt Above I've put my patch

1 0

[drupal-devel] [bug] Table Prefix
by kubaZygmunt 23 Jun '05

23 Jun '05

Issue status update for http://drupal.org/node/25600 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: kubaZygmunt Updated by: kubaZygmunt -Status: active +Status: patch Above I've put my patch kubaZygmunt Previous comments: ------------------------------------------------------------------------ June 23, 2005 - 13:28 : kubaZygmunt Attachment: http://drupal.org/files/issues/bootstrap.diff (422 bytes) I've found that new cvs version doesn't get properly db_prefix. In bootstrap.inc (function _drupal_bootstrap($phase) ) I added another global variable $db_prefix, and then it goes . I don't know if my solution is good because on my local site I can't see any blocks and on my internet site I have some caching and I can't see anything :)

1 0

[drupal-devel] [bug] Mission does not get displayed if it is a path alias
by kubaZygmunt 23 Jun '05

23 Jun '05

Issue status update for http://drupal.org/node/17291 Project: Drupal Version: cvs Component: theme system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: kbahey Updated by: kubaZygmunt -Status: active +Status: patch for me this diffs works so I change the status to patch kubaZygmunt Previous comments: ------------------------------------------------------------------------ February 14, 2005 - 01:22 : kbahey When path aliases are used for nodes, and the theme is told to display the mission statement, the mission will not display if the home page in /admin/settings is set to an alias. To reproduce this do the following: 1. Go to /admin/modules and enable the path module, if not already enabled 2. Create a node of type page, and enter an alias for it (e.g. home.html) 3. Go to /admin/settings and set the Drupal default front page to be home.html 4. Go to admin/themes and select Pushbutton (or any theme using xtemplate engine), make it the default 5 Go to /admin/themes/settings and enable Mission statement Now go to the home page of your site, and you will NOT see the mission displayed. Some debugging shows that the culprit is this section of code in /themes/engines/xtemplate/xtemplate.engine: <?php if ($_GET["q"] == variable_get("site_frontpage", "node") && theme_get_setting('toggle_mission') && ($mission = theme_get_setting('mission'))) { $xtemplate->template->assign("mission", $mission); $xtemplate->template->parse("header.mission"); } ?> The problem is $_GET["q"] stores "node/1" and not "home.html", so the above condition is never met, and the mission does not get displayed. The workaround is to put in /admin/settings the drupal node path (e.g. node/1) instead of home.html, the mission will be displayed then. ------------------------------------------------------------------------ June 11, 2005 - 23:53 : killes(a)www.drop.org xtemplate is no longer part of core. ------------------------------------------------------------------------ June 12, 2005 - 04:01 : kbahey The problem still occurs on phptemplate themes (e.g. Pushbutton) under 4.6. ------------------------------------------------------------------------ June 22, 2005 - 20:09 : eferraiuolo I also have run into this problem but from a different angle. I tried using taxonomy terms to be displayed on the front page along with the mission statement; I can get this to work, but not without getting an error/warning. So I tried creating an URL alias for my taxonomy terms url, but then the mission statment wasn't being displayed as you pointed out! *Example:* I set Administer >> Settings >> Default front page to: taxonomy/term/15,7 Also Mission Statement is toggled /on/ under Administer >> Themes and the result was what I was after; the front page displaying the mission statement along with all content tagged with Term 15 & Term 7. But I also got something I didn't want, a Warning/Error: warning: preg_match() [function.preg-match]: Unknown modifier 't' in /home/ewebportals/web/public/schoolcraft/modules/block.module on line 474. *To Fix the Error I did:* I created an URL Alias in Administer >> URL Aliases System Path: taxonomy/term/15,7 Alias Path: everyone/common I then replaced taxonomy/term/15,7 (my default front page URL) to everyone/common; but the error was still present, and I lost my mission statement. Finally I edited my URL Alias from everyone/common to everyone_common; this got rid of the error, but still my mission statement wasn't being displayed. *My Debug Trace:* I tried to track down my error and ended up the same place you did, but my theme is using PHPTemplate Engine; so I tracked the bug to *file: themes/engines/phptemplate.engine: if ($_GET['q'] == variable_get('site_frontpage', 'node')) { $mission = theme_get_setting('mission'); $frontpage = true; } ------------------------------------------------------------------------ June 23, 2005 - 14:33 : kubaZygmunt Attachment: http://drupal.org/files/issues/phptemplate.diff (685 bytes) To solve this in phptemplate I check if in database exists alias for main page(table {url_alias} ) and then check if ( ($_GET['q'] == variable_get('site_frontpage', 'node')) || ($_GET['q'] == $alias->src ) )

1 0

[drupal-devel] [bug] "Welcome to Drupal" page won't disappear after first post & proper access permissions
by deekayen 23 Jun '05

23 Jun '05

Issue status update for http://drupal.org/node/23296 Project: Drupal Version: 4.6.0 Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: djsparks Updated by: deekayen -Status: active +Status: patch Attachment: http://drupal.org/files/issues/frontpagemessageremoval.diff (865 bytes) Perhaps the attached patch will solve of some confusion. You could have 100 nodes in the db, and if none of them are promoted to the front page, you get the welcome message. This patch would say 'No content is currently promoted to the front page.' instead of acting like it's a fresh install. Diff'ed against HEAD. deekayen Previous comments: ------------------------------------------------------------------------ May 20, 2005 - 14:09 : djsparks After successful setup, settings of access permissions, etc., site was working fine--new setup welcome message was replaced with first post. However, next day, setup welcome message was back. Access control for node module is enabled for anonymous users. All other permissions have been reviewed with no known conflicts. Default node is "node". Clean URLs are enabled. ------------------------------------------------------------------------ May 22, 2005 - 17:18 : djsparks This issue seems to be a bug instead of a single incident. After looking at virtually every post on the support forums that seemed to apply to this issue, I was unable to find a solution. Upon uninstall and new install, problem disappeared--for now. No known solution to the problem; in fact, no idea what the actual cause of the problem is. However, this is not an isolated incident. No, the node_privacy_by_role module was not installed or in use. ------------------------------------------------------------------------ June 23, 2005 - 03:04 : Bèr Kessels please give us some more details: What third party modules do you use? What errors and messages do you se in the watchdog? Do you have a backup system that might flush the database? Marking this "normal", for critical should be read as "critical for Drupal", and not as "critical for me"

1 0

[drupal-devel] [feature] Add form_select() option CSS
by budda 23 Jun '05

23 Jun '05

Issue status update for http://drupal.org/node/25138 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: budda Updated by: budda -Status: active +Status: patch Attachment: http://drupal.org/files/issues/formselectcss.patch (1.82 KB) Patch for above CSS modification request. Most of what can currently be done with CSS on elements is only useful on Mozilla browsers. IE can't do anything exciting, it just ignores the content. budda Previous comments: ------------------------------------------------------------------------ June 16, 2005 - 13:54 : budda i'd like to CSS my select menu list. However the drupal common.inc form_select() doesn't assign each with a unique id/class. the option list id's could be generated in the form: <select-name>-<option value> Which could produce something like: <select class="card" name="edit[card]" id="edit-card"> <option value="" selected="selected">Please Choose</option> <option value="VISA" id="card-visa">Visa</option> <option value="MC" id="card-mc">Mastercard</option> <option value="SWITCH" id="card-switch">Switch</option> <option value="SOLO" id="card-solo">Solo</option> </select> The above would then allow individual styling to each - in my case displaying an image next to each option.

1 0

[drupal-devel] [feature] Cache rendered comment threads
by chx 23 Jun '05

23 Jun '05

Issue status update for http://drupal.org/node/25563 Project: Drupal Version: cvs Component: comment.module Category: feature requests Priority: normal Assigned to: chx Reported by: chx Updated by: chx Status: patch First problem to tackle: comments may have dynamic filters. No more. Comments are not nodes because they should be simple and fast and dynamic filters are killing this. So now we have static content built every two minutes on drupal.org, which is IMO bad. I do CACHE_PERMANENT and take care of killing the thread only when the particular thread is invalidated. If you find the patch worthy, I will extend it so that there is no multiple cache ie. the comments themselves are not cached when called from comment thread view. Maybe a similar patch could be introduced for cacheable nodes? chx

7 10

[drupal-devel] [bug] Notice: Undefined index: count in E:\Web\drupal\includes\bootstrap.inc on line 33
by deekayen 23 Jun '05

23 Jun '05

Issue status update for http://drupal.org/node/24605 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: minor Assigned to: Anonymous Reported by: deekayen Updated by: deekayen Status: patch Attachment: http://drupal.org/files/issues/line33notice.patch (409 bytes) I downloaded CVS last night and got this on every page load: Notice: Undefined index: count in E:\Web\drupal\includes\bootstrap.inc on line 33 It was bugging me so a patch is attached. deekayen

1 2

[drupal-devel] Release critical bugs for June 23, 2005
by drupal-devel＠drupal.org 23 Jun '05

23 Jun '05

/ bug reports email spam filtering does not "see" email addresses when they are NOT preceded by a word age: 22 weeks 4 days url: http://drupal.org/node/15654 / bug reports No titles in blocks age: 4 days 14 hours url: http://drupal.org/node/25255 / bug reports blocks age: 2 days 11 hours url: http://drupal.org/node/25378 Problem with cached pages assigned: jmonteiro age: 3 days 4 hours url: http://drupal.org/node/25327 Problem with cached pages assigned: jmonteiro age: 3 days 4 hours url: http://drupal.org/node/25326 admin/modules page: modules not activating age: 2 weeks 2 days url: http://drupal.org/node/24428 Accidentally Deleting Forums Vocabulary in Categories Breaks Forums? age: 2 weeks 5 days url: http://drupal.org/node/24274 Taxonomy Multiple Hierarchy doesn't display children for all its parent age: 3 weeks 1 day url: http://drupal.org/node/24023 Caching and garbage in cache table (gzipped?) age: 3 weeks 2 days url: http://drupal.org/node/23925 Multiple Hierarchy doesn't display children for all its parent age: 3 weeks 5 days url: http://drupal.org/node/23770 "Welcome to Drupal" page won't disappear after first post & proper access permissions age: 4 weeks 5 days url: http://drupal.org/node/23296 Tagging Issues age: 5 weeks 2 days url: http://drupal.org/node/23026 Forum post not visible assigned: mohaqa age: 5 weeks 2 days url: http://drupal.org/node/22960 Error in TEMP DIRECTORY age: 5 weeks 3 days url: http://drupal.org/node/22916 PG_QUERY ERROR - LOCK TABLES - IMPLEMENTATION FAULT. age: 5 weeks 3 days url: http://drupal.org/node/22911 Search memory limit problems after 4.6 upgrade age: 6 weeks 1 day url: http://drupal.org/node/22497 Podcasting feeds broken age: 7 weeks 1 day url: http://drupal.org/node/21924 Teaser problem assigned: childhood age: 9 weeks 1 day url: http://drupal.org/node/20843 UTF-8 node title gets truncated at wrong position age: 9 weeks 5 days url: http://drupal.org/node/20537 database table "term_node" not updated when removing a term from a node under editing and submitting age: 10 weeks 2 days url: http://drupal.org/node/20315 Reassigning a node to a different term does not work properly age: 10 weeks 3 days url: http://drupal.org/node/20278 4.6 aggregator showing/not interpreting HTML tags age: 11 weeks 4 days url: http://drupal.org/node/19874 New submit error, non-admin user, postgresql database assigned: adrian age: 15 weeks 1 day url: http://drupal.org/node/18552 When I delete a user, any forum in which s/he has commented also disappears. assigned: Jill6q age: 18 weeks 10 hours url: http://drupal.org/node/17428 Change to sesssion.inc violates UID database constraint age: 22 weeks 4 days url: http://drupal.org/node/15666 forum.module problem with postgresql v7.4.1 age: 23 weeks 2 days url: http://drupal.org/node/15411 PHP 5 gives error when session table has no session assigned: adschar age: 23 weeks 2 days url: http://drupal.org/node/15399 MySQL database scheme broken assigned: crackerjackmack(a)evilsquid.net age: 31 weeks 2 days url: http://drupal.org/node/12967 Argument NOT must be type boolean age: 31 weeks 2 days url: http://drupal.org/node/12950 Comments in approval queue still show up in tracker age: 35 weeks 4 days url: http://drupal.org/node/11647 Twin problems with comments assigned: Junyor age: 36 weeks 6 days url: http://drupal.org/node/11366 Fatal error: Call to undefined function: drupal_set_html_head() age: 43 weeks 1 day url: http://drupal.org/node/10317 Prevent browser page caching of dynamic content assigned: mathias age: 1 year 18 weeks url: http://drupal.org/node/5900 / feature requests Novel Module Creation Request age: 1 week 3 days url: http://drupal.org/node/24856 Provide a way to select a term from a vocabulary via a drop down list in a users profile age: 4 weeks 10 hours url: http://drupal.org/node/23601 moving pages en masse age: 11 weeks 6 days url: http://drupal.org/node/19754 Taxonomy module should use nodeapi 'load' age: 15 weeks 9 hours url: http://drupal.org/node/18631 Auto PHP memory maximisation age: 17 weeks 2 days url: http://drupal.org/node/17663 Don't reset existing password on request, prevent DoS password reset abuse age: 19 weeks 3 days url: http://drupal.org/node/16909 User info exposed to anonymous user age: 29 weeks 5 days url: http://drupal.org/node/13545 Allow named anchors to work without specifying full path to node age: 1 year 30 weeks url: http://drupal.org/node/4213 / support requests Please help me out i am stuck here :( assigned: neerajshokeen age: 6 weeks 4 days url: http://drupal.org/node/22227 Fatal error: Unknown column 'headers' in 'field list' query assigned: Eagle-i age: 14 weeks 1 day url: http://drupal.org/node/18928 Strange session behavior age: 14 weeks 3 days url: http://drupal.org/node/18821 user redirected to homepage when logging in age: 15 weeks 5 days url: http://drupal.org/node/18381 Problem with Forums age: 23 weeks 4 days url: http://drupal.org/node/15299 / bug reports Upgraded from 4.5 - Calendar Not Displaying Events age: 2 days 15 hours url: http://drupal.org/node/25367 Events seem to reappear in a crazy fashion in following months age: 1 week 13 hours url: http://drupal.org/node/25070 Events seem to reappear in a crazy fashion in following months age: 1 week 13 hours url: http://drupal.org/node/25069 search over fields.inc fields conceptual error age: 33 weeks 6 days url: http://drupal.org/node/12259 fields.inc screws up with multible multiselect fields age: 33 weeks 6 days url: http://drupal.org/node/12257 / feature requests event.module support of repeating/recurring events? assigned: thehunmonkgroup age: 1 year 31 weeks url: http://drupal.org/node/4122 / bug reports Menu item not showing age: 37 weeks 5 days url: http://drupal.org/node/11210 / bug reports segmentation fault related to filestore age: 1 year 38 weeks url: http://drupal.org/node/3001 / bug reports file size bug age: 1 week 5 days url: http://drupal.org/node/24728 / support requests File store module - Overwriting Filename....Help needed assigned: harishkm age: 1 year 11 weeks url: http://drupal.org/node/6827 Unserialize error at line 104 age: 1 year 18 weeks url: http://drupal.org/node/5857 Filestore module- sql errors rectified assigned: harishkm age: 1 year 19 weeks url: http://drupal.org/node/5619 Filestore Module Problems unaddressed assigned: harishkm age: 1 year 21 weeks url: http://drupal.org/node/5365 / bug reports Gallery error age: 8 weeks 2 days url: http://drupal.org/node/21290 Fatal Error: variable_get() age: 13 weeks 3 days url: http://drupal.org/node/19189 No Gallery Image Block age: 13 weeks 6 days url: http://drupal.org/node/19045 Mini applet can't find gallery at url / age: 14 weeks 4 days url: http://drupal.org/node/18785 Fatal error: Undefined class name 'galleryembed' age: 17 weeks 1 day url: http://drupal.org/node/17746 / support requests Can't Embed Gallery into Drupal age: 16 weeks 3 days url: http://drupal.org/node/18029 / bug reports Drupal-4.4-rc breaks registration setups and groups.module age: 1 year 14 weeks url: http://drupal.org/node/6392 / bug reports Editing a previously uploaded and thumnailed image loses the thumbnail. age: 1 day 8 hours url: http://drupal.org/node/25465 Image module thumbnail/preview stop working after l10n age: 8 weeks 6 days url: http://drupal.org/node/21036 Cannot upload .jpgs age: 16 weeks 3 days url: http://drupal.org/node/18076 Image.Module does not know the correct filename age: 31 weeks 1 day url: http://drupal.org/node/13032 SAFE MODE Restriction in effect... age: 34 weeks 6 days url: http://drupal.org/node/11843 Uploading jpeg makes Imagemagick do high compression age: 36 weeks 3 days url: http://drupal.org/node/11445 Image module failing on Preview because of a blank node id age: 38 weeks 4 days url: http://drupal.org/node/11069 Similar problem with Directory Upload Slow age: 38 weeks 4 days url: http://drupal.org/node/11064 / support requests path problems on upgrading... age: 7 weeks 3 days url: http://drupal.org/node/21725 / bug reports Outdated help texts age: 46 weeks 2 days url: http://drupal.org/node/9692 Import doesn't like XML/RSS feeds with no Title element age: 1 year 3 weeks url: http://drupal.org/node/8128 / feature requests RSS items overwriting edited items age: 1 year 1 week url: http://drupal.org/node/8455 / tasks move XML-parser into an inclde file. age: 1 day 14 hours url: http://drupal.org/node/25439 / feature requests Notify.module ignores the true submission queue age: 1 year 34 weeks url: http://drupal.org/node/3765 / feature requests Internationalization support for PDF assigned: TheLibrarian age: 1 year 12 weeks url: http://drupal.org/node/6795 / bug reports Download link is wrong age: 2 days 16 hours url: http://drupal.org/node/25363 Projects not listed and page not complete age: 3 weeks 2 days url: http://drupal.org/node/23956 Date for latest is incorrect age: 9 weeks 6 days url: http://drupal.org/node/20485 Invalid link to release files age: 17 weeks 3 days url: http://drupal.org/node/17625 Node body not complete w/o releases age: 19 weeks 5 days url: http://drupal.org/node/16733 blank page after install age: 20 weeks 1 day url: http://drupal.org/node/16575 / support requests Help with everything - nothing seems to work in the latest build age: 30 weeks 2 days url: http://drupal.org/node/13310 / bug reports Can't get the inline tag to show series age: 6 weeks 1 day url: http://drupal.org/node/22520 / bug reports MySQL Error age: 12 weeks 6 days url: http://drupal.org/node/19413 javascrip downloads square.gif for every category age: 18 weeks 1 day url: http://drupal.org/node/17366 / feature requests Drupal Search usability improvement age: 4 weeks 6 days url: http://drupal.org/node/23185

1 0

[drupal-devel] [bug] if postgresql function
by Arto 23 Jun '05

23 Jun '05

Issue status update for http://drupal.org/node/23499 Project: Drupal Version: 4.6.0 Component: forum.module Category: bug reports Priority: normal Assigned to: patrickslee Reported by: cchamilt Updated by: Arto Status: patch Drupal 4.6.1 on PostgreSQL 7.4.7: The patch (database.pgsql_3.patch) fixes the problem; igrcic's method would certainly fix it as well. Advocate committing the patch. Arto Previous comments: ------------------------------------------------------------------------ May 24, 2005 - 04:32 : cchamilt Postgresql function "if" is defined to return a boolean value, yet forum requests an integer - last_comment_uid. user error: query: SELECT n.nid, l.last_comment_timestamp, IF(l.last_comment_uid, cu.name, l.last_comment_name) as last_comment_name, l.last_comment_uid FROM node n, node_comment_statistics l /*! USE INDEX (node_comment_timestamp) */, users cu, term_node r WHERE n.nid = r.nid AND r.tid = 1 AND n.status = 1 AND n.type = 'forum' AND l.last_comment_uid = cu.uid AND n.nid = l.nid ORDER BY l.last_comment_timestamp DESC LIMIT 1 OFFSET 0 in /var/www/hosts/www.ambigc.com/htdocs/includes/database.pgsql.inc on line 62. warning: pg_query() [function.pg-query]: Query failed: ERROR: function if(integer, character varying, character varying) does not exist HINT: No function matches the given name and argument types. You may need to add explicit type casts. in /var/www/hosts/www.ambigc.com/htdocs/includes/database.pgsql.inc on line 45. ------------------------------------------------------------------------ May 24, 2005 - 22:07 : patrickslee Attachment: http://drupal.org/files/issues/forum.module_3.patch (2.69 KB) I have also encountered this bug and made a possible patch by replacing IF statements to CASE. A patch file is attached. ------------------------------------------------------------------------ May 24, 2005 - 22:28 : adrian There is an IF function defined in the database.pgsql function. On what page is this happening, as what might be happening is that the type isn't being picked up correctly. It's defined as IF(anyelement, anyelement, text) returns anyelement. IIRC. What I have seen happen is that it wants the text field to return integer, or vice versa. ------------------------------------------------------------------------ May 24, 2005 - 22:32 : patrickslee I found the definition in database.pgsql. It is like this: CREATE FUNCTION "if"(boolean, anyelement, anyelement) RETURNS anyelement AS ' SELECT CASE WHEN $1 THEN $2 ELSE $3 END; ' LANGUAGE 'sql'; So it is actually wanting boolean. ------------------------------------------------------------------------ May 24, 2005 - 22:43 : patrickslee So my patch will work, and we can make it easier by replacing the IF function to: IF(l.last_comment_uid 0 AND l.last_comment_uid NULL, cu.name, l.last_comment_name) BTW there is another place in forum.module use IF like this. ------------------------------------------------------------------------ May 24, 2005 - 22:45 : patrickslee Oops... my <>s are stolen. IF(l.last_comment_uid <> 0 AND l.last_comment_uid <> NULL, cu.name, l.last_comment_name) ------------------------------------------------------------------------ May 25, 2005 - 05:20 : cchamilt Yes that line works great. Thanks for your help! ------------------------------------------------------------------------ May 25, 2005 - 05:52 : patrickslee This patch shows another problem. The last post user will always show "Anonymous" or whatever you defined. Looking for solution... ------------------------------------------------------------------------ May 25, 2005 - 06:00 : patrickslee Use this line instead: IF(l.last_comment_uid <> 0 AND l.last_comment_uid <> NULL, cu.name, l.last_comment_name) Don't forget there are two places in forum.module need to be changed. ------------------------------------------------------------------------ May 25, 2005 - 06:10 : patrickslee Oh what have I done! I changed nothing! IF(l.last_comment_uid <> 0 AND l.last_comment_uid IS NOT NULL, cu.name, l.last_comment_name) ------------------------------------------------------------------------ May 25, 2005 - 10:12 : adrian perhaps we could also just add more wrapper functions for the specific types ? create or replace function IF (integer, anyelement, anyelement) returns anyelement as ' SELECT if (($1 0) AND NOT nullvalue($1), $2, $3); ' LANGUAGE 'sql'; Or something. ------------------------------------------------------------------------ May 25, 2005 - 10:41 : plj '' was missing. So what adrian actually means is this: CREATE OR REPLACE FUNCTION IF (integer, anyelement, anyelement) RETURNS anyelement AS ' SELECT if (($1 <> 0) AND NOT nullvalue($1), $2, $3); ' LANGUAGE 'sql'; I applied that and now forums work -- no module patches. PostgreSQL 7.4.7. ------------------------------------------------------------------------ May 25, 2005 - 10:45 : plj Sheesh. I meant that '<>' was missing. Gotta learn to use that preview button... ------------------------------------------------------------------------ May 25, 2005 - 21:53 : patrickslee Is nullvalue() a function? I cannot find it in neither postgres manual nor mysql manual. Use "IS NOT NULL" would be better as it is more standard-compatible. SO we have this: CREATE OR REPLACE FUNCTION IF (integer, anyelement, anyelement) RETURNS anyelement AS ' SELECT IF(($1 <> 0) AND $1 IS NOT NULL, $2, $3); ' LANGUAGE 'sql'; Looks we have a satisfying fix here. Is this fix going to be committed in CVS for next release? ------------------------------------------------------------------------ May 26, 2005 - 00:26 : adrian hostmaster=# \df nullvalue List of functions Result data type | Schema | Name | Argument data types ------------------+------------+-----------+--------------------- boolean | pg_catalog | nullvalue | "any" But it doesn't matter to me =) ------------------------------------------------------------------------ May 26, 2005 - 19:21 : Dries Can you guys provide a patch? I don't have a PostgreSQL setup to test it against. Will commit to DRUPAL-4-6 and HEAD. ------------------------------------------------------------------------ May 26, 2005 - 20:29 : patrickslee Attachment: http://drupal.org/files/issues/database.pgsql_3.patch (363 bytes) Here you have it. ------------------------------------------------------------------------ June 15, 2005 - 10:18 : igrcic Dont know about you guys but that patch doesnt work for me in drupal 4.6.1!? Im using PostgreSQL. Instead im using following function that works just fine if(integer,text,text) BEGIN IF $1 THEN RETURN $2; END IF; IF NOT $1 THEN RETURN $3; END IF; END; ------------------------------------------------------------------------ June 19, 2005 - 08:55 : Dries Just so you know: I'm not committing this patch yet because one user commented that it didn't work. Waiting for a follow-up from the PostgreSQL front. ------------------------------------------------------------------------ June 19, 2005 - 11:28 : igrcic Ok, here how it is now. First of all, forget my previous if FUNCTION :) Currenty im using drupal 4.6.1 and I had that problems with forums. Now Im using two if functions, because one is required for forums and I forgot for another another one, but I know that it was called because of different function parameters (bool, int). So one for the forum is : CREATE OR REPLACE FUNCTION "if"(integer, text, text) RETURNS text AS ' BEGIN IF $1 IS NOT NULL AND $1 > 0 THEN RETURN $2; ELSE RETURN $3; END IF; END; ' LANGUAGE 'plpgsql'; The another one is standard function that comes with drupal database.inc.pgsql file CREATE FUNCTION "if"(boolean, anyelement, anyelement) RETURNS anyelement AS ' SELECT CASE WHEN $1 THEN $2 ELSE $3 END; ' LANGUAGE 'sql'; Im using it for a while and everything works nice! Before I posted this topic I replaced function with that one in patch and it worked nice with this one too. But I know that once I had some error with it (didn't write it down grrr), so im stickin with the first function, because it work perfectly for me! And we have to have 2 functions, one for boolean and one for integer! In mysql it isnt so. Hope everything's clear now! ------------------------------------------------------------------------ June 19, 2005 - 11:30 : igrcic Oops, maybe I screwed up something with formatting my post :( Hope you can fix it, sorry

1 0

[drupal-devel] [bug] user_access returns a string not a boolean as specified
by moshe weitzman 23 Jun '05

23 Jun '05

Issue status update for http://drupal.org/node/21566 Project: Drupal Version: cvs Component: user system Category: bug reports Priority: minor Assigned to: deekayen Reported by: gjf Updated by: moshe weitzman Status: patch and the fact that you obviously did not test your patch with any user beside uid=1. considering that the code branch you changed doesn't even apply to uid=1, i'd say that this was pretty reckless. other than that, welcome to the project. we look forward to your future patches ... moshe weitzman Previous comments: ------------------------------------------------------------------------ April 29, 2005 - 01:53 : gjf user_access() function returns a string not a boolean. This caused memory consumption problems for us due to a bug elsewhere in our code. i.e. return strstr($perm[$account->uid], "$string, "); should probably be if ( strstr($perm[$account->uid], "$string, ")) { return true; } else { return false; } ------------------------------------------------------------------------ June 20, 2005 - 03:35 : deekayen Attachment: http://drupal.org/files/issues/user_access.returnbooleans.diff (1.28 KB) Attached patch has a spelling correction and makes user_access() return only booleans. Diff'ed against HEAD. ------------------------------------------------------------------------ June 20, 2005 - 03:55 : deekayen Attachment: http://drupal.org/files/issues/user_access.returnbooleans_0.diff (1.59 KB) It bothered me to have a string search instead of an array search for permissions. This patch does what the previous patch does, but it uses in_array() on the static $perm instead of strstr() on a string. ------------------------------------------------------------------------ June 20, 2005 - 04:02 : killes(a)www.drop.org Can you please provide a benchmark test of the strstr approach vs the in_array one? I am concerned that it might be slower. user_access gets called quite often. ------------------------------------------------------------------------ June 20, 2005 - 04:47 : deekayen That's a fair request. The output of the following code on my WinXP, PHP5.1-dev, 2.133 Ghz Athlon is: 0.29749894142151 0.29712684249878 1.0804200172424 0.56814384460449 0.10924220085144 0.12113380432129 0.13284420967102 <?php function utime($a = '') { static $utime; $time = explode(' ', microtime()); $usec = (double)$time[0]; $sec = (double)$time[1]; switch($a) { case 'bm': $to_return = $usec + $sec - $utime; break; default: $utime = $usec + $sec; return $utime; break; } $utime = $usec + $sec; return $to_return; } $account->uid = 1; utime(); for($i=0; $i<500000; $i+=1) { if ($account->uid == 1) { // blah } } echo utime('bm') .'<br />'; for($i=0; $i<500000; $i+=1) { if ((int)$account->uid === 1) { // blah } } echo utime('bm') .'<br />'; for($i=0; $i<50; $i+=1) { $result[$i] = ''; for($j=0; $j>10; $j+=1) { $result[$i] .= chr(rand(65-126)); } } $perm[$account->uid] = ''; utime(); for($i=0; $i<2000; $i+=1) { foreach($result as $row) { $perm[$account->uid] .= "$row, "; } isset($perm[$account->uid]) && strstr($perm[$account->uid], "{$result['45']}, "); } echo utime('bm') .'<br />'; $perm[$account->uid] = array(); utime(); for($i=0; $i<2000; $i+=1) { foreach($result as $row) { $perm[$account->uid][] = $row; } isset($perm[$account->uid]) && in_array($result['45'], $perm[$account->uid]); } echo utime('bm') .'<br />'; for($i=0; $i<500000; $i+=1) { // blah } echo utime('bm') .'<br />'; for($i=0; $i<500000; $i++) { // blah } echo utime('bm') .'<br />'; for($i=0; $i<500000; $i = $i+1) { // blah } echo utime('bm') .'<br />'; ?> ------------------------------------------------------------------------ June 20, 2005 - 05:01 : deekayen Actually, there's a bug in the benchmark code that causes $result to not populate. Switch the following: for($j=0; $j>10; $j+=1) { to for($j=0; $j<10; $j+=1) { Then the string search is more like 8.1727991104126 seconds verses like 0.46953892707825 for the array search, an even bigger difference. ------------------------------------------------------------------------ June 21, 2005 - 13:45 : Dries Committed to HEAD. ------------------------------------------------------------------------ June 22, 2005 - 15:31 : killes(a)www.drop.org Please revert this patch, it isn't working at all. Drupal HEad is non-workign for all users which aren't No. 1. ------------------------------------------------------------------------ June 22, 2005 - 15:37 : moshe weitzman yeah - this breaks HEAD completely. here is a possible fix, if we still want to use in_array() for checking. this is in user_access() where we build the permission array: <?php while ($row = db_fetch_object($result)) { foreach (explode(',', $row->perm) as $p) { $perm[$account->uid][] = trim($p); } } ?> ------------------------------------------------------------------------ June 22, 2005 - 18:10 : deekayen Attachment: http://drupal.org/files/issues/user_access.returnbooleans_1.diff (763 bytes) I haven't found a case where trim() would be necessary if you explode on ', ' (with the space). I made a patch so things are hopefully less broken. I'm working on the benchmark people keep asking me for in #drupal. ------------------------------------------------------------------------ June 22, 2005 - 20:35 : deekayen Attachment: http://drupal.org/files/issues/user_access.returnbooleans_2.diff (884 bytes) in_array() was faster, but explode() is slow, so this reverts back to strstr. I hope I can blame my newbieness to Drupal internals on this, but I should have looked to see how permissions were stored before just assuming each loop through db_fetch_object was a separate permission instead of a string of permissions.

1 0