June 2005 - Development - lists.drupal.org

[drupal-devel] [bug] Wrong Login Error
by moshe weitzman 16 Jun '05

16 Jun '05

Issue status update for http://drupal.org/node/3962 Project: Drupal Version: cvs Component: user system Category: bug reports Priority: minor Assigned to: deekayen Reported by: dziemecki Updated by: moshe weitzman Status: patch I'm not so sure about this one. We should continue to distinguish between a 'user block' and a 'host ban'. moshe weitzman Previous comments: ------------------------------------------------------------------------ November 5, 2003 - 22:01 : dziemecki When a new user logs on after they're ID and password were sent to them, but before their account was "unblocked", they get the follwoing error: "Sorry. Unrecognized username or password. Have you forgotten your password?" That may or may not count as a bug, but it not entirely accurate, and might be a little confusing. ------------------------------------------------------------------------ June 14, 2005 - 04:19 : deekayen I don't mind assigning this one to myself, but I'm not familiar enough with the function of the access table to complete the patch. Should blocked users be entered into the access table? Right now, user.module has a drupal_deny check with the correct error message, but it doesn't get displayed because the only place a person gets blocked is in the users table. To be more normalized, I'd just leave the block in the users table, but does someone intend to move the user block to the access table? ------------------------------------------------------------------------ June 15, 2005 - 22:37 : deekayen Attachment: http://drupal.org/files/issues/blockedloginmessage.patch (1.26 KB) Right now when users are blocked, they're not added to the access table, so this patch just checks the users table for blocked logins. The check in user.module's user_login() should work now and give the correct error message that was there all along. ------------------------------------------------------------------------ June 15, 2005 - 22:45 : deekayen Attachment: http://drupal.org/files/issues/removeactivereset.patch (882 bytes) This patch goes with the previous one. Without it, when you edit a blocked user to make them active again, they remain blocked and the edit screen shows an error message about the user being blocked. I don't really know if that's the intended behavior to have blocks be permanent, but permanent blocks don't seem right to me.

1 0

[drupal-devel] Brochure Design
by Andre Molnar 16 Jun '05

16 Jun '05

Good day all. The marketing team has come up with a draft of the copy to be included in the new brochure - and I am soliciting additional feedback from the dev community. The project page can be found at: http://drupal.org/node/24384 (scroll down for the latest version of the text) This is also a call for graphic arts magicians to submit your ideas on how this brochure should look. thanks andre

3 4

[drupal-devel] Logic in node.module's node_db_rewrite_sql function
by Michael Josephson 16 Jun '05

16 Jun '05

Hi all, I'm trying to follow through the circumstances under which a DISTINCT gets added into a query. e.g. at the moment If I request a Drupal path such as "taxonomy_menu/3" then I get duplicate entries for any nodes that are assigned to more than one term in that vocabulary. Looking at node.module it only sets distinct if !node_access_view_all_nodes() which seems to be an access permissions related condition. Should I be putting a hook in one of my own modules to control this? tvm, -Michael

2 1

[drupal-devel] more control over rending the list of nodes matching a taxonomy term?
by Michael Josephson 16 Jun '05

16 Jun '05

This is my first post to the drupal-devel list so I'd like to say Hi first of all. I've been busy over the last week or two building up the theme for a site and developing a couple of custom modules. I'd like to have a bit more control over how the list of nodes matching a taxonomy term is presented. e.g. if I have a Drupal path such as taxonomy/term/6 I'd like to display the item teasers in a 2-column layout. I've been looking at the taxonomy_render_nodes function in taxonomy.module and at present this just appends the node_views together one after the other so doesn't seem to provide a way for me to add any additional HTML. Is there a suggested mechanism that already exists for doing something like this or should I look at making a modification to taxonomy_render_nodes (e.g. adding a theming function call) Thanks for any help, -Michael

2 2

[drupal-devel] [bug] Wrong Login Error
by deekayen 16 Jun '05

16 Jun '05

Issue status update for http://drupal.org/node/3962 Project: Drupal Version: cvs Component: user system Category: bug reports Priority: minor Assigned to: deekayen Reported by: dziemecki Updated by: deekayen Status: patch Attachment: http://drupal.org/files/issues/removeactivereset.patch (882 bytes) This patch goes with the previous one. Without it, when you edit a blocked user to make them active again, they remain blocked and the edit screen shows an error message about the user being blocked. I don't really know if that's the intended behavior to have blocks be permanent, but permanent blocks don't seem right to me. deekayen Previous comments: ------------------------------------------------------------------------ November 5, 2003 - 21:01 : dziemecki When a new user logs on after they're ID and password were sent to them, but before their account was "unblocked", they get the follwoing error: "Sorry. Unrecognized username or password. Have you forgotten your password?" That may or may not count as a bug, but it not entirely accurate, and might be a little confusing. ------------------------------------------------------------------------ June 14, 2005 - 03:19 : deekayen I don't mind assigning this one to myself, but I'm not familiar enough with the function of the access table to complete the patch. Should blocked users be entered into the access table? Right now, user.module has a drupal_deny check with the correct error message, but it doesn't get displayed because the only place a person gets blocked is in the users table. To be more normalized, I'd just leave the block in the users table, but does someone intend to move the user block to the access table? ------------------------------------------------------------------------ June 15, 2005 - 21:37 : deekayen Attachment: http://drupal.org/files/issues/blockedloginmessage.patch (1.26 KB) Right now when users are blocked, they're not added to the access table, so this patch just checks the users table for blocked logins. The check in user.module's user_login() should work now and give the correct error message that was there all along.

1 0

[drupal-devel] [bug] Wrong Login Error
by deekayen 16 Jun '05

16 Jun '05

Issue status update for http://drupal.org/node/3962 Project: Drupal Version: cvs Component: user system Category: bug reports Priority: minor Assigned to: deekayen Reported by: dziemecki Updated by: deekayen -Status: active +Status: patch Attachment: http://drupal.org/files/issues/blockedloginmessage.patch (1.26 KB) Right now when users are blocked, they're not added to the access table, so this patch just checks the users table for blocked logins. The check in user.module's user_login() should work now and give the correct error message that was there all along. deekayen Previous comments: ------------------------------------------------------------------------ November 5, 2003 - 21:01 : dziemecki When a new user logs on after they're ID and password were sent to them, but before their account was "unblocked", they get the follwoing error: "Sorry. Unrecognized username or password. Have you forgotten your password?" That may or may not count as a bug, but it not entirely accurate, and might be a little confusing. ------------------------------------------------------------------------ June 14, 2005 - 03:19 : deekayen I don't mind assigning this one to myself, but I'm not familiar enough with the function of the access table to complete the patch. Should blocked users be entered into the access table? Right now, user.module has a drupal_deny check with the correct error message, but it doesn't get displayed because the only place a person gets blocked is in the users table. To be more normalized, I'd just leave the block in the users table, but does someone intend to move the user block to the access table?

1 0

[drupal-devel] Release critical bugs for June 16, 2005
by drupal-devel＠drupal.org 16 Jun '05

16 Jun '05

/ bug reports email spam filtering does not "see" email addresses when they are NOT preceded by a word age: 21 weeks 4 days url: http://drupal.org/node/15654 / bug reports admin/modules page: modules not activating age: 1 week 2 days url: http://drupal.org/node/24428 Accidentally Deleting Forums Vocabulary in Categories Breaks Forums? age: 1 week 5 days url: http://drupal.org/node/24274 Taxonomy Multiple Hierarchy doesn't display children for all its parent age: 2 weeks 1 day url: http://drupal.org/node/24023 Caching and garbage in cache table (gzipped?) age: 2 weeks 2 days url: http://drupal.org/node/23925 Multiple Hierarchy doesn't display children for all its parent age: 2 weeks 5 days url: http://drupal.org/node/23770 "Welcome to Drupal" page won't disappear after first post & proper access permissions age: 3 weeks 5 days url: http://drupal.org/node/23296 Tagging Issues age: 4 weeks 2 days url: http://drupal.org/node/23026 Error in TEMP DIRECTORY age: 4 weeks 3 days url: http://drupal.org/node/22916 PG_QUERY ERROR - LOCK TABLES - IMPLEMENTATION FAULT. age: 4 weeks 3 days url: http://drupal.org/node/22911 Search memory limit problems after 4.6 upgrade age: 5 weeks 1 day url: http://drupal.org/node/22497 Warning: Wrong parameter count for mysql_connect() assigned: jselva(a)drupal.org age: 5 weeks 5 days url: http://drupal.org/node/22188 Podcasting feeds broken age: 6 weeks 1 day url: http://drupal.org/node/21924 Teaser problem assigned: childhood age: 8 weeks 1 day url: http://drupal.org/node/20843 UTF-8 node title gets truncated at wrong position age: 8 weeks 5 days url: http://drupal.org/node/20537 database table "term_node" not updated when removing a term from a node under editing and submitting age: 9 weeks 2 days url: http://drupal.org/node/20315 Attached files can not be deleted age: 9 weeks 2 days url: http://drupal.org/node/20307 Reassigning a node to a different term does not work properly age: 9 weeks 3 days url: http://drupal.org/node/20278 4.6 aggregator showing/not interpreting HTML tags age: 10 weeks 4 days url: http://drupal.org/node/19874 New submit error, non-admin user, postgresql database assigned: adrian age: 14 weeks 1 day url: http://drupal.org/node/18552 When I delete a user, any forum in which s/he has commented also disappears. assigned: Jill6q age: 17 weeks 9 hours url: http://drupal.org/node/17428 Change to sesssion.inc violates UID database constraint age: 21 weeks 4 days url: http://drupal.org/node/15666 forum.module problem with postgresql v7.4.1 age: 22 weeks 2 days url: http://drupal.org/node/15411 PHP 5 gives error when session table has no session assigned: adschar age: 22 weeks 2 days url: http://drupal.org/node/15399 Argument NOT must be type boolean age: 30 weeks 2 days url: http://drupal.org/node/12950 Comments in approval queue still show up in tracker age: 34 weeks 4 days url: http://drupal.org/node/11647 Twin problems with comments assigned: Junyor age: 35 weeks 6 days url: http://drupal.org/node/11366 Prevent browser page caching of dynamic content assigned: mathias age: 1 year 17 weeks url: http://drupal.org/node/5900 / feature requests Novel Module Creation Request age: 3 days 10 hours url: http://drupal.org/node/24856 Provide a way to select a term from a vocabulary via a drop down list in a users profile age: 3 weeks 10 hours url: http://drupal.org/node/23601 moving pages en masse age: 10 weeks 6 days url: http://drupal.org/node/19754 Taxonomy module should use nodeapi 'load' age: 14 weeks 9 hours url: http://drupal.org/node/18631 Auto PHP memory maximisation age: 16 weeks 2 days url: http://drupal.org/node/17663 Don't reset existing password on request, prevent DoS password reset abuse age: 18 weeks 3 days url: http://drupal.org/node/16909 User info exposed to anonymous user age: 28 weeks 5 days url: http://drupal.org/node/13545 Allow named anchors to work without specifying full path to node age: 1 year 29 weeks url: http://drupal.org/node/4213 / support requests Please help me out i am stuck here :( assigned: neerajshokeen age: 5 weeks 4 days url: http://drupal.org/node/22227 Fatal error: Unknown column 'headers' in 'field list' query assigned: Eagle-i age: 13 weeks 1 day url: http://drupal.org/node/18928 Strange session behavior age: 13 weeks 3 days url: http://drupal.org/node/18821 user redirected to homepage when logging in age: 14 weeks 5 days url: http://drupal.org/node/18381 Problem with Forums age: 22 weeks 4 days url: http://drupal.org/node/15299 / bug reports Events seem to reappear in a crazy fashion in following months age: 12 hours 58 min url: http://drupal.org/node/25070 Events seem to reappear in a crazy fashion in following months age: 12 hours 58 min url: http://drupal.org/node/25069 search over fields.inc fields conceptual error age: 32 weeks 6 days url: http://drupal.org/node/12259 fields.inc screws up with multible multiselect fields age: 32 weeks 6 days url: http://drupal.org/node/12257 / feature requests event.module support of repeating/recurring events? assigned: thehunmonkgroup age: 1 year 30 weeks url: http://drupal.org/node/4122 / bug reports Menu item not showing age: 36 weeks 5 days url: http://drupal.org/node/11210 / bug reports segmentation fault related to filestore age: 1 year 37 weeks url: http://drupal.org/node/3001 / bug reports file size bug age: 5 days 18 hours url: http://drupal.org/node/24728 / support requests File store module - Overwriting Filename....Help needed assigned: harishkm age: 1 year 10 weeks url: http://drupal.org/node/6827 Unserialize error at line 104 age: 1 year 17 weeks url: http://drupal.org/node/5857 Filestore module- sql errors rectified assigned: harishkm age: 1 year 18 weeks url: http://drupal.org/node/5619 Filestore Module Problems unaddressed assigned: harishkm age: 1 year 20 weeks url: http://drupal.org/node/5365 / bug reports Gallery error age: 7 weeks 2 days url: http://drupal.org/node/21290 Fatal Error: variable_get() age: 12 weeks 3 days url: http://drupal.org/node/19189 No Gallery Image Block age: 12 weeks 6 days url: http://drupal.org/node/19045 Mini applet can't find gallery at url / age: 13 weeks 4 days url: http://drupal.org/node/18785 Fatal error: Undefined class name 'galleryembed' age: 16 weeks 1 day url: http://drupal.org/node/17746 / support requests Can't Embed Gallery into Drupal age: 15 weeks 3 days url: http://drupal.org/node/18029 / bug reports Drupal-4.4-rc breaks registration setups and groups.module age: 1 year 13 weeks url: http://drupal.org/node/6392 / bug reports Image module thumbnail/preview stop working after l10n age: 7 weeks 6 days url: http://drupal.org/node/21036 Cannot upload .jpgs age: 15 weeks 3 days url: http://drupal.org/node/18076 Image.Module does not know the correct filename age: 30 weeks 1 day url: http://drupal.org/node/13032 SAFE MODE Restriction in effect... age: 33 weeks 6 days url: http://drupal.org/node/11843 Uploading jpeg makes Imagemagick do high compression age: 35 weeks 3 days url: http://drupal.org/node/11445 Image module failing on Preview because of a blank node id age: 37 weeks 4 days url: http://drupal.org/node/11069 Similar problem with Directory Upload Slow age: 37 weeks 4 days url: http://drupal.org/node/11064 / support requests path problems on upgrading... age: 6 weeks 3 days url: http://drupal.org/node/21725 / bug reports Please update Node_Aggregator age: 12 weeks 5 days url: http://drupal.org/node/19096 Import doesn't like XML/RSS feeds with no Title element age: 1 year 2 weeks url: http://drupal.org/node/8128 / feature requests RSS items overwriting edited items age: 1 year 4 days url: http://drupal.org/node/8455 / feature requests Notify.module ignores the true submission queue age: 1 year 33 weeks url: http://drupal.org/node/3765 / feature requests Internationalization support for PDF assigned: TheLibrarian age: 1 year 11 weeks url: http://drupal.org/node/6795 / bug reports array bug in issue.inc when running on php5 age: 1 week 6 hours url: http://drupal.org/node/24602 Projects not listed and page not complete age: 2 weeks 1 day url: http://drupal.org/node/23956 Date for latest is incorrect age: 8 weeks 6 days url: http://drupal.org/node/20485 Invalid link to release files age: 16 weeks 3 days url: http://drupal.org/node/17625 Node body not complete w/o releases age: 18 weeks 5 days url: http://drupal.org/node/16733 blank page after install age: 19 weeks 1 day url: http://drupal.org/node/16575 "Page Not Found" when trying to view issues or add new release age: 27 weeks 6 days url: http://drupal.org/node/13815 Project pages display only title and description age: 30 weeks 7 hours url: http://drupal.org/node/13082 Fatal error: Cannot use string offset as an array in includes/tablesort.inc on line 113 assigned: publian age: 36 weeks 6 days url: http://drupal.org/node/11187 Can't create new project with issue tracker age: 43 weeks 21 hours url: http://drupal.org/node/10148 / support requests Help with everything - nothing seems to work in the latest build age: 29 weeks 2 days url: http://drupal.org/node/13310 / bug reports Can't get the inline tag to show series age: 5 weeks 1 day url: http://drupal.org/node/22520 / bug reports MySQL Error age: 11 weeks 6 days url: http://drupal.org/node/19413 javascrip downloads square.gif for every category age: 17 weeks 1 day url: http://drupal.org/node/17366 / feature requests Drupal Search usability improvement age: 3 weeks 6 days url: http://drupal.org/node/23185

1 0

[drupal-devel] [bug] user uploads photo to profile -> getimagesize(): Read error! in /includes/image.inc on line 88
by kbahey 16 Jun '05

16 Jun '05

Issue status update for http://drupal.org/node/24157 Project: Drupal Version: 4.6.0 Component: other Category: bug reports Priority: normal Assigned to: chx Reported by: lennart Updated by: kbahey Status: patch The patch fixes the problem. Had to apply the first hunk manually though on a 4.6.1 install. kbahey Previous comments: ------------------------------------------------------------------------ June 2, 2005 - 08:33 : lennart When a user tries to upload a photo to his or her profile the following error occurs in the log getimagesize(): Read error! in /includes/image.inc on line 88 I am using user.module and profile.module, but NOT image.module and upload.module GD2 is working. The problem is on a fresh 4.6.1 install without any contributed modules I did not know exactly what component to post this under, but I think it is important. ------------------------------------------------------------------------ June 2, 2005 - 11:57 : mariagwyn I am having the identical problem, except that I am using image.module. It happens anytime I click onto my images section. I get about 8 error messages, all the same. It this because images are missing? Any other reason? Thanks, Maria ------------------------------------------------------------------------ June 2, 2005 - 16:47 : rolfijn Me to! I've installed the image-module also and get the same error. I've allready given a 777 permision on my drupal directory, as to make sure it's not a permissions error. When i log into drupal and go to administration -> settings i have the following setting: File system path:files (which resolves to /home/httpd/html/drupal/files, right?) and Temporary directory: tmp (which resolves to /home/httpd/html/drupal/files/tmp, right?). Then going to administration -> settings -> image i see my Default image path: images (which resolves to /home/httpd/html/drupal/files/images, right?) I run trustix secure linux 2.2 with the following (relevant) components installed: apache-2.0.54-3tr apache-html-2.0.54-3tr php-cli-5.0.4-3tr php4-4.3.11-2tr php-pgsql-5.0.4-3tr php-gd-5.0.4-3tr php-imap-5.0.4-3tr php-5.0.4-3tr php4-pgsql-4.3.11-2tr php4-gd-4.3.11-2tr php4-imap-4.3.11-2tr postgresql-8.0.3-1tr postgresql-libs-8.0.3-1tr postgresql-server-8.0.3-1tr gd-2.0.33-3tr gd-utils-2.0.33-3tr I have no idea what the problem can be. Somebody? Thanks in advance, Rolf Deenen ------------------------------------------------------------------------ June 5, 2005 - 15:22 : Dublin Drupaller same problem....drupal 4.6.1. import images...giving a warning: getimagesize(): Read error! Anyone found a solution? Dub ------------------------------------------------------------------------ June 5, 2005 - 15:51 : Dublin Drupaller hi guys... I downloaded the latest image.module from the cvs repository...and it works.. http://cvs.drupal.org/viewcvs/drupal/contributions/modules/image_import/ The only down side is that it is in debug mode (which means a load of extra messages appear)...not sure how to switch that off...but, suffice to say that it looks like the owner/maintainer/developer of the the image_import module is on top of it. best to wait until the module developer updates the module. Dub ------------------------------------------------------------------------ June 5, 2005 - 16:07 : celticess I'm getting the same error but I think it only happens to the one user using the grey box theme. Otherwise I can't find any rhyme or reason to it. Everything seems to be displaying correctly. I have the various image modules installed though not the cvs(I am using drupal 4.6.1). And no pictures have been uploaded to the galleries for it even to give the error. Also I'm getting another include error and one module specific which I have also filed bug reports on. The other include error though is common.inc line 1308 and it seems no real reason for it to be pumping out that code either.(the module error occurs only when I tell it to show browsers in the stats filtering) I'm not exactly a php wiz... haven't programmed since the 80's actually so I have no idea why it's burping out these 3 errors I'm getting. My Drupal 4.6.1 is being run off of a debian site with php4 and mysql. I myself use gentoo linux(thinking about going to BSD) however my isp TOS forbids servers or I'd run it off my own box. ------------------------------------------------------------------------ June 6, 2005 - 21:43 : chueewowee I get the same error message with drupal 4.6.0 even with all content unpublished and all images deleted from the content. The error in all pages even when not creating content. I sue a custom theme, but have not altered anything relevant to images. In fact I am having terrible problems publishing images with the image.module and image_upload.module, in that the galleries do not show in the create pages etc.. as a number of people have reported. ------------------------------------------------------------------------ June 7, 2005 - 19:57 : occy Yeah, I'm getting the same thing. :/ One would think with so many people having the same issue someone would have responded with a fix. I guess maybe I'll try the CVS version. ------------------------------------------------------------------------ June 7, 2005 - 20:31 : celticess I put the cvs module in(I'm not running cvs drupal though just 4.6.1) in and so far that error now seems gone. However the other error I'm still getting and I've got that other annoying image related problem where you've told it to default to not promoting new uploaded images to front page but it still does it. Btw I wonder if the guys realize the directions for patch aren't too clear. I've used linux since '96 and am self taught. Oddly enough never had to use patch as things auto patch on gentoo. And I've now asked friends for plain english explaination of how to do that on my debian host. Why am I mentioning patch? Because if you guys are also having an issue with album someone has put out a patch. ------------------------------------------------------------------------ June 8, 2005 - 12:05 : lennart the problem is not specific to image.module ------------------------------------------------------------------------ June 8, 2005 - 15:17 : chx mage.inc , line 83, it's not file_exists but is_file . I suspect we'd better change theme_image also. Someone should roll a patch. Or I'll do when I have time :) ------------------------------------------------------------------------ June 12, 2005 - 14:21 : Robin Monks Attachment: http://drupal.org/files/issues/image.exist.patch (1.38 KB) Here is the patch per chx's comments, I made it for him as he didn't have time. He can answer any questions about it. Tested to work on HEAD. Robin ------------------------------------------------------------------------ June 13, 2005 - 22:48 : mariagwyn I am still having the same problem. I have tried to upload the new CVS files for image.inc, themes.inc, and common.inc, and added the patches listed above. However, I get even more errors with the other CVS files, so I reverted so I could do one thing at a time. If I just add the patch to image.inc and theme.inc, I simply get a blank screen. I am able to see my images, upload images, but if I click the /image link (the image gallery), it gives me a blank screen with the same error listed. I am running 4.6.1., using a custom theme. You may see the problem at: http://www.stnina.org/test/image I am not sure if I missed something. Suggestions? thanks, Maria ------------------------------------------------------------------------ June 13, 2005 - 23:03 : kbahey I faced the same issue today. A 4.6 install, with image.module. At first I thought it was because of my changes to the image module, but then the follow up email to this one popped up in my inbox with the same exact error in the title! Spooky!

1 0

[drupal-devel] [feature] Profile field visiblity should vary by role
by dmclark 15 Jun '05

15 Jun '05

Issue status update for http://drupal.org/node/14149 Project: Drupal Version: cvs Component: profile.module Category: feature requests Priority: normal Assigned to: ejort Reported by: sushi76 Updated by: dmclark Status: patch sorry if this is a nOOb question, but I try to apply the patch and get: patch: **** malformed patch at line 9: /** dmclark Previous comments: ------------------------------------------------------------------------ December 9, 2004 - 14:38 : sushi76 Currently there are only these three Options Private field, content only available to privileged users. (Admin users) Public field, content shown on profile page but not used on member list pages. (Everyone, but not in the member list) Public field, content shown on profile page and on member list pages. (Everyone, everywhere) It should be possible to set the visibilty of profile fields by user roles. ------------------------------------------------------------------------ March 6, 2005 - 16:40 : tulula I agree! If visibility is set by roles OR if the option is left up to the user to display their info at their discretion vs Admin at level of setting up profile fields. ------------------------------------------------------------------------ June 6, 2005 - 01:03 : ejort I agree that it should be possible to set visibility per role. There is profile data on my site that I want my organisation's committee members to see, but nobody else, there's information that I want only authenticated users to see, but not anonymous users etc. More than that, I think we should be able to set field editability by role also. There is data on my site that only certain people should be able to edit. If we get to this point then this would be a superset of the functionality discussed in the PROFILE_HIDDEN updates [1] thread, but would be much more flexible. [1] http://drupal.org/node/21219 ------------------------------------------------------------------------ June 10, 2005 - 04:07 : ejort Attachment: http://drupal.org/files/issues/profile.module.role_based_field_permissions.… (12.97 KB) Hi, Here's a patch which implements role based edit / access permissions for profile fields. It allows you to give permissions to each role (and for each field) to: * access a field (for all accounts) * access a field for your own account * edit a field for your account Users with permission 'administer users' can access / edit all fields, and users must have enough permission to edit/access a profile for these extra permissions to come into effect. I believe this allows for more flexibility than the existing profile.module method of PROFILE_PRIVATE and in HEAD PROFILE_HIDDEN. You can eg: * hide some fields from anonymous users, while allowing other roles to still view that info * have fields viewable by only the admin and user who owns the account (like PROFILE_PRIVATE * have fields viewable by some roles, but only editable by the admin * have fields hidden from all except the admin, and editable only by the admin * it will make you more attractive to the opposite sex etc. I'm developing this because I need it for one of my sites, hence, unfortunately this patch is against the 4.6 profile.module. If people think this is a valuable feature for HEAD I can roll a patch against that. Cheers, Eric ------------------------------------------------------------------------ June 10, 2005 - 05:13 : Bèr Kessels I am not too sure about this. A typical profile contains between five and 10 fields, but twenty fields is not unheard of. This patch will flood the permissions screen unnneccesary. I would opt for the hard way: An advanced profile module, or CRM module, or so. hat module could implemen,t all sorts of advanced levelled permissions. In order to maintain a high level of usability in core, we should try to minimize options and checkboxes. I know from flexinode, which adds similar dynamic permissions, that the interface for permissions is really not up to this big amount of permissions. I really think such things should not be in core. Buty that all said, it /is/ a handy feature :) ------------------------------------------------------------------------ June 10, 2005 - 05:53 : ejort Yes, unfortunately it can add a large number of permissions to the permissions page. I did consider trying to place the permission selections on each fields edit page instead (similar to the visibility settings), but as a certain eminent author recently wrote* [2]: "please use *only* the permissions page to set permissions, and do not create new permissions-alike settings in any configuration pages " :-) I think that the PROFILE_PRIVATE and PROFILE_HIDDEN (and the PROFILE_PUBLIC_*) settings are currently doing just that, implementing an alternate permissions system which addresses a few use cases, but is ultimately not particularly flexible. Is there any chance that the permissions sections can benefit from some collapsible goodness to alleviate the flooding? I think it's a shame to reduce the systems flexibility because it may create 'too many' permissions settings, especially as it is generally a set once and forget proposition. Perhaps we should look at the underlying UI problem? *That would be Bér :-) [2] http://drupal.org/node/22565#comment-32248 ------------------------------------------------------------------------ June 10, 2005 - 09:27 : Bèr Kessels Ejort, I know i wrote that. However, this is a little bit different. am not saying you should make a new system for changing the apperance of profile fields. I am only saying that having per-profile-field permissions is: * way OTT for the big mayority of users * extremely cluttering for the permission page (which, essetially is a problem in that interface, not in your "feature") ------------------------------------------------------------------------ June 14, 2005 - 11:22 : ejort I don't agree that this is extremely off topic for most users. A large number of people using drupal in any business setting will likely find the extra flexibility invaluable (and the use cases popping up in discussions for regarding PROFILE_HIDDEN show that the current approach doesn't cover enough of the possibilities). I've worked on multiple jobs where I had to create contact lists and employee profiles where basic information was accessible to the public (name, work email, profile text), certain details (direct phone numbers) were only visible to internal company employees, other data (mobile phone numbers) were visible only to team leaders, other data (next of kin contact details) were only visible to an admin, and the user wasn't allowed to edit certain items (such as the public profile text). I've had similar needs come up across several jobs, but then again I wrote the patch so of course I needed it! :-) I also believe that the permissions page problem isn't too large an issue. The permissions are created in response to the admin creating profile fields (3 per field, 'access', 'access own', 'edit'), so the page has no extra permissions by default. This also isn't an interface that is accessed on a daily basis, and there is a good visual separation of the sections so it is easy to skim past the longer profile section if that's not what you're interested in. Of course, this is all just my opinion, and I'm a biased observer :-) ------------------------------------------------------------------------ June 14, 2005 - 11:37 : Bèr Kessels I know its a handy feature, that will be used in some cases. But then it should nbe in an advanced-profile.module. Not in core. ------------------------------------------------------------------------ June 14, 2005 - 12:12 : judah I would have to disagree with you ber on this one. I have posted some comments on the Hidden Profile update mentioned above. The permission system *should* be apart of core. These shouldn't be broken out into another advanced module. There *shouldn't* be a node_privacy_by_role. This is unheard of in other systems. I have worked on many other cms solutions and permissions is always a part of the design. Should we plaster them on every feature? No. But we should not so easily dismiss this issue. Node privacy by role and field privacy by role should be considered more closely as a core function rather than where it is now. IMHO. Having said that I do understand the need to break things or branch things too. So it is up to you designers to consider this. Assuming this patch gets approved I would suggest you make the role assignment options available on the profile edit page if it's not already. ------------------------------------------------------------------------ June 14, 2005 - 17:09 : killes(a)www.drop.org judah: Drupal has the benefit that we can use any node access scheme we like by using another module. @all: I think the best thing would eb to make profiles nodes and wait for cck for field based permissions. ------------------------------------------------------------------------ June 15, 2005 - 07:19 : Bèr Kessels I think an interim solution would be to: * make profiles nodes * use Flexinode if one wished for profiles . otherwise use a dediceated node for this * add per field permissions to flexinode. ------------------------------------------------------------------------ June 15, 2005 - 10:14 : Boris Mann I think that profile does indeed need to be re-vamped at some point, and making it a node is likely the right way to go -- then we can benefit from all the field-level work that is going on as we head towards CCK. This is a good interim patch, and should likely be applied to HEAD until someone comes up with the one true profile node -- following our motto to commit things a little earlier so that they can get some testing and use, rather than waiting forever. I know we have a need for it right now as well, and so will help keep this up to date. The one issue is the UI for permissions. It should probably be a separate screen, rather than access control. I would put it directly in the per-field edit screen (e.g. admin/setting/profile/edit/1) or be a permission tab (e.g. admin/setting/profile/permissions). ------------------------------------------------------------------------ June 15, 2005 - 13:22 : fago the profile node sounds good. i think it's also good to have the possibility to define profile fields for different roles only, so that every role has its own profile. i've done recently a site, where i needed very extended profiles - so i wrote a profile.module based on the drupal profile.module which does this and a lot of other customized stuff.. i also introduced profile-fields, which can be edited only by user with "administer users", as mentioned here. i think, you might run into same problem i did: i already mentioned this issue [3] i'm using this patch, i posted there, on this site. otherwise a user could just inject data, with the same name as admin-only-field, in the user-data field, which will be loaded in the user object by user_load(). further profile_load_profile won't overwrite the value.. [3] http://drupal.org/node/21515

1 0

[drupal-devel] [bug] Last access time reports the epoch instead of 'never'
by deekayen 15 Jun '05

15 Jun '05

Issue status update for http://drupal.org/node/24766 Project: Drupal Version: cvs Component: user system Category: bug reports Priority: minor Assigned to: deekayen Reported by: puregin Updated by: deekayen Status: patch the rest of that comment is: [less than or equal to zero] would be valid times. To track whether someone visited or not, you'd have to store a new boolean for Visited/Not Visited. the [less than or equal to] sign I put in the comment got filtered out and cropped. Is that a known issue? deekayen Previous comments: ------------------------------------------------------------------------ June 10, 2005 - 12:32 : puregin As site admin, I create a user. When I look at the user admin page immediately afterwards, the user shows up with a 'last access' time of '35 years 24 weeks ago'. Could we report 'Never' instead of the epoch, if the last access time is older than the user account? I seem to recall a similar report, but I couldn't find it after searching through the issues for user.module, and issues in general. Djun ------------------------------------------------------------------------ June 14, 2005 - 02:01 : deekayen Attachment: http://drupal.org/files/issues/wrong_last_access.png (6.13 KB) I verified this on WinXP/PHP5.1. Screenshot attached. ------------------------------------------------------------------------ June 14, 2005 - 02:22 : deekayen Attachment: http://drupal.org/files/issues/epochuser.patch (1.17 KB) Attached patch shows "never" instead of epoch on new users with 0 as last visited value in the DB ------------------------------------------------------------------------ June 15, 2005 - 00:16 : puregin The patch fixes the problem, thanks. Are there other places in Drupal where this kind of message might occur? Is it possible for the timestamp to be negative under any circumstances (if so, perhaps the test should be $account->access <= 0 rather than $account->access == 0) Regards, Djun ------------------------------------------------------------------------ June 15, 2005 - 11:28 : deekayen I could see how the timestamp might be negative if the DB record were a page you wanted to back-date, but here we're talking about a triggered action. I think it would make about as much sense for this to be negative as it would to see something in your Apache logs date back to 1834. Besides, if the timestamp could be less than 0, you're taking about a whole new issue of the validity of using epoch to store time instead of a date/timestamp, because then

1 0