June 2005 - Development - lists.drupal.org

[drupal-devel] [feature] Path aliases - controlling outgoing alias
by mikeryan 09 Jun '05

09 Jun '05

Issue status update for http://drupal.org/node/24321 Project: Drupal Version: cvs Component: path.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: mikeryan Updated by: mikeryan Status: patch Attachment: http://drupal.org/files/issues/alias_0.patch (6.63 KB) Here's a patch to implement 2/3 of my previous suggestions [1]. 1. A *status* column is added to the url_alias table. A 0 (zero) value indicates an alias explicitly created by a user or administrator; a 1 (one) value indicates an alias created by an automated process. No core code support is required here - aliases created by core methods (the node form or url aliases settings) will default to 0. The pathauto module (or any other module that wishes to automatically generate aliases) will create them with a status of 1, and when updating aliases will only delete/modify aliases with a status of 1, so that aliases created explicitly by users are not blown away. 2. A *weight* column is added to the url_alias table. As path aliasing exists now, multiple aliases may be created for a given path but there is no control over which one is generated in the outgoing direction (as in listings). This patch adds the support for editing weights for aliases to the url aliases settings (and both *status* and *weight* become optional arguments to path_set_alias()), and drupal_lookup_path() is modified to pick the lowest weighted alias in response to an 'alias' call (if there's a tie for lowest weight, it's the same result as before, which is most likely lowest pid === first created). I really wanted to implement a method for having aliases that produce a 301 (Move Permanently) response, particularly if you want to change the alias for a page without abandoning any bookmarks/search engine links that are already out there - but I started on it and realized it will require more thought to integrate cleanly... It might just be easier to do that using conf_url_rewrite()... Thanks for your consideration... [1] http://drupal.org/node/22352 mikeryan

3 4

[drupal-devel] Release critical bugs for June 09, 2005
by drupal-devel＠drupal.org 09 Jun '05

09 Jun '05

/ bug reports email spam filtering does not "see" email addresses when they are NOT preceded by a word age: 20 weeks 4 days url: http://drupal.org/node/15654 / bug reports admin/modules page: modules not activating age: 2 days 5 hours url: http://drupal.org/node/24428 Accidentally Deleting Forums Vocabulary in Categories Breaks Forums? age: 5 days 1 hour url: http://drupal.org/node/24274 Taxonomy Multiple Hierarchy doesn't display children for all its parent age: 1 week 1 day url: http://drupal.org/node/24023 Caching and garbage in cache table (gzipped?) age: 1 week 2 days url: http://drupal.org/node/23925 Multiple Hierarchy doesn't display children for all its parent age: 1 week 5 days url: http://drupal.org/node/23770 "Welcome to Drupal" page won't disappear after first post & proper access permissions age: 2 weeks 5 days url: http://drupal.org/node/23296 In some case, "Recent comment" is not linked to THE COMMENT refered to. age: 3 weeks 14 hours url: http://drupal.org/node/23136 Tagging Issues age: 3 weeks 2 days url: http://drupal.org/node/23026 Forum post not visible assigned: mohaqa age: 3 weeks 2 days url: http://drupal.org/node/22960 Error in TEMP DIRECTORY age: 3 weeks 3 days url: http://drupal.org/node/22916 PG_QUERY ERROR - LOCK TABLES - IMPLEMENTATION FAULT. age: 3 weeks 3 days url: http://drupal.org/node/22911 Search memory limit problems after 4.6 upgrade age: 4 weeks 1 day url: http://drupal.org/node/22497 Warning: Wrong parameter count for mysql_connect() assigned: jselva(a)drupal.org age: 4 weeks 5 days url: http://drupal.org/node/22188 Podcasting feeds broken age: 5 weeks 1 day url: http://drupal.org/node/21924 Forum icon support is broken age: 5 weeks 1 day url: http://drupal.org/node/21918 Teaser problem assigned: childhood age: 7 weeks 1 day url: http://drupal.org/node/20843 UTF-8 node title gets truncated at wrong position age: 7 weeks 5 days url: http://drupal.org/node/20537 database table "term_node" not updated when removing a term from a node under editing and submitting age: 8 weeks 2 days url: http://drupal.org/node/20315 Attached files can not be deleted age: 8 weeks 2 days url: http://drupal.org/node/20307 Reassigning a node to a different term does not work properly age: 8 weeks 3 days url: http://drupal.org/node/20278 4.6 aggregator showing/not interpreting HTML tags age: 9 weeks 4 days url: http://drupal.org/node/19874 New submit error, non-admin user, postgresql database assigned: adrian age: 13 weeks 1 day url: http://drupal.org/node/18552 When I delete a user, any forum in which s/he has commented also disappears. assigned: Jill6q age: 16 weeks 9 hours url: http://drupal.org/node/17428 Change to sesssion.inc violates UID database constraint age: 20 weeks 4 days url: http://drupal.org/node/15666 forum.module problem with postgresql v7.4.1 age: 21 weeks 2 days url: http://drupal.org/node/15411 PHP 5 gives error when session table has no session assigned: adschar age: 21 weeks 2 days url: http://drupal.org/node/15399 postgresql error age: 22 weeks 4 hours url: http://drupal.org/node/15175 Entering an empty title broke drupal age: 29 weeks 2 days url: http://drupal.org/node/12974 Argument NOT must be type boolean age: 29 weeks 2 days url: http://drupal.org/node/12950 Comments in approval queue still show up in tracker age: 33 weeks 4 days url: http://drupal.org/node/11647 Twin problems with comments assigned: Junyor age: 34 weeks 6 days url: http://drupal.org/node/11366 Prevent browser page caching of dynamic content assigned: mathias age: 1 year 16 weeks url: http://drupal.org/node/5900 / feature requests MySQLi age: 5 days 6 hours url: http://drupal.org/node/24264 Provide a way to select a term from a vocabulary via a drop down list in a users profile age: 2 weeks 10 hours url: http://drupal.org/node/23601 Add a footer that is specific to a particular book, shown only on certain pages age: 9 weeks 6 days url: http://drupal.org/node/19757 moving pages en masse age: 9 weeks 6 days url: http://drupal.org/node/19754 Taxonomy module should use nodeapi 'load' age: 13 weeks 9 hours url: http://drupal.org/node/18631 Auto PHP memory maximisation age: 15 weeks 2 days url: http://drupal.org/node/17663 Don't reset existing password on request, prevent DoS password reset abuse age: 17 weeks 3 days url: http://drupal.org/node/16909 User info exposed to anonymous user age: 27 weeks 5 days url: http://drupal.org/node/13545 Allow named anchors to work without specifying full path to node age: 1 year 28 weeks url: http://drupal.org/node/4213 / support requests Please help me out i am stuck here :( assigned: neerajshokeen age: 4 weeks 4 days url: http://drupal.org/node/22227 Fatal error: Unknown column 'headers' in 'field list' query assigned: Eagle-i age: 12 weeks 1 day url: http://drupal.org/node/18928 Strange session behavior age: 12 weeks 3 days url: http://drupal.org/node/18821 user redirected to homepage when logging in age: 13 weeks 5 days url: http://drupal.org/node/18381 Problem with Forums age: 21 weeks 4 days url: http://drupal.org/node/15299 / bug reports search over fields.inc fields conceptual error age: 31 weeks 6 days url: http://drupal.org/node/12259 fields.inc screws up with multible multiselect fields age: 31 weeks 6 days url: http://drupal.org/node/12257 / bug reports Menu item not showing age: 35 weeks 5 days url: http://drupal.org/node/11210 / bug reports segmentation fault related to filestore age: 1 year 36 weeks url: http://drupal.org/node/3001 / support requests File store module - Overwriting Filename....Help needed assigned: harishkm age: 1 year 9 weeks url: http://drupal.org/node/6827 Unserialize error at line 104 age: 1 year 16 weeks url: http://drupal.org/node/5857 Filestore module- sql errors rectified assigned: harishkm age: 1 year 17 weeks url: http://drupal.org/node/5619 Filestore Module Problems unaddressed assigned: harishkm age: 1 year 19 weeks url: http://drupal.org/node/5365 / bug reports Gallery error age: 6 weeks 2 days url: http://drupal.org/node/21290 Fatal Error: variable_get() age: 11 weeks 3 days url: http://drupal.org/node/19189 No Gallery Image Block age: 11 weeks 6 days url: http://drupal.org/node/19045 Mini applet can't find gallery at url / age: 12 weeks 4 days url: http://drupal.org/node/18785 Fatal error: Undefined class name 'galleryembed' age: 15 weeks 1 day url: http://drupal.org/node/17746 / support requests Can't Embed Gallery into Drupal age: 14 weeks 3 days url: http://drupal.org/node/18029 / bug reports Drupal-4.4-rc breaks registration setups and groups.module age: 1 year 12 weeks url: http://drupal.org/node/6392 / bug reports Image module thumbnail/preview stop working after l10n age: 6 weeks 6 days url: http://drupal.org/node/21036 Cannot upload .jpgs age: 14 weeks 3 days url: http://drupal.org/node/18076 Wrongly formed html in image gallery age: 15 weeks 6 days url: http://drupal.org/node/17462 Image.Module does not know the correct filename age: 29 weeks 1 day url: http://drupal.org/node/13032 SAFE MODE Restriction in effect... age: 32 weeks 6 days url: http://drupal.org/node/11843 Uploading jpeg makes Imagemagick do high compression age: 34 weeks 3 days url: http://drupal.org/node/11445 Image module failing on Preview because of a blank node id age: 36 weeks 4 days url: http://drupal.org/node/11069 Similar problem with Directory Upload Slow age: 36 weeks 4 days url: http://drupal.org/node/11064 / support requests path problems on upgrading... age: 5 weeks 3 days url: http://drupal.org/node/21725 / bug reports Please update Node_Aggregator age: 11 weeks 5 days url: http://drupal.org/node/19096 Import doesn't like XML/RSS feeds with no Title element age: 1 year 1 week url: http://drupal.org/node/8128 / feature requests RSS items overwriting edited items age: 51 weeks 5 days url: http://drupal.org/node/8455 / feature requests Notify.module ignores the true submission queue age: 1 year 32 weeks url: http://drupal.org/node/3765 / feature requests Internationalization support for PDF assigned: TheLibrarian age: 1 year 10 weeks url: http://drupal.org/node/6795 / bug reports array bug in issue.inc when running on php5 age: 6 hours 5 min url: http://drupal.org/node/24602 Projects not listed and page not complete age: 1 week 1 day url: http://drupal.org/node/23956 Date for latest is incorrect age: 7 weeks 6 days url: http://drupal.org/node/20485 Invalid link to release files age: 15 weeks 3 days url: http://drupal.org/node/17625 Node body not complete w/o releases age: 17 weeks 5 days url: http://drupal.org/node/16733 blank page after install age: 18 weeks 1 day url: http://drupal.org/node/16575 "Page Not Found" when trying to view issues or add new release age: 26 weeks 6 days url: http://drupal.org/node/13815 Project pages display only title and description age: 29 weeks 7 hours url: http://drupal.org/node/13082 Fatal error: Cannot use string offset as an array in includes/tablesort.inc on line 113 assigned: publian age: 35 weeks 6 days url: http://drupal.org/node/11187 Can't create new project with issue tracker age: 42 weeks 21 hours url: http://drupal.org/node/10148 / support requests Help with everything - nothing seems to work in the latest build age: 28 weeks 2 days url: http://drupal.org/node/13310 / bug reports Can't get the inline tag to show series age: 4 weeks 1 day url: http://drupal.org/node/22520 / bug reports MySQL Error age: 10 weeks 6 days url: http://drupal.org/node/19413 javascrip downloads square.gif for every category age: 16 weeks 1 day url: http://drupal.org/node/17366 / feature requests Drupal Search usability improvement age: 2 weeks 6 days url: http://drupal.org/node/23185

1 0

[drupal-devel] [feature] export book as xml for formatting
by muralik 09 Jun '05

09 Jun '05

Issue status update for http://drupal.org/node/1482 Project: Drupal Version: cvs Component: book.module Category: feature requests Priority: normal Assigned to: puregin Reported by: BenEng Updated by: muralik Status: patch when i patch, i get this error, any clues? failed at line 321 muralik Previous comments: ------------------------------------------------------------------------ April 5, 2003 - 21:38 : BenEng Export an entire collaborative book to xml (docbook) so that it can be formatted using xslt (e.g., to rtf or pdf) and printed. It would also be nice to be able to perform the reverse. That is to import a collaborative book from an xml (docbook) file that is uploaded. ------------------------------------------------------------------------ June 3, 2004 - 00:10 : moshe weitzman can someone suggest an xml schema for this? i think we need a general xml schema for nodes. after that, this becomes a simple matter of nesting node elements (I think) ------------------------------------------------------------------------ February 1, 2005 - 09:42 : Teto Hi, Is there any news about a such feature ? All i've found about a docbook schema is here : http://docbook.sourceforge.net/projects/schema/ It seems there isn't much in the docbook cvs about that. Teto. ------------------------------------------------------------------------ May 14, 2005 - 09:11 : puregin Here's a list of the Book publishing DTDs I know about: NameNotesRef ISO 12083:1998//DTD Book//EN - this includes ISO 12093:1993//DTD Mathematics//EN Committee standard - very general. Used e.g. by University of California Press. www.xmlxperts.com/bookdtd.htm [1] DocBook Applications - widely used by Computer book publishers, e.g. O'Reilly. Good support. docbook.org [2] TEI/TEI-Lite Applications - scholarly/historical/literary documents www.tei-c.org [3] MIL-STD-38784 (CALS) Applications - Military/Govt/Enterprise publishing http://xml.coverpages.org/mil-std-38784-a1-dtd.txt [4] I'd highly recommend DocBook as a useable, technically focused, XML DTD with strong toolset support. [1] http://www.xmlxperts.com/bookdtd.htm [2] http://docbook.org [3] http://www.tei-c.org/ [4] http://xml.coverpages.org/mil-std-38784-a1-dtd.txt ------------------------------------------------------------------------ May 18, 2005 - 08:37 : puregin I'd suggest we start with something very simple. The patch which I submitted for http://drupal.org/node/1898 wraps each node in <div> tags, with a level, and a node id attribute, for printer friendly output. We can't rely in general on the contents of a node being XHTML, even if we force output through an XHTML validator such as tidy. So our best bet is to encode the entire contents of a node as CDATA. This gives us hierarchy, and encapsulated contents (of any kind - later this could also be other kinds of data or markup) This output will be valid XML, with a pretty simple DTD. It is easy to take such a file and write simple XSLT based scripts on the the client side to explode this file into a directory tree of HTML, a single HTML file, or many other formats. Importing is trickier. It's relatively easy to import an exported file, and update the nodes of the book according to the hierarchy defined by the sectional <div> elements. Importing needs to take care of structure which has changed - child nodes added, deleted, or moved. It would also be nice to have some client-side scripts to import other formats into this nested sectional <div> based format - for example, to take a directory tree of HTML fragments, and make this into an importable file. ------------------------------------------------------------------------ June 1, 2005 - 10:33 : puregin Attachment: http://drupal.org/files/issues/xml-export.patch (14.06 KB) This patch enables export of books as XML documents. The XML is DocBook "at the level of structure", but node contents are wrapped as CDATA, since we can't be sure that the contents are valid XML. Several other bugs/feature requests are also addressed with this patch: - Fixes bugs http://drupal.org/node/1898 http://drupal.org/node/1482 http://drupal.org/node/8049 http://drupal.org/node/1899 Should go a long way towards implementing feature request http://drupal.org/node/2062 It should also be easy to extend this to produce OPML, for example. - Adds about 170 lines, of which more than 100 are comments - Added doxygen comments - Made doxygen comment format consistent; fixed minor grammatical slips - A proper Doctype and more informative HTML element is generated for printer-friendly HTML output. - Refactored book_print() to use book_recurse(). - Refactored book_recurse(). Applies 'visitor' callback functions to nodes during weight/title order tree-traversal. The parameterized visitor callbacks can be used to generate different kinds of output. There are many other kinds of operations on books which can be implemented by writing a pre-node/post-node pair of callback functions: word-count/ statistics gathering, comparison, copying, search and replace... - Introduced book_export() which uses book_recurse() to generate DocBook-like XML to export book contents in a structured form. An md5 hash is computed for each node to help import code to decide if a node needs to be updated or not. ------------------------------------------------------------------------ June 3, 2005 - 08:29 : puregin Attachment: http://drupal.org/files/issues/xml-export-01.patch (14.19 KB) This updated patch adds "weight" metadata, which I forgot to capture in the previous patch. I'm not sure how much other metadata I should include. ------------------------------------------------------------------------ June 3, 2005 - 09:06 : puregin Attachment: http://drupal.org/files/issues/explode2dir.php (6.64 KB) The attached command-line PHP script may be useful in testing the XML export patch supplied. Assuming your local version of PHP is built with CLI support and XML parser support, you should be able to run the script against an XML export file generated by the book module with my patch. After you have installed the patch, you can select a book page, click on the 'export XML' link, and save the result as a file, say 'test.xml'. Then run the script. On my system this looks like this: % ./export2dir.php test.xml This will produce output that looks something like this: ./explode2dir.php test.xml md5: 9e8ca98c6a8be35c21f31f7937608acc weight: 1 md5: 11a1956a1592feac37abee6b469e62c8 weight: 0 md5: ed4c91279d3bed28b56899b75ccaa9aa weight: 0 It will generate a directory hierarchy, with one directory per book node. Each directory contains a file containing the node contents and a file 'nid' containing the metadata. You can check, for example, that the md5 signature of the contents match the md5 signature recorded with the metadata. Djun ------------------------------------------------------------------------ June 3, 2005 - 18:46 : Dries I like the approach taken in this patch! Let's tidy up the menu structure. I suggest changing book/export (docbook) book/print (plain-text) to export/docbook export/text If we add OPML-support, it would then become: export/opmlSimilarly, I suggest renaming 'export XML' to 'export DocBook XML' (or something). ------------------------------------------------------------------------ June 3, 2005 - 18:53 : Dries Haven't tried it but how does DocBook handle CDATA? Does it come out OK? Read: does it make sense to do it this way? ------------------------------------------------------------------------ June 3, 2005 - 23:04 : puregin Dries, The output XML which I've implemented is only 'DocBook-like', not true DocBook. I've been dealing with structure at the top level (book, chapter, section). I've hidden away the actual content inside a CDATA section. The XML is really intended to provide a container for export. At this point I'm trying to focus on a relatively simple way to do an export/import round trip of the current content format (text/'loose' HTML). Most people would probably not edit this using an XML editor. I think I can generate a tar/gzip archive of the directory structure I described (output of explode2dir.php) directly on the server, either by calling an external pipeline, or by using the tar/gzip PEAR extension. So the XML format I described would be useful primarily as means to do the /import/, unless we can think of a better way to import such a directory structure (perhaps via the node_import module?) How the CDATA section is handled depends on the application. Most XML editors will display this as CDATA, allow the user to edit as CDATA, and to perform edit operations such as cut/paste to convert the CDATA to other XML elements. DocBook formatting applications could do various things - ignore the CDATA; format as 'preformatted', e.g., source listing; or try to do something clever, like attempting to parse and convert the CDATA into real DocBook before proceeding. To generate true DocBook, we would have to: * emit a document type declaration * decide if we want to export complete documents (i.e., top level elements such as books, articles, set) or document fragments. The real difficulty is dealing with the /content/: to convert this into DocBook, we'd have to attempt to map (possibly not well formed) text and/or HTML into well-formed DocBook XML. This would require guessing in many cases, since text/HTML doesn't directly encode the author's intent. A problem with this would be that the content might not be returned exactly as exported in an (export/import) 'round trip' . If we want to support true DocBook, it would probably be better to do this via an input filter, similar to the PHP input filter - definitely worth pursuing, but perhaps a separate issue? I will rewrite the patch to make sure that the exported XML validates as a DocBook fragment, and punt off to people who actually want to deal with real DocBook the problem of embedding and converting content. These folks would probably not so interested in round-trip import/export, until we have native DocBook nodes, at which point many of these issues vanish (I hope :) Regards, Djun ------------------------------------------------------------------------ June 4, 2005 - 00:01 : Amazon As an active member of the documentation team I would greatly appreciate any ability to export and import content to and from the documentation handbooks. Drupal is slow for editing, and has some usability issues that I will be following up on. Please consider accepting this as a incremental step to assisting the documentation team and other editors. Kieran ------------------------------------------------------------------------ June 4, 2005 - 07:28 : Dries If the goal is to generate books, DocBook-export is key. However, if the output is only DocBook-like, it is only going to be used by a handful of people. I think the code comments should mention that it is only DocBook-like. If the goal is to import/export books, OPML might be the better choice. I think book syndication (publish/subscribe) is going to be the more popular. Either way, let's clean up the URL scheme and extend the book_help() function a bit (if not already). ------------------------------------------------------------------------ June 5, 2005 - 11:00 : Dries I made some changes (URL scheme) and committed this patch to HEAD. Please update your tree before making more changes. - Can you update the issues affected by this commit? - I wonder why the release info (md5-sum) isn't stored at XML attributes so it can be parsed/extracted easily. Probably DocBook-specific. - Firefox did not recognize the XML document as being XML. I think we might have to send the proper headers: drupal_set_header('Content-Type: text/xml; charset=utf-8');. Haven't checked yet. Great work Djun. ------------------------------------------------------------------------ June 6, 2005 - 09:18 : puregin Attachment: http://drupal.org/files/issues/xml-export-03.patch (22.3 KB) Thanks, Dries. Here is a new patch, against revision r1.299. - now generate value DocBook XML (fragments). Level 0 nodes are exported as books; level 1 as chapters, and level 2 and higher as sections. Content is still wrapped as CDATA, for the moment. I am working on code to generate proper DocBook from HTML, but this will require 1) Tidy, HTMLCorrector or something of the sort, to ensure that the HTML is well-formed XHTML; and 2) XSLT support enabled for PHP. I assume that this will need to be a packaged as a contributed module? - generate OPML (titles only) - issue Content-type: text/xml headers for XML output (DocBook, OPML) - changed URL scheme (single callback for all exports, takes export type as 1st argument) - merged book_export_html and book_export_xml into a single function book_export with 'switch()' logic to handle different output formats, to support the above URL scheme. So for example, book/export/html/154 will generate printer friendly HTML, while book/export/docbook/154 generates DocBook. - added function _book_get_depth($nid) which computes the absolute depth of a node in a book hierarchy - printer-friendly HTML is now generated with the exported node embedded to its absolute depth (e.g., level 3 nodes will always be marked-up as level 3 nodes) - changed name book_node_visitor_print -> name book_node_visitor_html - added parameter depth to 'post-node' visitor function call - fixed incorrect parameter to node_invoke_nodeapi() - changed 'view' to 'print' so as to avoid rendering book navigation in printer friendly (or other export format) output. - Added the new admin/help documentation, updated to include the XML export functionality.

1 0

[drupal-devel] CivicSpace Boston Meetup
by Chris Messina 09 Jun '05

09 Jun '05

Thanks to the gracious help from folks like Erik Hopp, Holmes Wilson, Amanda Michel, Rich Cowan and others, we're going to be staging an informal CivicSpace meetup at the Berkman Center next Tuesday, June 14 at 4pm. More details (feel free to pass around and RSVP): Evite: http://www.evite.com/pages/invite/viewInvite.jsp?event=VLXCZNBPETWNSOFQJDEI Upcoming: http://upcoming.org/event/21779/ Questions? Coming? Let me know! Chris

1 0

Re: [drupal-devel] [drupal-support] can't update the link in weblinks in Drupal 4.6
by Wilbert Berendsen 08 Jun '05

08 Jun '05

On Wednesday 08 June 2005 15:56, Wilbert Berendsen wrote: > Hi, > > I try to change some weblinks, but it seems Drupal does not save the > new URL when I change it. > > Drupal does save the body if I change it. It does not have to do with > caching, because even if I use the command line mysql client, I can see > the urls are not changed. No errors are reported in the Drupal log. > > Is this a bug? > > regards, > Wilbert I reported and, maybe, fixed the bug: http://drupal.org/node/24567 Please have a look if my fix is correct. regards, Wilbert -- Wilbert Berendsen (http://www.wilbertberendsen.nl/) Blijf de baas op je eigen PC met Linux en KDE: http://www.kde.nl/ Gratis Office met PDF en Flash export: http://nl.openoffice.org/

1 0

Re: [drupal-devel] Rewriting use of forms in Drupal
by Grugnog 08 Jun '05

08 Jun '05

> > > For example, my recipe module has a table in it. Each row of that > > > table has 3 input fields in it. I dread to think what the code looks > > > like to generate that with an array of controls. > > > > I currently have no solution for this. As my proposal is now, you'd need > > to tell your theme what to do with the individual fields. An idea is to > > have form() (which would become theme_form()) call a "form layout" > > hook. Hmmmm. > > I've discussed a bit with Adrian. I think the current solution would be > to add simple form items to a form group in _nodeapi('form pre') and > then in your theme do the table layout for that group. > > The backdraw would be that all people would have to modify their themes > to use your module. > > Themers to the front: Can we avoid this? Why not use a tableless css form layout that works without people needing to modify their theme, yet allows them to wrap it up in tables to display it another way if they so desire. e.g. in: http://www.quirksmode.org/css/forms.html http://www.cssdrive.com/index.php/examples/exampleitem/tableless_forms/ The label, form and fieldset tags could be fed to the theme separately, so by default the theme would just spit them out and they would be rendered reasonably by a snippet of css in drupal.css. If themers desire, however they can trap each/any tag and wrap them up in tables, spans, divs, or whatever they want. - Grug

1 0

[drupal-devel] Rewriting use of forms in Drupal
by Gerhard Killesreiter 08 Jun '05

08 Jun '05

Hi there! What follows is a proposal I sent to Dries before the security releases were made. Since it hinted at the possibility of flaws in our current way of handling forms I didn't want to make it available for public viewing at that time. There are probably still errors in some forms, but the most serious exploits should be fixed now. Although the proposal is geared towards node forms, it could be easily extended for other forms. Feedback would be appreciated. Instead of $output .= form_textfield(t('Title'), 'title', $edit->title, 60, 128, NULL, NULL, TRUE); we'd write $output['title'] = array('type' => 'textfield', 'title' => t('Title'), 'name' => 'title', 'value' => $edit->title, 'size' => 60, 'maxlenght' => 128, 'decription' => NULL, 'attributes' => NULL, 'required' => TRUE ); (We could add a 'group' element to indicate elements that should be grouped together, also a weight). Only in form() itself we'd generate the html. form() should be a themable function. What would that buy us? a) Easier value checking. In _validate we would then build the form a second time to check that all the fields still have the type and value they are supposed to have. foreach ($form_elements as $name => $value) { switch($value['type']) { case 'textfield': if (!is_string($edit['value'])) { form_set_error(...); } if (is_empty($edit['value']) && $value['required']) { form_set_error(...); } break; case 'textarea': .... } } (special checks such as "authored by" can be done here, possibly add another hook to get cleaner code) This would eliminate form problems such as the ones we are fixing in the bugfix release. Currently, a malicious user could try to spoof some of the fields (I am unsure with what kind of success). b) easier re-ordering of forms by modules and themes. Example: I'd like to add a description field to uploads uploaded through upload.module. I can do that through nodeapi(form post), but if I have three upload fields all my three description fields would appear after the three file selectors. If the existing form array would be passed around in "form post" I could add my fields in between. I think that Chris' ideas of nicer admin screens (with all their possible flaws) also require such a reorganization. Cheers, Gerhard

14 39

[drupal-devel] Bug#312202: drupal: Fix for Postgres Session Error
by Hilko Bengen 08 Jun '05

08 Jun '05

Mike McCallister <mike+debian(a)metalogue.com> writes: > Package: drupal > Version: 4.5.3-2 > Followup-For: Bug #312202 > > > Browsing through the Drupal CVS repository, looking for a fix for this > issue, I came across the following patch that resolves this issue for me > without requiring a database structure change: > > http://cvs.drupal.org/viewcvs/drupal/drupal/includes/session.inc?r1=1.13&r2… This patch is apparently against the wrong version of the file. The version of session.inc in Drupal 4.5.3-2 is // $Id: session.inc,v 1.8.2.1 2005/01/10 19:35:37 dries Exp $ Cheers, -Hilko

1 0

[drupal-devel] Job opening at University of Ghent
by Dries Buytaert 08 Jun '05

08 Jun '05

Hello world, the University of Ghent (and the department I work specifically) is looking to hire a full-time web developer, preferably someone with Drupal experience. It would be a full-time job on site for at least one year. Please drop me a line if you're interested. -- Dries Buytaert :: http://www.buytaert.net/

1 0

[drupal-devel] Google SOC Application
by Viksit Gaur 08 Jun '05

08 Jun '05

Hi All, I'm interested in applying for the SOC with Drupal, but I wasn't sure about how to go about it. Do I need to communicate with the mentors first, and give them an idea/get some ideas about the project, and the work which will be done with it? Or Do i go ahead and apply directly? I assumed the first option would be a much better one. I'm going to be joining Yale this Fall for my MS in Computer Science, and I've just finished my Undergrad in CS as well. (Well, just about :) Cheers, Viksit

2 1