June 2005 - Development - lists.drupal.org

[drupal-devel] [feature] Submission queue menu item should have count
by hba 27 Jul '05

27 Jul '05

Issue status update for http://drupal.org/node/19370 Project: Drupal Version: cvs Component: queue.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: hba Updated by: hba Status: active Attachment: http://drupal.org/files/issues/queue.module_0.patch (512 bytes) The 'submission queue' item in the menu block should have a count, so that users easily can see if there are new articles to vote for. Working patch attached. hba

2 2

[drupal-devel] [feature] Node module should provide node object to theme search hook
by Eric Scouten 27 Jul '05

27 Jul '05

Project: Drupal Version: 4.5.0 Component: page.module Category: feature requests Priority: normal Assigned to: Eric Scouten Reported by: Eric Scouten Updated by: Eric Scouten Status: patch Attachment: http://drupal.org/files/issues/node_search_hook.patch (719 bytes) As currently defined node.module's search hook doesn't provide enough information to allow a rich rendering of search results. For instance, in a photographic web site, I'd like the search results to show a thumbnail of each matched image. I can't do this without access to the node object. The attached one-line patch provides access to the node object in the search results. Eric Scouten -- View: http://drupal.org/node/16056 Edit: http://drupal.org/project/comments/add/16056

3 6

[drupal-devel] [feature] Check All | None on Content List Page (admin/node)
by jjeff 26 Jul '05

26 Jul '05

Issue status update for http://drupal.org/node/20641 Project: Drupal Version: cvs Component: node.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: jjeff Updated by: jjeff Status: patch Attachment: http://drupal.org/files/issues/node_module_check_all.patch (1.23 KB) >From the "what a great time-saver" department: Here is a short patch to node.module that adds a "Check all | none" javascript link to the bottom of the content listing table on admin/node. By clicking "all" or "none" you can select or deselect all of the check boxes in the table at once. The javascript is very non-invasive, should work older (non-DOM) browsers, and non-javascript browsers will simply lose this function. The patch also adds the attribute [name = "node-admin"] to the [form] tag. I don't know if there is a form naming convention, but this was the best guess I could come up with by looking at the page source. And incidentally, if Drupal is going to move toward javascript/ajax functioning, all forms are going to need 'name' and 'id' tags. Most don't have these now. -Jeff jjeff

8 12

[drupal-devel] [feature] i18n - Move drupal_goto to bootstrap.inc and some related features
by Jose A Reyero 22 Jul '05

22 Jul '05

Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Jose A Reyero Reported by: Jose A Reyero Updated by: Jose A Reyero Status: patch Attachment: http://drupal.org/files/issues/i18n_drupal_goto_01.patch (8.41 KB) This is firs of a serie of patches adding support for some i18n related features. This patch: - moves drupal_goto to bootstrap.inc, making it possible to use it from the module_init, even for cached pages - moves url() to bootstrap.inc, as it is needed by drupal_goto, and includes a check for not to resolve path aliases when called from bootstrap (it is not needed and would require including lot more stuff from common.inc) - adds a simple hook to call 'i18n_url_rewrite' from the function 'url()' , which allows outgoing urls to be rewrited, so some additional info can be placed in the path. Jose A Reyero -- View: http://drupal.org/node/16069 Edit: http://drupal.org/project/comments/add/16069

3 7

[drupal-devel] [feature] i18n - Support for language-dependent variables
by Jose A Reyero 22 Jul '05

22 Jul '05

Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Jose A Reyero Reported by: Jose A Reyero Updated by: Jose A Reyero Status: patch Attachment: http://drupal.org/files/issues/i18n_language_variables_01.patch (1.16 KB) This is a simple patch for bootstrap.inc, which adds a function call for all the variable functions (variable_get, variable_set, variable_del). This adds support for language-dependent variables, and does nothing when i18n.module is disabled. The idea is to add a language prefix to the variable name, depending on current language, thus allowing to easily translate some variables to different languages. Jose A Reyero -- View: http://drupal.org/node/16071 Edit: http://drupal.org/project/comments/add/16071

5 10

[drupal-devel] [feature] Allow node_load($nid)
by chx 20 Jul '05

20 Jul '05

Issue status update for http://drupal.org/node/25634 Project: Drupal Version: cvs Component: node system Category: feature requests Priority: normal Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/node_load.patch (2.23 KB) I am fed up writing node_load(array('nid' => $nid)) all the time. BTW. if this is accepted, next is node_view to accept a $nid. chx

9 19

[drupal-devel] [bug] 'administer nodes' should be 'administer comments'
by ejort 20 Jul '05

20 Jul '05

Issue status update for http://drupal.org/node/25285 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: ejort Updated by: ejort Status: patch Attachment: http://drupal.org/files/issues/comment.module.remove_administer_nodes.patch (810 bytes) Hi, In the validate case in comment_nodeapi, there is currently the following: if (!user_access('administer nodes')) { // Force default for normal users: $node->comment = variable_get("comment_$node->type", 2); } The check for 'adminster nodes' should instead be for 'administer comments'. As seen in the 'form admin' case, the comment options are only output if the user has 'administer comments' permission: if (user_access('administer comments')) { $selected = isset($node->comment) ? $node->comment : variable_get("comment_$node->type", 2); $output = form_radios('', 'comment', $selected, array(t('Disabled'), t('Read only'), t('Read/write'))); return form_group(t('User comments'), $output); } So, the bug I ran into was with users who had 'administer nodes' but not 'administer comments' permission. Everything was posted with comments disabled (the validate case DIDN'T force comments to the default, but neither were they given an option to select anything). This one line patch fixes the issue. This is present in 4.6 (where I discovered it) and in HEAD. Cheers, Eric ejort

2 3

[drupal-devel] [feature] 'View terms' for vocabularies with > 25 terms
by Morbus Iff 19 Jul '05

19 Jul '05

Issue status update for http://drupal.org/node/20505 Project: Drupal Version: cvs Component: taxonomy.module Category: feature requests Priority: normal Assigned to: Morbus Iff Reported by: Morbus Iff Updated by: Morbus Iff Status: patch Attachment: http://drupal.org/files/issues/_p_25termvocab.patch (1.28 KB) There was some small talk about this here and there during my folksonomy/free tagging patch, but I held off until now to actually implement it. Much like we handle free tagging vocabularies ("this is a free tagging vocabulary: view terms", which leads the admin into the taxonomy pager system), this patch does the same thing for NON-free tagging vocabularies, but ONLY if the vocabulary has more than 25 terms. These patches were made during the exploration and customization of Drupal by http://www.NHPR.org. In loving support of open source software, http://www.NHPR.org will continue to contribute patches they feel the community will benefit from. Questions about this patch should be directed to morbus(a)disobey.com. Morbus Iff

7 23

[drupal-devel] [bug] Comment Multi Page Goto Fix
by pyromanfo 18 Jul '05

18 Jul '05

Issue status update for http://drupal.org/node/24880 Project: Drupal Version: 4.6.0 Component: comment.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: pyromanfo Updated by: pyromanfo Status: patch Attachment: http://drupal.org/files/issues/comment_goto_multi_page.patch (817 bytes) This patch takes the user to the proper page when they post a comment to a node that has multiple pages of comments. pyromanfo

4 3

[drupal-devel] [bug] Consistent return values of comment post(), and much more
by moshe weitzman 18 Jul '05

18 Jul '05

Issue status update for http://drupal.org/node/18656 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: moshe weitzman Updated by: moshe weitzman Status: patch Attachment: http://drupal.org/files/issues/comment_post.patch (15.33 KB) This function which actually posts comments is comment_post(). This function is currently pretty messy, and not suitable for use by other modules. This patch assures that this function returns the comment ID if the submission was successful, or else returns FALSE. This is consistent with node_save(). In fact, I've renamed this function comment_save() for consistency. The old comment_save() was merged with comment_post(). I renamed comment_validate_form() to comment_validate() for consistency with node as well. To do this, I had to clean up quite more of the module. This patch unifies the admin comment form and the usual comment form, similar to what we did for nodes. This resulted lots of duplicate code removal. I was able give Admins the ability to change the author and timestamp of a comment. Thats been a feature request of mine since Jan 2003: http://drupal.org/node/983 I removed comment links from the bottom of the comment preview box (as we did for nodes) I hope this is considered for commit early in the 4.7 cycle. moshe weitzman

6 13