July 2005 - Development - lists.drupal.org

Re: [drupal-devel] request new password fails?
by Gerhard Killesreiter 23 Jul '05

23 Jul '05

On Sat, 23 Jul 2005, Remco Brink wrote: > On 7/23/05, Gerhard Killesreiter <killesreiter(a)physik.uni-freiburg.de> wrote: > > > > > > On Sat, 23 Jul 2005, Remco Brink wrote: > > > > > when requesting a new password in Drupal CVS, the user is for some > > > reason not returned a proper password, but instead "%password": > > > > Drupal cvs does not send new passwords anymore but only one time logins. > > Maybe that is the reason for this? > > Possible, but in that case Drupal CVS is not doing either as far as I can see. I think the problem could be that in your case the various variables about user mails are set and in the cases I've gotten one time log ins there weren't. Can you clear the fields on admin/settings and then try again? Cheers, Gerhard

1 0

[drupal-devel] On mailing list set up
by Piotr Krukowiecki 23 Jul '05

23 Jul '05

Hello, my 2 cents on ML setup: 1. IMO it'd be better if automatic issue->ml mails would be sent to separate mailing list, e.g. drupal-issue. They clutter this 'discussion' list. (well, maybe first issue could be sent here, but not responses) 2. About "Release critical bugs" reports: I'd like them to be more condensed, so it'd be easier to quickly skim them. For example instead of: / bug reports email spam filtering does not "see" email addresses when they are NOT preceded by a word age: 26 weeks 4 days url: http://drupal.org/node/15654 / bug reports enable MySQL client side for UTF8 age: 2 days 7 hours url: http://drupal.org/node/26990 anonymous user ccess Permission in administer node problem age: 1 week 1 day url: http://drupal.org/node/26564 / feature requests event.module support of repeating/recurring events? assigned: thehunmonkgroup age: 1 year 35 weeks url: http://drupal.org/node/4122 I'd like to see for example something like this: Bug reports: 26990:02d07h: enable MySQL client side for UTF8 26564:01w01d: anonymous user ccess Permission in administer node problem 15654:26w04d: email spam filtering does not "see" email addresses when they are NOT preceded by a word Feature requests: 4122:01y35w:event.module support of repeating/recurring events? etc. It should be sorted by report type (bugss/features/etc) and then by the age. -- Piotrek irc: #debian.pl Mors Drosophilis melanogastribus!

1 0

[drupal-devel] My opinion on drupal release cycle - 6 months is ok for me.
by Piotr Krukowiecki 23 Jul '05

23 Jul '05

Hi To express my opinion of release cycle length: IMO 6 months is ok. I don't like often upgrades. A lot of hassle. And about after-release-bugfixing-period: Plus, bugfixing is good. People won't use buggy software -- Piotrek irc: #debian.pl Mors Drosophilis melanogastribus!

1 0

[drupal-devel] node_load() change in HEAD
by Dries Buytaert 23 Jul '05

23 Jul '05

In HEAD, node_load() changed. You can now write: node_load($nid); instead of having to write: node_load(array('nid' => $nid)); Slightly less code, slightly less memory, slightly faster. -- Dries Buytaert :: http://www.buytaert.net/

3 3

[drupal-devel] [feature] Nice DB error screens
by stefan nagtegaal 23 Jul '05

23 Jul '05

Issue status update for http://drupal.org/node/27231 Post a follow up: http://drupal.org/project/comments/add/27231 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: stefan nagtegaal Status: patch Okay, I think I have to agree with Neill in here.. If this patch hits the trunk, I'll make a new issue and rolls a patch for introducing new functions which should improve code-wise consistency.. Let me introduce you to: function theme_placeholder($message) { return "$message"; } function theme_important($message) { return "$message"; } function theme_code($message) { return "<code>$message"; } function theme_text($message) { return "$message "; } Patches are soon to come in another issue, after this has hit the trunk.. stefan nagtegaal Previous comments: ------------------------------------------------------------------------ Thu, 21 Jul 2005 22:43:16 +0000 : drumm Attachment: http://drupal.org/files/issues/screenshot2.png (96.1 KB) Screenshot. ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:21:31 +0000 : drumm Attachment: http://drupal.org/files/issues/screenshot_10.png (88.44 KB) ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:25:57 +0000 : drumm Attachment: http://drupal.org/files/issues/druplicon.png (3.98 KB) New Druplicon which will need to replace misc/druplicon.png. The current file in that location is a giant flat druplicon which isn't used anywhere. ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:26:26 +0000 : drumm Attachment: http://drupal.org/files/issues/maintenance.css (329 bytes) Some CSS ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:30:34 +0000 : drumm Attachment: http://drupal.org/files/issues/errorhandling.patch (8.47 KB) This patch makes the database errors which occur when the database connection information is wrong or the database isn't up much nicer and more explanatory. To do this it adds a themeable function, theme_maintenance_page(), and a way to get Drupal running without a theme but the ability to execute themeable functions in the usual way. This means we can use the same code to give upgrade.php a nicer look in the future. ------------------------------------------------------------------------ Fri, 22 Jul 2005 06:33:57 +0000 : kbahey I was about to do something similar on a less ambitious scale (mainly the connect function), because what we get now is ugly and looks unprofessional. +1 from me for this. Great job! ------------------------------------------------------------------------ Fri, 22 Jul 2005 06:52:30 +0000 : gordon +1, This looks great. Get this in and then we can do something with the upgrade.php system and it will look just great. ------------------------------------------------------------------------ Fri, 22 Jul 2005 19:36:39 +0000 : drumm Attachment: http://drupal.org/files/issues/errorhandling_0.patch (8.44 KB) New patch with a couple suggestions from chx. * $foo === NULL is faster than is_null($foo) * Removed 'bootstrap' from the function name since it is not really part of the bootstrap system. When testing/applying updates #2 and #3 of this issue need to be handled too. ------------------------------------------------------------------------ Fri, 22 Jul 2005 20:47:18 +0000 : stefan nagtegaal I indeed like the patch! you have some perfectly helptexts which asure that people *must* be foulish when they do not know how to setup drupal the correct way. On that, a very, very fine patch.. Though, code-wise I have one nit-pick, which is propably not even a real issue. Only, I think it looks better: + print theme('maintenance_page', 'We were able to connect to the MySQL database server (which means your username and password is okay) but not able to select the database. +The MySQL error was: '. mysql_error() .'. +Currently, the database is <code>'. substr($url['path'], 1) .'. The username is '. $url['user'] .' and the database server is '. $url['host'] .'. + + * Are you sure you have the correct database name? + * Are you sure the database exists? + * Are you sure the username has permission to access the database? + +For more help, see the Installation and upgrading handbook [1]. If you are unsure what these terms mean you should probably contact your hosting provider. '); Wouldn't it be nicer (code-wise) todo: $message[] = 'We were able to connect to the MySQL database server (which means your username and password is okay) but not able to select the database.'; $message[] = strtr('The MySQL error was: %error.', array('%error' => theme('placeholder', mysql_error()))); $message[] = etc, etc; print theme('maintenance_page', $message); Also would I encourage you to make a function theme_message($type, $message), like: function theme_message($type, $message) { switch($type) { case 'code': $output .= '<code>'. $message .'<code>'; break; case 'placeholder': $output .= ''. $message .''; break; case 'important': $output .= ''. $message .''; break; default: $output .= ''. $message .''; break; } } Which makes theme_placeholder() redundant and could be removed. Codesnippets could be handled in a more consistent way then we currently do (having a theme_placeholder() only is rediculous imo afterall). Also this function could be used to remove the hardcoded HTML from the helptexts.. The code is untested and needs some love here-and-there. But, when it's done, I think we will create (codewise) more consistency than we currently have! I look forward to see your idea's and hear your opinion about this.. [1] http://drupal.org/node/258 ------------------------------------------------------------------------ Fri, 22 Jul 2005 23:27:53 +0000 : drumm The theme_message() which stefan nagtegaal looks like it should be four separate themeable functions, one of which already exists. I think any such modifications are outside the scope of this patch. I am nearly finished preparing a patch to update.php which uses this patch, but I can not post it until this patch is resolved.

1 0

[drupal-devel] CVS Warning
by Fabiano Sant'Ana 23 Jul '05

23 Jul '05

Hi, Someone could tell me what means this message? /cvs/drupal-contrib/contributions/sandbox/wundo/SoC/webdav.module,v <-- sandbox/wundo/SoC/webdav.module new revision: 1.5; previous revision: 1.4 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Thank you, Fabiano Sant'Ana

3 2

[drupal-devel] request new password fails?
by Remco Brink 23 Jul '05

23 Jul '05

Hi, when requesting a new password in Drupal CVS, the user is for some reason not returned a proper password, but instead "%password": ==== Subject: Replacement login information for remco at rc6.org remco, Here is your new password for rc6.org. You may now login to http://rc6.org/user using the following username and password: username: remco password: %password After logging in, you may wish to change your password at http://rc6.org/user/1/edit ===== Is anybody else seeing the same problem? regards, Remco -- Remco B. Brink -- DJ / BW GS / CDTT eating bandwith for breakfast at http://rc6.org

3 2

[drupal-devel] [bug] queue module display duplicate entry when more than one user has voted to an article
by leongtd 23 Jul '05

23 Jul '05

Issue status update for http://drupal.org/node/27305 Post a follow up: http://drupal.org/project/comments/add/27305 Project: Drupal Version: 4.6.2 Component: queue.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: leongtd Updated by: leongtd -Status: active +Status: patch Attachment: http://drupal.org/files/issues/drupal-4.6.2-queue-duplicate-entries.patch (1.77 KB) Attached is a rough proposed patch to fix this problem. leongtd Previous comments: ------------------------------------------------------------------------ Sat, 23 Jul 2005 08:07:43 +0000 : leongtd When more than one user have submitted the vote, the moderation queue will display duplicate entry of the same article. Step to reproduce: 1. Submit a new article to moderation queue 2. Login as another user and send in a vote 3. view the queue Actual result: - Two duplicated of the same article displayed - votes are viewed seperately. Expected result: - One entry for one article - vote should be the total score of the moderation point.

1 0

[drupal-devel] [task] Use named constants for drupal_bootstrap()
by drumm 23 Jul '05

23 Jul '05

Issue status update for http://drupal.org/node/27003 Post a follow up: http://drupal.org/project/comments/add/27003 Project: Drupal Version: cvs Component: base system Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/bootstrap_constants.patch (5.94 KB) Named constants are much better to use than strings for this sort of thing. drumm

3 3

[drupal-devel] [feature] Single step account creation and login
by mathias 23 Jul '05

23 Jul '05

Issue status update for http://drupal.org/node/4942 Post a follow up: http://drupal.org/project/comments/add/4942 Project: Drupal Version: 4.6.2 Component: user.module Category: feature requests Priority: normal Assigned to: amanuel Reported by: mathias Updated by: mathias Status: patch I want users to be able to enter their own passwords upon account creation, but this patch still needs some work. - The email verification checkbox in user admin settings is confusing. I'm assuming that it applies to any of the selected registration options? However when I select that only site admins can create new user accounts, the accounts I create don't get any emails sent for the user to verify. - When a user signs up and enters his/her own password I think they should be logged in automatically rather than taken to a screen asking them to click the login button. - User entered passwords aren't validated. We should check to make sure they're at least six characters and verify the password strength level to some degree (i.e. same characters, all lowercase letters.) mathias Previous comments: ------------------------------------------------------------------------ Sat, 03 Jan 2004 23:49:54 +0000 : mathias Under special circumstances, i would like a new user to be able to choose their own password and be automatically logged into the site without needing to check their email. I feel this is necessary for my ecommerce module, where after anonymous users are ready to "Proceed to checkout", they need to create an user account to continue. It is tedious for the customer if they have to stop, check their email, log into the site and then resume the checkout process. I'm game to code this (if this has potential to be part of the core), i just need some feedback on the best way to tweak user_register. ------------------------------------------------------------------------ Sun, 04 Jan 2004 06:18:07 +0000 : moshe weitzman +1 for this. I don't think you will get much objection to this much needed usability enhancement. ------------------------------------------------------------------------ Thu, 08 Jan 2004 05:48:40 +0000 : mathias Attachment: http://drupal.org/files/issues/user.module-quick_acount.patch (7.11 KB) This is a prototype patch to make sure i'm going in the right direction. I feel this patch is about 95% complete, the outstanding issue being page redirection after quick-account creation. It introduces and new option under the user admin settings "Public registrations" called "Visitors can create accounts and sign in immediately.", allowing visitors to submit their own passwords upon account creation. This is important in an ecommerce site where a new customer wants to the checkout process to be as easy and seamless as possible. ------------------------------------------------------------------------ Thu, 08 Jan 2004 10:22:09 +0000 : moshe weitzman i read through the patch. looks good to me. a few notes - we should still send a password via email to users who choose their ow password. with some text tweaking, we should be able to send the same welcome email to 'generated password' registratants, and 'user specified password' registrants. - I think we need a setting for minimum length of a password. the password textfield should inform users of this requirement. - you don't actually relinquish control after saying "/* Let the developer control where the user is redirected. */". i assume this part isn't finished yet. nice work. ------------------------------------------------------------------------ Thu, 08 Jan 2004 13:46:07 +0000 : flevour Are there any anti-bot checks around, e.g. randomly generated images that contain text or numbers to insert in a box? Congrats for your work :p // flevour ------------------------------------------------------------------------ Thu, 08 Jan 2004 13:54:19 +0000 : Bèr Kessels I had another idea. that would be to filter all emailadresses (in content too) into a link to the feedback module. thus http://www.mysite.org/feedback/mailto/me/mysite.org the feedback can then print a form that can send the message to me(a)mysite.org. Would this be a good feature or not? Ber ------------------------------------------------------------------------ Thu, 08 Jan 2004 13:56:36 +0000 : Bèr Kessels sorry folks. placed this in the wrong box. Was updating another feature, and reading this one (to see if it was the same one) i then, by accident, filled replyed here. :( Ber ------------------------------------------------------------------------ Thu, 08 Jan 2004 16:49:56 +0000 : Dries Showing an image with random generated text that a user is supposed to copy, makes your website inaccessible for visually impaired: they can't be read by a screen reader. ------------------------------------------------------------------------ Thu, 08 Jan 2004 17:07:02 +0000 : mathias Responding to Moshe's comments: - we should still send a password via email to users who choose their own password. with some text tweaking, we should be able to send the same welcome email to 'generated password' registratants, and 'user specified password' registrants. That is a good point. I'll update the patch. - I think we need a setting for minimum length of a password. the password textfield should inform users of this requirement. Agreed. In my patch i checked to make sure the password was at least six characters long, but this should be an element that can be tweaked by the admin. It might be best to make this a global password length system variable. - you don't actually relinquish control after saying "/* Let the developer control where the user is redirected. */". i assume this part isn't finished yet. Yep, that's the part i'm still working on. Thanks for the critical eyes. ------------------------------------------------------------------------ Wed, 14 Jan 2004 04:31:06 +0000 : mathias Attachment: http://drupal.org/files/issues/user_0.module-quick_acount.patch (7.95 KB) The patch has been updated and is ready for final review, and commit. ------------------------------------------------------------------------ Wed, 14 Jan 2004 22:37:53 +0000 : Dries Not sure. Wouldn't it make more sense (and result in better/less code) to let the user *always* choose his password and to introduce a admin setting to control whether e-mail addresses should be validated by e-mail? ------------------------------------------------------------------------ Sun, 15 Feb 2004 17:02:38 +0000 : moshe weitzman moving out of patch queue until a cleaner implementation is submitted ... this feature is still quite valuable. ------------------------------------------------------------------------ Fri, 05 Nov 2004 19:21:49 +0000 : Nick Nassar I agree with Dries that it makes a lot of sense to always let the user choose her password. It's a pain to copy and paste in a randomly generated password, then change it. Hash link based verification is much easier. That's really a seperate issue from an option to disable verification. ------------------------------------------------------------------------ Fri, 22 Jul 2005 22:11:42 +0000 : amanuel Attachment: http://drupal.org/files/issues/user4.6.2.patch (4.25 KB) Following Dries's suggestion, I have implemented a "Enable Email Verification" option to user.module. The attached patch does the job. With this patch the system by default will ask for a password. If Email Verification is turned on in the settings, the system will send the password via email. $edit['destination'] is carried so as to allow the user to return where they were (shopping cart etc.) Any comments? Amanuel

1 0