September 2005 - Development - lists.drupal.org

[drupal-devel] [bug] user.module user_mail() removes \r from email body.
by peterx 21 Sep '05

21 Sep '05

Issue status update for http://drupal.org/node/31821 Post a follow up: http://drupal.org/project/comments/add/31821 Project: Drupal Version: 4.6.3 Component: user.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: peterx Updated by: peterx Status: active There is a line in user.module user_mail() that removes \r from the email body: str_replace("\r", '', $message), To make the email comply with the standards the str_replace should be removed. Some unix based mail servers will ignore the lack of the \r while others reject the email as invalid. If you want to fix the occasional wierd line ending from editors on different operating systems, the following are useful. The following fixes text from some editors that forget the \r while maintaining the \r\n from standards compliant email editors. str_replace("\r\r\n", "\r\n", str_replace("\n", "\r\n", $message)); peterx

1 0

[drupal-devel] [bug] File copy failed: source file does not exist. (image module)
by dmjossel 21 Sep '05

21 Sep '05

Issue status update for http://drupal.org/node/30371 Post a follow up: http://drupal.org/project/comments/add/30371 Project: Drupal Version: 4.6.3 Component: file system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: sstrange Updated by: dmjossel Status: active I have a similar experience with the same error message, although the ability to add new images and to upload files seems unaffected. Only the update-image.php script is affected. Also, PHP is not running in safe mode: http://drupal.org/node/31816 Given that new images can be added, and all the paths are correct and readable (as well as writeable in the case of the images and temp folders, and PHP safe mode is off, it seems that there may be another obscure issue. The same server and web configuration works with Drupal 4.5's image module, as well. dmjossel Previous comments: ------------------------------------------------------------------------ Sun, 04 Sep 2005 11:59:23 +0000 : sstrange I've installed drupal version 4.6.3 and almost everything is working except the image and upload modules. When I try to create an image content I get the next error message: File copy failed: source file does not exist. Background info: I've drupal installed on at my hosting company which has PHP in safe mode. (4.3.11). Drupal directory structure: +---drupal | +---database | +---files (777) | | +---images (777) | | | +---temp (777) | | | \---tmp (777) | | \---pictures (777) | +---includes | +---misc | +---modules | | \---po | +---scripts | +---sites | | \---default | +---themes | | +---bluemarine | | +---chameleon | | | \---marvin | | +---engines | | | +---phptemplate | | | \---xtemplate | | +---greenmarinee | | \---pushbutton | \---tmp I'm able to upload files with the move_uploaded_file module with an phpupload.php script from my hosting party. There are no errors in the settings of the image module of drupal. Default image path is "images". What do I've to do to solve the image upload problem? Regards, Stefan ------------------------------------------------------------------------ Sun, 04 Sep 2005 18:57:45 +0000 : Bèr Kessels AFAIK tmp is relative to your OS root. so /tmp is not files/tmp but the actual /tmp of your OS/server. So make sure you set the TMP relative to your files directory, or give an absolute path. Something like /var/ww/drupal/files/tmp ------------------------------------------------------------------------ Mon, 05 Sep 2005 13:07:53 +0000 : sstrange I changed the Temporary directory settings from "tmp" to "/ext/s/st/stranger.nl/html/drupal/tmp" and saved the configuration. (no errors when saving settings) But I still get the error File copy failed: source file does not exist. ------------------------------------------------------------------------ Mon, 05 Sep 2005 14:02:46 +0000 : Bèr Kessels hmm; Sstrange.; (sorry could not resist ;) ) Can you see what permssions you have for the files _inside_ tmp? if tehre are any, that is. It could be that thefiles themselves have problems with permissions once put there Other then that, I am afraid I cannot help you any further. ------------------------------------------------------------------------ Mon, 05 Sep 2005 18:07:19 +0000 : sstrange I'm not sure what you mean with "files _inside_ tmp" but the permissions on html/drupal/tmp are 777. But there are no files within in tmp directory. But I can put files in that directory by ftp. How do I know what the default tmp directory is from my hosting company? Regards, Stefan ------------------------------------------------------------------------ Mon, 05 Sep 2005 19:32:28 +0000 : Bèr Kessels I meant files, that were stuck in that directory. Or might have been. But the fact there are no files at all in that dir, should help a lot too. Though I am lost at this moment. ------------------------------------------------------------------------ Tue, 06 Sep 2005 19:54:27 +0000 : walkah this seems to be a general file system issue - i'm suspicious of safe mode, but can't test further atm. ------------------------------------------------------------------------ Wed, 07 Sep 2005 09:43:43 +0000 : sstrange Can anyone please tell me how the image module works? What are the actions when an image is uploaded? In which directories are the (temporary files) placed before they are placed in the right directory? Regards, Stefan ------------------------------------------------------------------------ Thu, 08 Sep 2005 18:55:15 +0000 : sstrange According to the helpdesk of my hosting provider uses the file.inc (API for handling file uploads and server file management) the file_copy function which does not work with the safe mode restriction of my provider. Is not it posible to use the move_uploaded_file function instead of the file_copy function? If so who can help me? Regards, Stefan ------------------------------------------------------------------------ Sun, 18 Sep 2005 02:47:26 +0000 : cuebix That is indeed the problem. I added a few lines of code inside of includes/file.inc to find out what was going on: $source = realpath($source); var_dump($source); exit; if (!file_exists($source)) { drupal_set_message(t('File copy failed: source file does not exist.'), 'error'); return 0; } When uploading a file, this output: string(14) "/tmp/phpz4d3CH" The problem is, if you have safe_mode enabled, the conditional statement will fail. /tmp resides outside of the paths the script is allowed to work with, so even though the file exists, the function file_exists() plays dumb, as it should. The solution is, as suggested, to use move_uploaded_file instead. I've created a workaround for it for Drupal 4.6.3 In includes/file.inc in file_copy(...) Line 231: if (!file_exists($source) && !is_uploaded_file($source)) { drupal_set_message(t('File copy failed: source file does not exist.'), 'error'); return 0; } Line 272: if (is_uploaded_file($source)) { if (!move_uploaded_file($source, $dest)) { drupal_set_message(t('File copy failed.'), 'error'); return 0; } } else if (!@copy($source, $dest)) { drupal_set_message(t('File copy failed.'), 'error'); return 0; } in file_move(...) Line 314: if (is_uploaded_file($path_original)) { $uploaded_file = true; } if (file_copy($source, $dest, $replace)) { $path_current = is_object($source) ? $source->filepath : $source; if ($uploaded_file || $path_original == $path_current || file_delete($path_original)) { return 1; } drupal_set_message(t('Removing original file failed.'), 'error'); } For some reason the regular upload module still won't work though. ------------------------------------------------------------------------ Tue, 20 Sep 2005 19:41:15 +0000 : sstrange Attachment: http://drupal.org/files/issues/file_0.inc (17.48 KB) I changed the file.inc according to you advise but now I'm getting the next error message: Parse error: parse error, unexpected $ in /mnt/storage2/s/st/stranger.nl/html/drupal/includes/file.inc on line 559 See attached file.inc

1 0

[drupal-devel] Experiment: project issue mails disabled
by Dries Buytaert 21 Sep '05

21 Sep '05

Hello world, as an experiment I disabled the project issue mails sent to the drupal-devel mailing list. This change is the result of a recent drupal-devel discussion. We'll try this configuration for one or two weeks after which the change will be evaluated. (Possible metrics are: number of bugs fixed, number of patches reviewed, number of people that subscribed to the issues, quality of drupal-devel discussions, etc.) Two tips: - If you want to receive project issue mails, you can subscribe at http://drupal.org/project/issues/subscribe. - If you haven't already, enable the 'Contributor links'-block at drupal.org: it provides handy links to access the issue tracker. To enable the block, go to your user profile page and check the appropriate checkbox. -- Dries Buytaert :: http://www.elis.ugent.be/paris/

1 0

[drupal-devel] [feature] Administration Control Panel suggestion
by der 21 Sep '05

21 Sep '05

Issue status update for http://drupal.org/node/31326 Post a follow up: http://drupal.org/project/comments/add/31326 Project: Drupal Version: cvs Component: system.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: der Updated by: der Status: patch (code needs review) FYI control panel module posted at http://drupal.org/node/31806 der Previous comments: ------------------------------------------------------------------------ Thu, 15 Sep 2005 17:50:52 +0000 : der Attachment: http://drupal.org/files/issues/system_9.patch (4.27 KB) New feature suggestion: I would like to suggest a couple of enhancments to administration pages. First, add a new general settings option to allow the user to specify the admin home page. Currently the watchdog log view is the default home page. Second, add a new control panel page that can be used as the default admin start page. I've attached a suggested patch to the CVS head version of the system.module that implements these two enhancements. The patch does the following. Adds a new "default admin page" text field to the general settings group (just after the "default front page"). It also changes the admin menu entry to call a new function that examines the default "admin page" variable and redirects to the appropriate path. For the control panel, the patch adds a new function (system_admin_controlpanel). This function basically looks for the admin entry in the menu structure and then iterates through the child menu items and builds a control panel page using the path and title information returned from the menu structure. For the control panel icons it looks for an icon file in the misc directory that matches the name of the menu item (e.g. user.png, access.png etc) If it doesn't find an icon it uses a default. I've also included some 48/48 icons that I borrowed from my usr/share/icon/gnome directory of my local Linux box. I believe these are gnome GPL'ed icons but any 48/48 icons could be used. This patch allows users who prefer the current functionality to keep it as their default. It provides the option for others to make any admin page they want to be their admin "home page" including using a graphical control panel. Module developers that add new admin menu options can add their own custom icons for the control panel but they are not "required" to do so as a default will be used if they don't provide one. ------------------------------------------------------------------------ Thu, 15 Sep 2005 17:52:15 +0000 : der Attachment: http://drupal.org/files/issues/drupal_controlpanel_icons.zip (39.09 KB) 48x48 icons attached ------------------------------------------------------------------------ Fri, 16 Sep 2005 14:30:16 +0000 : der Attachment: http://drupal.org/files/issues/system_2_0.patch (4.5 KB) updated patch. slightly changed the formatting of the control panel page ------------------------------------------------------------------------ Sat, 17 Sep 2005 00:37:24 +0000 : moggy I quite like this. It certainly goes some way to making Drupal easier on the eyes for first time users. I noticed there's a lot of hard coded style. Would this not be better in a stylesheet and the code just containing classes and ids? Also would a dropdown box of possible admin pages be better than trying to remember how to spell controlpanel (something I'm having trouble with tonight ;-) ) ------------------------------------------------------------------------ Sat, 17 Sep 2005 13:02:08 +0000 : syllance Nice job :) the default admin page is a nice feature, and the controlpanel is a very good idea. This goes in the good direction to make Drupal more user friendly. i agree with the dropdown menu and stylesheet additions, but i already really appreciate the current version. hope this will go into core soon, as it really makes the first admin pages contact better :) i don't mind scrolling through the nav menu and i rarely goes into admin without checking the logs, but that definitely will help me converting my wife's site to drupal :p thanks ! ------------------------------------------------------------------------ Sat, 17 Sep 2005 16:09:43 +0000 : der I'll move the styles off to a style sheet but I'm uncertain about whether or not make make the default admin page a dropdown. It's an easy change and it eliminates any typos by the user but it also restricts the user to a current visible admin menu item. If by chance someone wanted to write their own admin start page (ie their own control panel) they would have to hack the core system.module to do it. Anyone else want to weigh in with their preference? Also, anyone up for creating drupalized versions of the control panel icons? ------------------------------------------------------------------------ Sat, 17 Sep 2005 16:16:15 +0000 : chx Maybe just because I created it, I like my control panel module better. ------------------------------------------------------------------------ Sat, 17 Sep 2005 16:25:30 +0000 : der If I would have known there was a module I wouldn't have written this patch although I do think this would be good for core Drupal as the default. Is your modules a recent creation? I don't see it on drupal.org nor could I find in the contribs section of CVS (either the modules or sandbox sections). I'm I missing something? Is it called something different? ------------------------------------------------------------------------ Sat, 17 Sep 2005 18:20:15 +0000 : syllance chx control panel is located in his sandbox (cp.module), and thanks to him for letting us know there's one :) it's working fine (tested on HEAD) and provide interesting concept for navigating through the admin, instead of just add a frontend. the settings part is the better one, listing all elements in the page makes quickly forget the standard menu. der's one looks nice and provide a more immediate access to admin pages, but the standard menu is still mandatory to access some elements (dba or store settings for example, still needs to be accessed via left menu). to be honest, i like them both :) being able to change the default admin page is very nice, and icons make admin looks a lot better, raising the Woman Acceptance Factor by a huge amount (my wife loves it :). but i also really like the more in depth admin navigation offered by chx module. mixing both on my head setup gives a nice result, so may be it would be a good idea to join forces and mix the 2 panels. chx, is your module somewhat official and scheduled to hit the core ? ------------------------------------------------------------------------ Sat, 17 Sep 2005 19:24:11 +0000 : Amazon Hi, I asked Karoly to create the control panel module. It important that the control panel be tied into the navigation menu block so that it does not create inconsistent navigation. The goal is to start a user experience grouping exercise to help the community categorize administration tasks. The first thing that has to happen is that administration must be considered a seperate situation from creating personal content in Drupal. To support this seperation of personal tasks and administration tasks we broke out administration to have a separate theme in the CivicSpace theme. Through research interviews into Drupal administration we need to discover what the goals and tasks of administrators are. Some early feedback is that site developers need modules to be evaluated on Drupal.org. They have also indicated they need better and consistent administration help ,with incontext list, which we have been adding. We have also heard administrators want a quick overview. Any change to provide a control panel like overview must have a dashboard like overview. You should assume that we will identify a list of 5-7 top goals for administrators. Once those those 5-7 top goals are identified we need to ensure administrators can acommplish tasks to achieve those goals. Some of those tasks will completed by clicking through to icons or admin interface links. Sub-goals will be accomplished by providing effective navigation. We need to consider 4 types of navigation to be added to the control panel: Global navigation, local navigation, contextual navigation, and situational navigation. Some of this navigation can be accomplished through a theme or blocks. Some will need to be in the page and some need to be added in otherways, such as interaction techniques. Keep all this in mind when creating a control panel solution. It also must respond to the fact that every site will have different permissions set and different modules. This is a complex problem and it's going to research and experimentation to get it right. But this is a big step in the right direction. Cheers, Kieran ------------------------------------------------------------------------ Sat, 17 Sep 2005 19:47:55 +0000 : der Attachment: http://drupal.org/files/issues/system.module_11.patch (5.61 KB) This has sparked a lot of good discussion. I've taken a look at cp.module and I think it really is complimentary with my proposed patch. I've taken my patch one step further and provided the settings icons in a collapsable group below the main control panel. This would allow access to all admin functions without referring to the traditional menu. Syllance, do you think this addresses the gap you saw in my solution? ------------------------------------------------------------------------ Sat, 17 Sep 2005 20:33:10 +0000 : der Kieran, I'm glad to see some serious thought going into the user experience for site administrators. I think separating the user and admin sections of the site is critical. It will not only allow extensive usability work to be done for site admins it will also make it much easier for theme creators as they will be able to focus on the end user experience. I like the admin theme for civicspace. My only dislike about the approach is that it's template driven which causes a sites template to be larger and more complex due to handling all the logic for user and admin themes. I think a better approach may be to use a module such as the sections module. This allows you to have smaller templates focused on user or admin themes. I agree with your point about making sure the control panel ties into them menu system. My approach uses the existing menu structure so modules are added dynamically and all permissions are enforced. ------------------------------------------------------------------------ Sat, 17 Sep 2005 22:21:05 +0000 : chx <?php function _system_adminpage () { drupal_goto($path = variable_get('site_adminpage', 'admin/controlpanel'), $query = NULL, $fragment = NULL); } ?> no way. Use menu !$may_cache and set the path based on the variable. Adding in-line style elements is also a no-go. The code style is not kept. Never a space between full stop and apostrophe, always otherwise. It's not $menuvisible but $menu_visible I must be blind (it's 0:17am) but // Build the settings section of the control panel does not seem to differ from the previous section. A function may be appropriate. ------------------------------------------------------------------------ Sat, 17 Sep 2005 22:39:40 +0000 : der Thanks for the code feedback. I'm assuming the extracted style info would get patched to drupal.css? Your right about the duplicate code. A function would make more sense, I'll make the change. I'm not sure about the comment to use "$may_cache" I've never used it before. What's it's purpose? How should I use it in this situation. I'll dig around and see if I can figure it out but I thought you might be able to give me a little insight. Thanks! ------------------------------------------------------------------------ Sun, 18 Sep 2005 10:41:00 +0000 : syllance der, i've checked the new version of your control panel, and it does simplify access to the settings menu (although with a complex setup, the site config collapsable menu goes a lot more down than the menu, but this a page and not a small menu so its still better) however, there other case settings like, such as the ecommerce modules, which provides a more complex menu tree (ex : store->settings->payment->adjustments, each with their own admin pages). these are not taken into account by your panel, leaving the menu mandatory. chx control panel handles this nicely with page navigation. going through the store menu with chx panel is a real pleasure while its a real pain with the menu. So i think the best would be to mix the two panels, chx one handling page navigation, and yours providing a frontend for basic admin pages, and collapsable site config items. instead of linking to the standard admin pages, icons might link to chx nav pages where there are sub entries. i'm running both today, and this already makes the admin really better, but i'm often switching from der panel to chx one (for store), so mixing both would be, for me, a very nice solution :p thanks for the good work :) ------------------------------------------------------------------------ Sun, 18 Sep 2005 12:54:55 +0000 : der Attachment: http://drupal.org/files/issues/control_panel.patch (5.61 KB) Here's a new patch with the code reworked per chx's comments with the exception of his objection to my use of drupal_goto function. chx, I'm probably missing something really obvious but I'm not understanding your suggestion. Are you suggesting I use some menu function to do the redirect? If so, I could not find one that suits my needs. Or are you suggesting to use the drupal_goto function in a different manner than I am using it. Like I said, I'm probably missing something really obvious here but for the life of me I don't know what it is. Any further advice would be greatly appreciated. The offending code below: <?php function _system_adminpage () { drupal_goto($path = variable_get('site_adminpage', 'admin/controlpanel'), $query = NULL, $fragment = NULL); } ?> ------------------------------------------------------------------------ Mon, 19 Sep 2005 13:42:57 +0000 : syllance i think there's a problem with your latest patch. it seems to display all icons as a vertical list. it may be a problem with my setup, but i'm using basic themes that comes with head. the administer page is thus very long, and this is not very useful. previous version was better, imho :) thanks ------------------------------------------------------------------------ Mon, 19 Sep 2005 14:10:03 +0000 : der which theme and which browser are you using? ------------------------------------------------------------------------ Mon, 19 Sep 2005 15:59:16 +0000 : der Attachment: http://drupal.org/files/issues/control_panel_0.patch (5.32 KB) I've tested this with IE and FireFox with each of the Drupal shipped HEAD themes and I'm not seeing the issue you described. Are you sure the patch applied correctly to drupal.css? Here's a slightly revised patch. It make the control panel icon group collapsable but open by default. ------------------------------------------------------------------------ Mon, 19 Sep 2005 18:09:22 +0000 : der Attachment: http://drupal.org/files/issues/control_panel_1.patch (5.64 KB) Sorry for the excessive number of patches. I just realized that my previous patch had an issue with icon image file names if there were admin and admin/settings menu items that were the same (eg admin/user and admin/settings/user). New patch attached to address. ------------------------------------------------------------------------ Tue, 20 Sep 2005 02:13:49 +0000 : syllance the vertical thing was probably due to a problem with my drupal.css. i've tested your new patch with a fresh update and the display is fine, but there's a bug. the site configuration panel displays store settings items (checkout,payment,shipping), and not the global settings one. this might be due to the menus item having the same name 'settings', although not located at the same level (administer/settings, and administer/store/settings). ready for another patch ? :) your panel adds a nice look and enable default administer page setup. but there's still a lot of menu access needed when other modules are setup (such as ecommerce), and i'm using it in addition to chx one to provide a complete admin solution :) chx one looks just like the theme you're using with no icons, but it really help accelerating admin navigation. i'm wondering if integrating both to core wouldn't be the ultimate solution. your panel more targeted at standard admin needs, and chx one helping users that deals with lots of modules & settings. thanks again ------------------------------------------------------------------------ Tue, 20 Sep 2005 02:19:54 +0000 : Amazon Hi, can you guys post some screen shots as you go along for those of us who don't want to keep installing new patches. ------------------------------------------------------------------------ Tue, 20 Sep 2005 02:25:06 +0000 : der Attachment: http://drupal.org/files/issues/Control Panel.png (101.02 KB) Sure, here's what the current version looks like with the civicspace admin theme. ------------------------------------------------------------------------ Tue, 20 Sep 2005 04:22:36 +0000 : der Attachment: http://drupal.org/files/issues/control_panel_2.patch (5.48 KB) Patch fixing the issue that syllance pointed out and it also fixes the obvious issue with the drupal_goto function arguments. duh! ------------------------------------------------------------------------ Tue, 20 Sep 2005 19:02:41 +0000 : der Attachment: http://drupal.org/files/issues/system.module_12.patch (2.48 KB) I've thought about this and I think it makes sense to break this enhancement request up and provide the second request (Admin Control Panel) as an add-on module. Therefore I've scaled this patch back to handling only the first enhancement request: /Add a new general settings option to allow the user to specify the admin home page. Currently the watchdog log view is the default home page./ ------------------------------------------------------------------------ Tue, 20 Sep 2005 19:12:41 +0000 : chx print theme('page', foo) is not used in HEAD, it's return foo. This approach now looks pretty good. I had another approach in my mind but this begins to look good. I'll test it later. ------------------------------------------------------------------------ Tue, 20 Sep 2005 19:21:39 +0000 : der Attachment: http://drupal.org/files/issues/system.module_13.patch (2.47 KB) new patch per chx's comment ------------------------------------------------------------------------ Tue, 20 Sep 2005 21:43:37 +0000 : syllance patch works fine. this is a small but useful feature, i think it should be added to core while waiting for the reworked control panel module. may be we could close the thread and switch to a new one for the upcoming module, as the comments start to grow (guilty, your honor :) keep up your nice work Der :) your patch was nice, but i'm sure we'll soon have a nice admin panel module. (and there is no doubt about it if chx says it begins to look good :) don't know anything about the approach mentionned by chx, but i really like the result of having der panel + chx one for navigation, this really gives drupal an improved admin usability. thanks² :)

1 0

[drupal-devel] [task] New drupal forms api.
by adrian 21 Sep '05

21 Sep '05

Issue status update for http://drupal.org/node/29465 Post a follow up: http://drupal.org/project/comments/add/29465 Project: Drupal Version: cvs Component: base system Category: tasks Priority: critical Assigned to: adrian Reported by: adrian Updated by: adrian Status: patch (code needs work) Attachment: http://drupal.org/files/issues/form.inc (20.53 KB) This is the first check in of the new forms api code. The system has been designed to co-exist with the current forms api, and is contained in a new include file (includes/form.inc). Forms are now defined in their component arrays, similar to how menu items are defined. example : <?php $form['body'] = array(type => 'textarea', default_value => $node->body, cols => 60, rows => 60); ?> Elements can also be nested, and the $edit follows this definition. For instance : <?php $form['author'] = array(type => 'fieldset', title => t('Authoring information'), collapsible => TRUE, collapsed => TRUE, weight => -1); $form['author']['name'] = array(type => 'textfield', title => t('Authored by'), maxlength => 60, autocomplete_path => 'user/autocomplete', default_value => $node->name, weight => -1); ?> All the properties used are defined as constants, and are documented for each of the elements, and individually. adrian

32 138

[drupal-devel] [bug] Update update.inc to use node_get_types
by chx 21 Sep '05

21 Sep '05

Issue status update for http://drupal.org/node/31770 Post a follow up: http://drupal.org/project/comments/add/31770 Project: Drupal Version: cvs Component: other Category: bug reports Priority: critical Assigned to: chx Reported by: chx Updated by: chx Status: patch (code needs review) Attachment: http://drupal.org/files/issues/update_119.patch (609 bytes) - chx

2 1

[drupal-devel] [bug] Comments per page, links don't go to correct page
by mindless 21 Sep '05

21 Sep '05

Issue status update for http://drupal.org/node/26966 Post a follow up: http://drupal.org/project/comments/add/26966 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: jakeg Updated by: mindless Status: patch (code needs review) We have this problem on http://gallery.sf.net too.. the incorrect redirect url after posting a new comment on a long topic was the case I noticed. I did fix one link in the forum module, see patch here: http://drupal.org/node/31645 mindless Previous comments: ------------------------------------------------------------------------ Mon, 18 Jul 2005 15:53:36 +0000 : jakeg When you, as admin, set the default number of comments per page, the links to those comments are not updated as they should be. For example, all links to individual comments still go to /node/x/#comment-x but comment no. x may not be on that page if x is bigger than the number of comments per page. Hence the link is wrong. This includes links from the 'recent comments' block and also very importantly after someone has submitted a new comment, they should be taken to their comment but if their new comment isn't on the first page then they have the same problem. This is a *big* problem if you have discussion/comment threads of more than about 100 posts (some threads on my site are over 300 posts) and hence you can't sensibly include them all on one page. ------------------------------------------------------------------------ Wed, 27 Jul 2005 20:44:29 +0000 : jakeg bump. I consider this to be quite important. Its definitely a 'bug' and not a feature request as when you click a link to a certain comment you expect to get to that comment, as the # in the URL would suggest. ------------------------------------------------------------------------ Tue, 09 Aug 2005 08:19:03 +0000 : jakeg bump - can anyone help? Its a major problem for me. ------------------------------------------------------------------------ Sun, 21 Aug 2005 06:58:32 +0000 : robertDouglass Changing this to CVS and widening the scope. When I set the comments per page at 10, in the CVS version, and then make a node with over 10 comments, I get no pager links to other pages of comments, but rather a useless "moderate comments" button. In short, in my install from yesterday, comments are foobar. ------------------------------------------------------------------------ Thu, 25 Aug 2005 23:49:03 +0000 : tostinni Attachment: http://drupal.org/files/issues/comment_page.patch (1.02 KB) "When I set the comments per page at 10, in the CVS version, and then make a node with over 10 comments, I get no pager links to other pages of comments, but rather a useless "moderate comments" button. In short, in my install from yesterday, comments are foobar. " Ok I got a patch for this, it's just a smal mistake in the order of the pager_query arguments. I'll have a look at the comment link tomorrow. ------------------------------------------------------------------------ Fri, 26 Aug 2005 22:49:52 +0000 : tostinni Regarding the block comment : "When you, as admin, set the default number of comments per page, the links to those comments are not updated as they should be. For example, all links to individual comments still go to /node/x/#comment-x but comment no. x may not be on that page if x is bigger than the number of comments per page. Hence the link is wrong. " In HEAD, it seems that links goes to /node/$nid#comment-$cid so I think there's a mistake here, it should be /node/$nid/$cid#comment-$cid if you want to see the individual comment. But if we want to see global comment thread and move the focus to the current comment, we should consider doing something like node/$nid?page=$pid&comments_per_page=10#comment-$cid $nid, $pid, $cid are variable defining the comment. What do you think about this ? ------------------------------------------------------------------------ Tue, 30 Aug 2005 17:29:51 +0000 : tostinni Attachment: http://drupal.org/files/issues/comment_page_0.patch (2.32 KB) Here comes a new patch, and for the moment, here will stop my contributions. I need help and review because I don't know how to fix the next bugs. What do my patch : - correct the pager_query function to see the list of comment as described in #4 - correct the links on the title of the comment when seeing the comments. Currently they are built like : /$nid#comment-$cid this doesn't work when a page is specified, so we have to look if URL get extra parameters like "page=1" to rebuilt the url link. So I modified phptemplate engine to change the comment theme function in order it takes these parameters. Now I'm still blocked because I don't have any idea how to solve the biggest problems in comment_block and about redirecting user after posting his comment. This is not so hard to tell, but I don't know a clean way to do this : In comment_block, the problem is that when we make the link to last comment, we didn't know the page where the post is supposed to be (this only happen when we have a threaded mode). So we should find it. Yes, but the problem is how... We should do an other query, like the one we made in comment_render and then find the position in thread of the current comment to add the page fragment to the url. It happens pretty much the same in the redirection after writing a comment. Any odeas on how we should make this ? 4.7 is coming... :) ------------------------------------------------------------------------ Mon, 12 Sep 2005 21:18:14 +0000 : killes(a)www.drop.org The first patch is an obvious bugfix and shoudl be committed. I don't understand the rest of the probem, though. paged coments have been broken for a long time, so it would be nice to see them fixed.

1 0

[drupal-devel] [feature] Administration Control Panel suggestion
by syllance 20 Sep '05

20 Sep '05

Issue status update for http://drupal.org/node/31326 Post a follow up: http://drupal.org/project/comments/add/31326 Project: Drupal Version: cvs Component: system.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: der Updated by: syllance Status: patch (code needs review) patch works fine. this is a small but useful feature, i think it should be added to core while waiting for the reworked control panel module. may be we could close the thread and switch to a new one for the upcoming module, as the comments start to grow (guilty, your honor :) keep up your nice work Der :) your patch was nice, but i'm sure we'll soon have a nice admin panel module. (and there is no doubt about it if chx says it begins to look good :) don't know anything about the approach mentionned by chx, but i really like the result of having der panel + chx one for navigation, this really gives drupal an improved admin usability. thanks² :) syllance Previous comments: ------------------------------------------------------------------------ Thu, 15 Sep 2005 17:50:52 +0000 : der Attachment: http://drupal.org/files/issues/system_9.patch (4.27 KB) New feature suggestion: I would like to suggest a couple of enhancments to administration pages. First, add a new general settings option to allow the user to specify the admin home page. Currently the watchdog log view is the default home page. Second, add a new control panel page that can be used as the default admin start page. I've attached a suggested patch to the CVS head version of the system.module that implements these two enhancements. The patch does the following. Adds a new "default admin page" text field to the general settings group (just after the "default front page"). It also changes the admin menu entry to call a new function that examines the default "admin page" variable and redirects to the appropriate path. For the control panel, the patch adds a new function (system_admin_controlpanel). This function basically looks for the admin entry in the menu structure and then iterates through the child menu items and builds a control panel page using the path and title information returned from the menu structure. For the control panel icons it looks for an icon file in the misc directory that matches the name of the menu item (e.g. user.png, access.png etc) If it doesn't find an icon it uses a default. I've also included some 48/48 icons that I borrowed from my usr/share/icon/gnome directory of my local Linux box. I believe these are gnome GPL'ed icons but any 48/48 icons could be used. This patch allows users who prefer the current functionality to keep it as their default. It provides the option for others to make any admin page they want to be their admin "home page" including using a graphical control panel. Module developers that add new admin menu options can add their own custom icons for the control panel but they are not "required" to do so as a default will be used if they don't provide one. ------------------------------------------------------------------------ Thu, 15 Sep 2005 17:52:15 +0000 : der Attachment: http://drupal.org/files/issues/drupal_controlpanel_icons.zip (39.09 KB) 48x48 icons attached ------------------------------------------------------------------------ Fri, 16 Sep 2005 14:30:16 +0000 : der Attachment: http://drupal.org/files/issues/system_2_0.patch (4.5 KB) updated patch. slightly changed the formatting of the control panel page ------------------------------------------------------------------------ Sat, 17 Sep 2005 00:37:24 +0000 : moggy I quite like this. It certainly goes some way to making Drupal easier on the eyes for first time users. I noticed there's a lot of hard coded style. Would this not be better in a stylesheet and the code just containing classes and ids? Also would a dropdown box of possible admin pages be better than trying to remember how to spell controlpanel (something I'm having trouble with tonight ;-) ) ------------------------------------------------------------------------ Sat, 17 Sep 2005 13:02:08 +0000 : syllance Nice job :) the default admin page is a nice feature, and the controlpanel is a very good idea. This goes in the good direction to make Drupal more user friendly. i agree with the dropdown menu and stylesheet additions, but i already really appreciate the current version. hope this will go into core soon, as it really makes the first admin pages contact better :) i don't mind scrolling through the nav menu and i rarely goes into admin without checking the logs, but that definitely will help me converting my wife's site to drupal :p thanks ! ------------------------------------------------------------------------ Sat, 17 Sep 2005 16:09:43 +0000 : der I'll move the styles off to a style sheet but I'm uncertain about whether or not make make the default admin page a dropdown. It's an easy change and it eliminates any typos by the user but it also restricts the user to a current visible admin menu item. If by chance someone wanted to write their own admin start page (ie their own control panel) they would have to hack the core system.module to do it. Anyone else want to weigh in with their preference? Also, anyone up for creating drupalized versions of the control panel icons? ------------------------------------------------------------------------ Sat, 17 Sep 2005 16:16:15 +0000 : chx Maybe just because I created it, I like my control panel module better. ------------------------------------------------------------------------ Sat, 17 Sep 2005 16:25:30 +0000 : der If I would have known there was a module I wouldn't have written this patch although I do think this would be good for core Drupal as the default. Is your modules a recent creation? I don't see it on drupal.org nor could I find in the contribs section of CVS (either the modules or sandbox sections). I'm I missing something? Is it called something different? ------------------------------------------------------------------------ Sat, 17 Sep 2005 18:20:15 +0000 : syllance chx control panel is located in his sandbox (cp.module), and thanks to him for letting us know there's one :) it's working fine (tested on HEAD) and provide interesting concept for navigating through the admin, instead of just add a frontend. the settings part is the better one, listing all elements in the page makes quickly forget the standard menu. der's one looks nice and provide a more immediate access to admin pages, but the standard menu is still mandatory to access some elements (dba or store settings for example, still needs to be accessed via left menu). to be honest, i like them both :) being able to change the default admin page is very nice, and icons make admin looks a lot better, raising the Woman Acceptance Factor by a huge amount (my wife loves it :). but i also really like the more in depth admin navigation offered by chx module. mixing both on my head setup gives a nice result, so may be it would be a good idea to join forces and mix the 2 panels. chx, is your module somewhat official and scheduled to hit the core ? ------------------------------------------------------------------------ Sat, 17 Sep 2005 19:24:11 +0000 : Amazon Hi, I asked Karoly to create the control panel module. It important that the control panel be tied into the navigation menu block so that it does not create inconsistent navigation. The goal is to start a user experience grouping exercise to help the community categorize administration tasks. The first thing that has to happen is that administration must be considered a seperate situation from creating personal content in Drupal. To support this seperation of personal tasks and administration tasks we broke out administration to have a separate theme in the CivicSpace theme. Through research interviews into Drupal administration we need to discover what the goals and tasks of administrators are. Some early feedback is that site developers need modules to be evaluated on Drupal.org. They have also indicated they need better and consistent administration help ,with incontext list, which we have been adding. We have also heard administrators want a quick overview. Any change to provide a control panel like overview must have a dashboard like overview. You should assume that we will identify a list of 5-7 top goals for administrators. Once those those 5-7 top goals are identified we need to ensure administrators can acommplish tasks to achieve those goals. Some of those tasks will completed by clicking through to icons or admin interface links. Sub-goals will be accomplished by providing effective navigation. We need to consider 4 types of navigation to be added to the control panel: Global navigation, local navigation, contextual navigation, and situational navigation. Some of this navigation can be accomplished through a theme or blocks. Some will need to be in the page and some need to be added in otherways, such as interaction techniques. Keep all this in mind when creating a control panel solution. It also must respond to the fact that every site will have different permissions set and different modules. This is a complex problem and it's going to research and experimentation to get it right. But this is a big step in the right direction. Cheers, Kieran ------------------------------------------------------------------------ Sat, 17 Sep 2005 19:47:55 +0000 : der Attachment: http://drupal.org/files/issues/system.module_11.patch (5.61 KB) This has sparked a lot of good discussion. I've taken a look at cp.module and I think it really is complimentary with my proposed patch. I've taken my patch one step further and provided the settings icons in a collapsable group below the main control panel. This would allow access to all admin functions without referring to the traditional menu. Syllance, do you think this addresses the gap you saw in my solution? ------------------------------------------------------------------------ Sat, 17 Sep 2005 20:33:10 +0000 : der Kieran, I'm glad to see some serious thought going into the user experience for site administrators. I think separating the user and admin sections of the site is critical. It will not only allow extensive usability work to be done for site admins it will also make it much easier for theme creators as they will be able to focus on the end user experience. I like the admin theme for civicspace. My only dislike about the approach is that it's template driven which causes a sites template to be larger and more complex due to handling all the logic for user and admin themes. I think a better approach may be to use a module such as the sections module. This allows you to have smaller templates focused on user or admin themes. I agree with your point about making sure the control panel ties into them menu system. My approach uses the existing menu structure so modules are added dynamically and all permissions are enforced. ------------------------------------------------------------------------ Sat, 17 Sep 2005 22:21:05 +0000 : chx <?php function _system_adminpage () { drupal_goto($path = variable_get('site_adminpage', 'admin/controlpanel'), $query = NULL, $fragment = NULL); } ?> no way. Use menu !$may_cache and set the path based on the variable. Adding in-line style elements is also a no-go. The code style is not kept. Never a space between full stop and apostrophe, always otherwise. It's not $menuvisible but $menu_visible I must be blind (it's 0:17am) but // Build the settings section of the control panel does not seem to differ from the previous section. A function may be appropriate. ------------------------------------------------------------------------ Sat, 17 Sep 2005 22:39:40 +0000 : der Thanks for the code feedback. I'm assuming the extracted style info would get patched to drupal.css? Your right about the duplicate code. A function would make more sense, I'll make the change. I'm not sure about the comment to use "$may_cache" I've never used it before. What's it's purpose? How should I use it in this situation. I'll dig around and see if I can figure it out but I thought you might be able to give me a little insight. Thanks! ------------------------------------------------------------------------ Sun, 18 Sep 2005 10:41:00 +0000 : syllance der, i've checked the new version of your control panel, and it does simplify access to the settings menu (although with a complex setup, the site config collapsable menu goes a lot more down than the menu, but this a page and not a small menu so its still better) however, there other case settings like, such as the ecommerce modules, which provides a more complex menu tree (ex : store->settings->payment->adjustments, each with their own admin pages). these are not taken into account by your panel, leaving the menu mandatory. chx control panel handles this nicely with page navigation. going through the store menu with chx panel is a real pleasure while its a real pain with the menu. So i think the best would be to mix the two panels, chx one handling page navigation, and yours providing a frontend for basic admin pages, and collapsable site config items. instead of linking to the standard admin pages, icons might link to chx nav pages where there are sub entries. i'm running both today, and this already makes the admin really better, but i'm often switching from der panel to chx one (for store), so mixing both would be, for me, a very nice solution :p thanks for the good work :) ------------------------------------------------------------------------ Sun, 18 Sep 2005 12:54:55 +0000 : der Attachment: http://drupal.org/files/issues/control_panel.patch (5.61 KB) Here's a new patch with the code reworked per chx's comments with the exception of his objection to my use of drupal_goto function. chx, I'm probably missing something really obvious but I'm not understanding your suggestion. Are you suggesting I use some menu function to do the redirect? If so, I could not find one that suits my needs. Or are you suggesting to use the drupal_goto function in a different manner than I am using it. Like I said, I'm probably missing something really obvious here but for the life of me I don't know what it is. Any further advice would be greatly appreciated. The offending code below: <?php function _system_adminpage () { drupal_goto($path = variable_get('site_adminpage', 'admin/controlpanel'), $query = NULL, $fragment = NULL); } ?> ------------------------------------------------------------------------ Mon, 19 Sep 2005 13:42:57 +0000 : syllance i think there's a problem with your latest patch. it seems to display all icons as a vertical list. it may be a problem with my setup, but i'm using basic themes that comes with head. the administer page is thus very long, and this is not very useful. previous version was better, imho :) thanks ------------------------------------------------------------------------ Mon, 19 Sep 2005 14:10:03 +0000 : der which theme and which browser are you using? ------------------------------------------------------------------------ Mon, 19 Sep 2005 15:59:16 +0000 : der Attachment: http://drupal.org/files/issues/control_panel_0.patch (5.32 KB) I've tested this with IE and FireFox with each of the Drupal shipped HEAD themes and I'm not seeing the issue you described. Are you sure the patch applied correctly to drupal.css? Here's a slightly revised patch. It make the control panel icon group collapsable but open by default. ------------------------------------------------------------------------ Mon, 19 Sep 2005 18:09:22 +0000 : der Attachment: http://drupal.org/files/issues/control_panel_1.patch (5.64 KB) Sorry for the excessive number of patches. I just realized that my previous patch had an issue with icon image file names if there were admin and admin/settings menu items that were the same (eg admin/user and admin/settings/user). New patch attached to address. ------------------------------------------------------------------------ Tue, 20 Sep 2005 02:13:49 +0000 : syllance the vertical thing was probably due to a problem with my drupal.css. i've tested your new patch with a fresh update and the display is fine, but there's a bug. the site configuration panel displays store settings items (checkout,payment,shipping), and not the global settings one. this might be due to the menus item having the same name 'settings', although not located at the same level (administer/settings, and administer/store/settings). ready for another patch ? :) your panel adds a nice look and enable default administer page setup. but there's still a lot of menu access needed when other modules are setup (such as ecommerce), and i'm using it in addition to chx one to provide a complete admin solution :) chx one looks just like the theme you're using with no icons, but it really help accelerating admin navigation. i'm wondering if integrating both to core wouldn't be the ultimate solution. your panel more targeted at standard admin needs, and chx one helping users that deals with lots of modules & settings. thanks again ------------------------------------------------------------------------ Tue, 20 Sep 2005 02:19:54 +0000 : Amazon Hi, can you guys post some screen shots as you go along for those of us who don't want to keep installing new patches. ------------------------------------------------------------------------ Tue, 20 Sep 2005 02:25:06 +0000 : der Attachment: http://drupal.org/files/issues/Control Panel.png (101.02 KB) Sure, here's what the current version looks like with the civicspace admin theme. ------------------------------------------------------------------------ Tue, 20 Sep 2005 04:22:36 +0000 : der Attachment: http://drupal.org/files/issues/control_panel_2.patch (5.48 KB) Patch fixing the issue that syllance pointed out and it also fixes the obvious issue with the drupal_goto function arguments. duh! ------------------------------------------------------------------------ Tue, 20 Sep 2005 19:02:41 +0000 : der Attachment: http://drupal.org/files/issues/system.module_12.patch (2.48 KB) I've thought about this and I think it makes sense to break this enhancement request up and provide the second request (Admin Control Panel) as an add-on module. Therefore I've scaled this patch back to handling only the first enhancement request: /Add a new general settings option to allow the user to specify the admin home page. Currently the watchdog log view is the default home page./ ------------------------------------------------------------------------ Tue, 20 Sep 2005 19:12:41 +0000 : chx print theme('page', foo) is not used in HEAD, it's return foo. This approach now looks pretty good. I had another approach in my mind but this begins to look good. I'll test it later. ------------------------------------------------------------------------ Tue, 20 Sep 2005 19:21:39 +0000 : der Attachment: http://drupal.org/files/issues/system.module_13.patch (2.47 KB) new patch per chx's comment

1 0

[drupal-devel] [feature] Authentication hook for local users
by bslade 20 Sep '05

20 Sep '05

Issue status update for http://drupal.org/node/29147 Post a follow up: http://drupal.org/project/comments/add/29147 Project: Drupal Version: cvs Component: user.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: naudefj Updated by: bslade Status: patch (code needs work) Nedjo said: " "I assume authentication should be either local or external--not both" " What exactly do you mean by "local" and "external"? Are you assuming: * The definition of "local" means logging in with just /username/ to get the username and password info from the name/pass fields in the core Drupal users table? (without calling hook_auth()) * The definition of "remote" means logging in with username@doman and calling hook_auth to get the username password info from some source /other than/ the core Drupal users table? I think this issue is talking about implementing some sort of authentication hook/module so that item (1) can access some other local table besides the core Drupal users table without having to hack the user.module. It sounds like, right now, the answer is, "can't do that". Ben in DC bslade Previous comments: ------------------------------------------------------------------------ Thu, 18 Aug 2005 20:46:57 +0000 : naudefj Please implement a hook to authenticate local users - similar to what hook_auth does for remote users. Alternatively, extend hook_auth to authenticate both local and remote users. Current behaviour: - If a user logs in with "user@domain", hook_auth gets activated; - If a user logs in with "user", hook_auth is bypassed. More details: http://drupal.org/node/27959 ------------------------------------------------------------------------ Sat, 20 Aug 2005 20:11:29 +0000 : killes(a)www.drop.org use hook_user(login) ------------------------------------------------------------------------ Sat, 20 Aug 2005 20:38:53 +0000 : naudefj I just tried hook_user(login), but it only fires when a valid drupal userid/password is entered. ------------------------------------------------------------------------ Sat, 20 Aug 2005 21:03:38 +0000 : naudefj I found the reason why hook_auth only works for remote users. Look at this code from users.module: // Try each external authentication source in series. Register user if // successful. else if (!$user->uid && $server) { Is this something that should be fixed, or should I just comment out the the "&& $server" part myself? ------------------------------------------------------------------------ Sun, 28 Aug 2005 19:03:24 +0000 : naudefj Attachment: http://drupal.org/files/issues/user_31.patch (1.7 KB) Here is a patch that will allow HOOK_AUTH to work for both local and remote users. If would be great if it can be reviewed and applied to HEAD. ------------------------------------------------------------------------ Sun, 11 Sep 2005 05:32:55 +0000 : moshe weitzman hook_auth deliberately is ineffective for local logins. if you enable it for all logins, you will slow down the experience for many people who guess their passwords wrong on login page. in that case, code would call all remote auth modules an dthey in turn would contact their home base. thats too slow. we want to return a 'sorry try again' message very quickly. what are you trying to accomplish here? ------------------------------------------------------------------------ Sun, 11 Sep 2005 06:59:52 +0000 : naudefj Hi, > hook_auth deliberately is ineffective for local logins. Not true. HOOK_AUTH cannot be used for local logins. Look at this line in user.module: else if (!$user->uid && $server) { > what are you trying to accomplish here? I would like my users to use their existing forum userids and passwords to login to Drupal. However, I quickly discovered that external authentication only works if you append a domain/servername to your userid. For example, if a username like "user*@domain*" is entered, HOOK_AUTH gets activated. Problem is that if a userid like "user" is used, HOOK_AUTH will be bypassed. This fix allows local users (i.e. just "user") to be authenticated against an external source. Any other solutions/ suggestions would be greatly appreciated! Best regards. Frank ------------------------------------------------------------------------ Sun, 11 Sep 2005 14:49:15 +0000 : nedjo "The fix allows local users (i.e. just "user") to be authenticated against an external source. " Why? I assume authentication should be either local or external--not both. Therefore, we need a way to distinguish between the two. Currently, the username@domain convention is used. Removing the @domain part of the DrupalID would remove this disctinction. Is the issue just that this convention is confusing for new users? In this case, I'd suggest pulling the domain part out into a different field. So, when drupal.module is enabled, there is a third user login field, "site" or "domain", that would include "local" and any registered associates. ------------------------------------------------------------------------ Mon, 12 Sep 2005 06:01:36 +0000 : naudefj > Why? Without it, it would be impossible to have a single userid/password for your entire site. It would be silly to ask users to log in to Drupal using their forumid@local. Surely there must be a way to authenticate them without having to type the "@local" part? > So, when drupal.module is enabled, there is a third user login field, "site" or "domain", that would include "local" and any registered associates. Not sure I understand - I'm not using drupal.module, but are trying to implement my own authentication module without the need to hack into user.module (or any other module for that sake).

1 0

[drupal-devel] Q: Custom node types in forums?
by David Cohen 20 Sep '05

20 Sep '05

I posted this question <http://drupal.org/node/30980> some time ago and got zero response. I'm following up here because I'd like to hear from Drupal experts before I pursue it any further. Briefly (this repeats content from the link above), I've created a new node type. It's an event with dates, location and other data. I want the event discussed in my forums, but I don't want to create a new forum entry in parallel with my event node. I'd like my event node itself to appear in the forums, as well as other places on the site (event calendar, etc). So my idea is that forums should include any node of any type, as long as it is associated with a forum taxonomy term. That is, if I create any node at all and give it the taxonomy term Forum->Events, it will appear in my Events forum. The current forum package does not work this way. It only shows nodes of type 'forum' and has a forum table which includes all forum nodes. I think both of these 'limitations' could be removed. Unless of course there is good reason for them that I do not see. Which is why I'm asking now. As I said in my earlier post, I'm willing to contribute to this if others like the idea. Thanks for your input, -Dave

5 6