April 2007 - Development - lists.drupal.org

Wrong usage of urlencode and drupal_urlencode
by Wim Mostrey 16 Apr '07

16 Apr '07

From the php.net handbook: "This function is convenient when encoding a string to be used in a query part of a URL, as a convenient way to pass variables to the next page." Currently the urlencode function is not only used for passing the url but also for displaying it, using l() for instance. Many modules experience errors because of this issue: upload, filefield, image, imagecache, .. Also just linking to a filename using l() fails. The value field always contains the correct filename (for example "this is a+test.pdf") while the actual link refers to the urlencoded filename (for example "this+is+a%2Btest.pdf" or "this+is+a+test.pdf") on which it breaks, since that file does not exist. I feel that while url() shouldn't be altered, l() should urldecode (or have a drupal_urldecode) the output created by url(). Currently all those modules are fixing this issue themselves, or are not addressing the issue at all, while I believe core should address this. Wim

3 4

Menu system -- call to action! Really!
by Karoly Negyesi 15 Apr '07

15 Apr '07

Hi, there is another reason why I would like to see someone writing expanded menu items who is not me: there should be someone else who understands the new menu in depth. My next week will be spent with writing the update path and the multiple menu support. The week after, I have already committed all my free time (and my money too) to the form API rush with Eaton. If the HRSDC approves my job offer (and I can't really see why not), then I will have a feverish run of collecting and submitting various papers, certifications and stuff and then medical examinations and then preparing and executing the actual move to Vancouver. I have no idea how much core time I will have after May 1, but... it might be less than you guys are used to. Tasks: -- expanded items support -- The menu localization patch needs to revived and brought to home. -- The modules admin page is still not coded for the new system. -- if you really want work, take over multiple menu support. Regards, NK

2 3

Patches on OS X
by Ken Rickard 14 Apr '07

14 Apr '07

All- I'm trying to troubleshoot an issue that came up when working on http://drupal.org/node/118660. I run OS X (10.4) and roll patches using 'cvs diff -up > file.patch' on the command line. This uses the Darwinports version of cvs. As near as I can figure, differences in how Macs handle linebreaks (/n vs. /r) cause problems, as running the patch will generate the error: "patch unexpectedly ends in middle of line" See http://drupal.org/node/122734 for another example. A Google search reveals 84 reported instances of this type error on drupal.org, so I'd like to add some handbook notes about it, but can't figure the solution. It seems to be quite common (there are over 400,000 matches on google), but no one ever reports a solution. The closest I've seen is dreweish's note at http://drupal.org/node/35945#comment-217838, which suggests running a linebreak converter before applying a patch. But this doesn't seem to help me in rolling and submitting a patch. Unless the answer is to run a linebreak converter on the patch after its rolled and before I submit it. But opening the patchfile in BBEdit indicates that the file has Unix line ends. I can even see in the Darwinports release where this error comes from. ( http://www.opensource.apple.com/darwinsource/Current/patch_cmds-10/patch/pc…) But no instructions for how to handle it. Offlist answers are fine. I intend to write a handbook note with the answers. Ref: http://www.google.com/search?hl=en&client=firefox-a&rls=org.mozilla%3Aen-US… http://www.google.com/search?hl=en&client=firefox-a&rls=org.mozilla%3Aen-US… -- Ken Rickard agentrickard

1 1

ANN: drupal.org improvements series
by Kristjan Jansen 13 Apr '07

13 Apr '07

Hi, I started bloggin on drupal.org improvement ideas: http://kika.trip.ee/drupal (also picked up by Drupal Planet). While I know it is actually better to submit feature requests, I continue on current workflow since it allows me to contribute more while living under tight time schedule. Hopefully somebody picks up a torch on some ideas :) Kristjan Jansen kika.trip.ee | kikamele.trip.ee

3 3

Update number changes
by Karthik 13 Apr '07

13 Apr '07

For those running HEAD, watch out for http://drupal.org/node/130331 , else you might be running the same updates twice. Update the schema_version field in the system table for the system module or just reinstall Drupal to fix it :) -K

1 0

RFC: Structured discussion module
by Darren Oh 12 Apr '07

12 Apr '07

I'd like to have module that helps people cut through the rhetoric that arises during arguments and focus on productive discussion. It could be called either "Structured Discussion" or "Argument Reconciliation". The module would make use of the following taxonomy structure: 1. Discussion vocabulary 2. Topics would the first level of terms in the hierarchy. 3. Positions would be the second level of terms. 4. Differences between positions would be the third level of terms. Each difference would inherit two terms from the positions level. 5. Evidences required to resolve the differences would be the fourth level of terms. Each evidence would inherit one or more terms from the differences level. The module would have the following content types: 1. Topic. When viewed, a table of positions and the differences between them would be attached. 2. Position. Must have at least one term from the topic level. Revising a position creates a new position and changes the status of the old position to "abandoned" until another user becomes its advocate. A position will also be abandoned if its advocate subscribes to another position with the same term. 3. Difference. Must have exactly two terms from the positions level. When viewed, a table of evidences would be attached. A difference starts with a status of "open" and is set to "resolved" when the advocates of the opposing positions accept and reject the same set of evidence. If all differences between two positions are resolved, the advocate of the rejected position will be automatically subscribed to the accepted position. 4. Evidence. Must have at least one term from the difference level. For each difference, the author must choose which of the positions it supports. An author may not choose two opposing positions for the same evidence. When viewed, a table of investigations would be attached. Advocates of each position can mark whether they accept or reject the evidence. If the advocate of the supported position rejects the evidence and the author of an opposing position accepts it, the evidence will not be a valid part the difference between the two positions. 5. Investigation results. Must have at least one term from the evidence level. Investigation status can be either "in progress" or "complete". Each content type could have terms only from a specific level of the taxonomy tree. The content type would create a term for the next level. It would be nice to enable RSS aggregation so that topics could pull in positions from other sites, positions could pull in differences from other sites, differences could pull in evidence from other sites, and evidences could pull in investigations from other sites. Is anything like this being worked on now?

1 0

Note that PHP arrays are fast
by Karoly Negyesi 12 Apr '07

12 Apr '07

Hi, Note my trick in http://drupal.org/node/134697 which shows that the hash lookups in Zend Engine are a bit faster than branching. Instead of $class = $class == 'even' ? 'odd' : 'even' we have $flip = array('even' => 'odd', 'odd' => 'even'); $class = $flip[$class]; The first can be as much as 10% slower. I will explore this area further and I recommend everyone to familiarize themselves with the vast array of php array functions :) because next Drupal will be even more abound with arrays. Regards, NK

10 12

Module developers - please test your modules on 5.2-dev
by Heine Deelstra 12 Apr '07

12 Apr '07

Dear module developers, Please test your modules on Drupal 5.2-dev. It has a duplicate form submission filter <http://drupal.org/node/107358#comment-204814> that may cause subtle issues with your modules' form submissions. This happens when the proper operation of your module requires or should support subsequent submissions that have the same $_POST data. The remedy is to set #skip_duplicate_check for your form, or the form that your module alters. Regards, Heine Deelstra

1 0

hook overriding
by Ashraf Amayreh 11 Apr '07

11 Apr '07

I've just posted two more examples on cases that I believe can't be solved without the concept of hook overriding. http://drupal.org/node/134148 Still opinions on why this feature should (or should not?) be included in drupal. Thanks for your time :-)

3 4

watchdog -> dblog + syslog
by Dries Buytaert 11 Apr '07

11 Apr '07

Hello world, I've just committed a patch (http://drupal.org/node/63881) that adds a tiny syslog module to Drupal core. In addition, the watchdog module has been renamed to dblog (database logging). Last but not least, there is now a _watchdog() hook that modules can tap into. In other words, it's now possible to integrate with existing logging applications or to write custom logging handlers (i.e. to send you an SMS message when something goes wrong, or to send you a Jabber notification when someone posts a new comment on your Drupal blog). If you're a developer, you'll notice that we now have additional "watchdog levels" like WATCHDOG_CRITICAL and WATCHDOG_DEBUG. These are conform RFC 3164 and are defined as constants in bootstrap.inc. Check 'em out. The patch is a little rough around the edges -- most notably on the documentation side (help texts, form descriptions, terminology) ... We'll want to work on that, and I expect to see a number of small follow-up patches to polish some of this. We'll also want to provide some basic instructions on how to setup the syslog routing in syslog.conf. We'll want to formulate practical advice as when to use dblog and when to use syslog. Feel free to help with that, as you explore the new functionality. It can be done in multiple small steps. :-) Most of the work has been done by Khalid and jakeg, so thanks Khalid and Jake! Let's try to get more logging improvements into Drupal 6. Anyone wants to improve the dblog module to work like this: http:// www.flickr.com/photos/dries/234754367/ ? -- Dries Buytaert :: http://www.buytaert.net/

5 7