May 2007 - Development - lists.drupal.org

Re: [development] The Drupal Diet - Making bootstrap faster
by Larry Garfield 10 May '07

10 May '07

On Thu, 10 May 2007 06:43:21 -0700, David Metzler <metzlerd(a)metzlerd.com> wrote: > For some reason I was lying awake at night thinking about drupal boot > strapping (dear lord help me). I can recommend my therapist. He's used to that by now. :-) > And it occured to me that although > the frequency of use is certainly the right measure to decide what to > load, that it probably isn't by technology, so I came up with a > couple of different ways to think about this. I'm not sure what you mean by technology? > BY MENU PATH > 1) System stuff - api's etc that need loading all the time. > 2) node viewing pages (node* paths/routes) (not so sure this would work) > 3) User settings (not sure about this one, but maybe anything with a > user* menu path > 4) admin pages (basically everything with an admin/blah route path > > You could even consider doing the admin pages based on a permisssions > test (access admin pages). The module_name.module files would > always load, but maybe there would be room for a > modulename.admin.module or a modulename.user.module file that would > be conditionally loaded based on either path or user permissions or > some other criteria. > > BY NAMESPACE > Or alternatively a namespace based approach where when a module is > going to make a call that relies on another module it basically does > an "import" of namespace (the way its done in java) This would make > a bootstrap call that would load the modules that claim that > namespace. (etiher in .info files or in a hook). By permission is interesting. Tweaking menu_execute_active_handler() to do the permission check first before the include should be trivial, and be a small performance boost on 403 pages. That said, right now the patch is breaking down code by module and by function. The "by function" part is up to each module author to decide. That's better than forcing an "admin pages", "other pages", "node pages", etc. split because we'll only ever call one page callback per page load. Why load all 70 admin page callbacks when we're only using one of them? The extreme case is one page callback per file, but I don't think that's a wise way to go in most cases. Different modules, though, will "fit" with different breakdowns. That should be flexibility left to the module author. The namespace approach is what chx suggested with magic function loading. I experimented with it, but eventually decided it was too opaque to deal with at this stage. I want to stick to page callbacks for right now, as those are the biggest dead weight on most page calls. More info in the issue queue: http://drupal.org/node/140218 . Reviews welcome. :-) The sooner we can get this in, the sooner we can start optimizing core. --Larry Garfield

1 0

Re: [development] update/replace the book module - poll, questions
by Peter Wolanin 09 May '07

09 May '07

Tao, this is exactly the point we're heading for- the new "book" module should primarily provide a UI and navigation elements, while all the heaving lifting in terms of maintaining the hierarchy will be done with the code and tables defined in menu.inc. -Peter >From: Tao Starbow <starbow(a)citris-uc.org> >To: development(a)drupal.org >Date: Tue, 08 May 2007 17:28:14 -0700 >Subject: Re: [development] update/replace the book module - poll, questions >I am probably missing something obvious, but why not just leverage the >parent-child relationships defined in the menu system and do away with >book entirely? It seems like the only things book does that menu >doesn't is put in the cute next/prev and children links, which would be >easy enough to add in. Other than that it is just UI. > >cheers, >-t

2 1

Impasse: Links to <front> are not marked active
by Barry Jaspan 09 May '07

09 May '07

Links created with l() to the special path '<front>' are not marked with the CSS class "active" as they should be. The issue http://drupal.org/node/78487 discusses the problem and has a working patch. Unfortunatey, we have an impasse on the fix. Let's not ship D6 with this ridiculous little bug still alive. The patch is not committed because drumm said (#10): "Any code which passes '<front>' to l() is buggy. We should be fixing the root problems, not symptoms." I replied (#11): "function url() is also written to assume that <front> may be passed. From common.inc:1.611 line 1183: // The special path '<front>' links to the default front page. if (!empty($path) && $path != '<front>') { In my case, I've added <front> to the primary links menu. I could submit a patch to menu_item_link() to replace <front> with '' before passing it to l(), but I'd suggest that would constitute fixing a symptom, not the root problem. We'd basically have to fix every invocation of l() because the API has specified for a while that you can pass <front> and it will work so we don't necessarily know everywhere it might occur." So, if fixing l() as in the patch is wrong, can someone suggest the correct fix? Thanks, Barry

1 0

Theming system, round 2
by Earl Miles 09 May '07

09 May '07

Hey all; Hopefully you've seen that I've done a lot of changes to the theming system for Drupal 6. I'm not done yet, and I invite help and/or discussion on the next wave of things. In particular, the stylesheets topic probably has a lot of discussion that it could use. http://drupal.org/node/141727 => Allow maintenance theme functions to be themable http://drupal.org/node/141725 => Allow multiple stylesheets in the .info files http://drupal.org/node/141914 => We need to convert theme functions to templates where possible http://drupal.org/node/141730 => Allow theming system to use wildcards

2 1

FYI: New way to classify releases on drupal.org
by Derek Wright 08 May '07

08 May '07

All project maintainers are encouraged to read: http://drupal.org/node/142344 thanks, -derek (dww)

1 0

Re: [development] Netvibes Universe
by Noah Biavaschi 08 May '07

08 May '07

Here is a link to the opml for my netvibes tab with about 20 drupal related feeds/blogs http://www.netvibes.com/subscribe.php?url=http://eco.netvibes.com/opml/aa7c… > Subject: > Re: [development] Netvibes Universe > From: > Gabor Hojtsy <gabor(a)hojtsy.hu> > Date: > Tue, 08 May 2007 17:10:40 +0200 > To: > development(a)drupal.org, matt(a)mattfarina.com > > To: > development(a)drupal.org, matt(a)mattfarina.com > > > Matt, Drupal Planet, the CVS RSS feed, Flickr Drupal tag, Google Video > drupal tag, lullabot podcast, and so on are logical candidates :) > > http://drupal.org/planet/rss.xml > http://drupal.org/cvs?rss=true (this is very busy, think about it) > http://flickr.com/photos/tags/drupal/ > > http://video.google.com/videofeed?type=search&q=drupal&so=1&num=20&output=r… > > http://www.lullabot.com/podcast/feed > > Gabor > > Matt Farina wrote: >> Last month netvibes launched universes [1]. One part of the >> universes is branded universes and the branded ones launched so far >> have been for recording artists and sites like CBS, Newsweek, etc. >> Netvibes is willing to create a branded drupal universe. >> >> If you don't know what netvibes is or a universe is check out >> http://netvibes.com and http://eco.netvibes.com/universes/. >> >> What we need is a list of feeds for the universe and any messages >> displayed. Anyone have any recommendations? >> >> - Matt >> >> [1] http://blog.netvibes.com/?2007/04/17/130-enter-the-netvibes-universe >>

1 0

AJAX security issue
by Ashraf Amayreh 08 May '07

08 May '07

Hello all, One of my friends has a sign-up page that contains an AJAX call to the server that check the username availability without submitting the page. This is not much unlike many sign-up services now-a-days. He was wondering how he could prevent someone from abusing this by writing his own page which could gather information from repeatedly calling the web server via AJAX calls? I've read many threads on AJAX security, but none that I have read handle such a trivial scenario. The above case is very simple but I'd like to see what people have in mind to protect against abusing such a call to gain sensitive site data. Thanks!

5 6

CVS branches and tags problem
by Sergio Caridad 08 May '07

08 May '07

Hi all, I'm the maintainer of the galician translation http://drupal.org/project/gl I've been trying to add the new 5.0 release to the project, with no luck. First, I created a DRUPAL-5 branch for the project, with the new files committed. Then, I created a new tag, DRUPAL-5--1-0. Then, I added the new release node, associating it with the recently created tag. But the packaged release is not there, the node is empty http://drupal.org/node/135656 (several days since then) I must have done something wrong in the CVS, but I don't know what... I can connect to the CVS and download the files for the 5--1-0 tag with no problem, so the files seem to be correctly tagged... what am I doing wrong? Any other translation/project maintainer could help me out? I've read the cvs guides, branching/tagging guides, etc. but I must have messed something up. I'm using the Eclipse CVS and also tried with TortoiseCVS. I have also posted my problem here http://drupal.org/node/139170 but I had no replies, so, since this is an important issue, I'll try once again in this list. Anyone? Thanks! ______________________ Sergio Caridad www.artefantastico.com sergiocaridad(a)gmail.com

2 1

Netvibes Universe
by Matt Farina 08 May '07

08 May '07

2 1

problems with db_rewrite_sql()
by Stella Power 08 May '07

08 May '07

Hi, I'm trying to implement db_rewrite_sql() on all sql queries that list nodes in the faq module so as to support i18n localization. However, I've run into difficulty getting it to work in a settings form. The same code in a different function works fine, so I'm unsure why the sql isn't getting rewritten in this case. I created an issue about it (#138624) a few weeks ago but it hasn't gotten any replies. At this stage, this is the only issue preventing me from doing a new release of the faq module. So if anyone has encountered this before or knows what I may be doing wrong, please let me know! Cheers, Stella

1 0