June 2007 - Development - lists.drupal.org

Interesting forum module patch
by Dries Buytaert 17 Jun '07

17 Jun '07

Patch http://drupal.org/node/20295 is looking for someone who can write help texts, and who can give some parts of the UI some usability-love. It's well-suited for a Sunday afternoon. :-) -- Dries Buytaert :: http://www.buytaert.net/

1 0

Drupal 5.2 ?
by Robert Douglass 17 Jun '07

17 Jun '07

There have been more than 110 bugfixes since Drupal 5.1. When are we planning on releasing 5.2? http://drupal.org/project/cvs/3060?nid=3060&branch=DRUPAL-5

5 4

comment module needs a little refreshment
by Karoly Negyesi 16 Jun '07

16 Jun '07

Hi, I began refreshing comment module -- it's really bizarre pre and post fapi code paths cries for it. I was at approx 50% and I had no time to continue and today I honestly tried but I just do not have the heart for it. Likely the settings forms can be moved over without a problem so there is little work to do, mostly just testing and bugfixing. The issue is at http://drupal.org/node/152417 . If you are interested you can find me in #drupal I'd be delighted to lead. Regards, NK

1 0

Re: [development] Can I use an external user DB instead of the original user table in drupal DB?
by andy＠spiders-lair.com 16 Jun '07

16 Jun '07

> I want users to provide more profile, and module profile can solve > this issue. But it's not convenient to query the data, which user > provides. Because the data has been saved in 'profile_fields' and > 'profile_values', two tables separately. Think you're missing the point of "API". Use the user_load() function which loads a user, profile and all for your convience. If you want to see the structure returned (and where the profile fileds are) install the devel module which can display this for you. http://api.drupal.org/api/5/function/user_load

5 4

hook_help() vs $section for Drupal 6
by Gabor Hojtsy 16 Jun '07

16 Jun '07

Hi, In an unrelated issue, we found that hook_help($section) gets called with the menu key now. So - if you have a "node/%node/edit", you get this in the help hook - if you have a "node", (which gets called with node/$nid too obviously), you don't get the $nid in the help hook The argument for this is that it is easy to provide broad help texts. The arguments against is obviously that it is very hard to provide focused help texts (like it is impossible to provide help text for a block configuration page based on $section alone). A couple of ideas popped up from Peter Wolanin and myself, so we only need to pick up the right one :) 1. Pass on $_GET['q'] simply to hook_help(). This makes it harder to provide a broad help text, as you would need to preg the dynamic parts out yourself. 2. Pass on both $_GET['q'] and the menu key to hook_help(). This would allow for both, if you wish. $section would become $path and $menu_key or something along the lines. 3. Pass on the whole menu item structure which has even more details. For people who would like to customize their help even more (although I am not sure what else can be used from the menu there). Now what is left is to pick one of these up, or suggest something better, so I can prepare a patch, and we can get this fixed soon. Gabor

3 4

Can I use an external user DB instead of the original user table in drupal DB?
by Huisi Wang 15 Jun '07

15 Jun '07

Hi, I want users to provide more profile, and module profile can solve this issue. But it's not convenient to query the data, which user provides. Because the data has been saved in 'profile_fields' and 'profile_values', two tables separately. So can I use an external user DB instead of the original user table in drupal DB, so that I can save all data in one DB table ? or some modules can solve this problem ? Thanks, Huisi

1 0

Foreign keys in Drupal 6
by David Strauss 14 Jun '07

14 Jun '07

Assuming the foreign keys patch to the schema API makes it in, there are four ways we can approach foreign keys in Drupal 6. 1. Don't use them at all. Just provide the schema API for contrib modules with higher database requirements than core. 2. Configure foreign keys as RESTRICT on delete. This will have no effect on MyISAM, but it will improve code quality because operations creating inconsistency would fail. Such operations would then be rewritten to manipulate the database in a consistent way. 3. Configure foreign keys as CASCADE on delete and have extra PHP run whenever a query manipulates a database using MyISAM. Basically, whenever a DELETE query gets sent to a MyISAM system, we would convert it to a SELECT query to identify the rows that would be deleted. Then, we would delete the records attached with foreign keys. Finally, we would run the original DELETE query. This would have to be recursive. 4. Configure foreign keys as CASCADE on delete and have modules conditionally run queries in their deletion hooks depending on the storage engine. If a module doesn't check the storage engine type, the DELETE it runs would simply be redundant. Personally, I think #2 would be a nice first step in Drupal 6. It would at least force us to clean up the database interaction so #3 or #4 could be seamlessly added later.

10 15

Announcing cvs_deploy.module
by Derek Wright 13 Jun '07

13 Jun '07

Hello world, FYI for anyone who cares about deploying Drupal sites directly via CVS... As per the discussions at: http://drupal.org/node/124661 (about providing support to update_status for folks who deploy from CVS) http://drupal.org/node/150316 (about moving all CVS-specific code out of update_status) and my meta comments on Dries's article about git: http://buytaert.net/linus-torvalds-on-git I decided to create a new contrib module called "CVS deploy": http://drupal.org/project/cvs_deploy See the description on the project page for more info. I'll make some release tags soon, probably once update_status 5.x-2.0 (at least a beta) is out. Meanwhile, HEAD is for 5.x core. Cheers, -Derek (dww) p.s. I hope to integrate this with drush_pm.module in the future to finally implement my dreams for a script to automatically update a site to the latest recommended official releases from all of your currently installed modules, directly via CVS. For the interested reader: http://drupal.org/project/drush http://drupal.org/node/124661 p.p.s. This module is only targeted at power users/developers who deploy sites via CVS, which is why I'm spamming this list about it. ;)

4 7

versioned schema?
by Peter Wolanin 13 Jun '07

13 Jun '07

A quick thought in terms of the Schema API and writing system/module updates: As far as I understand, on e shouldn't use functions like drupal_install_schema() in update functions since one cannot rely upon which version of the schema presently exists int he .schema file. To me this suggests that there should be a way having several different schema in the .schema file with different version numbers. Then functions like drupal_install_schema() could take an optional argument for the schema version. Does that make sense? -Peter

6 9

Re: [development] Use revisions to replace previews
by Michelle Cox 13 Jun '07

13 Jun '07

How hard would it be to add a third button? So you have "preview" "save draft" "save"? Save draft would go through what save normally does with the exception that it doesn't wipe out any existing "official" version of the node where "preview" would just show you without any sort of saving as it does now. I don't know about the code end but from the user end that makes sense to me. Michelle On 6/9/2007 4:48:32 PM, Dries Buytaert (dries.buytaert(a)gmail.com) wrote: I agree with this. As an excessive previewer myself, the mental model that lives in my head assumes that previews are volatile. I preview because I don't want to save my data before it's ready to be saved. I don't finish everything that I start writing so every once in a while, I abandon the post in which case the previews and the node ID would still be in the database? That said, I'm not opposed to an auto-save feature or a 'Save as draft' feature. Except that it should somehow align better with my mental model. Something else to consider -- spammers will often try to submit spam to your site. Even if they don't make it through, they might insert permanent junk in your database.

9 13