April 2008 - Development - lists.drupal.org

svn 1.5 supports -p
by Karoly Negyesi 28 Apr '08

28 Apr '08

Hello world, The first public release candidate of subversion 1.5.0 (RC4) is out there. There are several good things there but * 'svn diff -x' now takes '-p' extension option (issue #2995) cures a long standing nuisance for us. Thanks to the subversion team for adding this feature. Regards Karoly Negyesi

7 7

Seeking help internationalizing Views (and Panels and maybe other modules for D6)
by Earl Miles 27 Apr '08

27 Apr '08

Okay, so I have this idea for a module that will allow contrib modules to have their objects translated. I just did a scan of the modules available for Drupal 6.x involving translation, and #translateable seems close but not quite what I'm looking for, but it might be possible to turn it into what I'm looking for. Here's what I'm thinking: Many modules work with objects of some sort; particularly my modules. Because of the complexity of my objects, I've gone a long way to disengage them from the form. It is not possible to use duplicate, related objects to do translation, as is often done with nodes, because a view object does a LOT of stuff and it's very important not to have duplicates that try to do the same thing. This is also true of Panels. One thing I can do, is pretty easily identify any string I store as translateable. This is my proposed API: Views loads a view. Upon rendering, if the global $language->language is not the default language, and this module is enabled, Views will call MODULENAME_translate_object('views', 'view', $view->name) and do an inline replacement of all strings on the object itself. Views will also provide a 'translate' link which will lead to a URL provided by this module to translate that view. It may be possible to do some fapi integration with ajax translation but that's a 'bonus' feature. Could be cool, as long as it's not too hard to implement in my already crazy UI. /** * Return an array of translated strings, or NULL if there are no * translated strings for this object. * * @param $module * The name of the module that owns the object. * @param $type * The type of object being translated. Example: 'node', 'view', etc. * @param $id * The unique identifier of the object. May be a string! * @param $language * The language to translate to. If not specified, use the current * langauge from global $language. */ function MODULENAME_translate_object($module, $type, $id, $language) /** * Tell MODULENAME what objects your module has available for * translation. * * @return * An array of object identifiers. Each one must be unique. */ function hook_translateable_objects() { // example return array('view'); } /** * Tell MODULENAME what strings a particular object has available. * Because some objects may be dynamic, this is called for every * unique object id when translation is actively occurring. * * @param $type * The object identifier that corresponds to that used by * hook_translateable objects * @param $id * The unique object ID being translated. * * @return * An array of strings; the key is the string identifier, and * each value is an array that contains the following: * - title: The title of the field. * - description: The description of the field. * - value: The current value of the field. */ function hook_translateable_strings($type, $id) { // example return array('view'); } From the API perspective, that's about all I have to do. I have to do some extra work to make sure each component of the view provides the strings properly, but that's not hard. The translation interface will need to record state information on the strings, so that it can tell the user if the string has changed since the last time it was translated, making it easy to highlight what needs to be updated. It might be nice to provide a way to browse, but I think it's better to let the module provide that and require the module to provide a link to the translator; that's less work for this module and is likely to be much less clumsy. If someone implements this, I promise Views will use it and will use it very quickly. If a module like #translateable wants to use something like this, so much the better; I would really prefer it if an existing translation module can take on these features, so that we get more widespread usage. That said, my belief is that any module that Views uses for translation will see widespread use in the localization community, and thus, if well maintained, will become a de facto standard and we can convince other module developers to use it too. I'm willing to be flexible, too, but Views has special needs; you'll need to cater to it to get this working, and translating Views is a very important thing for a truly multi-lingual site. But also, with this API any of my modules will be easily translateable.

6 11

Arquitectura Drupal
by Pedro Enrique Castiñeiras Sanchez 24 Apr '08

24 Apr '08

Hola: Alguien me podría explicar si Drupal usa arquitectura Modelo Vista Controlador o Presentación Abstracción Control ? Agradecido de antemano. Saludos. _____________ NOD32 EMON 3048 (20080423) information _____________ This message was checked by NOD32 antivirus system http://www.eset.com

5 7

Very important testing update
by Karoly Negyesi 24 Apr '08

24 Apr '08

Hi, Yesterday we had quite a discussion on IRC which is summed up http://groups.drupal.org/node/10957 . Basically, mock functions were voted down as tests based on them takes too much developer resources to write and maintain. Instead, we are writing functional testing on an API level as described on http://drupal.org/node/30008 , for example: $this->assertEqual(l('Some page', 'node/34', array('class' => 'foobar')), '<a href="/node/34" class="foobar">some page</a>'); This test presumes and verifies somewhat that every function l calls is working correctly. Whether this still can be called unit testing or not is a pointless academic debate :) I expect that a number of tasks will be placed in the Drupal issue queue telling the community which tests are to be written. When this happens, I guess another email will land here and also I guess at various other places... I also plan to hold a 'testing hour' every single day starting probably next week. Stay tuned! Karoly Negyesi

1 0

Returning OR with hook_db_rewrite_sql
by Ron Parker 23 Apr '08

23 Apr '08

Hi. My module requires additional sql to return the correct content on taxonomy queries. I've used hook_db_rewrite_sql() to construct the sql I need, and it returns what I need. The problem is that my hook is AND'd with the taxonomy_access_db_rewrite_sql hook, and therefore voided. Example: In function taxonomy_term_page(): $result = db_query(db_rewrite_sql('SELECT t.tid, t.name FROM {term_data} t WHERE t.tid IN (%s)', 't', 'tid'), implode(',', $terms['tids'])); Once ran through the TAC hook and my hook, this query becomes: SELECT t.tid, t.name FROM term_data t WHERE (t.tid IN ('1')) AND (t.tid IN ('1','3')) AND ( t.tid IN (3)) TAC hook_db_rewrite_sql returns: (t.tid IN ('1')) My hook_db_rewrite_sql is returning: (t.tid IN ('1','3')) (correct) What I need is for my clause to be returned as OR rather than AND: SELECT t.tid, t.name FROM term_data t WHERE (t.tid IN ('1')) OR (t.tid IN ('1','3')) AND ( t.tid IN (3)) That would do the trick. Question is, how to do it? I've included my rewrite of the TAC db_rewrite_sql so you can see what I'm working with, but I'm hoping you might have some way for me to accomplish this short of hacking TAC. Thanks! -ron <?php /** * Implementation of hook_db_rewrite_sql() * * Used to include OGR roles in taxonomy/term * */ function og_user_roles_db_rewrite_sql($query, $table, $field) { if (!user_access('administer taxonomy') && ($field =='vid' || $field =='tid')) { global $user; $op = (arg(0) == 'node' && (arg(1) == 'add' || arg(2) == 'edit')) ? 'create' : 'list'; // let's cache static $taxonomy_access_sql_clause; $clause = array(); if (!isset($taxonomy_access_sql_clause)) { $taxonomy_access_sql_clause = array(); } if (!isset($taxonomy_access_sql_clause[$op][$field])) { if (isset($user) && is_array($user->roles)) { $rids = array_keys($user->roles); } else { $rids[] = 1; } if (isset($user)) { $query = db_query('SELECT ogr_id FROM {og_users_roles} where uid = %d', $user->uid); while($row = db_fetch_array($query)){ $ogr[] = $row['ogr_id']; } } else { $ogr[] = 0; } $sql = db_query("SELECT t.tid, d.vid, BIT_OR(t.grant_$op) AS grant_$op FROM {term_access} t INNER JOIN {term_data} d ON t.tid = d.tid LEFT OUTER JOIN {og_users_roles} ogr ON ogr.rid = t.rid WHERE (t.rid IN ('".implode("','",$rids)."') OR ogr.uid = ".$user->uid.") AND grant_$op = 1 GROUP BY t.tid, d.vid"); while ($result = db_fetch_object($sql)) { $tids[]= $result->tid; $vids[$result->vid]= $result->vid; } $clause[$op]['tid'] = isset($tids) ? implode("','",$tids) : ''; $clause[$op]['vid']= isset($vids) ? implode("','",$vids) : ''; $taxonomy_access_sql_clause = $clause; } else { $clause[$op][$field] = $taxonomy_access_sql_clause[$op][$field]; } $return['where'] = ($clause[$op][$field]) ? "$table.$field IN ('".$clause[$op][$field]."')" : "$table.$field IS NULL"; return $return; } else { return array(); } } ?> -- Ron Parker Software Creations http://www.scbbs.com Self-Administration Web Site http://saw.scbbs.com SDSS Subscription Mgmt Service http://sdss.scbbs.com Central Ave Dance Ensemble http://www.centralavedance.com R & B Salsa http://www.randbsalsa.com

1 0

Druplicon: Satiated
by Morbus Iff 23 Apr '08

23 Apr '08

<IslandUsurper> hey <Druplicon> hello <mozillamonks> botsnack <Druplicon> thanks, but no drink? I suppose I'll get by. <psynaptic> botsnack + drink <Druplicon> thanks psynaptic; can you pass the mayo? <psynaptic> mayo <mozillamonks> botsnack + drink + mayo <Druplicon> this is why I love #drupal <mozillamonks> lol <psynaptic> lol <MorbusIff> hahah

2 1

Unit testing
by Karoly Negyesi 23 Apr '08

23 Apr '08

Hi, Please do not reply to this mail, use the issue queue. I have written a unit testing framework. It is at http://drupal.org/node/249241 . While the parser is a bit harder to grok, it's not really relevant, it just does what it should... the runner itself is really small. I have added some documentation to http://drupal.org/node/30008 . Thanks, Karoly Negyesi

1 0

New advanced help module
by Earl Miles 22 Apr '08

22 Apr '08

In an effort to provide a framework to get decent documentation into Views 2, I determined that the built in Drupal help is simply not satisfactory for my needs. So I built this framework as a generic module that any module can utilize as an option to get expanded documentation about the administrative side of a module. Currently the module is in beta status -- it is almost certainly missing features, but it has what I want. I'll happily, however, let others who want to expand this to meet the needs of other modules. In my ideal world, this module will be improved, code-wise, until it is core worthy and the basic "how to use Drupal" documentation ends up shipped with Drupal. Perhaps this can happen as part of an upcoming Summer of Code project; in any case, I put this out there for people to use and see what we can do with it. Also, look at it this way: If Views uses it, you know that 50% of the modules out there for Drupal 6 will at least be exposed to it. Oh, the module is for Drupal 6 but can probably be backported to D5 with not a lot of effort. If someone wants to do that, great. I won't be doing it, though. =)

6 12

Test framework in core
by Dries Buytaert 20 Apr '08

20 Apr '08

Hello world, we just added a test framework to Drupal along with a first batch of tests for Drupal core! This is an important milestone for the project so enable the module and check it out ... :) Thanks to Rok Žlender, Károly Négyesi, Jimmy Berry, Kevin Bridges, Charlie Gordon, Douglas Hubler, Miglius Alaburda, Andy Kirkham, Dimitri13, Kieran Lal, Moshe Weitzman, and the many other people that helped with testing over the past years and that drove this home. It all works but it is still rough around the edges (i.e. documentation is still being written, the coding style is not 100% yet, a number of tests still fail) but we spent the entire weekend working on it in Paris and made a ton of progress. The best way to help and to get up to speed is to start writing and contributing some tests ... as well as fixing some of the failures. Kind regards, -- Dries Buytaert :: http://buytaert.net/

2 1

Privatemsg needs a better maintainer
by Karoly Negyesi 20 Apr '08

20 Apr '08

Hi, To cut a long story short, I am not a good maintainer. This module needs much more love than I can give it. For example, the 2.x branch should use subscriptions for its mailing needs but it has not kept up with the ground-up rewrite of subscriptions. Please help. Thanks, Karoly Negyesi

8 12