- Development - lists.drupal.org

Creating embedded unordered lists of checkboxes
by Steve Edwards 15 Jan '10

15 Jan '10

I have a need to create a two-level unordered list of checkboxes from a two level taxonomy vocabulary. So for instance, if my vocabulary is - Level 1 term 1 -- Level 2 term 1 -- Level 2 term 2 -- Level 2 term 3 - Level 1 term 2 -- Level 2 term 4 -- Level 2 term 5 - Level 1 term 3 I want to create the following: <ul> <li><input type = checkbox">Level 1 term 1</li> <ul> <li><input type = checkbox">.Level 2 term 1</li> <li><input type = checkbox">Level 2 term 2</li> <li><input type = checkbox">Level 2 term 3</li> </ul> <li><input type = checkbox">Level 1 term 2</li> <ul> <li><input type = checkbox">Level 2 term 4</li> <li><input type = checkbox">Level 2 term 5</li> <ul> <li><input type = checkbox">Level 1 term 3<li> </ul> What is the best way to do this? Just use a checkboxes element type and create my own theme function for the form? Modify something like theme_item_list? Or is there a better (and easier) way that I'm missing? What I tried doing was to create a theme function for my checkboxes element by setting the #theme property for the element to my custom theme function (and registering the function in hook_theme). I then just made a copy of theme_checkboxes() (and theme_form_element since it's called from theme_form_checkboxes) and renamed to match hook_theme and the #theme property. However, when doing that, none of my checkboxes are rendered at all. On stepping through the code, I found the problem in drupal_render starting at line 2868: if (!isset($elements['#children'])) { $children = element_children($elements); // Render all the children that use a theme function. if (isset($elements['#theme']) && empty($elements['#theme_used'])) { $elements['#theme_used'] = TRUE; $previous = array(); foreach (array('#value', '#type', '#prefix', '#suffix') as $key) { $previous[$key] = isset($elements[$key]) ? $elements[$key] : NULL; } // If we rendered a single element, then we will skip the renderer. if (empty($children)) { $elements['#printed'] = TRUE; } else { $elements['#value'] = ''; } $elements['#type'] = 'markup'; unset($elements['#prefix'], $elements['#suffix']); $content = theme($elements['#theme'], $elements); foreach (array('#value', '#type', '#prefix', '#suffix') as $key) { $elements[$key] = isset($previous[$key]) ? $previous[$key] : NULL; } } // Render each of the children using drupal_render and concatenate them. if (!isset($content) || $content === '') { foreach ($children as $key) { $content .= drupal_render($elements[$key]); } } } So basically, because I have #theme set for the checkboxes field, it skips the rendering of the individual checkbox elements. To me, it makes sense that I override the theme function for the checkboxes type since that's the element type, but that doesn't seem to be the case. So what do I need to do to be able to simply theme my checkboxes element? Thanks. Steve

3 6

So confused about arg(...)
by Nancy Wichmann 15 Jan '10

15 Jan '10

I'm working on a hook_preprocess_page and it seems to be behaving strangely. I have: drupal_set_message('stuff '. arg(0) . '/' . arg(1)); $variables['nancy'] = $hook . arg(0) . '/' . arg(1); In exactly that order, with no intervening lines. Displaying the variable in the page.tpl.php shows "page taxonomy/term" but the message shows "stuff r/ms" (even if I refresh the page, or clear the cache). How can this be happening? Nancy E. Wichmann, PMP Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr.

5 7

No reaction on security mails?
by Markus Kalkbrenner 14 Jan '10

14 Jan '10

Hi! We discovered a critical security issue in Drupal 6 Core and wrote a mail about it to security(a)drupal.org more than two weeks ago. (2009-12-27) The only reaction so far was an auto response mail from security-bounces(a)drupal.org the next day telling "All e-mails sent to us are read by a member of the team and acted upon if necessary." Now I'm not sure how to continue. Does it take more than two weeks to read through the mails and I just have to wait or is my message lost? Markus mkalkbrenner http://drupal.org/user/124705

4 4

cck filefield related question
by luca capra 14 Jan '10

14 Jan '10

Hi, probably I'm in the wrong place but I try to ask.. I'm using hook_form_alter to present a special form to anonymous users in D6. I got unlimited upload for a cck image field, but I would to limit to 1 for unauthenticated user. I've found this un-answered question in the cck issue queue: http://drupal.org/node/530828#comment-2288010 Should I maybe play with the submit hook? Thanks in advice, Luca

1 0

Creating a user and assigning a node in the node's submit callback.
by Brian Vuyk 13 Jan '10

13 Jan '10

Hi all. I've been trying to get a bit of code working, and I would appreciate a set of eyes. Basically, I have a content type ('profile') which has fields for user account details. If they are filled out, and a 'Create account' checkbox is checked, a user account is created with those details, and the profile node should be assigned to the newly-created user instead of the user creating the node. The issue is that, while the new user is created properly in the submit hook, the last line in the submit callback where I override the 'uid' value from the form values doesn't work - the node just saves with the user's uid instead of the uid of the new account that is specified on the last line. Does anyone have any idea how to make this work? Thank you in advance for anyone that can suggest a solution! Brian <?php function mymodule_form_profile_node_form_alter(&$form, &$form_state) { // Add our submit handler. We use array_unshift to prepend it, as we want it // to execute before the regular node form submit handler. array_unshift($form['buttons']['submit']['#submit'], 'mymodule_profile_form_submit'); } // Submit the user account creation fields in the profile_node_form. function mymodule_profile_form_submit($form, &$form_state) { // Create the user account. if ($form_state['values']['create']) { $account['name'] = $form_state['values']['username']; $account['mail'] = $form_state['values']['mail']; $account['pass'] = $form_state['values']['pass']; $account['status'] = 1; $account = user_save(array(), $account); // Now set the uid of the profile node to be owned by this new account. $form_state['values']['uid'] = $account->uid; } } ?>

5 9

Problem I am unable to locate
by Cory Gilliam 13 Jan '10

13 Jan '10

*Starting a new module and cant find the solution for this problem. I am trying to check the admin settings page for the module, and I am getting this error: Invalid argument supplied for foreach()* in * /home/dangerou/public_html/includes/menu.inc* on line *258*. Here is the code in the .module: function time_card_menu() { $items['admin/settings/time_card'] = array( 'title' => 'Time card settings', 'description' => 'Change how time card behave.', 'page callback' => 'drupal_get_form', 'page arguments' => array('time_card_admin_settings'), 'access arguments' => array('administer site configuration'), 'type' => MENU_NORMAL_ITEM, 'file' => 'time_card.admin.inc', ); return $items; } Here is the code in the .inc: function time_card_admin_settings() { $options = array('weekly' => 'Weekly'); $form['time_card_pay_periods'] = array( '#type' => 'checkboxes', '#title' => t('Your Pay Period is:'), '#options' => $options, '#default_value' => variable_get('time_card_pay_periods', array('weekly')), '#description' => t('This will tell the system how many weeks of information to collect for hour totals.'), ); return system_settings_form($form); } What is it that I am not seeing.

3 2

Private file upload
by Lee Rowlands 13 Jan '10

13 Jan '10

Hi All Can anyone suggest/recommend a module to handle users uploading files where only the uploading user can view/link to/access the file? Kind of like a private upload/file store system. The site will require public download method, except for these files. I've looked at IMCE but it doesn't appear to prevent hotlinking. I've looked at private_upload and private_download. I'm really looking for the private download/upload features of private_upload with the 'each user has a personal file collection' features of IMCE. I also like the idea of combining the token aspect of uploadpath to force files into a directory per user and then replicate the .htaccess based access permission checking of private_upload (forces redirect to replicate private download method). To complicate this further I need to allow anonymous users to upload files (temporarily of course) but each anonymous user cannot see the other. To retain the files, the user would need to register/sign in but not requiring this upfront show lower the barriers to using the site. Again I'm leaning towards forcing files into a folder per session id with access controls via .htaccess. To further complicate things, files will not be attached to a node - but it is fine if they are attached to a user. Any comments or advice would be greatly appreciated. Lee Rowlands

1 0

Re: [development] Problem I am unable to locate
by J. Sint Jago 13 Jan '10

13 Jan '10

Ah, Cory, sorry about the two mails. All rubbish :-) I was confused myself, better go to bed now. _____ Van: development-bounces(a)drupal.org [mailto:development-bounces@drupal.org] Namens Joop Sint Jago Verzonden: woensdag 13 januari 2010 9:18 Aan: development(a)drupal.org Onderwerp: Re: [development] Problem I am unable to locate Sorry, what i actually mean is that variable_get needs a variable on the second position: Maybe you intended: '#default_value' => variable_get('time_card_pay_periods', $weekly) Van: development-bounces(a)drupal.org [mailto:development-bounces@drupal.org] Namens Joop Sint Jago Verzonden: woensdag 13 januari 2010 6:57 Aan: development(a)drupal.org Onderwerp: Re: [development] Problem I am unable to locate '#default_value' => variable_get('time_card_pay_periods', array('weekly')), '#default_value' => variable_get('time_card_pay_periods', array['weekly']), Square brackets for your array? Van: development-bounces(a)drupal.org [mailto:development-bounces@drupal.org] Namens Cory Gilliam Verzonden: woensdag 13 januari 2010 6:07 Aan: development(a)drupal.org Onderwerp: [development] Problem I am unable to locate Starting a new module and cant find the solution for this problem. I am trying to check the admin settings page for the module, and I am getting this error: Invalid argument supplied for foreach() in /home/dangerou/public_html/includes/menu.inc on line 258. Here is the code in the .module: function time_card_menu() { $items['admin/settings/time_card'] = array( 'title' => 'Time card settings', 'description' => 'Change how time card behave.', 'page callback' => 'drupal_get_form', 'page arguments' => array('time_card_admin_settings'), 'access arguments' => array('administer site configuration'), 'type' => MENU_NORMAL_ITEM, 'file' => 'time_card.admin.inc', ); return $items; } Here is the code in the .inc: function time_card_admin_settings() { $options = array('weekly' => 'Weekly'); $form['time_card_pay_periods'] = array( '#type' => 'checkboxes', '#title' => t('Your Pay Period is:'), '#options' => $options, '#default_value' => variable_get('time_card_pay_periods', array('weekly')), '#description' => t('This will tell the system how many weeks of information to collect for hour totals.'), ); return system_settings_form($form); } What is it that I am not seeing.

3 3

Re: [development] Problem I am unable to locate
by Joop Sint Jago 13 Jan '10

13 Jan '10

Sorry, what i actually mean is that variable_get needs a variable on the second position: Maybe you intended: '#default_value' => variable_get('time_card_pay_periods', $weekly) Van: development-bounces(a)drupal.org [mailto:development-bounces@drupal.org] Namens Joop Sint Jago Verzonden: woensdag 13 januari 2010 6:57 Aan: development(a)drupal.org Onderwerp: Re: [development] Problem I am unable to locate '#default_value' => variable_get('time_card_pay_periods', array('weekly')), '#default_value' => variable_get('time_card_pay_periods', array['weekly']), Square brackets for your array? Van: development-bounces(a)drupal.org [mailto:development-bounces@drupal.org] Namens Cory Gilliam Verzonden: woensdag 13 januari 2010 6:07 Aan: development(a)drupal.org Onderwerp: [development] Problem I am unable to locate Starting a new module and cant find the solution for this problem. I am trying to check the admin settings page for the module, and I am getting this error: Invalid argument supplied for foreach() in /home/dangerou/public_html/includes/menu.inc on line 258. Here is the code in the .module: function time_card_menu() { $items['admin/settings/time_card'] = array( 'title' => 'Time card settings', 'description' => 'Change how time card behave.', 'page callback' => 'drupal_get_form', 'page arguments' => array('time_card_admin_settings'), 'access arguments' => array('administer site configuration'), 'type' => MENU_NORMAL_ITEM, 'file' => 'time_card.admin.inc', ); return $items; } Here is the code in the .inc: function time_card_admin_settings() { $options = array('weekly' => 'Weekly'); $form['time_card_pay_periods'] = array( '#type' => 'checkboxes', '#title' => t('Your Pay Period is:'), '#options' => $options, '#default_value' => variable_get('time_card_pay_periods', array('weekly')), '#description' => t('This will tell the system how many weeks of information to collect for hour totals.'), ); return system_settings_form($form); } What is it that I am not seeing.

1 0

cache flexibility improvement
by Ivan Sergio Borgonovo 13 Jan '10

13 Jan '10

Hi, I saw a chance to improve the flexibility of D7 cache, with something that looks as a very small change. I'm sorry if I'm missing something, but I'd really appreciate if someone will point out what's wrong with my proposal. Substantially D7 doesn't serve cached pages if $_SESSION isn't empty as stated in drupal_page_get_cache docs (I couldn't find anymore where $_SESSION is tested...). This limit the use of cache substantially. Nearly all users will have a not empty $_SESSION that will force regeneration of ALL the pages. Currently core put in SESSION: 1) openid 2) user_overview_filter 3) dblog_overview_filter 4) node_overview_filter 5) clean_url 6) authorize_filetransfer_backends 7) authorize_operation 8) ignore_slave_server 9) update_manager_update_projects 10) authorize_results 11) update_results 12) messages 13) locale_translation_filter 14) maintenance_mode 15) update_success 16) updates_remaining 17) maintenance_mode 18) batch_form_state 19) my_batch_results 20) batches Most of them shouldn't actually forbid the use of ALL cached pages. One way to retro-fit a more fine grained control over cache would be to add a field to all the SESSION items in the array eg. $_SESSION['session_var'] = $stuff; $_SESSION['session_var']['cacheable'] = true; And in spite of invalidating all cached pages we could check if there is any ['cacheable'] that is null/unset preserving current behaviour and giving a chance to exploit more the cache. Then we could add the ['cacheable'] flag where it is safe a bit at a time. If bootstrap_invoke_all('boot') in function _drupal_bootstrap_page_cache() could be anticipated we could even give a chance to modules that would like to control if the cache has to be used to fire. eg. don't serve cached pages for user coming from this IP, don't serve cached pages during these hours, always serve cached pages to these IP etc... -- Ivan Sergio Borgonovo http://www.webthatworks.it

2 1