- Development - lists.drupal.org

Beta release CVS tagging
by Syscrusher 13 Nov '08

13 Nov '08

Hmmmm....I *thought* I had RTFM and was following the instructions, but CVS thinks otherwise. I have, in CVS HEAD, a module that has been committed with current changes. I want to make an official release for Drupal 6.x compatibility, first release of this module for that core API level, and a "beta" level of stability. According to http://drupal.org/node/94155 and http://drupal.org/handbook/cvs/branches-and-tags/contributions I thought I needed to do this: $ cvs tag DRUPAL-6--1-0-BETA However, this returns the following error: cvs tag: Pre-tag check failed ** See http://drupal.org/node/93999 for the format of valid release tags.** ERROR: invalid tag for this directory: Can someone tell me what I'm doing wrong here? It's been a long time since I needed to do an actual release, and I think things may have changed since the last time I did one of these. Thanks. Kind regards, Scott -- Syscrusher <syscrusher(a)4th.com>

2 2

automated patch testing comes to drupal.org
by Chad Phillips -- Apartment Lines 12 Nov '08

12 Nov '08

the automated patch testing framework has been enabled, and is currently working through the backlog of 7.x patches for the Drupal project on drupal.org to avoid any surprises or frustrations that this new workflow brings to the development cycle, i encourage everyone to read http://drupal.org/node/332678 for issues related to the framework itself use the appropriate project issue queues. for issues related to the sending and receiving of patches, display, auto status changes, etc: http://drupal.org/project/issues/project_issue_file_test for issues related to the automated testing itself: http://drupal.org/project/issues/project_issue_file_review

5 4

Reviewing patches and making decisions
by Anselm 10 Nov '08

10 Nov '08

Hello, Having followed this thread for a while, I decided to do my bit, and start reviewing patches. I didn't get very far ; I stopped at the first patch. Not because of the code - I could understand what the original code did, and what the patched code did - but because there are two decisions to be made : 1. In that case - and I guess this is not uncomon - the old behaviour might be a bug, but it might have been by design. I have no way of telling. 2. Changing the old behaviour to the new one could break old modules that implicitely relied on the old behaviour. Again, this is probably not uncomon. How do I weight the importance of the patch vs stability of old modules ? So what do I do next ? I don't have a sufficient overview of that part of Drupal to make such decisions myself. Should I mark it as reviewed, and add as a note what the potential implications are ? Or is there another process to follow in such situations ? Best, Anselm

13 26

Display Search Results as they are Located
by Ron Parker 10 Nov '08

10 Nov '08

I have a custom search. Right now, the search results page is displayed after the search is completed. Is there a way to display the search results as they are located? For example, in the hook_search api http://api.drupal.org/api/function/hook_search/5 , this is how the results are located in a generic custom search: <?php case 'search' : $find = do_search ( $keys , 'node' , 'INNER JOIN {node} n ON n.nid = i.sid ' . node_access_join_sql () . ' INNER JOIN {users} u ON n.uid = u.uid' , 'n.status = 1 AND ' . node_access_where_sql ()); $results = array(); foreach ( $find as $item ) { $node = node_load (array( 'nid' => $item )); $extra = node_invoke_nodeapi ( $node , 'search result' ); $results [] = array( 'link' => url ( 'node/' . $item ), 'type' => node_invoke ( $node , 'node_name' ), 'title' => $node -> title , 'user' => theme ( 'username' , $node ), 'date' => $node -> changed , 'extra' => $extra , 'snippet' => search_excerpt ( $keys , check_output ( $node -> body , $node -> format ))); } return $results ; ?> What I am asking: Is there a way to print each $result[] item as it is located rather than returning the $results array to print the page after the search is completed? My problem is that my custom search uses a 3rd party search, then I have to parse the those results using a query to a Drupal table. Then, I populate the $results array. This is taking a very long time, but I don't see a lot of ways round it. What would give the impression of it not taking so long would be if the search results started popping up immediately. Thanks for any suggestions. -ron

1 0

Outstanding issues with .htaccess, settings.php or robots.txt on Drupal 6?
by Gábor Hojtsy 10 Nov '08

10 Nov '08

Hi, With each Drupal 6 release, we made it a best practice to include a note in the related SA that "the settings.php, robots.txt and .htaccess files have not changed and can be left as they are if upgrading from the current version of Drupal". As part of my usual Drupal 6 branch maintenance, I've worked down the RTBC queue for Drupal 6 to two issues: - http://drupal.org/node/28776 - Protect svn files in .htaccess (which also protects .test files on the Drupal 6 patch) - http://drupal.org/node/299582 - Update robots.txt to remove obsolete items and order existing ones in alphabetical order If we do change any of the three files, I think it is better to do them all at once and then try to stay away from touching them for another lengthy period to help people apply changes to these three files which are most likely patched on a considerable number of Drupal installs. Therefore I am asking if you have any issues with these existing two patches to sound your concerns before they are committed (avoid the next Drupal version to come with changes to these files). Also, if you have other issues against these files, which you think should be resolved sooner then later, it is the time to put them into the spotlight. Gábor

4 4

jQuery Gradient Plugin
by Gordon Heydon 10 Nov '08

10 Nov '08

Hi, I was wondering if anyone has used this plugin http://plugins.jquery.com/project/gradient as part of the theming on their site. I have been trying to get it going but it is breaking all the Drupal js and other things. I was wondering if any has any ideas. Gordon.

1 0

d.o schedule maintenance, time correction
by Chad Phillips -- Apartment Lines 07 Nov '08

07 Nov '08

apologies, folks, the maintenance window for drupal.org is sat, nov. 8th at 2am, not today the 7th as i had originally posted. i've corrected the announcement on the front page of d.o. sorry for the misunderstanding. i hate timezones. chad

1 0

opt-in performance benchmarking on d.o.
by justin randell 07 Nov '08

07 Nov '08

hi all, i've been watching the inspiring work to integrate testing patches against HEAD at testing.drupal.org, and wondering if it would be useful/possible/desirable to have benchmarking integrated into d.o. as well? like the testing stuff, but maybe opt-in? i'd be willing to do some dev/sysadmin work, and i'd hope there would be enough dev resources, but we'd need some hardware dedicated to it. thoughts? suggestions? flames? cheers justin

2 1

Change menu structure at runtime
by Fernando Silva 06 Nov '08

06 Nov '08

Hi, I want to do a "strange" thing with the (Drupal 6) menu system. After defining a menu structure, let's assume that it is a "primary navigation", when viewing a node page I want that page to be under a specific menu item in the menu "primary links". See this: - primary navigation -- menu 1 -- menu 2 -- menu 3 ---- node/80 (this will be changed at runtime) That "node/80" path will be the child of a menu item, according to some conditionals that I have in hook_nodeapi. So the question is: can I alter the menu structure at runtime, while not changing database or persisting those changes? Or perhaps there is another solution... Thanks, Fernando

2 1

How to post bug reports and patches
by Markus Kalkbrenner 06 Nov '08

06 Nov '08

Hi, This is my first post to this list so I will introduce myself first. My name is Markus Kalkbrenner. I'm developing software for more than 15 years and participating in open source projects since 7 years. Two years ago I started working with drupal and posted my first bug reports and patches. Currently I'm asking myself which is the right strategy to contribute patches and get them committed to CVS because most of the time I'm still working with drupal 5 and find bugs there. Just some examples: Posted 4 month ago for drupal 5.7: http://drupal.org/node/229411 node_view() incompatible to php5 I was asked to add more comments to my patch and drumm found out that the same bug still exists in drupal 6. So I added the comments but nothing happend. Neither in D5 nor in D6. Posted 3 month ago for drupal 5.8 http://drupal.org/node/287063 node_delete memory leak and wrong order of commands In a different bug I was told to post the bugs for drupal 6 to get them handled faster and finally backported to drupal 5. So I switched the version for this issue to D6 and added an additional patch for it. But no reaction. Posted 3 month ago for drupal 6.dev http://drupal.org/node/298768 Ensure that entries are written to watchdog table and http://drupal.org/node/298678 Impossible to lock two MySQL tables From my point of view these are two serious issues which are the reason for several other bug reports. I found them in drupal 5 but discovered that they still exist in D6 and D7. So I decided to post them for D6 because this is the current stable version. Unfortunately I didn't see any reaction so far. Please don't get me wrong. I really like drupal and will keep on contributing patches because I want to improve it. But maybe I'm doing something wrong or you just have no time to maintain the stable versions. So for me the current situation is like a "bad user experience". Markus

31 69