- Development - lists.drupal.org

Backport/Performance patch repository?
by Jim Li 05 Jun '07

05 Jun '07

Hello, first off I apologize if this is inappropriate for this list. I just leaned that custom logging (by Kahlid) and JS aggregation (by M3avrck) has been backported to 5.x. So I was thinking does it make sense to have a central repository for all these fine backport/performance patches, which may never land in the official 5.x release? (Or does it already exist?) Another high profile patch I am aware of is the tracker query patch (by David Strauss). There gotta be more, including some of the locally applied to d.o. ones that never got released. All these patches (at least the above 3 I mentioned) would be great to have on my existing 5.x sites. But they are buried deep in the issue queue or comment thread, thus easy to miss. My guess is most ppl aren't even aware of them unless they follow issue queue and dev list closely. Can we somehow organize them in a central place, Group, Document page or even a Project? Does it make sense and worth the efforts? Any comments? Thanks.

7 10

comments as nodes
by Robert Douglass 05 Jun '07

05 Jun '07

Since it came up, I'll draw everyone's attention to the nodecomment module which makes comments into nodes. Rather, it uses one node type to be the comment type of another node type. To me (and the other Lullabots) this makes a lot of sense. All that is needed is a 1:n mapping between a parent and its children and some special display. What makes the nodecomment module really special, however, is that the rendering of the "comments" is handed off to the views module (which is a requirement), so you could display your comments in totally non-traditional ways, such as in a table or in a calendar. One of the most useful applications that this module has found is also the impetus for its creation: voting widgets in the comments that vote on the parent node. I'm creating a site, for example, where the comments are all ratings of the parent node, and each comment needs to have four separate fivestar widgets. To do this, the comment node type has four CCK fields from the fivestar module where the target of the voting is set as arg(1)... meaning the fields belong to the comment nodes but the votes belong to the parent node. Very cool. We've had clients who have requests like wanting to promote comments to the front page, or rate comments, or categorize comments etc. This module fills those needs. The release says it is beta, and I stick by that, but it is worth noting that this beta code probably serves 5 million page views a day or more on live (rockstar) websites. -Robert http://drupal.org/project/nodecomment

10 15

Default to InnoDB
by David Strauss 05 Jun '07

05 Jun '07

Many discount web hosts (like Dreamhost) support InnoDB but don't configure it as a default. What do people think about using InnoDB as the default, or at least an option during installation? The only way I know to install Drupal with InnoDB is by modifying my.cnf, which requires root access.

6 7

Tips on keeping up?
by Tao Starbow 05 Jun '07

05 Jun '07

Hi List, I could use some advice on keeping up with development, and where I should be spending my time. Just today, I followed at link from the front page to an issue that I had not seen before, and in the comments found out that Dries was interested in having my find_paths module modified and included into core. I would have been thrilled to do it, but unfortunately, the comment was from a month ago, and someone else has already stepped up and done most of the work. I keep up with the dev list, and planet drupal, a couple of groups over at g.d.o, my own projects issue queue, and email about the user group I run, and that pretty much consumes all of the time I have to stay up-to-date. And I still missed a key opportunity to contribute. Do folks have advice? Should I give up the dev list and focus on the issues queues (and which ones)? Should I stop reading Planet Drupal and spend an hour a day over at #drupal? Or should I just chill and assume that if someone wants my help they will contact me directly? thanks, -tao

10 10

menu status
by Karoly Negyesi 05 Jun '07

05 Jun '07

Hi, The whole of menu subsystem is supposed to be fully functional now. Known issues: * update. Please test http://drupal.org/node/147657 * default tabs. Please help with adding comments to http://drupal.org/node/115847 Otherwise, please file issues -- patches preferred :) -- if something is not working as it should. Regards, NK

4 3

Re: [development] comments as nodes
by Michelle Cox 05 Jun '07

05 Jun '07

Based on Boris' recommendation, I installed it on my dev site and checked it out. It seems like a good module but I didn't find the user interface to be as intuitive as userreview's and userreview also has an easy way for me to put the reviews right where I want them. So I'm going to stick with it. Now I'm going to stop being so offtopic. If anyone wants to discuss the review + vote options further, feel free to email me or catch me on IRC. :) Michelle On 6/4/2007 3:37:28 PM, Larry Garfield (larry(a)garfieldtech.com) wrote: > Boris, stop making me blush. :-) > > The site that nodereview was originally developed for needed multi-axis > ratings, but > there's certainly nothing stopping you from only having one axis > configured. Of course, said site never actually launched so I haven't > been giving that module more than bug-fix attention lately. Patches > welcome, but lately I > haven't really had time to do much with feature requests that don't > include code. Apparently several sites are using it, though. If someone > does have an interest in it, I would welcome a co-maintainer. > > --Larry Garfield

1 0

Re: [development] comments as nodes
by Michelle Cox 04 Jun '07

04 Jun '07

I looked at nodereview as well before going with userreview but I didn't want all those different types of voting on there. Just wanted something simple with 1 rating per comment. If you think it's better than userreview, I'll give it another look. I don't have any reviews in the system, yet, because my site is still being built, so now's the time to switch if I'm going to. :) Thanks, Michelle On 6/4/2007 12:24:11 PM, Boris Mann (boris(a)bryght.com) wrote: > On 6/4/07, Michelle Cox <mcox(a)charter.net> wrote: > > This is very interesting. > I'm currently using the userreview module instead > > of fivestar, even though I'd > prefer a star rating, because it lets you > > comment and rate at the same time. > I'm interested in trying your approach, > > but I'm concerned about totally > replacing the comment module. Have you run > > into any problems with things that use comments such as forums? > Especially > > when using flatforum? > > Actually, check out Node Review (http://drupal.org/project/nodereview) > -- it is built along the same lines as what Robert has described, but > specifically for ratings / reviews. If you don't want to replace ALL > comments....us that one. Yes, userreview and nodereview should > probably be merged. I trust nodereview because Larry wrote it.... > > -- > Boris Mann > Office 604-682-2889 > Skype borismann > http://www.bryght.com

2 1

Re: [development] comments as nodes
by Michelle Cox 04 Jun '07

04 Jun '07

On 6/4/2007 12:22:27 PM, Robert Douglass (rob(a)robshouse.net) wrote: > There is a currently unreleased forum replacement module (only does flat > forum style, no threaded comments supported) which can handle the forum > needs. Bug merlinofchaos, mfredrickson, or eaton to get that released! Yeah, and which one isn't busy with freeze coming up? ;) If it doesn't work well with forums as is, then I think I'll have to pass for this site. I'll keep it in mind for the future, though. Thanks, Michelle

1 0

Re: [development] Accessing CCK field data (single, multiple, or shared) from another module
by Karen Stevenson 04 Jun '07

04 Jun '07

To find the right table for a field for a SQL query, use the API, like this: $db_info = content_database_info($field); $table = $db_info['table']; That will always return the right table for the requested field. $field needs to be the complete field array, not just the field name, so if you only have the field name, you would do: $field = content_fields(my_field_name); $db_info = content_database_info($field); $table = $db_info['table']; content_database_info($field) also contains info about the columns declared by the field so you know what field names to use in a SQL query. It returns an array that looks like: Array ( [table] => content_type_story [columns] => Array ( [value] => Array ( [type] => varchar [length] => 50 [not null] => 1 [default] => '' [sortable] => 1 [column] => field_phone_value ) [value2] => Array ( [type] => int [length] => 10 [unsigned] => 1 [not null] => 1 [default] => 0 [column] => field_phone_type ) ) ) ----- Original Message ---- From: Rob Barreca <rob(a)electronicinsight.com> To: development(a)drupal.org Sent: Thursday, March 22, 2007 7:55:31 PM Subject: Re: [development] Accessing CCK field data (single, multiple, or shared) from another module > > Is there a function for getting the data that you can just give a node > type and a field name and it handles the rest? This is something I've just run into as well. I have a hardcoded to query the DB for the multiple field table, but have a TODO in there to find the right API call. Rob Roy Barreca Founder and COO Electronic Insight Corporation http://www.electronicinsight.com rob(a)electronicinsight.com Benjamin Melançon wrote: > Gracious developers, CCK people especially... > > I wrote an access control module that works with the node relativity > module to cascade permissions to all nodes lower in a hierarchy. I > hard-coded a query for a userreference field on a custom content type > as one way to give a user access to a node (and its descendants). > > In generalizing this, the current stumbling block is the way CCK > stores single instances in the content data table and shared instances > of a field in a separate table. > > Is there a function for getting the data that you can just give a node > type and a field name and it handles the rest? > > Or is there a place to check what the case is for a particular field? > (Even a "column_exists()" function would do it for me, but haven't > found one in PHP...) > > It's being developed in Drupal 5 and fixing this (as well as saving > explicitly permitted users when creating a new node) is all that's > needed for posting the project for general use. > > Many thanks, > > ben > > Agaric Design Collective > Open Source Web Development > http://AgaricDesign.com/ > > People Who Give a Damn > building the infrastructure of a network for everyone > http://pwgd.org/

5 4

patches that need reviews/work
by Ashraf Amayreh 04 Jun '07

04 Jun '07

Thanks to Dries' wise decision, we can now really put some extra efforts to make this a perfect release, there are patches that need reviews, others that need some work to minimize their performance impact, and others that are RTBC but are still not. To ease this and make it more effective, everyone who has a patch that needs reviews, some work or is RTBC but is still not, please post it in this thread to get it under lights. Please don't post another developer's patches unless you're in sync with him so that this won't get filled with repetitive posts. A short description of each patch and what it does should be helpful as long as it's no longer than a paragraph, this is a second reason the patch author is in a better position to post here rather than someone else, interested parties can see the details in the issue page. By doing this, we can centralize all our efforts on the patches in this thread. Finally, let's avoid giving opinions on these patches over here to streamline this thread and attempt to make it as direct as possible. The issue page can be used for that. My patch is a simple one that Moshe has agreed is RTBC, so I hope we can get it in and turn to other important patches. http://drupal.org/node/114938

3 3