- Development - lists.drupal.org

Fwd: [drupal:dries] /modules/comment comment.module
by Stefan Nagtegaal 12 Oct '06

12 Oct '06

Begin doorgestuurd bericht: > Van: drupal-cvs(a)drupal.org > Datum: 11 oktober 2006 15:17:24 GMT+02:00 > Aan: drupal-cvs(a)drupal.org > Onderwerp: [drupal:dries] /modules/comment comment.module > Antwoord aan: development(a)drupal.org > > User: dries Branch: HEAD Date: Wed, 11 Oct 2006 13:17:24 +0000 > > Modified files: > /modules/comment comment.module > > Log message: > - Patch #87995 by merlinofchaos: cleaned up CSS and simplified > the code. > > Links: > http://cvs.drupal.org/diff.php?path=drupal/modules/comment/ > comment.module&old=1.489&new=1.490 > > -- > [ Drupal cvs list | http://list.drupal.org/ ] Shouldn't this commit also add the following css to comment.css? .indented { margin-left: 1.5em; }

1 0

LDAP Addressbook: Taking over
by DMX 12 Oct '06

12 Oct '06

Hi all, I thought about making a LDAP addressbook module and I created a project, afterward I found a project with the same name but it's very outdated. I contacted the main developer who redirected me to another but still none of them is willing to continue, as far as I see. So I wanna take over that project and continue from their code base. I hope you can help me. Thanks, Omar

1 0

Re: [development] Drupal 5.x Installation is Bad!
by Michelle Cox 12 Oct '06

12 Oct '06

On 10/11/2006 7:59:59 PM, Drupal Indonesia (support(a)drupal-id.com) wrote: > The solution is very simple, but we must agree first that the new > installation > should be as easy as possible while the security concern still the best :) >Here: >1. On the installation screen say: "You must enter a db username with >creating >DB rights, otherwise please create the DB first" >2. Step #2: Drupal installation checks if the DB is exists, if not then >create >the DB. >Simple, right? >This is not new techno, I see many CMSs have feature to create DB. I suppose, but I wonder if it's worth it. From my admittedly limited experience, people on shared hosting wouldn't be able to use it because of the need to create databases through cPanel or equivalent. People not on shared hosting probably know enough to not need Drupal to make the DB. So who'd use it? Would be a good survey question, I guess. Michelle

2 1

Remote usability sprint October 27th-29th
by Kieran Lal 12 Oct '06

12 Oct '06

Hello, the third remote usability sprint is upon on us and I am going to be leading an effort to conduct user experience testing of Drupal 5.0 with remote users around the world. The event will take place at Google headquarters in Mountain View. http://www.flossusability.org/ The goal is to teach developers how to conduct remote user experience testing and get good user experience feedback for Drupal 5.0 and beyond. In particular, we will use the 1700+ results of the Drupal administration survey to help create new designs for focus areas identified by the survey. 1) I am looking for core developers to participate remotely. e.g. I'll watch Drupal administrators use Drupal and make notes, mock-up suggested improvements, and file issues. 2) I am looking for volunteers to set up remote user experience testing stations. e.g. I'll set up remote streaming video and skype casts on a computer so that Drupal developers can do direct observation of Drupal administrators while I supervise. 3) I am looking for volunteers to review videos of Drupal administrators using Drupal and file issues, produce mock-ups, and make notes. Cheers, Kieran CivicSpace

1 0

CCK field generation confusion (and how to solve)
by Bèr Kessels 11 Oct '06

11 Oct '06

Hi, I have been fighting CCK fields for the last two days again. My general conclusion already was that it is a little too hard to grok, so let us get that solved. Why? Because it is too hard to grok. Looking closer at the field that are there, you will notice that the developers were: a) inconsistent. Very inconsistent. Every module with fields is completely different. b) using fields where they should have used widgets. And using widgets where they should have used fields. c) seem to be overly confused about the 'multiple' thing. How? Documentation. This is a catch22, because how much I would love to make docs, I am too unfamiliar with CCK to write docs. Even some sketchy notes by/from the original designers (why multiple, what was the idea behind fields vs widgets) can help. Are they anywhere? And more technical: Documentation can help us solve some of the issues. But even with docs and examples, this material is very hard to grok. The workflow is like spaghetti, the hooks, using call-by-refs trace back up-to 5(!) hook calls deep! (meaning: hook_foo calls hook_bar, which calls hook_baz etc, 5 of them is the most I counted). Call by reference: Either all of the stuff should be call by ref in all hooks at all points. Or none. Not have $node as called by ref in some $ops (load) but not in others (insert). Hooks vs FAPI. Because the general Drupal-way seems to be towards _altering of FAPI forms, instead of the 'old' hook mechanism, CCK uses many hooks. To alter forms. But not everywhere. These CCK hooks are well documented already, but when it mixes with form alters, you get a messy spaghetti-bowl again. I'd say: either _alters all over the place, or hooks, but never both. Hence I suggest to drop the hook_*() $op == 'form' in favour of form_alters all trough CCK. Fields widgets and the rest. This is confusing. When I read peoples fields-modules my general idea is that no-one really groks this. Eventhough I understand the database architecture behind it , I still think that a) the names are confusing. b) the associated hook ops are badly named. Hence I suggest to take the widgets out of CCK entirely, and stick them in a widget_library.module. CCK-field modules can pick widgets from that library. If they need additional widgets, then they can add them to the library. This way we can do away with the current 'widgets and fields' confusion. And we can enforce people to think slightly better about their fields vs their widgets. Right now, nearly all of the modules with CCK fields have widgets-who-validate-field-data, or fields-whom-dictate-widgets. An additional benefit is that any module can easily re-use fancy widgets without needing the whole of CCK. Another benefit, is that the amount of code that needs to be changed can be minimised. A big downside is the dependency of CCK on the widget_library.module. Who? There are a lot of users, but very few developers for CCK. The main reason, IMO is the very steep learning curve of CCK development. (see above) But I think that enough people are willing to contribute if CCK were a little more accessible. If we can agree on the abovementioned ideas, or provide better ones, then I hope we can get this started with some patches and issues right away. Bèr -- [ Bèr Kessels | Drupal services www.webschuur.com ]

4 9

Proper method for including external libraries
by Joseph Bratton 11 Oct '06

11 Oct '06

Quick question, what is the "proper" method for including external libraries within a drupal module? Should I place a require_once at the top of the module, or just at the beginning of any functions within the module that use that library? Once at the top of the module is cleaner, but it also means that it is loaded on every page, whether it is actually used or not. Thanks, Joey

3 2

jQuery Rounded Corners plugin...
by Morbus Iff 11 Oct '06

11 Oct '06

http://paul.jquery.com/plugins/nifty/ http://paul.jquery.com/plugins/nifty/example.html From the jQuery mailing list: ------- paul.bakaus(a)googlemail.com I noticed there was an update on the famous nifty2, which does rounded corners on elements without the use of graphics. When I saw the parsing capabilites, I thought "Why not use jQuery for that". So I went ahead and used 3 hours of my time to modify and optimize the plugin as a jQuery plugin. You can check it out here: The code can probably still be optimized alot, but I don't have the time. If someone wants to help, go on and grap the js :) ------- -- Morbus Iff ( united we're bland ) Technical: http://www.oreillynet.com/pub/au/779 Culture: http://www.disobey.com/ and http://www.gamegrene.com/ icq: 2927491 / aim: akaMorbus / yahoo: morbus_iff / jabber.org: morbus

2 1

Re: [development] Why Drupal 5.x must have built-in WYSIWYG Editor?
by Michelle Cox 11 Oct '06

11 Oct '06

On 10/6/2006 3:44:01 AM, Drupal Indonesia (support(a)drupal-id.com) wrote: > 2. A best solution, IMHO, is provide a function in Drupal to call the > Editor. > This Editor() function simply call the ediitor if available, but if no >editor installed > then Editor() uses <textarea>. While I don't agree that Drupal needs a WYSIWYG built in, I do like this idea. If I'm understanding right, it's basically a hook to call whatever editor the user has installed or a plain text area if none. From my non-dev perspective, that sounds like a useful thing. Would be especially nice if there was a way to make it so that, for example, my users get BBCode and I get QuickTags. And that they only show up when editing the main text of a node. Michelle

5 5

Re: [development] 2k qps
by Tamir Khason 11 Oct '06

11 Oct '06

Yes, sure it is a one of things to consider - MaxClients. But it's not an issue when it comes to server hang. It doesn't have time to start swap but just hangs. It worked like this with 100-256 clients configured. Each process takes around 10-13MB. It cannot be decreased since lot of modules are loaded. Actually we can turn off log module and info module and may be more here and there...but overall this doesn't help. The hang happens immediately and not slowly with the time. We have simple monitor for load average coming to 5 and then sending mail. The problem is that load average goes to 100 within a minute and nothing can alert or work. Sometimes it reaches 500. Average process amount is around 70-80 until the problem comes to visit us...So adjusting MaxClients won't help a lot here. KeepAlive is 15 sec and it's fair. I can reduce it to 3-5 secs..not sure it might help. Once again, when problem starts all processes are engaged and system hangs..so keepalive won't help. May be Timeout..but we cannot decrease its settings otherwise it will cut on image upload. If I am not mistakening thttpd is discontinued project. In our case I wanted use TUX but it cannot serve htaccess file. So I am planning run 2 apache. 1 in worker mode and server static content and behind it prefork mode serving dynamic content only. We tried to move everything to httpd.conf but seems those Drupal guys want .htaccess to exist so we have no choice and using it and I do know that apache makes an extra look for .htaccess in each dir it accesses. Shortly: we cannot turn AllowOverride to None. Query_cache for some tables could be an interesting thing. We will surely investigate this one and try. Also we will look into that alias thingy you've been talking about. More than that, we even don't succeed to enter server-status in apache to see what goes on...everything goes too fast and something kills the server within the seconds.. Thanks so far > From: Amr Mostafa <amr.mostafa(a)gmail.com> > Date: Wed, 11 Oct 2006 10:27:54 +0200 > Subject: Re: [development] 2k qps > To: development(a)drupal.org > > > Check if the number of Apache processes is too high (e.g. 256 which > > may not fit in your RAM without swapping), and lower it if necessary. > > Regarding this, what I do is watch the process table, see the average > memory footprint for each apache process, let's say it's 6 mb. You > have 1000 mb, leave some RAM for mysql and other services, so > remaining is 600 mb (just an example). 600/6 = 100. And that's the Max > apache processes I will be allowing. Because more than that it means > my apache will swap. > > If your theme has lots of images, consider tweaking your Keep-Alive > (http://httpd.apache.org/docs/1.3/keepalive.html) and cache > (http://www.mnot.net/cache_docs/) it will help save unnecessary > apache processes. Also, consider serving your non php files under > thttpd (http://www.acme.com/software/thttpd/) or another light web > server. > > Consider moving your rewriting rules to to conf files instead of > .htaccess, due to way rewriting works, it internally resets part of > the request processing cycle when invoked too late (e..g via > .htaccess) while having it in conf files enables it to take action > early enough. > > Consider removing your .htaccess completely, move the configuration to > .conf files, and disable .htaccess in apache conf. This will save you > a few system calls. > > If your site is a community one that gets updated a lot, consider > turning off query cache for some tables. Because in that case, cache > becomes invalid in very short intervals and maintaining cache becomes > overhead. > > No one sugguested a Drupal performance tip. I will kick the ball off, > it's a bit nuts, might break things but this is the devel list right ? > I find many sites not using Drupal's aliases feature. If you are one > of those, consider turning off aliases lookup. I do this quickly by > adding return FALSE in first line in > (http://api.drupal.org/api/4.7/function/drupal_lookup_path) This will > save you some queries. > > Of course you will want to benchmark all that and see what works best > for you. >

1 0

2k qps
by Tamir Khason 11 Oct '06

11 Oct '06

Please share, if 2k qps for loaded drupal for 3k concurrent users is OK. My server (2x2G Xeon 1G Ram) goes mad of such load and once a day just hanged within second (even did not write err_log). What can it be? Might it be core problem?

7 8