- Development - lists.drupal.org

RE: [development] Data API
by Metzler, David 13 Sep '06

13 Sep '06

I would humbly disagree that themes would be considered the view level, or that forms represent the model level in MVC. I think originally you could argue that the node api represented the model level, and that moving crud into the forms api represents a blurring of MVC and not a step towards that. That is the primary debate that's being waged here, whether we need separation of data manipulation from the controller. I personally would like to avoid creating a ddl in drupal. One of the things that make's drupal work is how agile the loosely coupled, loosely typed system is. The $forms arrays are collection of controls. I'd love to see them stay that way. right now forms posting and validation are accessed via simple array constructs. I'd like to see them stay that way. I agree that form_validate, form_submit, node_save, and node_delete functions (when used in crud) are really model work, especially the way they are used in 4.7. I think a lot of whats bothering some is that they're getting dependent on the forms api, and that dependency may cause inflexibility down the road. I agree that defining fieldsets, checkboxes, etc. have no place in the model portion of mvc. And having to set up those contructs provide extra cruft for programatic manipulation of data. (that's the forms dependency part creaping it's head). -----Original Message----- From: development-bounces(a)drupal.org [mailto:development-bounces@drupal.org] On Behalf Of Mark Fredrickson Sent: Friday, September 01, 2006 7:33 AM To: development(a)drupal.org Subject: [development] Data API After the previous round of talks on the form api, I have a proposal for future Drupal development: let us rename the form API to the data API and start to look at it as the central method of implementing a full MVC in Drupal. First, some observations: HTML forms are simply a method of getting data from users, nodes are collections of defined data, nodes are increasingly represented as "forms" - however, coupling our data to an XHTML representation blurs the line between model and view. The general benefits and costs of an MVC design pattern are outside the scope of this email, but feel free to criticize my position if you don't like MVCs. I will say, MVC isn't the only design pattern, but it's a good one if you don't have a reason to choose something else. Let me map the model, view, and controller to current and future Drupal constructs: 1. Model: I think most people would say that the current model is just the db schema. I say that the model should be the schema AND the data definition (currently in the shape of a form definition). In fact, I might argue that schemas should be phased out for a database abstracted system. Imagine if you could just define a simple data structure in the form: $mydata = array( '#type' => number, '#name' => 'My Number', '#default_value' => 1234, ); etc... While I agree that we having a drupal specific DDL is bad, the reality is that we already do have one: the current formAPI. Accepting that fact and writing tools to turn $mydata into a db schema will only help development, not raise the barrier. 2. Controller: These are the _submit and _validate functions right now. I know there is work going on to more flexibly work with these items (eg. I owe a patch to allow binding of buttons to functions). I think the controller layer probably needs the most work. The recent nodeapi vs. formAPI (call it Data API now!) illustrates this fact. 3. Views: Arguably, these are the theme_* functions; however, this is where the coupling of data to XHMTL forms I mentioned earlier comes in. Take for example '#type' => 'checkbox'. This definition makes me cry every time. Multiselects and checkboxes should be collapsed into one type: multi. Radios and drop downs should be collapsed into one type: single. Text boxes and text fields should just be one type, varied on size (and perhaps something else to allow filtering). If we move these functions into the theme layer, forms API will stop being just about forms and wills start being about data. Good. So, what are the benefits of this system? First, I think changing the semantics of the name will allieviate some confusion regarding the role of the Data API. The recent nodeapi discussions have shown that there is confusion over where and when data should be manipulated. I think it gives us CCK like features right out of the box. Since most of the data api will be used for defining nodes, it seems natural to me that users could define forms online and Drupal would turn them into types on the fly. This email is getting long as it is, so I'll end it here. Of course, discussion is welcome. Cheers, -M

14 19

RE: [development] New Core Theme for 5.0
by Michelle Cox 12 Sep '06

12 Sep '06

This isn't really a theme thing. It's something in the navigation menu doing it. I don't like it either, but I wanted to point out that it's not really an issue with the theme. Michelle On 9/12/2006 11:02:48 AM, Walt Daniels (wdlists(a)optonline.net) wrote: > I have another complaint about all the themes I have seen including this > one. Before you logon the menu begins with Navigation. After you logon > the > word Navigation is replaced with your username. This has two problems, > Navigation and username don't come from the same name space, i.e. username > does not imply anthing about menus or navigation to me. It has a > subsidiary > problem that is a visual clash, Navigation begins with a capital letter, > the > usernames frequently do not, e.g. my username is yktdan on many sites.

1 0

Administration module - looking for a maintainer
by David Reed 12 Sep '06

12 Sep '06

Earl Miles and myself coauthored the administration module. There is a 4.6and 4.7 version. There have been a number of bug reports opened for both version. I am not currently using this in any of my projects and I've been too busy of late to spend time researching the issues people are having so I'm asking the dev community, does anyone want to take over ownership of this module? It seems like the work that's gone into core for the next release this module will not need to live past 4.7. I don't know how many people are actually using it although I think they may be using it for CivicSpace. Any takers??

2 1

Re: development Digest, Vol 45, Issue 40
by Raven Brooks 12 Sep '06

12 Sep '06

There still seem to be misconceptions with this theme. The point of this exercise is to present a theme with solid, semantically correct XHTML that people can do a wide range of things with. If you want to make it fixed you can do that with CSS. If you want to make it fluid you can do that with CSS on the very same XHTML. If you want to make it *completely* different and look nothing like this you can still do that with different CSS and the same XHTML. It is exactly the same concept as CSS Zen Garden. Raven Brooks _____ Message: 4 Date: Tue, 12 Sep 2006 10:01:23 -0400 From: inkfree press <inkfree(a)gmail.com> Subject: Re: [development] New Core Theme for 5.0 To: Drupal-dev <development(a)drupal.org> Message-ID: <C12C35F3.1424E%inkfree(a)gmail.com> Content-Type: text/plain; charset="US-ASCII" "Earl Miles" wrote: > Morbus Iff wrote: >>>> Still fixed, not fluid. Minus one ;) >>> >>> Theme STILL has fixed and fluid options. Always has. >> >> Naturally, that's not entirely obvious just by looking at it, >> and I had no idea I was to login to fully appreciate the theme. > > We've had this discussion on the IRC. You complained about it being fixed > only. I told you it has a fluid option. Sure, ok, you've forgotten, but c'mon. > You're giving your -1 without paying any attention at all, and you don't even > remember talking about it in the past. If you're going to poo-poo something, > at least pay some attention. Maybe it's a waste of your time to actually > download the theme and look at it, but it's a waste of everyone's time when > you -1 it for being fixed-only when it's not, especially when your opinion is > important and people around here are going to assume you know what you're > talking about. Or, rather, you could make options more clear to the viewer. You actually point out a common "techie" problem: Tech folks often get a bit ruffled when the viewer doesn't see all the bells and whistles they've added. Instead of shooting the messenger, take the time to be more clear about what you wish to have reviewed. If you want people to take note of both Option A and Option B, then state so. Earl, you're personally invested in this theme, so your emotional response can be understood. However, precisely _because_ you are personally invested, it's very easy for you to forget that not everyone is. If you (or others) want to build in options, or have them reviewed, then make them clear and don't shoot the messenger. It surely looks (and acts) 'fixed width' to me...and I wouldn't spend time trying to examine other options unless I knew what someone wanted me to explore. Perhaps you should take (-1) steps back from the emotional connection you feel for this so-so theme and just get on with making it better, if that's your goal. It's coming along, but still seems very redundant to other themes that are readily available. (And the icons are too chunky on the edges, like bit map icons. I especially notice this with the small 'clock face' icon, which looks like bad clip art.) -1 on default fluidity -1 on icons +1 on general color scheme (which is the same as many other themes) -- inkfree

1 0

Scheduler module looking for a maintainer
by Angela Byron 12 Sep '06

12 Sep '06

On behalf of Ted Serbinkski, Scheduler module is looking for a new maintainer. http://drupal.org/project/scheduler If interested, contact m3avrck: http://drupal.org/user/12932 Ted's willing to help anyone who's interested get up to speed and so forth. -Angie

1 0

Release critical bugs for September 10, 2006
by drupal-devel＠drupal.org 10 Sep '06

10 Sep '06

Article / bug reports 4.7 Beta/ CVS Errors assigned: msameer age: 24 weeks 2 days url: http://drupal.org/node/55533 Chatbox / bug reports Localization problem age: 15 weeks 6 days url: http://drupal.org/node/64847 No check for loading chatbox with other name age: 41 weeks 5 days url: http://drupal.org/node/38397 CVS management/tracker / bug reports update for deprecated settings hook age: 8 weeks 11 hours url: http://drupal.org/node/73917 Event / bug reports event_start not being set age: 15 weeks 2 days url: http://drupal.org/node/65609 Next link will not show for Junes events age: 17 weeks 8 hours url: http://drupal.org/node/63454 Fatal Error After activating "Browse Scheduled Events" in modules age: 18 weeks 2 days url: http://drupal.org/node/61920 Event module preventing me from uploading age: 20 weeks 1 day url: http://drupal.org/node/59775 INSTALL.txt incorrect age: 20 weeks 6 days url: http://drupal.org/node/59019 event calendars off by day/not respecting timezones - fix? age: 23 weeks 5 days url: http://drupal.org/node/56189 Flexinode generates an error age: 24 weeks 4 days url: http://drupal.org/node/55135 Body text missing age: 25 weeks 2 days url: http://drupal.org/node/54383 Calendar subscribing not working age: 25 weeks 4 days url: http://drupal.org/node/54036 Problem Selecting Event by Type age: 26 weeks 4 days url: http://drupal.org/node/52883 Event start and end times not getting saved in database age: 38 weeks 2 days url: http://drupal.org/node/41300 Issues with list view for events age: 39 weeks 6 days url: http://drupal.org/node/39943 Database error keeps popping up age: 40 weeks 4 days url: http://drupal.org/node/39396 Date problem on calendar, off by a day age: 40 weeks 5 days url: http://drupal.org/node/39193 Events module bugs adding and changeing events age: 41 weeks 3 hours url: http://drupal.org/node/39016 gmdate() warnings on windows install age: 1 year 10 weeks url: http://drupal.org/node/26140 Event / support requests Blank Page After Submit age: 21 weeks 17 hours url: http://drupal.org/node/58918 Can't Administer Event Module age: 35 weeks 2 days url: http://drupal.org/node/43509 displaying event start info in flexinode tabular view? age: 48 weeks 4 days url: http://drupal.org/node/33019 Event block missing content of many fields age: 51 weeks 2 hours url: http://drupal.org/node/31532 Filebrowser / bug reports ArrayMerge Errors with PHP5 age: 28 weeks 1 day url: http://drupal.org/node/51174 Filebrowser / support requests File paths generated by new filebrowser are not leading to the file age: 2 weeks 8 hours url: http://drupal.org/node/80903 Gallery / bug reports IE error using embed not error with none-embed... age: 18 weeks 1 day url: http://drupal.org/node/62119 block manage - Block specific settings can save item selected - with drupal 4.7B4 age: 27 weeks 6 days url: http://drupal.org/node/51436 Gallery / feature requests Unable to initialize embedded Gallery age: 29 weeks 4 days url: http://drupal.org/node/49417 Gallery / support requests import existing gallery2 user account age: 44 weeks 5 days url: http://drupal.org/node/35920 Glossary / feature requests po files and other language support age: 32 weeks 4 days url: http://drupal.org/node/46313 Goofy / feature requests Goofy Forum UI age: 49 weeks 5 days url: http://drupal.org/node/32294 Htmlarea / bug reports if Clean URLs is Enabled, upload_image in htmlarea not working age: 7 weeks 5 days url: http://drupal.org/node/74119 htmlArea/xinha firefox freezes (multiple textareas) age: 14 weeks 2 days url: http://drupal.org/node/66746 Layout is quirky age: 26 weeks 5 days url: http://drupal.org/node/52741 view source broken in firefox 1.5 age: 32 weeks 4 days url: http://drupal.org/node/46246 Toolbar won't display correct in IE 6 with Pushbutton Theme age: 1 year 1 day url: http://drupal.org/node/30696 Htmlarea / support requests Problem with size of button assigned: khayman age: 19 weeks 5 days url: http://drupal.org/node/60255 Image / bug reports suddenly the thumbnails can't be seen age: 4 days 1 hour url: http://drupal.org/node/82712 Preview and Thumbnail images have incorrect paths. age: 3 weeks 4 days url: http://drupal.org/node/78791 Image Attach: If title is not filled then link for image is bad (result=error) assigned: brumisek age: 4 weeks 5 days url: http://drupal.org/node/77610 No thumbnails will show.. age: 7 weeks 2 days url: http://drupal.org/node/74770 Localization issue for Premiew and Thumbnail links age: 11 weeks 2 days url: http://drupal.org/node/70396 Category module and image_gallery age: 15 weeks 5 days url: http://drupal.org/node/65066 Problem in Image Gallery display especially in Internet Explorer age: 28 weeks 2 days url: http://drupal.org/node/50943 By CHanging the following the error changes assigned: walkah age: 38 weeks 2 days url: http://drupal.org/node/41353 imagemagick.inc file does not contain the function... age: 43 weeks 15 hours url: http://drupal.org/node/37372 Error when Submitting New Image Node age: 43 weeks 16 hours url: http://drupal.org/node/37366 only variables can be passed by reference on line 713 age: 44 weeks 3 days url: http://drupal.org/node/36092 image.module 4.6.0 strange actions age: 48 weeks 2 days url: http://drupal.org/node/33292 File copy failed: source file does not exist error after running update-image.php age: 50 weeks 4 days url: http://drupal.org/node/31816 Path for image folder not inserted correctly when nodetype = image age: 1 year 1 week url: http://drupal.org/node/30031 image module patch & image_import module age: 1 year 2 weeks url: http://drupal.org/node/29377 image module fails on dual site configuration age: 1 year 8 weeks url: http://drupal.org/node/26657 Cannot upload .jpgs age: 1 year 27 weeks url: http://drupal.org/node/18076 Image / feature requests HELP I want to display image as well as information about that image age: 3 weeks 3 days url: http://drupal.org/node/79129 how to display limited imagea and how to give links to other pages in drupal assigned: anjeet age: 4 weeks 5 days url: http://drupal.org/node/77597 Copying original age: 44 weeks 2 days url: http://drupal.org/node/36321 Image / support requests showing the galleries separately age: 11 weeks 1 day url: http://drupal.org/node/70499 upload image wont' display, it show a file not found page age: 23 weeks 3 days url: http://drupal.org/node/56491 I need to change the style of displaying each node. Please help. age: 35 weeks 6 days url: http://drupal.org/node/43017 What does update-image.php do exactly? age: 37 weeks 1 day url: http://drupal.org/node/42222 images not showing2 age: 40 weeks 1 day url: http://drupal.org/node/39773 Image Folder Permissions age: 46 weeks 1 day url: http://drupal.org/node/34839 Image Module Permissions age: 1 year 9 weeks url: http://drupal.org/node/26280 Image / tasks how to display limited images in one page and if more display on next page and how to give links to other pages in drupal assigned: anjeet age: 4 weeks 5 days url: http://drupal.org/node/77605 Listhandler / bug reports user lookup on name only assigned: zeroj age: 23 weeks 4 hours url: http://drupal.org/node/56936 Link to mailhandler does not use l() function age: 34 weeks 1 day url: http://drupal.org/node/44599 Listhandler caused error in "comment.module on line 996" ? age: 44 weeks 2 days url: http://drupal.org/node/36244 Listhandler 4.6.0 fails to send emails at all age: 1 year 7 weeks url: http://drupal.org/node/27095 Listhandler / tasks Correct/Complete Documentation age: 46 weeks 17 hours url: http://drupal.org/node/34909 Mailhandler / support requests Creating a page using mailhandler age: 12 weeks 4 days url: http://drupal.org/node/68947 Mail Body not downloaded age: 35 weeks 3 days url: http://drupal.org/node/43374 Members / bug reports Update: beta5 and possible problem with php 4 age: 27 weeks 3 days url: http://drupal.org/node/52004 Patch for member.module to bring it up to 4.7 age: 31 weeks 1 day url: http://drupal.org/node/47829 foreach() assigned: neablo age: 36 weeks 6 days url: http://drupal.org/node/42350 Node (key)words / bug reports Error on delete node age: 2 weeks 2 days url: http://drupal.org/node/80505 can't use php functions in body of nodes assigned: Robrecht Jacques age: 3 weeks 2 days url: http://drupal.org/node/79315 Node (key)words / feature requests Enable nodewords for node type? age: 30 weeks 1 day url: http://drupal.org/node/48869 Node Aggregator / bug reports help Install error assigned: mindwarz age: 2 weeks 5 days url: http://drupal.org/node/79969 nodes are being created with no body age: 39 weeks 3 days url: http://drupal.org/node/40373 missing promote column assigned: Bèr Kessels age: 41 weeks 1 day url: http://drupal.org/node/38836 Naming issues with files and DB tables age: 46 weeks 6 days url: http://drupal.org/node/34298 RSS "no element found at line 1" age: 1 year 10 weeks url: http://drupal.org/node/26185 Outdated help texts age: 2 years 5 weeks url: http://drupal.org/node/9692 Import doesn't like XML/RSS feeds with no Title element age: 2 years 14 weeks url: http://drupal.org/node/8128 Node Aggregator / tasks move XML-parser into an inclde file. age: 1 year 11 weeks url: http://drupal.org/node/25439 Notify / bug reports Content published by scheduler not mailed out age: 13 weeks 5 days url: http://drupal.org/node/67475 Notify not playing well with Organic Groups age: 38 weeks 5 days url: http://drupal.org/node/40967 Path / bug reports Login as an alias gets cached age: 50 weeks 5 days url: http://drupal.org/node/31699 Pdfview / bug reports pdfview will not make a pdf for any node with an image age: 4 weeks 1 day url: http://drupal.org/node/78229 Malformed PDFs age: 36 weeks 6 days url: http://drupal.org/node/42312 support dynamic content? age: 42 weeks 1 day url: http://drupal.org/node/38181 please explain html2fpdf age: 42 weeks 4 days url: http://drupal.org/node/37748 Management of french charaters age: 43 weeks 6 days url: http://drupal.org/node/36605 Pdfview / support requests Problem with PDFView age: 33 weeks 5 days url: http://drupal.org/node/45092 Poormanscron / support requests Poormanscron not doing what it says on the tin age: 22 hours 12 min url: http://drupal.org/node/83252 Privatemsg / bug reports privatemsg module: - database error - incompatibility with relationship module age: 30 weeks 1 day url: http://drupal.org/node/48866 Project / bug reports Tagging of Sub-projects. age: 15 weeks 4 days url: http://drupal.org/node/65110 attachements missing after pressing preview age: 20 weeks 6 days url: http://drupal.org/node/59039 SQL errors on issues and my projects pages age: 37 weeks 2 days url: http://drupal.org/node/42160 Get disconnected from server on attempting to add an issue age: 44 weeks 3 days url: http://drupal.org/node/36124 Projects not listed and page not complete age: 1 year 14 weeks url: http://drupal.org/node/23956 Project / feature requests Need Documentation age: 39 weeks 2 days url: http://drupal.org/node/40392 Allow subscription to individual project issues age: 46 weeks 4 days url: http://drupal.org/node/34496 Project / support requests Project is unusable (to me) assigned: dww age: 8 weeks 3 days url: http://drupal.org/node/73460 Fatal error: Only variables can be passed by reference age: 25 weeks 4 days url: http://drupal.org/node/53984 Add the project release manually without the scan feature age: 46 weeks 4 days url: http://drupal.org/node/34500 Project / tasks First draft at releases as nodes age: 9 hours 7 min url: http://drupal.org/node/83339 New method for contributed project releases and versions assigned: dww age: 21 weeks 6 days url: http://drupal.org/node/58066 Recipe / bug reports Error with URL to recipe age: 1 year 1 week url: http://drupal.org/node/29885 Remindme / bug reports Argument #1 is not an array age: 12 weeks 2 days url: http://drupal.org/node/69286 Cron job creates SQL error age: 14 weeks 5 days url: http://drupal.org/node/66202 Subscriptions / bug reports When subscriptions is enabled with storylink of voting up/down age: 2 days 13 hours url: http://drupal.org/node/83016 Problem with %url in notification emails assigned: dziemecki age: 2 weeks 3 days url: http://drupal.org/node/80266 Taxonomy dhtml / bug reports Error on Page with Internet Explorer 6 age: 12 weeks 4 days url: http://drupal.org/node/68906 Taxonomy DHTML's cache ignores user privileges age: 16 weeks 1 day url: http://drupal.org/node/64532 Does not work correctly in Internet Explorer age: 48 weeks 1 day url: http://drupal.org/node/33354 javascrip downloads square.gif for every category age: 1 year 29 weeks url: http://drupal.org/node/17366 Taxonomy dhtml / feature requests A unique page for each category group? age: 46 weeks 3 days url: http://drupal.org/node/34610 Taxonomy navigation / bug reports Taxonomy links only work for the first line of links assigned: PierreFWalter age: 28 weeks 1 day url: http://drupal.org/node/51149 Taxonomy navigation / support requests Taxonomy has dissapeared age: 48 weeks 4 days url: http://drupal.org/node/33061 TrackBack / bug reports Sends trackbacks for unpublished nodes assigned: ankur age: 1 year 32 weeks url: http://drupal.org/node/16239 TrackBack / feature requests Use AKISMET to filter the spam, spam.module doesn't do the job age: 2 weeks 2 days url: http://drupal.org/node/80558 User experience / bug reports Fatal error for Drupal 4.7.0 installed with Fantastico age: 10 weeks 3 days url: http://drupal.org/node/71407 Sometimes when I open the drupal site in My Local machine I am getting the error. age: 26 weeks 6 days url: http://drupal.org/node/52652 Event start/end date section should *not* show first on Submit event page age: 37 weeks 4 days url: http://drupal.org/node/41869 meet age: 38 weeks 4 days url: http://drupal.org/node/40996 User experience / feature requests A better Drupal.org Index (homepage) interface/layout mockup age: 32 weeks 6 days url: http://drupal.org/node/45967 A small but effective improvement to Improvement of admin/user accessability suggestion age: 47 weeks 1 day url: http://drupal.org/node/34073 User experience / support requests How can I stop visitors from being able to edit my blog posts? assigned: jsolochek age: 3 weeks 1 day url: http://drupal.org/node/79432 block module / side-content module age: 17 weeks 5 days url: http://drupal.org/node/62506 Acess denied to login Newly installed and upgraded site that I need up and running A.S.A.P assigned: Johnny age: 42 weeks 16 hours url: http://drupal.org/node/38227 Webserver Auth / bug reports Logging out error age: 23 weeks 2 days url: http://drupal.org/node/56663 Wiki / bug reports the wiki module can't work with HTML age: 31 weeks 5 days url: http://drupal.org/node/47124

2 1

Microsoft SQL Support added
by Peter Heinrich 10 Sep '06

10 Sep '06

Hi everybody, I've done a quick hack to support MS-SQL-Server, since my company needed that functionality. I know, that MS-SQL was supported in earlier versions and that you decided to drop it. Since only minor changes to the system were necessary I believe that supporting this database would not take so much. I've done that for version 4.7.2, you can get the patch here: http://www.heinrichp.de/drupal-4.7.2-mssql.patch This is not tested very much but it works for me quite fine. Tested with: Database System: Microsoft Server 2003 Standard Microsoft SQL Server 2005 Webserver: Debian Sarge PHP-Sybase driver regards, Peter

4 3

Out of Office AutoReply: [Subscriptions bug] Enable Subscriptions module -> no comments are shown anymore
by Metzler, David 09 Sep '06

09 Sep '06

I am out of the office until Monday September 18nd. If you need immediate assistance, please e-mail the network services dl, or call Aaron Powell at ext 6238. David Metzler Network Services

2 1

dealing with gzipped data with php.
by Augustin (Beginner) 09 Sep '06

09 Sep '06

Hello, I have a question that is tough for me, but hopefully easy for you :) I am getting some data via XML RPC. One particular method is sending me a "gzipped array of 32 bits unsigned big endian integers". Sorry to be rude, but I had to say it! So, basically I have: $xml_rpc_reply['data'] = gzipped file; How can I unzip on the fly the data so I can deal with it? Does it need a particular setup, apache/php server side? Assuming I manage to unzip the data, how do I then deal with the '32 bits big endian integers' within it? I certainly do hope that some of you can give me some pointers, thanks, Augustin. -- http://www.wechange.org/ Because we and the world need to change. http://www.reuniting.info/ Intimate Relationships, peace and harmony in the couple.

1 1

NodeAPI Broken-ness, possible solutions
by Jeff Eaton 09 Sep '06

09 Sep '06

In Drupal 5.0, hook_view() and nodeapi 'view' operations now stick elements into the $node->content[] array, and it's rendered for output. That open up a lot of doors for theming and customization, and also moves us closer to a clean centralized 'rendering API' for on screen content. However, some modules need to do more than just add or rearrange elements, though. They need to modify *the complete text of the node* after it's fully rendered. In the case of upload.module, for example, we do path substitution to make sure that things work when clean URLs are turned off. In 4.7 and earlier, this was easy because ALL view-time work involved altering the raw node body. In 5.0, though, this requires adding a callback to $node->content['#after_render']. When drupal_render parses the array to render it, it will call the functions listed in that element, giving them a chance to alter the final text. Shortly after the code freeze, however, I realized that this was insufficient for some modules, and broke functionality that worked fine in 4.7. Why? 1) Because they're called inside drupal_render(), the #after_render callback functions don't get any context. They don't have a copy of the $node object (which some modules need to do substitutions properly). 2) In addition, they don't know whether the node is displaying in teaser mode, whether it's in full page mode, etc. 3) Code that needs to output just a small chunk of the node (in a sidebar block, for example) loses any filtering done by modules like inline or upload. Since the #after_build element is only processed when the node is rendered *as a whole*. Taken together, these problems cripple a couple of critical Drupal modules and rob us of many of the promised benefits of the new node rendering system. http://drupal.org/node/82045 has a patch that I posted in an attempt to solve this problem a day or so after the code freeze. It is potentially controversial, as it adds a new hook after the code freeze (though it doesn't change any existing ones). It's a somewhat subtle and complex issue, but I'd very much appreciate any thoughts others would be willing to contribute. I'm hoping that we can figure out an elegant solution to this before any of the badly affected modules need to be ported. --Jeff

1 0