- Development - lists.drupal.org

[drupal-devel] critical: infinite loop in form.inc (?)
by Anguo 07 Nov '05

07 Nov '05

Hello: Any idea what could be creating in infinite loop here: http://drupal.org/node/36643 B. -- http://www.wechange.org/ Because we and the world need to change. http://www.reuniting.info/ Intimate Relationships, peace and harmony in the couple. http://www.gnosis-usa.com/ Revolutionary Psychology, White Tantrism, Dream Yoga... http://www.masquilier.org/ Condorcet, Approval alternative, better voting methods.

1 0

[drupal-devel] Seems like form validation might fail with some users
by Steve Dondley 07 Nov '05

07 Nov '05

Some ISP's, like AOL, change a user's IP address from one page view to the next. It seems like this might cause a problem for the new forms API which uses the IP address to create a token used to validate a form. The IP address collected from the user when used the form gets loaded could be different from the IP address seen when submitting it.

9 9

Re: [drupal-devel] Forms API and readability
by Angie Byron 06 Nov '05

06 Nov '05

Konstantin Käfer wrote: > Angie, you said that you updated CODING_STANDARDS.html in contrib > root. But obviously the file hasn't changed since september 11. Would > you mind checking it in a second time? Sorry, I should have been more clear... I was the one who updated it back in September to cover the // $Id$ commenting standard (as opposed to /* $Id$ */) but it has yet to appear on the actual coding standards page in the handbook. So I was curious to know what the actual procedure was in updating that page on the site. I've updated the CODING_STANDARDS.html page in CVS again now to include: * Added note about leaving off the ?> at the ends of code files (added full explanation as well to http://drupal.org/node/545) * Added section on how to format arrays, including consensus of this discussion * Fixed a small typo Could Dries or someone who has access please update http://drupal.org/node/318 to reflect these changes? -Angie

3 4

[drupal-devel] Comment Moderation.
by Gordon Heydon 06 Nov '05

06 Nov '05

Hi, I have had a question from a client and I was thinking that someone must have already done this. Basically he would like comments that are posted against forum entries not be moderated and comments posted against other node types, eg story or page to be moderated. I have looking at the code and the I was thinking of adding additional perms for each node type as well as having the current one, and then or'ing the 2 to see what I came up with. I would be surprised if no one else had needed something like this. Thanks in advance. Gordon.

2 2

Re: [drupal-devel] RSS feed for cvs log oh Core HEAD
by Karoly Negyesi 05 Nov '05

05 Nov '05

> Thanks! FWIW: the url for the feed is: > http://drupal.org/cvs?rss=true&nid=3060 ooooh this is NICE. Now... what about advertising this a bit more? Or maybe, obfuscate it a bit more and a "guess where is the feed today" contest :P ?

1 0

Re: [drupal-devel] New forms API -- kudos to the developers!
by Karoly Negyesi 05 Nov '05

05 Nov '05

> Zend Studio impressed me, almost enough to give it a try properly. Does > anyone know if it works completely (as in with debugging) on mac? As Zend Studio is in Java... though I found that it's very slow sometimes.

1 0

Re: node_import and forms - some questions (Was: [drupal-devel] Orphaning the node_import module)
by Karoly Negyesi 05 Nov '05

05 Nov '05

On Fri, 04 Nov 2005 11:38:08 +0100, Robrecht Jacques <robrechtj(a)gmail.com> wrote: > Forgot one question: > > 4. If I use a [form_id]_execute function, how do I know which button > on the form was pushed? Am I still supposed to look into $edit['op']? Yes, looking at $_POST['op'] is fine. Jut look, never store/write it out. > Or alternatively, how can I attach a different _execute function to > each submit button, similar to "#valid" ? ATM you can't. Regards NK

1 0

[drupal-devel] Bug#336719: Can you reproduce this on 4.5.3-4?
by Hilko Bengen 05 Nov '05

05 Nov '05

notfound 336719 4.5.3-4 thank you "Matthew A. Nicholson" <matt(a)matt-land.com> writes: > I don't use 4.5.3, I use 4.5.5. I can download 4.5.3 and compare the > source changes, but I don't use it and it's not an option for me to test > with it. Give me a few hours and i'll get back to you. :) 4.5.3-4 is the current version in stable and that has a higher priority for me right now than the version in testing/unstable. This change got introduced to session.inc after 4.5.3: function sess_destroy($key) { - db_query("DELETE FROM {sessions} WHERE sid = '$key'"); + db_query("DELETE FROM {sessions} WHERE sid = '%d'", $key); } ... and this is the last change that supposedly fixes the logout problem. function sess_destroy($key) { - db_query("DELETE FROM {sessions} WHERE sid = '%d'", $key); + db_query("DELETE FROM {sessions} WHERE sid = '%s'", $key); } db_query uses sprintf to replace placeholder expressions if passed more than one argument and it seems to me that using %s does the same thing as PHP's string expansion as in 4.5.3. I have removed version 4.5.3-4 from this bug. If you disagree, feel free to add it again with a "found" statement to control(a)b.d.o, with a rationale. Cheers, -Hilko

2 1

[drupal-devel] Release critical bugs for November 05, 2005
by drupal-devel＠drupal.org 05 Nov '05

05 Nov '05

/ bug reports PHP 4.4.1 breaks Article Categories list age: 1 day 19 hours url: http://drupal.org/node/36245 / bug reports XML Parsing Error age: 4 days 19 hours url: http://drupal.org/node/35872 / bug reports email spam filtering does not "see" email addresses when they are NOT preceded by a word age: 41 weeks 6 days url: http://drupal.org/node/15654 / bug reports Random "access denied" and logouts age: 18 hours 3 sec url: http://drupal.org/node/36386 Profile.module accepts, but does not display, user input age: 19 hours 31 min url: http://drupal.org/node/36381 old behaviour missing on admin/themes age: 1 day 3 hours url: http://drupal.org/node/36333 expecting `T_STRING' or `T_VARIABLE' or `T_NUM_STRING' age: 2 days 11 hours url: http://drupal.org/node/36159 Mail warning errors age: 3 days 20 hours url: http://drupal.org/node/35973 Form API missing textarea hook age: 1 week 20 hours url: http://drupal.org/node/35594 update makes me loose all my themes and blocks and so. age: 1 week 23 hours url: http://drupal.org/node/35577 Profile_values random overwritten age: 1 week 1 day url: http://drupal.org/node/35555 IE allocates memory until it crashes age: 1 week 2 days url: http://drupal.org/node/35368 $status is not returned when the vocabulary 'Forums' is being made age: 1 week 4 days url: http://drupal.org/node/35177 Duplicate entries in aggregator age: 1 week 5 days url: http://drupal.org/node/35048 Bad SQl query, postgresql, c.format column to GROUP BY clause age: 1 week 5 days url: http://drupal.org/node/35008 Changing theme in cvs PHP5 is not working age: 1 week 5 days url: http://drupal.org/node/34991 Error when using the 'Vote' button to vote at a poll age: 1 week 6 days url: http://drupal.org/node/34921 Search results don't include last part of longer pages age: 2 weeks 16 hours url: http://drupal.org/node/34826 Cron Search Executes PHP pages - Node Range Lost Permanently in Search age: 2 weeks 1 day url: http://drupal.org/node/34768 Requesting a new password does not give a message age: 2 weeks 1 day url: http://drupal.org/node/34726 Can't save admin settings - "directory does not exist" age: 2 weeks 2 days url: http://drupal.org/node/34646 Permissions Too Prohibitive on Install age: 2 weeks 3 days url: http://drupal.org/node/34502 upload module and space in filenames age: 2 weeks 3 days url: http://drupal.org/node/34497 Problem with nodes when upgrading 4.6.3 ->4.7 age: 2 weeks 5 days url: http://drupal.org/node/34342 Bug in settings (if upload directory is unwritable we won't be able to change settings) assigned: chx age: 2 weeks 6 days url: http://drupal.org/node/34218 Theme settings not saved since Forms API assigned: chx age: 3 weeks 2 hours url: http://drupal.org/node/34170 overzealous file_check_directory for file_directory_path age: 3 weeks 3 days url: http://drupal.org/node/33771 Pictures (avatars) don't display age: 3 weeks 4 days url: http://drupal.org/node/33699 No checking/catching for unique database columns assigned: cyrific age: 3 weeks 6 days url: http://drupal.org/node/33478 Bug in node_load call in statistics_node_tracker age: 6 weeks 18 hours url: http://drupal.org/node/32040 Upload broken in IE age: 6 weeks 1 day url: http://drupal.org/node/31968 Comment options: broken. age: 6 weeks 4 days url: http://drupal.org/node/31641 Node update hooks are getting stale data and can't save. age: 6 weeks 6 days url: http://drupal.org/node/31495 Translation/localization import bug (Drupal 4.6.3, Fedora 4) age: 7 weeks 1 day url: http://drupal.org/node/31364 When removing a revision, the associated files are not removed. assigned: killes(a)www.drop.org age: 7 weeks 1 day url: http://drupal.org/node/31355 Delete filter format fails age: 8 weeks 23 hours url: http://drupal.org/node/30781 Submit button needs double-press when menu options dropped-down age: 9 weeks 3 days url: http://drupal.org/node/30097 update.php is broken when drupal is installed in subdirectory age: 9 weeks 3 days url: http://drupal.org/node/30075 Drupal "forgets" some blocks... age: 10 weeks 23 hours url: http://drupal.org/node/29733 system_settings_save() bypasses access_control age: 10 weeks 1 day url: http://drupal.org/node/29680 files table needs a "module" column age: 10 weeks 6 days url: http://drupal.org/node/29297 logo uploads still broken...? can't replace default logo with new drupal 4.6.3 tar ball? age: 11 weeks 18 hours url: http://drupal.org/node/29221 Error when anonymous user creates content age: 11 weeks 3 days url: http://drupal.org/node/29032 Reset user mail variables. age: 11 weeks 5 days url: http://drupal.org/node/28868 Free Tagging broken on forums age: 12 weeks 3 days url: http://drupal.org/node/28607 js addLoadEvent not working. age: 13 weeks 6 days url: http://drupal.org/node/27884 Forum bug with drupal 462 age: 14 weeks 2 days url: http://drupal.org/node/27663 enable MySQL client side for UTF8 age: 15 weeks 4 days url: http://drupal.org/node/26990 Drupal 4.6.2 Doesn't allow login (IIS 5.1, PHP 5.0.4) assigned: bigeye age: 16 weeks 22 hours url: http://drupal.org/node/26780 postgresql autocomplete code age: 18 weeks 2 days url: http://drupal.org/node/26027 Accidentally Deleting Forums Vocabulary in Categories Breaks Forums? age: 22 weeks 13 hours url: http://drupal.org/node/24274 Getting term node counts fails without "Administer Nodes" permission age: 22 weeks 3 days url: http://drupal.org/node/24015 Mysql Password with special symbols assigned: zignit age: 26 weeks 6 days url: http://drupal.org/node/21719 4.6 aggregator showing/not interpreting HTML tags age: 30 weeks 6 days url: http://drupal.org/node/19874 New submit error, non-admin user, postgresql database assigned: adrian age: 34 weeks 3 days url: http://drupal.org/node/18552 user redirected to homepage when logging in age: 35 weeks 20 hours url: http://drupal.org/node/18381 Cache should store BINARY data as a BLOB and not as text age: 38 weeks 3 days url: http://drupal.org/node/16998 Change to sesssion.inc violates UID database constraint age: 41 weeks 6 days url: http://drupal.org/node/15666 forum.module problem with postgresql v7.4.1 age: 42 weeks 4 days url: http://drupal.org/node/15411 Argument NOT must be type boolean age: 50 weeks 5 days url: http://drupal.org/node/12950 Cache problem with Postgres assigned: Cvbge age: 1 year 9 weeks url: http://drupal.org/node/10407 user error: Duplicate entry assigned: Kjartan age: 1 year 48 weeks url: http://drupal.org/node/4428 / feature requests Profile fields should be controlled by roles age: 6 days 15 hours url: http://drupal.org/node/35693 Module Access Control age: 1 week 1 day url: http://drupal.org/node/35459 Customizable module blocks age: 2 weeks 3 days url: http://drupal.org/node/34563 Filter the title to allow HTML comments age: 15 weeks 1 day url: http://drupal.org/node/27205 No obvious way to tell which release a site is running assigned: Uwe Hermann age: 29 weeks 2 days url: http://drupal.org/node/20439 moving pages en masse age: 31 weeks 2 days url: http://drupal.org/node/19754 Taxonomy module should use nodeapi 'load' age: 34 weeks 2 days url: http://drupal.org/node/18631 Auto PHP memory maximisation age: 36 weeks 4 days url: http://drupal.org/node/17663 Allow named anchors to work without specifying full path to node age: 1 year 50 weeks url: http://drupal.org/node/4213 / support requests user logins failing - cry for help age: 1 week 4 days url: http://drupal.org/node/35104 Password error when changing user role age: 1 week 6 days url: http://drupal.org/node/34933 / feature requests Events only for registered users age: 2 weeks 2 days url: http://drupal.org/node/34640 / support requests displaying event start info in flexinode tabular view? age: 4 weeks 4 days url: http://drupal.org/node/33019 Event block missing content of many fields age: 6 weeks 6 days url: http://drupal.org/node/31532 / tasks How do I contribute? age: 1 day 1 hour url: http://drupal.org/node/36351 / bug reports file size bug age: 21 weeks 1 day url: http://drupal.org/node/24728 / bug reports Search results give incorrect links age: 3 weeks 5 days url: http://drupal.org/node/33539 Full screen slideshow in Gallery module is not working (erroring out on the wrong URL) age: 17 weeks 2 days url: http://drupal.org/node/26479 / support requests import existing gallery2 user account age: 4 days 11 hours url: http://drupal.org/node/35920 / feature requests Goofy Forum UI age: 5 weeks 4 days url: http://drupal.org/node/32294 / bug reports only variables can be passed by reference on line 713 age: 2 days 22 hours url: http://drupal.org/node/36092 image.module 4.6.0 strange actions age: 4 weeks 1 day url: http://drupal.org/node/33292 File copy failed: source file does not exist error after running update-image.php age: 6 weeks 3 days url: http://drupal.org/node/31816 Path for image folder not inserted correctly when nodetype = image age: 9 weeks 3 days url: http://drupal.org/node/30031 image module patch & image_import module age: 10 weeks 5 days url: http://drupal.org/node/29377 image module fails on dual site configuration age: 16 weeks 2 days url: http://drupal.org/node/26657 Cannot upload .jpgs age: 35 weeks 5 days url: http://drupal.org/node/18076 / feature requests Copying original age: 1 day 6 hours url: http://drupal.org/node/36321 Image deletions? age: 8 weeks 3 days url: http://drupal.org/node/30557 / support requests Image Folder Permissions age: 2 weeks 14 hours url: http://drupal.org/node/34839 Images are there but not showing assigned: Stepfordtwit age: 14 weeks 2 days url: http://drupal.org/node/27615 Image Module Permissions age: 17 weeks 6 days url: http://drupal.org/node/26280 / bug reports Listhandler caused error in "comment.module on line 996" ? age: 1 day 19 hours url: http://drupal.org/node/36244 Prefix column error for SQL in Listhandler admin!! age: 4 weeks 4 days url: http://drupal.org/node/33017 / tasks Correct/Complete Documentation age: 1 week 6 days url: http://drupal.org/node/34909 / bug reports Naming issues with files and DB tables age: 2 weeks 5 days url: http://drupal.org/node/34298 RSS "no element found at line 1" age: 18 weeks 20 hours url: http://drupal.org/node/26185 Outdated help texts age: 1 year 13 weeks url: http://drupal.org/node/9692 Import doesn't like XML/RSS feeds with no Title element age: 1 year 22 weeks url: http://drupal.org/node/8128 / tasks move XML-parser into an inclde file. age: 19 weeks 4 days url: http://drupal.org/node/25439 / feature requests Notify turn on by default age: 2 days 10 hours url: http://drupal.org/node/36163 Notify.module ignores the true submission queue age: 2 years 1 week url: http://drupal.org/node/3765 / bug reports Login as an alias gets cached age: 6 weeks 4 days url: http://drupal.org/node/31699 / feature requests Internationalization support for PDF assigned: TheLibrarian age: 1 year 31 weeks url: http://drupal.org/node/6795 / bug reports privatemsg not working with current head age: 7 weeks 49 min url: http://drupal.org/node/31469 Reminder email links don't work age: 19 weeks 1 day url: http://drupal.org/node/25677 / bug reports Get disconnected from server on attempting to add an issue age: 2 days 17 hours url: http://drupal.org/node/36124 can't select all projects age: 4 weeks 1 day url: http://drupal.org/node/33262 Can't update issue title from issue comment assigned: nedjo age: 4 weeks 5 days url: http://drupal.org/node/32843 Projects not listed and page not complete age: 22 weeks 4 days url: http://drupal.org/node/23956 Date for latest is incorrect age: 29 weeks 2 days url: http://drupal.org/node/20485 / feature requests Allow subscription to individual project issues age: 2 weeks 3 days url: http://drupal.org/node/34496 Implement XML-RPC functionlality for communication between drupal.org and Drupal installations age: 3 weeks 20 hours url: http://drupal.org/node/34108 / support requests Add the project release manually without the scan feature age: 2 weeks 3 days url: http://drupal.org/node/34500 / tasks Update to use Form API age: 3 weeks 4 days url: http://drupal.org/node/33736 / bug reports Error with URL to recipe age: 9 weeks 5 days url: http://drupal.org/node/29885 / feature requests Request to generate email for all content changes/additions, including comments age: 16 weeks 2 hours url: http://drupal.org/node/26824 / bug reports Wrong URL mask age: 1 week 3 days url: http://drupal.org/node/35215 / bug reports Does not work correctly in Internet Explorer age: 4 weeks 23 hours url: http://drupal.org/node/33354 Blocks switch and reset when vocabs are modified age: 25 weeks 2 days url: http://drupal.org/node/22631 javascrip downloads square.gif for every category age: 37 weeks 4 days url: http://drupal.org/node/17366 / feature requests A unique page for each category group? age: 2 weeks 2 days url: http://drupal.org/node/34610 / support requests Taxonomy has dissapeared age: 4 weeks 3 days url: http://drupal.org/node/33061 / bug reports Sends trackbacks for unpublished nodes assigned: ankur age: 40 weeks 2 days url: http://drupal.org/node/16239 / feature requests A small but effective improvement to Improvement of admin/user accessability suggestion age: 3 weeks 1 day url: http://drupal.org/node/34073 / bug reports User error: Table 'db_drpl1.weblink' doesn't exist? a pain in the neck age: 2 weeks 1 day url: http://drupal.org/node/34765

1 0

[drupal-devel] What does #post_process do?
by Richard Archer 05 Nov '05

05 Nov '05

In http://drupal.org/node/35575 Karoly suggested that the form needs a #post_process. The only documentation I can find about #post_process is "This also introduces the #post_process property, which allows you to change the form based on stuff that has been submitted." Well, this bug doesn't require the form to be changed. It just needs to read a field from the form. So I don't see why or how #post_process can be used here. Anyone care to share some wisdom? ...Richard.

2 1