- Development - lists.drupal.org

[drupal-devel] [bug] Author information block seems to be broken
by tostinni 12 Aug '05

12 Aug '05

Issue status update for http://drupal.org/node/27948 Post a follow up: http://drupal.org/project/comments/add/27948 Project: Drupal Version: cvs Component: profile.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: robertDouglass Updated by: tostinni -Status: active +Status: patch (code needs review) Attachment: http://drupal.org/files/issues/profile.module_2.patch (1.09 KB) This little patch does the trick. The bug came from the fact that the query retrieving user profiles, didn't take all public fields. tostinni Previous comments: ------------------------------------------------------------------------ Mon, 01 Aug 2005 12:27:39 +0000 : robertDouglass This needs confirmation but I am unable to get fields to be shown in the author information block. The 'Link to full user profile' will work, but when I deselect 'Link to full user profile' from admin/block/configure/profile/0 and select the other fields instead, the block fails to materialize.

1 0

[drupal-devel] [bug] settings for multiple sites with port
by pbcomm 12 Aug '05

12 Aug '05

Issue status update for http://drupal.org/node/28719 Post a follow up: http://drupal.org/project/comments/add/28719 Project: Drupal Version: 4.6.0 Component: base system Category: bug reports Priority: normal Assigned to: pbcomm Reported by: pbcomm Updated by: pbcomm Status: patch (ready to be committed) I have 2 sites running on port 85 (I can not have them on port 80 because of the provider) and can not create settings directory for any of them, ":" is not a valid char for directory name (Windows Host). Example: http://name.domain.com:81/site/ My suggestion is to change the following line: $server = explode('.', rtrim($_SERVER['HTTP_HOST'], '.')); to: $tmp = parse_url(rtrim($_SERVER['HTTP_HOST'], '.')); $server = explode('.', $tmp['host']); pbcomm

1 0

[drupal-devel] [bug] Blocks showing up when module disabled
by drumm 12 Aug '05

12 Aug '05

Issue status update for http://drupal.org/node/13802 Post a follow up: http://drupal.org/project/comments/add/13802 Project: Drupal Version: cvs Component: module system Category: bug reports Priority: minor -Assigned to: Anonymous +Assigned to: drumm Reported by: Jose A Reyero Updated by: drumm Status: patch (code needs work) I can work on this. drumm Previous comments: ------------------------------------------------------------------------ Thu, 02 Dec 2004 13:19:31 +0000 : Jose A Reyero This only happens in the module administration page. To reproduce this behaviour: 1. enable a module and one block provided by it - I.e. 'archive' module 2. disable the module The block still shows up in the module administration page I find this more funny than annoying and it happens only in module admin page. Anyway, think it's and undesirable behaviour and should be addressed, maybe at the block management level. ------------------------------------------------------------------------ Thu, 16 Jun 2005 04:37:45 +0000 : deekayen I verified this in HEAD for the archive module. ------------------------------------------------------------------------ Thu, 11 Aug 2005 20:49:44 +0000 : tostinni This still apply to HEAD, the procedure to reproduce the bug is the right one. However, I don't understand exactly why the block keep appears on this page, and not on the others pages. The problem is that looking at the blocks table, "archive" block stay there even if it doesn't appear on other pages (on module page yes it does). When I enter a new page, saying home, archive block isn't there but is still on the db. The cache is flushed, because archive seems not to appear on the entry giving me the menu, but the current page keep the old cache entry (well I guess). Ok so I proposed a radical way to correct this : rehashing blocks after saving the module configuration. So I just add a _block_rehash(); after the menu_rebuild();, it's a little dirty but do the trick. If you have any suggestion about a better way to do this ;) <?php function system_listing_save($edit = array()) { $op = $_POST['op']; $edit = $_POST['edit']; if ($op == t('Save configuration')) { db_query("UPDATE {system} SET status = 0 WHERE type = '%s'", $edit['type']); foreach ($edit['status'] as $name => $status) { // Make certain that the default theme is enabled to avoid user error if (($edit['type'] == 'theme') && ($edit['theme_default'] == $name)) { $status = 1; } db_query("UPDATE {system} SET status = %d, throttle = %d WHERE type = '%s' AND name = '%s'", $status, $edit['throttle'][$name], $edit['type'], $name); } if ($edit['type'] == 'theme') { variable_set('theme_default', $edit['theme_default']); } menu_rebuild(); _block_rehash(); drupal_set_message(t('The configuration options have been saved.')); drupal_goto($_GET['q']); } } ?>

1 0

[drupal-devel] [bug] Blocks showing up when module disabled
by tostinni 11 Aug '05

11 Aug '05

Issue status update for http://drupal.org/node/13802 Post a follow up: http://drupal.org/project/comments/add/13802 Project: Drupal Version: cvs Component: module system Category: bug reports Priority: minor Assigned to: Anonymous Reported by: Jose A Reyero Updated by: tostinni -Status: active +Status: patch (code needs work) This still apply to HEAD, the procedure to reproduce the bug is the right one. However, I don't understand exactly why the block keep appears on this page, and not on the others pages. The problem is that looking at the blocks table, "archive" block stay there even if it doesn't appear on other pages (on module page yes it does). When I enter a new page, saying home, archive block isn't there but is still on the db. The cache is flushed, because archive seems not to appear on the entry giving me the menu, but the current page keep the old cache entry (well I guess). Ok so I proposed a radical way to correct this : rehashing blocks after saving the module configuration. So I just add a _block_rehash(); after the menu_rebuild();, it's a little dirty but do the trick. If you have any suggestion about a better way to do this ;) <?php function system_listing_save($edit = array()) { $op = $_POST['op']; $edit = $_POST['edit']; if ($op == t('Save configuration')) { db_query("UPDATE {system} SET status = 0 WHERE type = '%s'", $edit['type']); foreach ($edit['status'] as $name => $status) { // Make certain that the default theme is enabled to avoid user error if (($edit['type'] == 'theme') && ($edit['theme_default'] == $name)) { $status = 1; } db_query("UPDATE {system} SET status = %d, throttle = %d WHERE type = '%s' AND name = '%s'", $status, $edit['throttle'][$name], $edit['type'], $name); } if ($edit['type'] == 'theme') { variable_set('theme_default', $edit['theme_default']); } menu_rebuild(); _block_rehash(); drupal_set_message(t('The configuration options have been saved.')); drupal_goto($_GET['q']); } } ?> tostinni Previous comments: ------------------------------------------------------------------------ Thu, 02 Dec 2004 13:19:31 +0000 : Jose A Reyero This only happens in the module administration page. To reproduce this behaviour: 1. enable a module and one block provided by it - I.e. 'archive' module 2. disable the module The block still shows up in the module administration page I find this more funny than annoying and it happens only in module admin page. Anyway, think it's and undesirable behaviour and should be addressed, maybe at the block management level. ------------------------------------------------------------------------ Thu, 16 Jun 2005 04:37:45 +0000 : deekayen I verified this in HEAD for the archive module.

1 0

[drupal-devel] [bug] drupal base and E_NOTICE
by Thomas Ilsche 11 Aug '05

11 Aug '05

Issue status update for http://drupal.org/node/28540 Post a follow up: http://drupal.org/project/comments/add/28540 Project: Drupal Version: 4.6.0 Component: base system Category: bug reports Priority: minor Assigned to: Anonymous Reported by: hlslaughter Updated by: Thomas Ilsche Status: patch (code needs review) About the newlines at eof: Sorry didn't notcied this as phped removed them manually, is there any reason for them, I got them in many drupal files? Maybe worth a fix aswell? Thomas Ilsche Previous comments: ------------------------------------------------------------------------ Tue, 09 Aug 2005 19:19:33 +0000 : hlslaughter ok, instead of whining in the forums, i'll submit a ticket. i'm sure i'm not the first person to bring this up, and i apologize in advance if this issue is already decided/closed. but my issue is this: would it be possible to review the core modules and clean up code to the point that it would be feasible to run drupal with notices turned on (at least in a dev environment)? i think it would be pretty trivial to clean most/all of these errors from the code base. the cost of this effort would be relatively teeny, and the benefits would be great. admins would no longer panic if they happen to see these messages; with an option added to the settings screen, developers could turn on notices and would write cleaner code, which would probably result in fewer bugs in 3rd party modules; etc... you know the routine 8*) after turning on E_NOTICE in common.inc, i see the following notice messages when accessing the homepage of my site: occurences - message ----V--------------V-------- 12 notice: Undefined index: field in /var/www/html/includes/tablesort.inc on line 114. 10 notice: Undefined variable: teaser in /var/www/html/modules/opt/attachment.module on line 37. 6 notice: Undefined variable: count in /var/www/html/modules/opt/attachment.module on line 120. 6 notice: Undefined index: field in /var/www/html/includes/tablesort.inc on line 176. 4 notice: Undefined variable: rows in /var/www/html/modules/opt/attachment.module on line 352. 4 notice: Undefined variable: count in /var/www/html/modules/opt/attachment.module on line 123. 4 notice: Undefined variable: attachments in /var/www/html/modules/opt/attachment.module on line 279. 1 notice: Undefined variable: node in /var/www/html/modules/node.module on line 1950. 1 notice: Undefined offset: 0 in /var/www/html/includes/pager.inc on line 59. 1 notice: Undefined index: op in /var/www/html/modules/node.module on line 1636. 1 notice: Undefined index: node.taxonomy in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: node.picture in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: header.title in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: header.site_slogan in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: header.mission in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: header.help in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: from in /var/www/html/includes/pager.inc on line 53. 1 notice: Undefined index: footer.message in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: footer.blocks in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: edit in /var/www/html/modules/node.module on line 1637. 1 notice: Undefined index: 2 in /var/www/html/modules/filter.module on line 629. 1 notice: Undefined index: in /var/www/html/includes/common.inc on line 506. 1 notice: Trying to get property of non-object in /var/www/html/modules/node.module on line 1950. again, no offense, and sorry if i'm trying to bring a dead horse back to life. ------------------------------------------------------------------------ Tue, 09 Aug 2005 19:22:44 +0000 : killes(a)www.drop.org This is being worked on for the next Drupal version. Please install yourself a test site on cvs and submit individual patches. ------------------------------------------------------------------------ Tue, 09 Aug 2005 19:32:57 +0000 : hlslaughter thanks, i'll do this. i take it patches are just posted here? do i just post a diff -N, title it patch and mark the component appropriately? ------------------------------------------------------------------------ Tue, 09 Aug 2005 19:39:08 +0000 : killes(a)www.drop.org Yes, attach here or create new issue. diff -up is what we usually use. Thanks. ------------------------------------------------------------------------ Tue, 09 Aug 2005 20:24:16 +0000 : hlslaughter Attachment: http://drupal.org/files/issues/test.patch (25.21 KB) attached is results of: harry@penny:~/cvs/third_party/drupal/drupal> diff -Naurp . /var/www/html/drupal_cvs/ > ../test.patch ok, would this type of patch be suitable? it includes fixes for all the E_NOTICE messages generated when accessing the homepage of a new, unmodified drupal installation straight from CVS (as of Aug 9 13:14) ------------------------------------------------------------------------ Tue, 09 Aug 2005 21:01:37 +0000 : killes(a)www.drop.org You are almost there. How to best prepare patches is to run Drupal directly from a cvs checkout. then you can fix the checkout and then run cvs diff -up This way the unrelated files in the patch won't be included. ------------------------------------------------------------------------ Thu, 11 Aug 2005 16:29:12 +0000 : Thomas Ilsche Attachment: http://drupal.org/files/issues/node.user.e_notice.path.txt (1.79 KB) I have a small patch for node.module and user.module that fixes 3 notices in the current HEAD. Please especially have a look at node_access_view_all_nodes, I simply do not get the current use of $node->nid (do I need some more sleep or is this really bogus?)

1 0

[drupal-devel] [bug] drupal base and E_NOTICE
by Thomas Ilsche 11 Aug '05

11 Aug '05

Issue status update for http://drupal.org/node/28540 Post a follow up: http://drupal.org/project/comments/add/28540 Project: Drupal Version: 4.6.0 Component: base system Category: bug reports Priority: minor Assigned to: Anonymous Reported by: hlslaughter Updated by: Thomas Ilsche -Status: patch (code needs work) +Status: patch (code needs review) Attachment: http://drupal.org/files/issues/node.user.e_notice.path.txt (1.79 KB) I have a small patch for node.module and user.module that fixes 3 notices in the current HEAD. Please especially have a look at node_access_view_all_nodes, I simply do not get the current use of $node->nid (do I need some more sleep or is this really bogus?) Thomas Ilsche Previous comments: ------------------------------------------------------------------------ Tue, 09 Aug 2005 19:19:33 +0000 : hlslaughter ok, instead of whining in the forums, i'll submit a ticket. i'm sure i'm not the first person to bring this up, and i apologize in advance if this issue is already decided/closed. but my issue is this: would it be possible to review the core modules and clean up code to the point that it would be feasible to run drupal with notices turned on (at least in a dev environment)? i think it would be pretty trivial to clean most/all of these errors from the code base. the cost of this effort would be relatively teeny, and the benefits would be great. admins would no longer panic if they happen to see these messages; with an option added to the settings screen, developers could turn on notices and would write cleaner code, which would probably result in fewer bugs in 3rd party modules; etc... you know the routine 8*) after turning on E_NOTICE in common.inc, i see the following notice messages when accessing the homepage of my site: occurences - message ----V--------------V-------- 12 notice: Undefined index: field in /var/www/html/includes/tablesort.inc on line 114. 10 notice: Undefined variable: teaser in /var/www/html/modules/opt/attachment.module on line 37. 6 notice: Undefined variable: count in /var/www/html/modules/opt/attachment.module on line 120. 6 notice: Undefined index: field in /var/www/html/includes/tablesort.inc on line 176. 4 notice: Undefined variable: rows in /var/www/html/modules/opt/attachment.module on line 352. 4 notice: Undefined variable: count in /var/www/html/modules/opt/attachment.module on line 123. 4 notice: Undefined variable: attachments in /var/www/html/modules/opt/attachment.module on line 279. 1 notice: Undefined variable: node in /var/www/html/modules/node.module on line 1950. 1 notice: Undefined offset: 0 in /var/www/html/includes/pager.inc on line 59. 1 notice: Undefined index: op in /var/www/html/modules/node.module on line 1636. 1 notice: Undefined index: node.taxonomy in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: node.picture in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: header.title in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: header.site_slogan in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: header.mission in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: header.help in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: from in /var/www/html/includes/pager.inc on line 53. 1 notice: Undefined index: footer.message in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: footer.blocks in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: edit in /var/www/html/modules/node.module on line 1637. 1 notice: Undefined index: 2 in /var/www/html/modules/filter.module on line 629. 1 notice: Undefined index: in /var/www/html/includes/common.inc on line 506. 1 notice: Trying to get property of non-object in /var/www/html/modules/node.module on line 1950. again, no offense, and sorry if i'm trying to bring a dead horse back to life. ------------------------------------------------------------------------ Tue, 09 Aug 2005 19:22:44 +0000 : killes(a)www.drop.org This is being worked on for the next Drupal version. Please install yourself a test site on cvs and submit individual patches. ------------------------------------------------------------------------ Tue, 09 Aug 2005 19:32:57 +0000 : hlslaughter thanks, i'll do this. i take it patches are just posted here? do i just post a diff -N, title it patch and mark the component appropriately? ------------------------------------------------------------------------ Tue, 09 Aug 2005 19:39:08 +0000 : killes(a)www.drop.org Yes, attach here or create new issue. diff -up is what we usually use. Thanks. ------------------------------------------------------------------------ Tue, 09 Aug 2005 20:24:16 +0000 : hlslaughter Attachment: http://drupal.org/files/issues/test.patch (25.21 KB) attached is results of: harry@penny:~/cvs/third_party/drupal/drupal> diff -Naurp . /var/www/html/drupal_cvs/ > ../test.patch ok, would this type of patch be suitable? it includes fixes for all the E_NOTICE messages generated when accessing the homepage of a new, unmodified drupal installation straight from CVS (as of Aug 9 13:14) ------------------------------------------------------------------------ Tue, 09 Aug 2005 21:01:37 +0000 : killes(a)www.drop.org You are almost there. How to best prepare patches is to run Drupal directly from a cvs checkout. then you can fix the checkout and then run cvs diff -up This way the unrelated files in the patch won't be included.

1 0

Re: [drupal-devel] More profiling code - the server this time
by Mike Gifford 11 Aug '05

11 Aug '05

Hi John, John VanDyk <jvandyk(a)iastate.edu> wrote: > Mike, I am very interested in having a benchmarking suite for Drupal. > I'd like to get metrics to see how various code changes affect > performance characteristics. Like the idea of a benchmarking suite. The code I posted would only look at benchmarking the servers though. The server code could sit nicely as a stand alone module I think. However, the module memory profiling code I sent to the list earlier would certainly be part of the benchmarking module I would think. You'd also want to have ways to patch in the profiling code into key places in the core code... Again you'd want to extend that to look at timing issues, so the script timing class I suggested might also come in handy (unless there is a standard drupal way to measure execution time). Mike -- Mike Gifford, OpenConcept Consulting Free Software for Social Change -> http://www.openconcept.ca Latest launch Canadian Labour Congress / Congrès du travail du Canada http://canadianlabour.ca / http://congresdutravail.ca

1 0

[drupal-devel] Re: More profiling code - the server this time
by Mike Gifford 11 Aug '05

11 Aug '05

Hi Robert, Robert Douglass <rob(a)robshouse.net> wrote: > I'd be pretty interested in seeing this code and would love to help > you > port it to Drupal. If you don't want to wait for CVS access we > could put > it in my sandbox. It's not a lot of code so I've just pasted it in here. No problems with you putting it up in your sandbox. I'm still new to drupal so hints on locations for a temp directory where this could be written, the cache table is probably be used. Also, is there is an existing script timer tool built in. I can send along the class that this script uses if there isn't one built in. Also, the values I put in for the base number of cycles were designed so that they would take about a second on an old machine. A shorter number of cycles made it harder to judge the relative speed and more cycles caused the problems on really slow servers. /* Do some really simple math a bunch of times */ function profileProcessorSpeed($max = 1000) { // for ($i=0 ; $i < $max ; ++$i) { $bigArray[] = 3 * $i; } foreach($bigArray AS $bigItem) { $value = $bigItem / 2; } // echo "$value end"; } /* Read/Write a bunch of files to a temp directory */ function profileDiskSpeed($max = 400) { global $_PSL, $scriptTimer; $contents = $handle = null; $dir = $_PSL['basedir'] . '/updir/fileCache/'; $scriptTimer->start('diskSpeed'); for ($i=0 ; $i < $max ; ++$i) { if ($scriptTimer->get_current('diskSpeed') > 30) { echo "Script Interrupted, $i disk cycles completed"; return $i; break; } $filename = $dir . 'testFile_' . $i . '.txt'; $somecontent = "Add this to the file $i \n"; // Let's make sure the directory is writable first. if (is_writable($dir)) { // Open file if (!$handle = fopen($filename, 'a')) { echo "Cannot open file ($filename)"; exit; } // Write $somecontent to our opened file. if (fwrite($handle, $somecontent) === FALSE) { echo "Cannot write to file ($filename)"; exit; } fclose($handle); // Read contents $handle = fopen($filename, 'r'); $contents .= fread($handle, filesize($filename)); fclose($handle); unlink($filename); } else { echo "The directory $dir is not writable"; } } return null; } /* Insert/Update/Delete a bunch of files into a cache table */ function profileDBaccess($max = 400) { global $_PSL, $scriptTimer; $contents = null; $db = pslNew('BEDB'); $scriptTimer->start('dbSpeed'); for ($i=0 ; $i < $max ; ++$i) { if ($scriptTimer->get_current('dbSpeed') > 30) { echo "Script Interrupted, $i database cycles completed"; return $i; break; } $j = $i + 30000; $query = "SELECT value FROM psl_variable WHERE variable_id = '$j'"; $db->query($query); while ($db->next_record()) { if ($db->Record['value']) { $query = "DELETE FROM psl_variable WHERE variable_id = '$j'"; $db->query($query); } } $query = "INSERT INTO psl_variable (variable_id, value, variable_name) VALUES ('$j', 'Inserted Value $j', 'Test$j')"; $db->query($query); $query = "UPDATE psl_variable SET value = 'Updated Value $j' WHERE variable_id = '$j'"; $db->query($query); $query = "SELECT value FROM psl_variable WHERE variable_id = '$j'"; $db->query($query); if ($db->next_record()) { $contents .= $db->Record['value']; } $query = "DELETE FROM psl_variable WHERE variable_id = '$j'"; $db->query($query); } return null; } // Start log content $content = '<p>' . date("D M j G:i:s T Y") . ' - '; $scriptTimer->start('profile'); $processorCycles = 10000; profileProcessorSpeed($processorCycles); $processorSpeed = $scriptTimer->get_current('profile'); $content .= "Processor Speed ($processorCycles Cycles): $processorSpeed - "; $fileCycles = 400; $diskCycleResults = profileDiskSpeed($fileCycles); $diskCycleResults = (!empty($diskCycleResults)) ? $diskCycleResults : $fileCycles; $diskSpeed = $scriptTimer->get_current('profile') - $processorSpeed; $content .= "Disk Speed ($diskCycleResults Cycles): $diskSpeed - "; $dbCycles = 250; $dbCycleResults = profileDBaccess($dbCycles); $dbCycleResults = (!empty($dbCycleResults)) ? $dbCycleResults : $dbCycles; $dbSpeed = $scriptTimer->get_current('profile') - $processorSpeed - $diskSpeed; $content .= "DB Speed ($dbCycleResults Cycles): $dbSpeed </p>\n"; $dir = $_PSL['basedir'] . '/updir/fileCache'; $filenameLog = $dir . '/profileLog.txt'; $filenameAverage = $dir . '/profileAverage.txt'; // Read contents of log if (is_readable($filenameLog)) { $handle = fopen($filenameLog, 'r'); $contents .= fread($handle, filesize($filenameLog)); fclose($handle); } // Write log if (!$handle = fopen($filenameLog, 'a')) { echo "Cannot open file ($filenameLog)"; exit; } if (fwrite($handle, $content) === FALSE) { echo "Cannot write to file ($filenameLog)"; exit; } fclose($handle); // Read contents of log if (is_readable($filenameAverage)) { $handle = fopen($filenameAverage, 'r'); $values = unserialize(fread($handle, filesize ($filenameAverage))); fclose($handle); $count = $values['count'] + 1; $processor = (($values['processor'] * $values['count']) + $processorSpeed) / $count; $disk = (($values['disk'] * $values['count']) + $diskSpeed) / $count; $database = (($values['database'] * $values['count']) + $dbSpeed) / $count; } else { $count = 1; $processor = $processorSpeed; $disk = $diskSpeed; $database = $dbSpeed; } $average = "<p>Count $count - Processor Speed (100000 Cycles): $processor - Disk Speed (400 Cycles): $disk - DB Speed (250 Cycles): $database </p>"; // Write log $value = serialize(array('count' => $count, 'processor' => $processor, 'disk' => $disk, 'database' => $database)); if (!$handle = fopen($filenameAverage, 'w')) { echo "Cannot open file ($filenameAverage)"; exit; } if (fwrite($handle, $value) === FALSE) { echo "Cannot write to file ($filenameAverage)"; exit; } fclose($handle); echo "<h1>Last Results</h1> $content <h1>Average Results</h1> $average <h1>All Results</h1> $contents "; Feel free to enhance any of this. Would be neat to see it as a drupal module. Mike -- Mike Gifford, OpenConcept Consulting Free Software for Social Change -> http://www.openconcept.ca Latest launch Canadian Labour Congress / Congrès du travail du Canada http://canadianlabour.ca / http://congresdutravail.ca

2 2

[drupal-devel] [feature] Parse atom feeds
by Prometheus6 11 Aug '05

11 Aug '05

Issue status update for http://drupal.org/node/13941 Post a follow up: http://drupal.org/project/comments/add/13941 Project: Drupal Version: cvs Component: aggregator.module Category: feature requests Priority: normal Assigned to: Prometheus6 Reported by: Capnj Updated by: Prometheus6 Status: patch (code needs review) Okay. Just to let you know, I added the blog it link because of this conversation. http://drupal.org/node/10752 I'll make a patch tonight just for the blog it feature, so this item can be closed if you like. Prometheus6 Previous comments: ------------------------------------------------------------------------ Sun, 05 Dec 2004 23:26:00 +0000 : Capnj I've seen mention elsewhere on drupal.org but don't see a feature request, so here goes. The news aggregator is a great piece of Drupal as far as I'm concerned and I'd sure like to see it read all the sources out there, have the 'blog this' function, and also have a tool for browsers to generate a blog entry from a web page (like MT had). Is that a big enough request? LOL Thanks for all that everyone does here. Great stuff! gil ------------------------------------------------------------------------ Tue, 07 Dec 2004 17:38:31 +0000 : drumm RSS 2.0 feeds should work in 4.5.0 and earlier. ------------------------------------------------------------------------ Mon, 14 Feb 2005 16:04:32 +0000 : georgehotelling I've hacked Magpie [1] support into the Drupal aggregator, so it can support Atom. If you have a Drupal site and want the code, you can get it from http://george.hotelling.net/projects/magpie-aggregator-4.5.2.tgz [2] I'm not sure if I'm supposed to create a patch or what, but I needed this for ArborBlogs.com [3] and figured some other people would benefit from it. [1] http://magpierss.sourceforge.net/ [2] http://george.hotelling.net/projects/magpie-aggregator-4.5.2.tgz [3] http://www.arborblogs.com/ ------------------------------------------------------------------------ Tue, 15 Mar 2005 04:04:42 +0000 : Prometheus6 Attachment: http://drupal.org/files/issues/AGGREGATOR_ATOM_HEAD.txt (5.46 KB) Very nice. I hacked aggregator.module for 4.6 using your module as a guide...well, frankly by ripping out great chunks of code for my use. ------------------------------------------------------------------------ Thu, 28 Jul 2005 22:21:11 +0000 : Boris Mann Can someone roll a patch for this? Would be a good addition for 4.7 now that Atom is at 1.0. ------------------------------------------------------------------------ Fri, 29 Jul 2005 01:49:42 +0000 : Prometheus6 Attachment: http://drupal.org/files/issues/magpie_aggregator.zip (7.87 KB) A patch would require the Magpie include files and wholly restructures the way the feeds are parsed...the Magpie code would handle all the feeds, not just Atom. That said, the attached zip file has the necessary includes and a patch to CVS. ------------------------------------------------------------------------ Fri, 29 Jul 2005 03:36:59 +0000 : Steven Magpie RSS duplicates a lot of functionality that is already in Drupal. We decided a long time ago that we would not use it. Porting Atom parsing into the current aggregator can't be that hard. ------------------------------------------------------------------------ Mon, 01 Aug 2005 16:38:53 +0000 : Prometheus6 Attachment: http://drupal.org/files/issues/AGGREGATOR_ATOM_HEAD_0.txt (1.93 KB) Since I'm messing around with the aggregator module anyway... I developed this around Atom 0.3 feeds this weekend, but I don't see anything in Atom 1.0 that should break it. ------------------------------------------------------------------------ Tue, 02 Aug 2005 15:00:50 +0000 : Eaton +1 on that patch. Running it now on my test site and everything looks great. ------------------------------------------------------------------------ Tue, 02 Aug 2005 16:24:54 +0000 : Bèr Kessels a small issue, whe do not use if ($data) $items[$item][$tag] .= $data; please just use if ($data) { $items[$item][$tag] .= $data; } ------------------------------------------------------------------------ Wed, 03 Aug 2005 02:18:54 +0000 : Prometheus6 Attachment: http://drupal.org/files/issues/AGGREGATOR_ATOM_HEAD_1.txt (1.99 KB) Not a problem. Here's the corrections. ------------------------------------------------------------------------ Wed, 03 Aug 2005 16:14:14 +0000 : Dries If this is all it takes to parse Atom feeds (to some extend), I'm all for it. Code looks OK. Set to 'ready to be committed' after some testing. ------------------------------------------------------------------------ Wed, 03 Aug 2005 18:59:20 +0000 : kika anybody up for a testing suite tests? http://intertwingly.net/wiki/pie/FormatTests ------------------------------------------------------------------------ Wed, 03 Aug 2005 20:07:37 +0000 : Prometheus6 That would be for the Atom module. ------------------------------------------------------------------------ Wed, 03 Aug 2005 23:36:04 +0000 : Prometheus6 Attachment: http://drupal.org/files/issues/AGGREGATOR_ATOM_CVS.txt (2.35 KB) Because the aggregator would always gather enough information todownload an Atom feed, the previous patch focused on parsing items/entries correctly. This patch adds more complete parsing of the feed's channel data (site link, subtitle/description, logo). Now all the feed and item fields will be properly updated. ------------------------------------------------------------------------ Mon, 08 Aug 2005 16:00:22 +0000 : Prometheus6 The content of the Atom feed's id and info tags were being displayed as part of the feed's description on the aggregator pages. With this patch those tags are recognized and discarded. The "blog it" link is also added to the aggregator page items in addition to the block. ------------------------------------------------------------------------ Mon, 08 Aug 2005 16:01:55 +0000 : Prometheus6 Attachment: http://drupal.org/files/issues/AGGREGATOR_ATOM_CVS_0.txt (3.69 KB) Let's try that with the patch this time... ------------------------------------------------------------------------ Thu, 11 Aug 2005 13:13:34 +0000 : Dries Committed a partial patch. Left out the 'blog it' stuff for now but committed the parsing part. The 'blog it' stuff needs more review and testing.

1 0

[drupal-devel] [bug] _db_query() does not return FALSE in case of errors, as stated in documentation
by Cvbge 11 Aug '05

11 Aug '05

Issue status update for http://drupal.org/node/25522 Project: Drupal Version: cvs Component: database system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Cvbge Updated by: Cvbge Status: patch Attachment: http://drupal.org/files/issues/database.mysql.inc.diff (318 bytes) According to documentation db_query() should return FALSE "if the query was not executed correctly". This function calls _db_query() which returns nothing in such cases (for example when the sql syntax is wrong). Attached one-liner fixes this by adding return FALSE to _db_query(). It's from 4.6.1 but should apply to cvs without problems. Please apply this patch also to 4.6 branch. But there seems to be a problem with db_error(). It calls mysql_errno() but it seems that errors are cleared after mysql_error() call. So db_error() does not indicate any errors even if they occur. Cvbge

2 5