- Development - lists.drupal.org

[drupal-devel] [task] Display referer with "page not found" warnings
by ahoeben 28 Jul '05

28 Jul '05

Issue status update for http://drupal.org/node/23651 Post a follow up: http://drupal.org/project/comments/add/23651 Project: Drupal Version: cvs Component: watchdog.module Category: tasks Priority: normal Assigned to: Anonymous Reported by: Thox Updated by: ahoeben Status: patch Attachment: http://drupal.org/files/issues/watchdog-referrer-cvs.patch (3.14 KB) New patch against CVS. Includes stefan's patch for updates.inc (thanks) and adds database.mysql and database.pgsql ahoeben Previous comments: ------------------------------------------------------------------------ Thu, 26 May 2005 11:05:16 +0000 : Thox I get plenty of "page not found" warnings when I look at the admin page, but I have no way to fix them. The pages (rightfully) no longer exist, so I'd simply like to stop links pointing there. If the referering page was part of the message, that would be far more helpful. ------------------------------------------------------------------------ Tue, 26 Jul 2005 07:52:54 +0000 : ahoeben Referer / referrer loggin would be usefull for a more than just page not found warnings. I'ld say include them where available. ------------------------------------------------------------------------ Tue, 26 Jul 2005 09:20:13 +0000 : ahoeben This requires minor changes in bootstrap.inc (watchdog() function), the watchdog module, as well as an alteration to the watchdog table. I'll try to make a patch ------------------------------------------------------------------------ Wed, 27 Jul 2005 21:06:52 +0000 : ahoeben Attachment: http://drupal.org/files/issues/watchdog-referrer.patch (1.6 KB) Here's the patch against 4.6.2. First, you need to execute this SQL statement to alter the watchdog table: ALTER TABLE `watchdog` ADD COLUMN `referer` varchar (128) NOT NULL Next, the patch includes two one-line changes, one each for includes/bootstrap.inc and modules/watchdog.module (you may have to split up the patch file and run them one by one or manually) ------------------------------------------------------------------------ Wed, 27 Jul 2005 21:23:07 +0000 : drumm +1 for this functionality, but it needs to be a patch against Drupal CVS. ------------------------------------------------------------------------ Thu, 28 Jul 2005 07:25:47 +0000 : kbahey +1 on functionality too. ------------------------------------------------------------------------ Thu, 28 Jul 2005 08:23:30 +0000 : Bèr Kessels +1 on the idea. But this really needs a patch for update.php and database.* marking this "active" untill that is in place. ------------------------------------------------------------------------ Thu, 28 Jul 2005 08:45:13 +0000 : stefan nagtegaal Attachment: http://drupal.org/files/issues/watchdog-referer.patch (3.14 KB) Okay I updated the patch to apply against HEAD. I also updated the update.inc to reflect the changes.. Please update the patch or apply.. I do not have time to keep this patch up-to-date. ------------------------------------------------------------------------ Thu, 28 Jul 2005 08:46:40 +0000 : stefan nagtegaal Status -> 'Patch', Version -> 'CVS'.. I updated the patch to work with current HEAD. Please apply or pdate yourself. I do not have time to keep this patch up-to-date.. Sorry

1 0

[drupal-devel] [task] Style update.php
by drumm 28 Jul '05

28 Jul '05

Issue status update for http://drupal.org/node/27635 Post a follow up: http://drupal.org/project/comments/add/27635 Project: Drupal Version: cvs Component: base system Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/update_maintenance.diff (12.46 KB) This patch makes update.php look an order of magnitude better and the HTML actually validates. The inside of the pages stays the same, patches to do the real UI work will be coming one page at a time. The one content change is the "All" option for updates is removed because no one in their right mind should ever run every update since June 2002 and people who are new to updating Drupal might mistake "All" for something that they want. drumm

2 1

[drupal-devel] [task] Display referer with "page not found" warnings
by stefan nagtegaal 28 Jul '05

28 Jul '05

Issue status update for http://drupal.org/node/23651 Post a follow up: http://drupal.org/project/comments/add/23651 Project: Drupal -Version: 4.6.2 +Version: cvs Component: watchdog.module Category: tasks Priority: normal Assigned to: Anonymous Reported by: Thox Updated by: stefan nagtegaal -Status: active +Status: patch Status -> 'Patch', Version -> 'CVS'.. I updated the patch to work with current HEAD. Please apply or pdate yourself. I do not have time to keep this patch up-to-date.. Sorry stefan nagtegaal Previous comments: ------------------------------------------------------------------------ Thu, 26 May 2005 11:05:16 +0000 : Thox I get plenty of "page not found" warnings when I look at the admin page, but I have no way to fix them. The pages (rightfully) no longer exist, so I'd simply like to stop links pointing there. If the referering page was part of the message, that would be far more helpful. ------------------------------------------------------------------------ Tue, 26 Jul 2005 07:52:54 +0000 : ahoeben Referer / referrer loggin would be usefull for a more than just page not found warnings. I'ld say include them where available. ------------------------------------------------------------------------ Tue, 26 Jul 2005 09:20:13 +0000 : ahoeben This requires minor changes in bootstrap.inc (watchdog() function), the watchdog module, as well as an alteration to the watchdog table. I'll try to make a patch ------------------------------------------------------------------------ Wed, 27 Jul 2005 21:06:52 +0000 : ahoeben Attachment: http://drupal.org/files/issues/watchdog-referrer.patch (1.6 KB) Here's the patch against 4.6.2. First, you need to execute this SQL statement to alter the watchdog table: ALTER TABLE `watchdog` ADD COLUMN `referer` varchar (128) NOT NULL Next, the patch includes two one-line changes, one each for includes/bootstrap.inc and modules/watchdog.module (you may have to split up the patch file and run them one by one or manually) ------------------------------------------------------------------------ Wed, 27 Jul 2005 21:23:07 +0000 : drumm +1 for this functionality, but it needs to be a patch against Drupal CVS. ------------------------------------------------------------------------ Thu, 28 Jul 2005 07:25:47 +0000 : kbahey +1 on functionality too. ------------------------------------------------------------------------ Thu, 28 Jul 2005 08:23:30 +0000 : Bèr Kessels +1 on the idea. But this really needs a patch for update.php and database.* marking this "active" untill that is in place. ------------------------------------------------------------------------ Thu, 28 Jul 2005 08:45:13 +0000 : stefan nagtegaal Attachment: http://drupal.org/files/issues/watchdog-referer.patch (3.14 KB) Okay I updated the patch to apply against HEAD. I also updated the update.inc to reflect the changes.. Please update the patch or apply.. I do not have time to keep this patch up-to-date.

1 0

[drupal-devel] [bug] node_search doesn't node_view, causing bad snippets.
by Bèr Kessels 28 Jul '05

28 Jul '05

Issue status update for http://drupal.org/node/26458 Post a follow up: http://drupal.org/project/comments/add/26458 Project: Drupal Version: cvs Component: node.module Category: bug reports Priority: normal Assigned to: Morbus Iff Reported by: Morbus Iff Updated by: Bèr Kessels Status: patch Just a thought: node_view can be extremely dynamic. so the search index might get overrun with odd or even non-existing entries. Also: potentially, a node_view can return entries based on the role/permission. parts of a body can be hidden away for certain users. This patch will break that behaviour too. I beleive that the search system needs some renewed thought, to overcome such issues. Bèr Kessels Previous comments: ------------------------------------------------------------------------ Wed, 06 Jul 2005 15:08:32 +0000 : Morbus Iff Attachment: http://drupal.org/files/issues/_p_nodesearch.patch (1010 bytes) During search indexing, the node.module invokes node_view and node view api before indexing it for content (see node_update_index). This, however, doesn't happen on node_search, which assumes that the body exists to get a snippet from. This causes an empty snippet on flexinode nodes, or anything else that requires a node view api. This patch simply adds the same block from node_update_index to node_search. ------------------------------------------------------------------------ Tue, 19 Jul 2005 14:16:50 +0000 : Morbus Iff Attachment: http://drupal.org/files/issues/_p_26458_nodesearch.patch (996 bytes) Updated for HEAD. ------------------------------------------------------------------------ Wed, 27 Jul 2005 20:40:06 +0000 : chx The patch applies, does what is described and it is needed. +1

1 0

[drupal-devel] Google Sitemap
by Gordon Heydon 28 Jul '05

28 Jul '05

Hi, I have been taking a look at the Google Sitemap module for a client and I am wanting to know a couple of things. I know that it is being written as apart of the Google Summer of Code, and was wondering how stable it is? Also updating of google? is it automatic after the first manual upload or do we have to upload everytime. Thanks. Gordon.

3 4

[drupal-devel] [task] Display referer with "page not found" warnings
by kbahey 28 Jul '05

28 Jul '05

Issue status update for http://drupal.org/node/23651 Post a follow up: http://drupal.org/project/comments/add/23651 Project: Drupal Version: 4.6.2 Component: watchdog.module Category: tasks Priority: normal Assigned to: Anonymous Reported by: Thox Updated by: kbahey Status: patch +1 on functionality too. kbahey Previous comments: ------------------------------------------------------------------------ Thu, 26 May 2005 11:05:16 +0000 : Thox I get plenty of "page not found" warnings when I look at the admin page, but I have no way to fix them. The pages (rightfully) no longer exist, so I'd simply like to stop links pointing there. If the referering page was part of the message, that would be far more helpful. ------------------------------------------------------------------------ Tue, 26 Jul 2005 07:52:54 +0000 : ahoeben Referer / referrer loggin would be usefull for a more than just page not found warnings. I'ld say include them where available. ------------------------------------------------------------------------ Tue, 26 Jul 2005 09:20:13 +0000 : ahoeben This requires minor changes in bootstrap.inc (watchdog() function), the watchdog module, as well as an alteration to the watchdog table. I'll try to make a patch ------------------------------------------------------------------------ Wed, 27 Jul 2005 21:06:52 +0000 : ahoeben Attachment: http://drupal.org/files/issues/watchdog-referrer.patch (1.6 KB) Here's the patch against 4.6.2. First, you need to execute this SQL statement to alter the watchdog table: ALTER TABLE `watchdog` ADD COLUMN `referer` varchar (128) NOT NULL Next, the patch includes two one-line changes, one each for includes/bootstrap.inc and modules/watchdog.module (you may have to split up the patch file and run them one by one or manually) ------------------------------------------------------------------------ Wed, 27 Jul 2005 21:23:07 +0000 : drumm +1 for this functionality, but it needs to be a patch against Drupal CVS.

1 0

[drupal-devel] [feature] Pass include and exclude parameters to cron.php for fine grained cron timing
by kbahey 28 Jul '05

28 Jul '05

Issue status update for http://drupal.org/node/19173 Post a follow up: http://drupal.org/project/comments/add/19173 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: robertDouglass Updated by: kbahey Status: patch +1 on an include/exclude mechanism. However, I am not sure that having it in the URL is a good idea. This could expose things that we may not want exposed in the future. Anyone on the net can run your stuff more frequently than you want to. what I would like to see is a cron settings page with all the modules that have a cron hook listed, and a frequency that can be changed. cron.php can then check that setting per module and decide to run it or not. Something along those lines would be better than URL based solutions which requires many entries in crontab, and may open exploits. kbahey Previous comments: ------------------------------------------------------------------------ Sun, 20 Mar 2005 10:08:59 +0000 : robertDouglass Attachment: http://drupal.org/files/issues/cronpatch.txt (1.99 KB) Some sites need fine grained timing for cron runs. For example, a site that relies heavily on moblogging, mailhandler or any other email based function would want to connect with the email server pretty often, say ever 2-5 minutes. On another site I'm working on we generate flat files for all of a certain node type on a regular basis, though not every 2-5 minutes. Thus the need for cron tasks on different schedules. This patch allows you to make a list of modules to either include or exclude when running cron, so that several cron tasks for one site can be defined. The default behavior in the absence of both parameters is to run all, so the patch preserves backwards compatibility. * Examples: * * runs all hooks * http://mysite.com/cron.php * * runs all hooks except the search and aggregator modules * http://mysite.com/cron.php?exclude=search,aggregator * * runs only search, archive and aggregator modules * http://mysite.com/cron.php?includ=search,archive,aggregator ------------------------------------------------------------------------ Wed, 23 Mar 2005 21:23:59 +0000 : Dries Isn't it possible to run all cron functions every 2-5 minutes? The impact of that should be minimal. ------------------------------------------------------------------------ Wed, 23 Mar 2005 21:33:06 +0000 : moshe weitzman an alternative approach is to make a quick PHP page which simply calls mailhandler_cron and any others that need to be called more frequently than normal. then call that php page from cron every couple minutes ... not so sure this complexity is worth having. ------------------------------------------------------------------------ Thu, 24 Mar 2005 07:32:32 +0000 : robertDouglass Whether or not this "complexity" is needed depends a lot on what you expect to do with cron. As soon as one starts aggregating not tens but several hundred RSS feeds or more, it is impossible to run cron every 2 minutes. Yet if the site depends on mailhandler keeping user moblog submissions current, 2 minutes is already about the maximum latency time acceptable. Thus the need for crons on different schedules. In terms of usage, writing ?include=mailhandler,search,event isn't so complex. On the code level, splitting that list on comma and looping over the resultant array also isn't really that complex. The patch defaults to normal behavior for people who don't need the feature, and I've seen more than one site that had to solve this problem. ------------------------------------------------------------------------ Thu, 24 Mar 2005 10:48:09 +0000 : Robert Castelo Could different cron runs be set to run different tasks based on a cron ID number.... For instance, set up 3 separate cron to run every hour, each one calls the cron.php page including a number variable which runs a certain set of tasks. An Admin control panel would list all cron tasks and allow administrators to split them into separate cron runs based on the number variable passed to the script when calling cron.php. ------------------------------------------------------------------------ Thu, 24 Mar 2005 11:24:53 +0000 : robertDouglass Robert, the id parameter is already a practical necessity for this patch if cron_busy is to be effective. I'm open to suggestions as to how we would track various cron tasks and whether they are busy. First things first, though: does anyone except me need this? I'm not going to program an admin-configurable cron mechanism unless there is demand for it. Furthermore, such a system would really be incomplete unless there were some actual mechanism for setting these cron runs up from the admin interface as well. This wouldn't be such a bad idea, I know a lot of people who still type /cron.php into their browser every day or so to updated thier sites (yes I've mentioned poormanscron). Anyway, first reactions to this patch have been cold, so maybe nobody wants it. ------------------------------------------------------------------------ Thu, 24 Mar 2005 11:39:13 +0000 : Robert Castelo +1 from me. I'll be needing something like this once my email newsletter is released and starts hogging cron runs. ------------------------------------------------------------------------ Thu, 24 Mar 2005 16:06:31 +0000 : Chris Johnson It does seem like a good idea to allow running different cron tasks at different intervals, so as to be efficient and reduce web server loads. There is little point in running tasks that do not need to be run. Many cron tasks only need to be run once to a few times per day. Note also that cron job scheduling on most Unix-variants is only within a +/- 1 minute range, so trying to run a cron program every 2 minutes is approaching the crumbling edge of being "on time." ------------------------------------------------------------------------ Thu, 24 Mar 2005 16:37:39 +0000 : robertDouglass I think I am leaning in favor of extending cron.php in the following way: 1) Add admin screen which scans all modules for existence of cron hook 2) set a cron_interval variable for each one 3) allow admin to set an interval 4) check whether the current cron run falls outside of each module's interval before invoking its cron hook 5) before a module's cron hook gets called a {module_name}_cron_busy variable gets set. This would function like the current cron_busy now, just at a modular level. The admin would then set one cron tab to run at the smallest needed interval and could then decide on a module-by-module basis how often each is to run. How does this sound to people? ------------------------------------------------------------------------ Wed, 27 Jul 2005 16:18:23 +0000 : Bèr Kessels -1 on this one. I think the hook_cron should carry the logic whether or not it wants to be ran. Maybe aintroduce an API that allows theis checkto be done easier? drupal_elapsed_run($name, interval) that will check when $name was last updated, if it was longer then $interval ago, return TRUE, and update the last run of $name. ------------------------------------------------------------------------ Wed, 27 Jul 2005 21:32:29 +0000 : robertDouglass Bèr, how can you adjust the interval then? If it is hardcoded how often the cron should run, administrators loose all control and you can't have different sites have different schedules, unless of course you have cron configuration in the interface itself. I think cron scheduling should be completely done with the cron tool itself, and that the URL or command that is given should be able to handle the fine tuning of which module's hooks get called. ------------------------------------------------------------------------ Thu, 28 Jul 2005 05:53:15 +0000 : clydefrog When I last used aggregator (which was probably back in the 4.4 days), it let me set a refresh interval for each feed. Is this no longer the case? Note I have nothing against this patch. It sounds like a good general solution for removing calls to hooks that are resource-heavy every time they run but still allowing some other hooks to be run more often. However, I also like Ber's idea of a convenience function to make delays easier to measure. ------------------------------------------------------------------------ Thu, 28 Jul 2005 07:01:00 +0000 : Uwe Hermann +1 for the include/exclude feature, I'd use this on multiple sites... Uwe.

1 0

[drupal-devel] [feature] Pass include and exclude parameters to cron.php for fine grained cron timing
by Uwe Hermann 28 Jul '05

28 Jul '05

Issue status update for http://drupal.org/node/19173 Post a follow up: http://drupal.org/project/comments/add/19173 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: robertDouglass Updated by: Uwe Hermann Status: patch +1 for the include/exclude feature, I'd use this on multiple sites... Uwe. Uwe Hermann Previous comments: ------------------------------------------------------------------------ Sun, 20 Mar 2005 10:08:59 +0000 : robertDouglass Attachment: http://drupal.org/files/issues/cronpatch.txt (1.99 KB) Some sites need fine grained timing for cron runs. For example, a site that relies heavily on moblogging, mailhandler or any other email based function would want to connect with the email server pretty often, say ever 2-5 minutes. On another site I'm working on we generate flat files for all of a certain node type on a regular basis, though not every 2-5 minutes. Thus the need for cron tasks on different schedules. This patch allows you to make a list of modules to either include or exclude when running cron, so that several cron tasks for one site can be defined. The default behavior in the absence of both parameters is to run all, so the patch preserves backwards compatibility. * Examples: * * runs all hooks * http://mysite.com/cron.php * * runs all hooks except the search and aggregator modules * http://mysite.com/cron.php?exclude=search,aggregator * * runs only search, archive and aggregator modules * http://mysite.com/cron.php?includ=search,archive,aggregator ------------------------------------------------------------------------ Wed, 23 Mar 2005 21:23:59 +0000 : Dries Isn't it possible to run all cron functions every 2-5 minutes? The impact of that should be minimal. ------------------------------------------------------------------------ Wed, 23 Mar 2005 21:33:06 +0000 : moshe weitzman an alternative approach is to make a quick PHP page which simply calls mailhandler_cron and any others that need to be called more frequently than normal. then call that php page from cron every couple minutes ... not so sure this complexity is worth having. ------------------------------------------------------------------------ Thu, 24 Mar 2005 07:32:32 +0000 : robertDouglass Whether or not this "complexity" is needed depends a lot on what you expect to do with cron. As soon as one starts aggregating not tens but several hundred RSS feeds or more, it is impossible to run cron every 2 minutes. Yet if the site depends on mailhandler keeping user moblog submissions current, 2 minutes is already about the maximum latency time acceptable. Thus the need for crons on different schedules. In terms of usage, writing ?include=mailhandler,search,event isn't so complex. On the code level, splitting that list on comma and looping over the resultant array also isn't really that complex. The patch defaults to normal behavior for people who don't need the feature, and I've seen more than one site that had to solve this problem. ------------------------------------------------------------------------ Thu, 24 Mar 2005 10:48:09 +0000 : Robert Castelo Could different cron runs be set to run different tasks based on a cron ID number.... For instance, set up 3 separate cron to run every hour, each one calls the cron.php page including a number variable which runs a certain set of tasks. An Admin control panel would list all cron tasks and allow administrators to split them into separate cron runs based on the number variable passed to the script when calling cron.php. ------------------------------------------------------------------------ Thu, 24 Mar 2005 11:24:53 +0000 : robertDouglass Robert, the id parameter is already a practical necessity for this patch if cron_busy is to be effective. I'm open to suggestions as to how we would track various cron tasks and whether they are busy. First things first, though: does anyone except me need this? I'm not going to program an admin-configurable cron mechanism unless there is demand for it. Furthermore, such a system would really be incomplete unless there were some actual mechanism for setting these cron runs up from the admin interface as well. This wouldn't be such a bad idea, I know a lot of people who still type /cron.php into their browser every day or so to updated thier sites (yes I've mentioned poormanscron). Anyway, first reactions to this patch have been cold, so maybe nobody wants it. ------------------------------------------------------------------------ Thu, 24 Mar 2005 11:39:13 +0000 : Robert Castelo +1 from me. I'll be needing something like this once my email newsletter is released and starts hogging cron runs. ------------------------------------------------------------------------ Thu, 24 Mar 2005 16:06:31 +0000 : Chris Johnson It does seem like a good idea to allow running different cron tasks at different intervals, so as to be efficient and reduce web server loads. There is little point in running tasks that do not need to be run. Many cron tasks only need to be run once to a few times per day. Note also that cron job scheduling on most Unix-variants is only within a +/- 1 minute range, so trying to run a cron program every 2 minutes is approaching the crumbling edge of being "on time." ------------------------------------------------------------------------ Thu, 24 Mar 2005 16:37:39 +0000 : robertDouglass I think I am leaning in favor of extending cron.php in the following way: 1) Add admin screen which scans all modules for existence of cron hook 2) set a cron_interval variable for each one 3) allow admin to set an interval 4) check whether the current cron run falls outside of each module's interval before invoking its cron hook 5) before a module's cron hook gets called a {module_name}_cron_busy variable gets set. This would function like the current cron_busy now, just at a modular level. The admin would then set one cron tab to run at the smallest needed interval and could then decide on a module-by-module basis how often each is to run. How does this sound to people? ------------------------------------------------------------------------ Wed, 27 Jul 2005 16:18:23 +0000 : Bèr Kessels -1 on this one. I think the hook_cron should carry the logic whether or not it wants to be ran. Maybe aintroduce an API that allows theis checkto be done easier? drupal_elapsed_run($name, interval) that will check when $name was last updated, if it was longer then $interval ago, return TRUE, and update the last run of $name. ------------------------------------------------------------------------ Wed, 27 Jul 2005 21:32:29 +0000 : robertDouglass Bèr, how can you adjust the interval then? If it is hardcoded how often the cron should run, administrators loose all control and you can't have different sites have different schedules, unless of course you have cron configuration in the interface itself. I think cron scheduling should be completely done with the cron tool itself, and that the URL or command that is given should be able to handle the fine tuning of which module's hooks get called. ------------------------------------------------------------------------ Thu, 28 Jul 2005 05:53:15 +0000 : clydefrog When I last used aggregator (which was probably back in the 4.4 days), it let me set a refresh interval for each feed. Is this no longer the case? Note I have nothing against this patch. It sounds like a good general solution for removing calls to hooks that are resource-heavy every time they run but still allowing some other hooks to be run more often. However, I also like Ber's idea of a convenience function to make delays easier to measure.

1 0

[drupal-devel] Release critical bugs for July 28, 2005
by drupal-devel＠drupal.org 28 Jul '05

28 Jul '05

/ bug reports email spam filtering does not "see" email addresses when they are NOT preceded by a word age: 27 weeks 4 days url: http://drupal.org/node/15654 / bug reports Visitors don't see anything? assigned: The Chief(a)gamebgs.com age: 1 hour 51 min url: http://drupal.org/node/27654 enable MySQL client side for UTF8 age: 1 week 2 days url: http://drupal.org/node/26990 Problem in the 4.6.2 upgrade - node.module age: 3 weeks 2 days url: http://drupal.org/node/26342 postgresql autocomplete code age: 4 weeks 7 hours url: http://drupal.org/node/26027 book "previous" link does not respect unpublished node setting age: 4 weeks 5 days url: http://drupal.org/node/25706 Accidentally Deleting Forums Vocabulary in Categories Breaks Forums? age: 7 weeks 5 days url: http://drupal.org/node/24274 Taxonomy Multiple Hierarchy doesn't display children for all its parent age: 8 weeks 1 day url: http://drupal.org/node/24023 PG_QUERY ERROR - LOCK TABLES - IMPLEMENTATION FAULT. age: 10 weeks 3 days url: http://drupal.org/node/22911 UTF-8 node title gets truncated at wrong position age: 14 weeks 6 days url: http://drupal.org/node/20537 database table "term_node" not updated when removing a term from a node under editing and submitting age: 15 weeks 2 days url: http://drupal.org/node/20315 Reassigning a node to a different term does not work properly age: 15 weeks 3 days url: http://drupal.org/node/20278 4.6 aggregator showing/not interpreting HTML tags age: 16 weeks 4 days url: http://drupal.org/node/19874 New submit error, non-admin user, postgresql database assigned: adrian age: 20 weeks 1 day url: http://drupal.org/node/18552 When I delete a user, any forum in which s/he has commented also disappears. assigned: Jill6q age: 23 weeks 12 hours url: http://drupal.org/node/17428 Change to sesssion.inc violates UID database constraint age: 27 weeks 4 days url: http://drupal.org/node/15666 forum.module problem with postgresql v7.4.1 age: 28 weeks 2 days url: http://drupal.org/node/15411 PHP 5 gives error when session table has no session assigned: adschar age: 28 weeks 2 days url: http://drupal.org/node/15399 apache and drupal both compressing pages age: 35 weeks 4 days url: http://drupal.org/node/13224 Argument NOT must be type boolean age: 36 weeks 2 days url: http://drupal.org/node/12950 Comments in approval queue still show up in tracker age: 40 weeks 4 days url: http://drupal.org/node/11647 Twin problems with comments assigned: Junyor age: 41 weeks 6 days url: http://drupal.org/node/11366 Fatal error: Call to undefined function: drupal_set_html_head() age: 48 weeks 1 day url: http://drupal.org/node/10317 user error: Duplicate entry assigned: Kjartan age: 1 year 33 weeks url: http://drupal.org/node/4428 / feature requests Filter the title to allow HTML comments age: 6 days 14 hours url: http://drupal.org/node/27205 Novel Module Creation Request age: 6 weeks 3 days url: http://drupal.org/node/24856 moving pages en masse age: 16 weeks 6 days url: http://drupal.org/node/19754 Taxonomy module should use nodeapi 'load' age: 20 weeks 11 hours url: http://drupal.org/node/18631 Auto PHP memory maximisation age: 22 weeks 2 days url: http://drupal.org/node/17663 User info exposed to anonymous user age: 34 weeks 5 days url: http://drupal.org/node/13545 Allow named anchors to work without specifying full path to node age: 1 year 35 weeks url: http://drupal.org/node/4213 / support requests blocks age: 5 weeks 2 days url: http://drupal.org/node/25378 Problem with Forums age: 28 weeks 5 days url: http://drupal.org/node/15299 / bug reports search over fields.inc fields conceptual error age: 38 weeks 6 days url: http://drupal.org/node/12259 fields.inc screws up with multible multiselect fields age: 38 weeks 6 days url: http://drupal.org/node/12257 / feature requests event.module support of repeating/recurring events? assigned: thehunmonkgroup age: 1 year 36 weeks url: http://drupal.org/node/4122 / bug reports Menu item not showing age: 42 weeks 5 days url: http://drupal.org/node/11210 / bug reports segmentation fault related to filestore age: 1 year 43 weeks url: http://drupal.org/node/3001 / bug reports file size bug age: 6 weeks 5 days url: http://drupal.org/node/24728 / bug reports Full screen slideshow in Gallery module is not working (erroring out on the wrong URL) age: 3 weeks 7 hours url: http://drupal.org/node/26479 Drupal session being logged out each time gallery module is called age: 4 weeks 6 days url: http://drupal.org/node/25614 Gallery error age: 13 weeks 2 days url: http://drupal.org/node/21290 Fatal Error: variable_get() age: 18 weeks 3 days url: http://drupal.org/node/19189 No Gallery Image Block age: 18 weeks 6 days url: http://drupal.org/node/19045 Mini applet can't find gallery at url / age: 19 weeks 4 days url: http://drupal.org/node/18785 Fatal error: Undefined class name 'galleryembed' age: 22 weeks 1 day url: http://drupal.org/node/17746 / support requests Can't Embed Gallery into Drupal age: 21 weeks 4 days url: http://drupal.org/node/18029 / bug reports Drupal-4.4-rc breaks registration setups and groups.module age: 1 year 19 weeks url: http://drupal.org/node/6392 / bug reports image module fails on dual site configuration age: 2 weeks 4 hours url: http://drupal.org/node/26657 Editing a previously uploaded and thumnailed image loses the thumbnail. age: 5 weeks 1 day url: http://drupal.org/node/25465 Cannot upload .jpgs age: 21 weeks 3 days url: http://drupal.org/node/18076 Image.Module does not know the correct filename age: 36 weeks 1 day url: http://drupal.org/node/13032 / support requests Images are there but not showing assigned: Stepfordtwit age: 11 hours 30 min url: http://drupal.org/node/27615 Image Module Permissions age: 3 weeks 3 days url: http://drupal.org/node/26280 path problems on upgrading... age: 12 weeks 3 days url: http://drupal.org/node/21725 / bug reports RSS "no element found at line 1" age: 3 weeks 5 days url: http://drupal.org/node/26185 Outdated help texts age: 51 weeks 2 days url: http://drupal.org/node/9692 Import doesn't like XML/RSS feeds with no Title element age: 1 year 8 weeks url: http://drupal.org/node/8128 / tasks move XML-parser into an inclde file. age: 5 weeks 1 day url: http://drupal.org/node/25439 / feature requests Notify.module ignores the true submission queue age: 1 year 39 weeks url: http://drupal.org/node/3765 / feature requests Internationalization support for PDF assigned: TheLibrarian age: 1 year 17 weeks url: http://drupal.org/node/6795 / bug reports Reminder email links don't work age: 4 weeks 5 days url: http://drupal.org/node/25677 / bug reports access control problems age: 5 days 8 hours url: http://drupal.org/node/27273 Download link is wrong age: 5 weeks 2 days url: http://drupal.org/node/25363 Projects not listed and page not complete age: 8 weeks 2 days url: http://drupal.org/node/23956 Date for latest is incorrect age: 14 weeks 6 days url: http://drupal.org/node/20485 Invalid link to release files age: 22 weeks 3 days url: http://drupal.org/node/17625 Node body not complete w/o releases age: 24 weeks 5 days url: http://drupal.org/node/16733 blank page after install age: 25 weeks 1 day url: http://drupal.org/node/16575 / support requests Help with everything - nothing seems to work in the latest build age: 35 weeks 2 days url: http://drupal.org/node/13310 / bug reports Can't get the inline tag to show series age: 11 weeks 1 day url: http://drupal.org/node/22520 / feature requests Request to generate email for all content changes/additions, including comments age: 1 week 4 days url: http://drupal.org/node/26824 / bug reports javascrip downloads square.gif for every category age: 23 weeks 1 day url: http://drupal.org/node/17366

1 0

[drupal-devel] [feature] Pass include and exclude parameters to cron.php for fine grained cron timing
by clydefrog 28 Jul '05

28 Jul '05

Issue status update for http://drupal.org/node/19173 Post a follow up: http://drupal.org/project/comments/add/19173 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: robertDouglass Updated by: clydefrog Status: patch When I last used aggregator (which was probably back in the 4.4 days), it let me set a refresh interval for each feed. Is this no longer the case? Note I have nothing against this patch. It sounds like a good general solution for removing calls to hooks that are resource-heavy every time they run but still allowing some other hooks to be run more often. However, I also like Ber's idea of a convenience function to make delays easier to measure. clydefrog Previous comments: ------------------------------------------------------------------------ Sun, 20 Mar 2005 10:08:59 +0000 : robertDouglass Attachment: http://drupal.org/files/issues/cronpatch.txt (1.99 KB) Some sites need fine grained timing for cron runs. For example, a site that relies heavily on moblogging, mailhandler or any other email based function would want to connect with the email server pretty often, say ever 2-5 minutes. On another site I'm working on we generate flat files for all of a certain node type on a regular basis, though not every 2-5 minutes. Thus the need for cron tasks on different schedules. This patch allows you to make a list of modules to either include or exclude when running cron, so that several cron tasks for one site can be defined. The default behavior in the absence of both parameters is to run all, so the patch preserves backwards compatibility. * Examples: * * runs all hooks * http://mysite.com/cron.php * * runs all hooks except the search and aggregator modules * http://mysite.com/cron.php?exclude=search,aggregator * * runs only search, archive and aggregator modules * http://mysite.com/cron.php?includ=search,archive,aggregator ------------------------------------------------------------------------ Wed, 23 Mar 2005 21:23:59 +0000 : Dries Isn't it possible to run all cron functions every 2-5 minutes? The impact of that should be minimal. ------------------------------------------------------------------------ Wed, 23 Mar 2005 21:33:06 +0000 : moshe weitzman an alternative approach is to make a quick PHP page which simply calls mailhandler_cron and any others that need to be called more frequently than normal. then call that php page from cron every couple minutes ... not so sure this complexity is worth having. ------------------------------------------------------------------------ Thu, 24 Mar 2005 07:32:32 +0000 : robertDouglass Whether or not this "complexity" is needed depends a lot on what you expect to do with cron. As soon as one starts aggregating not tens but several hundred RSS feeds or more, it is impossible to run cron every 2 minutes. Yet if the site depends on mailhandler keeping user moblog submissions current, 2 minutes is already about the maximum latency time acceptable. Thus the need for crons on different schedules. In terms of usage, writing ?include=mailhandler,search,event isn't so complex. On the code level, splitting that list on comma and looping over the resultant array also isn't really that complex. The patch defaults to normal behavior for people who don't need the feature, and I've seen more than one site that had to solve this problem. ------------------------------------------------------------------------ Thu, 24 Mar 2005 10:48:09 +0000 : Robert Castelo Could different cron runs be set to run different tasks based on a cron ID number.... For instance, set up 3 separate cron to run every hour, each one calls the cron.php page including a number variable which runs a certain set of tasks. An Admin control panel would list all cron tasks and allow administrators to split them into separate cron runs based on the number variable passed to the script when calling cron.php. ------------------------------------------------------------------------ Thu, 24 Mar 2005 11:24:53 +0000 : robertDouglass Robert, the id parameter is already a practical necessity for this patch if cron_busy is to be effective. I'm open to suggestions as to how we would track various cron tasks and whether they are busy. First things first, though: does anyone except me need this? I'm not going to program an admin-configurable cron mechanism unless there is demand for it. Furthermore, such a system would really be incomplete unless there were some actual mechanism for setting these cron runs up from the admin interface as well. This wouldn't be such a bad idea, I know a lot of people who still type /cron.php into their browser every day or so to updated thier sites (yes I've mentioned poormanscron). Anyway, first reactions to this patch have been cold, so maybe nobody wants it. ------------------------------------------------------------------------ Thu, 24 Mar 2005 11:39:13 +0000 : Robert Castelo +1 from me. I'll be needing something like this once my email newsletter is released and starts hogging cron runs. ------------------------------------------------------------------------ Thu, 24 Mar 2005 16:06:31 +0000 : Chris Johnson It does seem like a good idea to allow running different cron tasks at different intervals, so as to be efficient and reduce web server loads. There is little point in running tasks that do not need to be run. Many cron tasks only need to be run once to a few times per day. Note also that cron job scheduling on most Unix-variants is only within a +/- 1 minute range, so trying to run a cron program every 2 minutes is approaching the crumbling edge of being "on time." ------------------------------------------------------------------------ Thu, 24 Mar 2005 16:37:39 +0000 : robertDouglass I think I am leaning in favor of extending cron.php in the following way: 1) Add admin screen which scans all modules for existence of cron hook 2) set a cron_interval variable for each one 3) allow admin to set an interval 4) check whether the current cron run falls outside of each module's interval before invoking its cron hook 5) before a module's cron hook gets called a {module_name}_cron_busy variable gets set. This would function like the current cron_busy now, just at a modular level. The admin would then set one cron tab to run at the smallest needed interval and could then decide on a module-by-module basis how often each is to run. How does this sound to people? ------------------------------------------------------------------------ Wed, 27 Jul 2005 16:18:23 +0000 : Bèr Kessels -1 on this one. I think the hook_cron should carry the logic whether or not it wants to be ran. Maybe aintroduce an API that allows theis checkto be done easier? drupal_elapsed_run($name, interval) that will check when $name was last updated, if it was longer then $interval ago, return TRUE, and update the last run of $name. ------------------------------------------------------------------------ Wed, 27 Jul 2005 21:32:29 +0000 : robertDouglass Bèr, how can you adjust the interval then? If it is hardcoded how often the cron should run, administrators loose all control and you can't have different sites have different schedules, unless of course you have cron configuration in the interface itself. I think cron scheduling should be completely done with the cron tool itself, and that the URL or command that is given should be able to handle the fine tuning of which module's hooks get called.

1 0