- Development - lists.drupal.org

[drupal-devel] [feature] Single step account creation and login
by mathias 23 Jul '05

23 Jul '05

Issue status update for http://drupal.org/node/4942 Post a follow up: http://drupal.org/project/comments/add/4942 Project: Drupal Version: 4.6.2 Component: user.module Category: feature requests Priority: normal Assigned to: amanuel Reported by: mathias Updated by: mathias Status: patch I want users to be able to enter their own passwords upon account creation, but this patch still needs some work. - The email verification checkbox in user admin settings is confusing. I'm assuming that it applies to any of the selected registration options? However when I select that only site admins can create new user accounts, the accounts I create don't get any emails sent for the user to verify. - When a user signs up and enters his/her own password I think they should be logged in automatically rather than taken to a screen asking them to click the login button. - User entered passwords aren't validated. We should check to make sure they're at least six characters and verify the password strength level to some degree (i.e. same characters, all lowercase letters.) mathias Previous comments: ------------------------------------------------------------------------ Sat, 03 Jan 2004 23:49:54 +0000 : mathias Under special circumstances, i would like a new user to be able to choose their own password and be automatically logged into the site without needing to check their email. I feel this is necessary for my ecommerce module, where after anonymous users are ready to "Proceed to checkout", they need to create an user account to continue. It is tedious for the customer if they have to stop, check their email, log into the site and then resume the checkout process. I'm game to code this (if this has potential to be part of the core), i just need some feedback on the best way to tweak user_register. ------------------------------------------------------------------------ Sun, 04 Jan 2004 06:18:07 +0000 : moshe weitzman +1 for this. I don't think you will get much objection to this much needed usability enhancement. ------------------------------------------------------------------------ Thu, 08 Jan 2004 05:48:40 +0000 : mathias Attachment: http://drupal.org/files/issues/user.module-quick_acount.patch (7.11 KB) This is a prototype patch to make sure i'm going in the right direction. I feel this patch is about 95% complete, the outstanding issue being page redirection after quick-account creation. It introduces and new option under the user admin settings "Public registrations" called "Visitors can create accounts and sign in immediately.", allowing visitors to submit their own passwords upon account creation. This is important in an ecommerce site where a new customer wants to the checkout process to be as easy and seamless as possible. ------------------------------------------------------------------------ Thu, 08 Jan 2004 10:22:09 +0000 : moshe weitzman i read through the patch. looks good to me. a few notes - we should still send a password via email to users who choose their ow password. with some text tweaking, we should be able to send the same welcome email to 'generated password' registratants, and 'user specified password' registrants. - I think we need a setting for minimum length of a password. the password textfield should inform users of this requirement. - you don't actually relinquish control after saying "/* Let the developer control where the user is redirected. */". i assume this part isn't finished yet. nice work. ------------------------------------------------------------------------ Thu, 08 Jan 2004 13:46:07 +0000 : flevour Are there any anti-bot checks around, e.g. randomly generated images that contain text or numbers to insert in a box? Congrats for your work :p // flevour ------------------------------------------------------------------------ Thu, 08 Jan 2004 13:54:19 +0000 : Bèr Kessels I had another idea. that would be to filter all emailadresses (in content too) into a link to the feedback module. thus http://www.mysite.org/feedback/mailto/me/mysite.org the feedback can then print a form that can send the message to me(a)mysite.org. Would this be a good feature or not? Ber ------------------------------------------------------------------------ Thu, 08 Jan 2004 13:56:36 +0000 : Bèr Kessels sorry folks. placed this in the wrong box. Was updating another feature, and reading this one (to see if it was the same one) i then, by accident, filled replyed here. :( Ber ------------------------------------------------------------------------ Thu, 08 Jan 2004 16:49:56 +0000 : Dries Showing an image with random generated text that a user is supposed to copy, makes your website inaccessible for visually impaired: they can't be read by a screen reader. ------------------------------------------------------------------------ Thu, 08 Jan 2004 17:07:02 +0000 : mathias Responding to Moshe's comments: - we should still send a password via email to users who choose their own password. with some text tweaking, we should be able to send the same welcome email to 'generated password' registratants, and 'user specified password' registrants. That is a good point. I'll update the patch. - I think we need a setting for minimum length of a password. the password textfield should inform users of this requirement. Agreed. In my patch i checked to make sure the password was at least six characters long, but this should be an element that can be tweaked by the admin. It might be best to make this a global password length system variable. - you don't actually relinquish control after saying "/* Let the developer control where the user is redirected. */". i assume this part isn't finished yet. Yep, that's the part i'm still working on. Thanks for the critical eyes. ------------------------------------------------------------------------ Wed, 14 Jan 2004 04:31:06 +0000 : mathias Attachment: http://drupal.org/files/issues/user_0.module-quick_acount.patch (7.95 KB) The patch has been updated and is ready for final review, and commit. ------------------------------------------------------------------------ Wed, 14 Jan 2004 22:37:53 +0000 : Dries Not sure. Wouldn't it make more sense (and result in better/less code) to let the user *always* choose his password and to introduce a admin setting to control whether e-mail addresses should be validated by e-mail? ------------------------------------------------------------------------ Sun, 15 Feb 2004 17:02:38 +0000 : moshe weitzman moving out of patch queue until a cleaner implementation is submitted ... this feature is still quite valuable. ------------------------------------------------------------------------ Fri, 05 Nov 2004 19:21:49 +0000 : Nick Nassar I agree with Dries that it makes a lot of sense to always let the user choose her password. It's a pain to copy and paste in a randomly generated password, then change it. Hash link based verification is much easier. That's really a seperate issue from an option to disable verification. ------------------------------------------------------------------------ Fri, 22 Jul 2005 22:11:42 +0000 : amanuel Attachment: http://drupal.org/files/issues/user4.6.2.patch (4.25 KB) Following Dries's suggestion, I have implemented a "Enable Email Verification" option to user.module. The attached patch does the job. With this patch the system by default will ask for a password. If Email Verification is turned on in the settings, the system will send the password via email. $edit['destination'] is carried so as to allow the user to return where they were (shopping cart etc.) Any comments? Amanuel

1 0

[drupal-devel] [task] Introduce Daylight Saving Time for Drupal
by mfb 23 Jul '05

23 Jul '05

Issue status update for http://drupal.org/node/11077 Post a follow up: http://drupal.org/project/comments/add/11077 Project: Drupal Version: cvs Component: base system Category: tasks Priority: normal Assigned to: crunchywelch Reported by: killes(a)www.drop.org Updated by: mfb Status: patch It would be great to use MySQL 4.1 as the solution but it probably isn't (yet) possible for Drupal to require MySQL 4.1 when many webhosts are still using MySQL 4.0. We'll have to use our own zoneinfo library. Which by the way will need an update if the U.S. changes daylight saving time. mfb Previous comments: ------------------------------------------------------------------------ Sun, 26 Sep 2004 03:01:53 +0000 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/dst.patch (6.04 KB) Many people have wanted to have a Daylight Saving Time setting in the past. If we use the "server time" modell (all times are displayed the same around the world) this isn't all that hard to do. I found a lot of usefull information here: http://webexhibits.org/daylightsaving/g.html The patch introduces a new DST setting and uses it if the "Configurable time zones" setting is switched off. ------------------------------------------------------------------------ Sun, 26 Sep 2004 04:40:56 +0000 : gordon This is a lovely patch, but you do realise that you have opened a can of worms. Daylight saving is a messy business, I had to write the Contestable Electricity billing for a company here in Australia which had multiple installations in multpile timezones, all with different daylight savings rules, which impacted upon the bill. The way that dst is legistated is very messy and here is Australia it is very messy. Daylight savings don't follow state lines, as some towns that are very close to the border may choose to follow the only the daylight saving period of the next state, and when we had the olympics NSW went into daylight savings months before anyone else. There are other examples of weird things like even the 1 hour forward is not also true. I know that in the 1999 change to daylight savings there was a small set of islands north of New Zealand that went ahead by 2 hours as they wanted to be the first into 2000. >From what I can see of your patch it only allows for a single daylight savings period for the entire system. Their can be situations where there can be users from multiple countries and in different timezones/dst. I think that entire timezone system needs to looked at again, and maybe re-implement it so that it will allow for dst. Maybe make it a bit more user friendly so instead of setting up the timezone by name much like how operating systems do it, and then this will automatically work out the timezone. +1 for this is something that would be good, but it still needs work. ------------------------------------------------------------------------ Sun, 26 Sep 2004 14:13:27 +0000 : Anonymous The patch works as it is now. I had good reason to limit its capability to the setting where users cannot chose their own timezone. ;) I also assume that a server administrator knows if he has dst or not. I also didn't (yet) cater for all countries where dst is in use mainly because some insist on not giving a sensible rule for the change dates. ------------------------------------------------------------------------ Sun, 26 Sep 2004 22:54:40 +0000 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/dst_0.patch (6.04 KB) The last comment was mine. After a code review by Kjartan I provide a slightly improved patch. I want to stress that solving the DST issue in a "suits everybody" manner isn't the intention of this patch. It solves the problem for people who have chosen to let all times on their site be displayed in the server's time setting. By covering a large portion of the earth's landmass I hope to be able to help most site admins. It would be possible to extend the patch to allow users to chose their DST setting, too. In my experience, however, users tend to not care about time settings at all. This may be EUrocentric though, as we have only one time zone. Feedback is welcome. ------------------------------------------------------------------------ Mon, 27 Sep 2004 21:12:25 +0000 : drumm +1 >From a code review I think this is an excellent solution. Could use a little more comments in the section that sets $node->date to explain the (probably good) reasoning behind that chunk of code. I don't have anything resembling a good set of tests so I did not apply the patch and try it. ------------------------------------------------------------------------ Tue, 25 Jan 2005 20:38:14 +0000 : killes(a)www.drop.org I just want to point out that this patch still applies and would make for a fine feature for Drupal 4.6... ------------------------------------------------------------------------ Wed, 26 Jan 2005 16:46:21 +0000 : alliax wouldn't hurt to have this feature in upcoming drupal. I would use it for sure, my users are from the same place, with dst ------------------------------------------------------------------------ Thu, 28 Apr 2005 16:12:36 +0000 : Sage This is an incredibly useful feature and I would like to see it incorporated into the next release (current release is 4.6.0). ------------------------------------------------------------------------ Wed, 04 May 2005 16:06:51 +0000 : syntaxerror Works beautifully.. I'm going to work on getting this to work with event.module. ------------------------------------------------------------------------ Wed, 04 May 2005 17:53:36 +0000 : crunchywelch I have just discussed with killes and rorris an enhancement to this patch which I will implement. We have proposed putting the ical timezone db (http://cvs.drupal.org/viewcvs/drupal/contributions/modules/ical/ical.sql?re…) in core. We will implement a DST field in that db for each zone which coreesponds with the zones in killes' patch here for dtermining whether a zone is currently in dst or not. Currently, the 5 zones in the drupal_is_dst() function in this patch will be the only regions assigned to timezones. If more regions are desired they can be submitted by the community. To be clear, this must be implemented before additional development on ical/event.module can proceed properly. We would like this to be in core for 4.7, and move one more step with timezone handling in event module to use this as well. Discuss! ------------------------------------------------------------------------ Wed, 04 May 2005 18:13:06 +0000 : tostinni I agree to put more specific region to DST as it's easier for someone to know which city DST he belongs than which DST Zone (Pacific Standard Time...). I like pretty much the way that windows manage this. +1 ------------------------------------------------------------------------ Thu, 05 May 2005 02:45:52 +0000 : Jaza The patch looks good... however, it doesn't take into account the fact that in Australia, DST starts and ends at 2am on Sunday morning. So these lines: case 4: // Australia // start of DST (last Sunday in October) $dststart = strtotime("-1 week sunday GMT", strtotime("1 november $year GMT")) + $timezone; // end of DST (last Sunday in March) $dstend = strtotime("-1 week sunday GMT", strtotime("1 april $year GMT")) + $timezone; break; Should read: case 4: // Australia // start of DST (last Sunday in October at 2am) $dststart = strtotime("-1 week sunday GMT", strtotime("1 november $year GMT")) + 7200 + $timezone; // end of DST (last Sunday in March at 2am) $dstend = strtotime("-1 week sunday GMT", strtotime("1 april $year GMT")) + 7200 + $timezone; break; There are also a whole lot more countries (and their specific DST rules) on http://webexhibits.org/daylightsaving/g.html than are implemented in this patch. I'd ultimately like to see an admin interface to let the webmaster add additional DST rules for whatever country they live in (or are developing for). These rules could be entered in raw PHP, or using a somewhat friendlier interface. Jaza. ------------------------------------------------------------------------ Wed, 25 May 2005 06:11:32 +0000 : Steven +1 on this patch. Catches most cases and at least provides a base for others to work on. ------------------------------------------------------------------------ Wed, 25 May 2005 07:13:36 +0000 : gordon Do not take this the wrong what, but when it comes to dst, this is exemely simplisict. What would be the best method of doing this is to use the Zone Info files from libc. These not only have all the dst splits, but also all the timezones, and would be the most acurate. Have a look at Sources of Time Zone and Daylight Savings Data [1] whcih has pointers to where all this information is. Did you know that Australia has 21 different Timezones and DST areas. If you could enter the same information from tzdata then this would be the altermate dst system [1] http://www.twinsun.com/tz/tz-link.htm ------------------------------------------------------------------------ Wed, 25 May 2005 12:25:32 +0000 : jhriggs There has sure been a lot of talk about DST and time zones lately. All I ask is that we hold off on committing anything for a bit. I am currently working on a project that will hopefully fix this issue completely, correctly, and once and for all. :-) I am in the process of writing a pure PHP library that will be released LGPL that uses the /real/ zoneinfo data files to handle any date (not just Unix timestamps) in any time zone. With this, site admins and/or users will be able to select their real time zone (America/New_York vs. our current GMT -500) and DST will inherently be handled without users having to change their settings. Much of the grunt work is already done. I still have to put all of the pieces together and make sure everything is well documented. As soon as I have tested everything to my satisfaction, I will role a Drupal patch that we can hopefully get tested and committed ASAP. Of course I want to see this get into Drupal first! ;-) I hope to have everything completed in the next couple of weeks, but based on the way things have been going lately, I can't make any promises. It will definitely be done before 4.7, though...whatever it takes! ------------------------------------------------------------------------ Wed, 25 May 2005 12:47:07 +0000 : gordon +1 This sounds great, but I think we will still need a pure php version that will be able to be used on hosted web sites where we will not be able to get you library installed. It doesn't need to be as effient as the php extension, as sites that at that big will be self hosted and be able to install this library. One question. Does you extension run on windows. If it does this is another reason to have a pure php version. This is really the method that should be employed. ------------------------------------------------------------------------ Wed, 25 May 2005 12:53:32 +0000 : jhriggs When I say "library," I just mean a collection of PHP files as opposed to a single file. There is nothing to be installed like an extension. This is pure PHP that will simply be part of the distribution (a handful of .php files placed inside includes/zoneinfo or something like that). As this is pure PHP, it will work anywhere PHP does. This will essentially give us the benefit and functionality of using the TZ variable on Unix without all of the problems associated with that (i.e. not knowing what zones are available and what there names are, not being available on Windows, etc.). ------------------------------------------------------------------------ Wed, 25 May 2005 13:27:05 +0000 : gordon This sounds good. If you would like someone who has done alot of stuff with timezones and dst (mainly in the contestable electricity inductry in australia, which is required for billing), I would be quite happy to take a look. The only problem that I see is that it sounds a little too messy for core. maybe this could be made into a contributed module that can be installed if people need the correct timezones. However this is how the dst and timezones need to be done if we want to get them correct. As I said before and I couldn't believe it, Australia has 21 different timezones and dst areas. The timezone database needs to be maintained. ------------------------------------------------------------------------ Wed, 25 May 2005 14:41:40 +0000 : killes(a)www.drop.org jhriggs, gordon: Please have a look at crunchywelch's dst implementation for event.module (in 4.6 and cvs). We intend to push this into core. ------------------------------------------------------------------------ Tue, 28 Jun 2005 20:11:48 +0000 : mfb Great! event_timezones.inc definitely needs to be in core, as it would be used for both user and site configuration. But it should include everything from the unix zoneinfo libraries, e.g. timezone abbreviations used by strftime(), so you can display "PDT" or "PST" instead of "America/Los_Angeles". so, a complete port of the zoneinfo libraries to PHP is probably what is needed. This would be used for site config, user config and events. ------------------------------------------------------------------------ Tue, 05 Jul 2005 11:45:33 +0000 : glen one idea, maybe use mysql timezone tables that are available since mysql 4.1.3? http://www.visionwebhosting.net/mysql-web-hosting/page0403.htm not sure how it's possible with licensing, but original tzdata is GPL (at least according to Fedora Core 2 tzdata.spec) then mysql data table contents should be too GPL. good side is that it should work for windows too http://dev.mysql.com/downloads/timezones.html

1 0

[drupal-devel] [task] Remove a style for filter tips
by drumm 23 Jul '05

23 Jul '05

Issue status update for http://drupal.org/node/27283 Post a follow up: http://drupal.org/project/comments/add/27283 Project: Drupal Version: cvs Component: theme system Category: tasks Priority: minor Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/drupal.css_1.diff (491 bytes) I don't think we need these margins which appear only on the .../filter/tips page. The default themes look fine without it. drumm

1 0

[drupal-devel] [feature] Nice DB error screens
by drumm 23 Jul '05

23 Jul '05

Issue status update for http://drupal.org/node/27231 Post a follow up: http://drupal.org/project/comments/add/27231 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch The theme_message() which stefan nagtegaal looks like it should be four separate themeable functions, one of which already exists. I think any such modifications are outside the scope of this patch. I am nearly finished preparing a patch to update.php which uses this patch, but I can not post it until this patch is resolved. drumm Previous comments: ------------------------------------------------------------------------ Thu, 21 Jul 2005 22:43:16 +0000 : drumm Attachment: http://drupal.org/files/issues/screenshot2.png (96.1 KB) Screenshot. ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:21:31 +0000 : drumm Attachment: http://drupal.org/files/issues/screenshot_10.png (88.44 KB) ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:25:57 +0000 : drumm Attachment: http://drupal.org/files/issues/druplicon.png (3.98 KB) New Druplicon which will need to replace misc/druplicon.png. The current file in that location is a giant flat druplicon which isn't used anywhere. ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:26:26 +0000 : drumm Attachment: http://drupal.org/files/issues/maintenance.css (329 bytes) Some CSS ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:30:34 +0000 : drumm Attachment: http://drupal.org/files/issues/errorhandling.patch (8.47 KB) This patch makes the database errors which occur when the database connection information is wrong or the database isn't up much nicer and more explanatory. To do this it adds a themeable function, theme_maintenance_page(), and a way to get Drupal running without a theme but the ability to execute themeable functions in the usual way. This means we can use the same code to give upgrade.php a nicer look in the future. ------------------------------------------------------------------------ Fri, 22 Jul 2005 06:33:57 +0000 : kbahey I was about to do something similar on a less ambitious scale (mainly the connect function), because what we get now is ugly and looks unprofessional. +1 from me for this. Great job! ------------------------------------------------------------------------ Fri, 22 Jul 2005 06:52:30 +0000 : gordon +1, This looks great. Get this in and then we can do something with the upgrade.php system and it will look just great. ------------------------------------------------------------------------ Fri, 22 Jul 2005 19:36:39 +0000 : drumm Attachment: http://drupal.org/files/issues/errorhandling_0.patch (8.44 KB) New patch with a couple suggestions from chx. * $foo === NULL is faster than is_null($foo) * Removed 'bootstrap' from the function name since it is not really part of the bootstrap system. When testing/applying updates #2 and #3 of this issue need to be handled too. ------------------------------------------------------------------------ Fri, 22 Jul 2005 20:47:18 +0000 : stefan nagtegaal I indeed like the patch! you have some perfectly helptexts which asure that people *must* be foulish when they do not know how to setup drupal the correct way. On that, a very, very fine patch.. Though, code-wise I have one nit-pick, which is propably not even a real issue. Only, I think it looks better: + print theme('maintenance_page', '<p>We were able to connect to the MySQL database server (which means your username and password is okay) but not able to select the database.</p> +<p>The MySQL error was: <em>'. mysql_error() .'</em>.</p> +<p>Currently, the database is <code>'. substr($url['path'], 1) .'. The username is '. $url['user'] .' and the database server is '. $url['host'] .'. + + * Are you sure you have the correct database name? + * Are you sure the database exists? + * Are you sure the username has permission to access the database? + +For more help, see the Installation and upgrading handbook [1]. If you are unsure what these terms mean you should probably contact your hosting provider. '); Wouldn't it be nicer (code-wise) todo: $message[] = 'We were able to connect to the MySQL database server (which means your username and password is okay) but not able to select the database.'; $message[] = strtr('The MySQL error was: %error.', array('%error' => theme('placeholder', mysql_error()))); $message[] = etc, etc; print theme('maintenance_page', $message); Also would I encourage you to make a function theme_message($type, $message), like: function theme_message($type, $message) { switch($type) { case 'code': $output .= '<code>'. $message .'<code>'; break; case 'placeholder': $output .= '<em>'. $message .'<em>'; break; case 'important': $output .= '<strong>'. $message .'<strong>'; break; default: $output .= '<p>'. $message .'<p>'; break; } } Which makes theme_placeholder() redundant and could be removed. Codesnippets could be handled in a more consistent way then we currently do (having a theme_placeholder() only is rediculous imo afterall). Also this function could be used to remove the hardcoded HTML from the helptexts.. The code is untested and needs some love here-and-there. But, when it's done, I think we will create (codewise) more consistency than we currently have! I look forward to see your idea's and hear your opinion about this.. [1] http://drupal.org/node/258

1 0

[drupal-devel] [feature] Single step account creation and login
by amanuel 23 Jul '05

23 Jul '05

Issue status update for http://drupal.org/node/4942 Post a follow up: http://drupal.org/project/comments/add/4942 Project: Drupal -Version: cvs +Version: 4.6.2 Component: user.module Category: feature requests Priority: normal -Assigned to: mathias +Assigned to: amanuel Reported by: mathias Updated by: amanuel -Status: active +Status: patch Attachment: http://drupal.org/files/issues/user4.6.2.patch (4.25 KB) Following Dries's suggestion, I have implemented a "Enable Email Verification" option to user.module. The attached patch does the job. With this patch the system by default will ask for a password. If Email Verification is turned on in the settings, the system will send the password via email. $edit['destination'] is carried so as to allow the user to return where they were (shopping cart etc.) Any comments? Amanuel amanuel Previous comments: ------------------------------------------------------------------------ Sat, 03 Jan 2004 23:49:54 +0000 : mathias Under special circumstances, i would like a new user to be able to choose their own password and be automatically logged into the site without needing to check their email. I feel this is necessary for my ecommerce module, where after anonymous users are ready to "Proceed to checkout", they need to create an user account to continue. It is tedious for the customer if they have to stop, check their email, log into the site and then resume the checkout process. I'm game to code this (if this has potential to be part of the core), i just need some feedback on the best way to tweak user_register. ------------------------------------------------------------------------ Sun, 04 Jan 2004 06:18:07 +0000 : moshe weitzman +1 for this. I don't think you will get much objection to this much needed usability enhancement. ------------------------------------------------------------------------ Thu, 08 Jan 2004 05:48:40 +0000 : mathias Attachment: http://drupal.org/files/issues/user.module-quick_acount.patch (7.11 KB) This is a prototype patch to make sure i'm going in the right direction. I feel this patch is about 95% complete, the outstanding issue being page redirection after quick-account creation. It introduces and new option under the user admin settings "Public registrations" called "Visitors can create accounts and sign in immediately.", allowing visitors to submit their own passwords upon account creation. This is important in an ecommerce site where a new customer wants to the checkout process to be as easy and seamless as possible. ------------------------------------------------------------------------ Thu, 08 Jan 2004 10:22:09 +0000 : moshe weitzman i read through the patch. looks good to me. a few notes - we should still send a password via email to users who choose their ow password. with some text tweaking, we should be able to send the same welcome email to 'generated password' registratants, and 'user specified password' registrants. - I think we need a setting for minimum length of a password. the password textfield should inform users of this requirement. - you don't actually relinquish control after saying "/* Let the developer control where the user is redirected. */". i assume this part isn't finished yet. nice work. ------------------------------------------------------------------------ Thu, 08 Jan 2004 13:46:07 +0000 : flevour Are there any anti-bot checks around, e.g. randomly generated images that contain text or numbers to insert in a box? Congrats for your work :p // flevour ------------------------------------------------------------------------ Thu, 08 Jan 2004 13:54:19 +0000 : Bèr Kessels I had another idea. that would be to filter all emailadresses (in content too) into a link to the feedback module. thus http://www.mysite.org/feedback/mailto/me/mysite.org the feedback can then print a form that can send the message to me(a)mysite.org. Would this be a good feature or not? Ber ------------------------------------------------------------------------ Thu, 08 Jan 2004 13:56:36 +0000 : Bèr Kessels sorry folks. placed this in the wrong box. Was updating another feature, and reading this one (to see if it was the same one) i then, by accident, filled replyed here. :( Ber ------------------------------------------------------------------------ Thu, 08 Jan 2004 16:49:56 +0000 : Dries Showing an image with random generated text that a user is supposed to copy, makes your website inaccessible for visually impaired: they can't be read by a screen reader. ------------------------------------------------------------------------ Thu, 08 Jan 2004 17:07:02 +0000 : mathias Responding to Moshe's comments: - we should still send a password via email to users who choose their own password. with some text tweaking, we should be able to send the same welcome email to 'generated password' registratants, and 'user specified password' registrants. That is a good point. I'll update the patch. - I think we need a setting for minimum length of a password. the password textfield should inform users of this requirement. Agreed. In my patch i checked to make sure the password was at least six characters long, but this should be an element that can be tweaked by the admin. It might be best to make this a global password length system variable. - you don't actually relinquish control after saying "/* Let the developer control where the user is redirected. */". i assume this part isn't finished yet. Yep, that's the part i'm still working on. Thanks for the critical eyes. ------------------------------------------------------------------------ Wed, 14 Jan 2004 04:31:06 +0000 : mathias Attachment: http://drupal.org/files/issues/user_0.module-quick_acount.patch (7.95 KB) The patch has been updated and is ready for final review, and commit. ------------------------------------------------------------------------ Wed, 14 Jan 2004 22:37:53 +0000 : Dries Not sure. Wouldn't it make more sense (and result in better/less code) to let the user *always* choose his password and to introduce a admin setting to control whether e-mail addresses should be validated by e-mail? ------------------------------------------------------------------------ Sun, 15 Feb 2004 17:02:38 +0000 : moshe weitzman moving out of patch queue until a cleaner implementation is submitted ... this feature is still quite valuable. ------------------------------------------------------------------------ Fri, 05 Nov 2004 19:21:49 +0000 : Nick Nassar I agree with Dries that it makes a lot of sense to always let the user choose her password. It's a pain to copy and paste in a randomly generated password, then change it. Hash link based verification is much easier. That's really a seperate issue from an option to disable verification.

1 0

[drupal-devel] [feature] Nice DB error screens
by stefan nagtegaal 22 Jul '05

22 Jul '05

Issue status update for http://drupal.org/node/27231 Post a follow up: http://drupal.org/project/comments/add/27231 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: stefan nagtegaal Status: patch I indeed like the patch! you have some perfectly helptexts which asure that people *must* be foulish when they do not know how to setup drupal the correct way. On that, a very, very fine patch.. Though, code-wise I have one nit-pick, which is propably not even a real issue. Only, I think it looks better: + print theme('maintenance_page', '<p>We were able to connect to the MySQL database server (which means your username and password is okay) but not able to select the database.</p> +<p>The MySQL error was: <em>'. mysql_error() .'</em>.</p> +<p>Currently, the database is <code>'. substr($url['path'], 1) .'. The username is '. $url['user'] .' and the database server is '. $url['host'] .'. + + * Are you sure you have the correct database name? + * Are you sure the database exists? + * Are you sure the username has permission to access the database? + +For more help, see the Installation and upgrading handbook [1]. If you are unsure what these terms mean you should probably contact your hosting provider. '); Wouldn't it be nicer (code-wise) todo: $message[] = 'We were able to connect to the MySQL database server (which means your username and password is okay) but not able to select the database.'; $message[] = strtr('The MySQL error was: %error.', array('%error' => theme('placeholder', mysql_error()))); $message[] = etc, etc; print theme('maintenance_page', $message); Also would I encourage you to make a function theme_message($type, $message), like: function theme_message($type, $message) { switch($type) { case 'code': $output .= '<code>'. $message .'<code>'; break; case 'placeholder': $output .= '<em>'. $message .'<em>'; break; case 'important': $output .= '<strong>'. $message .'<strong>'; break; default: $output .= '<p>'. $message .'<p>'; break; } } Which makes theme_placeholder() redundant and could be removed. Codesnippets could be handled in a more consistent way then we currently do (having a theme_placeholder() only is rediculous imo afterall). Also this function could be used to remove the hardcoded HTML from the helptexts.. The code is untested and needs some love here-and-there. But, when it's done, I think we will create (codewise) more consistency than we currently have! I look forward to see your idea's and hear your opinion about this.. [1] http://drupal.org/node/258 stefan nagtegaal Previous comments: ------------------------------------------------------------------------ Thu, 21 Jul 2005 22:43:16 +0000 : drumm Attachment: http://drupal.org/files/issues/screenshot2.png (96.1 KB) Screenshot. ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:21:31 +0000 : drumm Attachment: http://drupal.org/files/issues/screenshot_10.png (88.44 KB) ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:25:57 +0000 : drumm Attachment: http://drupal.org/files/issues/druplicon.png (3.98 KB) New Druplicon which will need to replace misc/druplicon.png. The current file in that location is a giant flat druplicon which isn't used anywhere. ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:26:26 +0000 : drumm Attachment: http://drupal.org/files/issues/maintenance.css (329 bytes) Some CSS ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:30:34 +0000 : drumm Attachment: http://drupal.org/files/issues/errorhandling.patch (8.47 KB) This patch makes the database errors which occur when the database connection information is wrong or the database isn't up much nicer and more explanatory. To do this it adds a themeable function, theme_maintenance_page(), and a way to get Drupal running without a theme but the ability to execute themeable functions in the usual way. This means we can use the same code to give upgrade.php a nicer look in the future. ------------------------------------------------------------------------ Fri, 22 Jul 2005 06:33:57 +0000 : kbahey I was about to do something similar on a less ambitious scale (mainly the connect function), because what we get now is ugly and looks unprofessional. +1 from me for this. Great job! ------------------------------------------------------------------------ Fri, 22 Jul 2005 06:52:30 +0000 : gordon +1, This looks great. Get this in and then we can do something with the upgrade.php system and it will look just great. ------------------------------------------------------------------------ Fri, 22 Jul 2005 19:36:39 +0000 : drumm Attachment: http://drupal.org/files/issues/errorhandling_0.patch (8.44 KB) New patch with a couple suggestions from chx. * $foo === NULL is faster than is_null($foo) * Removed 'bootstrap' from the function name since it is not really part of the bootstrap system. When testing/applying updates #2 and #3 of this issue need to be handled too.

1 0

[drupal-devel] [feature] Nice DB error screens
by drumm 22 Jul '05

22 Jul '05

Issue status update for http://drupal.org/node/27231 Post a follow up: http://drupal.org/project/comments/add/27231 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/errorhandling_0.patch (8.44 KB) New patch with a couple suggestions from chx. * $foo === NULL is faster than is_null($foo) * Removed 'bootstrap' from the function name since it is not really part of the bootstrap system. When testing/applying updates #2 and #3 of this issue need to be handled too. drumm Previous comments: ------------------------------------------------------------------------ Thu, 21 Jul 2005 22:43:16 +0000 : drumm Attachment: http://drupal.org/files/issues/screenshot2.png (96.1 KB) Screenshot. ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:21:31 +0000 : drumm Attachment: http://drupal.org/files/issues/screenshot_10.png (88.44 KB) ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:25:57 +0000 : drumm Attachment: http://drupal.org/files/issues/druplicon.png (3.98 KB) New Druplicon which will need to replace misc/druplicon.png. The current file in that location is a giant flat druplicon which isn't used anywhere. ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:26:26 +0000 : drumm Attachment: http://drupal.org/files/issues/maintenance.css (329 bytes) Some CSS ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:30:34 +0000 : drumm Attachment: http://drupal.org/files/issues/errorhandling.patch (8.47 KB) This patch makes the database errors which occur when the database connection information is wrong or the database isn't up much nicer and more explanatory. To do this it adds a themeable function, theme_maintenance_page(), and a way to get Drupal running without a theme but the ability to execute themeable functions in the usual way. This means we can use the same code to give upgrade.php a nicer look in the future. ------------------------------------------------------------------------ Fri, 22 Jul 2005 06:33:57 +0000 : kbahey I was about to do something similar on a less ambitious scale (mainly the connect function), because what we get now is ugly and looks unprofessional. +1 from me for this. Great job! ------------------------------------------------------------------------ Fri, 22 Jul 2005 06:52:30 +0000 : gordon +1, This looks great. Get this in and then we can do something with the upgrade.php system and it will look just great.

1 0

[drupal-devel] [feature] Using taxonomy hook to add fields to taxonomy forms
by nedjo 22 Jul '05

22 Jul '05

Issue status update for http://drupal.org/node/16440 Post a follow up: http://drupal.org/project/comments/add/16440 Project: Drupal Version: cvs Component: taxonomy.module Category: feature requests Priority: normal Assigned to: chx Reported by: Jose A Reyero Updated by: nedjo Status: patch +1 in priciple (code looks good, but haven't tried it). This helps move toward parallelism in different object types. It could be useful e.g. for taxonomy images. nedjo Previous comments: ------------------------------------------------------------------------ Sun, 30 Jan 2005 18:33:50 +0000 : Jose A Reyero Attachment: http://drupal.org/files/issues/taxonomy_module_hook_form_pre_01.patch (2.04 KB) This is similar to nodeapi('form pre'...), it just uses the taxonomy hook to allow other modules to add fields at the beginning of the taxonomy's forms -terms and vocabularies. Though this one is needed for i18n, its a general feature and could be also some use for other modules. ------------------------------------------------------------------------ Sun, 30 Jan 2005 18:41:38 +0000 : Jose A Reyero Attachment: http://drupal.org/files/issues/taxonomy_module_hook_form_pre_02.patch (1.54 KB) The previous one had some unneccessary stuff, sorry ------------------------------------------------------------------------ Fri, 22 Jul 2005 18:38:00 +0000 : chx Attachment: http://drupal.org/files/issues/taxonomy_form_pre_post.patch (2.98 KB) As I was working on http://drupal.org/node/899 and on i18n I found that my needs collide on this. So, form pre and form post form taxonomy edit forms.

1 0

[drupal-devel] [feature] Enable multiple block regions (not just "left" and "right" sidebars)
by brmjo 22 Jul '05

22 Jul '05

Issue status update for http://drupal.org/node/16216 Post a follow up: http://drupal.org/project/comments/add/16216 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: nedjo Reported by: paragkenia Updated by: brmjo Status: patch Hello, I have read all the comments in this post and with the help of my friend I installed the patch in my site. Everything looks fine, the blocks menu show the diferent regions available, etc. But I have a problem: from a designer point of view, how do i 'insert' or 'supply' the new regions on a custom theme i'm creating? I have the following: </php print $sidebar_left ?> and </php print $sidebar_right ?> in diferent places of my page.tpl.php, but how do I place, or create the new regions on diferent parts of my template? Thank you for your help, sorry if there is an obvious solution to this, I'm not a programmer. brmjo Previous comments: ------------------------------------------------------------------------ Wed, 26 Jan 2005 10:27:16 +0000 : paragkenia I read the comparision discussion between *Drupal* and *Mambo*. In several messages it was outlined that Drupal can place blocks only in right and left and not flexible to put them on anywhere where one want. It will be great if this can be changed in upcoming versions. I am no pro at PHP, so don't know how much time this task will take, but I think it is very important. parag ------------------------------------------------------------------------ Fri, 15 Apr 2005 01:44:03 +0000 : nedjo This issue was apparently partially addressed in issue http://drupal.org/node/19694 [1]. [1] http://drupal.org/node/19694 ------------------------------------------------------------------------ Sun, 17 Apr 2005 00:24:38 +0000 : nedjo Attachment: http://drupal.org/files/issues/block-dynamic-regions.patch (8.17 KB) This much-requested functionality - to have the ability to place blocks in more than the two predefined regions - was partially addressed in issue http://drupal.org/node/19694. [2]. But "blocks" are still limited to the "left" and "right" sidebars (hard-coded in block.module). This patch is a first step designed to enable multiple (eventually, admin-definable) regions for blocks. I've moved the existing "left" and "right" block regions to a 'region' table (with ids of 0 and 1, as currently used in themes). Then all references to the regions are drawn dynamically from the table. This way, if further records are added, they will appear in the list of available regions for block placement. Doing this actually reduces some duplicated code, since it's no longer necessary to repeat code blocks for each of "left" and "right". As it stands, the patch doesn't add any new functionality--but I don't think it breaks anything either. New functionality would need (a) new regions defined, and (b) changes to themes. A simple first step might be, e.g., to add a "footer" region and then add a call in the footer generation to append any blocks assigned to the footer region there. I'm setting this to patch, but I'm aware that it needs some discussion and refining before it'll be ready to apply. [2] http://drupal.org/node/19694. ------------------------------------------------------------------------ Sun, 17 Apr 2005 01:05:03 +0000 : nedjo Attachment: http://drupal.org/files/issues/block_regions.png (5.65 KB) Here's a screenshot showing the block admin page, with drop-downs for region placement (the options are dynamically generated based on defined regions). ------------------------------------------------------------------------ Sun, 17 Apr 2005 02:57:01 +0000 : adrian The biggest problem with this is that you can have multiple themes, and each of these themes can have different regions available. Also, the method of defining which regions are available needs to be standardised. Some of the work that me and Vlado are working on for the install system would go towards solving that problem (ie: meta information for modules, themes and styles). This has been discussed to death, but the general consensus has been that we _want_ to do this, but we need to solve a few other problems properly first, the most pertinent being the interface issue. Chris (factoryjoe) recently did a whole mess of workflows for something related to this. ------------------------------------------------------------------------ Sun, 17 Apr 2005 04:09:30 +0000 : syscrusher The first paragraph of adrian [3]'s post is a point that occurred to me also, as I read this thread. One suggestion would be to separate the definition and configuration of blocks, on one hand, from the placement of those blocks, on the other hand. In other words, Drupal core provides a mechanism defining what blocks exist, which of these are on by default or off by default and user-selectable vs. which are forced on for all users, and the configuration (if applicable) of specialized blocks defined by particular modules. Each theme provides a standard hook function that returns an array of region names and help/description text, e.g., array('left'=>t('This vertical region is left of the main content area'), 'right'=>t('This vertical region is right of the main content area'), 'footer'=>t('The footer is below the left, right, and main content areas of the page')). The theme part of Drupal core (i.e., theme.module itself, not the individual themes) provides a standard UI that is displayed within config of *each theme* (but is one physical code base within theme.module) that allows the administrator to map blocks defined by Drupal core into regions defined by the theme, and storing that mapping as an theme-to-block_ID-to-region_ID (with weight) table in the database. From there, the actual page rendering is similar to what's being done now, but there is more of it. I guess what I'm trying to say is that the key to solving this problem is breaking it along its degrees of orthogonality, and there are three -- two in Drupal core and one in the individual theme. Scott [3] http://drupal.org//user/1517 ------------------------------------------------------------------------ Sun, 17 Apr 2005 07:14:12 +0000 : Dries Scott, is right. The theme should export its available regions. Then the administrator's task is to assign blocks to regions (not to setup regions). A theme could have configurable regions, but that internal to the theme. To me, the real challenge is the UI and the interaction design. Configuring blocks could easily become a real pain (while most themes continue to use 'left' and 'right'.) Of course, we can implement all the functionality, default everything to 'left' and 'right', and worry about the UI later. This should be fairly straightforward to implement and nedjo's patch looks like a first step in the right direction. ------------------------------------------------------------------------ Sun, 17 Apr 2005 21:09:13 +0000 : nedjo I agree with the suggested approach of themes registering their regions. I'd see this happening when a particular theme is activiated (or upgraded). Regions would be an array of names (e.g., 'left', 'right', 'footer'). New records would be created in the region table only for region names not previously registered. Some areas I'm not clear on, or that need further work: * Table naming Should a new table be 'region' or 'regions' (I've used 'region')? I don't see a convention among existing table names, some of which are singular and others plural. * Default values I've kept the existing '0' and '1' ids for regions (left and right, respectively), for backward compatibility. But this means we can't use autoincrement for the region id (rid), since autoincrements seem to begin with 1. Likely we should change to autogenerated ids. * Initial records Using the INSERT INTO statements as I've done for the initial region entries is probably counterproductive, since sooner or later they'll have to be dynamically generated. I was hoping this could be a preliminary patch, with the main work coming later, but likely we need to solve region registration by themes before this patch is applied. I don't have a good idea of how region registration by themes would be implemented (a hook on theme activation?), and invite suggestions or implementations. * Theme system changes Besides region registration, the other change I'm seeing that would be needed in the theme system is loading blocks by region name, rather than region id. This is because the ids currently used ('0' and '1') in theory might be diffferent on a particular install. ------------------------------------------------------------------------ Sun, 17 Apr 2005 21:18:33 +0000 : syscrusher Instead of having themes "register" their regions, why not just add a theme API hook called them_regions() that returns an associative array of $region_name=>t($region_helptext)? This would be in keeping with other similar API functions, such as those that return what permissions apply to a module or what node types are defined by a module. Most themes are going to define only a small number of regions (two being the typical case now, but I could see five or six in a complex theme), so returning a constant array will be faster than querying SQL to obtain an array of rows. There could be (optionally, at the discretion of whoever builds this thing) another API hook like theme_region_properties($region_name) that returns an associative array with detailed info for a given region, such as extended help text with recommended usage instructions for the region. Scott ------------------------------------------------------------------------ Sun, 17 Apr 2005 21:19:11 +0000 : syscrusher s/them_regions/theme_regions/g ------------------------------------------------------------------------ Sun, 17 Apr 2005 22:47:20 +0000 : adrian Because. The most common 'theme' is a phptemplate theme. And there needs to be a generic method for specifying the regions available, in a non hook_function format.. Themes get their names from the directory in which they are contained.. when copying the theme to another directory, there must be _no_ modifications necessary to allow normal usage. This is one of the tenets of the new template system I designed. You would need a standard way to define meta-information for themes, that does not need to be modified when copied to a new directory. We are working on this in the install system work, as you need a way external of Drupal to define the module dependencies and some other things. My approach would be to add a theme.dsc text file to the directory, which would allow you to specify meta-information. For instance : ---- regions: left, right, footer, center, mountie author: Johnny McAngstyPants ---- ------------------------------------------------------------------------ Mon, 18 Apr 2005 02:00:59 +0000 : syscrusher Adrian wrote: " Themes get their names from the directory in which they are contained.. when copying the theme to another directory, there must be _no_ modifications necessary to allow normal usage. This is one of the tenets of the new template system I designed. " A very good point. But region names don't have to be unique across different themes, so my hook function wouldn't have to be modified. The suggestion I made for the mapping metadata was three factors: theme ID or name, region ID or name, and block ID (plus one non-key weight value to order the blocks within a region, but this is not relevant here). I'm not familiar enough with PHP template to be able to respond to your comments on that one, so if you say it's not feasible to work with my schema, then I'll take your word for it. :-) Scott ------------------------------------------------------------------------ Mon, 18 Apr 2005 02:03:15 +0000 : syscrusher Oh, wait.....I see now what you mean! It's not the output of the function that is the problem, but the *name* of the function. Never mind. I concede your point. Scott ------------------------------------------------------------------------ Mon, 18 Apr 2005 07:44:19 +0000 : Jaza I'm probably jumping ahead a bit here... but something that this patch will have to eventually account for, is how to allow regions to be defined as inline. Allowing a theme to define a region's position as being anywhere on the edge of the page (i.e. top, left, right, bottom, corners, etc) is relatively easy. But what about having a region that's in the middle of a node's body, or somewhere else that's not the edge of the page? What I'm thinking of, is eventually allowing the custom region system to integrate with the CCK. Like I said, I admit that I'm jumping ahead into the future - the CCK still has a long way to go before it's ready. But ultimately, it would be cool if a theme could define a region as being after, say, the "rating" field in nodes of type "movie review". This would make the region (and the blocks in it) truly inline and in context with the actual content of the node. This would be a huge step forward compared to the current block system, which doesn't allow you to mix the presentation of blocks and nodes at all. In Drupal ATM, blocks and "the rest of the page" are totally separate, and really you have no choice but to display them as such. The result of this is that information in blocks that really should be displayed as part of a node, gets literally "pushed to the side", and always seems secondary to the actual content. Often the block has content that is just as important as the content of the node itself. Another option (of less merit, IMO - because of the extra maintenance work, and lack of enforced consistency) would be to have a region filter. You could then choose where to place an inline region on a per-node basis, by entering text such as [region:2] (example based on image_filter syntax) into the node body. Anyway, just thought I'd throw that idea into the open. I don't expect it will be implemented any time soon, but it's something to think about. Jeremy ------------------------------------------------------------------------ Mon, 18 Apr 2005 08:54:40 +0000 : stefan nagtegaal Attachment: http://drupal.org/files/issues/regions---possibility-1.png (1.29 KB) Imo the 'regions' are more than you guys name here.. FOr example I attached 2 screens which only shows you the regions.. What I think is that it should always be possible to have free names for the regions. No matter if i call - the region where my content appears in - 'content' or 'site items'.. See attached screens.. ------------------------------------------------------------------------ Mon, 18 Apr 2005 08:56:31 +0000 : stefan nagtegaal Attachment: http://drupal.org/files/issues/regions---possibility-2.png (1.39 KB) And the second... See these links: - http://drupal.org/files/issues/regions---possibility-1.png - http://drupal.org/files/issues/regions---possibility-2.png ------------------------------------------------------------------------ Mon, 18 Apr 2005 15:22:42 +0000 : nedjo Attachment: http://drupal.org/files/issues/block-dynamic-regions2.patch (13.39 KB) Here's a revised patch implementing some of the ideas so far. I've used the theme engine - rather than individual themes - to generate the list of available regions. I know this isn't ideal, but e.g. for xtemplate it's at present the only option--no logic is possible in the individual theme. region is changed to a varchar field from the current tinyint. I've roughed in several regions--really just for demo purposes. More thought and work would be needed to refine them (e.g., styling, etc.). But this maybe moves the conversation forward. ------------------------------------------------------------------------ Mon, 18 Apr 2005 21:26:56 +0000 : Dries This patch enables different regions to be used. That is a good thing. The next question is: should we take into account that different themes could assign blocks to different regions? Lots of problems would be solved if (i) there could only be one active theme on a website or (ii) if all themes would have a common set of regions. (This "let users select their own theme"-thing is a left-over from the early days, except for WAP stuff maybe.) ------------------------------------------------------------------------ Mon, 18 Apr 2005 21:37:04 +0000 : killes(a)www.drop.org Giving up multiple theme support would be a great thing. People could still select from multiple style sheets. WAP shoud not be a user preference setting, but automatically detected and redirected to a special site with a WAP theme. ------------------------------------------------------------------------ Mon, 18 Apr 2005 21:48:42 +0000 : adrian You would then lose the ability to make a special front page theme for use with the sections module, for instance. Also, currently styles exist in the same namespace as themes, and we would have to make more a distinction of styles vs templates (or themes), but I do think this could help simplify things. ------------------------------------------------------------------------ Thu, 21 Apr 2005 16:54:03 +0000 : nedjo Attachment: http://drupal.org/files/issues/block-dynamic-regions3.patch (15.69 KB) The main issue raised, if I'm understanding well: if a theme or theme engine is present that offers regions other than those available in the default theme, any blocks assigned to those regions will be invisible to most users. Here's a revised patch addressing the concern. I've added a test for each region to see whether it's also available in the current default theme. (Actually, I'm realizing as I write this, I've used the theme engine--so it would need to be updated to test first if an engine is being used.) In any case, any regions not available by default are starred, and a message text appears (only if necessary). If there's support for the approach, I'd be happy to finish the patch. Remaining work: * extend to work with non-engine themes * finalize base set of regions to implement * implement common region set in all core themes (for now I've only done xtemplate) * work on CSS display (how blocks in each region should look) This last point I'm not too confident on and would look for help/suggestions. Screenshot to come. ------------------------------------------------------------------------ Thu, 21 Apr 2005 16:56:41 +0000 : nedjo Attachment: http://drupal.org/files/issues/block_regions_message.png (12.34 KB) Screenshot showing starring of non-default regions plus message. ------------------------------------------------------------------------ Thu, 21 Apr 2005 17:19:19 +0000 : killes(a)www.drop.org I like that approach. +1 ------------------------------------------------------------------------ Thu, 21 Apr 2005 17:23:56 +0000 : resmini My two cents. If this has to be done (and it should), better get rid of spatial definitions for areas such as left, right, top, bottom, etc. Use semantic names related to content and let the theme take care of their positioning interely. Also note that there in an ongoing debate in IA trying to build up a standard naming convention for page regions in a way that is semantically (and logically) correct. Just for the sake of it, you can check http://www.stuffandnonsense.co.uk/archives/whats_in_a_name.html http://www.stuffandnonsense.co.uk/archives/whats_in_a_name_pt2.html with follow-ups, including Eric Meyer's. There are more substantial contributes in the AIfIA web site, but I can't seem to find them now. I'll post a link or an abstract if I manage to. -- vector at exea dot it ------------------------------------------------------------------------ Thu, 21 Apr 2005 18:15:49 +0000 : nedjo Good points, useful references. The default regions I'm thinking of are: 'banner' => t('banner'), 'left' => t('left sidebar'), 'right' => t('right sidebar'), 'body_top' => t('body top'), 'body_bottom' => t('body bottom'), 'footer' => t('footer') Perhaps "body" would be better as "content"? It would be easy enough to add in more regions, e.g., within the content (after title, after help, etc.) One issue is that many of these regions will already have rendered content. Should the blocks come before or after that other content? I've assumed after for banner and footer, while giving both options in body. In any case, refinements or suggestions would be great. ------------------------------------------------------------------------ Thu, 21 Apr 2005 18:56:50 +0000 : resmini Well, 'banner' => t('banner'), 'left' => t('left sidebar'), 'right' => t('right sidebar'), 'body_top' => t('body top'), 'body_bottom' => t('body bottom'), 'footer' => t('footer') The classic (as far as classic goes for something Web related) scheme comprises 5 spatial regions, much like stefan's http://drupal.org/files/issues/regions---possibility-1.png with a left area mirroring the one called 'blocks'. Call them top, left, center, right, bottom. Variants usually exclude one or more of these, layout-wise. If we talk content (semantic) instead, things get a bit more complicated, as these spatial regions normally include more than one content-area. The top, for example, could include ad banners and the site's header, or the main menu. But these merge seamlessly with CSS definitions, which are definitely something that should get properly standardized (most of the errors / inconsistencies I'm encountering with Drupal today are related to this), but this is out of scope in this thread. What I somewhat object to the definitions above is that it mixes the two approaches. 'banner' is not spatial, is content, as it is the distinction between body top and bottom. If 'banner' goes there, it is 'top', whatever that might be. I designed a couple of web sites which had headers/logos/banners at the bottom of the page, and I'm not exactly the wildest designer you'll probably meet. And if we include body_top and _bottom, we should also add 'navigation', or 'menu' and some other content-related semantic region (impressum, or company_data, or whatever). I suggest that either we go along 'top' => t('banner'), 'left' => t('left sidebar'), 'center' => t('body'), 'right' => t('right sidebar'), 'bottom' => t('footer') or we dedicate some time to detailing what could possibly fit there semantically, which is perfectly possible without limiting design freedom or whatever, since the vocabulary is not infinite, but not something you do out of the blue. Please note that I understand t('something') to be an example, since such a layout only defines regions on the page, not semantic regions. My main content could fit nicely in the bottom region. As for the names for the regions, they are not important, as much as they are coherent and enforced. ------------------------------------------------------------------------ Thu, 21 Apr 2005 21:16:45 +0000 : stefan nagtegaal Attachment: http://drupal.org/files/issues/regions-final.png (2.39 KB) Maybe something like this??? But, I have to say that I _really_ liked the solution to split the 'content'-region into the 'content' and 'beneath content'.. I love that! ------------------------------------------------------------------------ Thu, 21 Apr 2005 22:20:26 +0000 : resmini Stefan, yes. That's basically what you can build if you stick with spatial, and this layout can generate quite an amount of (sane) layout variations even if you interpret it strictly (suppose a default) as <div id="header"> </div> <div id="left-bar"> </div> <div id="content"> </div> <div id="right-bar"> </div> <div id="footer"> </div> What you can do with this is left basically to the theme designers and their use of CSS, CSS-P or tables (brrr), but this could be an easy and proper way to identify macro-regions in which more accurate positioning happens at a more specific level. I'm all in favour of subsequent identification of sub-areas (top and bottom in body), but I don't think it would be a good idea to mix the different approaches I mentioned in my previous post. A site with lots of things going on or which is not just blogging surely has the need to use its content area in a wiser manner than just putting there 'content', the number of modules doing precisely this is more than proof, but that falls more in a 'Drupal definitive guide to semantics', in which CSS selectors are used or suggested strategically for such a scope. >From this point of view and for the sake of this thread, any unique area / div (#name) could (should?) be a target for blocks, and this in my opinion (*) would be the perfect solution, but I do not know if and how this is even remotely possible in the current Drupal. (*) It's quite late, local time, and it was a looong working day. ------------------------------------------------------------------------ Thu, 21 Apr 2005 22:38:53 +0000 : resmini Attachment: http://drupal.org/files/issues/regions-final-variation.png (1.9 KB) Just to be clear, I add a variation of stefan's scheme that shows how this is *not* by any means positional, but spatial, or better relational. Use your CSS imagination to take out regions, reduce them to empty containers, enlarge them, make them taller, shorter, whatever. 5 regions, do what you like. ------------------------------------------------------------------------ Thu, 21 Apr 2005 22:44:41 +0000 : resmini Sorry, I forgot. And this is also why I'm not too keen on calling anything 'content'. If I enlarge my right region enough, why not put my content there? Shouldn't this be a theme-level concern? It's nothing serious, but if my center area is called 'center' (or something similar and more sexy), I won't confuse anybody. This is left, center, right: do with them what you prefer. Content in the bottom? Show me. If I call something 'content', I'm more than suggesting that content goes there, and only there. ------------------------------------------------------------------------ Fri, 22 Apr 2005 08:17:39 +0000 : stefan nagtegaal Resmini, maybe it is only me but I think that you are making a mistake in your way of thinking.. I get the feeling that you're mixing the 'regions' and 'divs'.. the 'regioins' should have meaningfull sentences, but the divs shouldn'thave.. As an example: $region_name => $content_body here we go: 'header' => $logo 'left sidebar' => theme('blocks', 'left') 'right sidebar' => theme('blocks', 'right') 'content' => $content 'footer' => $footer. So, $region_name does not have to be equal to the id or class of the divs.. ------------------------------------------------------------------------ Fri, 22 Apr 2005 09:27:25 +0000 : resmini Stefan, >So, $region_name does not have to be equal to the id or class of the divs.. Yes, absolutely. I probably didn't make myself very clear: what I'm trying to point out is that in 'header' => $logo 'left sidebar' => theme('blocks', 'left') 'right sidebar' => theme('blocks', 'right') 'content' => $content 'footer' => $footer. there is no reason at all to call 'content' the region that holds $content. nedjo asked in #24 'body_top' => t('body top'), 'body_bottom' => t('body bottom'), if /Perhaps "body" would be better as "content"?/ and all my reasoning is simply that no, that is not content, or it shouldn't be (or better: it may happen that main content is elsewhere). As a matter of fact, even the connotation 'sidebar' doesn't fit very well logically. To make it short: Today's method works, but has limits. Mambo, which paragkenia quotes at the beginning, handles more 'user regions' but in pure Mambo style conventions are so loose that they are hardly useful. If we define regions, as in nedjo's example, in my opinion these regions shouldn't imply informational layouting, only relational positioning (that is, where they stay in the browser viewport). I know it may look like overdesigning, but Drupal constantly enforces conventions and coding guidelines everywhere: this is one of the best aspects of the project and I think it should carry to the layout. ------------------------------------------------------------------------ Fri, 22 Apr 2005 09:32:48 +0000 : stefan nagtegaal While I think that 'body_*' is not as self explaining as 'content_*' I vote for using 'content_*'.. ------------------------------------------------------------------------ Mon, 25 Apr 2005 17:48:24 +0000 : chx Let's get back to the code. If my understanding is correct the big discussion is about how to name potiental rectangular areas _after_ this is commited. So, first get this committed. What's need to make that happen? ------------------------------------------------------------------------ Mon, 25 Apr 2005 18:56:07 +0000 : chx I spoke with Moshe, Steven, JonBob and the result is: keys shall be numbers, and themes shall define the values. We will make region zero and one required. There will be a define('REGION_CONTENT', 0) and a define('REGION_SIDEBAR', 1); so you can have readable code still. Either wait for me to code it or feel to do it yourself, just drop me a mail via the contact form if you are doing it. ------------------------------------------------------------------------ Wed, 27 Apr 2005 16:14:25 +0000 : nedjo Károly, it's great if you're willing to take on finishing this. I tried to summarize remaining work in update 20, above [4]. The numerical keys look fine to me. In terms of an initial default set of regions, one quirk is this: for now, so far as I can see (and assuming the approach I sketched in), available regions can be defined only in (a) theme engines and (b) individual themes that don't use an engine. So, for instance, an individual xtemplate based theme can't define its own custom regions; they need to be defined in the theme engine. (Unless and until the whole theme system should switch to the sort of configuration file adrian suggested above [5].) Which is to say that, under this approach, we'll be defining a set of regions for each engine, and then all themes using that engine should try to implement those regions. (Otherwise, if a site admin selects a region defined in the engine but not implemented in the default theme, the content won't appear.) Please let me know if there's anything in what I've done that isn't clear, or if you want to pass some or all of this back. Thanks! [4] http://www.drupal.org/node/16216#comment-27398 [5] http://www.drupal.org/node/16216#comment-27052 ------------------------------------------------------------------------ Mon, 09 May 2005 20:36:03 +0000 : chx I had a "short" discussion with the UI team leader ie. Ber Kessels. The outcoming is that we will change hook_block so that it uses callbacks a bit like menu system. Here's an example: <?php function module_block() { $items = array(); $items['module_header'] = array('callback' => 'mymodule_page', 'weight' => -50, 'region' => 'content' , 'cache' => TRUE, 'pages' => "node/*\n<front>"); return $items; } ?> Please note that we are allowing caching the themed output of each block independently. The theme system will execute hook_block as it does now and it'll execute the callbacks defined in module_block as well. Of course if the callback is cacheable and in the cache, it'll print it from cache. If it's themeable and not in the cache, it'll cache it before printing. Pages contains a string (could be PHP code!) which can be overriden in the block configuration screen. Callbacks defined in hook_menu will have lot less functionality after this, they will be used for non-themed pages mainly. ------------------------------------------------------------------------ Mon, 09 May 2005 20:45:37 +0000 : chx More explanation is requested for the example. module_header is the unqiue name of the block. pages define on which pages the block is visible. ('pages' in the block configuration screen.) Maybe I'll implement 'visibility' from the same screen as well. callback, weight are well known Drupal terms. cache is a boolean which defines whether given output is cacheable or not. ------------------------------------------------------------------------ Mon, 09 May 2005 20:47:53 +0000 : chx Ber, Dries, do not kill me! Ber chaired the usability meeting in Antwerp, that's all. ------------------------------------------------------------------------ Mon, 09 May 2005 20:52:11 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/more_regions_principle.png (123.29 KB) attached is a schematic which might clarify this a little. And I would also like to comment on me being the UI leader: I do not consider myself any leader, no ofeence, though. Just to clarify that. ------------------------------------------------------------------------ Mon, 09 May 2005 22:42:48 +0000 : nedjo I am not opposed to the idea of changing the _block() hook to use callbacks (I have no opinion on it, not immediately grasping the need), but this seems quite distinct from the aim of enabling multiple and extensible regions. Why can't we just move ahead with the block generalization? I suggest: * quickly implement the proposed block region generalization, using only the two existing regions (i.e., implementing them in core themes) * later worry about: - adding further regions (the details of which are best done by those primarily responsible for the particular themes) - possible changes to the _block() hook. Wouldn't this make sense? Or am I missing some pressing reason for which the block generalization has to wait? ------------------------------------------------------------------------ Tue, 10 May 2005 01:28:21 +0000 : killes(a)www.drop.org "Or am I missing some pressing reason for which the block generalization has to wait?" I might be missing something too, but I thought Chx was just talking about the block generalization and proposing a way to code it. ------------------------------------------------------------------------ Tue, 10 May 2005 02:41:08 +0000 : factoryjoe I wanted to chime in with this discussion because it's an important one and has some really huge implications for Drupal moving forward. That said, I also have a day job pulling all my attention which means that the big ideas I have for this problem can't be put into a complete visual form for at least a week or more. In the meantime, I'd like to offer a few thoughts on the matter. * *Regions do not belong in themes.* Blocks were originally separate from themes for a reason. Themes should define the general look and feel of a site -- and to some extent a site's behavior. Layouts which define the spatial relationship between regions belong in some intermediary between style and content, which does not currently exist in Drupal. * I would propose that *layouts become a new kind of CCK tool.* By that I mean that they can be defined, shared and deployed very easily -- even as simply as tossing a directory of some .layout textfiles into a layouts/ directory. Note that this suggestion has nothing to do with the way CCK /might actually/ work right now; instead I'm suggesting how I would like it to work. I would like, for example, to create a CCK item like a "person" and ship it with a .layout file that carries all the semantic goodness needed to output that "person" to the screen in juicy, semantic markup... which anyone can come along and theme to their heart's content. * *Creating shareable layouts should be relatively painless.* Dashboard [6] sets the bar for easy hackability. It should be that easy to create layouts for Drupal... I can imagine creating an "iTunes layout" or an "Image Gallery" layout and so on... If we used something akin to PHPTal to develop the layouts, we could keep development fairly standard while making it possible for more folks to hack up cool and innovative layouts. * *Layouts should be extensible.. to a degree.* I see a huge problem with how this discussion has floated back and forth between semantic and spatial region naming. Because we talk about this problem in those terms, we fail to identify the real problem and opportunities presented to us. Here's the thing: when you predefine regions, you limit creativity and the ability of people to really use the system. On the other hand, when you make a system too flexibile, it quickly becomes unwieldy. In all the mockups presented above, both classes of problems would arise. Therefore we need to think about a way to stay flexibile while "taming the beast." * To that end, I suggest developing *self-contained layouts that are contextually-complete.* So for the example of the iTunes search layout... you would know before hand that you get a couple multiple select boxes that you can hook up to whatever taxonomies you want to progressively filter [nodes]. You could even change the .layout file, allowing you to theme it to your liking -- even though that would totally optional, given the layout's internal default styling. Once you've got your layout, you would go into a layout module UI [7], create a new layout [8], select the layout from a list [9] and then give it a path so you can access the layout... You would then walk through a wizard [10] that would help you populate that layout with all kinds of nice Drupally goodies... feeds, node listings, PHP code, etc. The power in this approach is multifold. For one, it snaps Drupal out of its block mentality and allows designers to really innovate with individual page designs. In fact, I've already thought out how I could reimplement Flickr using this system, combined with Drupal's native feeds, taxonomy and menu module, and I'd barely break a sweat... sort of. ;) But anyway, this is a very productive conversation to be having, but I really think that we should consider whether the old paradigm, as such, really pushes Drupal as far forward as we have the opportunity to go. [6] http://drupal.org/apple.com/macosx/theater/dashboard.html [7] http://photos4.flickr.com/6944826_90af237c99_o.png [8] http://www.factorycity.net/demos/civicspace/layout/new.html [9] http://www.factorycity.net/demos/civicspace/layout/new_layout.html [10] http://www.factorycity.net/demos/civicspace/layout/testing_add.html ------------------------------------------------------------------------ Tue, 10 May 2005 04:34:07 +0000 : chx While factoryjoe may be right, I could be right as well. Regions has definitely something to do with themes, after all it's the theme that renders the page, and it can only render regions that it knows of. So, instead of postponing this into the far future when someone comes out with a layout system, I code this now. ------------------------------------------------------------------------ Tue, 10 May 2005 05:22:04 +0000 : Dries The proposed 'weight', 'region' and 'pages' would be configurable, not? Are these just defaults? The 'callback' and 'cache' options are nice to have. ------------------------------------------------------------------------ Tue, 10 May 2005 05:25:45 +0000 : chx Yes, blocks can provide a default for everything on the block and and configuration screen. Of course, you can override these in the UI. ------------------------------------------------------------------------ Tue, 10 May 2005 09:02:53 +0000 : Bèr Kessels Dries: yes, the region, weight and pages will be configurable from an admin interface. What we tried to address here, is a method for developers to choose good defaults. Take for example "logo". that should be enabled by default in a regions called header, rendered on all pages, and have a very light weight. We should not force an admin to visit the blocks admin before she can see or use the logo. Chris: I do not know if you have ever tried typo3. Its concept is some form of builder system. I do not like thar, because far too complex. If we ever get sme kind of builder in core (if ever) it will require a lot of work, and even more usability research. So for now such a builder is far out of our reach. Lets aim at goals that are more realistic ;) So: it does belong in themes, its the best place that is still realistic. I do like your visions, Chris, but I hope you agree they are not realistic, yet. So, maybe you can think of a path towards your visions, ow we can reach such a builder-system, you describe? ------------------------------------------------------------------------ Tue, 10 May 2005 14:52:08 +0000 : factoryjoe My browser crashed before I was able to submit my followup to chx's comment... I have no problem with the current work going forward and am happy to see it happening. I know that my ideas are typically outlandlish and far off... That's the kind of design I enjoy doing! In any case, I see chx's solution being a means to an end; once we have abstracted the region code, it become much easier for me to get some help creating my vision. In the meantime, and as a demonstration of how I see this layout system working (to answer, I hope, Ber's concerns about clunkiness), I've created a workflow movie that shows off how fast you'd be able to add content to the system. Check it out: http://factorycity.net/demos/civicspace/layout/media/layout_workflow_v1.mov Feedback appreciated. And, if you want to try the demo out yourself (it's all hardcoded, like a "movie set" for my UI), go here: http://factorycity.net/demos/civicspace/layout/ ------------------------------------------------------------------------ Thu, 12 May 2005 16:45:04 +0000 : nedjo Attachment: http://drupal.org/files/issues/block-dynamic-regions4.patch (13.56 KB) "I might be missing something too, but I thought Chx was just talking about the block generalization and proposing a way to code it. " Well, if I can say so respectfully, I don't think so. Not so far as I can see identifying problems with my original patch, this interesting discussion is rather addressing the (useful, but logically subsequent) question "once we have multiple regions, how should we work with them?". It's perhaps demonstrating our propensity to try to do more rather than less with a given patch--to talk for a long time when a first step solution is already in place. So here is a (yes, interim!) small, focused, and tested patch to remove the hard-coded regions. I've stripped it down so it does nothing more than (a) make block regions declared by themes rather than hard-coded and (b) implement the existing left and right regions in existing core themes. Please, try it out, I think you'll like it. I'm of the (I'm hoping not scandalous) opinion that it can be applied right away, and so clear the way for further progress. In particular, this patch leaves the adding and configuring of additional regions to theme authors/maintainers, who are best qualified for the work. "I spoke with Moshe, Steven, JonBob and the result is: keys shall be numbers, and themes shall define the values. We will make region zero and one required. " The reason I moved from numbers to strings (e.g., "left") is that a theme author defining regions has no way of knowing what regions might have already been defined, and therefore what integers might have aleady been used. It's like module and theme names--we'd have to use random numbers to avoid conflicts, so we're better off with string names. ------------------------------------------------------------------------ Thu, 12 May 2005 18:17:31 +0000 : Bèr Kessels nedjo, I am not a fan of your solution for blocks that dissapear. It breaks the ability to allow more themes on a site. if important blocks dont show up, your site will simply break. I would rather suggest that every theme MUST have a region called 'default'. any blocks that want to go into a non-existing region, will be placed there. We must define a standard listy of suggested region names. to avoid a wildgrowth of names. I am not sure if i like the way you do function phptemplate_regions(). these regions should be defined in the templqtes, not the engine. Otherwise all phptemplate themes will still all have two regions. Note that i did not test your patch thouroughly, just applied and looked at. ------------------------------------------------------------------------ Thu, 12 May 2005 19:38:02 +0000 : nedjo Thanks for your comments. I think we're getting somewhere. "I am not a fan of your solution for blocks that dissapear. It breaks the ability to allow more themes on a site. if important blocks dont show up, your site will simply break. I would rather suggest that every theme MUST have a region called 'default'. any blocks that want to go into a non-existing region, will be placed there. " Good suggestion. Having a default region for blocks to show up sounds like a valuable backup. I'm thinking we might want to have a way to designate a given region as the default, rather than having to have one named 'default'. Thoughts? "We must define a standard listy of suggested region names. to avoid a wildgrowth of names. " Sure. But the patch doesn't prevent doing that--it enables it. "I am not sure if i like the way you do function phptemplate_regions(). these regions should be defined in the templqtes, not the engine. Otherwise all phptemplate themes will still all have two regions. " Oh, I wholeheartedly agree, and I've noted the issue above. But unless we substantially rewrite the engines, some region definition is needed in the engines, as they call blocks. Should we therefore define a base set in the engine, then call a hook from the engine to add any other regions from themes based on that engine? If so, where in the theme's files should such a hook be located? And a side note. Do let's make an effort to keep our comments friendly. Taking the time to note one or two things that do work or are done well as part of a review is I believe a valuable habit. It helps to confirm what is indeed accomplished. Beyond this, it helps to maintain the idea that we are collaborating on shared goals, rather than pushing individual and competing visions, and that contributions and work are appreciated, rather than being invitations to criticism. Thanks, Nedjo ------------------------------------------------------------------------ Thu, 12 May 2005 19:42:47 +0000 : chx I am implementing http://drupal.org/node/16216#comment-29282 but it takes time. regions again have names. default and sidebar regions are mandatory. This has little to do with nedjo's code much more with his idea -- I looked at the screenshot and said, OK this is great but... we'd like to have a lot more 'blocks' if this comes through, henceforth the above mentioned solution. ------------------------------------------------------------------------ Thu, 12 May 2005 20:39:48 +0000 : nedjo Okay, thanks for the clarification, I hadn't understood that you were taking a new approach rather than building on what I'd begun. Given that that's the case, staging as I'd suggested obviously won't work so I'm content to wait and see what you accomplish. I'd only suggest, don't feel like you need necessarily to do everything all at once. ------------------------------------------------------------------------ Fri, 13 May 2005 08:34:04 +0000 : Bèr Kessels Nedjo, sorry if the sound of my comment was hostile. it was never meant to be that way. I am busy, and thus did not want to comment all the things i liked about your patch, but chose to pick the much smaller amount of things I thought could use some improvement. I will try to keep in mind to be more friendly next times. Also, not all of us are as fluent in English as our native English speakers. I think its good to keep in mind that for a lot of us, communication in English is not as easy as it may seem. For me, it often requires a lot of concentration to get the subtleties right. I mean: I can type some English text, look up words in the dictionary, but to get small yet important subtleties in my texts is very hard, often. But, that all said: I liked your patch. ------------------------------------------------------------------------ Fri, 10 Jun 2005 11:08:46 +0000 : jakeg How far off is this from being officially released or at least usable? If its usable now, what files will I need to implement it? ------------------------------------------------------------------------ Fri, 10 Jun 2005 12:19:09 +0000 : Kobus Attachment: http://drupal.org/files/issues/regions---possibility-3.png (2.21 KB) To add to Stefan's suggestions with the two screenshots, I modified one of them a bit, and this is how I understand Jaza's post, and yes, I agree, this would be a wonderful feature! I can't wait! Imagine how good it would look if I had a theme that has a clear white background (not visible blocks) and then these seemingly random boxes on the page, as shown in the screenshot. Especially where I can place it anywhere around the node like Jaza said with a [region:2] block etc. I say again: I can't wait! Kobus ------------------------------------------------------------------------ Fri, 10 Jun 2005 13:59:03 +0000 : chx I need 3-4 hrs of peace to implement the callback based thing. That's a lot these days. Let's hope I'll get on it in the following days. ------------------------------------------------------------------------ Sat, 18 Jun 2005 22:32:09 +0000 : chx Here's an example again of how hook_block will look like: <?php function module_block() { $items = array(); $items['module_header'] = array('callback' => 'mymodule_function', 'callback arguments' => arg(1), 'weight' => -50, 'region' => 'content', 'cache' => TRUE, ''pages' => "node/*\n<front>"); return $items; } ?> Items are keyed by unique IDs. The template system will call module_invoke_all('block'), put the rendered HTML of the blocks into regions sorted by weight. The rendered HTML is cached if it is allowed. More keys will be introduced later, but now basically we just throw everything from block configure in here, and add callback, callback arguments, region. Node teasers or fullly rendered nodes are blocks, too. Almost everything is. So, here what happens when we are on taxonomy/term/1: taxonomy_render_nodes is called it calls block_set('node_view', $weight, $node, $teaser, $page); a few times, so a few node_view blocks will be on the page later the theme system is invoked. It will ask the block system to collect all blocks, dynamic and the static blocks as well. For all dynamic blocks we have a block defined in hook_block somewhere, like the definition above, with one exception: it will have a 'standalone' => FALSE pair, so it is not a standalone block which is automatically rendered but something that needs to explicitely requested. Also, we may define a 'suffix' => 'somefunction' pair which provides us with a cache ID suffix. Look at the code below: <?php function block_collect_blocks() { // get all block definitions $static_blocks = module_invoke_all('block'); // iterate of the dynamic blocks set on the page foreach (block_get() as $dynamic_block) { // get the block definition for the given dynamic block $static_block = $static_blocks[$dynamic_block['block']]; // merge the callback arguments from the dynamic and static. dynamic_block['callback arguments'] is always set though // may be empty if (isset($static_block['callback arguments'])) { $dynamic_block['callback arguments'] = array_merge($static_block['arguments'], $dynamic_block['callback arguments']); } // try to get a cache ID suffix $suffix = function_exists($static_block['suffix']) && call_user_func_array($static_block['suffix'], $dynamic_block['callback arguments']); // if the block is cacheable or the suffix function says that it is cacheable by setting a suffix if ($static_block['cache'] || $suffix) { // set cache ID $cid = 'block:'. $dynamic_block['block'] .':'. $suffix; // try to get the rendered HTML from cache if ($block_rendered = cache_get($cid)) { $return[$static_block['region'][$dynamic_block['weight']][] = $static_block_rendered; continue; } } // render the block $block_rendered = call_user_func_array($static_block['callback'], $dynamic_block['callback arguments']); // store the block for return $return[$static_block['region'][$dynamic_block['weight']][] = $static_block_rendered; if ($static_block['cache'] || $suffix) { // if cacheable, do it cache_set($cid, $static_block_rendered); } } foreach ($static_blocks as $key => $static_block) { // is this a stand alone block, like in Drupal 4.6? if ($static_block['standalone']) { // now, the above is repeated, save that we do not have a dynamic_block here $suffix = function_exists($static_block['suffix']) && call_user_func_array($static_block['suffix'], $static_block['callback arguments']); if ($static_block['cache'] || $suffix) { $cid = "block:$key:$suffix"; if ($block_rendered = cache_get($cid)) { $return[$static_block['region'][$static_block['weight']][] = $static_block_rendered; continue; } } $block_rendered = call_user_func_array($static_block['callback'], $static_block['callback arguments']); $return[$static_block['region']][$static_block['weight']][] = $static_block_rendered; if ($static_block['cache'] || $suffix) { cache_set($cid, $static_block_rendered); } } } } function block_set() { static $blocks; $args = func_get_args(); if (count($args)) { $callback = array_shift($args); $weight = array_shift($args); $blocks[] = array('block' => $function, 'weight' => $weight, 'callback arguments' => $args); } return $blocks; } function block_get() { return block_set(); } ?> When to expire the block cache? Never. If functions can call cache_clear all, they can be smart enough to cache_clear only those blocks that are changed by them. Some blocks won't be cacheable anyways, say there is little use in caching 'active forum topics' ------------------------------------------------------------------------ Sun, 19 Jun 2005 07:15:00 +0000 : Dries Frankly, I don't understand what you are trying to say. What is a 'dynamic', a 'static' and a 'standalone block'? What is the suffix for? What is the advantage of making node and taxonomy views blocks? If there is no big advantage, this is just bloat. All in all, it looks pretty complex to me. If we make Drupal more flexible _and_ more complex, people will get upset, and we end up being like Plone. Drupal's simplicity is something to foster, as it allows people to go in, and change stuff. The focus is to make Drupal simpler _and_ more flexible. I merely spent 10 minutes looking at this (reading your explanation twice, staring at the code), and the newly added complexity simply turns me off. Maybe that is because I don't understand what we are gaining. ------------------------------------------------------------------------ Sun, 19 Jun 2005 07:34:33 +0000 : Bèr Kessels * The first thing we gain, is, very slmple: more regions. But, how many? what regions? on what pages? in what location? bearing which name? For all these issues we need some callback system. To allow themers, administrators and module developers to give answers to all these questions. what we have now: sidebars, with only admin settings, is simply too limited: It takes serious hacking (~15 lines of code in your theme) to get a login block in your header! * The second thing we get for free: We are passing along chuncks of HTML, so why not cache them in a central place. Practice points out that our current cache is not used well. We leave it to developers to cache. And developers are lazy by nature. Just looks at all the places where caching should have been done, but is not. 9/10contribs have at least one of these places. You must actually see these issues separate. The new central blocks pulling system, and the caching. the latter is something that we get for free, a high level of advanced caching (how often has not been put forward Drupal seiously lacks better/advanced caching?). But we get it only for free if it is co-developed with the new regions blocks. And Last but not least, everything is a block, from a themer point of veiw. I know developers tend to think: I do the content, and do not care about where and how it turns up. That results in a content-centric system, what we have now. Everythng is built around aa single chunk of content. while, in fact content, is yet another block. Look at http://www.terminus1525.ca/index.php?l=en or http://www.franklinpennsylvania.us/ as it stands now, its up to the developer to concenate all the HTML in the center area, into a huge chunk of HTML. While in fact everyone can see that these are a lot of separate blocks. ------------------------------------------------------------------------ Sun, 19 Jun 2005 07:39:48 +0000 : Dries Ber: I was talking about chx's latest changes, not the block system in general. ------------------------------------------------------------------------ Mon, 20 Jun 2005 18:06:47 +0000 : nedjo I appreciate the update on directions being contemplated, although I find it confusing. Again, I'd caution, let's keep focused on the aim at hand, and on a staged solution. A bigger patch means greater complexity, more difficulty getting meaningful review, and greater delays in getting a priority change. We're currently in a position where we have two hard-coded regions for blocks, a major issue if nothing else than because it reflects poorly on Drupal's usability and versatility. Moving from here directly to something like "everything you see anywhere is a (nested) block in its own (nested) region" strikes me as a bigger step than we need to take. And in belated reply to Ber's note (#53 above [11]), thanks for the thoughtful comments, I didn't mean to single you out and acknowledge that language & cultural differences play a role, I feel we can all benefit from attention to communication. [11] http://www.drupal.org/node/16216#comment-29633 ------------------------------------------------------------------------ Tue, 21 Jun 2005 19:39:59 +0000 : Dries Even with the explanation in chx's sandbox, this is too complex for my likings. Here is a suggestion: let's drop the caching and the 'suffix'-stuff. Let's also drop the 'complete' and 'incomplete' stuff. Keep it _simple_, chx. IMO, you're creating a monster. ------------------------------------------------------------------------ Wed, 22 Jun 2005 20:47:08 +0000 : chx nedjo, take over. I am out. ------------------------------------------------------------------------ Wed, 22 Jun 2005 22:51:14 +0000 : djnz Quick and dirty solution? Let blocks be assignable to 9 locations - Top left, middle, right, middle left, middle right, bottom left, middle, right. The actual location of these areas within a theme is up to a theme designer, but the designer should include each of them - how about $sidebar['tl'], $sidebar['tm'], $sidebar['tr'] ... Backwards theme compatibility could easily be maintained by only creating the $sidebar array if the theme has set (eg in its template.php file for a PHPtemplate theme) a flag, otherwise generate $sidebar_left from the blocks set (in sequence) to top left, middle left, bottom left, top middle and middle middle (arbitrary break) with $sidebar_right the remainder. I appreciate I have no karma here and only superficial knowledge of the Drupal code, but sometimes the clarity of a view unclouded by too much information is useful ;) ------------------------------------------------------------------------ Mon, 27 Jun 2005 06:26:17 +0000 : nedjo Attachment: http://drupal.org/files/issues/regioning.patch (24.74 KB) " nedjo, take over. I am out. " Um, okay. I've given the question some more thought and come to the following conclusions: 1. If we take regions to be areas of the page that specific types of content are rendered into, and a regioning system to be a system to accomplish this, we already have a number of regions and different types of regioning systems. They include: (a) our current blocks system, and (b) the various drupal_set_[region]() functions, like drupal_set_comment(). (c) specialized hooks like our help system, which assembles content to be rendered into a region. 2. LIkely we should tease out regions from blocks. So attached is a next rough cut at regioning. Features: * Default region is defined in general admin settings page * Regions are defined in both engines and themes. A particular engine-based theme has the regions it defines plus the engine's default ones. * Content can be written to regions in two ways: through blocks or through drupal_set_content($region, $content) calls. Initial comments are welcome. I'll work on getting a more polished patch and also more explanation of the approach. ------------------------------------------------------------------------ Mon, 27 Jun 2005 06:43:22 +0000 : deekayen Disclaimer: I offer no code for this, so this is just a bunch of idealism I can't back up. djnz's comment makes sense if you want quick and dirty, but it seems to me the correct way to do things would be in terms of relatives. I would think doing it right the first time would be easier than redoing block location code twice. For example set a standard starting location; perhaps the start is 100% height/width conceptually. If you want to put something on the right, it would be the first block on the right of the starting block - let the theme manage widths. Then if you want another block on the right, or 10, just keep adding them relative to the others kind of like the current ordering of book pages or like adding more TD cells in a HTML table. Using this example under the current standard layout, the main block could be in the middle with with relative blocks on the left and right. ------------------------------------------------------------------------ Tue, 28 Jun 2005 10:26:44 +0000 : arnabdotorg It would be totally awesome to see multiple regions in Drupal 5, if not 4.7. This topic has been discussed several times before, noting them down for reference: http://drupal.org/node/2790 /[September 9th 2003]/ http://drupal.org/node/10653 http://drupal.org/node/13008 I also think it would be nice to have people implement multi-region themes; see what problems we encounter, and learn from it. ------------------------------------------------------------------------ Tue, 28 Jun 2005 12:28:24 +0000 : arnabdotorg Forgot to add, I've patched nedjo's final patch [12] to Drupal HEAD, it's up at http://arnab.drupaldevs.org/ [13]. [12] http://drupal.org/files/issues/regioning.patch [13] http://drupal.org/files/issues/regioning.patch ------------------------------------------------------------------------ Tue, 28 Jun 2005 16:57:02 +0000 : nedjo Attachment: http://drupal.org/files/issues/regioning2.patch (25.03 KB) Here's an improved version of the patch--several bug fixes, no new functionality. There are still a couple of loose ends (e.g., implementing the option of particular blocks not to be themed), and I haven't fully tested it. Further to my previous explanation, here is a summary of what the patch does. I'll mark as "new" the bits added in this week's iteration. Problem addressed: Currently, Drupal has two hard-coded regions into which block content is rendered: left and right. This situation severely limits the flexibility of content presentation. Aim: Enable multiple and extensible regions for blocks and other content. Approach: 1. Hard coded regions are removed from block.module. Instead, available regions are loaded dynamically. 2. Available regions are defined in themes (and, optionally, in modules). A theme or a theme engine defines its available regions through a themename_regions() function in themename.theme file or a enginename_regions() function in an enginename.engine file. New: engine-based themes can define their own regions in a .theme file. They will have all the engine's regions plus any they define. New: modules can define their own regions through a hook_regions() call. This should allow modules to define and use "inline" regions. For example, a module could define a region, then use a nodeapi() call to load content for that block and then insert it into a formatted box in $node->body. 3. New: the regions associated with a theme are loaded as part of the system_theme_data() call, and available regions are loaded through a system_region_list() function. 4. Previously stored as an integer, blocks' regions are changed to varchar, to enable storing of strings (e.g., 'left'). 5. A "default" region is defined (as a core setting), into which content will be rendered in the case that it's assigned to a region that's not available in the current theme. The options available for the default region are "core" regions, defined as all those available in all available themes. In the main block admin page, all regions not available in the current default theme are marked with an asterix, with an explanatory note. ------------------------------------------------------------------------ Tue, 28 Jun 2005 17:04:54 +0000 : nedjo Attachment: http://drupal.org/files/issues/showregions.module.txt (1.13 KB) Here's a sample module using the patch's regioning. When installed, it visually marks all available regions when you visit the page ?q=showregions. This is implemented using the proposed system_region_list() and drupal_set_content() functions. (I've attached a .txt extension to the module file since otherwise module files seem to get rewritten when uploaded.) ------------------------------------------------------------------------ Sat, 02 Jul 2005 21:15:54 +0000 : nedjo Attachment: http://drupal.org/files/issues/regioning3.patch (28.83 KB) Okay, this is now ready for review. To install after applying the patch, run update.php, since some database fields need to be created and updated (see function update_141() in the patched update.inc). In this final version, I've: * simplified the handling of content assigned to regions not available in the current theme, by loading such content directly in theme_blocks(), so that no custom handling is required in themes. * finished the coding for designating particular blocks (including custom ones) as not themed, so that it's possible simpy to inject content. This introduces a new 'themed' parameter of blocks. * made several variables configurable in the declaration of blocks by modules. As well as $block['content'] and $block['title'], you can now set $block['status'], $block['weight'], $block['region'], $block['themed'], $block['pages'], and $block['custom']. To see the behaviour, set any phptemplate-based theme, or chameleon, as the default theme. In the blocks configuration page, configure blocks to go to display in various regions. Note that, as chameleon has only two regions (left and right), all others are written to the default region (set in the main settings page, under general settings). I believe this iteration answers all major outstanding requests for functionality. It also, I hope, leaves the way open for the sort of caching and other block system enhancements chx was working on. I've taken this patch as far as I can. I'm committed to basic fixes before or after it's applied, if such are needed. But if what's wanted is another major rewrite, we'll need someone different to take it on. Reviews and comments, please! ------------------------------------------------------------------------ Sun, 03 Jul 2005 07:43:44 +0000 : Bèr Kessels Nice approach! One thin i dislik though (read this as: I like the rest) is the configuration for a default region. 1) it adds clutter. 2) I cannot think of any theme that will not break when I statr putting lots of content other than ni the place the theme wants it to be. 3) This should really be up to the themer. A theme should provide the default region, not the administrator. ------------------------------------------------------------------------ Sun, 03 Jul 2005 15:40:58 +0000 : Dries The patch no longer applies ... Looking at the code, I wonder whether the 'themed' stuff makes sense. A theme might want to theme different blocks differently based on their ID. Not theming a block is a special case of this and is already possible. Allowing the designer to set IDs that he or she can intercept, makes more sense to me. The themed-field gets a -1 from me, but I might reconsider after having tested the patch. Looking at the code, I wonder what happens when one theme calls the sidebar "left sidebar" and another theme calls it "sidebar left" (words in different order)? Is there any limitations to the current approach? ------------------------------------------------------------------------ Mon, 04 Jul 2005 03:38:38 +0000 : nedjo Attachment: http://drupal.org/files/issues/regioning4.patch (25.73 KB) Here's an updated patch. I've removed the "themed" functionality (which gave the option, mostly useful for admin-defined blocks, of inserting content directly without it being themed). It wasn't necessary to the patch. I might consider submitting it as a separate patch, but in fact I think the main issue it addressed - that content often looked bad when inserted into areas like the 'content' region, and would be better without the theming - will be addressed as themes designate appropriate styling for these block regions. I've also implemented Ber's suggested solution to the question of how to designate a default region for content assigned to regions not available in the current theme. Yes, it's better to leave this to the theme author--and since this avoids needing to create a new setting, it's a Good Thing. ------------------------------------------------------------------------ Tue, 05 Jul 2005 08:03:16 +0000 : Kobus Inline blocks could perhaps also be used instead of absolute regioning. When patching the block admin page similar to uploads thread's screenshot (as shown here: http://drupal.org/node/26288) could improve blocks quite a lot. If you look at the first screenshot, it shows a checkbox "inline" for each uploaded file. If this can be used in conjunction with [inline:xx] tags to have precise placement of the images as they state here, the same can be done for blocks, by means of a tag [block:xx] or something like that. given, that if you want to use that, you would need to know HTML (and have it allowed in nodes) to achieve this precision layout of blocks inside nodes by means of tables, for example. I would really LOVE to see inline blocks together with inline images. The combination of these two elements can really provide for a total themed look instead of just blocks. I could, for example, have a node with two inline blocks, and another with no blocks and 3 images and one with one block and one image. This would break the left/right columns look completely, and, if you choose, eliminate it almost completely, as you can generate a "sticky" node at the top with the appropriate block inside it. I think that inline blocks is more important than more regions for blocks, but that might just be me :) Regards, Kobus ------------------------------------------------------------------------ Wed, 06 Jul 2005 21:11:03 +0000 : nedjo Because my patch allows modules to declare their own regions, it should be easy to implement inline regions through a module, e.g., inlineregions.module. Something like: <?php /** * Implementation of hook_nodeapi(). */ function inlineregions_nodeapi(&$node, $op, $arg = 0, $arg2 = 0) { switch ($op) { case 'view': foreach(inlineregions_regions() as $key => $value) { $node->body = str_replace ('[inline:' . $key . ']', theme('blocks', $key), $node->body); } break; } function inlineregions_regions() { return variable_get('inlineregions', array('inline1' => t('inline one'))); } function inlineregions_settings() { // Interface to allow site admins to define regions by setting variable 'inlineregions'. } ?> ------------------------------------------------------------------------ Thu, 07 Jul 2005 05:48:22 +0000 : Kobus I have no idea how to implement your code into a module as of yet, but once the new patch is approved, I will play around a bit with it :) Thanks for the hint! Kobus ------------------------------------------------------------------------ Fri, 15 Jul 2005 21:32:35 +0000 : stefan nagtegaal While I _really_ want to see such a thing hit the trunk, I'll soon review/test this patch.. ------------------------------------------------------------------------ Sat, 16 Jul 2005 06:19:44 +0000 : arnabdotorg I'd really like this to hit core too... (waits) ------------------------------------------------------------------------ Mon, 18 Jul 2005 09:32:46 +0000 : Dries I just tried this patch. First reaction: I can only guess where my blocks will show up. I can't predict the result of making a change. The UI doesn't make me feel comfortable. For this patch to succeed, we have have to limit ourselves to (i) having one theme, (ii) having a unified list of block regions or (iii) simply reworking the GUI so I have one selection menu for each of the available themes. Personally, I'm in favor of (i) but I'm sure some people are hooked up on the multi-theme thing. While this patch is very powerful, it is also very confusing to use. I'd like to commit it to core, but I believe the UI / interaction design needs more work. ------------------------------------------------------------------------ Mon, 18 Jul 2005 20:31:55 +0000 : Bèr Kessels +1 for he -only-one-theme-idea. As author and (well, no longer maintainer of) the onlye true multitheme druopal site (please get back to me if you have one too!!), I think drupal needs, above al, a one-theme-system It will simplify a ot of code, including this patch , wich I like. but, above all, i would like to see a "default" region. A place where themes AND module developers can trow their stuff when they dont know another place. It should simply replace the current MAIN area, really nothing more. ------------------------------------------------------------------------ Mon, 18 Jul 2005 23:23:34 +0000 : nedjo Attachment: http://drupal.org/files/issues/regioning5.patch (28.64 KB) Thanks for the review and comments. Please try this revised patch. It provides highlighting on the block admin page, showing the location of each of the current theme's regions. This change is one UI approach to the issue of clarity around where content will appear. I've also changed the patch to limit the available regions to those of enabled themes (previously it was all installed themes). While I get the general point, I really don't see multiple themes as much of a problem. Don't want multiple themes (and the variability that goes with that, variability that, one hopes, goes beyond just this regioning issue)? Easy--don't enable more than one. I don't see any pressing need to strip out this functionality. I've added the following text to the admin/theme help: "Note that different themes may have different regions available for rendering content like blocks. If you want consistency in what your users see, you may wish to enable only one theme. " That should cover it, shouldn't it? ------------------------------------------------------------------------ Mon, 18 Jul 2005 23:25:53 +0000 : nedjo Attachment: http://drupal.org/files/issues/regions_highlighted.png (20.75 KB) Screenshot showing the region highlighting on (portion of) block admin page, to give visual cue as to where content will go. ------------------------------------------------------------------------ Tue, 19 Jul 2005 21:12:01 +0000 : Dries I tried the latest version of this patch. The highlights are nice but it doesn't solve the fundamental problem; it is difficult (impossible) to configure blocks when multiple themes are present. It's like having a global logo-setting, rather than a per-theme logo-setting. The global logo just won't cut it in presence of multiple themes. Because of that, the UI is rather confusing and the result of making a change is rather unpredictable. Unfortunately, I don't know how to fix this, except for removing multi-theme support. Anyone else has some thoughts on this? Ber: removing multi-themes would have tremendous impact on stuff like your regions.module, or the possibility to have a separate admin-theme, not? ------------------------------------------------------------------------ Wed, 20 Jul 2005 11:02:13 +0000 : stefan nagtegaal Can't we implement the multiple regions approach in the theme itself? And let the blocks api get the selected values. (And fallback when the theme is changed to the defaults 'left' and 'right') theme_region_*() should be searched for in the template/theme by the block administration and return the values inside the dropdown/radiobuttons which are in the block admin.. I think that's more failsafe then the current choosen method. ------------------------------------------------------------------------ Thu, 21 Jul 2005 18:57:59 +0000 : nedjo I've never personally had a need for multiple themes. I view the functionality as mainly a novelty. And, it's worth remembering, it would still be possible to have multiple styles, since styles based on the same theme would have the same regions. So, e.g., an admin style would still be feasible. But maybe, rather than removing multiple theme support, we should simply change multiple themes to an admin-selectable option? (e.g.., in theme admin page, introduce "enable multiple theme support" checkbox. If checked, theme admin options are as presently, otherwise "enabled" becomes radios and "default" is eliminated). Add a message about the tradeoffs of enabling multi-theme support, so admins can make an informed choice. "Can't we implement the multiple regions approach in the theme itself? " I don't understand the suggestion. Could you explain this a little more? In the current approach, regions /are/ loaded from themes. Alternately, if you'd like to code your suggested approach and offer it for examination, please go ahead. ------------------------------------------------------------------------ Thu, 21 Jul 2005 19:57:45 +0000 : moshe weitzman Hmmm. In our current theme system, a style *is* a theme. For example, Bluemarine and Pushbutton are each themes, and each styles. Even though these 2 styles are likely to have the same regions, what Dries is proposing here would make it impossible to use both on the same page (without hacking something). I like Nedjo's idea to hide the complex UI behind a checkbox, but still support multiple themes. Multiple themes can be very useful on occasion. I would hate to lose that. -moshe ------------------------------------------------------------------------ Thu, 21 Jul 2005 20:29:51 +0000 : Eric Scouten I'm fine with the idea of dropping multiple theme support. The only time I change themes on a site is when learning about the themes as a site developer. I never allow end users to change themes. The closest I ever get is changing color or lead-in picture for various sections of the site. ------------------------------------------------------------------------ Thu, 21 Jul 2005 20:52:57 +0000 : jvandyk So, this would render the taxonomy_theme [14] module obsolete? -1 for losing multiple theme support. Multiple themes are very handy, and one of Drupal's strong points. [14] http://drupal.org/project/taxonomy_theme ------------------------------------------------------------------------ Thu, 21 Jul 2005 21:13:31 +0000 : Eric Scouten I'm fine with the idea of dropping multiple theme support. The only time I change themes on a site is when learning about the themes as a site developer. I never allow end users to change themes. The closest I ever get is changing color or lead-in picture for various sections of the site. ------------------------------------------------------------------------ Thu, 21 Jul 2005 21:29:26 +0000 : Dries Note that there is no win-win situation here. As I see it, there are two options: 1. We keep multi-theme support and add multi-block regions. The drawback is that block configuration becomes confusing. This will affect 100% of the users. Note that I think it becomes confusing, you might think otherwise. Apply the patch, test it, and report back. Also note that in the long, I hope Drupal will be able to do more complex page layouts (page specific layouts). This might also be more complex in presence of multiple themes. Hard to tell up front. 2. We drop multi-theme support, add multi-block regions and simplify parts of Drupal. For 95% of the users this will be an improvement; most people only use one theme and for these people theme configuration will become simpler. Plus, they get multiple block regions. Unfortunately, for the 5% that uses multiple themes, this is a regression. (Note that we can still do CSS-tricks. How about an admin-theme? Can we do that with just CSS?) (3. Ask some UI people to review the GUI. Maybe they can figure out a better way to approach this.) Do we value (1) ease of use and simplicity or (2) complexity and flexibility? ------------------------------------------------------------------------ Thu, 21 Jul 2005 21:39:29 +0000 : Goba Dries, from where does that 5% come from? I am not sure that number is so low, although I cannot give a better estimation myself. The problem with judging this by ourselves is that we as developers mostly run more professional Drupal sites, requireing a distinct look, while quite a few (I don't know whether it is 1% or 16%) run with multiple themes to choose from, so that their site users are pleased. Problem is we have no data about the amount. ------------------------------------------------------------------------ Thu, 21 Jul 2005 22:11:25 +0000 : adrian -1 for losing multiple theme support, at least on the back end. Multi-theme support was one of the primary reasons I tackled the template system, and as such .. I am against it being removed. Why don't we make sure that each of these block/setting pages can be instanced, per theme, and then provide a new contrib 'multi-theme' module, that adds the extra menu entries and allows you to configure each of the themes seperately, including when the themes show. This would mean you have your theme select, and your theme settings and your block region settings by default. And if you have the module enabled, there's an 'additional' local task under admin/themes, which allows you access to the extra configuration pages. ------------------------------------------------------------------------ Thu, 21 Jul 2005 22:27:12 +0000 : adrian (crazy idea) perhaps we can use breaking out multi-theme support as a mechanism to provide specific named 'sections'. So a 'section' == theme selection + theme settings + block configuration. And we allow the developer to switch section based on rules. ie: taxonomy, node type, path or custom (php block). And each of these sections have a weight, as to which takes preference. That might be more useful than how we have it now (ie: settings, overridden by settings per theme + seperate block configuration) This would mean that the normal configuration only sets up the default 'section'. (/crazy idea) ------------------------------------------------------------------------ Thu, 21 Jul 2005 22:44:17 +0000 : eafarris My users like being able to choose their own theme, so, -1 on removing multi-theme capability, though they could probably be satisfied with a few style.css variants. ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:29:40 +0000 : Nathan_ I use multiple themes, mainly for the seperation of admin pages and the general user pages. I also use it in conjuncion with a veriation on the sections module, to display slightly different themes, based on the users location on the site. This COULD be replacd with logic in the theme itself, so it knows where it is/ what page it is on. Not the best solution, but a solution. I would miss it, but I see more value in having the multiple block regions. This has the potential to solve some of th eproblems I was using mutilple theme support for. Instead of calling a new theme to print a NEW region at the bottom of the page (these pages all share the same style sheet btw), I could assign a block to that region and have it turn on on the pages I want. I have yet to test this patch. I will do that shortly and report any suggestions regarding the UI. To clarfiy, drop multiple theme support and bring in the multiple block regions. ------------------------------------------------------------------------ Fri, 22 Jul 2005 01:37:12 +0000 : moshe weitzman Dries makes a pretty compelling argument for one active theme at a time. Furthermore, it occurs to me that the same tricks we do today with $custom_theme will work in the future. In other words, we can still change the active theme on a page by page basis. Thats probably what Nedjo meant by retaining use of multiple styles even in a single theme system. single theme is ok with me. ------------------------------------------------------------------------ Fri, 22 Jul 2005 01:37:14 +0000 : moshe weitzman Dries makes a pretty compelling argument for one active theme at a time. Furthermore, it occurs to me that the same tricks we do today with $custom_theme will work in the future. In other words, we can still change the active theme on a page by page basis. Thats probably what Nedjo meant by retaining use of multiple styles even in a single theme system. single theme is ok with me. ------------------------------------------------------------------------ Fri, 22 Jul 2005 02:47:50 +0000 : clydefrog User-selectable themes are useful for theme developers to use their new theme and make sure it works well before making it the site default. Programmatically selectable themes (in hook_init()) are also very useful. I use it to send out the page in bluemarine if the browser is IE5 and our regular theme (modified friendselectric) otherwsie. Losing this functionality is a Bad Thing (TM). ------------------------------------------------------------------------ Fri, 22 Jul 2005 07:23:40 +0000 : Kobus I personally have only the need for one theme, but multiple style sheets. I am happy with the single-theme approach. Regards, ------------------------------------------------------------------------ Fri, 22 Jul 2005 09:24:12 +0000 : stefan nagtegaal Like Moshe, there are plenty of other manners how you could have multiple themes in drupal. I'am completely confident with a single theme system... So, +1 for removing it.. ------------------------------------------------------------------------ Fri, 22 Jul 2005 12:56:41 +0000 : Goba Stefan, why push the theme system under another layer, if we can have one layer built on top of it instead. Problem is that limiting the system to one theme, we add another layer of complexity for those, who would like to have multiple themes, while with the current system plus another block arranging layer we can preserve what is already there from the programmer and from the user point of view too. I imagine something where I can categorize blocks (add terms to them :) and then decide per theme, what term goes to what region. No, I am not about to be able to contribute code at this time, so if noone else picks up the idea, then please discard.

1 0

[drupal-devel] [feature] i18n - Move drupal_goto to bootstrap.inc and some related features
by Jose A Reyero 22 Jul '05

22 Jul '05

Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Jose A Reyero Reported by: Jose A Reyero Updated by: Jose A Reyero Status: patch Attachment: http://drupal.org/files/issues/i18n_drupal_goto_01.patch (8.41 KB) This is firs of a serie of patches adding support for some i18n related features. This patch: - moves drupal_goto to bootstrap.inc, making it possible to use it from the module_init, even for cached pages - moves url() to bootstrap.inc, as it is needed by drupal_goto, and includes a check for not to resolve path aliases when called from bootstrap (it is not needed and would require including lot more stuff from common.inc) - adds a simple hook to call 'i18n_url_rewrite' from the function 'url()' , which allows outgoing urls to be rewrited, so some additional info can be placed in the path. Jose A Reyero -- View: http://drupal.org/node/16069 Edit: http://drupal.org/project/comments/add/16069

3 7