- Development - lists.drupal.org

[drupal-devel] [feature] Allow annoymous users to log in on access denied
by jjeff 19 Jul '05

19 Jul '05

Issue status update for http://drupal.org/node/24050 Post a follow up: http://drupal.org/project/comments/add/24050 Project: Drupal Version: cvs Component: user system Category: feature requests Priority: normal Assigned to: gordon Reported by: gordon Updated by: jjeff Status: patch Before I saw this thread, I posted another take on this bug at http://drupal.org/node/26659. It explains the problem a little more in-depth. Here's the thing: What makes Drupal sites look like Drupal sites is that they've got a login/password box on every page until the user is logged in. For Drupal to become a mature platform, it's going to need to move away from dependence on this crutch. Drupal should provide the infrastructure to allow the option of a simple "Login/Register" link. However, if a user gets an access denied message, they should be prompted to log in. As it is, the best that you can do after login is direct them back to the node that defines the "Access Denied" message. This is more than just confusing for the user. It's downright wrong! Dries, please reconsider this patch and/or some variation that solves this problem. It is essential for all current versions of Drupal. Thanks, Jeff jjeff Previous comments: ------------------------------------------------------------------------ Wed, 01 Jun 2005 05:51:25 +0000 : gordon Attachment: http://drupal.org/files/issues/denied_login.diff (1.41 KB) If the user is anonymous, then the user will be presented with the login page 'user/login' instead of a the 403 default page. If the user then logins in and has access to the page they will then get redirected to the page they were trying to access. If the user is already logged in then they will get the defined 403 page. With the standard system you cannot just set user/login as the 403 page as you will not be redirected to the page that you were originally requesting, but instead to the user page. ------------------------------------------------------------------------ Sun, 05 Jun 2005 00:22:06 +0000 : gordon Attachment: http://drupal.org/files/issues/denied_login2.patch (3.43 KB) here is a newer version of the patch which adds an option to admin/settings page so this functionality can be turned off and on. ------------------------------------------------------------------------ Sun, 05 Jun 2005 01:38:39 +0000 : moshe weitzman I have been wanting this since i first saw drupal (i.e. a long time). +1 ------------------------------------------------------------------------ Sun, 05 Jun 2005 10:29:05 +0000 : Dries Because the 403 page is configurable, this is already possible. This patch only makes it more convenient. I tempted to say: "Won't commit, but let's extend the form description a bit so it is clear this is possible.". That or we add a link to the login page (without the extra setting), cfr. to what the comment module does. ------------------------------------------------------------------------ Sun, 05 Jun 2005 12:06:40 +0000 : moshe weitzman dries - upon executing the 403 handler, the original $_GET['q'] is lost. That means that we cannot redirect to the destination page after login and thats one of the main benefits of this patch. ------------------------------------------------------------------------ Sun, 05 Jun 2005 12:40:57 +0000 : gordon Yes you can use the user/login link, but once you login you get the user page and not the page you were triing to get to. Also if you are logged in you will still get the user/login page when really you should get the custom access denied page. ------------------------------------------------------------------------ Sun, 05 Jun 2005 20:57:20 +0000 : slower What version of Drupal is this for? I'm using 4.5. ------------------------------------------------------------------------ Sun, 05 Jun 2005 23:47:19 +0000 : gordon It is for cvs (4.7) I would have to rewrite it if I was to port it back to 4.5 ------------------------------------------------------------------------ Mon, 13 Jun 2005 23:49:02 +0000 : gordon Dries, What is the verdict on this patch. I have found no way of prompting anonymous users to login and continue seemlessly without this patch. Please correct me if I am wrong, as this is some functionality that I require. ------------------------------------------------------------------------ Tue, 14 Jun 2005 01:00:12 +0000 : neofactor Glad to see it... I had always just added the following custom pages: http://neofactor.com/error403 (with a login link) http://neofactor.com/error404 (Adding the auto search) My 403's are only for non-members and all members have the same access. I use PHP to control groups differently for lots of different clients, so this works out well form me. The auto redirect function is nice.... keeping the user's initial request in place. hey.... When is Drupal going to add images to pages at core? Visual appeal.... It would be great if menu items and other areas started to do this... then people could just swap them out. Just a wish list. ;) ------------------------------------------------------------------------ Tue, 14 Jun 2005 03:02:01 +0000 : gordon Just adding the pages does work, but does not give the effect that I need. You can always use the login box on the sidebar, which will do the same thing. You said that the 403's aren't used to logged in users as they have the same privledge, But not everyone has the same privledge on your site (unless everyone has the same rights as user 1 ;-)) So what if a user who is already logged in goes to /admin you do not want to tell them that they need to login to get to the admin page, you want to send them to a big go away page.

1 0

[drupal-devel] Image extension - Images made easy
by Jose A. Reyero 19 Jul '05

19 Jul '05

Hi, I like the existing image modules: image, img_assist, image_filter, but usually I just need a *simple* way to add images to stories or blogs, and this modules, while powerful, are not that easy for new users. This is a very small and simple module that extends image.module to allow images for any node type -similar to the old image_attach. It uses the excellent api provided by the image.module, thus it only needs a few lines of code. I was planning to build on it providing some additional formatting options, but maybe all this would be more interesting as a patch to the existing image module than as a new module. For the moment, it's only in my sandbox -For 4.6.2 What do you think?. - Walkah? http://cvs.drupal.org/viewcvs/drupal/contributions/sandbox/jareyero/modules… Regards, Jose A. Reyero

2 2

[drupal-devel] node_list() change, list of affected modules
by Dries Buytaert 19 Jul '05

19 Jul '05

The node_list() function changed in HEAD. It now returns an associative array. The following files are affected: akvaforum/akvaforum.module attached_node/attached_node.module clipper/clipper.module commentcloser/comment_closer.module copyright/copyright.module directory/directory.module editasnew/editasnew.module eventfinder/eventfinder.module freelinking/freelinking.module groups/groups.module i18n/i18n.module menu_otf/menu_otf.module mime_registry/mime_registry.module nmoderation/nmoderation.module node_image/node_image.module nodelist/nodelist.module nodeperm_role/nodeperm_role.module nodevote/nodevote.module og/og.module pathauto/pathauto_node.inc periodical/periodical.module publish/publish.module quickpost/quickpost.module relatedlinks/relatedlinks.module relativity/relativity.module spam/spam.module static/static.module subscribe/subscribe.module summary/summary.module taxonomy_browser/taxonomy_browser.module taxonomy_context/taxonomy_context.module taxonomy_defaults/taxonomy_defaults.module trip_search/trip_search.module typecat/typecat.module userpoints/userpoints.module userposts/userposts.module workflow/workflow.module workspace/workspace.module Typically, you have to change: foreach (node_list() as $type) { into: foreach (node_list() as $type => $module) { -- Dries Buytaert :: http://www.buytaert.net/

1 0

[drupal-devel] [feature] Patch to add the guid tag to the rss feed
by frjo 19 Jul '05

19 Jul '05

Issue status update for http://drupal.org/node/26223 Post a follow up: http://drupal.org/project/comments/add/26223 Project: Drupal -Version: 4.6.2 +Version: cvs Component: node system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: frjo Updated by: frjo -Status: active +Status: patch Attachment: http://drupal.org/files/issues/common_rss_guid_02.patch (524 bytes) I made a patch for the cvs version of Drupal also. I believe this is a smal but very nice improvement of Drupals RSS support. frjo Previous comments: ------------------------------------------------------------------------ Sat, 02 Jul 2005 07:29:30 +0000 : frjo Attachment: http://drupal.org/files/issues/common_rss_guid.patch (537 bytes) This patch add the guid (globally unique identifier) tag to the rss feed. This is in line with the RSS 2.0 Specification, se below. It's a very simpel, one line patch, to the format_rss_item function in common.inc. I want this personally so my news reader (NetNewsWire) can distinguish between new and updates posts. >From http://blogs.law.harvard.edu/tech/rss "A frequently asked question about s is how do they compare to s. Aren't they the same thing? Yes, in some content systems, and no in others. In some systems, is a permalink to a weblog item. However, in other systems, each is a synopsis of a longer article, points to the article, and is the permalink to the weblog entry. In all cases, it's recommended that you provide the guid, and if possible make it a permalink. This enables aggregators to not repeat items, even if there have been editing changes. "

1 0

[drupal-devel] [feature] Easily persist destinations
by mathias 19 Jul '05

19 Jul '05

Issue status update for http://drupal.org/node/26467 Post a follow up: http://drupal.org/project/comments/add/26467 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: mathias Status: patch I tested this patch and it works as expected. By tacking on a destination parameter to the URI I was able to control for example, where the login form takes a user after successful authentication. This is especially helpful for the ecommerce package to redirect users back to the checkout process after logon. I did some basic security checks to make sure a user couldn't redirect to an absolute URL or traverse web directories, but I still ponder the implications are of allowing anyone to control the destination after a form submit on my site. That could just be the control freak in me coming out in full swing. mathias Previous comments: ------------------------------------------------------------------------ Wed, 06 Jul 2005 18:01:07 +0000 : drumm Attachment: http://drupal.org/files/issues/common.inc_4.diff (1.44 KB) I think drupal_get_destination() should keep track of the origionally set destination. With this patch drupal_get_destination() will return the current destination instead of the current page if it exists. ------------------------------------------------------------------------ Wed, 06 Jul 2005 18:10:04 +0000 : drumm setting status to patch ------------------------------------------------------------------------ Wed, 06 Jul 2005 19:14:20 +0000 : drumm Attachment: http://drupal.org/files/issues/common.inc_5.diff (1.47 KB) More clear help text. Hopefully the patch is more self-explanatory now. ------------------------------------------------------------------------ Thu, 07 Jul 2005 05:41:57 +0000 : Kobus Not sure if I understand this correctly, but from my scan of the code it seems like it. If I do understand correctly: 1. User clicks on an e-mail or web link to an article on a page. 2. Authentication is required. 3. User gets redirected to log in. 4. User logs in. 5. User gets redirected to the original article they requested. If that is what this patch enables me to do, I am +20 for it :) Regards, Kobus ------------------------------------------------------------------------ Mon, 18 Jul 2005 19:22:05 +0000 : drumm I am updating this patch so that this API feature is used by the node module. ------------------------------------------------------------------------ Mon, 18 Jul 2005 22:08:54 +0000 : drumm Attachment: http://drupal.org/files/issues/destination.patch (3.6 KB) This patch includes going back to the right place when deleting nodes. ------------------------------------------------------------------------ Mon, 18 Jul 2005 22:14:55 +0000 : drumm Wrong status. ------------------------------------------------------------------------ Mon, 18 Jul 2005 22:22:55 +0000 : chx very nice idea. ------------------------------------------------------------------------ Tue, 19 Jul 2005 00:51:40 +0000 : jjeff I've been using a hack to get this functionality on my current site. It should DEFINITELY be part of the core. If anyone wants to build a theme that doesn't have a login box on every page, this is absolutely necessary. ++1 ------------------------------------------------------------------------ Tue, 19 Jul 2005 01:03:41 +0000 : drumm Just to be clear, this does not affect the login process. ------------------------------------------------------------------------ Tue, 19 Jul 2005 03:30:35 +0000 : jjeff Well it does not affect the default Drupal login process, but if a theme wants to put a login *link* on its pages rather than the Drupal-esque login form-on-every-page, then the appropriate way would be to use: <?php print l(t('Login/Register'), 'user/login', array(), drupal_get_destination()); ?> The idea being that users would get sent to http://www.example.com/user/login?destination=the_node_they_came_from However, because the destination does not persist, they don't get sent back to the node they came from. Instead they get sent to their user page. Unless I'm reading it wrong, this patch fixes drupal_get_destination() so that everything works as it should and the user ends up logged in and back at the original node. -Jeff ------------------------------------------------------------------------ Tue, 19 Jul 2005 03:59:17 +0000 : gordon Not to blow my own trumpet... well actually I am. Kobus: The patch that you are looking for the one that I did a month or so ago. Basically if you get a 403 and you are not logged in you will get a login page and then once you have loged it will redirect you back to the page that you we denied access to. This patch is more of an API level change where you are going to need to do some coding before you can make use of it. I have not yet been able to convince Dries that you cannot do this in Drupal. He has been a little busy laterly so I have not bugged him. As for this patch. +1 I like it. The idea of not having a login page on a theme, but still come back to the current page is great. ------------------------------------------------------------------------ Tue, 19 Jul 2005 04:12:51 +0000 : gordon opps forgot the url. http://drupal.org/node/24050 [1] [1] http://drupal.org/node/24050

1 0

[drupal-devel] [feature] Easily persist destinations
by gordon 19 Jul '05

19 Jul '05

Issue status update for http://drupal.org/node/26467 Post a follow up: http://drupal.org/project/comments/add/26467 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: gordon Status: patch opps forgot the url. http://drupal.org/node/24050 [1] [1] http://drupal.org/node/24050 gordon Previous comments: ------------------------------------------------------------------------ Wed, 06 Jul 2005 18:01:07 +0000 : drumm Attachment: http://drupal.org/files/issues/common.inc_4.diff (1.44 KB) I think drupal_get_destination() should keep track of the origionally set destination. With this patch drupal_get_destination() will return the current destination instead of the current page if it exists. ------------------------------------------------------------------------ Wed, 06 Jul 2005 18:10:04 +0000 : drumm setting status to patch ------------------------------------------------------------------------ Wed, 06 Jul 2005 19:14:20 +0000 : drumm Attachment: http://drupal.org/files/issues/common.inc_5.diff (1.47 KB) More clear help text. Hopefully the patch is more self-explanatory now. ------------------------------------------------------------------------ Thu, 07 Jul 2005 05:41:57 +0000 : Kobus Not sure if I understand this correctly, but from my scan of the code it seems like it. If I do understand correctly: 1. User clicks on an e-mail or web link to an article on a page. 2. Authentication is required. 3. User gets redirected to log in. 4. User logs in. 5. User gets redirected to the original article they requested. If that is what this patch enables me to do, I am +20 for it :) Regards, Kobus ------------------------------------------------------------------------ Mon, 18 Jul 2005 19:22:05 +0000 : drumm I am updating this patch so that this API feature is used by the node module. ------------------------------------------------------------------------ Mon, 18 Jul 2005 22:08:54 +0000 : drumm Attachment: http://drupal.org/files/issues/destination.patch (3.6 KB) This patch includes going back to the right place when deleting nodes. ------------------------------------------------------------------------ Mon, 18 Jul 2005 22:14:55 +0000 : drumm Wrong status. ------------------------------------------------------------------------ Mon, 18 Jul 2005 22:22:55 +0000 : chx very nice idea. ------------------------------------------------------------------------ Tue, 19 Jul 2005 00:51:40 +0000 : jjeff I've been using a hack to get this functionality on my current site. It should DEFINITELY be part of the core. If anyone wants to build a theme that doesn't have a login box on every page, this is absolutely necessary. ++1 ------------------------------------------------------------------------ Tue, 19 Jul 2005 01:03:41 +0000 : drumm Just to be clear, this does not affect the login process. ------------------------------------------------------------------------ Tue, 19 Jul 2005 03:30:35 +0000 : jjeff Well it does not affect the default Drupal login process, but if a theme wants to put a login *link* on its pages rather than the Drupal-esque login form-on-every-page, then the appropriate way would be to use: <?php print l(t('Login/Register'), 'user/login', array(), drupal_get_destination()); ?> The idea being that users would get sent to http://www.example.com/user/login?destination=the_node_they_came_from However, because the destination does not persist, they don't get sent back to the node they came from. Instead they get sent to their user page. Unless I'm reading it wrong, this patch fixes drupal_get_destination() so that everything works as it should and the user ends up logged in and back at the original node. -Jeff ------------------------------------------------------------------------ Tue, 19 Jul 2005 03:59:17 +0000 : gordon Not to blow my own trumpet... well actually I am. Kobus: The patch that you are looking for the one that I did a month or so ago. Basically if you get a 403 and you are not logged in you will get a login page and then once you have loged it will redirect you back to the page that you we denied access to. This patch is more of an API level change where you are going to need to do some coding before you can make use of it. I have not yet been able to convince Dries that you cannot do this in Drupal. He has been a little busy laterly so I have not bugged him. As for this patch. +1 I like it. The idea of not having a login page on a theme, but still come back to the current page is great.

1 0

[drupal-devel] [feature] Easily persist destinations
by gordon 19 Jul '05

19 Jul '05

Issue status update for http://drupal.org/node/26467 Post a follow up: http://drupal.org/project/comments/add/26467 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: gordon Status: patch Not to blow my own trumpet... well actually I am. Kobus: The patch that you are looking for the one that I did a month or so ago. Basically if you get a 403 and you are not logged in you will get a login page and then once you have loged it will redirect you back to the page that you we denied access to. This patch is more of an API level change where you are going to need to do some coding before you can make use of it. I have not yet been able to convince Dries that you cannot do this in Drupal. He has been a little busy laterly so I have not bugged him. As for this patch. +1 I like it. The idea of not having a login page on a theme, but still come back to the current page is great. gordon Previous comments: ------------------------------------------------------------------------ Wed, 06 Jul 2005 18:01:07 +0000 : drumm Attachment: http://drupal.org/files/issues/common.inc_4.diff (1.44 KB) I think drupal_get_destination() should keep track of the origionally set destination. With this patch drupal_get_destination() will return the current destination instead of the current page if it exists. ------------------------------------------------------------------------ Wed, 06 Jul 2005 18:10:04 +0000 : drumm setting status to patch ------------------------------------------------------------------------ Wed, 06 Jul 2005 19:14:20 +0000 : drumm Attachment: http://drupal.org/files/issues/common.inc_5.diff (1.47 KB) More clear help text. Hopefully the patch is more self-explanatory now. ------------------------------------------------------------------------ Thu, 07 Jul 2005 05:41:57 +0000 : Kobus Not sure if I understand this correctly, but from my scan of the code it seems like it. If I do understand correctly: 1. User clicks on an e-mail or web link to an article on a page. 2. Authentication is required. 3. User gets redirected to log in. 4. User logs in. 5. User gets redirected to the original article they requested. If that is what this patch enables me to do, I am +20 for it :) Regards, Kobus ------------------------------------------------------------------------ Mon, 18 Jul 2005 19:22:05 +0000 : drumm I am updating this patch so that this API feature is used by the node module. ------------------------------------------------------------------------ Mon, 18 Jul 2005 22:08:54 +0000 : drumm Attachment: http://drupal.org/files/issues/destination.patch (3.6 KB) This patch includes going back to the right place when deleting nodes. ------------------------------------------------------------------------ Mon, 18 Jul 2005 22:14:55 +0000 : drumm Wrong status. ------------------------------------------------------------------------ Mon, 18 Jul 2005 22:22:55 +0000 : chx very nice idea. ------------------------------------------------------------------------ Tue, 19 Jul 2005 00:51:40 +0000 : jjeff I've been using a hack to get this functionality on my current site. It should DEFINITELY be part of the core. If anyone wants to build a theme that doesn't have a login box on every page, this is absolutely necessary. ++1 ------------------------------------------------------------------------ Tue, 19 Jul 2005 01:03:41 +0000 : drumm Just to be clear, this does not affect the login process. ------------------------------------------------------------------------ Tue, 19 Jul 2005 03:30:35 +0000 : jjeff Well it does not affect the default Drupal login process, but if a theme wants to put a login *link* on its pages rather than the Drupal-esque login form-on-every-page, then the appropriate way would be to use: <?php print l(t('Login/Register'), 'user/login', array(), drupal_get_destination()); ?> The idea being that users would get sent to http://www.example.com/user/login?destination=the_node_they_came_from However, because the destination does not persist, they don't get sent back to the node they came from. Instead they get sent to their user page. Unless I'm reading it wrong, this patch fixes drupal_get_destination() so that everything works as it should and the user ends up logged in and back at the original node. -Jeff

1 0

[drupal-devel] [feature] Easily persist destinations
by jjeff 19 Jul '05

19 Jul '05

Issue status update for http://drupal.org/node/26467 Post a follow up: http://drupal.org/project/comments/add/26467 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: jjeff Status: patch Well it does not affect the default Drupal login process, but if a theme wants to put a login *link* on its pages rather than the Drupal-esque login form-on-every-page, then the appropriate way would be to use: <?php print l(t('Login/Register'), 'user/login', array(), drupal_get_destination()); ?> The idea being that users would get sent to http://www.example.com/user/login?destination=the_node_they_came_from However, because the destination does not persist, they don't get sent back to the node they came from. Instead they get sent to their user page. Unless I'm reading it wrong, this patch fixes drupal_get_destination() so that everything works as it should and the user ends up logged in and back at the original node. -Jeff jjeff Previous comments: ------------------------------------------------------------------------ Wed, 06 Jul 2005 18:01:07 +0000 : drumm Attachment: http://drupal.org/files/issues/common.inc_4.diff (1.44 KB) I think drupal_get_destination() should keep track of the origionally set destination. With this patch drupal_get_destination() will return the current destination instead of the current page if it exists. ------------------------------------------------------------------------ Wed, 06 Jul 2005 18:10:04 +0000 : drumm setting status to patch ------------------------------------------------------------------------ Wed, 06 Jul 2005 19:14:20 +0000 : drumm Attachment: http://drupal.org/files/issues/common.inc_5.diff (1.47 KB) More clear help text. Hopefully the patch is more self-explanatory now. ------------------------------------------------------------------------ Thu, 07 Jul 2005 05:41:57 +0000 : Kobus Not sure if I understand this correctly, but from my scan of the code it seems like it. If I do understand correctly: 1. User clicks on an e-mail or web link to an article on a page. 2. Authentication is required. 3. User gets redirected to log in. 4. User logs in. 5. User gets redirected to the original article they requested. If that is what this patch enables me to do, I am +20 for it :) Regards, Kobus ------------------------------------------------------------------------ Mon, 18 Jul 2005 19:22:05 +0000 : drumm I am updating this patch so that this API feature is used by the node module. ------------------------------------------------------------------------ Mon, 18 Jul 2005 22:08:54 +0000 : drumm Attachment: http://drupal.org/files/issues/destination.patch (3.6 KB) This patch includes going back to the right place when deleting nodes. ------------------------------------------------------------------------ Mon, 18 Jul 2005 22:14:55 +0000 : drumm Wrong status. ------------------------------------------------------------------------ Mon, 18 Jul 2005 22:22:55 +0000 : chx very nice idea. ------------------------------------------------------------------------ Tue, 19 Jul 2005 00:51:40 +0000 : jjeff I've been using a hack to get this functionality on my current site. It should DEFINITELY be part of the core. If anyone wants to build a theme that doesn't have a login box on every page, this is absolutely necessary. ++1 ------------------------------------------------------------------------ Tue, 19 Jul 2005 01:03:41 +0000 : drumm Just to be clear, this does not affect the login process.

1 0

[drupal-devel] [feature] Easily persist destinations
by drumm 19 Jul '05

19 Jul '05

Issue status update for http://drupal.org/node/26467 Post a follow up: http://drupal.org/project/comments/add/26467 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Just to be clear, this does not affect the login process. drumm Previous comments: ------------------------------------------------------------------------ Wed, 06 Jul 2005 18:01:07 +0000 : drumm Attachment: http://drupal.org/files/issues/common.inc_4.diff (1.44 KB) I think drupal_get_destination() should keep track of the origionally set destination. With this patch drupal_get_destination() will return the current destination instead of the current page if it exists. ------------------------------------------------------------------------ Wed, 06 Jul 2005 18:10:04 +0000 : drumm setting status to patch ------------------------------------------------------------------------ Wed, 06 Jul 2005 19:14:20 +0000 : drumm Attachment: http://drupal.org/files/issues/common.inc_5.diff (1.47 KB) More clear help text. Hopefully the patch is more self-explanatory now. ------------------------------------------------------------------------ Thu, 07 Jul 2005 05:41:57 +0000 : Kobus Not sure if I understand this correctly, but from my scan of the code it seems like it. If I do understand correctly: 1. User clicks on an e-mail or web link to an article on a page. 2. Authentication is required. 3. User gets redirected to log in. 4. User logs in. 5. User gets redirected to the original article they requested. If that is what this patch enables me to do, I am +20 for it :) Regards, Kobus ------------------------------------------------------------------------ Mon, 18 Jul 2005 19:22:05 +0000 : drumm I am updating this patch so that this API feature is used by the node module. ------------------------------------------------------------------------ Mon, 18 Jul 2005 22:08:54 +0000 : drumm Attachment: http://drupal.org/files/issues/destination.patch (3.6 KB) This patch includes going back to the right place when deleting nodes. ------------------------------------------------------------------------ Mon, 18 Jul 2005 22:14:55 +0000 : drumm Wrong status. ------------------------------------------------------------------------ Mon, 18 Jul 2005 22:22:55 +0000 : chx very nice idea. ------------------------------------------------------------------------ Tue, 19 Jul 2005 00:51:40 +0000 : jjeff I've been using a hack to get this functionality on my current site. It should DEFINITELY be part of the core. If anyone wants to build a theme that doesn't have a login box on every page, this is absolutely necessary. ++1

1 0

[drupal-devel] [feature] Easily persist destinations
by jjeff 19 Jul '05

19 Jul '05

Issue status update for http://drupal.org/node/26467 Post a follow up: http://drupal.org/project/comments/add/26467 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: jjeff Status: patch I've been using a hack to get this functionality on my current site. It should DEFINITELY be part of the core. If anyone wants to build a theme that doesn't have a login box on every page, this is absolutely necessary. ++1 jjeff Previous comments: ------------------------------------------------------------------------ Wed, 06 Jul 2005 18:01:07 +0000 : drumm Attachment: http://drupal.org/files/issues/common.inc_4.diff (1.44 KB) I think drupal_get_destination() should keep track of the origionally set destination. With this patch drupal_get_destination() will return the current destination instead of the current page if it exists. ------------------------------------------------------------------------ Wed, 06 Jul 2005 18:10:04 +0000 : drumm setting status to patch ------------------------------------------------------------------------ Wed, 06 Jul 2005 19:14:20 +0000 : drumm Attachment: http://drupal.org/files/issues/common.inc_5.diff (1.47 KB) More clear help text. Hopefully the patch is more self-explanatory now. ------------------------------------------------------------------------ Thu, 07 Jul 2005 05:41:57 +0000 : Kobus Not sure if I understand this correctly, but from my scan of the code it seems like it. If I do understand correctly: 1. User clicks on an e-mail or web link to an article on a page. 2. Authentication is required. 3. User gets redirected to log in. 4. User logs in. 5. User gets redirected to the original article they requested. If that is what this patch enables me to do, I am +20 for it :) Regards, Kobus ------------------------------------------------------------------------ Mon, 18 Jul 2005 19:22:05 +0000 : drumm I am updating this patch so that this API feature is used by the node module. ------------------------------------------------------------------------ Mon, 18 Jul 2005 22:08:54 +0000 : drumm Attachment: http://drupal.org/files/issues/destination.patch (3.6 KB) This patch includes going back to the right place when deleting nodes. ------------------------------------------------------------------------ Mon, 18 Jul 2005 22:14:55 +0000 : drumm Wrong status. ------------------------------------------------------------------------ Mon, 18 Jul 2005 22:22:55 +0000 : chx very nice idea.

1 0