- Development - lists.drupal.org

[drupal-devel] [bug] Strange markup in book render functions
by puregin 13 Jun '05

13 Jun '05

Issue status update for http://drupal.org/node/1898 Project: Drupal Version: cvs Component: book.module Category: bug reports Priority: critical Assigned to: puregin Reported by: kika Updated by: puregin Status: patch Attachment: http://drupal.org/files/issues/xml-export-06.patch (616 bytes) I forgot to include a proper id attribute for book elements in the last patch. The attached patch corrects this, so all 'node container' elements have an id derived from the node id. Djun puregin Previous comments: ------------------------------------------------------------------------ June 9, 2003 - 15:06 : kika Snippet from book_render(): $output .= "<dt>". l($node->title, "node/view/$node->nid") ."</dt><dd>". book_body($node) ."<br /><br /></dd>"; Is using definition list here is really correct? This should be replaced with appropiate div's or even better, funnel through theme() Same goes for the function book_print(): $output .= "$node->title"; if ($node->body) { $output .= "<ul>". book_body($node) ."</ul>"; } Why wrap body inside <ul>? ------------------------------------------------------------------------ June 10, 2003 - 17:31 : al Yeah, it's all nasty. I patched this ages ago, but no one seemed interested. The patch now won't apply due to all the changes since then. I'm on this - expect a new patch to hit my sandbox shortly. ------------------------------------------------------------------------ June 10, 2003 - 23:03 : ax please remove the superfluous <ul>s and <li> [1], too. to solve the problem of invalid nested <hx> tags, maybe we should change <h$depth> to <h1 class="book-h$depth">? this way, we could use <h2> - <h6> in book pages. alternatively, we should only use <h5> and <h6> in book pages - we shouldn't have nestings deeper than 4 in printed books, then. additionally, i think it would be a good idea to add id's to all book headings so they can be jumped to via fragment identifiers (url#fragment-identifier). i often wish this would be possible when referencing the last paragraph of a long page of documentation ... these id's should be of the form <hx id="foo" name="foo"> [2], with foo probably being the node-id of the single book page. adding id's to headings would also be a good idea for headings / sections in single book nodes. for example, it would be nice if i could link to list point 10 in the drupal installation instructions [3] via something like url#10. these id's had to be added manually. the question is: how can these id's be named to be unique within a /printed/ book? probably <node_id>_<section_id> ... [1] [ [drupal-devel] Drupal handbook formatting and heading tags | http://lists.drupal.org/pipermail/drupal-devel/2003-June/025860.html ] [2] [ XHTML Spec, HTML Compatibility Guidelines, Fragment Identifiers | http://www.w3.org/TR/xhtml1/#C_8 ] [3] http://drupal.org/node/view/260 ------------------------------------------------------------------------ June 15, 2003 - 07:23 : al Fixed in latest CVS. Uses all of Ax's suggestions: - <h1 class="depthX"> - Fixed to use CSS rather than tables. - Changes link at top to standard "breadcrumb" style, rather than hierarchy in tree view. - Removes odd and superfluous <ul> tags and the like. - Makes printed docs have proper <html> and <body> wrapping, etc. ------------------------------------------------------------------------ May 5, 2005 - 00:20 : puregin I'm re-opening this, because the problem persists in CVS. 1) The current CVS version (1.288.2.4) of book module still wraps $node->body in an <ul> element in book_print_recurse(). This produces non-conformant HTML. I'm not sure why this was done in the first place - I'm guessing someone wanted to insulate from having bad markup in a book page throw off the enclosing page. Getting rid of the offending UL tags is a one-line solution, but what is the right thing to do here? I'd like to see something very structural - wrapping the /entire/ output (including the generated sectional header) of the book_print_recurse() wrapped in a <div> element. This will properly nest true structural sections, making the structure accessible to applications via DOM. It will also make it easier to use XSLT, for example, to transform into various XML based export formats, for example. Any reason not to do so? Also... when we get the 'printer-friendly' version of a page, the subtree rooted at that page is returned, and the root page is marked up with a class="book-h1". Is there any reason why we don't compute the depth of the root page, and use that to generate the "in-place" header? In other words, if a section is "book-h3" relative to the top-level book, shouldn't it be "book-h3" whenever it is viewed? In this case, we could apply the same principal to generating the <div> tags around each section. ------------------------------------------------------------------------ May 5, 2005 - 15:58 : puregin Attachment: http://drupal.org/files/issues/book_printer_friendly_div.patch (1.57 KB) I am attaching a patch which fixes improper printer-friendly output, as discussed. The patch fixes book_print and book_print_recurse() to insert a <div> start tag before emitting the header, and to close this after subsections have been recursively generated. The <div> tag has an id attribute of the form id="sect-123", where the node's nid is 123, and a class attribute of form class="sect/n/" where the depth of the section is /n/. I'm marking this issue as critical, since the present HTML output plays havoc with any attempts at sane PDF generation. I will address the issue of where printer-friendly subsections should be 'rooted' in a follow-up. Djun ------------------------------------------------------------------------ May 6, 2005 - 01:53 : Dries Let's not abbreviate 'section' to 'sect'. Also, we use '-' to separate words in CSS names. - If the section ID uses the node ID, maybe we should use 'node-' instead of 'sect-'? - If the class uses depth, maybe we should use 'depth-' instead of 'sect'? The same is true for your other patch where you suggest to use 'n'. Better to make that 'node-'. (Feel free to merge both patches.) Looks like the book.module generates a _lot_ of CSS IDs/classes. If the introduction of these new IDs/classes allows us to remove some of the existing IDs/classes, please do. ------------------------------------------------------------------------ May 6, 2005 - 21:26 : Steven Here's my idea.. why not use regular h tags for the book structure, and renumber the header tags in the content, starting one level after the current book depth? Here's a function which does this: <?php function fix_up_headers($text, $level = 1) { // Find all header tags that are used (if any) if (preg_match_all('/<h[0-9]+/i', $text, $tags) == 0) { return $text; } // Discard duplicates and sort them by number $tags = array_unique(array_map('strtolower', $tags[0])); natsort($tags); // Renumber them and replace them $i = $level; foreach ($tags as $tag) { $from[] = '@'. preg_quote($tag) .'(?![0-9])@i'; $from[] = '@'. preg_quote(str_replace('<', '</', $tag)) .'(?![0-9])@i'; $to[] = '<h'. $i; $to[] = '</h'. $i; $i++; } $text = preg_replace($from, $to, $text); // Change level 7 headers and higher to divs. return preg_replace(array('!<h([7-9]|[1-9][0-9]+)!i', '!</h([7-9]|[1-9][0-9]+)!i'), array('<div class="header-\1"', '</div'), $text); } ?> That way you can use header tags safely in the content (which is useful in the context of a single page) without messing up the book output. ------------------------------------------------------------------------ May 7, 2005 - 00:50 : puregin Attachment: http://drupal.org/files/issues/02_book_printer_friendly_div.patch (1.78 KB) The attached patch changes the div id to the form 'node-123'. I was concerned that a document fragment might be created with both a book section and a non-book section from the same node, leading to non-unique id's, but at this point it seems like an unlikely scenario. I've changed 'class=sect1' to 'class=section-1'. I was trying to be lazy and use the DocBook section name convention to make XSLT conversion a little easier, but it's really not saving any effort, in the end, and this is clearer. I think 'section' rather than 'depth' is appropriate - it describes what the role of the div element is. I've closed the other issue regarding id's in header elements, because I've replaced the whole 'class="book-hx"' business in headers with 'class="book-header"'. Since the level can now be selected by context with respect to the enclosing div, separate classes for headers are not required. That is, we can style with CSS like the following: .section-1 h1.book-header { font-weight: bold; font-size: 2.2em; } .section-2 h1.book-header { font-size: 2em; } .section-1 p { text-align: justified; } .section-3 p { margin-left: 3em; margin-right: 3em; } Note that the section-2 h1 will be bold, since the section-2 div is nested within the section-1 div. Also, all paragraphs regardless of section will be justified; and section-3 paragraphs will be indented left and right. Because we can style /everything/ by section, not just headers, and because the styling specifications respect the sectional hierarchy, it's possible to create very elegant and sophisticated book pages with very little CSS. Even I can do it! :) I'm definitely *not* a designer, but I've played around a bit with this - have a look at http://www.puregin.org/book/print/129 for an example. I will attach patches for misc/print.css and misc/drupal.css separately. I don't understand why, but the present version (cvs) of these files has all of the h1.book-hx selectors in drupal.css - the printer-friendly page actually looks at print.css. Am I missing something? For the record, this approach seems to have been suggested by clairem in http://drupal.org/node/8049 where I have a little rant about headings in book pages. Twice :) Djun ------------------------------------------------------------------------ May 7, 2005 - 01:10 : puregin Steven - that's a neat idea, and very clever, clean code! But it still doesn't catch problems such as, for example, an h5 inside of an h1 section with no intervening h2..h4 headers, or? I'm inclined to be a bit suspicious of the approach, though - I rather think it's 'doing magic behind the user's back'. If people are going to insist on putting headings inside of pages, it should be possible. And it would be odd for users to discover that what they typed isn't what they get. ------------------------------------------------------------------------ May 7, 2005 - 01:32 : puregin Attachment: http://drupal.org/files/issues/print_css_div.patch (1.36 KB) Here's the patch for print.css. There's a couple of commented-out lines - these show how to make section headings 'run in' as part of the following paragraph (or other inline element). I am assuming that print.css is supposed to be something of an example that people would use to experiment with? Please feel free to improve this in any way - as I said, I'm far from being a graphic designer, and I'm also not really sure what the intention of this file is. ------------------------------------------------------------------------ May 7, 2005 - 11:40 : Steven Puregin: nope, the code correctly handles missing h numbers. If the book page only uses h2, then that will be the first new level. If it uses h2 and h4, and it is inside a 3rd level book page for example (whose title would be h3), they they get renumbered to respectively h4 and h5 (no missing number). >From a semantic point of view it is crazy not to use h# for book titles. ------------------------------------------------------------------------ May 7, 2005 - 11:44 : Steven A bit more verbose: I think the overwhelming majority of users browse a book on the site itself. Within a single page, there is a h1 tag for the page title. So it makes sense for a writer to use h2, h3, etc inside a single page. This is semantically valid HTML. On the other hand, the print output places the content in a whole new context. I would expect the book module to take whatever steps necessary 'behind the user's back' to ensure it displays correctly. ------------------------------------------------------------------------ May 7, 2005 - 13:43 : puregin Sorry, I replied to the last post on the list - I'll include the post here for the record, and expand a little. Steven, I think that the issue you're addressing is actually a different one than I am trying to fix in my patch, which addresses how sections are wrapped. My patch would still allow users to write headers in their book pages - it would then be up to post-processing - or something like your approach - to deal with how embedded headers are dealt with. Perhaps we should take up your suggestion in another of the book.module issues dealing with the sequences of headers? How about http://drupal.org/node/8049, or http://drupal.org/node/4118? With respect to your suggestion - I understand now that you're proposing to apply the re-writing only to the printer-friendly output. I'm conflicted about this idea - on the one hand, the output which it produces is clearly an improvement over the present output. On the other hand, it changes what the user types to make it 'right' - I guess this is in the long tradition of HTML being interpreted very forgivingly by web-browsers and other applications. On the balance, I support your idea - I guess it's in the spirit of 'make things easier for the user'. With respect to the actual code - I don't think it will handle the case where h2, h3, and h4 are all used in the text, but the sequence h2, h4 occurs. To put it another way, the problem of checking whether headers are in a legal sequence is context sensitive, while a regular-expression search and replace (even if the replacement sequence remaps the targets) is context-free. When I say legal sequence, I mean legal in terms of book hierarchy, not in terms of the XHTML definition, which doesn't address hierarchy, because headers are titles, not sectional elements. SGML/XML publishing DTDs define such things via inclusion/exclusion on true sectional elements) The case I described is, admittedly, a relatively infrequent occurrence, and the general solution would be way to difficult to deal with - it would involve constructing and manipulating a DOM, or something along those lines. Ugh! Djun ------------------------------------------------------------------------ May 18, 2005 - 10:24 : cel4145 The Drupal doc team is very interested in being able to import/export book content. I'm sure that others would be interested in it, too. Djun has indicated that this patch is a good step toward having that functionality So +1 if the developers can help him to get this patch so that it can be implemented. ------------------------------------------------------------------------ June 1, 2005 - 03:37 : puregin This patch is subsumed in my patch for issue http://drupal.org/project/comments/add/1482, which provides for XML export of books. Note that the patch for print.css in this issue still applies with the new patch. ------------------------------------------------------------------------ June 6, 2005 - 02:30 : puregin This issue has been fixed with the application of patch from http://drupal.org/node/1482. However, I'm not sure if the print.css file patch has been commited. Dries? Also, as I mentioned, someone with real page/graphic designer's expertise should probably look over this and tweak/replace with better layout. ------------------------------------------------------------------------ June 6, 2005 - 13:30 : Dries Attachment: http://drupal.org/files/issues/opml.png (39.94 KB) I think this version generates invalid OPML and invalid Docbook code. The Docbook does not seems to validate as XML because sometimes a book-tag is closed with a section-tag. In OPML's case, the section-classes look weird (see screenshot). I'm guessing something is wrong with the computation of the depth. Are the class-sections part of the OPML standard? I'm having a hard time guessing what they are about or why one wants to use these. A couple of code comments: 1. Don't use tabs. Even in absence of tabs, the spacing isn't always 100% consistent -- sometimes two spaces are used. 2. The use of " (double quotes) and ' (single quotes) is sometimes confusing. Only use single quotes when it shortens the code. Often your code can be shortened by using double quotes (and escaping double quotes in the embedded string). Example: $output .= '<div id="node-'.$node->nid. '" class="section-'.$depth.'">'."\n"; 3. Write $depth == 2, not 2 == $depth. ------------------------------------------------------------------------ June 6, 2005 - 17:07 : puregin Attachment: http://drupal.org/files/issues/xml-export-04.patch (23.89 KB) I am now supplying the correct number of parameters to the '_post_node' visitor definitions, so the depth is now passed correctly. This fixes the problems with mismatched tags and strange section depths. The DocBook output for top-level nodes validates against Docbook XML V4.1.2 (using onsgmls). Level 2 and deeper nodes generate Chapters and sections as document fragments and so won't validate per-se. I've checked that they are well-formed, and that they validate on a manual embedding. OPML now validates against the 1.0 DTD (though there seem to be some problems with the DTD itself) I now encode the "id" attribute as string in type attribute of outline for OPML, in order to store this metadata in an existing attribute. The use case I have in mind is someone exporting the book structure (hierarchy) via OPML, editing it and re-importing to modify the structure of the book. I have removed the "class" metadata. Checked for tabs/whitespace - I hope this is now OK. Now using ($depth == 2) rather than (2 == $depth). I've replace single quotes with double where code is simplified by this. ------------------------------------------------------------------------ June 6, 2005 - 17:17 : puregin Attachment: http://drupal.org/files/issues/xml-export-05.patch (23.89 KB) Sorry, ignore the last patch - I goofed with escaping a string. The new patchfile is attached -- Djun ------------------------------------------------------------------------ June 7, 2005 - 12:22 : Dries Committed to HEAD. Great job, Djun. If any outstanding bugs need to be updated, please do.

1 0

[drupal-devel] [bug] user uploads photo to profile -> getimagesize(): Read error! in /includes/image.inc on line 88
by Robin Monks 12 Jun '05

12 Jun '05

Issue status update for http://drupal.org/node/24157 Project: Drupal Version: 4.6.0 Component: other Category: bug reports Priority: normal Assigned to: chx Reported by: lennart Updated by: Robin Monks -Status: active +Status: patch Attachment: http://drupal.org/files/issues/image.exist.patch (1.38 KB) Here is the patch per chx's comments, I made it for him as he didn't have time. He can answer any questions about it. Tested to work on HEAD. Robin Robin Monks Previous comments: ------------------------------------------------------------------------ June 2, 2005 - 13:33 : lennart When a user tries to upload a photo to his or her profile the following error occurs in the log getimagesize(): Read error! in /includes/image.inc on line 88 I am using user.module and profile.module, but NOT image.module and upload.module GD2 is working. The problem is on a fresh 4.6.1 install without any contributed modules I did not know exactly what component to post this under, but I think it is important. ------------------------------------------------------------------------ June 2, 2005 - 16:57 : mariagwyn I am having the identical problem, except that I am using image.module. It happens anytime I click onto my images section. I get about 8 error messages, all the same. It this because images are missing? Any other reason? Thanks, Maria ------------------------------------------------------------------------ June 2, 2005 - 21:47 : rolfijn Me to! I've installed the image-module also and get the same error. I've allready given a 777 permision on my drupal directory, as to make sure it's not a permissions error. When i log into drupal and go to administration -> settings i have the following setting: File system path:files (which resolves to /home/httpd/html/drupal/files, right?) and Temporary directory: tmp (which resolves to /home/httpd/html/drupal/files/tmp, right?). Then going to administration -> settings -> image i see my Default image path: images (which resolves to /home/httpd/html/drupal/files/images, right?) I run trustix secure linux 2.2 with the following (relevant) components installed: apache-2.0.54-3tr apache-html-2.0.54-3tr php-cli-5.0.4-3tr php4-4.3.11-2tr php-pgsql-5.0.4-3tr php-gd-5.0.4-3tr php-imap-5.0.4-3tr php-5.0.4-3tr php4-pgsql-4.3.11-2tr php4-gd-4.3.11-2tr php4-imap-4.3.11-2tr postgresql-8.0.3-1tr postgresql-libs-8.0.3-1tr postgresql-server-8.0.3-1tr gd-2.0.33-3tr gd-utils-2.0.33-3tr I have no idea what the problem can be. Somebody? Thanks in advance, Rolf Deenen ------------------------------------------------------------------------ June 5, 2005 - 20:22 : Dublin Drupaller same problem....drupal 4.6.1. import images...giving a warning: getimagesize(): Read error! Anyone found a solution? Dub ------------------------------------------------------------------------ June 5, 2005 - 20:51 : Dublin Drupaller hi guys... I downloaded the latest image.module from the cvs repository...and it works.. http://cvs.drupal.org/viewcvs/drupal/contributions/modules/image_import/ The only down side is that it is in debug mode (which means a load of extra messages appear)...not sure how to switch that off...but, suffice to say that it looks like the owner/maintainer/developer of the the image_import module is on top of it. best to wait until the module developer updates the module. Dub ------------------------------------------------------------------------ June 5, 2005 - 21:07 : celticess I'm getting the same error but I think it only happens to the one user using the grey box theme. Otherwise I can't find any rhyme or reason to it. Everything seems to be displaying correctly. I have the various image modules installed though not the cvs(I am using drupal 4.6.1). And no pictures have been uploaded to the galleries for it even to give the error. Also I'm getting another include error and one module specific which I have also filed bug reports on. The other include error though is common.inc line 1308 and it seems no real reason for it to be pumping out that code either.(the module error occurs only when I tell it to show browsers in the stats filtering) I'm not exactly a php wiz... haven't programmed since the 80's actually so I have no idea why it's burping out these 3 errors I'm getting. My Drupal 4.6.1 is being run off of a debian site with php4 and mysql. I myself use gentoo linux(thinking about going to BSD) however my isp TOS forbids servers or I'd run it off my own box. ------------------------------------------------------------------------ June 7, 2005 - 02:43 : chueewowee I get the same error message with drupal 4.6.0 even with all content unpublished and all images deleted from the content. The error in all pages even when not creating content. I sue a custom theme, but have not altered anything relevant to images. In fact I am having terrible problems publishing images with the image.module and image_upload.module, in that the galleries do not show in the create pages etc.. as a number of people have reported. ------------------------------------------------------------------------ June 8, 2005 - 00:57 : occy Yeah, I'm getting the same thing. :/ One would think with so many people having the same issue someone would have responded with a fix. I guess maybe I'll try the CVS version. ------------------------------------------------------------------------ June 8, 2005 - 01:31 : celticess I put the cvs module in(I'm not running cvs drupal though just 4.6.1) in and so far that error now seems gone. However the other error I'm still getting and I've got that other annoying image related problem where you've told it to default to not promoting new uploaded images to front page but it still does it. Btw I wonder if the guys realize the directions for patch aren't too clear. I've used linux since '96 and am self taught. Oddly enough never had to use patch as things auto patch on gentoo. And I've now asked friends for plain english explaination of how to do that on my debian host. Why am I mentioning patch? Because if you guys are also having an issue with album someone has put out a patch. ------------------------------------------------------------------------ June 8, 2005 - 17:05 : lennart the problem is not specific to image.module ------------------------------------------------------------------------ June 8, 2005 - 20:17 : chx mage.inc , line 83, it's not file_exists but is_file . I suspect we'd better change theme_image also. Someone should roll a patch. Or I'll do when I have time :)

1 0

[drupal-devel] copying vocabularies
by Christopher Taylor 12 Jun '05

12 Jun '05

Hello everybody, My posts aren't getting through on the support list so I thought I try this list. I was hoping somebody could help me with a PHP script or give me a suggestion that would easily allow us to copy a vocabulary. I am not familiar with PHP or programming. We have tried using groups but I can't make the content get presented in a organized news paper/magazine order in the group. I have also tried creating vocabularies of: content, community, issue The problem is there is no order to the nodes in the last two vocabularies only date order. My vocabulary has about 47 terms and it is designed to be local news, information, and discussion content for a community. I would like to copy the vocabulary so that I can build multiple communities easily. We also are going to publish the information in a weekly magazine. My first test community is Washington, DC. If you can help, please let me know. If it helps, we'll give you free advertising in our publication. Best Regards Christopher Email: christ(a)bnmc.com By the way, I can not get through on the support list. I am sorry to drupal if for some reason, you have blocked my messages. I am a young completely blind person just trying to get my feet wet. I have been given a job and I am trying to get it done. If you have a problem with my posts, please just let me know. The email list is much easier to use than the forums. Hopefully, this is just a mistake or a temporary problem. At this point, I'd be willing to pay for help.

1 0

[drupal-devel] [bug] Forum icon support is broken
by Robin Monks 11 Jun '05

11 Jun '05

Issue status update for http://drupal.org/node/21918 Project: Drupal -Version: 4.6.0 +Version: cvs Component: forum.module Category: bug reports Priority: normal -Assigned to: Anonymous +Assigned to: Robin Monks Reported by: budda Updated by: Robin Monks -Status: active +Status: patch Attachment: http://drupal.org/files/issues/Forum.Image.Display.Folder.Issue.patch (514 bytes) Here it is in patch form. I'll take responsibility of any required updates. Robin Robin Monks Previous comments: ------------------------------------------------------------------------ May 3, 2005 - 15:07 : budda The forum icon support is broken in 4.6 - currently if an icon path is provided in the user interface, it gets ignored anyway! Changes required in the function _forum_icon() of forum.module. The main problem is the hardcoded path to the icons is currently: $file = "misc/forum-$icon.png"; $output = theme('image', $file); This is easily fixed by moving the 'misc' path to the variable_get() at the start of the function. Then changing the way the $file variable is built up, as below. $base_path = variable_get('forum_icon_path', 'misc'); ... $file = "$base_path/forum-$icon.png"; ------------------------------------------------------------------------ June 5, 2005 - 19:46 : budda I'm having to modify Drupal core installs to fix this bug in forum.module. Has it been addressed at all in CVS yet? Sorry I've not submitted a patch to apply the fix. The bug still exists in 4.6.1 release. ------------------------------------------------------------------------ June 11, 2005 - 21:33 : killes(a)www.drop.org A missing icon is certainly not critical.

1 0

[drupal-devel] [bug] remove unneeded code from book
by Bèr Kessels 11 Jun '05

11 Jun '05

Issue status update for http://drupal.org/node/24805 Project: Drupal Version: cvs Component: book.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: Bèr Kessels Status: patch Attachment: http://drupal.org/files/issues/book_unneededlines.patch (759 bytes) This patch removes unneeded code from bok module. Probably old leftovers. Bèr Kessels

1 0

[drupal-devel] [PATCH] 4.6.1 Add events to Drupal
by Fab Psycho 11 Jun '05

11 Jun '05

Hi, Here's a patch adding event management to nodes against 4.6.1 Ok, it's my very first drupal patch so I'd be glad if you could help me making this sound professional :) URL : http://www.deepbass.net/~fabian/drupal/drupal4.6.1ff1.diff Features : +-pushbutton, bluemarine style fix for events +-add event display to archive module +-mysql & pg fix for events +-add events to node_form +-add events to node_save (node_module : node_page->switch op -> node_submit($_POST['edit']) -> node_save) +-add events div in drupal.css +-node_validate additions for events +-node_form->form_textfield->common.inc->_form_get_error($name) Result : -User can add start & end date for an event related to a node -special tip is displayed to related dates in archive module. Remains: archive calendar doesn't display future :( someone could synch this ? Best regards, FabF _________________________________________________________________ Protégez votre boîte de réception: Phishing : comment l'identifier, le signaler et l'empêcher http://www.fr.msn.be/security/phishing/

2 1

[drupal-devel] [bug] Incorrect access checking for username auto completion
by Thox 10 Jun '05

10 Jun '05

Issue status update for http://drupal.org/node/24617 Project: Drupal Version: cvs Component: node.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: drumm Updated by: Thox -Status: active +Status: patch Attachment: http://drupal.org/files/issues/access.patch (1.55 KB) Attached patch moves the menu entry from user.module into node.module and fixes the permission check. Thox Previous comments: ------------------------------------------------------------------------ June 9, 2005 - 01:36 : drumm The auto completion for user name on node edit pages checks user_access('administer users') when it should be something more like node_access($node, 'edit'). ------------------------------------------------------------------------ June 10, 2005 - 16:32 : Thox -1 The current "Authored by" field is only for users "administer nodes" permission. ------------------------------------------------------------------------ June 10, 2005 - 16:35 : Thox Whoops, administer nodes != administer users. This makes things different. The true permission should be administer nodes... which almost suggests that the autocomplete function should be part of node.module, not user.module. It depends where else the autocomplete is used in the future. ------------------------------------------------------------------------ June 10, 2005 - 16:57 : killes(a)www.drop.org I think the function should stay in user.module, but node.module should get a menu callback that utilizes it. This is not a problem as user.module is a required module.

1 0

[drupal-devel] Google Summer of Code: Social context of content
by Kieran Lal 10 Jun '05

10 Jun '05

Hello, please review this proposal and provide feedback for consideration as a Google summer of code project for Drupal. The social context of content is important in evaluating content. User questions this is trying to answer: Who is the person everybody reads? Who was there when the subject of the content happened? What are your friends reading? What is relevant for your next social meeting? What it is the socially relevancy of media such as pictures or video? The goal of this project is to allow for the descriptions of content in a social context and to automatically discover the social context of content. The first phase will be to create a standard set of social tags for describing individuals, their relationships, and their activities. These descriptions will be done using the taxonomic tagging module in Drupal and it's forthcoming customer relationship management module. The automated discovery of the social context of content will be the second phase. This will allow social context to be derived from information that is available but not coordinated. This will include user page views, authorship, number of reads, response rate weighting, interaction of buddy list contacts, social weight of readers, responders social weight , events, locative information, volunteer, and invitation information which are all currently available in Drupal modules. Why this is innovative? Content management has currently focused on supporting varieties of content, transcoding content, and integration of content with other systems but has done little to state why it is socially relevant to people. This project aims to enable producers, consumers, and managers of content to describe content in a socially relevant manner. It also aims to discover how users want to describe the social context of content and how they prefer to consume that information. Drupal's well defined schema allows for discovery of social context in structured data that is presented to users in an unstructured way. Deliverables Part I: Social context tagging An open standard for referencing individuals, their relationships, and their activities. This will be an open standard for Community Relationship Management based on the CiviCRM open standard, SugarCRM, foaf, xfn, rojo (proprietary), aura (codecon 2005), and SalesForce for non-profits. A database file with this standard taxonomy, and possible folksonomy extensions. An interface for the module which allows social context tags to be effectively displayed with content. An interface for allowing users to add social context tags or extend their own tags. Part II: Automatic discovery of social context. A module that drills across content management tables for social context information and creates a table with the total social context of content nodes. This will be done in off-line batch modes as a series of data warehousing style queries. This will be architected to include queries to other data marts. Interested Googlers who would benefit from this open source project Danah Boyd from Blogger and Ellen Spertus from Orkut would be able to benefit from research into social context prototypes. Academic references This project was inspired at the Computer Human Interaction conference 2005. One paper from Microsoft described the need for social context of content in Microsoft Outlook rather than meta-data such as file size, date, and urgency. One paper in the short papers section described how a photo of young people in a car on a trip could be socially relevant because it could have been the author's nephew who died on a similar car trip. This illustrates the power of social context of content. A paper from Microsoft analyzing Usenet post meta-data showed that power users were most interested in what the most respected people in a community were saying. References to papers and academic relevancy will be added to this proposal.

3 4

[drupal-devel] [feature] Enable multiple block regions (not just "left" and "right" sidebars)
by chx 10 Jun '05

10 Jun '05

Issue status update for http://drupal.org/node/16216 Project: Drupal Version: cvs Component: block.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: paragkenia Updated by: chx Status: patch I need 3-4 hrs of peace to implement the callback based thing. That's a lot these days. Let's hope I'll get on it in the following days. chx Previous comments: ------------------------------------------------------------------------ January 26, 2005 - 12:27 : paragkenia I read the comparision discussion between *Drupal* and *Mambo*. In several messages it was outlined that Drupal can place blocks only in right and left and not flexible to put them on anywhere where one want. It will be great if this can be changed in upcoming versions. I am no pro at PHP, so don't know how much time this task will take, but I think it is very important. parag ------------------------------------------------------------------------ April 15, 2005 - 03:44 : nedjo This issue was apparently partially addressed in issue http://drupal.org/node/19694 [1]. [1] http://drupal.org/node/19694 ------------------------------------------------------------------------ April 17, 2005 - 02:24 : nedjo Attachment: http://drupal.org/files/issues/block-dynamic-regions.patch (8.17 KB) This much-requested functionality - to have the ability to place blocks in more than the two predefined regions - was partially addressed in issue http://drupal.org/node/19694. [2]. But "blocks" are still limited to the "left" and "right" sidebars (hard-coded in block.module). This patch is a first step designed to enable multiple (eventually, admin-definable) regions for blocks. I've moved the existing "left" and "right" block regions to a 'region' table (with ids of 0 and 1, as currently used in themes). Then all references to the regions are drawn dynamically from the table. This way, if further records are added, they will appear in the list of available regions for block placement. Doing this actually reduces some duplicated code, since it's no longer necessary to repeat code blocks for each of "left" and "right". As it stands, the patch doesn't add any new functionality--but I don't think it breaks anything either. New functionality would need (a) new regions defined, and (b) changes to themes. A simple first step might be, e.g., to add a "footer" region and then add a call in the footer generation to append any blocks assigned to the footer region there. I'm setting this to patch, but I'm aware that it needs some discussion and refining before it'll be ready to apply. [2] http://drupal.org/node/19694. ------------------------------------------------------------------------ April 17, 2005 - 03:05 : nedjo Attachment: http://drupal.org/files/issues/block_regions.png (5.65 KB) Here's a screenshot showing the block admin page, with drop-downs for region placement (the options are dynamically generated based on defined regions). ------------------------------------------------------------------------ April 17, 2005 - 04:57 : adrian The biggest problem with this is that you can have multiple themes, and each of these themes can have different regions available. Also, the method of defining which regions are available needs to be standardised. Some of the work that me and Vlado are working on for the install system would go towards solving that problem (ie: meta information for modules, themes and styles). This has been discussed to death, but the general consensus has been that we _want_ to do this, but we need to solve a few other problems properly first, the most pertinent being the interface issue. Chris (factoryjoe) recently did a whole mess of workflows for something related to this. ------------------------------------------------------------------------ April 17, 2005 - 06:09 : syscrusher The first paragraph of adrian [3]'s post is a point that occurred to me also, as I read this thread. One suggestion would be to separate the definition and configuration of blocks, on one hand, from the placement of those blocks, on the other hand. In other words, Drupal core provides a mechanism defining what blocks exist, which of these are on by default or off by default and user-selectable vs. which are forced on for all users, and the configuration (if applicable) of specialized blocks defined by particular modules. Each theme provides a standard hook function that returns an array of region names and help/description text, e.g., array('left'=>t('This vertical region is left of the main content area'), 'right'=>t('This vertical region is right of the main content area'), 'footer'=>t('The footer is below the left, right, and main content areas of the page')). The theme part of Drupal core (i.e., theme.module itself, not the individual themes) provides a standard UI that is displayed within config of *each theme* (but is one physical code base within theme.module) that allows the administrator to map blocks defined by Drupal core into regions defined by the theme, and storing that mapping as an theme-to-block_ID-to-region_ID (with weight) table in the database. From there, the actual page rendering is similar to what's being done now, but there is more of it. I guess what I'm trying to say is that the key to solving this problem is breaking it along its degrees of orthogonality, and there are three -- two in Drupal core and one in the individual theme. Scott [3] http://drupal.org//user/1517 ------------------------------------------------------------------------ April 17, 2005 - 09:14 : Dries Scott, is right. The theme should export its available regions. Then the administrator's task is to assign blocks to regions (not to setup regions). A theme could have configurable regions, but that internal to the theme. To me, the real challenge is the UI and the interaction design. Configuring blocks could easily become a real pain (while most themes continue to use 'left' and 'right'.) Of course, we can implement all the functionality, default everything to 'left' and 'right', and worry about the UI later. This should be fairly straightforward to implement and nedjo's patch looks like a first step in the right direction. ------------------------------------------------------------------------ April 17, 2005 - 23:09 : nedjo I agree with the suggested approach of themes registering their regions. I'd see this happening when a particular theme is activiated (or upgraded). Regions would be an array of names (e.g., 'left', 'right', 'footer'). New records would be created in the region table only for region names not previously registered. Some areas I'm not clear on, or that need further work: * Table naming Should a new table be 'region' or 'regions' (I've used 'region')? I don't see a convention among existing table names, some of which are singular and others plural. * Default values I've kept the existing '0' and '1' ids for regions (left and right, respectively), for backward compatibility. But this means we can't use autoincrement for the region id (rid), since autoincrements seem to begin with 1. Likely we should change to autogenerated ids. * Initial records Using the INSERT INTO statements as I've done for the initial region entries is probably counterproductive, since sooner or later they'll have to be dynamically generated. I was hoping this could be a preliminary patch, with the main work coming later, but likely we need to solve region registration by themes before this patch is applied. I don't have a good idea of how region registration by themes would be implemented (a hook on theme activation?), and invite suggestions or implementations. * Theme system changes Besides region registration, the other change I'm seeing that would be needed in the theme system is loading blocks by region name, rather than region id. This is because the ids currently used ('0' and '1') in theory might be diffferent on a particular install. ------------------------------------------------------------------------ April 17, 2005 - 23:18 : syscrusher Instead of having themes "register" their regions, why not just add a theme API hook called them_regions() that returns an associative array of $region_name=>t($region_helptext)? This would be in keeping with other similar API functions, such as those that return what permissions apply to a module or what node types are defined by a module. Most themes are going to define only a small number of regions (two being the typical case now, but I could see five or six in a complex theme), so returning a constant array will be faster than querying SQL to obtain an array of rows. There could be (optionally, at the discretion of whoever builds this thing) another API hook like theme_region_properties($region_name) that returns an associative array with detailed info for a given region, such as extended help text with recommended usage instructions for the region. Scott ------------------------------------------------------------------------ April 17, 2005 - 23:19 : syscrusher s/them_regions/theme_regions/g ------------------------------------------------------------------------ April 18, 2005 - 00:47 : adrian Because. The most common 'theme' is a phptemplate theme. And there needs to be a generic method for specifying the regions available, in a non hook_function format.. Themes get their names from the directory in which they are contained.. when copying the theme to another directory, there must be _no_ modifications necessary to allow normal usage. This is one of the tenets of the new template system I designed. You would need a standard way to define meta-information for themes, that does not need to be modified when copied to a new directory. We are working on this in the install system work, as you need a way external of Drupal to define the module dependencies and some other things. My approach would be to add a theme.dsc text file to the directory, which would allow you to specify meta-information. For instance : ---- regions: left, right, footer, center, mountie author: Johnny McAngstyPants ---- ------------------------------------------------------------------------ April 18, 2005 - 04:00 : syscrusher Adrian wrote: " Themes get their names from the directory in which they are contained.. when copying the theme to another directory, there must be _no_ modifications necessary to allow normal usage. This is one of the tenets of the new template system I designed. " A very good point. But region names don't have to be unique across different themes, so my hook function wouldn't have to be modified. The suggestion I made for the mapping metadata was three factors: theme ID or name, region ID or name, and block ID (plus one non-key weight value to order the blocks within a region, but this is not relevant here). I'm not familiar enough with PHP template to be able to respond to your comments on that one, so if you say it's not feasible to work with my schema, then I'll take your word for it. :-) Scott ------------------------------------------------------------------------ April 18, 2005 - 04:03 : syscrusher Oh, wait.....I see now what you mean! It's not the output of the function that is the problem, but the *name* of the function. Never mind. I concede your point. Scott ------------------------------------------------------------------------ April 18, 2005 - 09:44 : Jaza I'm probably jumping ahead a bit here... but something that this patch will have to eventually account for, is how to allow regions to be defined as inline. Allowing a theme to define a region's position as being anywhere on the edge of the page (i.e. top, left, right, bottom, corners, etc) is relatively easy. But what about having a region that's in the middle of a node's body, or somewhere else that's not the edge of the page? What I'm thinking of, is eventually allowing the custom region system to integrate with the CCK. Like I said, I admit that I'm jumping ahead into the future - the CCK still has a long way to go before it's ready. But ultimately, it would be cool if a theme could define a region as being after, say, the "rating" field in nodes of type "movie review". This would make the region (and the blocks in it) truly inline and in context with the actual content of the node. This would be a huge step forward compared to the current block system, which doesn't allow you to mix the presentation of blocks and nodes at all. In Drupal ATM, blocks and "the rest of the page" are totally separate, and really you have no choice but to display them as such. The result of this is that information in blocks that really should be displayed as part of a node, gets literally "pushed to the side", and always seems secondary to the actual content. Often the block has content that is just as important as the content of the node itself. Another option (of less merit, IMO - because of the extra maintenance work, and lack of enforced consistency) would be to have a region filter. You could then choose where to place an inline region on a per-node basis, by entering text such as [region:2] (example based on image_filter syntax) into the node body. Anyway, just thought I'd throw that idea into the open. I don't expect it will be implemented any time soon, but it's something to think about. Jeremy ------------------------------------------------------------------------ April 18, 2005 - 10:54 : stefan nagtegaal Attachment: http://drupal.org/files/issues/regions---possibility-1.png (1.29 KB) Imo the 'regions' are more than you guys name here.. FOr example I attached 2 screens which only shows you the regions.. What I think is that it should always be possible to have free names for the regions. No matter if i call - the region where my content appears in - 'content' or 'site items'.. See attached screens.. ------------------------------------------------------------------------ April 18, 2005 - 10:56 : stefan nagtegaal Attachment: http://drupal.org/files/issues/regions---possibility-2.png (1.39 KB) And the second... See these links: - http://drupal.org/files/issues/regions---possibility-1.png - http://drupal.org/files/issues/regions---possibility-2.png ------------------------------------------------------------------------ April 18, 2005 - 17:22 : nedjo Attachment: http://drupal.org/files/issues/block-dynamic-regions2.patch (13.39 KB) Here's a revised patch implementing some of the ideas so far. I've used the theme engine - rather than individual themes - to generate the list of available regions. I know this isn't ideal, but e.g. for xtemplate it's at present the only option--no logic is possible in the individual theme. region is changed to a varchar field from the current tinyint. I've roughed in several regions--really just for demo purposes. More thought and work would be needed to refine them (e.g., styling, etc.). But this maybe moves the conversation forward. ------------------------------------------------------------------------ April 18, 2005 - 23:26 : Dries This patch enables different regions to be used. That is a good thing. The next question is: should we take into account that different themes could assign blocks to different regions? Lots of problems would be solved if (i) there could only be one active theme on a website or (ii) if all themes would have a common set of regions. (This "let users select their own theme"-thing is a left-over from the early days, except for WAP stuff maybe.) ------------------------------------------------------------------------ April 18, 2005 - 23:37 : killes(a)www.drop.org Giving up multiple theme support would be a great thing. People could still select from multiple style sheets. WAP shoud not be a user preference setting, but automatically detected and redirected to a special site with a WAP theme. ------------------------------------------------------------------------ April 18, 2005 - 23:48 : adrian You would then lose the ability to make a special front page theme for use with the sections module, for instance. Also, currently styles exist in the same namespace as themes, and we would have to make more a distinction of styles vs templates (or themes), but I do think this could help simplify things. ------------------------------------------------------------------------ April 21, 2005 - 18:54 : nedjo Attachment: http://drupal.org/files/issues/block-dynamic-regions3.patch (15.69 KB) The main issue raised, if I'm understanding well: if a theme or theme engine is present that offers regions other than those available in the default theme, any blocks assigned to those regions will be invisible to most users. Here's a revised patch addressing the concern. I've added a test for each region to see whether it's also available in the current default theme. (Actually, I'm realizing as I write this, I've used the theme engine--so it would need to be updated to test first if an engine is being used.) In any case, any regions not available by default are starred, and a message text appears (only if necessary). If there's support for the approach, I'd be happy to finish the patch. Remaining work: * extend to work with non-engine themes * finalize base set of regions to implement * implement common region set in all core themes (for now I've only done xtemplate) * work on CSS display (how blocks in each region should look) This last point I'm not too confident on and would look for help/suggestions. Screenshot to come. ------------------------------------------------------------------------ April 21, 2005 - 18:56 : nedjo Attachment: http://drupal.org/files/issues/block_regions_message.png (12.34 KB) Screenshot showing starring of non-default regions plus message. ------------------------------------------------------------------------ April 21, 2005 - 19:19 : killes(a)www.drop.org I like that approach. +1 ------------------------------------------------------------------------ April 21, 2005 - 19:23 : resmini My two cents. If this has to be done (and it should), better get rid of spatial definitions for areas such as left, right, top, bottom, etc. Use semantic names related to content and let the theme take care of their positioning interely. Also note that there in an ongoing debate in IA trying to build up a standard naming convention for page regions in a way that is semantically (and logically) correct. Just for the sake of it, you can check http://www.stuffandnonsense.co.uk/archives/whats_in_a_name.html http://www.stuffandnonsense.co.uk/archives/whats_in_a_name_pt2.html with follow-ups, including Eric Meyer's. There are more substantial contributes in the AIfIA web site, but I can't seem to find them now. I'll post a link or an abstract if I manage to. -- vector at exea dot it ------------------------------------------------------------------------ April 21, 2005 - 20:15 : nedjo Good points, useful references. The default regions I'm thinking of are: 'banner' => t('banner'), 'left' => t('left sidebar'), 'right' => t('right sidebar'), 'body_top' => t('body top'), 'body_bottom' => t('body bottom'), 'footer' => t('footer') Perhaps "body" would be better as "content"? It would be easy enough to add in more regions, e.g., within the content (after title, after help, etc.) One issue is that many of these regions will already have rendered content. Should the blocks come before or after that other content? I've assumed after for banner and footer, while giving both options in body. In any case, refinements or suggestions would be great. ------------------------------------------------------------------------ April 21, 2005 - 20:56 : resmini Well, 'banner' => t('banner'), 'left' => t('left sidebar'), 'right' => t('right sidebar'), 'body_top' => t('body top'), 'body_bottom' => t('body bottom'), 'footer' => t('footer') The classic (as far as classic goes for something Web related) scheme comprises 5 spatial regions, much like stefan's http://drupal.org/files/issues/regions---possibility-1.png with a left area mirroring the one called 'blocks'. Call them top, left, center, right, bottom. Variants usually exclude one or more of these, layout-wise. If we talk content (semantic) instead, things get a bit more complicated, as these spatial regions normally include more than one content-area. The top, for example, could include ad banners and the site's header, or the main menu. But these merge seamlessly with CSS definitions, which are definitely something that should get properly standardized (most of the errors / inconsistencies I'm encountering with Drupal today are related to this), but this is out of scope in this thread. What I somewhat object to the definitions above is that it mixes the two approaches. 'banner' is not spatial, is content, as it is the distinction between body top and bottom. If 'banner' goes there, it is 'top', whatever that might be. I designed a couple of web sites which had headers/logos/banners at the bottom of the page, and I'm not exactly the wildest designer you'll probably meet. And if we include body_top and _bottom, we should also add 'navigation', or 'menu' and some other content-related semantic region (impressum, or company_data, or whatever). I suggest that either we go along 'top' => t('banner'), 'left' => t('left sidebar'), 'center' => t('body'), 'right' => t('right sidebar'), 'bottom' => t('footer') or we dedicate some time to detailing what could possibly fit there semantically, which is perfectly possible without limiting design freedom or whatever, since the vocabulary is not infinite, but not something you do out of the blue. Please note that I understand t('something') to be an example, since such a layout only defines regions on the page, not semantic regions. My main content could fit nicely in the bottom region. As for the names for the regions, they are not important, as much as they are coherent and enforced. ------------------------------------------------------------------------ April 21, 2005 - 23:16 : stefan nagtegaal Attachment: http://drupal.org/files/issues/regions-final.png (2.39 KB) Maybe something like this??? But, I have to say that I _really_ liked the solution to split the 'content'-region into the 'content' and 'beneath content'.. I love that! ------------------------------------------------------------------------ April 22, 2005 - 00:20 : resmini Stefan, yes. That's basically what you can build if you stick with spatial, and this layout can generate quite an amount of (sane) layout variations even if you interpret it strictly (suppose a default) as <div id="header"> </div> <div id="left-bar"> </div> <div id="content"> </div> <div id="right-bar"> </div> <div id="footer"> </div> What you can do with this is left basically to the theme designers and their use of CSS, CSS-P or tables (brrr), but this could be an easy and proper way to identify macro-regions in which more accurate positioning happens at a more specific level. I'm all in favour of subsequent identification of sub-areas (top and bottom in body), but I don't think it would be a good idea to mix the different approaches I mentioned in my previous post. A site with lots of things going on or which is not just blogging surely has the need to use its content area in a wiser manner than just putting there 'content', the number of modules doing precisely this is more than proof, but that falls more in a 'Drupal definitive guide to semantics', in which CSS selectors are used or suggested strategically for such a scope. >From this point of view and for the sake of this thread, any unique area / div (#name) could (should?) be a target for blocks, and this in my opinion (*) would be the perfect solution, but I do not know if and how this is even remotely possible in the current Drupal. (*) It's quite late, local time, and it was a looong working day. ------------------------------------------------------------------------ April 22, 2005 - 00:38 : resmini Attachment: http://drupal.org/files/issues/regions-final-variation.png (1.9 KB) Just to be clear, I add a variation of stefan's scheme that shows how this is *not* by any means positional, but spatial, or better relational. Use your CSS imagination to take out regions, reduce them to empty containers, enlarge them, make them taller, shorter, whatever. 5 regions, do what you like. ------------------------------------------------------------------------ April 22, 2005 - 00:44 : resmini Sorry, I forgot. And this is also why I'm not too keen on calling anything 'content'. If I enlarge my right region enough, why not put my content there? Shouldn't this be a theme-level concern? It's nothing serious, but if my center area is called 'center' (or something similar and more sexy), I won't confuse anybody. This is left, center, right: do with them what you prefer. Content in the bottom? Show me. If I call something 'content', I'm more than suggesting that content goes there, and only there. ------------------------------------------------------------------------ April 22, 2005 - 10:17 : stefan nagtegaal Resmini, maybe it is only me but I think that you are making a mistake in your way of thinking.. I get the feeling that you're mixing the 'regions' and 'divs'.. the 'regioins' should have meaningfull sentences, but the divs shouldn'thave.. As an example: $region_name => $content_body here we go: 'header' => $logo 'left sidebar' => theme('blocks', 'left') 'right sidebar' => theme('blocks', 'right') 'content' => $content 'footer' => $footer. So, $region_name does not have to be equal to the id or class of the divs.. ------------------------------------------------------------------------ April 22, 2005 - 11:27 : resmini Stefan, >So, $region_name does not have to be equal to the id or class of the divs.. Yes, absolutely. I probably didn't make myself very clear: what I'm trying to point out is that in 'header' => $logo 'left sidebar' => theme('blocks', 'left') 'right sidebar' => theme('blocks', 'right') 'content' => $content 'footer' => $footer. there is no reason at all to call 'content' the region that holds $content. nedjo asked in #24 'body_top' => t('body top'), 'body_bottom' => t('body bottom'), if /Perhaps "body" would be better as "content"?/ and all my reasoning is simply that no, that is not content, or it shouldn't be (or better: it may happen that main content is elsewhere). As a matter of fact, even the connotation 'sidebar' doesn't fit very well logically. To make it short: Today's method works, but has limits. Mambo, which paragkenia quotes at the beginning, handles more 'user regions' but in pure Mambo style conventions are so loose that they are hardly useful. If we define regions, as in nedjo's example, in my opinion these regions shouldn't imply informational layouting, only relational positioning (that is, where they stay in the browser viewport). I know it may look like overdesigning, but Drupal constantly enforces conventions and coding guidelines everywhere: this is one of the best aspects of the project and I think it should carry to the layout. ------------------------------------------------------------------------ April 22, 2005 - 11:32 : stefan nagtegaal While I think that 'body_*' is not as self explaining as 'content_*' I vote for using 'content_*'.. ------------------------------------------------------------------------ April 25, 2005 - 19:48 : chx Let's get back to the code. If my understanding is correct the big discussion is about how to name potiental rectangular areas _after_ this is commited. So, first get this committed. What's need to make that happen? ------------------------------------------------------------------------ April 25, 2005 - 20:56 : chx I spoke with Moshe, Steven, JonBob and the result is: keys shall be numbers, and themes shall define the values. We will make region zero and one required. There will be a define('REGION_CONTENT', 0) and a define('REGION_SIDEBAR', 1); so you can have readable code still. Either wait for me to code it or feel to do it yourself, just drop me a mail via the contact form if you are doing it. ------------------------------------------------------------------------ April 27, 2005 - 18:14 : nedjo Károly, it's great if you're willing to take on finishing this. I tried to summarize remaining work in update 20, above [4]. The numerical keys look fine to me. In terms of an initial default set of regions, one quirk is this: for now, so far as I can see (and assuming the approach I sketched in), available regions can be defined only in (a) theme engines and (b) individual themes that don't use an engine. So, for instance, an individual xtemplate based theme can't define its own custom regions; they need to be defined in the theme engine. (Unless and until the whole theme system should switch to the sort of configuration file adrian suggested above [5].) Which is to say that, under this approach, we'll be defining a set of regions for each engine, and then all themes using that engine should try to implement those regions. (Otherwise, if a site admin selects a region defined in the engine but not implemented in the default theme, the content won't appear.) Please let me know if there's anything in what I've done that isn't clear, or if you want to pass some or all of this back. Thanks! [4] http://www.drupal.org/node/16216#comment-27398 [5] http://www.drupal.org/node/16216#comment-27052 ------------------------------------------------------------------------ May 9, 2005 - 22:36 : chx I had a "short" discussion with the UI team leader ie. Ber Kessels. The outcoming is that we will change hook_block so that it uses callbacks a bit like menu system. Here's an example: <?php function module_block() { $items = array(); $items['module_header'] = array('callback' => 'mymodule_page', 'weight' => -50, 'region' => 'content' , 'cache' => TRUE, 'pages' => "node/*\n<front>"); return $items; } ?> Please note that we are allowing caching the themed output of each block independently. The theme system will execute hook_block as it does now and it'll execute the callbacks defined in module_block as well. Of course if the callback is cacheable and in the cache, it'll print it from cache. If it's themeable and not in the cache, it'll cache it before printing. Pages contains a string (could be PHP code!) which can be overriden in the block configuration screen. Callbacks defined in hook_menu will have lot less functionality after this, they will be used for non-themed pages mainly. ------------------------------------------------------------------------ May 9, 2005 - 22:45 : chx More explanation is requested for the example. module_header is the unqiue name of the block. pages define on which pages the block is visible. ('pages' in the block configuration screen.) Maybe I'll implement 'visibility' from the same screen as well. callback, weight are well known Drupal terms. cache is a boolean which defines whether given output is cacheable or not. ------------------------------------------------------------------------ May 9, 2005 - 22:47 : chx Ber, Dries, do not kill me! Ber chaired the usability meeting in Antwerp, that's all. ------------------------------------------------------------------------ May 9, 2005 - 22:52 : Bèr Kessels Attachment: http://drupal.org/files/issues/more_regions_principle.png (123.29 KB) attached is a schematic which might clarify this a little. And I would also like to comment on me being the UI leader: I do not consider myself any leader, no ofeence, though. Just to clarify that. ------------------------------------------------------------------------ May 10, 2005 - 00:42 : nedjo I am not opposed to the idea of changing the _block() hook to use callbacks (I have no opinion on it, not immediately grasping the need), but this seems quite distinct from the aim of enabling multiple and extensible regions. Why can't we just move ahead with the block generalization? I suggest: * quickly implement the proposed block region generalization, using only the two existing regions (i.e., implementing them in core themes) * later worry about: - adding further regions (the details of which are best done by those primarily responsible for the particular themes) - possible changes to the _block() hook. Wouldn't this make sense? Or am I missing some pressing reason for which the block generalization has to wait? ------------------------------------------------------------------------ May 10, 2005 - 03:28 : killes(a)www.drop.org "Or am I missing some pressing reason for which the block generalization has to wait?" I might be missing something too, but I thought Chx was just talking about the block generalization and proposing a way to code it. ------------------------------------------------------------------------ May 10, 2005 - 04:41 : factoryjoe I wanted to chime in with this discussion because it's an important one and has some really huge implications for Drupal moving forward. That said, I also have a day job pulling all my attention which means that the big ideas I have for this problem can't be put into a complete visual form for at least a week or more. In the meantime, I'd like to offer a few thoughts on the matter. * *Regions do not belong in themes.* Blocks were originally separate from themes for a reason. Themes should define the general look and feel of a site -- and to some extent a site's behavior. Layouts which define the spatial relationship between regions belong in some intermediary between style and content, which does not currently exist in Drupal. * I would propose that *layouts become a new kind of CCK tool.* By that I mean that they can be defined, shared and deployed very easily -- even as simply as tossing a directory of some .layout textfiles into a layouts/ directory. Note that this suggestion has nothing to do with the way CCK /might actually/ work right now; instead I'm suggesting how I would like it to work. I would like, for example, to create a CCK item like a "person" and ship it with a .layout file that carries all the semantic goodness needed to output that "person" to the screen in juicy, semantic markup... which anyone can come along and theme to their heart's content. * *Creating shareable layouts should be relatively painless.* Dashboard [6] sets the bar for easy hackability. It should be that easy to create layouts for Drupal... I can imagine creating an "iTunes layout" or an "Image Gallery" layout and so on... If we used something akin to PHPTal to develop the layouts, we could keep development fairly standard while making it possible for more folks to hack up cool and innovative layouts. * *Layouts should be extensible.. to a degree.* I see a huge problem with how this discussion has floated back and forth between semantic and spatial region naming. Because we talk about this problem in those terms, we fail to identify the real problem and opportunities presented to us. Here's the thing: when you predefine regions, you limit creativity and the ability of people to really use the system. On the other hand, when you make a system too flexibile, it quickly becomes unwieldy. In all the mockups presented above, both classes of problems would arise. Therefore we need to think about a way to stay flexibile while "taming the beast." * To that end, I suggest developing *self-contained layouts that are contextually-complete.* So for the example of the iTunes search layout... you would know before hand that you get a couple multiple select boxes that you can hook up to whatever taxonomies you want to progressively filter [nodes]. You could even change the .layout file, allowing you to theme it to your liking -- even though that would totally optional, given the layout's internal default styling. Once you've got your layout, you would go into a layout module UI [7], create a new layout [8], select the layout from a list [9] and then give it a path so you can access the layout... You would then walk through a wizard [10] that would help you populate that layout with all kinds of nice Drupally goodies... feeds, node listings, PHP code, etc. The power in this approach is multifold. For one, it snaps Drupal out of its block mentality and allows designers to really innovate with individual page designs. In fact, I've already thought out how I could reimplement Flickr using this system, combined with Drupal's native feeds, taxonomy and menu module, and I'd barely break a sweat... sort of. ;) But anyway, this is a very productive conversation to be having, but I really think that we should consider whether the old paradigm, as such, really pushes Drupal as far forward as we have the opportunity to go. [6] http://drupal.org/apple.com/macosx/theater/dashboard.html [7] http://photos4.flickr.com/6944826_90af237c99_o.png [8] http://www.factorycity.net/demos/civicspace/layout/new.html [9] http://www.factorycity.net/demos/civicspace/layout/new_layout.html [10] http://www.factorycity.net/demos/civicspace/layout/testing_add.html ------------------------------------------------------------------------ May 10, 2005 - 06:34 : chx While factoryjoe may be right, I could be right as well. Regions has definitely something to do with themes, after all it's the theme that renders the page, and it can only render regions that it knows of. So, instead of postponing this into the far future when someone comes out with a layout system, I code this now. ------------------------------------------------------------------------ May 10, 2005 - 07:22 : Dries The proposed 'weight', 'region' and 'pages' would be configurable, not? Are these just defaults? The 'callback' and 'cache' options are nice to have. ------------------------------------------------------------------------ May 10, 2005 - 07:25 : chx Yes, blocks can provide a default for everything on the block and and configuration screen. Of course, you can override these in the UI. ------------------------------------------------------------------------ May 10, 2005 - 11:02 : Bèr Kessels Dries: yes, the region, weight and pages will be configurable from an admin interface. What we tried to address here, is a method for developers to choose good defaults. Take for example "logo". that should be enabled by default in a regions called header, rendered on all pages, and have a very light weight. We should not force an admin to visit the blocks admin before she can see or use the logo. Chris: I do not know if you have ever tried typo3. Its concept is some form of builder system. I do not like thar, because far too complex. If we ever get sme kind of builder in core (if ever) it will require a lot of work, and even more usability research. So for now such a builder is far out of our reach. Lets aim at goals that are more realistic ;) So: it does belong in themes, its the best place that is still realistic. I do like your visions, Chris, but I hope you agree they are not realistic, yet. So, maybe you can think of a path towards your visions, ow we can reach such a builder-system, you describe? ------------------------------------------------------------------------ May 10, 2005 - 16:52 : factoryjoe My browser crashed before I was able to submit my followup to chx's comment... I have no problem with the current work going forward and am happy to see it happening. I know that my ideas are typically outlandlish and far off... That's the kind of design I enjoy doing! In any case, I see chx's solution being a means to an end; once we have abstracted the region code, it become much easier for me to get some help creating my vision. In the meantime, and as a demonstration of how I see this layout system working (to answer, I hope, Ber's concerns about clunkiness), I've created a workflow movie that shows off how fast you'd be able to add content to the system. Check it out: http://factorycity.net/demos/civicspace/layout/media/layout_workflow_v1.mov Feedback appreciated. And, if you want to try the demo out yourself (it's all hardcoded, like a "movie set" for my UI), go here: http://factorycity.net/demos/civicspace/layout/ ------------------------------------------------------------------------ May 12, 2005 - 18:45 : nedjo Attachment: http://drupal.org/files/issues/block-dynamic-regions4.patch (13.56 KB) "I might be missing something too, but I thought Chx was just talking about the block generalization and proposing a way to code it. " Well, if I can say so respectfully, I don't think so. Not so far as I can see identifying problems with my original patch, this interesting discussion is rather addressing the (useful, but logically subsequent) question "once we have multiple regions, how should we work with them?". It's perhaps demonstrating our propensity to try to do more rather than less with a given patch--to talk for a long time when a first step solution is already in place. So here is a (yes, interim!) small, focused, and tested patch to remove the hard-coded regions. I've stripped it down so it does nothing more than (a) make block regions declared by themes rather than hard-coded and (b) implement the existing left and right regions in existing core themes. Please, try it out, I think you'll like it. I'm of the (I'm hoping not scandalous) opinion that it can be applied right away, and so clear the way for further progress. In particular, this patch leaves the adding and configuring of additional regions to theme authors/maintainers, who are best qualified for the work. "I spoke with Moshe, Steven, JonBob and the result is: keys shall be numbers, and themes shall define the values. We will make region zero and one required. " The reason I moved from numbers to strings (e.g., "left") is that a theme author defining regions has no way of knowing what regions might have already been defined, and therefore what integers might have aleady been used. It's like module and theme names--we'd have to use random numbers to avoid conflicts, so we're better off with string names. ------------------------------------------------------------------------ May 12, 2005 - 20:17 : Bèr Kessels nedjo, I am not a fan of your solution for blocks that dissapear. It breaks the ability to allow more themes on a site. if important blocks dont show up, your site will simply break. I would rather suggest that every theme MUST have a region called 'default'. any blocks that want to go into a non-existing region, will be placed there. We must define a standard listy of suggested region names. to avoid a wildgrowth of names. I am not sure if i like the way you do function phptemplate_regions(). these regions should be defined in the templqtes, not the engine. Otherwise all phptemplate themes will still all have two regions. Note that i did not test your patch thouroughly, just applied and looked at. ------------------------------------------------------------------------ May 12, 2005 - 21:38 : nedjo Thanks for your comments. I think we're getting somewhere. "I am not a fan of your solution for blocks that dissapear. It breaks the ability to allow more themes on a site. if important blocks dont show up, your site will simply break. I would rather suggest that every theme MUST have a region called 'default'. any blocks that want to go into a non-existing region, will be placed there. " Good suggestion. Having a default region for blocks to show up sounds like a valuable backup. I'm thinking we might want to have a way to designate a given region as the default, rather than having to have one named 'default'. Thoughts? "We must define a standard listy of suggested region names. to avoid a wildgrowth of names. " Sure. But the patch doesn't prevent doing that--it enables it. "I am not sure if i like the way you do function phptemplate_regions(). these regions should be defined in the templqtes, not the engine. Otherwise all phptemplate themes will still all have two regions. " Oh, I wholeheartedly agree, and I've noted the issue above. But unless we substantially rewrite the engines, some region definition is needed in the engines, as they call blocks. Should we therefore define a base set in the engine, then call a hook from the engine to add any other regions from themes based on that engine? If so, where in the theme's files should such a hook be located? And a side note. Do let's make an effort to keep our comments friendly. Taking the time to note one or two things that do work or are done well as part of a review is I believe a valuable habit. It helps to confirm what is indeed accomplished. Beyond this, it helps to maintain the idea that we are collaborating on shared goals, rather than pushing individual and competing visions, and that contributions and work are appreciated, rather than being invitations to criticism. Thanks, Nedjo ------------------------------------------------------------------------ May 12, 2005 - 21:42 : chx I am implementing http://drupal.org/node/16216#comment-29282 but it takes time. regions again have names. default and sidebar regions are mandatory. This has little to do with nedjo's code much more with his idea -- I looked at the screenshot and said, OK this is great but... we'd like to have a lot more 'blocks' if this comes through, henceforth the above mentioned solution. ------------------------------------------------------------------------ May 12, 2005 - 22:39 : nedjo Okay, thanks for the clarification, I hadn't understood that you were taking a new approach rather than building on what I'd begun. Given that that's the case, staging as I'd suggested obviously won't work so I'm content to wait and see what you accomplish. I'd only suggest, don't feel like you need necessarily to do everything all at once. ------------------------------------------------------------------------ May 13, 2005 - 10:34 : Bèr Kessels Nedjo, sorry if the sound of my comment was hostile. it was never meant to be that way. I am busy, and thus did not want to comment all the things i liked about your patch, but chose to pick the much smaller amount of things I thought could use some improvement. I will try to keep in mind to be more friendly next times. Also, not all of us are as fluent in English as our native English speakers. I think its good to keep in mind that for a lot of us, communication in English is not as easy as it may seem. For me, it often requires a lot of concentration to get the subtleties right. I mean: I can type some English text, look up words in the dictionary, but to get small yet important subtleties in my texts is very hard, often. But, that all said: I liked your patch. ------------------------------------------------------------------------ June 10, 2005 - 13:08 : jakeg How far off is this from being officially released or at least usable? If its usable now, what files will I need to implement it? ------------------------------------------------------------------------ June 10, 2005 - 14:19 : Kobus Attachment: http://drupal.org/files/issues/regions---possibility-3.png (2.21 KB) To add to Stefan's suggestions with the two screenshots, I modified one of them a bit, and this is how I understand Jaza's post, and yes, I agree, this would be a wonderful feature! I can't wait! Imagine how good it would look if I had a theme that has a clear white background (not visible blocks) and then these seemingly random boxes on the page, as shown in the screenshot. Especially where I can place it anywhere around the node like Jaza said with a [region:2] block etc. I say again: I can't wait! Kobus

1 0

[drupal-devel] [feature] Profile field visiblity should vary by role
by Bèr Kessels 10 Jun '05

10 Jun '05

Issue status update for http://drupal.org/node/14149 Project: Drupal Version: cvs Component: profile.module Category: feature requests Priority: normal Assigned to: ejort Reported by: sushi76 Updated by: Bèr Kessels Status: patch Ejort, I know i wrote that. However, this is a little bit different. am not saying you should make a new system for changing the apperance of profile fields. I am only saying that having per-profile-field permissions is: * way OTT for the big mayority of users * extremely cluttering for the permission page (which, essetially is a problem in that interface, not in your "feature") Bèr Kessels Previous comments: ------------------------------------------------------------------------ December 9, 2004 - 19:38 : sushi76 Currently there are only these three Options Private field, content only available to privileged users. (Admin users) Public field, content shown on profile page but not used on member list pages. (Everyone, but not in the member list) Public field, content shown on profile page and on member list pages. (Everyone, everywhere) It should be possible to set the visibilty of profile fields by user roles. ------------------------------------------------------------------------ March 6, 2005 - 21:40 : tulula I agree! If visibility is set by roles OR if the option is left up to the user to display their info at their discretion vs Admin at level of setting up profile fields. ------------------------------------------------------------------------ June 6, 2005 - 06:03 : ejort I agree that it should be possible to set visibility per role. There is profile data on my site that I want my organisation's committee members to see, but nobody else, there's information that I want only authenticated users to see, but not anonymous users etc. More than that, I think we should be able to set field editability by role also. There is data on my site that only certain people should be able to edit. If we get to this point then this would be a superset of the functionality discussed in the PROFILE_HIDDEN updates [1] thread, but would be much more flexible. [1] http://drupal.org/node/21219 ------------------------------------------------------------------------ June 10, 2005 - 09:07 : ejort Attachment: http://drupal.org/files/issues/profile.module.role_based_field_permissions.… (12.97 KB) Hi, Here's a patch which implements role based edit / access permissions for profile fields. It allows you to give permissions to each role (and for each field) to: * access a field (for all accounts) * access a field for your own account * edit a field for your account Users with permission 'administer users' can access / edit all fields, and users must have enough permission to edit/access a profile for these extra permissions to come into effect. I believe this allows for more flexibility than the existing profile.module method of PROFILE_PRIVATE and in HEAD PROFILE_HIDDEN. You can eg: * hide some fields from anonymous users, while allowing other roles to still view that info * have fields viewable by only the admin and user who owns the account (like PROFILE_PRIVATE * have fields viewable by some roles, but only editable by the admin * have fields hidden from all except the admin, and editable only by the admin * it will make you more attractive to the opposite sex etc. I'm developing this because I need it for one of my sites, hence, unfortunately this patch is against the 4.6 profile.module. If people think this is a valuable feature for HEAD I can roll a patch against that. Cheers, Eric ------------------------------------------------------------------------ June 10, 2005 - 10:13 : Bèr Kessels I am not too sure about this. A typical profile contains between five and 10 fields, but twenty fields is not unheard of. This patch will flood the permissions screen unnneccesary. I would opt for the hard way: An advanced profile module, or CRM module, or so. hat module could implemen,t all sorts of advanced levelled permissions. In order to maintain a high level of usability in core, we should try to minimize options and checkboxes. I know from flexinode, which adds similar dynamic permissions, that the interface for permissions is really not up to this big amount of permissions. I really think such things should not be in core. Buty that all said, it /is/ a handy feature :) ------------------------------------------------------------------------ June 10, 2005 - 10:53 : ejort Yes, unfortunately it can add a large number of permissions to the permissions page. I did consider trying to place the permission selections on each fields edit page instead (similar to the visibility settings), but as a certain eminent author recently wrote* [2]: "please use *only* the permissions page to set permissions, and do not create new permissions-alike settings in any configuration pages " :-) I think that the PROFILE_PRIVATE and PROFILE_HIDDEN (and the PROFILE_PUBLIC_*) settings are currently doing just that, implementing an alternate permissions system which addresses a few use cases, but is ultimately not particularly flexible. Is there any chance that the permissions sections can benefit from some collapsible goodness to alleviate the flooding? I think it's a shame to reduce the systems flexibility because it may create 'too many' permissions settings, especially as it is generally a set once and forget proposition. Perhaps we should look at the underlying UI problem? *That would be Bér :-) [2] http://drupal.org/node/22565#comment-32248

1 0