- Development - lists.drupal.org

Re: [drupal-devel] creating drupal-doc teams
by Kobus Myburgh 20 May '05

20 May '05

Charlie, I am subscribed to the drupal-docs list. Subscribed this morning. Be sure to let me know if there are things that I can do. I will monitor the list anyways and let you know when there is something I can do. Regards, Kobus >>> cel4145(a)cyberdash.com 5/20/2005 5:09 PM >>> Kobus wrote, "If there is a place where I can be involved, please let me know. I am not very big on the coding, so this is a good area for me to get involved in." Definitely, join the drupal-docs list if you aren't subscribes already. And I've got you written down for the project areas that you mentioned. Charlie

1 0

Re: [drupal-devel] creating drupal-doc teams
by Charlie Lowe 20 May '05

20 May '05

Thanks Steven, Gerhard, and Djun :) And you are right Steven. One thing I was thinking about is that it's much easier for two people to sort of keep things moving along because they can take turns. That, and my experience has been that when there are two people responsible for figuring out solutions to problems, those solutions tend to be more robust because of the different perspectives that each brings. I'll wait a day or two, and then post a list to the mailing lists of who volunteered for which project teams. Charlie

1 1

[drupal-devel] [bug] Remove PHP warnings.
by killes 20 May '05

20 May '05

Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org Status: patch Attachment: http://drupal.org/files/issues/tablesort-notices.patch (3.42 KB) Drupal emits an annoying number of PHP notices. The attached patch fixes a few of them in tablesort.inc. killes(a)www.drop.org -- View: http://drupal.org/node/16303 Edit: http://drupal.org/project/comments/add/16303

3 8

[drupal-devel] [bug] Nodes are repeated when asking for a list of taxonomy/term/x+y nodes
by matteo 20 May '05

20 May '05

Issue status update for http://drupal.org/node/22469 Project: Drupal Version: 4.6.0 Component: taxonomy.module Category: bug reports Priority: normal -Assigned to: Anonymous +Assigned to: matteo Reported by: matteo Updated by: matteo -Status: active +Status: patch Attachment: http://drupal.org/files/issues/taxonomy_distinct.patch (1.06 KB) Here is the patch for Drupal 4.6 to solve this problem. Matteo matteo Previous comments: ------------------------------------------------------------------------ May 9, 2005 - 22:39 : matteo When asking for a list of nodes linked to more than one term by using the syntax 'taxonomy/term/x+y', the same nodes are shown twice instead of only one time, when nodes are linked to both x and y term. Hoping I've been able to explain what happens..... Matteo PS: Maybe is it so by design.... ?? ------------------------------------------------------------------------ May 9, 2005 - 22:45 : matteo It looks like a distinct(n.nid) clause should be added to lines 839-840, which should sound like this: $sql = 'SELECT distinct(n.nid), n.sticky, n.title, n.created FROM {node} n INNER JOIN {term_node} tn ON n.nid = tn.nid WHERE tn.tid IN ('. $str_tids .') AND n.status = 1 ORDER BY n.sticky DESC, n.created DESC'; $sql_count = 'SELECT COUNT(distinct(n.nid)) FROM {node} n INNER JOIN {term_node} tn ON n.nid = tn.nid WHERE tn.tid IN ('. $str_tids .') AND n.status = 1'; this prints out the correct number of nodes. Matteo ------------------------------------------------------------------------ May 10, 2005 - 16:01 : JonBob I think your analysis is right. The DISTINCT() was probably removed because someone thought it was there for node permissions (the new db_rewrite() mechanism handles this now), but it is also necessary in the case of an OR query. ------------------------------------------------------------------------ May 20, 2005 - 09:10 : Cvbge Hello, I've used proposed change and it works as expected. ------------------------------------------------------------------------ May 20, 2005 - 09:22 : matteo Just to undesrtand what to do, should I create the patch, or is it assigned to someone else ?? Matteo

1 0

Re: [drupal-devel] Contact people for translations
by Kobus Myburgh 20 May '05

20 May '05

Hi, I am also willing to be coordinator for translations, if you wish (and the Drupal team approves), Gerhard. Regards, Kobus >>> killesreiter(a)physik.uni-freiburg.de 5/20/2005 12:14 PM >>> On Thu, 19 May 2005, Kieran Lal wrote: > Hi, we have been talking about how changes to admin help might effect > translation efforts. I think we have some proposals on the docs > list. Who should I speak with from the translation efforts to see if > what we are proposing is reasonable? That is a valid question. Although I recently proclaimed myself translations coordinator (mainly because I tell people how to get their translations into cvs and do some initial commits for them) I have very little contact to most of the translators. I think the best thing would be to post in the translations forum. If feedback turns out to be too low, we can draft a list of translators from the cvs commits and contact them directly. Cheers, Gerhard

1 0

[drupal-devel] Contact people for translations
by Kieran Lal 20 May '05

20 May '05

Hi, we have been talking about how changes to admin help might effect translation efforts. I think we have some proposals on the docs list. Who should I speak with from the translation efforts to see if what we are proposing is reasonable? Thanks, Kieran

2 1

[drupal-devel] [bug] Remove BlueMarine's logo border attribute
by Robin Monks 20 May '05

20 May '05

Issue status update for http://drupal.org/node/23270 Project: Drupal Version: cvs Component: theme system Category: bug reports Priority: minor Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks Status: patch This patch removes the border="0" attribute from BlueMarine's logo img tag. This is a validation error and should be included as the web moves towards standards. The border attribute is included in the theme's CSS. I tested this patch and verified it to work. Robin Robin Monks

1 0

[drupal-devel] [bug] Remove BlueMarine's logo border attribute
by Robin Monks 20 May '05

20 May '05

Issue status update for http://drupal.org/node/23269 Project: Drupal Version: cvs Component: theme system Category: bug reports Priority: minor Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks Status: patch Attachment: http://drupal.org/files/issues/remove image border.patch (729 bytes) This patch removes the border="0" attribute from BlueMarine's logo img tag. This is a validation error and should be included as the web moves towards standards. The border attribute is included in the theme's CSS. I tested this patch and verified it to work. Robin Robin Monks

1 0

[drupal-devel] [feature] Enable customizing of "Title" field on node forms
by Thox 20 May '05

20 May '05

Issue status update for http://drupal.org/node/10056 Project: Drupal Version: cvs Component: node system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Anonymous Updated by: Thox Status: patch I'd benefit greatly from having a feature like this. The example already given is one of the cases I need it: I'd like the title field to be a concatenation of two fields: "First name" and "Last name". Thox Previous comments: ------------------------------------------------------------------------ August 14, 2004 - 18:17 : Anonymous Attachment: http://drupal.org/files/issues/node.set-title-field.patch (2.02 KB) The default "title" field in a node object is useful but not always appropriate. For some node types it would be preferable to rename the field for display to users (e.g., from "title" to "name" for a record of an organization or business), while in others the title might be best drawn from a combination of other fields (e.g., first_name and last_name fields, for a record of an individual). This patch enables two new alternatives for node titles: renamingThe title field can be renamed, e.g., from "title" to "name". substutingOther fields can be substituted for the title field. The functionality is implemented through a new proposed node hook, _title_field($op). There are two possible values for $op: "action" (either "rename" or "substitute") and "names" (a list of field names to be used in the title field). Sample uses: [?PHP function example_title_field($node, $op) { switch ($op) { case 'action': $return = 'rename'; break; case 'names': $return = array('Name'); } return $return; } ?] In this case, since the requested action is "rename", the title field would be labelled "Name" (instead of "Title") in node add and edit forms for nodes of type "example". [?PHP function example_title_field($node, $op) { switch ($op) { case 'action': $return = 'substitute'; break; case 'names': $return = array('first_name', 'last_name'); } return $return; } ?] In this case, no "Title" field would be displayed in node add or node edit forms of node type "example". Instead, the fields "first_name" and "last_name" would be concatenated to form a title. Implementing this patch would significantly increase the flexibility of the node system, making it feasible to store information of many types not currently supported because they don't have a "title" attribute. ------------------------------------------------------------------------ August 15, 2004 - 16:39 : Dries This is best accomplished through the existing nodeapi hook, using a separate module. ------------------------------------------------------------------------ August 15, 2004 - 23:02 : nedjo Thanks for the suggestion. I did look for a way to accomplish this through _nodeapi (and other existing hooks), but couldn't see how. The "title" field is hard-coded into node.module. The _nodeapi hook allows various types of manipulations, but not, so far as I could see, changes to elements that have been generated by, e.g., form_textfield() calls. Are there possibilities I'm missing? Other approaches? Any specific suggestions as to means we could use to change the hard-coded "title" field? ------------------------------------------------------------------------ August 19, 2004 - 18:27 : nedjo Attachment: http://drupal.org/files/issues/node.set-title-field_0.patch (741 bytes) Drawing on Dries's suggestion, I've substantially revised this patch to enable node title field customization with only three additional lines of code in node.module. In place of the existing line in function node_form() <?php $output .= form_textfield(t('Title'), 'title', $edit->title, 60, 128, NULL, NULL, TRUE); ?> the patch substitutes a the following: <?php $title = variable_get('node_titlefield_'. $edit->type, 'Title'); if(!($title == 'none')) { $output .= form_textfield(t($title), 'title', $edit->title, 60, 128, NULL, NULL, TRUE); } ?> With this change in place, node modules will be able to override the standard node title label by setting a variable, node_titlefield_nodetype, where nodetype is the type of node. This could be done, e.g., in a _settings hook, so that the first time settings were accessed the module would set the variable: <?php if (variable_get('node_titlefield_example', '') == '') { // since none is already set, set this variable variable_set('node_titlefield_example', 'Name'); drupal_set_message('Example module initialization completed.'); } ?> The special value 'none' would suppress the title field altogether in node forms, used as follows: <?php if (variable_get('node_titlefield_example', '') == '') { // since none is already set, set this variable variable_set('node_titlefield_example', 'none'); drupal_set_message('Example module initialization completed.'); } ?> In this case, a _validate hook would be used to set the title field value. Assuming a module where a first name-last name combination was to be used for a title: <?php function example_validate(&$node) { if(!(isset($node->title))) { $node->title = $node->first_name . ' ' . node->last_name; } } ?> In short, this three-line addition to the node.module would significantly increase the flexibility of the node system by removing the hard-coded 'Title' field in node add and edit forms and instead enabling custom labelling or concatenation of the field from other sources. ------------------------------------------------------------------------ August 19, 2004 - 18:50 : moshe weitzman I like this functionality. But the implementation still seems unclean. I would prefer to simply remove the 'title' form field from node_form() and require that modules present this field in whatever way they please. in some cases, they will use a hidden form field because no customer interaction is required. This causes a break with backward compatibility, but cleanliness is facored over compatibilityness (when you must choose). I'm moving this back to 'Active', since I don't think this patch is committable as is. ------------------------------------------------------------------------ August 27, 2004 - 23:46 : nedjo Attachment: http://drupal.org/files/issues/node.set-title-field_1.patch (830 bytes) Thanks for looking at this. The suggestion - dropping the title field altogether and leaving this for module authors - has the advantage of simplicity. However, this change would imply significant new work as it would would require all or nearly all existing modules - core and contributed - be modified. While I think enabling title field customization is important for Drupal as a whole, and while this is a change I need for two modules I'm working on, I'm not immediately convinced that the benefits of this change justify this cost. Also, in most cases, the present title field works fine, so keeping it as a default option would I feel be desirable. Hence the following patch. In place of my (poorly conceived) initial hook proposals, above, this patch introduces a single very straightforward new node hook, _title_field. By setting this hook to return FALSE, node modules authors will suppress the default title field, and be free therefore to substitute what they wish or need. Returning TRUE, or not using the hook, will result in the default title field being used. Sample usage: <?php function example_title_field() { return FALSE; } ?> This is, I feel, a much better solution than the previous two I suggested--proof, if it's true, that the Drupal issue system works! ------------------------------------------------------------------------ September 6, 2004 - 15:50 : nedjo Are there any objections to or issues raised by this small patch (introducing a new hook to make the title field optional in node forms)? If not, can it be applied? ------------------------------------------------------------------------ September 7, 2004 - 13:46 : Anonymous I think I agree with Moshe's opinion that this should be accomplished by having node modules display the title field. In any event, this is a new feature and shouldn't go in during the feature freeze for 4.5. ------------------------------------------------------------------------ September 7, 2004 - 13:58 : ccourtne +1 for just moving the title field to be a responsibility of the implementing module instead of node_form. There is already to some extent "hook overload", in addition there may be several modules which don't want to even display a title module. Why add that only fixes some of the problems just to have to remove it later when you make a fix that address the whole problem. ------------------------------------------------------------------------ September 7, 2004 - 21:09 : nedjo Attachment: http://drupal.org/files/issues/node.remove-title-field.patch (636 bytes) Thanks for comments. As per feedback, the attached patch removes the title field from node forms, leaving this instead to node modules. Understood that possible approval of this patch this will need to wait until code unfrozen. ------------------------------------------------------------------------ October 24, 2004 - 12:06 : moshe weitzman please patch all core node modules as well. ------------------------------------------------------------------------ November 28, 2004 - 01:00 : nedjo Attachment: http://drupal.org/files/issues/node-move-form-title-field.patch (4.29 KB) Good point Moshe. This patch of node.module plus all core node modules simply moves the title field out of node.module and into the node modules, enabling (if desired) customization of the title field by a module. Patches to contributed modules will in most cases be as simple as adding the line <?php $output = form_textfield(t('Subject'), 'title', $node->title, 60, 128, NULL, NULL, TRUE); ?> at the beginning of a typename_form() function (and, if necessary changing an existing $output = to $output .=). In the attached patch, I've customized the title field for only one of the node types, calling the title of a forum topic the "Subject". We could consider calling the title of a blog a "Subject" or "Topic" as well. I feel this is a good solution (thanks for the feedback and discussion) and, for minimal work (minor updates to contributed modules), will have the significant benefit of enabling flexibility in content types beyond those that have "title" attributes. ------------------------------------------------------------------------ November 28, 2004 - 17:45 : nedjo Ability to customize title as provided in this patch was requested here [1]: "When adding/editing, the 'title' field is manditory, which is fine. Except that its label is hardcoded to 'title'. A custom node modelling, say, a 'Company' would much rather this field be presented to the user as 'Company Name'. " [1] http://drupal.org/node/13596 ------------------------------------------------------------------------ March 4, 2005 - 03:44 : nedjo Here's another patch that's sat for months without being either applied or turned down, although there was expressed support and, after several iterations, it addressed all issues that had been raised. The point is to remove the hard-coded "Title" field - inapprioriate for many node types, e.g., companies - from node forms, instead allowing node modules to treat this as appropriate (e.g., a "Subject", "Name" or "Topic", or nothing at all). Are there problems with this approach that were not raised? Is there a reason this wasn't accepted? ------------------------------------------------------------------------ March 4, 2005 - 03:54 : Steven nedjo: if you read the backlog you can see that this feature was delayed for after the 4.6 release. "I've customized the title field for only one of the node types, calling the title of a forum topic the "Subject". " This is really inconsistent, as what you call the title of a blog, story or forum node is purely subjective. "Subject" "Topic" and "Title" are pretty much interchageable and any subtle differences will surely be eroded by translation. The only thing I can agree on so far is naming a polls' title "Question". ------------------------------------------------------------------------ March 4, 2005 - 05:15 : nedjo Thanks for the note. I'm not sure what you mean by the "backlog". Where would I find this? I agree that a "Question" field would make sense for polls. ------------------------------------------------------------------------ March 4, 2005 - 14:12 : JonBob Actually UnConeD, it was postponed until after the 4.5 release, not 4.6, and looks like everyone forgot about it when the release happened. And no, Nedjo, I don't take this as proof that Drupal needs more bureaucracy. :-) Marking this active again; I'm sure the patch will have to be updated once the code branches. We had rolled this function into the needs for CCK, but in our discussions split it off again. ------------------------------------------------------------------------ April 3, 2005 - 05:28 : chx Attachment: http://drupal.org/files/issues/node-move-form-title-field_0.patch (4.59 KB) The patch applies to ucrrent HEAD with some offset. I have rerolled it so it applies cleanly. ------------------------------------------------------------------------ May 20, 2005 - 10:09 : chx Patch still applies (yes, with some offset, but applies). ANd yes, we need this very badly.

1 0

[drupal-devel] Yahoo Usability Pattern Drupal site developer needs help
by Kieran Lal 20 May '05

20 May '05

Hi, I made contact with the main developer for the Yahoo usability pattern Drupal site. He is really busy and he wants to hire a good Drupal PHP developer, so if you are in the Bay Area send me note and I'll pass on his email to you. His modules are currently tightly coupled with their workflow and content so he's not sure they would be useful to others. But I am sure if we got the right person in there, they could extract the modules to be more generic. They also run a yahoo version of php called yphp and so he's not sure that his modules will work on regular php. If people are interested in this, respond and maybe we can help get a more generic pattern library module out of it. Cheers, Kieran

3 2