- Development - lists.drupal.org

[drupal-devel] [feature] Small fix for conf.php.
by tangent 24 Feb '05

24 Feb '05

Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Chris Johnson Reported by: Uwe Hermann Updated by: tangent Status: patch Makes sense to me. +1 tangent Previous comments: ------------------------------------------------------------------------ October 16, 2004 - 08:11 : Uwe Hermann As seen here [1] it's not so obvious what to fill into the $dburl line in include/conf.php. My suggestion to clarify this a bit: Replace # $db_url = "mysql://user:password@hostname/database"; with # $db_url = "mysql://dbuser:dbpassword@dbhostname/database"; This should make it a little clearer that the database user, password and host is meant. The same should be done with the PostgreSQL line... [1] http://drupal.org/node/11325#comment-17968 ------------------------------------------------------------------------ February 24, 2005 - 10:31 : Chris Johnson Attachment: http://drupal.org/files/issues/conf.php.patch (579 bytes) Here's a simple patch against 4.5.2. ------------------------------------------------------------------------ February 24, 2005 - 10:35 : Chris Johnson Attachment: http://drupal.org/files/issues/settings.php.patch (551 bytes) And here is the equivalent patch for HEAD, against settings.php. -- View: http://drupal.org/node/11645 Edit: http://drupal.org/project/comments/add/11645

1 0

[drupal-devel] [feature] Better validation of new users email address when creating account
by budda 24 Feb '05

24 Feb '05

Project: Drupal Version: 4.5.2 Component: user.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: budda Updated by: budda Status: patch Working with the user.module of 4.5.2 distribution I amended the user_validate_mail() function to provide additional checking for a new user. This was inspired by the constant bounced emails I was getting each day from new users mistyping their email address. Sorry that the code is not in patch form. The following code should be placed in user.module :- function _user_check_dnsrr($maildomain, $rectype = 'MX') { if(!empty($maildomain)) { if(function_exists('checkdnsrr')) { return checkdnsrr($maildomain, $rectype); } else { exec("nslookup -type=$rectype $maildomain", $result); foreach ($result as $line) { if(eregi("^$maildomain",$line)) { return true; } } return false; } } return false; } function user_validate_mail($mail) { if (!$mail) return t('You must enter an e-mail address.'); list($username, $maildomain) = split("@", $mail); if (!valid_email_address($mail) || !_user_check_dnsrr($maildomain, "MX")) { return t('The e-mail address %mail is not valid.', array('%mail' => "<em>$mail</em>")); } } I have been using the above on http://www.bargainspy.co.uk/user/register without problem for a day now. Another step in the direction of helping users hide their general stupidity! budda -- View: http://drupal.org/node/17780 Edit: http://drupal.org/project/comments/add/17780

3 4

[drupal-devel] [task] Clean up block module tables
by TDobes 24 Feb '05

24 Feb '05

Project: Drupal Version: cvs Component: block.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: TDobes Status: patch It should be noted that the patch here contains a fix for a CRITICAL bug in block.module: At the moment, custom blocks cannot be deleted. A patch containing the fix alone (without other improvements) is located in another issue, which was marked as a duplicate [1] quite a while ago. Since we're now in a feature freeze, perhaps I should reopen the other issue so the deletion fix alone can be committed? [1] http://drupal.org/node/14625 TDobes Previous comments: ------------------------------------------------------------------------ December 9, 2004 - 15:07 : drumm Attachment: http://drupal.org/files/issues/block.module_2.diff (9.54 KB) * renamed 'boxes' to 'blocks_custom' * changed the 'bid' column of that table to 'delta' and removed auto increment in favor of the usual db_next_id * made associated changes in code to avoid 'box' and 'bid' * removed unique constriant on custom box titles (http://drupal.org/node/11724) * put the delete link for custom blocks back in, it was apparently lost in another update ------------------------------------------------------------------------ December 9, 2004 - 15:26 : jhriggs I think the only thing I would question is the renaming of bid. It seems inconsistent with the rest of drupal. We use nid, rid, uid, etc., etc. So, this should be a block ID, bid. ------------------------------------------------------------------------ December 9, 2004 - 16:05 : drumm Delta is the best name since this is what hook_block() calls it. Adding a bid (b as in block) to the blocks table is a good idea, but I wouldn't want to confuse things with a patch that is renaming bid in one context and adding bid in a related but different context. ------------------------------------------------------------------------ December 9, 2004 - 16:22 : Dries I prefer bid. I'd rather change delta to bid, instead of changing bid to delta. It is more consistent. Otherwise the patch looks good. ------------------------------------------------------------------------ December 9, 2004 - 16:43 : drumm Delta really isn't a good id. It isn't unique. The closest thing to a primary key is the blocks table is (module, delta). I think bid should be added as a real primary key on the blocks table. If there is a good word to use in place of delta that isn't bid, then that would be good to use. ------------------------------------------------------------------------ December 10, 2004 - 18:22 : drumm Updated patch which adds: * Added index to weight column in blocks table * Added primary key bid to blocks table * Replaced module/delta construct with bid where possible In additon to the previous: * renamed 'boxes' to 'blocks_custom' * changed the 'bid' column of that table to 'delta' and removed auto increment in favor of the usual db_next_id * made associated changes in code to avoid 'box' and 'bid' * removed unique constriant on custom box titles (http://drupal.org/node/11724) * put the delete link for custom blocks back in, it was apparently lost in another update ------------------------------------------------------------------------ December 10, 2004 - 18:23 : drumm Attachment: http://drupal.org/files/issues/block.module_3.diff (20.41 KB) And the patch too ------------------------------------------------------------------------ December 12, 2004 - 02:58 : Dries The upgrade path gave me problems. I got a fatal error: <?php $ret[] = update_sql('ALTER TABLE {blocks_custom} DROP INDEX title'); ?> The index did not exist on my setup. Weird. I got several hundred warnings about this line: <?php foreach ($blocks as $delta => $block) { ?> It's somewhat tricky, because you can't execute that update twice. My user and block tables are pretty unusable now. :) (Is the block->info field still being used? It looks quite redundant to me.) ------------------------------------------------------------------------ December 12, 2004 - 03:52 : Dries I ran this update on a copy of the drupal.org database and it seems to work. The reason my previous attempt failed, is because of the way error reporting was configured. My copy of the drupal.org database doesn't have an index on 'blocks_custom.title' either, but it did not result in a fatal error nor did it cause the upgrade script to halt. Warning are suppressed so they are simply not shown. In short, depending on how error reporting is configured, the upgrade path might or might not work. If it doesn't work, you're screwed because you won't be able to run the upgrade script again. At least, not without intimate knowledge of Drupal's internals. -- View: http://drupal.org/node/14158 Edit: http://drupal.org/project/comments/add/14158

6 12

[drupal-devel] [feature] Option to disable printer friendly version for book module
by javanaut 24 Feb '05

24 Feb '05

Project: Drupal Version: cvs Component: book.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: kbahey Updated by: javanaut Status: patch On the topic of an "advanced settings" tab, I implemented this for a module I'm working on here: http://drupal.org/node/17781#comment-29737 It does simplify an otherwise very messy UI (ok, it's still messy :). Additionally, I like the idea of a global flag/permission that would hide the "advanced" tab. I would think that every setting under the advanced tab would have a sensible default that, in general, wouldn't need to be modified for default module behavior. Ber, would such a feature offset your hesitation to add new configuration options? -Mark javanaut Previous comments: ------------------------------------------------------------------------ November 20, 2004 - 00:30 : kbahey Attachment: http://drupal.org/files/issues/book_17.patch (2.18 KB) I wanted an option for the book module to NOT display a 'printer-friendly version' link for every node. So, I implemented an option for the book module to allow this to be turned off. Using this option: - Go to the /admin/node/book - Uncheck the box that say 'show printer friendly links for books' if you want - Click 'Save settings' There will be no printer friendly links after you do this. Please consider applying this patch to CVS. ------------------------------------------------------------------------ November 21, 2004 - 11:01 : kbahey Setting status to patch, so that it is discussed on the mailing list. ------------------------------------------------------------------------ November 25, 2004 - 17:36 : kbahey Attachment: http://drupal.org/files/issues/book_18.patch (2.3 KB) I have remade this patch to match what is in the current CVS version. The previous patch had conflicts with the latest CVS version. Will this be included in the base any time soon? ------------------------------------------------------------------------ November 25, 2004 - 18:07 : Bèr Kessels options, options, options. Alltough an option is an easy method to add fetaures, while not breaking backwards compatibility, it is generally very bad for useability. I am therefore a -1 for this patch. kbahey, Eventhough the functionality is very nice, I would rather see you either make thisa single site wide setting (in books settings). Or -even better IMO- make the link dis(appear) through a theme function. Or -and thats the best option IMO- help the folks who are working on a better $links (the links under each node) and introduce a general API and theme system to show, hide and markup those links on nodes. ------------------------------------------------------------------------ November 26, 2004 - 15:55 : Anonymous "I would rather see you either make thisa single site wide setting (in books settings). " That is what it already does. The setting is global in books settings, and not in every individual book. It just so happens, for a reason unknown to me, that book's setting page is under administer -> content -> books, and not under administer -> settings -> book like other modules. "Or -even better IMO- make the link dis(appear) through a theme function. Or -and thats the best option IMO- help the folks who are working on a better $links (the links under each node) and introduce a general API and theme system to show, hide and markup those links on nodes. " Those sound like a better option for sure. If the option is in admin -> themes -> configure, under the "Toggle display" part. I am not familiar with that code at this point. Will do some digging to see what can be done. ------------------------------------------------------------------------ February 17, 2005 - 08:58 : kbahey One of the objections to this patch is that it introduces one more option. If I resubmit this patch without an option, does it have a change to be accepted? I will rely on the new $conf variable being able to override variable_get(), so there is no option screen needed. How about that? ------------------------------------------------------------------------ February 17, 2005 - 09:23 : stefan nagtegaal Imo this is a theme feature, so it should be handled in there.. A link management system should be the best to handle such things, but is - unfortunatly - quite hard to inplement... ------------------------------------------------------------------------ February 17, 2005 - 14:41 : kbahey Ideally it would be a theme function. However, most themes, specially the ones that ship with the standard Drupal distribution, do not provide a way to turn that off at will. Most ideal solution is the link management interface you mention, where site admins can turn on off any link they like for any module. But that does not exist so far, so until either one of the above solutions exist, I will be submitting a patch that allows turning off the printer friendly link. ------------------------------------------------------------------------ February 17, 2005 - 14:52 : Bèr Kessels With a theme function, is not meant a function that will make an option on your screen. "Ideally it would be a theme function. However, most themes, specially the ones that ship with the standard Drupal distribution, do not provide a way to turn that off at will." With a theme function, stefan most probablt meant a function theme_printer_friendly(). That function would return the link. If you want to turn it off, you woudl have to make a function yourtheme_printer_friendly() that does /not/ return that link. Problemd solved, without adding more clutter to the UI. ------------------------------------------------------------------------ February 17, 2005 - 20:48 : kbahey Attachment: http://drupal.org/files/issues/book-2.patch (1017 bytes) There are no UI changes in this patch. If someone wants to turn off the printer friendly link, then all they do is : - Go to settings.php - Uncomment the lines that have the $conf variable and the closing bracket - Add a line like this: 'book_hide_printer_friendly' => 1, That is it. No menus, no options, nothing ... Preferrably, we should document these 'hidden' options in the future, under an 'Advanced Configuration' section. ------------------------------------------------------------------------ February 17, 2005 - 23:42 : nedjo kbahey's point reflects a general problem in Drupal--much of the content returned is hard-coded, generated in modules, and therefore without any way of being overridden. As a site administrator, my feeling is that I should have full control over what I present to my users and therefore /nothing/ should be forced on me. My observation is that, many times when suggestions are made to try to free Drupal's core from hard-coded content, there is resistance on the basis that this would require more configuration. Fair enough--but sticking us with content we don't want isn't much of an option either. The three options suggested in this issue - theming, ui configuration options, and settings.php configuration options - all have some merit, and are all currently in use; but it looks like we need a larger discussion, and perhaps some fresh approaches. I'm thinking the proposed solution of passing the content filtering to theming is tempting, but ultimately problematic. Basically, the theme approach would say: generate content pass to theme function optionally (and manually), insert theme override function that doesn't display the content that's been generated In a practical sense, this approach is cumbersome because it requires, for every optional content element, (a) edits to the core module to pass content through a theme_ function, and (b) manual theme editing to write an override function. (This second piece, of course, necessitates extra work every time a theme is updated, even if we use otherwise unmodified themes). The workflow of first generating content and then overriding it is more than inefficient--it suggests a confusion in the separation of content and presentation. Ideally, I still believe, a theme should answers the question /how/ do you want to present content--not /what/ do you want to present. Of course, in Drupal, we break this ideal routinely. But to push even more decision-making logic into the themes feels like a step in the wrong direction. Ultimately, if we don't want content displayed, probably we shouldn't generate it in the first place. My own preference is configuration options over hard-coded content (thought the lastest suggestion of hiding this option in settings.php seems a bit confusing--most admins will never know about this option). But maybe we need a completely different approach. It strikes me that the menu system provides a possible model. It offers a way to assign generated content to various categories, e.g., MENU_SUGGESTED_ITEM. Could we extend this approach to other types of content--allowing administrative override, as we do with the menu module? ------------------------------------------------------------------------ February 18, 2005 - 05:28 : Anonymous I plan to address this issue shortly on the Interface and useability meetings on dropalCOM. My vision on this is: If a setting requires frequent change, or if a setting is that of an oblect, such as a taxonomy term, or if a setting is user, role or permission sepcific, or if we cannot find a "good default" because an option differs per case [1] ** we will allow UI elelements ** we should not have UI config options, but settings in conf.php or htacess If a setting is technical, server aimed site specific and a good default can be found (e.g. settings for time to remain logged in) ** we should not have UI config options, but theme functions, for setting that are: clearly layout settings or, provide output (e.g should horizontal tabs be UL or not) or, very site specific [1] and on all outputted HTML,( off course.) [1] this is a debatable part, and thus needs some clarification. With cases i mean a targetted group. An example of a case is "community site" or "personal blog". Specific suites, will fit within these cases, but is more specific. This print_link thing is obviously very specific. There is not one case that would not want a print link. on contrary: the user-details with each post are only interesting for cases of community sites. "corporate sites" are not interested. So that post-info should be ui configurable, since 50% of the sites wants it, and 50% does not. A print link will suit 98% of the people, while hiding is only interesting for 2%. Thus it it specific. Bèr ------------------------------------------------------------------------ February 18, 2005 - 05:29 : Bèr Kessels ^-- That was me. logged out for some reason ------------------------------------------------------------------------ February 18, 2005 - 09:57 : kbahey Nedjo, You feel my pain. Here is another example of the need for options to turn on/off certain links. This site uses image gallery to display products. http://originaltilly.com/node/view/144&n=all As you notice, there are no links at the bottom for resolution, gallery, ...etc. When I asked the author (asitis.org) how he did it, he said he edited out the links he does not need! On other sites, he overrode it in the theme. Doing this stuff in the theme is really ugly, because a theme should not have a lot of logic in it, and I agree with nedjo it should be about presentation of content not fiddling with content. The other problem that I pointed out is that no 'standard' theme does that today. My resorting to $conf was basically to get over the "no new options" objection. The option would be there and are hidden from view. We can have a note in a ADVANCED.txt file describing what options can be set there are how to set them, then we have satisfied both camps, the average user will not get confused, the advanced user can do what they want. Another approach is to have those infrequent options grouped under an advanced tab or something, where theywould not confuse the average user. Guys: Please! Let us be more pragmatic about this options thing. We may be introducing options that have the potential for confusion, but the price we pay is more than that: - Creating fragmented and ugly hacks in some themes - Forcing the introduction of unneeded complexity in some themes - Not having a general solution out of the box - Depriving functionality for others who cannot modify themes. ------------------------------------------------------------------------ February 18, 2005 - 10:02 : moshe weitzman Personally, I like the 'Advanced' tab. There should be a permission which is universal across all modules which says 'access advanced configuration options'. If user has that permission, he can see these tabs. -moshe -- View: http://drupal.org/node/13211 Edit: http://drupal.org/project/comments/add/13211

1 0

[drupal-devel] [feature] Small fix for conf.php.
by Chris Johnson 24 Feb '05

24 Feb '05

Project: Drupal -Version: 4.5.2 +Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Chris Johnson Reported by: Uwe Hermann Updated by: Chris Johnson Status: patch Attachment: http://drupal.org/files/issues/settings.php.patch (551 bytes) And here is the equivalent patch for HEAD, against settings.php. Chris Johnson Previous comments: ------------------------------------------------------------------------ October 16, 2004 - 07:11 : Uwe Hermann As seen here [1] it's not so obvious what to fill into the $dburl line in include/conf.php. My suggestion to clarify this a bit: Replace # $db_url = "mysql://user:password@hostname/database"; with # $db_url = "mysql://dbuser:dbpassword@dbhostname/database"; This should make it a little clearer that the database user, password and host is meant. The same should be done with the PostgreSQL line... [1] http://drupal.org/node/11325#comment-17968 ------------------------------------------------------------------------ February 24, 2005 - 09:31 : Chris Johnson Attachment: http://drupal.org/files/issues/conf.php.patch (579 bytes) Here's a simple patch against 4.5.2. -- View: http://drupal.org/node/11645 Edit: http://drupal.org/project/comments/add/11645

1 0

[drupal-devel] [feature] Small fix for conf.php.
by Chris Johnson 24 Feb '05

24 Feb '05

Project: Drupal -Version: 4.5.0-rc +Version: 4.5.2 Component: base system Category: feature requests Priority: normal -Assigned to: Anonymous +Assigned to: Chris Johnson Reported by: Uwe Hermann Updated by: Chris Johnson -Status: active +Status: patch Attachment: http://drupal.org/files/issues/conf.php.patch (579 bytes) Here's a simple patch against 4.5.2. Chris Johnson Previous comments: ------------------------------------------------------------------------ October 16, 2004 - 07:11 : Uwe Hermann As seen here [1] it's not so obvious what to fill into the $dburl line in include/conf.php. My suggestion to clarify this a bit: Replace # $db_url = "mysql://user:password@hostname/database"; with # $db_url = "mysql://dbuser:dbpassword@dbhostname/database"; This should make it a little clearer that the database user, password and host is meant. The same should be done with the PostgreSQL line... [1] http://drupal.org/node/11325#comment-17968 -- View: http://drupal.org/node/11645 Edit: http://drupal.org/project/comments/add/11645

1 0

[drupal-devel] [task] Fill empty comment subject during preview
by drumm 24 Feb '05

24 Feb '05

Project: Drupal Version: cvs Component: comment.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch This usability fix fills the comment subject as it would before posting during the preview so the user can see it before it happens. drumm -- View: http://drupal.org/node/17877 Edit: http://drupal.org/project/comments/add/17877

2 2

[drupal-devel] [task] Add a preview class to node previews
by drumm 24 Feb '05

24 Feb '05

Project: Drupal Version: cvs Component: node system Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/node.module_1.diff (2.34 KB) Chris (factoryjoe) wanted to be able to theme node previews differently from the other node views. I decided to add a div around the whole preview area which includes one or two node views, trimmed and not trimmed. And I went ahead and put the whole thing in a themeable function since the is a lot of HTML there. drumm -- View: http://drupal.org/node/17870 Edit: http://drupal.org/project/comments/add/17870

2 1

[drupal-devel] [task] Remove hardcoded align="center"
by drumm 24 Feb '05

24 Feb '05

Project: Drupal Version: cvs Component: block.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/block.module_5.diff (2.22 KB) We don't really need to have those alignments hard coded. drumm -- View: http://drupal.org/node/17868 Edit: http://drupal.org/project/comments/add/17868

2 1

[drupal-devel] really interesting post on distributed authentication
by Adrian Rossouw 24 Feb '05

24 Feb '05

http://alec.bohemiandrive.com/perm/2005/02/18/distributed-authentication He suggests a system which I think might be better than the current drupalID system (even if we just change the authentication process) -- Adrian Rossouw Drupal developer and Bryght Guy http://drupal.org | http://bryght.com

1 0