- Development - lists.drupal.org

[drupal-devel] [bug] Menu cache is not locale aware
by Bèr Kessels 31 Jan '05

31 Jan '05

Project: Drupal Version: 4.5.0 Component: menu system Category: bug reports Priority: normal Assigned to: chx Reported by: chx Updated by: Bèr Kessels Status: patch I found out what is wrong with this: Swithcing and cache are two completely differetn things: The language is a per-session setting. The cache is a per-role setting. So any user can switch langauge on any moment, resulting in a cahce that will get flushed on nearly every page-load. And since roles and sessions are tow different thingsm we should not flush a role based cache because a variable in the session changes. The only correct option would be to have per-locale cache. (as per Jose's patch) Bèr Kessels Previous comments: ------------------------------------------------------------------------ November 26, 2004 - 08:13 : chx Attachment: http://drupal.org/files/issues/menu_locale.patch (522 bytes) If you have a multi language site, and change languages, the menu is already cached, thus it can not display the translated version. This simple patch makes the menu cache locale aware. Do I need to file the same patch against HEAD? 'Cos it applies, too. ------------------------------------------------------------------------ November 26, 2004 - 10:13 : Dries Isn't it better to flush the menu cache when someone (or the admin) switches languages? Keeps the cache size down. ------------------------------------------------------------------------ November 26, 2004 - 12:20 : chx There could be several points where the language is changed. i18n for example displays a language selection block which lets you switch anytime. Thus I think this solution is the best. ------------------------------------------------------------------------ November 26, 2004 - 13:26 : Goba See also this issue [1], which is still (again) open. The locale is also changed, when the admin changes it as the default on the admin interface, and the menu cache needs to be flushed then, and the admin needs to be redirected. I don't know how these problems are solved currently, so I would only be able to submit a placebo patch to make that issue pop up again... [1] http://drupal.org/node/11312 ------------------------------------------------------------------------ November 26, 2004 - 14:28 : Bèr Kessels I solved it by adding some logic to the swithcer function in i18n: when a language is switched the cache is flushed. The negative side of this, is that if you have hundred various roles of users reading English and one switching to German, the complete cahce is flushed. But then again, who has so many roles, that this might become an issue? ------------------------------------------------------------------------ November 27, 2004 - 10:59 : Dries I just fixed bug 11312 [2]. I don't see what's wrong with invalidating the user's menu cache when he or she switches language. Just do: <?php cache_clear_all("menu:$user->uid"); ?> [2] http://drupal.org/node/11312 ------------------------------------------------------------------------ January 30, 2005 - 20:26 : Jose A Reyero This is needed also for i18n. Invalidating cache is not a solution here, as we would need to do it also for anonymous users. So I think this is a simple solution and will work fine for both cases, user/locale and i18n. -- View: http://drupal.org/node/13503 Edit: http://drupal.org/project/comments/add/13503

1 0

[drupal-devel] [feature] Adjustable username crop
by tangent 31 Jan '05

31 Jan '05

Project: Drupal Version: 4.5.2 Component: node system Category: feature requests Priority: normal Assigned to: com2 Reported by: com2 Updated by: tangent Status: patch In some cases there may not be a need to truncate the output at all. We should consider using CSS to adjust the display of text rather than truncating strings to arbitrary lengths that may be less than can be viewed in a given resolution. Given the following markup <div class="container"> This is a string which may be displayed in a small area and may be truncated if the container is too small to contain it. </div> the following CSS may be used to control the overflow of the container. .container { display: block; overflow: hidden; white-space: nowrap; text-overflow: ellipsis; } Use of the proprietary (MS Internet Explorer) "text-overflow" property may be used to show ellipsis on a container with hidden content. Javascript could be used to display ellipsis on these containers for other browsers as well, though it may well not be worth doing so. Using CSS to control display in this manner gives greater control for supporting variable environments (graphical browser, wap browser, text browser) without limiting the content that I user needs to see. tangent Previous comments: ------------------------------------------------------------------------ January 27, 2005 - 11:11 : com2 Attachment: http://drupal.org/files/issues/common_0.diff (546 bytes) Some people might not like it when long usernames are cropped in the node haeder. This patch can be applied to includes/common.inc version 4.5.2 and creates a new variable 'user_name_crop' to adjust the crop length. ------------------------------------------------------------------------ January 27, 2005 - 15:32 : com2 Attachment: http://drupal.org/files/issues/common_1.diff (544 bytes) I had the numbers wrong. In the original code it was cropped at 15, not at 10 like in my diff. I also changed it a bit to avoid negative argaments. Attached the new diff from version 4.5.2. if ($object->uid && $object->name) { // Shorten the name when it is too long or it will break many tables. if (strlen($object->name) > variable_get('user_name_crop', 15)+5) { $name = truncate_utf8($object->name, variable_get('user_name_crop', 15)) .'...'; } else { $name = $object->name; ------------------------------------------------------------------------ January 27, 2005 - 16:00 : Bèr Kessels IMO this should be done in a theme, not with yet another config option. what about theme_username() ? ------------------------------------------------------------------------ January 27, 2005 - 16:07 : killes(a)www.drop.org theme_username++ format_name is one of the functions I always need to modify. theme_date would be nice, too. ------------------------------------------------------------------------ January 27, 2005 - 16:27 : Dries This should be done in the theme. -- View: http://drupal.org/node/16299 Edit: http://drupal.org/project/comments/add/16299

1 0

[drupal-devel] Bug#292647: more info
by Hilko Bengen 31 Jan '05

31 Jan '05

severity 292647 important thanks Same reason as for #292887: "drupal was not included in woody, so this upgrade issue is not RC for sarge."

2 1

[drupal-devel] Bug#292887: upgrading from drupal 4.4.x does not upgrade the mysql database and makes drupal inaccesable
by Steve Langasek 31 Jan '05

31 Jan '05

severity 292887 important thanks drupal was not included in woody, so this upgrade issue is not RC for sarge. -- Steve Langasek postmodern programmer

2 1

[drupal-devel] cvs log messages
by no-reply＠zind.net 31 Jan '05

31 Jan '05

File: /modules/cvslog/cvs.module 1.42 Date: January 30, 2005 - 23:28 User: dries - More changes and incremental improvements. ---------------------------------------------------------------------- File: /modules/cvslog/cvs.module 1.41 Date: January 30, 2005 - 23:19 User: dries - More updates. ---------------------------------------------------------------------- File: /translations/README.txt 1.6 Date: January 30, 2005 - 22:03 User: mcduarte Various corrections. ---------------------------------------------------------------------- File: /modules/cvslog/cvs.module 1.40 /modules/cvslog/cvs.mysql 1.6 Date: January 30, 2005 - 21:43 User: dries - Added a CVS application form and further integrated user and CVS accounts. Work in progress. ---------------------------------------------------------------------- File: /modules/webform/webform.inc 1.5 /modules/webform/webform.module 1.32 Date: January 30, 2005 - 20:27 User: ullgren more changes to the report part from jnt ---------------------------------------------------------------------- File: /translations/fr/blog-module.po 1.6 Date: January 30, 2005 - 20:06 User: alkahan ---------------------------------------------------------------------- File: /modules/project/project.module 1.178 Date: January 30, 2005 - 18:31 User: unconed - Fixing missing project vocabulary tabs ---------------------------------------------------------------------- File: /modules/project/project.module 1.177 Date: January 30, 2005 - 18:26 User: unconed - Fixing missing project vocabulary tabs ---------------------------------------------------------------------- File: /modules/project/project.module 1.176 Date: January 30, 2005 - 18:10 User: unconed - Fixing form error reporting ---------------------------------------------------------------------- File: /includes/database.inc 1.36 Date: January 30, 2005 - 17:48 User: dries - Patch #16111 by chx: PHPdoc/documentation improvements. ---------------------------------------------------------------------- File: /modules/blogroll/blogroll.module 1.8 Date: January 30, 2005 - 17:29 User: ahynes1 Updated to take advantage of weighting in the script section ---------------------------------------------------------------------- File: /modules/project/project.inc 1.45 Date: January 30, 2005 - 17:17 User: dries - Patch #11284 by tapio: fixed broken URL. ---------------------------------------------------------------------- File: /modules/project/issue.inc 1.87 Date: January 30, 2005 - 17:17 User: dries - Fixed broken breadcrumb link on issue pages. ---------------------------------------------------------------------- File: /modules/project/release.inc 1.43 Date: January 30, 2005 - 17:14 User: dries - Patch #11122 by tangent: the heading links for each release on the new "release tab" linked to an invalid path. They linked to "releases" instead of "release". Also the anchor ID values contained the version number which was not valid XHTML. ---------------------------------------------------------------------- File: /modules/project/issue.inc 1.86 Date: January 30, 2005 - 17:11 User: dries - Patch #16025 by tangent: set the default/initial status to 'active'. ---------------------------------------------------------------------- File: /translations/de/README.txt 1.12 Date: January 30, 2005 - 13:32 User: uwe Applied patch by xeophin from http://drupal.org/node/16347. Thanks. ---------------------------------------------------------------------- File: /modules/project/mail.inc 1.42 Date: January 30, 2005 - 12:55 User: unconed - Regexp oopsie ---------------------------------------------------------------------- File: /includes/theme.inc 1.223 /misc/drupal.css 1.94 /modules/comment.module 1.331 /modules/node.module 1.454 /modules/tracker.module 1.113 Date: January 30, 2005 - 09:53 User: dries - Patch #16253 by Goba: incremental improvements to the new content markers. Goba: it would be nice if one of the core themes would showcase this functionality. ;-) ---------------------------------------------------------------------- File: /modules/book.module 1.283 Date: January 30, 2005 - 08:53 User: dries - Fixed a misplaced bracket that slipped in due to the db/node_rewrite_sql_patch. ---------------------------------------------------------------------- File: /modules/tracker.module 1.112 Date: January 30, 2005 - 08:39 User: dries - Added a missing DISTINCT() to the pager query. Spotted by Steven. ---------------------------------------------------------------------- File: /modules/postcount_rank/postcount_rank.module 1.6 Date: January 30, 2005 - 07:41 User: pyromanfo Fixed infinite loop when going over top rank ----------------------------------------------------------------------

1 0

[drupal-devel] [bug] i18n - Cached menus not changing language
by Jose A Reyero 30 Jan '05

30 Jan '05

Project: Drupal Version: cvs Component: menu system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Jose A Reyero Updated by: Jose A Reyero Status: patch Attachment: http://drupal.org/files/issues/menu_inc_cached_language_01.patch (719 bytes) Menu caching is too aggressive, resulting in menus not changing language when you change user language. This is also -but not only- a problem with i18n. Note: got this code from Ber Kessels, I just produced the patch. (thanx) Jose A Reyero -- View: http://drupal.org/node/16443 Edit: http://drupal.org/project/comments/add/16443

1 0

[drupal-devel] [feature] i18n - Using taxonomy hook to add fields to taxonomy forms
by Jose A Reyero 30 Jan '05

30 Jan '05

Project: Drupal Version: cvs Component: taxonomy.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Jose A Reyero Updated by: Jose A Reyero Status: patch Attachment: http://drupal.org/files/issues/taxonomy_module_hook_form_pre_02.patch (1.54 KB) The previous one had some unneccessary stuff, sorry Jose A Reyero Previous comments: ------------------------------------------------------------------------ January 30, 2005 - 19:33 : Jose A Reyero Attachment: http://drupal.org/files/issues/taxonomy_module_hook_form_pre_01.patch (2.04 KB) This is similar to nodeapi('form pre'...), it just uses the taxonomy hook to allow other modules to add fields at the beginning of the taxonomy's forms -terms and vocabularies. Though this one is needed for i18n, its a general feature and could be also some use for other modules. -- View: http://drupal.org/node/16440 Edit: http://drupal.org/project/comments/add/16440

1 0

[drupal-devel] uploading patches
by Dries Buytaert 30 Jan '05

30 Jan '05

1 0

[drupal-devel] [feature] Allow Authenticated users to Post Anonymously
by javanaut 30 Jan '05

30 Jan '05

Project: Drupal Version: 4.5.2 Component: comment.module Category: feature requests Priority: normal Assigned to: javanaut Reported by: javanaut Updated by: javanaut -Status: active +Status: patch javanaut Previous comments: ------------------------------------------------------------------------ January 28, 2005 - 18:49 : javanaut Attachment: http://drupal.org/files/issues/comment.post_anonymously.patch (1.64 KB) -- View: http://drupal.org/node/16366 Edit: http://drupal.org/project/comments/add/16366

1 0

[drupal-devel] cvs log messages
by no-reply＠zind.net 30 Jan '05

30 Jan '05

File: /modules/project/mail.inc 1.41 Date: January 29, 2005 - 23:47 User: unconed - Improved newline handling in mail output. ---------------------------------------------------------------------- File: /modules/project/mail.inc 1.40 Date: January 29, 2005 - 23:09 User: unconed Oopsie: '\n' -> "\n". ---------------------------------------------------------------------- File: /modules/taxonomy_access/taxonomy_access.module 1.25 Date: January 29, 2005 - 23:09 User: pyromanfo Fixed errors when doing clean install ---------------------------------------------------------------------- File: /modules/project/mail.inc 1.39 Date: January 29, 2005 - 23:02 User: unconed Adding some smarter HTML to text conversions. ---------------------------------------------------------------------- File: /modules/tracker.module 1.111 Date: January 29, 2005 - 22:21 User: dries - I had to use DISTINCT for the tracker.module's SQL queries. ---------------------------------------------------------------------- File: /CHANGELOG.txt 1.63 /includes/database.inc 1.35 /modules/aggregator.module 1.227 /modules/archive.module 1.77 /modules/blog.module 1.212 /modules/book.module 1.282 /modules/comment.module 1.330 /modules/forum.module 1.227 /modules/node.module 1.453 /modules/poll.module 1.156 /modules/queue.module 1.125 /modules/taxonomy.module 1.172 /modules/tracker.module 1.110 /modules/upload.module 1.22 /modules/user.module 1.436 Date: January 29, 2005 - 22:02 User: dries - Patch #16111 by chx: generalized node_rewrite_query to db_rewrite_query. ---------------------------------------------------------------------- File: /modules/project/mail.inc 1.38 Date: January 29, 2005 - 21:49 User: unconed Fixing bad HTML handling. ---------------------------------------------------------------------- File: /modules/actions/actions.module 1.3 Date: January 29, 2005 - 18:59 User: jvandyk array_pop() to make sure batched actions happen in the expected order ---------------------------------------------------------------------- File: /modules/actions/actions.inc 1.4 Date: January 29, 2005 - 18:57 User: jvandyk passing node by reference so our changes are not discarded when actions are batched ---------------------------------------------------------------------- File: /modules/taxonomy_access/taxonomy_access.module 1.24 Date: January 29, 2005 - 17:30 User: pyromanfo Added checkboxes next to vocabularies so that users can set permissions for all terms in a vocabulary at once ---------------------------------------------------------------------- File: /modules/feedback/feedback.module 1.28 Date: January 29, 2005 - 16:52 User: kbahey Added a breadcrumb to the home page, so as to be consistent with the rest of Drupal. In response to a comment on an issue here http://drupal.org/node/15492 ---------------------------------------------------------------------- File: /modules/taxonomy_access/taxonomy_access.module 1.23 Date: January 29, 2005 - 16:47 User: pyromanfo Removed unnecessary line from taxonomy_access_node_grants ---------------------------------------------------------------------- File: /modules/taxonomy_access/taxonomy_access.module 1.22 Date: January 29, 2005 - 16:45 User: pyromanfo Fixed errors when enabling module for first time ---------------------------------------------------------------------- File: /modules/feature/feature.module 1.20 Date: January 29, 2005 - 15:36 User: dries - Moved the feature menu. ---------------------------------------------------------------------- File: /translations/it/profile-module.po 1.6 Date: January 29, 2005 - 14:07 User: michelef Drupal 4.5.2 translation; complete. ---------------------------------------------------------------------- File: /modules/blogroll/blogroll.module 1.7 /modules/blogroll/INSTALL.txt 1.3 Date: January 29, 2005 - 10:37 User: grantbow * Added editing of personal blogrolls and weights. Enabled community blogrolling. Updated INSTALL.txt ---------------------------------------------------------------------- File: /theme-engines/phptemplate/phptemplate.engine 1.16 /themes/adc/adc.theme 1.16 /themes/goofy/goofy.theme 1.15 /themes/interlaced/interlaced.theme 1.19 /themes/marvinclassic/marvinclassic.theme 1.3 /themes/slurpee/slurpee.theme 1.18 /themes/sunflower/sunflower.theme 1.22 /themes/unconed/unconed.theme 1.12 Date: January 29, 2005 - 10:17 User: tdobes update for changes made in #13907 ---------------------------------------------------------------------- File: /modules/privatemsg/privatemsg.module 1.41 /modules/subscriptions/subscriptions.module 1.28 Date: January 29, 2005 - 10:11 User: tdobes update for changes made in #13907 ---------------------------------------------------------------------- File: /modules/subscriptions/subscriptions.module 1.22.2.4 DRUPAL-4-5 Date: January 29, 2005 - 09:38 User: tdobes Fixes for #16129 #15731 #15055 ---------------------------------------------------------------------- File: /modules/subscriptions/subscriptions.module 1.27 Date: January 29, 2005 - 09:36 User: tdobes Fixes for #16129 #15731 #15055 ---------------------------------------------------------------------- File: /modules/subscriptions/subscriptions.module 1.26 Date: January 29, 2005 - 08:57 User: tdobes minor code style changes ---------------------------------------------------------------------- File: /modules/upload.module 1.21 Date: January 29, 2005 - 08:31 User: dries - Moved the upload settings to 'admin/settings'. ---------------------------------------------------------------------- File: /modules/moblog/moblog.module 1.4 Date: January 29, 2005 - 07:58 User: javanaut Updating the node/view/$nid to more modern nod/$nid syntax. ---------------------------------------------------------------------- File: /modules/bookreview/bookreview.css 1.2 /modules/bookreview/bookreview.module 1.13 /modules/bookreview/bookreview.mysql 1.4 /modules/bookreview/bookreview.pgsql 1.2 /modules/bookreview/CHANGELOG 1.9 /modules/bookreview/INSTALL 1.3 /modules/bookreview/README.txt 1.2 Date: January 29, 2005 - 05:20 User: jeremy sync with latest version ---------------------------------------------------------------------- File: /modules/bookreview/bookreview.css 1.1.2.1 DRUPAL-4-5 /modules/bookreview/bookreview.module 1.11.2.1 DRUPAL-4-5 /modules/bookreview/bookreview.mysql 1.3.2.1 DRUPAL-4-5 /modules/bookreview/bookreview.pgsql 1.1.2.1 DRUPAL-4-5 /modules/bookreview/CHANGELOG 1.8.2.1 DRUPAL-4-5 /modules/bookreview/INSTALL 1.1.4.2 DRUPAL-4-5 /modules/bookreview/README.txt 1.1.2.1 DRUPAL-4-5 Date: January 29, 2005 - 05:13 User: jeremy - bookreview.module: o put bookreview.css into seperate configurable file (issue #15327) o filter type configurable per-node (issue #15701) o filters don't strip div and span tags (issue #15701) o added "price" (issue #15161) o convert "copyright" and "pages" from int to varchar (issue #14954) - bookreview.mysql: o added "price" column o convert "copyright" and "pages" from int to varchar - bookreview.pgsql: o add PostgreSQL support (issue #14955) ---------------------------------------------------------------------- File: /modules/bookreview/INSTALL 1.1.4.1 DRUPAL-4-5 Date: January 29, 2005 - 03:49 User: jeremy sync with head, fix INSTALL to include database name ---------------------------------------------------------------------- File: /modules/workflow/workflow.module 1.5.2.5 DRUPAL-4-5 Date: January 29, 2005 - 03:47 User: jvandyk fix removal of action instances, eliminate use of arg() ---------------------------------------------------------------------- File: /modules/workflow/workflow.module 1.10 Date: January 29, 2005 - 03:32 User: jvandyk fix removal of action instances, eliminate use of arg() ---------------------------------------------------------------------- File: /modules/bookreview/INSTALL 1.2 Date: January 29, 2005 - 03:05 User: jeremy fix bug #16367: include database name in INSTALL example ---------------------------------------------------------------------- File: /sandbox/javanaut/nodeattachment/nodeattachment.module 1.1 /sandbox/javanaut/nodeattachment/nodeattachment.mysql 1.1 Date: January 29, 2005 - 01:02 User: javanaut Initial import. Yet another attachment module, this time node-to-node and the relationships between node types can be managed and stored in a database table. Useful if you want to be able to dredge up reports using the relationships. ---------------------------------------------------------------------- File: /translations/it/filter-module.po 1.6 Date: January 29, 2005 - 00:51 User: michelef Drupal 4.5.2 translation; help to be translated ---------------------------------------------------------------------- File: /translations/it/drupal-module.po 1.5 Date: January 29, 2005 - 00:04 User: michelef Drupal 4.5.2 translation; complete. ---------------------------------------------------------------------- File: /modules/upload_indexer/upload_indexer.module 1.2 Date: January 28, 2005 - 23:29 User: weitzman refactoring to allow for mime magic or file - mime type detection. will later support file extension based mapping ----------------------------------------------------------------------

1 0