- Development - lists.drupal.org

[drupal-devel] why is node.module not required?
by Negyesi Karoly 17 Jan '05

17 Jan '05

Hi, What is the reason for node.module is not a required one? What can Drupal be used without nodes? Regards NK -- "In God we trust; All others must provide an X.509 certificate".

2 3

[drupal-devel] Drupal 4.5.2 released
by Dries Buytaert 17 Jan '05

17 Jan '05

The Drupal project has released version 4.5.2 of its open-source content management platform. Drupal 4.5.2 is a maintenance release that provides corrections of problems reported using the bug tracking system. Drupal 4.5.2 also fixes a cross-site scripting (XSS) vulnerability so it is recommended that you upgrade your existing Drupal sites. For more information about the Drupal 4.5.2 release, consult the announcement at: http://drupal.org/drupal-4.5.2 -- Dries Buytaert :: http://www.buytaert.net/

5 6

[drupal-devel] [bug] IF in forum SQL not supported by postgresql
by Zed Pobre 17 Jan '05

17 Jan '05

Project: Drupal -Version: 4.5.1 +Version: 4.5.2 Component: forum.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: michaelemeyers Updated by: Zed Pobre -Status: active +Status: patch Attachment: http://drupal.org/files/issues/forum_3.patch (3.17 KB) I'll chime in noting that it works for me as well. I've attached the above solution as an actual patch file to 4.5.2. Zed Pobre Previous comments: ------------------------------------------------------------------------ December 14, 2004 - 16:32 : michaelemeyers postgresql 7.4.5 / drupal 4.5.1 forum module version information: // $Id: forum.module,v 1.217 2004/11/24 22:56:21 dries Exp $ in the forum module, the IF statement in the SQL queries is not postgresql compliant: IF(l.last_comment_uid, cu.name, l.last_comment_name) as last_comment_name needs to be a case statement (or an IF function in postgresql could be written...): CASE WHEN l.last_comment_uid = 1 THEN cu.name ELSE l.last_comment_name END as last_comment_name case statements are supported by both mySQL and postgresql... -------------------------- IF results in errors: -------------------------- warning: pg_query(): Query failed: ERROR: invalid input syntax for type boolean: "13" in /usr/local/apache/htdocs/includes/database.pgsql.inc on line 45. user error: query: SELECT DISTINCT(n.nid), l.last_comment_timestamp, IF(l.last_comment_uid, cu.name, l.last_comment_name) as last_comment_name, l.last_comment_uid FROM node n , node_comment_statistics l, users cu, term_node r WHERE n.nid = r.nid AND r.tid = 354 AND n.status = 1 AND n.type = 'forum' AND l.last_comment_uid = cu.uid AND n.nid = l.nid AND '1' ORDER BY l.last_comment_timestamp DESC LIMIT 1 OFFSET 0 in /usr/local/apache/htdocs/includes/database.pgsql.inc on line 62. warning: pg_query(): Query failed: ERROR: invalid input syntax for type boolean: "2" in /usr/local/apache/htdocs/includes/database.pgsql.inc on line 45. user error: query: SELECT DISTINCT(n.nid), l.last_comment_timestamp, IF(l.last_comment_uid, cu.name, l.last_comment_name) as last_comment_name, l.last_comment_uid FROM node n , node_comment_statistics l, users cu, term_node r WHERE n.nid = r.nid AND r.tid = 353 AND n.status = 1 AND n.type = 'forum' AND l.last_comment_uid = cu.uid AND n.nid = l.nid AND '1' ORDER BY l.last_comment_timestamp DESC LIMIT 1 OFFSET 0 in /usr/local/apache/htdocs/includes/database.pgsql.inc on line 62. -------------------------- suggested patch: -------------------------- function forum_get_forums($tid = 0) { // ~at around line 380: // remove: -- $topic = db_fetch_object(db_query_range('SELECT DISTINCT(n.nid), l.last_comment_timestamp, IF(l.last_comment_uid, cu.name, l.last_comment_name) as last_comment_name, l.last_comment_uid FROM {node} n ' . node_access_join_sql() . ", {node_comment_statistics} l /*! USE INDEX (node_comment_timestamp) */, {users} cu, {term_node} r WHERE n.nid = r.nid AND r.tid = %d AND n.status = 1 AND n.type = 'forum' AND l.last_comment_uid = cu.uid AND n.nid = l.nid AND " . node_access_where_sql() . ' ORDER BY l.last_comment_timestamp DESC', $forum->tid, 0, 1)); // add: ++ $topic = db_fetch_object(db_query_range('SELECT DISTINCT(n.nid), l.last_comment_timestamp, CASE WHEN l.last_comment_uid = 1 THEN cu.name ELSE l.last_comment_name END as last_comment_name, l.last_comment_uid FROM {node} n ' . node_access_join_sql() . ", {node_comment_statistics} l, {users} cu, {term_node} r WHERE n.nid = r.nid AND r.tid = %d AND n.status = 1 AND n.type = 'forum' AND l.last_comment_uid = cu.uid AND n.nid = l.nid AND " . node_access_where_sql() . ' ORDER BY l.last_comment_timestamp DESC', $forum->tid, 0, 1)); function _forum_topics_read($term, $uid) { // ~at around line 420: // remove: -- $sql = "SELECT DISTINCT(n.nid), f.tid, n.title, n.sticky, u.name, u.uid, n.created AS timestamp, n.comment AS comment_mode, l.last_comment_timestamp, IF(l.last_comment_uid, cu.name, l.last_comment_name) as last_comment_name, l.last_comment_uid, l.comment_count AS num_comments FROM {node} n ". node_access_join_sql() .", {node_comment_statistics} l, {users} cu, {term_node} r, {users} u, {forum} f WHERE n.status = 1 AND l.last_comment_uid = cu.uid AND n.nid = l.nid AND n.nid = r.nid AND r.tid = $check_tid AND n.uid = u.uid AND n.nid = f.nid AND ". node_access_where_sql(); $sql .= tablesort_sql($forum_topic_list_header, 'n.sticky DESC,'); // add: ++ $sql = "SELECT DISTINCT(n.nid), f.tid, n.title, n.sticky, u.name, u.uid, n.created AS timestamp, n.comment AS comment_mode, l.last_comment_timestamp, CASE WHEN l.last_comment_uid = 1 THEN cu.name ELSE l.last_comment_name END as last_comment_name, l.last_comment_uid, l.comment_count AS num_comments FROM {node} n ". node_access_join_sql() .", {node_comment_statistics} l, {users} cu, {term_node} r, {users} u, {forum} f WHERE n.status = 1 AND l.last_comment_uid = cu.uid AND n.nid = l.nid AND n.nid = r.nid AND r.tid = $check_tid AND n.uid = u.uid AND n.nid = f.nid AND ". node_access_where_sql(); $sql .= tablesort_sql($forum_topic_list_header, 'n.sticky DESC,'); ------------------------------------------------------------------------ January 10, 2005 - 16:34 : Anonymous just wanted to chime in... this patch works perfectly. thanks, aaron -- View: http://drupal.org/node/14352 Edit: http://drupal.org/project/comments/add/14352

1 0

[drupal-devel] Poll: Stat Tracking for Web Projects
by Chris Messina 17 Jan '05

17 Jan '05

This post/discussion might be of interest regarding the recent Watchdog changes. As an aside, it would be nice if there were a dedicated module owner who operated in the realm of statistic analysis in their waking life and could help us write some bang up analysis tools (like Urchin maybe?)... ;) http://superfluousbanter.org/archives/2005/01/poll_stat_track.php Chris

1 0

[drupal-devel] [bug] Ignore unpublished comments when determining last_post
by Jeremy 17 Jan '05

17 Jan '05

Project: Drupal Version: 4.5.2 Component: tracker.module Category: bug reports Priority: normal Assigned to: Morbus Iff Reported by: Morbus Iff Updated by: Jeremy(a)kerneltrap.org Status: patch Agreed, the updated patch seems to be working perfectly for me. Now these constant floods of spam don't render my tracker useless. Thanks! :) Jeremy(a)kerneltrap.org Previous comments: ------------------------------------------------------------------------ January 12, 2005 - 11:02 : Morbus Iff The automated unpublishing is great for stopping spam from being displayed, but it doesn't stop spam from corrupting another feature: my "recent posts" (tracker.module). I'll regularly get bursts of 200 auto-unpublished spams which make the "recent posts" page useless - an unpublished spam still affects the modification date of a node, which makes "recent posts" display craploads of updates, even though there really isn't any. Thus, the feature request would be: - treat an unpublished spam as a deleted spam - when a spam is automatically unpublished, revert the node modification date to its previous value. I'm not entirely sure how easily possible this is, as you'd have to make sure the date is properly set when someone says "nah, this unpublished spam was actual ham", and then republishes it. ------------------------------------------------------------------------ January 12, 2005 - 14:41 : Jeremy(a)kerneltrap.org This is a known and annoying bug. As it affects me too, I assure you I'll get to fixing this eventually... Any ideas on how to cleanly implement this are welcome. ------------------------------------------------------------------------ January 13, 2005 - 16:27 : Morbus Iff Would it seem to you that this behavior should be part of core? Ignoring spam.module entirely, if a node is updated at 11:00, and then updated with a comment at 12:00, the 12:00 is saved in there as the node's modification time. But if a comment is unpublished, shouldn't the node also be reverted back to its previous state (being 11:00)? How is the deletion of data (permanently hiding it) different from merely temporarily hiding it (ie., unpublishing it)? Perhaps I should move request to Drupal. ------------------------------------------------------------------------ January 13, 2005 - 16:32 : Jeremy(a)kerneltrap.org Feel free to move it. If I come up with a clean solution (at least as far as spam is concerned), I'll update the issue wherever it is. ------------------------------------------------------------------------ January 13, 2005 - 16:39 : Morbus Iff Was talking about this with killes (who "frankly [doesn't] care too much about comments"), and I'm now wondering if I'm going nutty with all this talk about node and comment timestamps. We should investigate to see if tracker.module looks at /unpublished/ comment timestamps instead of just published ones. If it doesn't make a distinction, then it would theoretically be a quickie patch to a SQL statement to only check against published comment timestamps, not unpublished. ------------------------------------------------------------------------ January 13, 2005 - 16:42 : Morbus Iff With a quick look, it looks like tracker_page() only checks node.status, and not comment.status. We should be able to put a patch in for comment.status = 1 (unpublished being 2), and that should solve our problem, right? ------------------------------------------------------------------------ January 13, 2005 - 16:55 : Morbus Iff Apologies... "AND c.status = 0". Modifying the two queries in tracker_page() made things, seemingly, work as I desire. Can you confirm? ------------------------------------------------------------------------ January 13, 2005 - 17:02 : Jeremy(a)kerneltrap.org It didn't appear to help with regards to the spam module. I had a recent spam flood, and with or without the 'AND c.status = 0' I saw the same posts, including those with recently unpublished spam comments. ------------------------------------------------------------------------ January 13, 2005 - 17:08 : Morbus Iff Odd - I had one unpublished piece of spam that I tested against (for 4.5.0, not CVS), and modifying tracker.module seemed to work as I intended. So, the following bit of SQL still shows you erroneous nodes with unpublished comments? SELECT DISTINCT(n.nid), n.title, n.type, n.changed, n.uid, u.name, MAX(GREATEST(n.changed, c.timestamp)) AS last_post FROM node n LEFT JOIN comments c ON n.nid = c.nid INNER JOIN users u ON n.uid = u.uid WHERE n.status = 1 AND c.status = 0 AND '1' GROUP BY n.nid, n.title, n.type, n.changed, n.uid, u.name ORDER BY last_post DESC LIMIT 10; The above is what is actually run against my database with the proposed tracker.module change. (This code is currently active on gamegrene.com, so we can test live if need be. Submit a comment as an anonymous user with the words "poker" or "texas hold'em", and it should be a) unpublished automatically via your module, and b) not shown in the tracker. ------------------------------------------------------------------------ January 14, 2005 - 07:52 : Morbus Iff For what it's worth, I just woke up to another flood of 150 spams, and no corruption of my recent posts. ------------------------------------------------------------------------ January 14, 2005 - 08:05 : Jeremy(a)kerneltrap.org Then it sounds like a patch is in order... For the tracker module. ------------------------------------------------------------------------ January 14, 2005 - 08:59 : Morbus Iff Have you been able to confirm this though? ------------------------------------------------------------------------ January 14, 2005 - 09:46 : Morbus Iff Attachment: http://drupal.org/files/issues/tracker_0.patch (2.59 KB) Patch attached for 4.5.0. Haven't tried applying it to CVS, but it needs to go there too. ------------------------------------------------------------------------ January 14, 2005 - 09:56 : killes(a)www.drop.org I think it makes sense to only select published comments. I think this bugfix should go in both 4.5 and cvs. +1 ------------------------------------------------------------------------ January 14, 2005 - 10:43 : Dries Committed to DRUPAL-4-5. ------------------------------------------------------------------------ January 15, 2005 - 13:55 : grohk Reopening this issue. I just upgraded to 4.5.2 and noticed that this patch did indeed filter out the nodes with unpublished comments, but it also seems to be causing a new problem in the tracker. I have observed that new posts do not show up in the tracker until they have been commented on. I rolled back the tracker.module installed on my site to revision 1.100 and the problem was resolved, but the phantom comments (unpublished spam) were back. I am going to do some more investigations, but I am rather inexperienced in this realm. Anyone have an ideas? ------------------------------------------------------------------------ January 16, 2005 - 06:13 : Zed Pobre Attachment: http://drupal.org/files/issues/tracker.diff (2.67 KB) To fix this, instead of just checking c.status = 0, check (c.status = 0 OR c.status IS NULL). I've attached a patch to do this. ------------------------------------------------------------------------ January 16, 2005 - 10:45 : grohk So far so good. This patch seems to have fixed my tracker. Thanks Zed, I really appreciate it. -- View: http://drupal.org/node/15500 Edit: http://drupal.org/project/comments/add/15500

1 0

Re: [drupal-devel] [feature] br tag before buttons in node.module
by Chris Messina 17 Jan '05

17 Jan '05

Grant, If your solution works for you on your site, by all means, use it! :) My response to your patch was simply that it wouldn't be a wise one to implement back into core Drupal. That said, I do think that more themeability of form elements is needed and is actually something that we're working on! Have you seen the recent node creation redesign threads (http://drupal.org/node/15506 and http://drupal.org/node/14886)? Hopefully the issue that you're running into will be addressed through the continuing work on improving both the default node creation interface as well as the themeability of forms. Chris

1 0

[drupal-devel] [feature] br tag before buttons in node.module
by grantbow 17 Jan '05

17 Jan '05

Project: Drupal Version: cvs Component: node.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: grantbow(a)civicspacelabs.org Updated by: grantbow(a)civicspacelabs.org Status: patch Attachment: http://drupal.org/files/issues/node.module (60.79 KB) On my site the preview and submit buttons appear to the right side of the trackback block. Users who expect the buttons to be at the bottom of the page have a (extremely small) hurdle to find the buttons. Sometimes the buttons are rendered into the next column due to the width of the trackback block. While I am not aware if this happens on all sites, I wanted to offer a simple patch that works well on my own site. If this fix not in the proper place I would appreciate constructive feedback on where it does belong. Thanks. Index: node.module =================================================================== RCS file: /cvs/drupal/drupal/modules/node.module,v retrieving revision 1.439 diff -u -F^fun -r1.439 node.module --- node.module 11 Jan 2005 09:41:49 -0000 1.439 +++ node.module 16 Jan 2005 08:43:19 -0000 @@ -1220,6 +1220,7 @@ function node_form($edit) { $output .= form_hidden('type', $edit->type); // Add the buttons. + $output .= ''; $output .= form_submit(t('Preview')); if (!form_get_errors()) { grantbow(a)civicspacelabs.org -- View: http://drupal.org/node/15679 Edit: http://drupal.org/project/comments/add/15679

5 7

[drupal-devel] [feature] Node type filter on node admin page
by Steven 16 Jan '05

16 Jan '05

Project: Drupal Version: cvs Component: node.module Category: feature requests Priority: normal Assigned to: Steven Reported by: Anonymous Updated by: Steven Status: patch The widths are there to avoid IE pushing part of the form down. If you remove them, make sure your modified setup doesn't suffer from the same bugs. In any case, I don't have the time now to work on this patch further (exams), so if it needs further clean up, one of you guys will have to do it... Steven Previous comments: ------------------------------------------------------------------------ August 23, 2004 - 17:09 : Anonymous Attachment: http://drupal.org/files/issues/node_admin_filter.patch (3.8 KB) Here's a patch for the current CVS version which adds the option to filter nodes by type on the node admin page. Having built a few sites recently which make heavy use of flexinodes, the ability to filter out particular node types would have been extremely useful, so I hope this makes it to 4.5.0. ------------------------------------------------------------------------ August 23, 2004 - 21:06 : leafish_dylan This would be a great feature. ------------------------------------------------------------------------ August 23, 2004 - 21:06 : leafish_dylan This would be a great feature. ------------------------------------------------------------------------ September 4, 2004 - 00:38 : Bèr Kessels I think we should really come up with a good solution for this screen. In the past, I went looking for such a solution and found that the various MP3 library tools might come to help. They deal with large amounts of metadata, some of wch are important, other are not. I summarise here what the UI could be like: ** The menu-based (tree) approach: Most mp3 collections use this idea. In a tree like structure on the side, you can make selections. The list in the main area will follow this selection. (Itunes: http://www.apple.com/itunes/playlists.html , Juk: http://developer.kde.org/~wheeler/images/juk-2.0/juk-2.png, finf/freeamp: http://www.zinf.org/images/zinf_mymusic_shot.png) In drupal that would mean a menu-based filtering method. I once made a patch for that, but that was rejected: http://drupal.org/node/view/7766 The good thing here, is that it is virtually endless scalable. So in theory, flexinode coud add menu items to show only nodes where foo is bar. | - nodetype | |- blog | |= Flexinode | | |=foo | | | |=bar | |- page ** The multiple selectlist UI: Another moethod is a extended method of what we have now: select items from select boxes and press submit. Above the main area one will find some selection UI where one can in- and exlude sertain criteria. (rhythmbox: http://www.rhythmbox.org/screenshots/Screenshot-Rhythmbox.png, and winamp http://www.winamp.com/player/walkthrough.php) Note that both still show some form of tree navigation. In drupal that would mean multiple selects in three columns (rhytmbox and winamp show only two artist and album) For drupal we need three of thos blocks: one for node-types, one for node-settings (promoted, etc) and one for taxonomy terms. The node settings should be logical too: If a criteria is selected it it true, if not: false. That way we can also get rod of the annoying logic: "view posts that are not promoted" and the likes. In both solutions the "perform batch action" needs to move somewhere else. I would plead for moving it to the bottom of the list. A lot of webmail cleints do it that way. The reason being simple: the steps you take to perform the update are: 1) select criteria (find nodes) 2) checkmark the chages (we need columns of checkboxes) 3) perform the update. Logically the way you go through the UI is left->right, top-> down (not taking into consideration japanese/hebrew/arabs etc) So all in all: i think indeed the UI needs serious work. I am willing to take this one me, bu I do need some consensus first. I am not willing to spend hours on a new UI (like the menu-based approach) to find the patch being rejected.Therefore I like some discussion up fron, rather than the " code first see later" approach. Regards, Ber ------------------------------------------------------------------------ September 5, 2004 - 23:42 : Bèr Kessels Attachment: http://drupal.org/files/issues/new_UI_proposal.png (175.31 KB) Here is a gimped mockup from what option 2) could look like. WE could add a fouth box with users too, but I am not sure how that would go with permissions and the like. I need to do some thinking about selecatibility by users first. ------------------------------------------------------------------------ September 6, 2004 - 00:01 : Bèr Kessels Sorry for the spam: but I forgot to mention that there are a few issues: The "perform action dropdown" should list stuff as: promote, demote, etc. But that list needs to be generated with the selection above in mind. So if you choose " published" the action list should not have "publish these nodes" Also the action list could contain "recategorise" wich would need another screen after the one in the "ugly screendump-gimp-mockup", to be able to choose the categories in wich the selection should be placed. And of course the delete these items with a confimation dialog. (http://drupal.org/node/view/7743#comment-11624) ------------------------------------------------------------------------ September 6, 2004 - 14:32 : Bèr Kessels Attachment: http://drupal.org/files/issues/node_admin.html (29.95 KB) After a long discussion with Steven And gerhard, I designed the page in HTML, to let you all try it in some way. Beware: the html is an ugly mock, It is meant as scetch, not as valid html. Some notes on the page: "View all nodes that are:" contains three differnet possibilities for searching. The first two (above the blank line) are there for simplicity, but they might confuse users, because they need a lot of text. The second idea uses a checkbox to enable the select next to it. The third one uses some ajvascript to improve useablity. We should of course choose one of these three methods. "View all nodes that are classified in:" There are quite some people that have questions with whether or not we should include this selection aat all. Here is why I think it should definately go Because most sites have only one purpose and thus a lot of nodes of one type in one state. For example a personal blog site: 99% of the nodes are blogs. 99% are promoted. Only 1 or 2 are not promoted, not published or of type page. Or take a photo-album-site. All posts will be images, the main difference is the classification (the galleries) I placed them in. "any/all" There must be a way to choose whether the sected options should be an AND or an OR. I tried three different methods, each block has one method. We should choose one. Please give me feedback, for I still have to decide whether or not to make this a contributed module or start lobby-ing to get it in core. ------------------------------------------------------------------------ September 13, 2004 - 11:50 : moshe weitzman looking good, and really useful. a few small comments: - consider upping the number of nodes that appear on this page. it is nearly pointless to use paging on this sort of UI - i like the second idea of an 'enabled' checkbox, without the javascript. i think you can use 2 checkboxes, where the second one is called 'publish', 'promote', and 'has comments' - I prefer the horizontal configuration of the 'Require: all any' radio buttons - don't repeat 'the selected posts' in the choices for the bottom dropdown. perhaps use a title for that form_select() instead. - the last choice in that dropdown is 'reclassify'. i don't see how this screen could support that. instead, use my taxonomy_multi_edit.module from contrib :) i suggest making this a contrib module at first. it can be a tab off of the current page. thats how taxonomy_multi_edit.module appears. ------------------------------------------------------------------------ September 13, 2004 - 13:03 : Bèr Kessels About that reclassify: That was exactly my intention: using the taxonomy_muliti_edit module for that. All I wanted to do is pass a list of nids to your module and open a screen using that module with the previously selected nodes! About the other comments: Yes upping the number of nodes might be a good idea. Anyone any idea what number would still be usefull. 10.000 nodes (on drupal.org) in one list is not a good idea, IMO, so some paging is needed. indeed: repeatinf words in dropdowns is considered "bad UI design" thank you for pointing it out. Regards, Ber ------------------------------------------------------------------------ September 28, 2004 - 13:37 : eafarris Attachment: http://drupal.org/files/issues/admin_node_filter_by_type.patch (1.96 KB) here is an updated version of this patch, syncing it with CVS HEAD. Also, i did change the functionality somewhat: previous versions of the patch asked the modules what node types were out there (via hook_node_name()). This version asks the node table what types are in there (via SELECT DISTINCT type FROM {node}). I find this more useful, because it's entirely possible that, over time, modules will be removed from the system, yet they still have rows in the node table. This method gives a more accurate view of the types of nodes on the system. The new UI looks excellent, but this patch does not address it. ------------------------------------------------------------------------ September 28, 2004 - 19:05 : drumm -1 I applied and tested and it did not work at all for me. The type options selection only contains 's' and 'W', selecting one does not work. The list of types seems to come from the DB which is probably an unnecessary query. ------------------------------------------------------------------------ September 29, 2004 - 12:51 : eafarris Attachment: http://drupal.org/files/issues/admin_node_filter_by_type_1.patch (2.31 KB) Here's a version of that patch that should work. Sorry. I think that getting the types from the node table is necessary. The list of installed nodes is not the authority on what types of nodes are in the db; we should ask the db directly. It's a small query on one admin page; the result is that the dropdown has in it the most accurate information available. That's worth it, imo. ------------------------------------------------------------------------ September 29, 2004 - 12:52 : eafarris s/list of installed nodes/list of installed modules/ . sheesh. teach me to post before my tea. ------------------------------------------------------------------------ October 21, 2004 - 18:15 : Bèr Kessels Attachment: http://drupal.org/files/issues/node.html (29.33 KB) I do not know where it weant, but my proposal had a HTML mockup. Attaching it here to see what i meant. ------------------------------------------------------------------------ October 23, 2004 - 13:14 : com2 Nice filter options, but what I really miss it the possibility to select all checkboxes. Really boring job when you have to click the whole list one by one. ------------------------------------------------------------------------ October 24, 2004 - 10:41 : Bèr Kessels I am not a big fan of those options in forms. They more often break things than that thy fix them. Rahter use a bookmarklet r so for that: http://www.squarefree.com/bookmarklets/forms.html Ber ------------------------------------------------------------------------ October 25, 2004 - 01:03 : Steven Attachment: http://drupal.org/files/issues/node_admin_ucd.html (29.83 KB) Based on some more IRC discussion, I came up with this (attachment). It is based on an earlier mockup. It does use Javascript and doesn't degrade without script (yet), but I think it's worth considering. It can be implemented quite cleanly. The idea would be to have a filter like this initially, and after clicking 'Go', to show the current filter as well as the form again, allowing you to refine your search. I haven't tested browser compatibility, but it should work on most browsers. The only ones I know for sure won't work are IE4 and NS4, which are old enough to ignore IMO: after all, this is admin only, and we can put some stricter browser requirements on that. Recent versions of other browsers should work (it only does a simple visibility toggle). I like it because it's not an airplane cockpit, but still offers complex filtering options through refinement. It is also quite similar to the search/filtering UI in e.g. mail applications. The question is of course, how to degrade it for people without Javascript. My suggestion would be to simply show all filter options, and put a radiobutton in front of each: ( ) Where type is [ blog | v ] ( ) Where published status is ( ) published ( ) unpublished ( ) Where category is [ term1 | v ] ... It has more visual clutter, but the same principle of use. ------------------------------------------------------------------------ October 25, 2004 - 01:13 : Steven In fact, I just realized that the radio-button version can be coded to send exactly the same form data as the scripted version, which makes it more interesting. ------------------------------------------------------------------------ October 29, 2004 - 00:52 : Steven If you guys approve of my idea, I'll start coding. Assigning to myself for now. ------------------------------------------------------------------------ November 1, 2004 - 17:35 : Bèr Kessels I like this idea much more than my previous approaches. Gave it some thought and came with the follwing behaviour: * I think we need to discuss or at least design the tabular data too: It makes 0 sense to show the "types" column, if you chose "type = image" * I think we need to introduce a hook to add info to that tabulat view. Images can output thumbnails, for example * In tabular view, we should make: title a textfield, type and author a select and satus a select too. * I think we should introduce another range of options: "where content contains" [ ] and "where title contains" [ ] * I would like to get some feedback on how many drupal-using people are firmly against javascript, with a reason why. I bet that this is < 1% ! Bèr ------------------------------------------------------------------------ November 1, 2004 - 17:42 : Steven We don't have an anti-JS policy in Drupal. It's just that until recently, doing cross browser JS was a chore and making it accessible and degradable would be a disaster. This form can be implemented cleanly and will degrade without problems. Anyone who opposes it because it is JS can bugger off ;). ------------------------------------------------------------------------ November 3, 2004 - 19:24 : com2 There is a more radical way around JS. You could forget the table idea alltogether and present the nodes in Listbox. Then selecting becomes much easier with Ctrl-Click and Shift-Click ------------------------------------------------------------------------ November 4, 2004 - 00:02 : Bèr Kessels Did you have a look at the previous applied UI improvements? Did you consider the pre's and cons of those earlier posts? It seams you are repeating passed issues here, please reply with miore detailed issues here, Bèr ------------------------------------------------------------------------ December 3, 2004 - 10:49 : Steven Attachment: http://drupal.org/files/issues/node-admin.patch (13.1 KB) Here's a patch which implements the JS approach of refining the selection. ------------------------------------------------------------------------ December 3, 2004 - 10:50 : Steven Attachment: http://drupal.org/files/issues/node_admin.png (34.38 KB) And here's a screenshot of how it looks. ------------------------------------------------------------------------ December 3, 2004 - 19:23 : FactoryJoe(a)civicspacelabs.org This is looking better and better. I'm going to do a UI review of this a post any additional thoughts or comments. Chris ------------------------------------------------------------------------ December 3, 2004 - 21:50 : Anonymous Ack, I tested this using the bluebeach theme, but there's a small CSS bug with bluemarine, where the header for the operations form is stuck to the right of the filter form. I'll make an updated patch later. In the meantime, comments are much appreciated. ------------------------------------------------------------------------ December 3, 2004 - 23:15 : killes(a)www.drop.org I actually prefer the non-JS menu over the JS menu. Not (only) because of the JS but because I prefer radiobuttons over pulldown menus. The argument that the non-JS approach uses more vertical space can be mitigated by redirecting to a #results anchor. ------------------------------------------------------------------------ January 15, 2005 - 06:32 : Steven Attachment: http://drupal.org/files/issues/node.admin.patch (14.41 KB) Here's an updated patch... I have exams in a week, so I don't have time to finish up the Javascript version, so I removed it (it can be added later easily). However, the non-JS version is still very usable. Changes since last time: - Uses semantic XHTML (definition list, and yes, they are for more than just definitions, even w3c agrees). - Merges the various node flags (promoted, published, ...) into one "status" dropdown. This keeps the whole selector shorter, and is better UI-wise IMO. - Adds drupal_gotos, they were missing. - Updates node admin watchog messages to properly display the type. The code used t($node->type) which is a big no-no. hook_node_name() is now invoked instead. - Removes some dead code. - I rolled Ber's node mass deletion patch in as it affects the same piece of code. Updating either patch for the other separately would be a waste of time. I also added some more improvements to Bèr's code, such as removing the incorrect help from the confirmation page, cleaning up the code style a bit, not loading every node just to display its title and displaying a single drupal_set_message() after the deleting rather than one per node. The old issue is here: http://drupal.org/node/7743 ------------------------------------------------------------------------ January 15, 2005 - 06:32 : Steven Attachment: http://drupal.org/files/issues/node admin.png (30.19 KB) ------------------------------------------------------------------------ January 15, 2005 - 09:55 : Bèr Kessels Thanks for integrating the batch delete patch, Steven! ------------------------------------------------------------------------ January 15, 2005 - 13:47 : Dries Attachment: http://drupal.org/files/issues/node-filter-wrap.png (34.55 KB) It looks good but: 1. It makes the UI looks cluttered. I suggest visually grouping the varios form elements so it becomes easier for they eye to skip over them. 2. It is too wide. Try using the Chameleon theme with a sidebar on the right at 1024x768 (eg. my laptop's resolution) and you'll find that the form elements wrap, and wrap in an awkward order. See screenshot. Maybe we should group the form elements using from_group() and make "Show only items where" the form_group()'s title. It would save space. ------------------------------------------------------------------------ January 15, 2005 - 16:14 : Bèr Kessels Steven, Is there a reason why you do not use theme_box, but hardcode HTML in your forms? If there is none, I will spend some time monday to fix it. Bèr ------------------------------------------------------------------------ January 15, 2005 - 17:48 : Steven Simple. There aren't any guidelines on theme box usage :P. Plus, theming the admin interface is probably not a big priority. ------------------------------------------------------------------------ January 15, 2005 - 19:44 : FactoryJoe(a)civicspacelabs.org Attachment: http://drupal.org/files/issues/node-filter-wrap-v2.png (14.23 KB) I simplified the layout and added some visual separation between elements (the rounded boxes). I imagine that pretty much the same markup as exists now could be used with some slight tweaks. Probably the most significant change, horizontally, is moving the filter button below the filters. ------------------------------------------------------------------------ January 15, 2005 - 20:13 : Steven This way they take up even more space though. I'd like to at least have the user see part of the results table without scrolling. Also, the rounded boxes are definitely a theme thing and don't really belong in core. The markup would need some changes too, as right now the structure is vertical nested inside horizontal, while yours is horizontal nested in vertical. I was also wondering about the wording... "Show items where A is B" sounds a bit bumpy. Alternatives "... items whose A is B" "items with A of B", etc. ------------------------------------------------------------------------ January 15, 2005 - 23:04 : Dries Chris' mockup looks better but there is still room for improvement: 1. The titles of the two /form groups/ are not consistent. 2. Removing the (mostly) brain-death help text might help to reduce the visual clutter. The help text is incorrect: clicking the username opens the user's profile page as one would expect. 3. The indentation looks pretty random. ------------------------------------------------------------------------ January 16, 2005 - 20:33 : Dries Attachment: http://drupal.org/files/issues/node-filter.png (27.38 KB) Looked some more at this patch: 1. The hardcoded widths in drupal.css should be avoided. They don't match my laptop's resolution and make for akward whitespace on higher resolutions. When I remove some of the hardcoded constants in drupal.css the forms look a whole lot better. Except for the buttons that is, they still wrap but it might not be a problem. IMO, we can't get this right unless we move the buttons under the form. 2. I played with the patch a little and came up with the attached screenshot. It needs refinement but the CSS/markup make it bothersome so this is nothing but of a proof-of-concept. As soon I try to change something the layout freaks out. It took me 15 minutes to 'reverse engineer' the markup/CSS. Personally, I'd rather have something that is a bit easier to change/customize. Any way, I simplified the help, wrapped the forms in a form_group() and generally forced things to fit my resolution better. 3. The fact there is no Javascript involved makes things a whole lot easier. -- View: http://drupal.org/node/10296 Edit: http://drupal.org/project/comments/add/10296

1 0

[drupal-devel] [task] Improve story help texts
by Goba 16 Jan '05

16 Jan '05

Project: Drupal Version: cvs Component: story.module Category: tasks Priority: normal Assigned to: Bèr Kessels Reported by: Bèr Kessels Updated by: Goba Status: patch But having a multisentence long text being present two times in the code, and even one more time as a prefix makes translation a lot harder. True, the two identical strings only need to be translated once, but not the third one. Who will spot that the longer one actually has the same prefix? Programs like kbabel provide no clue on what else is in the file, they only concentrate on one string. Also if one fixes a typo in your string, or starts to improve it, he needs to do so in three places, and the translator also needs to fix it in two places. I bet non-coders will not expect that a string they see on the interface might be in the code three times, so if they fix one instance, it might not be that one exact instance they expected to fix. Non-coders have probably no idea on what the section identifiers mean... Goba Previous comments: ------------------------------------------------------------------------ January 7, 2005 - 14:19 : Bèr Kessels Attachment: http://drupal.org/files/issues/story_help.patch (3.06 KB) Because of historical reasons the story module help contained all sortts of odd texts, that are partly even untrue. This patch changes the help so that it: * stresses that stories are nodes in their simplest form * removes all the bloat about workflow. workflow can be configured for any node type, why should nstories mention it? * removes parts of voting, queues, promotion, comments etc. Any node type can have this. * adds a note that you can use stories for personal blogging, and as general pages, pages with no specific purpose (I consider, for example, a forum node a node with a special purpose) * stresses that you should use other modules (taxonnomy, menu) to give the node a place on your site. set to CVS but will apply to 4.5 too..... ------------------------------------------------------------------------ January 10, 2005 - 17:41 : Bèr Kessels Attachment: http://drupal.org/files/issues/story_help_0.patch (3.06 KB) previous patch was the one before spellchecking. This one is without the two spelling errors. ------------------------------------------------------------------------ January 10, 2005 - 20:29 : Dries Can someone review this please? ------------------------------------------------------------------------ January 12, 2005 - 14:53 : Bèr Kessels Attachment: http://drupal.org/files/issues/story_help_1.patch (3.01 KB) After some discussion on the drupal-docs ML, i came up with the following help-texts: Short: Stories are articles in their simplest form: they have a title, a teaser and a body, but can be extended by other modules. The teaser is part of the body too. Stories may be used as a personal blog or for news articles. Longer: Stories are articles in their simplest form: they have a title, a teaser and a body, but can be extended by other modules. The teaser is part of the body too. Stories may be used as a personal blog or for news articles. By default, no menu item, or navigation element is created for a story. An extra feature of a story is, that an administrator can specify a submission guideline and enforce a minimum word count for user submitted stories ------------------------------------------------------------------------ January 13, 2005 - 20:42 : Dries This patch doesn't apply against HEAD. patching file modules/story.module Hunk #1 FAILED at 14. Hunk #2 FAILED at 26. 2 out of 2 hunks FAILED -- saving rejects to file modules/story.module.rej ------------------------------------------------------------------------ January 14, 2005 - 23:55 : Bèr Kessels AARHGH, such a simple patch, so much hassle. My mistake, uplaoded the wrong one again. This one should be right. ------------------------------------------------------------------------ January 15, 2005 - 00:05 : Bèr Kessels Attachment: http://drupal.org/files/issues/story_improve_help.patch (3.19 KB) **sigh** ------------------------------------------------------------------------ January 15, 2005 - 09:01 : Dries Committed to HEAD. ------------------------------------------------------------------------ January 15, 2005 - 20:10 : Goba Attachment: http://drupal.org/files/issues/Drupal.simplify.story.help.patch (2.18 KB) Well, this was a bogus fix after all. The patch removed the paragraph tags used in some help texts. These were introduced lately in most of the help texts to improve consistency in displaying help texts. I am unsure however, whether such paragraphs are going to be used on node add pages... What is worse, that the committed patch contained the exact same sentence sequeces three times in the code, two times identical, one time with an extension. Being in a switch() statement, it is quite simple to overcome the duplicate, and it is also not hard to watch out for the extended part. A patch attached to remedy this. BUT this still does not restore the paragpraph wrapping around the help text in the admin helps, since I am unsure, whether that would be applicable to the 'node add' page descriptions. ------------------------------------------------------------------------ January 16, 2005 - 21:07 : Bèr Kessels Allthough your patch cleans the code, I did purposedly not do it your way. The reason being that i recall (but cannot refind some discussion about this. AFAIKR it was decided we would keep help separate. The reason being that non-codes would be able to chage the help of various textx easier. -- View: http://drupal.org/node/15264 Edit: http://drupal.org/project/comments/add/15264

1 0

[drupal-devel] [task] Improve story help texts
by Bèr Kessels 16 Jan '05

16 Jan '05

Project: Drupal Version: cvs Component: story.module Category: tasks Priority: normal Assigned to: Bèr Kessels Reported by: Bèr Kessels Updated by: Bèr Kessels Status: patch Allthough your patch cleans the code, I did purposedly not do it your way. The reason being that i recall (but cannot refind some discussion about this. AFAIKR it was decided we would keep help separate. The reason being that non-codes would be able to chage the help of various textx easier. Bèr Kessels Previous comments: ------------------------------------------------------------------------ January 7, 2005 - 14:19 : Bèr Kessels Attachment: http://drupal.org/files/issues/story_help.patch (3.06 KB) Because of historical reasons the story module help contained all sortts of odd texts, that are partly even untrue. This patch changes the help so that it: * stresses that stories are nodes in their simplest form * removes all the bloat about workflow. workflow can be configured for any node type, why should nstories mention it? * removes parts of voting, queues, promotion, comments etc. Any node type can have this. * adds a note that you can use stories for personal blogging, and as general pages, pages with no specific purpose (I consider, for example, a forum node a node with a special purpose) * stresses that you should use other modules (taxonnomy, menu) to give the node a place on your site. set to CVS but will apply to 4.5 too..... ------------------------------------------------------------------------ January 10, 2005 - 17:41 : Bèr Kessels Attachment: http://drupal.org/files/issues/story_help_0.patch (3.06 KB) previous patch was the one before spellchecking. This one is without the two spelling errors. ------------------------------------------------------------------------ January 10, 2005 - 20:29 : Dries Can someone review this please? ------------------------------------------------------------------------ January 12, 2005 - 14:53 : Bèr Kessels Attachment: http://drupal.org/files/issues/story_help_1.patch (3.01 KB) After some discussion on the drupal-docs ML, i came up with the following help-texts: Short: Stories are articles in their simplest form: they have a title, a teaser and a body, but can be extended by other modules. The teaser is part of the body too. Stories may be used as a personal blog or for news articles. Longer: Stories are articles in their simplest form: they have a title, a teaser and a body, but can be extended by other modules. The teaser is part of the body too. Stories may be used as a personal blog or for news articles. By default, no menu item, or navigation element is created for a story. An extra feature of a story is, that an administrator can specify a submission guideline and enforce a minimum word count for user submitted stories ------------------------------------------------------------------------ January 13, 2005 - 20:42 : Dries This patch doesn't apply against HEAD. patching file modules/story.module Hunk #1 FAILED at 14. Hunk #2 FAILED at 26. 2 out of 2 hunks FAILED -- saving rejects to file modules/story.module.rej ------------------------------------------------------------------------ January 14, 2005 - 23:55 : Bèr Kessels AARHGH, such a simple patch, so much hassle. My mistake, uplaoded the wrong one again. This one should be right. ------------------------------------------------------------------------ January 15, 2005 - 00:05 : Bèr Kessels Attachment: http://drupal.org/files/issues/story_improve_help.patch (3.19 KB) **sigh** ------------------------------------------------------------------------ January 15, 2005 - 09:01 : Dries Committed to HEAD. ------------------------------------------------------------------------ January 15, 2005 - 20:10 : Goba Attachment: http://drupal.org/files/issues/Drupal.simplify.story.help.patch (2.18 KB) Well, this was a bogus fix after all. The patch removed the paragraph tags used in some help texts. These were introduced lately in most of the help texts to improve consistency in displaying help texts. I am unsure however, whether such paragraphs are going to be used on node add pages... What is worse, that the committed patch contained the exact same sentence sequeces three times in the code, two times identical, one time with an extension. Being in a switch() statement, it is quite simple to overcome the duplicate, and it is also not hard to watch out for the extended part. A patch attached to remedy this. BUT this still does not restore the paragpraph wrapping around the help text in the admin helps, since I am unsure, whether that would be applicable to the 'node add' page descriptions. -- View: http://drupal.org/node/15264 Edit: http://drupal.org/project/comments/add/15264

1 0