January 2005 - Development - lists.drupal.org

[drupal-devel] [bug] QUICKFIX: Vocabulary node type checks are bogus
by Goba 19 Jan '05

19 Jan '05

Project: Drupal Version: cvs Component: taxonomy.module Category: bug reports Priority: normal Assigned to: Goba Reported by: Goba Updated by: Goba Status: patch Attachment: http://drupal.org/files/issues/Drupal-fix-vocab-node-types.patch (1.27 KB) The vocabulary node types checks in taxonomy.module are very vulnerable to having node types names as prefixes of other node type names %%%s%% as it is there with %%blog%% will match a lot more, then just this simple node type. I have a special blogmark type for example, which is found for %%blog%%. Since the node types are stored in a comma separated list, the solution is to search for 'blog' or '%%,blog,%%' or 'blog,%%' or '%%,blog', that is matching only for that node type, or matching that node type in a list, or at the beginning of a list, or at the end of a list. It does not look elegant, but this is the solution for the format used. This probably also applies to 4.5.0, the patch is against HEAD. Goba -- View: http://drupal.org/node/15690 Edit: http://drupal.org/project/comments/add/15690

1 2

Re: [drupal-devel] rel=nofollow
by Boris Mann 19 Jan '05

19 Jan '05

On Wed, 19 Jan 2005 17:45:08 +0100, Gerhard Killesreiter <killesreiter(a)physik.uni-freiburg.de> wrote: > If you or anybody else decides to do that, please do it in a way that > can > be bypassed. We once had such a feature and it was most annoying for use > with mailhandler or similar automatic posting. It's in core, it's a filter, and James Walker (yeah, he works with me) coded it. :P -- Boris Mann http://www.bryght.com

1 0

Re: [drupal-devel] rel=nofollow
by Boris Mann 19 Jan '05

19 Jan '05

On Tue, 18 Jan 2005 23:08:06 -0500, Andre Molnar <mcsparkerton(a)yahoo.co.uk> wrote: > Todd Grimason wrote: > > Haven't seen this mentioned anywhere here yet: > > http://www.google.com/googleblog/2005/01/preventing-comment-spam.html > > In short, adding an attribute to an anchor tag: > > rel="nofollow" > > will cause participating search engines to not follow/count the link > > (Google, MSN, and Yahoo! so far). > > So anywhere there's a link in user-submitted content you'd add this. > > Won't stop the spammers - but at least their efforts will be wasted. I'm not sure that there is much point to this...spam.module is MUCH more effective at making this not a problem. And what if you WANT user submitted content to count towards pagerank? Like, say, people in forums constantly pointing to the same RTFM post. Do spammers spam to raise page rank? Or do spammers spam so that other people see/click on their links? *grumble, grumble, grumble* -- Boris Mann http://www.bryght.com

7 6

[drupal-devel] [bug] form_weight should use dleta:15 in book outline admin
by Bèr Kessels 19 Jan '05

19 Jan '05

Project: Drupal Version: cvs Component: book.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: Bèr Kessels Status: patch Attachment: http://drupal.org/files/issues/book_form_weight_delta.patch (1.11 KB) This is a useability improvement *with code* ;) In book-pages node forms we use a delta of fifteen (-15 to +15) but in the book-outline admin we dont dewfine this, resulting in a default delta of ten. This should be consistent and thus both 15. Bèr Kessels -- View: http://drupal.org/node/15843 Edit: http://drupal.org/project/comments/add/15843

1 0

[drupal-devel] settings
by Negyesi Karoly 19 Jan '05

19 Jan '05

Hi, Settings are scattered everywhere. This is extermely confusing the light of the Settings menu item. I'd expect to find every settings under settings. Why Is content settings is reachable under node / settings but not under settings / node ? What's more I'd expect both subtabs (settings, default workflow) from admin/node/configure Same with users, the page admin/user/configure should be also accessible as settings/user. Regards NK

3 6

Re: [drupal-devel] rel=nofollow
by Boris Mann 19 Jan '05

19 Jan '05

On Wed, 19 Jan 2005 10:54:12 +0000, Gabor Hojtsy <gabor(a)hojtsy.hu> wrote: > >> I'm not sure that there is much point to this...spam.module is MUCH > >> more effective at making this not a problem. And what if you WANT user > >> submitted content to count towards pagerank? Like, say, people in > >> forums constantly pointing to the same RTFM post. > > i see a much point. maintaining spam.module is much harder than just > > rewriting some links. the idea is not to rewrite internal links (such > > as your forum example), but rather to rewrite external links. > > For external pages, it is just the same, you might just be happy with > increasing some page's pagerank. On some forums, users tend to suggest > others going to http://www.catb.org/~esr/faqs/smart-questions.html or > the native language translation of that before asking more questions :) > Now it would clearly be positive, if these type of pages pagerank would > raise :) EXACTLY! This is a very big hammer to be raising. I'm not sure what the effects will be (I don't think anyone can, even Google, until it actually starts to effect changes). I *am* interested to flip ahead to the end of this story. May be the single biggest change in Google PR/Internet traffic in history. Chris: in your spam example on SpreadFirefox, wouldn't Jeremy's spam module have unpublished all that content/comments? On my (obviously much smaller) site, I have a big spam problem...so I just turn on comment moderation for anonymous users. Spammers don't get links, but they still spam. Why do people think it will stop because of this? (I'm honestly puzzled by this). In any case...if someone wants to implement, great -- please, just not in core, or allow it to be turned off. -- Boris Mann http://www.bryght.com

2 1

[drupal-devel] [bug] "Add new comment" no longer shows up in $links?
by Junyor 19 Jan '05

19 Jan '05

Project: Drupal Version: 4.5.1 Component: poll.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Morbus Iff Updated by: Junyor -Status: active +Status: patch Attachment: http://drupal.org/files/issues/junyor.poll.patch (762 bytes) The change to theme_node was done as part of http://drupal.org/node/9287. Other than theme_node, poll_view is the only function that calls link_node directly. Attached is a patch to fix the function call in poll_view to send the correct parameters. Junyor Previous comments: ------------------------------------------------------------------------ December 30, 2004 - 15:41 : Morbus Iff I recently upgraded from 4.4.2 to 4.5.1, and have noticed that the poll block no longer displays the "add new comment" or "# comments" link. This is (was) important to me, as I usually ask for comments whenever someone chooses the negative option. Any idea where and why this went? You can still get to the comment form in a roundabout way ("other polls", choose your poll, whammo), but that's far too many clicks and intellect points. ------------------------------------------------------------------------ January 18, 2005 - 16:50 : rooey I had the same problem going from 4.4 to 4.5 - i still see it in 4.5.2 :( There is *some* info on comment issues here: http://drupal.org/node/11366 I didn't find any of them solved this particular issue tho. ------------------------------------------------------------------------ January 18, 2005 - 18:28 : Junyor So, not even the "add new comment" link is showing up? I just loaded the poll module and that shows fine. However, the current comment count doesn't show correctly in the block. This is what I've seen so far: 1) poll_block calls poll_view 2) poll_view calls poll_view_voting, which outputs the poll choices 3) for blocks, poll_view calls link_node, which calls hook_link('node') in each module. For all other poll displays, the theme does the call to link_node (via node_view) I'm guessing poll_view is where the problem is. I'll keep looking at it. ------------------------------------------------------------------------ January 18, 2005 - 18:41 : Junyor Changing the call to link_node on line 438 in poll.module (in poll_view) to: ------------------------------------------------------------------------ January 18, 2005 - 18:51 : Junyor Trying again with correct PHP tags. :) Changing the call to link_node on line 438 in poll.module (in poll_view) to: seems to solve the problem. I'm trying to look now at the history of link_node to see why that fixed it. That's the same parameters that the call in theme_node uses. -- View: http://drupal.org/node/14936 Edit: http://drupal.org/project/comments/add/14936

5 6

[drupal-devel] [bug] unneeded " in query code
by nato 19 Jan '05

19 Jan '05

Project: Drupal Version: cvs Component: statistics.module Category: bug reports Priority: normal Assigned to: nato Reported by: nato Updated by: nato Status: patch Attachment: http://drupal.org/files/issues/statistics.diff (1.07 KB) unneeded " in query code nato -- View: http://drupal.org/node/15825 Edit: http://drupal.org/project/comments/add/15825

2 1

Re: [drupal-devel] Introduction and Questions
by Tim Altman 19 Jan '05

19 Jan '05

On Tue, 18 Jan 2005 20:03:14 -0000, Michael Jervis <mike(a)fuckingbrit.com> wrote: [...] > I have another task in mind, a proper geeklog migration script. I was > thinking a standalone PHP file, rather than a .module, as it would be a > use > once thing. Is there a standard way that has been used in the past for > migration scripts? Or are they all ad-hoc things? I'll probably need to > read > conf.php to get the prefix, which makes me think about slotting into > Drupal. > But I'm not yet familiar enough with the Drupal system to know if I > should/shouldn't etc. I've recently been working on a migration script for Blogger and have written one for MovableType in the past. You can find my current work in my sandbox. There's some information about migrating from Geeklog at http://drupal.org/node/1080, too. If at all possible, we should use the same framework for importation scripts, so it's easy to make a new importer plug-in. That's what I've been trying to do with the Blogger script. I still have to rewrite the MT importer to follow the same framework. I'm quite open to reworking the stuff I've done so far, as I've been making the framework as I've been writing the Blogger plug-in and I haven't done anything like this in the past. -- Tim Altman

1 0

RE: [drupal-devel] Introduction and Questions
by Michael Jervis 19 Jan '05

19 Jan '05

>This is tied to some long standing issues. Basically, need to both add >read/write support for multiple formats, preferably in a Is there something missing here? >Lack of libraries hasn't been the issue, but rather lack of bandwidth >to go through all the related items. Neil Drumm is probably the person >that's actually done the most on this so far (I just bitch and tell >other people how things should be architected, when I'm not >cheerleading). How far have things got with this? Is there code in HEAD working in the direction? Cheers, Mike

1 0