January 2005 - Development - lists.drupal.org

[drupal-devel] Bug#292887: upgrading from drupal 4.4.x does not upgrade the mysql database and makes drupal inaccesable
by Steve Langasek 31 Jan '05

31 Jan '05

severity 292887 important thanks drupal was not included in woody, so this upgrade issue is not RC for sarge. -- Steve Langasek postmodern programmer

2 1

[drupal-devel] cvs log messages
by no-reply＠zind.net 31 Jan '05

31 Jan '05

File: /modules/cvslog/cvs.module 1.42 Date: January 30, 2005 - 23:28 User: dries - More changes and incremental improvements. ---------------------------------------------------------------------- File: /modules/cvslog/cvs.module 1.41 Date: January 30, 2005 - 23:19 User: dries - More updates. ---------------------------------------------------------------------- File: /translations/README.txt 1.6 Date: January 30, 2005 - 22:03 User: mcduarte Various corrections. ---------------------------------------------------------------------- File: /modules/cvslog/cvs.module 1.40 /modules/cvslog/cvs.mysql 1.6 Date: January 30, 2005 - 21:43 User: dries - Added a CVS application form and further integrated user and CVS accounts. Work in progress. ---------------------------------------------------------------------- File: /modules/webform/webform.inc 1.5 /modules/webform/webform.module 1.32 Date: January 30, 2005 - 20:27 User: ullgren more changes to the report part from jnt ---------------------------------------------------------------------- File: /translations/fr/blog-module.po 1.6 Date: January 30, 2005 - 20:06 User: alkahan ---------------------------------------------------------------------- File: /modules/project/project.module 1.178 Date: January 30, 2005 - 18:31 User: unconed - Fixing missing project vocabulary tabs ---------------------------------------------------------------------- File: /modules/project/project.module 1.177 Date: January 30, 2005 - 18:26 User: unconed - Fixing missing project vocabulary tabs ---------------------------------------------------------------------- File: /modules/project/project.module 1.176 Date: January 30, 2005 - 18:10 User: unconed - Fixing form error reporting ---------------------------------------------------------------------- File: /includes/database.inc 1.36 Date: January 30, 2005 - 17:48 User: dries - Patch #16111 by chx: PHPdoc/documentation improvements. ---------------------------------------------------------------------- File: /modules/blogroll/blogroll.module 1.8 Date: January 30, 2005 - 17:29 User: ahynes1 Updated to take advantage of weighting in the script section ---------------------------------------------------------------------- File: /modules/project/project.inc 1.45 Date: January 30, 2005 - 17:17 User: dries - Patch #11284 by tapio: fixed broken URL. ---------------------------------------------------------------------- File: /modules/project/issue.inc 1.87 Date: January 30, 2005 - 17:17 User: dries - Fixed broken breadcrumb link on issue pages. ---------------------------------------------------------------------- File: /modules/project/release.inc 1.43 Date: January 30, 2005 - 17:14 User: dries - Patch #11122 by tangent: the heading links for each release on the new "release tab" linked to an invalid path. They linked to "releases" instead of "release". Also the anchor ID values contained the version number which was not valid XHTML. ---------------------------------------------------------------------- File: /modules/project/issue.inc 1.86 Date: January 30, 2005 - 17:11 User: dries - Patch #16025 by tangent: set the default/initial status to 'active'. ---------------------------------------------------------------------- File: /translations/de/README.txt 1.12 Date: January 30, 2005 - 13:32 User: uwe Applied patch by xeophin from http://drupal.org/node/16347. Thanks. ---------------------------------------------------------------------- File: /modules/project/mail.inc 1.42 Date: January 30, 2005 - 12:55 User: unconed - Regexp oopsie ---------------------------------------------------------------------- File: /includes/theme.inc 1.223 /misc/drupal.css 1.94 /modules/comment.module 1.331 /modules/node.module 1.454 /modules/tracker.module 1.113 Date: January 30, 2005 - 09:53 User: dries - Patch #16253 by Goba: incremental improvements to the new content markers. Goba: it would be nice if one of the core themes would showcase this functionality. ;-) ---------------------------------------------------------------------- File: /modules/book.module 1.283 Date: January 30, 2005 - 08:53 User: dries - Fixed a misplaced bracket that slipped in due to the db/node_rewrite_sql_patch. ---------------------------------------------------------------------- File: /modules/tracker.module 1.112 Date: January 30, 2005 - 08:39 User: dries - Added a missing DISTINCT() to the pager query. Spotted by Steven. ---------------------------------------------------------------------- File: /modules/postcount_rank/postcount_rank.module 1.6 Date: January 30, 2005 - 07:41 User: pyromanfo Fixed infinite loop when going over top rank ----------------------------------------------------------------------

1 0

[drupal-devel] [bug] i18n - Cached menus not changing language
by Jose A Reyero 30 Jan '05

30 Jan '05

Project: Drupal Version: cvs Component: menu system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Jose A Reyero Updated by: Jose A Reyero Status: patch Attachment: http://drupal.org/files/issues/menu_inc_cached_language_01.patch (719 bytes) Menu caching is too aggressive, resulting in menus not changing language when you change user language. This is also -but not only- a problem with i18n. Note: got this code from Ber Kessels, I just produced the patch. (thanx) Jose A Reyero -- View: http://drupal.org/node/16443 Edit: http://drupal.org/project/comments/add/16443

1 0

[drupal-devel] [feature] i18n - Using taxonomy hook to add fields to taxonomy forms
by Jose A Reyero 30 Jan '05

30 Jan '05

Project: Drupal Version: cvs Component: taxonomy.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Jose A Reyero Updated by: Jose A Reyero Status: patch Attachment: http://drupal.org/files/issues/taxonomy_module_hook_form_pre_02.patch (1.54 KB) The previous one had some unneccessary stuff, sorry Jose A Reyero Previous comments: ------------------------------------------------------------------------ January 30, 2005 - 19:33 : Jose A Reyero Attachment: http://drupal.org/files/issues/taxonomy_module_hook_form_pre_01.patch (2.04 KB) This is similar to nodeapi('form pre'...), it just uses the taxonomy hook to allow other modules to add fields at the beginning of the taxonomy's forms -terms and vocabularies. Though this one is needed for i18n, its a general feature and could be also some use for other modules. -- View: http://drupal.org/node/16440 Edit: http://drupal.org/project/comments/add/16440

1 0

[drupal-devel] uploading patches
by Dries Buytaert 30 Jan '05

30 Jan '05

1 0

[drupal-devel] [feature] Allow Authenticated users to Post Anonymously
by javanaut 30 Jan '05

30 Jan '05

Project: Drupal Version: 4.5.2 Component: comment.module Category: feature requests Priority: normal Assigned to: javanaut Reported by: javanaut Updated by: javanaut -Status: active +Status: patch javanaut Previous comments: ------------------------------------------------------------------------ January 28, 2005 - 18:49 : javanaut Attachment: http://drupal.org/files/issues/comment.post_anonymously.patch (1.64 KB) -- View: http://drupal.org/node/16366 Edit: http://drupal.org/project/comments/add/16366

1 0

[drupal-devel] cvs log messages
by no-reply＠zind.net 30 Jan '05

30 Jan '05

File: /modules/project/mail.inc 1.41 Date: January 29, 2005 - 23:47 User: unconed - Improved newline handling in mail output. ---------------------------------------------------------------------- File: /modules/project/mail.inc 1.40 Date: January 29, 2005 - 23:09 User: unconed Oopsie: '\n' -> "\n". ---------------------------------------------------------------------- File: /modules/taxonomy_access/taxonomy_access.module 1.25 Date: January 29, 2005 - 23:09 User: pyromanfo Fixed errors when doing clean install ---------------------------------------------------------------------- File: /modules/project/mail.inc 1.39 Date: January 29, 2005 - 23:02 User: unconed Adding some smarter HTML to text conversions. ---------------------------------------------------------------------- File: /modules/tracker.module 1.111 Date: January 29, 2005 - 22:21 User: dries - I had to use DISTINCT for the tracker.module's SQL queries. ---------------------------------------------------------------------- File: /CHANGELOG.txt 1.63 /includes/database.inc 1.35 /modules/aggregator.module 1.227 /modules/archive.module 1.77 /modules/blog.module 1.212 /modules/book.module 1.282 /modules/comment.module 1.330 /modules/forum.module 1.227 /modules/node.module 1.453 /modules/poll.module 1.156 /modules/queue.module 1.125 /modules/taxonomy.module 1.172 /modules/tracker.module 1.110 /modules/upload.module 1.22 /modules/user.module 1.436 Date: January 29, 2005 - 22:02 User: dries - Patch #16111 by chx: generalized node_rewrite_query to db_rewrite_query. ---------------------------------------------------------------------- File: /modules/project/mail.inc 1.38 Date: January 29, 2005 - 21:49 User: unconed Fixing bad HTML handling. ---------------------------------------------------------------------- File: /modules/actions/actions.module 1.3 Date: January 29, 2005 - 18:59 User: jvandyk array_pop() to make sure batched actions happen in the expected order ---------------------------------------------------------------------- File: /modules/actions/actions.inc 1.4 Date: January 29, 2005 - 18:57 User: jvandyk passing node by reference so our changes are not discarded when actions are batched ---------------------------------------------------------------------- File: /modules/taxonomy_access/taxonomy_access.module 1.24 Date: January 29, 2005 - 17:30 User: pyromanfo Added checkboxes next to vocabularies so that users can set permissions for all terms in a vocabulary at once ---------------------------------------------------------------------- File: /modules/feedback/feedback.module 1.28 Date: January 29, 2005 - 16:52 User: kbahey Added a breadcrumb to the home page, so as to be consistent with the rest of Drupal. In response to a comment on an issue here http://drupal.org/node/15492 ---------------------------------------------------------------------- File: /modules/taxonomy_access/taxonomy_access.module 1.23 Date: January 29, 2005 - 16:47 User: pyromanfo Removed unnecessary line from taxonomy_access_node_grants ---------------------------------------------------------------------- File: /modules/taxonomy_access/taxonomy_access.module 1.22 Date: January 29, 2005 - 16:45 User: pyromanfo Fixed errors when enabling module for first time ---------------------------------------------------------------------- File: /modules/feature/feature.module 1.20 Date: January 29, 2005 - 15:36 User: dries - Moved the feature menu. ---------------------------------------------------------------------- File: /translations/it/profile-module.po 1.6 Date: January 29, 2005 - 14:07 User: michelef Drupal 4.5.2 translation; complete. ---------------------------------------------------------------------- File: /modules/blogroll/blogroll.module 1.7 /modules/blogroll/INSTALL.txt 1.3 Date: January 29, 2005 - 10:37 User: grantbow * Added editing of personal blogrolls and weights. Enabled community blogrolling. Updated INSTALL.txt ---------------------------------------------------------------------- File: /theme-engines/phptemplate/phptemplate.engine 1.16 /themes/adc/adc.theme 1.16 /themes/goofy/goofy.theme 1.15 /themes/interlaced/interlaced.theme 1.19 /themes/marvinclassic/marvinclassic.theme 1.3 /themes/slurpee/slurpee.theme 1.18 /themes/sunflower/sunflower.theme 1.22 /themes/unconed/unconed.theme 1.12 Date: January 29, 2005 - 10:17 User: tdobes update for changes made in #13907 ---------------------------------------------------------------------- File: /modules/privatemsg/privatemsg.module 1.41 /modules/subscriptions/subscriptions.module 1.28 Date: January 29, 2005 - 10:11 User: tdobes update for changes made in #13907 ---------------------------------------------------------------------- File: /modules/subscriptions/subscriptions.module 1.22.2.4 DRUPAL-4-5 Date: January 29, 2005 - 09:38 User: tdobes Fixes for #16129 #15731 #15055 ---------------------------------------------------------------------- File: /modules/subscriptions/subscriptions.module 1.27 Date: January 29, 2005 - 09:36 User: tdobes Fixes for #16129 #15731 #15055 ---------------------------------------------------------------------- File: /modules/subscriptions/subscriptions.module 1.26 Date: January 29, 2005 - 08:57 User: tdobes minor code style changes ---------------------------------------------------------------------- File: /modules/upload.module 1.21 Date: January 29, 2005 - 08:31 User: dries - Moved the upload settings to 'admin/settings'. ---------------------------------------------------------------------- File: /modules/moblog/moblog.module 1.4 Date: January 29, 2005 - 07:58 User: javanaut Updating the node/view/$nid to more modern nod/$nid syntax. ---------------------------------------------------------------------- File: /modules/bookreview/bookreview.css 1.2 /modules/bookreview/bookreview.module 1.13 /modules/bookreview/bookreview.mysql 1.4 /modules/bookreview/bookreview.pgsql 1.2 /modules/bookreview/CHANGELOG 1.9 /modules/bookreview/INSTALL 1.3 /modules/bookreview/README.txt 1.2 Date: January 29, 2005 - 05:20 User: jeremy sync with latest version ---------------------------------------------------------------------- File: /modules/bookreview/bookreview.css 1.1.2.1 DRUPAL-4-5 /modules/bookreview/bookreview.module 1.11.2.1 DRUPAL-4-5 /modules/bookreview/bookreview.mysql 1.3.2.1 DRUPAL-4-5 /modules/bookreview/bookreview.pgsql 1.1.2.1 DRUPAL-4-5 /modules/bookreview/CHANGELOG 1.8.2.1 DRUPAL-4-5 /modules/bookreview/INSTALL 1.1.4.2 DRUPAL-4-5 /modules/bookreview/README.txt 1.1.2.1 DRUPAL-4-5 Date: January 29, 2005 - 05:13 User: jeremy - bookreview.module: o put bookreview.css into seperate configurable file (issue #15327) o filter type configurable per-node (issue #15701) o filters don't strip div and span tags (issue #15701) o added "price" (issue #15161) o convert "copyright" and "pages" from int to varchar (issue #14954) - bookreview.mysql: o added "price" column o convert "copyright" and "pages" from int to varchar - bookreview.pgsql: o add PostgreSQL support (issue #14955) ---------------------------------------------------------------------- File: /modules/bookreview/INSTALL 1.1.4.1 DRUPAL-4-5 Date: January 29, 2005 - 03:49 User: jeremy sync with head, fix INSTALL to include database name ---------------------------------------------------------------------- File: /modules/workflow/workflow.module 1.5.2.5 DRUPAL-4-5 Date: January 29, 2005 - 03:47 User: jvandyk fix removal of action instances, eliminate use of arg() ---------------------------------------------------------------------- File: /modules/workflow/workflow.module 1.10 Date: January 29, 2005 - 03:32 User: jvandyk fix removal of action instances, eliminate use of arg() ---------------------------------------------------------------------- File: /modules/bookreview/INSTALL 1.2 Date: January 29, 2005 - 03:05 User: jeremy fix bug #16367: include database name in INSTALL example ---------------------------------------------------------------------- File: /sandbox/javanaut/nodeattachment/nodeattachment.module 1.1 /sandbox/javanaut/nodeattachment/nodeattachment.mysql 1.1 Date: January 29, 2005 - 01:02 User: javanaut Initial import. Yet another attachment module, this time node-to-node and the relationships between node types can be managed and stored in a database table. Useful if you want to be able to dredge up reports using the relationships. ---------------------------------------------------------------------- File: /translations/it/filter-module.po 1.6 Date: January 29, 2005 - 00:51 User: michelef Drupal 4.5.2 translation; help to be translated ---------------------------------------------------------------------- File: /translations/it/drupal-module.po 1.5 Date: January 29, 2005 - 00:04 User: michelef Drupal 4.5.2 translation; complete. ---------------------------------------------------------------------- File: /modules/upload_indexer/upload_indexer.module 1.2 Date: January 28, 2005 - 23:29 User: weitzman refactoring to allow for mime magic or file - mime type detection. will later support file extension based mapping ----------------------------------------------------------------------

1 0

[drupal-devel] [feature] QUICKFEATURE: allow different marker types
by Goba 30 Jan '05

30 Jan '05

Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Goba Reported by: Goba Updated by: Goba Status: patch Attachment: http://drupal.org/files/issues/Drupal-allow-different-markers.patch (4.21 KB) This simple and straightforward patch adds the ability to define different types of markers (while retaining the old default behaviour of the new and required markers to look the same). Someone with enough time on his hands might be able to partition the new marker to a real new marker and a changed marker (since node_is_new() returns TRUE even if nodes changed, and not only when they are new). This is the base on which the new patch can be worked though. Goba -- View: http://drupal.org/node/16253 Edit: http://drupal.org/project/comments/add/16253

6 19

[drupal-devel] Re: [drupal:dries] /modules tracker.module
by Steven Wittens 30 Jan '05

30 Jan '05

>Modified files: > /modules tracker.module > >Log message: > - I had to use DISTINCT for the tracker.module's SQL queries. > > Doesn't the pager query need to be updated too? I think they should be SELECT COUNT(DISTINCT(n.nid)) ... - $sql = 'SELECT n.nid, n.title, n.type, n.changed, n.uid, u.name, l.last_comment_timestamp AS last_post, l.comment_count FROM {node} n INNER JOIN {node_comment_statistics} l ON n.nid = l.nid INNER JOIN {users} u ON n.uid = u.uid LEFT JOIN {comments} c ON n.nid = c.nid AND (c.status = 0 OR c.status IS NULL) WHERE n.status = 1 AND (n.uid = %d OR c.uid = %d) ORDER BY last_post DESC'; + $sql = 'SELECT DISTINCT(n.nid), n.title, n.type, n.changed, n.uid, u.name, l.last_comment_timestamp AS last_post, l.comment_count FROM {node} n INNER JOIN {node_comment_statistics} l ON n.nid = l.nid INNER JOIN {users} u ON n.uid = u.uid LEFT JOIN {comments} c ON n.nid = c.nid AND (c.status = 0 OR c.status IS NULL) WHERE n.status = 1 AND (n.uid = %d OR c.uid = %d) ORDER BY last_post DESC'; $sql = db_rewrite_sql($sql); $sql_count = 'SELECT COUNT(DISTINCT(n.nid)) FROM {node} n LEFT JOIN {comments} c ON n.nid = c.nid AND (c.status = 0 OR c.status IS NULL) WHERE n.status = 1 AND (n.uid = %d OR c.uid = %d)'; $sql_count = db_rewrite_sql($sql_count); $result = pager_query($sql, 25, 0, $sql_count, $uid, $uid); } else { - $sql = 'SELECT n.nid, n.title, n.type, n.changed, n.uid, u.name, l.last_comment_timestamp AS last_post, l.comment_count FROM {node} n INNER JOIN {users} u ON n.uid = u.uid INNER JOIN {node_comment_statistics} l ON n.nid = l.nid WHERE n.status = 1 ORDER BY last_post DESC'; + $sql = 'SELECT DISTINCT(n.nid), n.title, n.type, n.changed, n.uid, u.name, l.last_comment_timestamp AS last_post, l.comment_count FROM {node} n INNER JOIN {users} u ON n.uid = u.uid INNER JOIN {node_comment_statistics} l ON n.nid = l.nid WHERE n.status = 1 ORDER BY last_post DESC'; $sql = db_rewrite_sql($sql); $sql_count = 'SELECT COUNT(n.nid) FROM {node} n WHERE n.status = 1'; $sql_count = db_rewrite_sql($sql_count); Steven

1 0

[drupal-devel] [task] Put revisions in their own table
by killes 29 Jan '05

29 Jan '05

Project: Drupal Version: cvs Component: node system Category: tasks Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org Status: patch Attachment: http://drupal.org/files/issues/revisions_7.patch (55.69 KB) Sorry, that was the old version, this is the right one. killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ May 5, 2004 - 17:25 : killes(a)www.drop.org Currently all node revisions are stored in a serialized field in node.table and retrieved for _each_ page view although they are rarely needed. However, we have agreed that serializing data is bad and that we should try to keep the memory foot print pf Drupal small. Therefore I propose to create a separate revisions table which would be in principle identical to the node table, only that it could have several old copies of the same node. Extra data added by other modules could be added in a serialized field unless we find a better solution. ------------------------------------------------------------------------ May 5, 2004 - 18:06 : jhriggs I too think the serialized approach is less than desirable, but here's an alternative. This would likely take some considerable rework in core and contrib, but the following is how we handle similar types of situations in our databases at work. It is more elegant that a separate table, and avoids the (almost exact) duplication of a table. Instead of separate tables, keep all revisions of nodes in the node table as follows: * add field: active (0/1 or Y/N) * add field: revision * every revision of a node is stored in the node table; however, only one revision can be active at any given time * nid can no longer be unique -- primary/unique key becomes (nid, active) * any time a node is loaded, updated (without revision), etc., the active version is used. Thoughts? ------------------------------------------------------------------------ May 5, 2004 - 18:57 : killes(a)www.drop.org I am not opposed to your scheme, but I want to stress the following: * Duplicating a table's structure is not bad (IMHO) as long as the content is different. * having two tables will allow us to have a rather small node table. This is (maybe) a performance gain. ------------------------------------------------------------------------ May 5, 2004 - 19:37 : jhriggs I don't necessarily think that duplicating a table's structure is _bad_. It just seems to be wasteful and a pain to maintain. (Every change to the node table is made twice...easy to do, but also easy to miss perhaps.) As for performance, as long as nid and the active indicator are indexed, there shouldn't be any performance loss. Also, archiving an old version when making a new revision will be much simpler: just change the active indicator rather than copying an entire node to another table (and ensuring everything gets copied...again a potential maintainance issue). To be honest, I would just like to see the serialized data go away, regarless of what approach is taken. ------------------------------------------------------------------------ July 30, 2004 - 20:49 : Nick Nassar Attachment: http://drupal.org/files/issues/Drupal-Improved_Revision_Schema_07-30-2004.p… (10.47 KB) I'm interested in using Drupal for a large scale wiki-type project. In order to do this, I need revisions to be in their own table. Attached is a patch to do just that. Most of the changes are pretty self explanatory. Spreading out node data across two tables meant that I had to add database functions to do locking/transactions. Without this, race conditions in which the database becomes corrupted are possible. ------------------------------------------------------------------------ July 30, 2004 - 20:54 : Nick Nassar Oh yeah... The patch is a diff against Drupal CVS ------------------------------------------------------------------------ July 31, 2004 - 01:00 : Anonymous Gerhard speaking. Nick, thanks a lot for your nice patch! It saves me a great deal of labour. I looked through it and immediately liked it. You not only put the old revisions into a new table but also the current one. Do you have an estimate how much more expensive the additional join is? Besides a few minor coding style issues I found a major one: Just a few hours before you uploaded your patch JonBob's node access patch hit core. That means your patch won't apply anymore as all the queries you change have been changed. Can I bug you to update your patch? ------------------------------------------------------------------------ July 31, 2004 - 02:11 : Anonymous Also I think that your upgrade path loses existing revisions. ------------------------------------------------------------------------ July 31, 2004 - 03:39 : drumm I think this is the proper way to do things. No columns are duplicated, there is no serialized data, and only the fields that are logically revised are stored. Nothing jumped out at me as a way to have my node modules be able to keep a table of revisions of additional fields. I'm guessing this could be done within the confines of _insert and _update. Assuming the upgrade path works and modules can extend it I give it a +1. ------------------------------------------------------------------------ July 31, 2004 - 15:40 : Nick Nassar It figures that just as I finish a big patch, another patch comes along and breaks it. Oh well, it should be a pretty easy to fix. I'll work on it. Fixing the upgrade path to keep revisions should be fairly painless. I found another issue that needs to be fixed before this patch gets merged. There format of a node needs to be stored for each revision. Otherwise, for modules that store a format for the nodes, such as page and book, if you write one revision in PHP and the next in HTML, the PHP revision will be displayed as HTML. This is part of a larger issue of how node modules should store revisions of additional fields. I think each module that wants to do this should create another table with (nid, revid) as the primary key. Just as when they want to add fields to a node they create another table with nid as the primary key. As far as performance goes, for sites that make heavy use of revisions, an extra join on primary keys is going to be a lot faster than grabbing all of the revisions from that database everytime. We would need to run benchmarks to determine is the overall difference in speed is for an average site is a gain or a loss. I'm guessing it's very minor either way. ------------------------------------------------------------------------ August 23, 2004 - 14:55 : Nick Nassar Attachment: http://drupal.org/files/issues/Drupal-Improved_Revision_Schema_08-23-2004.p… (10.92 KB) Here's an updated patch against CVS that puts revisions in their own table, provides an upgrade path, and fixes the format related bugs in the last patch. Hopefully, this can make it into CVS as soon as the freeze is over. ------------------------------------------------------------------------ August 23, 2004 - 15:10 : moshe weitzman Interesting patch ... drumm's question is still outstanding. how do modules store revisions of their fields? Are they expected to manage this on their own? Thats not how it works today. As an aside, i am seeing profile_ fields in my node.revisions column. One could argue that those need not be saved. They pertain to the node author, not to the node itself. ------------------------------------------------------------------------ August 23, 2004 - 17:14 : Nick Nassar Having modules be responsible for storing revisions of their own fields is a side-effect of storing revision data in tables. There's really no way around it. However, revisions generally don't make sense for node types that don't have PHP/HTML content, such as polls. I think it's going to be a pretty rare scenario for a new node type to want another field to change per-revision, so it's a pretty good trade-off. Storing fields that shouldn't be part of revisions, such as the profile_ fields, is a side-effect of storing revisions as serialized objects. Applying this patch will free up that wasted space. :) ------------------------------------------------------------------------ August 23, 2004 - 18:20 : Anonymous There should be a hook that let's the module choose whether it supports history. This way a module author can prevent the user from doing something that may break his module or just cause undefined behavior. If the module doesn't support history then don't let the user/admin choose to add history to nodes of that type. Craig ------------------------------------------------------------------------ August 23, 2004 - 20:23 : Nick Nassar I agree, there should be an API change to make specifying support for revisions easier. In the interests of keeping patches small and keeping to one change per patch, I think the API change should be a separate issue. A sort of ad-hoc API to decide whether or not a module supports revisions by default already exists. Instead of having a hook, modules set the default value of the "Create new revision" field in the edit form. The admin can change this option in admin/node/configure/defaults. This patch doesn't change that. Revisions are broken for node types that have their own database structure, like polls, even when storing them as serialized objects. This patch doesn't change that, either. ------------------------------------------------------------------------ October 26, 2004 - 03:35 : moshe weitzman I'm guessing that someone is going to have to demonstrate that this patch performs as well as current drupal before it gets comitted. i think this patch is a few benchmarks from being comitted. ------------------------------------------------------------------------ October 27, 2004 - 02:04 : Nick Nassar Attachment: http://drupal.org/files/issues/Drupal-Improved_Revision_Schema_10-26-2004.p… (11 KB) I ran some really unscientific benchmarks, and it looks like this patch has a negligible affect on performance. I used apache bench and the database from theregular.org, which doesn't contain any revisions (worst case scenario for this patch) and contains several hundred nodes. Both the patched and unpatched versions hovered between 2.36 and 2.38 requests per second. The command I used was: ab -n50 -C 'PHPSESSID=b01a9f92880ef215b0ed6f1314a5eba2' http://192.168.0.100/ An updated patch that should apply to CVS is attached. ------------------------------------------------------------------------ October 27, 2004 - 02:05 : Nick Nassar I ran some really unscientific benchmarks, and it looks like this patch has a negligible affect on performance. I used apache bench and the database from theregular.org, which doesn't contain any revisions (worst case scenario for this patch) and contains several hundred nodes. Both the patched and unpatched versions hovered between 2.36 and 2.38 requests per second. The command I used was: ab -n50 -C 'PHPSESSID=b01a9f92880ef215b0ed6f1314a5eba2' http://192.168.0.100/ An updated patch that should apply to CVS is attached. ------------------------------------------------------------------------ October 27, 2004 - 02:05 : Nick Nassar Attachment: http://drupal.org/files/issues/Drupal-Improved_Revision_Schema_10-26-2004.p… (11 KB) I ran some really unscientific benchmarks, and it looks like this patch has a negligible affect on performance. I used apache bench and the database from theregular.org, which doesn't contain any revisions (worst case scenario for this patch) and contains several hundred nodes. Both the patched and unpatched versions hovered between 2.36 and 2.38 requests per second. The command I used was: ab -n50 -C 'PHPSESSID=b01a9f92880ef215b0ed6f1314a5eba2' http://192.168.0.100/ An updated patch that should apply to CVS is attached. ------------------------------------------------------------------------ November 15, 2004 - 06:05 : elias1884 please overthink the revision system default workflow as well. don't look at the revision system as an isolated system but as a part of the whole workflow system! if you combine revisions with the moderation queue the most logic default workflow would be like that: auth user creates node (revision #0) admin approves the node (status = 1, moderation = 0) => node publicly available auth user finds typo and changes node (revision #1, status = 0, moderation = 1) ------- what happens at that point at the moment is, that the node is not accessible anymore at all until the new revision is approved by admin. of course the new revision should not go online until reviewed and approved, this is absolutely correct, but there is no reason to not take the old revision offline, since it was already approved and should therefore be online until the new revision is approved. it is not practical if a node disappears only because the author corrected a typo. ------- admin approves the node (status = 1, moderation = 0) eventhough I first thought a plain boolean active field would not be capable of providing that functionality if finally came to the conclusion, that it can. The only thing to do is to not set that bit, when a new revision is created, but when it is approved (in case moderation is activated under default workflow). Every revision should have its own moderation, status and active field and on approval they are set like this (status=1, moderation=0, active=Y). When you wanna rollback to an old revision, you can chose between all revisions that already have the moderation bit set back to 0 again and the published to 1. There should be an extra permission for rollback! another concern that I have about the default workflow is, that users can't see the content, they have just created, when moderation is enabled. Eventhough, there is a big fat "submission accepted" presented after submissions, unexperienced users tend to question the information those stupid tincans give them, if they can't find their content afterwards. Many users are really lazy bastards and they don't even read the status messages. The best feedback about whether his story was submitted successfully or not of course is, if he can find the story somewhere on the site, maybe with a status message on top of it, mentioning, that the content is currently not publicly available since it has not been approved yet. there should be a my content section under my account, like somebody is trying to do with the workspace module I guess. so my suggestion is to make (status=0, moderation=1) still available for the creator under a my content section somewhere! ------------------------------------------------------------------------ November 24, 2004 - 05:21 : Nick Nassar I agree. The current workflow for moderation queues and revisions needs to change, but this patch isn't the place for it. The patch is already too big, and it only does the backend stuff. Instead of adding more to this patch and making it take even longer to get into core, would you mind creating a new issue for your UI suggestions, so the those changes can be added as a separate patch? Thanks, Nick ------------------------------------------------------------------------ December 11, 2004 - 13:26 : Dries This patch is _much_ needed so I'd love to see someone revive it. In order for this patch to be accepted, the following needs to be done: Update this patch to CVS HEAD. Rename revid to vid. Rename node_rev to node_revisions. Rename node_rev.changed to node_revisions.timestamp. Rename $rnode to $revision. Fix the coding style to match Drupal's: proper spacing, single quotes where possible, proper variable names. Benchmark this patch with a large database with enough revisions. I'd be happy to benchmark this on my local copy of the drupal.org database. The book.log field should probably move to the node_revisions table. This can be done in a separate patch. Investigate whether transactions are well-supported. ------------------------------------------------------------------------ December 13, 2004 - 01:25 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/Drupal-Improved_Revision_Schema_10-26-2004-r… (11.02 KB) I've worked a bit on the patch (coding style issues as mentioned by Dries). One thing I noticed is that the patch uses REPLACE. IIRC this needs to be chagned to "UPDATE, if fail INSERT" for pgsql compatibility. Nick, are you still interested in working on that patch? I'd like to know how it works on your site and work on getting it into core. ------------------------------------------------------------------------ December 13, 2004 - 13:33 : Dries Gerhard: your patch does not apply. ------------------------------------------------------------------------ December 13, 2004 - 18:10 : killes(a)www.drop.org Yes, I know, that was the same version as I mailed to you earlier. ------------------------------------------------------------------------ December 13, 2004 - 22:02 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/revisions.patch (52.96 KB) Ok, upüdated the patch to cvs. ------------------------------------------------------------------------ December 14, 2004 - 09:58 : Dries Some more comments: db_begin_transaction() and db_end_transaction() do not belong in database.inc, but in database.mysql.inc and database.pgsql.inc respectively. The node module calls node_revisionsision_list() which is not defined. (Fxed that on my local copy.) Do db_begin_transaction() and db_end_transaction() deprecate Jeremy's table locking patch? The upgrade path assigns the wrong user ID to each revision. The upgrade path assigns the wrong date to each revision (that or a node's revision page shows the wrong usernames/dates). The coding style needs a bit of work, but we can worry about that later. ------------------------------------------------------------------------ December 14, 2004 - 18:34 : Nick Nassar If you need any help getting those things fixed, just let me know. ------------------------------------------------------------------------ December 14, 2004 - 18:50 : Nick Nassar How this relates to Jeremy's node locking patch: There was lots of discussion, and node locking was decided against because from an end user point of view you never want a node to be locked. He's now advocating for a much simpler patch that warns users if their changes will overwrite someone elses. That patch still has a race condition, which might be fixed using db_begin_transaction(). http://drupal.org/node/6025 ------------------------------------------------------------------------ December 14, 2004 - 23:26 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/revisions_0.patch (55.96 KB) Here is an updated patch that tries to address Dries concerns. ------------------------------------------------------------------------ December 15, 2004 - 09:32 : Dries Attachment: http://drupal.org/files/issues/revisions-bug.png (76.06 KB) It didn't fix the aforementioned bugs. See attached screenshot. ------------------------------------------------------------------------ January 6, 2005 - 21:15 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/revisions_1.patch (51.77 KB) Ok, here is a new version. Dries and myself worked hart at it, so please have a look. what is still missing - database upgrades for the core modules with an own table - contrib modules need an upgrade too. - do we need nid and vid in both the node and the node_revisions table? - the amount of sql queries means a good stress testing for large databases. ------------------------------------------------------------------------ January 19, 2005 - 22:43 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/revisions_2.patch (49.49 KB) Here is an updated patch. We discussed to keep the current title in node module and also in the revisiosn table. This is content duplication but will save many joins as many queries only need the title of a node. Discussion is welcome. ------------------------------------------------------------------------ January 20, 2005 - 00:33 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/revisions_3.patch (29.93 KB) I've implemented the aforementioned solution. This makes the patch much smaller. The patch now also removes taxonomy_node_has_term() which wasn't used anywhere. I'd really apprciate if some people could test drive the patch. It will be another huge improvement for 4.6. ------------------------------------------------------------------------ January 20, 2005 - 01:05 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/revisions_4.patch (30 KB) Another revision. Steven didn't like my literal $node->vid in queries. ------------------------------------------------------------------------ January 20, 2005 - 02:10 : killes(a)www.drop.org - database upgrades for the core modules with an own table - contrib modules need an upgrade too. - do we need nid and vid in both the node and the node_revisions table? - the amount of sql queries means a good stress testing for large databases. These issues are still open, btw. Especially the first one needs to be tackled. ------------------------------------------------------------------------ January 25, 2005 - 21:11 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/revisions_5.patch (51.13 KB) Here is a patch that has the database tables updated for forum, book, and page module. ------------------------------------------------------------------------ January 29, 2005 - 23:55 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/revisions_6.patch (49.18 KB) Yet another update to keep it working with head. The patch now also removes the table definitons for the page table. -- View: http://drupal.org/node/7582 Edit: http://drupal.org/project/comments/add/7582

1 0