January 2005 - Development - lists.drupal.org

RE: [drupal-devel] Module Review: spam_mtblacklist
by D. Moonfire 28 Jan '05

28 Jan '05

I had a query, loosely related to this. I had this patch I was working on (mainly because it led to something I think would be very useful) that would allow a module to indicate if it had a requirement that was not being fulfilled (such as another activated module, a PHP library, or my personal problem, table structures). Since I haven't had any experience with adding patches to Drupal, I was lurking in the mailing list to get a feel for it. Would it make sense to actually code up this? The basic idea was to create a hook (preload?) that is called only on the module selection page and only for activated modules. If the hook returns an error (I was thinking an array of strings error messages for translation fun), the module is automatically deactivated and a message is displayed. As I original saw it: spam_mtblacklist_preload() { if (!module_exists("spam")) { return array("Requires the 'spam' module to be active."); } } I also thought it would be useful for the image module to precheck for the PHP libraries or functions. Or for the taxonomy_access module to make sure the patch is put in before it is activated. (Just ideas.) Then, when the module is selected, it would automatically be unselected with an error message. This is still a rough idea (i.e. I haven't finished the code) since I'm a strong believer in implementing ideas for workability before posting feature requests, but is this something that would both fit somewhat into the Drupal framework and resolve this problem? Cheers, Dylan On Thu, 2005-01-27 at 22:48 +0000, Michael Jervis wrote: > Jeremy agreed it should be done as a separate module: > > >> I've been thinking, I intend to implement this as a new module that > >> requires the spam module and works with it to keep the code modular > >> and separate. I think this is the right way to go as it allows the > >> functionality to be totally removed if people don't want it. > > > >I agree it should be a seperate module. > > Sadly drupal's contrib system doesn't allow to distribute them together. (I > don't think)

2 1

[drupal-devel] [PATCH] pager.inc
by Remco Brink 28 Jan '05

28 Jan '05

Hi, small patch for pager.inc, which seems to have lost a closing div-tag during its last update. regards, Remco -- Remco B. Brink -- DJ / BW GS / CDTT eating bandwith for breakfast at http://rc6.org

2 1

Re: [drupal-devel] Module Review: spam_mtblacklist
by Gerhard Killesreiter 28 Jan '05

28 Jan '05

On Thu, 27 Jan 2005, Michael Jervis wrote: > Contributions/modules/spam_mtblacklist > > Adds to the spam module, one new field in spam_custom, provides import and > updates of spam blacklists from the MT Blacklist project. Since the module is apparently only usefull together with the spam module it would be nice if it could either be integrated or at least distributed with Jeremy's spam module. This way we would avoid the "yet another module" thing. Cheers, Gerhard

4 4

Re: [drupal-devel] [feature] Taxonomy Cloud
by Boris Mann 28 Jan '05

28 Jan '05

On Wed, 26 Jan 2005 23:39:27 -0800, Dan Robinson <dan(a)civicactions.com> wrote: Please see <dev.civicactions.net/?q=node/114> for my > initial write up of the "Taxonomy Cloud". This is something that is a > deliverable for CivicGroups and we will begin coding early next week. > Please comment at <dev.civicactions.net/?q=forum/34> I get errors when I try to login with a Drupal ID. I would recommend using "Easy News Topics" (ENT) [1] for this. It was discussed (briefly) on Drupal.org [2] quite some time ago. This does require RSS 2.0, but that is something that we need to implement in any case. Paolo's been talking [3] about it lately again, too (it sort of intersects with Technorati tags, but don't get me started on that). [1] http://matt.blogs.it/specs/ENT/1.0/ [2] http://drupal.org/node/1655 [3] http://paolo.evectors.it/ -- Boris Mann http://www.bryght.com

3 2

[drupal-devel] [feature] Proposed change to menu.inc that would allow modules to create custom menus
by andremolnar 28 Jan '05

28 Jan '05

Project: Drupal Version: cvs Component: menu system Category: feature requests Priority: normal Assigned to: andremolnar Reported by: andremolnar Updated by: andremolnar Status: patch JonBob, I'd be happy to work on a solution with you. Right now what I had to do in the proposed changes to book was build functions to insert data into the {menu} table by hand since there was no other handler available (e.g. hook_menu). And proposing this MENU_MODULE_MENU type was the only way I could think of to clearly distinguish where these new menu items were coming from (i.e. a module doing an insert into the menu system outside of the normal chanels). Would the creation of a new hook_ be in order. Perhaps hook_menu_block? While it would be a confusing hook name - it is does describe the desired outcome. i.e. Output from hook_menu_block would be inserted into the menu system and a block would be created for that menu. But even then I think these new menu types (or something similar) would have to be employed in some way. andre andremolnar Previous comments: ------------------------------------------------------------------------ January 6, 2005 - 07:13 : andremolnar Attachment: http://drupal.org/files/issues/menu_inc_2.patch (2.65 KB) See http://drupal.org/node/15153 and http://drupal.org/node/14120 for discussion on this proposed change. Patch is included here for further discussion (with the changes suggested by Dries). A patch is forthcoming for topics discussed in http://drupal.org/node/14120 which would make use of this patch. Status to be changed to patch later if there are no objections following discussion. andre ------------------------------------------------------------------------ January 8, 2005 - 21:16 : andremolnar Patch making use of this is now added to http://drupal.org/node/14120. andre ------------------------------------------------------------------------ January 10, 2005 - 07:29 : andremolnar Just realising that the rules for setting status to patch would allow this to be patch since its technically ready to go. (and it might actually get noticed if its on the dev list and patch queue). andre ------------------------------------------------------------------------ January 11, 2005 - 06:47 : Dries I'm OK with this patch but won't commit it yet until the book module patch is ready. ------------------------------------------------------------------------ January 20, 2005 - 02:07 : andremolnar I've uploaded the latest version of the patch to book. http://drupal.org/node/14120 andre ------------------------------------------------------------------------ January 27, 2005 - 17:38 : JonBob I'd prefer a solution that allowed modules to declare such menu items using the menu hook, but haven't been able to come up with such a solution. I'm okay with this approach until such time as someone has a brilliant idea to make the menu hook more powerful. -- View: http://drupal.org/node/15198 Edit: http://drupal.org/project/comments/add/15198

1 0

[drupal-devel] [bug] "my account" menu item oddities
by Boris Mann 28 Jan '05

28 Jan '05

Project: Drupal Version: 4.5.0 Component: menu system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: jasper Updated by: Boris Mann Status: patch The same issue comes up with other menus that include the user ID (there are a couple, can't recall exactly which). While user/me is interesting, it would then be inconsistent with things like blog/UID and blog/UID/feed. Adding something like [uid] to menu creation might make menu code more complex, but should work. Boris Mann Previous comments: ------------------------------------------------------------------------ November 19, 2004 - 13:03 : jasper 1. "my account" link can not be given "weight" 2. If edited, "my account" link behaves strangely: appears as separate menu in admin screen, disappears from navigation menu, etc. 3. Subitems can't be added under my account, or, strange things happen if you try to do that. ------------------------------------------------------------------------ November 25, 2004 - 03:36 : jasper Reproduce the error: 1. Assign sub-menus to "my account" menu item 2. edit "my account" menu item - capitalize "My Account" result: 1. sub-menus disappear from navigation block 2. "My Account" becomes separate Menu at the bottom of the menu administration page. I would really like to capitalize the "my account" link. Any way to do that without bugging out the menus? ------------------------------------------------------------------------ December 17, 2004 - 22:05 : jasper anybody? ------------------------------------------------------------------------ January 27, 2005 - 11:36 : JonBob Attachment: http://drupal.org/files/issues/user_13.patch (705 bytes) The "my account" menu item includes the user ID, so really cannot be customized. This is unfortunate. The attached patch corrects the mentioned bug by locking the menu item as it should be, but doesn't address the usability issue of not being able to customize the menu item. I suggest we move ahead with this patch for the 4.5 branch and, since time is short, likely 4.6. Any suggestions for how to make this item editable? I think we'd need some way to have multiple paths for a single menu item... wildcards or something. But an implementation escapes me. ------------------------------------------------------------------------ January 27, 2005 - 11:50 : Steven Perhaps we could change the path for "my account" to "user/me" or something? Link-wise it's not too hard to implement, just do "user/". ($account->uid == $user->uid ? "me" : $account->uid) or something when linking to that page. ------------------------------------------------------------------------ January 27, 2005 - 13:35 : Dries The patch did not apply cleanly against DRUPAL-4-5. I modified the patch and committed it to DRUPAL-4-5 and to HEAD. I'm leaving this issue open for a couple more days. -- View: http://drupal.org/node/13184 Edit: http://drupal.org/project/comments/add/13184

1 0

[drupal-devel] cvs log messages
by no-reply＠zind.net 28 Jan '05

28 Jan '05

File: /modules/block.module 1.151 Date: January 27, 2005 - 22:53 User: unconed Typos. ---------------------------------------------------------------------- File: /database/updates.inc 1.89 Date: January 27, 2005 - 22:50 User: dries - Patch by andre: fixed typo: type -> types. ---------------------------------------------------------------------- File: /modules/taxonomy.module 1.170 Date: January 27, 2005 - 22:47 User: dries - Consistency: 'deleted' -> 'Deleted'. ---------------------------------------------------------------------- File: /modules/spam_mtblacklist/spam_mtblacklist.module 1.1 /modules/spam_mtblacklist/spam_mtblacklist.mysql 1.1 Date: January 27, 2005 - 22:25 User: themike Import of working MT Blacklist manager. ---------------------------------------------------------------------- File: /modules/actions/actions.inc 1.3 Date: January 27, 2005 - 22:03 User: jvandyk coding standards compliance ---------------------------------------------------------------------- File: /modules/webform/README.txt 1.3 /modules/webform/webform.inc 1.4 /modules/webform/webform.module 1.31 Date: January 27, 2005 - 21:42 User: ullgren added tally analysis, patch by jnt ---------------------------------------------------------------------- File: /modules/user.module 1.434 Date: January 27, 2005 - 21:34 User: dries - Patch #13184 by JonBob: changed the 'my account' menu to a 'dynamic menu' so it can't be edited. ---------------------------------------------------------------------- File: /modules/user.module 1.407.2.11 DRUPAL-4-5 Date: January 27, 2005 - 21:32 User: dries - Patch #13184 by JonBob: changed the 'my account' menu to a 'dynamic menu' so it can't be edited. ---------------------------------------------------------------------- File: /scripts/cron-curl.sh 1.1 Date: January 27, 2005 - 21:25 User: dries - Patch #16298 by budda: added a curl-based script for grabbing cron.php. ---------------------------------------------------------------------- File: /modules/webform/webform.module 1.30 Date: January 27, 2005 - 21:12 User: ullgren changed node/view/x to node/x/view ---------------------------------------------------------------------- File: /modules/img_assist/CHANGELOG.txt 1.18 /modules/img_assist/img_assist.module 1.22 Date: January 27, 2005 - 20:01 User: mathias * Fix bug #15630 - wrong datatype error. ---------------------------------------------------------------------- File: /modules/img_assist/CHANGELOG.txt 1.8.2.8 DRUPAL-4-5 /modules/img_assist/img_assist.module 1.11.2.8 DRUPAL-4-5 Date: January 27, 2005 - 20:01 User: mathias * Fix bug #15630 - wrong datatype error. ---------------------------------------------------------------------- File: /modules/block.module 1.150 Date: January 27, 2005 - 19:55 User: unconed - Code style ---------------------------------------------------------------------- File: /modules/flexinode/flexinode.module 1.36.2.3 DRUPAL-4-5 Date: January 27, 2005 - 19:54 User: killes _cron backport from HEAD ---------------------------------------------------------------------- File: /modules/listhandler/listhandler.module 1.53.2.3 DRUPAL-4-5 Date: January 27, 2005 - 19:51 User: killes backport form HEAD ---------------------------------------------------------------------- File: /modules/listhandler/listhandler.module 1.58 Date: January 27, 2005 - 19:49 User: killes sql query fix. ---------------------------------------------------------------------- File: /database/database.mysql 1.167 /database/database.pgsql 1.103 /database/updates.inc 1.88 /modules/block.module 1.149 Date: January 27, 2005 - 19:41 User: dries - Patch #16074 by Andre Molnar: add configuration option to show blocks only on pages of certain node type. ---------------------------------------------------------------------- File: /modules/workflow/workflow.module 1.5.2.4 DRUPAL-4-5 Date: January 27, 2005 - 19:34 User: jvandyk added id tag, eliminate transition saving error ---------------------------------------------------------------------- File: /modules/workflow/workflow.module 1.9 Date: January 27, 2005 - 19:33 User: jvandyk added id tag, eliminate transition saving error ---------------------------------------------------------------------- File: /includes/pager.inc 1.40 Date: January 27, 2005 - 19:01 User: dries - Patch by Jeremy: fixed unclosed " ---------------------------------------------------------------------- File: /translations/de/aggregator-module.po 1.2.2.3 DRUPAL-4-5 /translations/de/archive-module.po 1.4.2.3 DRUPAL-4-5 /translations/de/block-module.po 1.4.2.3 DRUPAL-4-5 /translations/de/blog-module.po 1.2.2.3 DRUPAL-4-5 /translations/de/blogapi-module.po 1.2.2.3 DRUPAL-4-5 /translations/de/book-module.po 1.2.2.3 DRUPAL-4-5 /translations/de/common-inc.po 1.2.2.3 DRUPAL-4-5 /translations/de/drupal-module.po 1.2.2.3 DRUPAL-4-5 /translations/de/file-inc.po 1.3.2.3 DRUPAL-4-5 /translations/de/filter-module.po 1.2.2.3 DRUPAL-4-5 /translations/de/forum-module.po 1.2.2.3 DRUPAL-4-5 /translations/de/general.po 1.3.2.3 DRUPAL-4-5 /translations/de/locale-inc.po 1.3.2.3 DRUPAL-4-5 /translations/de/locale-module.po 1.2.2.3 DRUPAL-4-5 /translations/de/menu-module.po 1.4.2.3 DRUPAL-4-5 /translations/de/node-module.po 1.5.2.3 DRUPAL-4-5 /translations/de/path-module.po 1.2.2.3 DRUPAL-4-5 /translations/de/ping-module.po 1.2.2.1 DRUPAL-4-5 /translations/de/poll-module.po 1.2.2.3 DRUPAL-4-5 /translations/de/queue-module.po 1.2.2.3 DRUPAL-4-5 /translations/de/README.txt 1.11.2.1 DRUPAL-4-5 /translations/de/search-module.po 1.2.2.3 DRUPAL-4-5 /translations/de/statistics-module.po 1.2.2.3 DRUPAL-4-5 /translations/de/story-module.po 1.2.2.3 DRUPAL-4-5 /translations/de/system-module.po 1.2.2.3 DRUPAL-4-5 /translations/de/throttle-module.po 1.2.2.3 DRUPAL-4-5 /translations/de/upload-module.po 1.2.2.3 DRUPAL-4-5 /translations/de/user-module.po 1.2.2.3 DRUPAL-4-5 /translations/de/watchdog-module.po 1.4.2.3 DRUPAL-4-5 Date: January 27, 2005 - 18:52 User: uwe Updated the (quite outdated) translations for the Drupal 4.5 branch, i.e. merged changes from HEAD. ---------------------------------------------------------------------- File: /translations/de/forum-module.po 1.4 Date: January 27, 2005 - 18:39 User: uwe Applied (and slightly modified) the patch from Xeophin at http://drupal.org/node/16290. Thanks! ---------------------------------------------------------------------- File: /modules/img_assist/CHANGELOG.txt 1.17 /modules/img_assist/img_assist.module 1.21 /modules/img_assist/README.txt 1.8 Date: January 27, 2005 - 18:28 User: mathias * Discontinued support for the outdated and buggy image.module found at http://drupal.org/project/image. Instead Img_assist now uses James Walker's improved version of image module which uses Drupal's file api. It's slated to replace the old one. ---------------------------------------------------------------------- File: /translations/it/taxonomy-module.po 1.9 Date: January 27, 2005 - 18:07 User: michelef Drupal 4.5.2 translation; complete. ---------------------------------------------------------------------- File: /modules/flexinode/CHANGELOG 1.25 /modules/flexinode/flexinode.module 1.44 Date: January 27, 2005 - 18:07 User: killes Added _cron hook. ---------------------------------------------------------------------- File: /translations/it/general.po 1.8 Date: January 27, 2005 - 18:06 User: michelef Drupal 4.5.2 translation; complete. ---------------------------------------------------------------------- File: /modules/flexinode/flexinode.module 1.43 Date: January 27, 2005 - 18:01 User: killes Remove some PHP notices. ---------------------------------------------------------------------- File: /sandbox/walkah/image/45/image.imagemagick.inc 1.2 /sandbox/walkah/image/45/image.module 1.3 /sandbox/walkah/image/image.imagemagick.inc 1.6 /sandbox/walkah/image/image.module 1.12 Date: January 27, 2005 - 17:44 User: mathias * Tidy up the path parameter for file_exists() in image.imagemagick.inc. * Add input format selector to the 'description' form field. * image_view() should call node_prepare(). * When displaying a single node, make sure the 'full' image is rendered instead of 'preview'. ---------------------------------------------------------------------- File: /includes/pager.inc 1.39 Date: January 27, 2005 - 15:53 User: dries - Patch by Jeremy: made the diffs more meaningful. ---------------------------------------------------------------------- File: /modules/fckeditor/README.txt 1.4 Date: January 27, 2005 - 15:40 User: latpro copyright updated ---------------------------------------------------------------------- File: /modules/node.module 1.452 Date: January 27, 2005 - 14:45 User: dries - Patch #6025 by Jeremy: avoid data to get lost when two users are editing a node at the same time. ---------------------------------------------------------------------- File: /CHANGELOG.txt 1.61 Date: January 27, 2005 - 14:33 User: dries - A small updates ---------------------------------------------------------------------- File: /includes/pager.inc 1.38 Date: January 27, 2005 - 14:30 User: dries - Patch #16273 by Jeremy: improved the themability of the pager. ---------------------------------------------------------------------- File: /includes/theme.inc 1.222 /modules/comment.module 1.329 /modules/tracker.module 1.109 Date: January 27, 2005 - 12:57 User: dries - Patch #16253 by Goba: this simple and straightforward patch adds the ability to define different types of markers (while retaining the old default behaviour of the new and required markers to look the same). Someone with enough time on his hands might be able to partition the new marker to a real new marker and a changed marker (since node_is_new() returns TRUE even if nodes changed, and not only when they are new). This is the base on which the new patch can be worked though. ---------------------------------------------------------------------- File: /docs/developer/hooks/core.php 1.47 Date: January 27, 2005 - 11:44 User: goba fix menu path for settings hook ---------------------------------------------------------------------- File: Date: January 27, 2005 - 04:57 User: weitzman Description ----------------------- Indexes files which are attached to nodes. This enables content in attachments to become searchable. Prerequisites --------------------- - Your web site must not be running in PHP safe mode. Check phpinfo() to investigate this - You must have access to the file -i command in your path. This happens by default for UNIX OS. - you must have your cron job working in order to search your site Installation ----------------------- Install as usual and then complete the admin/settings/upload_indexer page. Todo ----------------------- Offer mime_magic powered alternative to 'file' command. Primarily for Windows web hosts. Credits ---------------- Sponsored by Quadstone - http://www.quadstone.com/ ---------------------------------------------------------------------- File: /modules/workspace/README.txt 1.3 /modules/workspace/workspace.module 1.10 Date: January 27, 2005 - 04:11 User: jvandyk wrap node deletion so we can get there without using POST, add validation, change permission to configure own workspace ---------------------------------------------------------------------- File: /modules/mail_archive/mail_archive.module 1.13 Date: January 27, 2005 - 03:57 User: jeremy fix cut&paste error ---------------------------------------------------------------------- File: /modules/mail_archive/CHANGELOG.txt 1.11 /modules/mail_archive/mail_archive.module 1.12 /modules/mail_archive/README.txt 1.9 Date: January 27, 2005 - 03:54 User: jeremy - mail_archive_module: o added ability to delete message (and optionally attachments) ---------------------------------------------------------------------- File: /modules/feedback/feedback.module 1.27 Date: January 26, 2005 - 23:31 User: kbahey Fixed bug where phone number/postal address/validate email checkboxes could not be set, no matter what the site admin did. See here for details: http://drupal.org/node/16250 ---------------------------------------------------------------------- File: /modules/actions/actions.module 1.2 Date: January 26, 2005 - 23:18 User: jvandyk fix config and delete links ---------------------------------------------------------------------- File: Date: January 26, 2005 - 23:18 User: latpro ---------------------------------------------------------------------- File: /modules/contact_dir/README.txt 1.3 Date: January 26, 2005 - 23:17 User: latpro ---------------------------------------------------------------------- File: /modules/workflow/workflow.module 1.5.2.3 DRUPAL-4-5 Date: January 26, 2005 - 23:10 User: jvandyk cleaner deletion of workflows, replace array_key_exists() with isset() ---------------------------------------------------------------------- File: /database/updates.inc 1.87 /modules/page.module 1.131 Date: January 26, 2005 - 23:09 User: dries - Patch #16237 by Neil: removed dead code from page.module. ---------------------------------------------------------------------- File: /modules/workflow/workflow.module 1.8 Date: January 26, 2005 - 23:07 User: jvandyk cleaner deletion of workflows, replace array_key_exists() with isset() ---------------------------------------------------------------------- File: /modules/actions/actions.inc 1.2 Date: January 26, 2005 - 23:03 User: jvandyk added action to assign user ownership to a node ---------------------------------------------------------------------- File: /modules/watchdog.module 1.121 Date: January 26, 2005 - 23:02 User: dries - Patch #16197 by Neil: removed useless watchdog "long" help. Less is more. ---------------------------------------------------------------------- File: /modules/blog.module 1.211 /modules/forum.module 1.225 /modules/node.module 1.451 /modules/story.module 1.165 Date: January 26, 2005 - 22:59 User: dries - Patch #16192 by Neil: moved the submission guidelines found in forum, story, and blog and the minimum number of words found in story and blog (blog had a slight bug) into the node module. ---------------------------------------------------------------------- File: /translations/it/statistics-module.po 1.5 Date: January 26, 2005 - 22:37 User: michelef Drupal 4.5.2 translation; automatic translation, may contain errors. ----------------------------------------------------------------------

1 0

RE: [drupal-devel] Module Review: spam_mtblacklist
by Gerhard Killesreiter 27 Jan '05

27 Jan '05

On Thu, 27 Jan 2005, Michael Jervis wrote: > ---- > Since the module is apparently only usefull together with the spam module it > would be nice if it could either be integrated or at least distributed with > Jeremy's spam module. This way we would avoid the "yet another module" > thing. > ---- > > Jeremy agreed it should be done as a separate module: > > >> I've been thinking, I intend to implement this as a new module that > >> requires the spam module and works with it to keep the code modular > >> and separate. I think this is the right way to go as it allows the > >> functionality to be totally removed if people don't want it. > > > >I agree it should be a seperate module. > > Sadly drupal's contrib system doesn't allow to distribute them together. (I > don't think) You could always put it into a subdirectory of the spam module (if Jeremy agrees). See the ecommerce module. Cheers, Gerhard

1 0

[drupal-devel] [feature] Add configuration option to show blocks only on pages of certain node type
by andremolnar 27 Jan '05

27 Jan '05

Project: Drupal Version: cvs Component: block.module Category: feature requests Priority: normal Assigned to: andremolnar Reported by: andremolnar Updated by: andremolnar Status: patch Attachment: http://drupal.org/files/issues/block_module_1.patch (8.14 KB) This patch would allow adminstrators to configure blocks to show up only pages of a specified node type. This patch is being submitted in response to feedback on the proposed changes to the book module http://drupal.org/node/14120. Feedback indicated that if the block generation associated with books is changed, administrators will still require the ability to specify that newly created book blocks behave as the existing book blocks do (i.e. only show up on book pages). This patch goes one step further and would allow an admin to show a book block (or any block) on any type of page. While independent of 14120 - this patch in conjuntion with 14120 would allow the removal of a large piece of block generation code from the book module. Comments and feedback, as always, are welcome. andre andremolnar -- View: http://drupal.org/node/16074 Edit: http://drupal.org/project/comments/add/16074

7 26

[drupal-devel] Module Review: spam_mtblacklist
by Michael Jervis 27 Jan '05

27 Jan '05

Contributions/modules/spam_mtblacklist Adds to the spam module, one new field in spam_custom, provides import and updates of spam blacklists from the MT Blacklist project. First time I've done any DB/Cron/Settings etc, in fact all I've done before is two tiny auth modules, so please, have a good look. Cheers, Mike

1 0