October 2005 - Development - lists.drupal.org

[drupal-devel] Fun with mysql grants
by Gerhard Killesreiter 24 Oct '05

24 Oct '05

Hi there! I just want to point out that as of last week we need a new database grant to run Drupal with mysql (and maybe pgsql too, no idea). Steven's search patch uses temporary tables for which you need the CREATE TEMPORARY TABLES permission. I am not sure, but I think this permission is not a default permission so we should make it clear that this permission is required in big, bold, blinking letters. And keep the flamethrower ready. Cheers, Gerhard

1 0

[drupal-devel] Problem with new form API in _upload_form
by Tim Altman 24 Oct '05

24 Oct '05

Greetings: I ran into a problem with the new form API while I was investigating a bug with file uploads. The bug is that the list attribute and description for uploaded files aren't saved. I've solved the bug with the list attribute, but I can't figure out the correct solution for the bug with file descriptions. The form in _upload_form outputs the descriptions as $node['attachments']['current']['description'] whereas the delete and list checkboxes are output as $node['remove'] and $node['list'], respectively. Descriptions are nested so deeply because the #tree attribute is set to TRUE for $form['current']['description'] in _upload_form which is returned into $form['attachments'] by upload_form. So, should upload_save expect $node['attachments']['current']['description'] or is there a way to fix this so it works as it did before? I see no reason for descriptions to be nested so deeply in the form. -- Tim Altman

1 0

[drupal-devel] Problem with drupal_get_messages()
by Gordon Heydon 23 Oct '05

23 Oct '05

Hi, I am having a problem on a site where the messages from drupal_get_messages() is not being deleted once they have displayed. I have checked and drupal_get_messages() is deleting $_SESSION, but session is not being updated to reflect the change. I am not sure why this is happening, or how I should proceed to resolve this problem. If anyone can shed some light which can help me to resolve this issue it will be most appreciated. Thanks. Gordon.

2 3

[drupal-devel] FYI: todos in comments in code in core
by Bèr Kessels 23 Oct '05

23 Oct '05

Here and there we find some todo's in core, inside comments. berub@penelope: berub@penelope:~/repository/drupal$ egrep -r -n '/(?:\/\*(?: (?!\*\/).)*|\/\/.*?)*/' * | grep TODO database/updates.inc:76: // TODO: needs PGSQL version includes/menu.inc:517: // TODO: have automatic prefixing through an installer to prevent this. modules/filter.module.orig:722: // TODO: get support for block-level radios so the <br /> is not output? modules/user.module:1073: // TODO: Is this necessary? Won't session_write() replicate this? modules/node.module:525: // TODO: this strips legitimate uses of '' also. modules/node.module:1495: // todo use a better word counting algorithm that will work in other languages Do with it what you like :) Bèr -continues learning advanced regular expressions- Kessels -- PGP ber(a)webschuur.com http://www.webschuur.com/sites/webschuur.com/files/ber_webschuur.asc PGP berkessels(a)gmx.net http://www.webschuur.com/sites/webschuur.com/files/ber_gmx.asc

1 0

[drupal-devel] copying between nodes
by vrao 23 Oct '05

23 Oct '05

Sorry, if this was a support question. Dont get responses regarding code on the other list What is the best (easiest) way to copy a nodes comments to another node. Also the files. Say I want nid 45 to have the same comments and attachments (using upload.module) as nid 100 Thanks, V

2 2

[drupal-devel] comment_moderation_form gone?
by Bèr Kessels 23 Oct '05

23 Oct '05

suddenly I miss comment_moderation_form. I ran across this when debuging the hook_link patch. Is this a form_API thing? Can anyone give me a hint how to get that little dropdown under each node back? Or did we get rid of it for other reasons? Bèr -- PGP ber(a)webschuur.com http://www.webschuur.com/sites/webschuur.com/files/ber_webschuur.asc PGP berkessels(a)gmx.net http://www.webschuur.com/sites/webschuur.com/files/ber_gmx.asc

1 0

[drupal-devel] Why is the block.module required?
by Konstantin Käfer 23 Oct '05

23 Oct '05

Hello, I just asked me why the block.module is required by drupal? I don't really see any need for it being marked as required. Konstantin Käfer

1 0

[drupal-devel] hook_links for boks: small thingies
by Bèr Kessels 23 Oct '05

23 Oct '05

Hi, I am now debugging and testing a new patch for http://drupal.org/node/18260 to allow overriding of any _links value on theme level. Basically all I do is return any linhks in a structured way. However, I have "improved" the book links. Or so I find. Id like too discuss that a littlebit outside of taht issue. My patch * removes the permissions again. IMO its very very inconsistent to add permissions for links Its a temprorary hackish solution. After my patch lands you can set per link thingies on theme level, or in a contri module. Also in book_menu these permissions are wrongly checked. So the permissions dont even work ATM! * Changed 'printer friendly version' into 'Export this book page and its sub-pages as a plain HTML page.'. Printing is done on theme level, with print CSS! The print thingy on book pages often confused my users/clients, since I made them 'print this' on every page, not just books. Please comment on this if you agree or disagree. Bèr -- PGP ber(a)webschuur.com http://www.webschuur.com/sites/webschuur.com/files/ber_webschuur.asc PGP berkessels(a)gmx.net http://www.webschuur.com/sites/webschuur.com/files/ber_gmx.asc

1 0

[drupal-devel] Is the 'upload files' permission necessary?
by neil＠civicspacelabs.org 22 Oct '05

22 Oct '05

I think the 'upload files' permission is redundant with the settings for which content types have attachments enabled and permissions for who can create those content types. -Neil

3 2

[drupal-devel] Permissions in the relations
by Bèr Kessels 22 Oct '05

22 Oct '05

Hello, Karoly (chx) had so,e issues with permissions in the relationship project. Can anyone, who has thoughts on what permissions should be in the relationship APIs comment here. Then I can publish a summary in the thread on drupal.org Questions that need answer IMO are: * should we bother at all in the relationship API or should we leave it to drupal. * If yes to above: how far do we want to go in securing permissions in relations. * Should we add complexity to the API to avoid performance loss when used together with complex permissions * Please add your own. Bèr -- PGP ber(a)webschuur.com http://www.webschuur.com/sites/webschuur.com/files/ber_webschuur.asc PGP berkessels(a)gmx.net http://www.webschuur.com/sites/webschuur.com/files/ber_gmx.asc

2 2