February 2005 - Development - lists.drupal.org

[drupal-devel] Posting permission denied on drupal.org
by Chris Cook 08 Feb '05

08 Feb '05

When I try to update an issue on drupal.org I'm getting the message "Terminated request because of suspicious input data." A new feature? I mention some drupal functions by name and I'm attaching a patch but I don't see anything terribly suspicous about this.

2 1

[drupal-devel] [task] Don't use align attribute
by drumm 08 Feb '05

08 Feb '05

Project: Drupal Version: cvs Component: user.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/user.module_13.diff (1.15 KB) So this should be classed and put in drupal.css, but it isn't particularly needed to center this operations column since all the others are not centered. drumm -- View: http://drupal.org/node/16972 Edit: http://drupal.org/project/comments/add/16972

1 0

[drupal-devel] [task] Don't document code in help text.
by drumm 08 Feb '05

08 Feb '05

Project: Drupal Version: cvs Component: system.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/system.module_0.diff (2.5 KB) Help text shouldn't be used to document hook_cron(). drumm -- View: http://drupal.org/node/16966 Edit: http://drupal.org/project/comments/add/16966

1 0

[drupal-devel] [task] Remove useless story "long" help
by drumm 08 Feb '05

08 Feb '05

Project: Drupal Version: cvs Component: story.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/story.module.diff (1.25 KB) Everything that people need to know about the story module is said elsewhere IMO. drumm -- View: http://drupal.org/node/16965 Edit: http://drupal.org/project/comments/add/16965

1 0

[drupal-devel] [task] Make posting permission more granular.
by killes 08 Feb '05

08 Feb '05

Project: Drupal Version: cvs Component: comment.module Category: tasks Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org Status: patch Yes, the patch is still needed. The patch actually removes more code from node.module than it adds. Both modules are essential to Drupal and some degree of interaction is tolerable, I think. You can still disable comment.module withou any ill effects. killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ August 29, 2004 - 07:55 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/node-access-comment.patch (5 KB) There have been requests to private forums. I think the most straightforward way to allow them is by extending the node_access hook. The attached patch tries this. It assumes that my node object caching patch got committed. Afterwards loading a node twice won't be a performance issue anymore. The patch is untested, I'd like to get feedback on the implementation. ------------------------------------------------------------------------ August 31, 2004 - 17:53 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/node-access-comment_0.patch (5.02 KB) The patch is now tested. I think this needs a better explanations: The patch isn't only for forums (which still need some kind of taxonomy permissions) but applies to all nodes. You can set individual nodes to be commentable through the _access hook. This would be helpfull for a forum where only a selected role should be allowed to post, but others should read the announcements. ------------------------------------------------------------------------ September 4, 2004 - 09:57 : killes(a)www.drop.org The patch has a small problem: We need either to move this check <?php if ($op == 'comment' && $node->comment == 2 && user_access('post comments')) { return TRUE; } ?> before the db query (and thus taking away a bit of the power from that patch) or add a grant_comment column to the node_access table: alter table node_access add grant_comment tinyint(1) unsigned NOT NULL default '0'; ------------------------------------------------------------------------ September 5, 2004 - 11:42 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/node-access-comment_0_0.patch (4.78 KB) Keeping up with CVS. I'd like to receive some feedback on the resolution of the problme mentioned above. ------------------------------------------------------------------------ September 13, 2004 - 03:25 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/module_0.patch (7.1 KB) Keeping up with cvs. Node modules should implement _access('comment'). ------------------------------------------------------------------------ September 14, 2004 - 07:38 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/commentable.patch (7.89 KB) Had forgotten blog.module ------------------------------------------------------------------------ February 5, 2005 - 01:19 : Steven Is this patch still needed? Doesn't it tie comment.module unnecessarily into node.module? -- View: http://drupal.org/node/10426 Edit: http://drupal.org/project/comments/add/10426

1 0

[drupal-devel] [task] Maintain help_upload()
by drumm 08 Feb '05

08 Feb '05

Project: Drupal Version: cvs Component: upload.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/upload.module_1.diff (2.49 KB) The upload's module help text was in bad shape. Here is a patch which edits it down to what is needed with links that actually work. drumm -- View: http://drupal.org/node/16963 Edit: http://drupal.org/project/comments/add/16963

1 0

[drupal-devel] [task] Remove page module help text.
by drumm 08 Feb '05

08 Feb '05

Project: Drupal Version: cvs Component: page.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm -Status: active +Status: patch Status should be patch. drumm Previous comments: ------------------------------------------------------------------------ February 7, 2005 - 17:10 : drumm Attachment: http://drupal.org/files/issues/page.module_2.diff (1.56 KB) The page module's long help text is a bunch of lies and then it briefly explains it's permissions. IMO it should just be taken out. I can't think of what help should be there. -- View: http://drupal.org/node/16962 Edit: http://drupal.org/project/comments/add/16962

1 0

[drupal-devel] [bug] Putting a .theme file into themes/ makes all themes not working
by Anonymous 07 Feb '05

07 Feb '05

Project: Drupal Version: cvs Component: theme system Category: bug reports Priority: critical Assigned to: chx Reported by: chx Updated by: Anonymous Status: patch While this patch would allow a theme to be placed directly in the "themes" directory, it disables the ability for that theme to use a "style.css" file, which is inconsistent. I would prefer a patch that enforces the criteria that themes MUST be placed in a SUBDIRECTORY of "themes" -- themes placed directly in the "themes" folder should be ignored... maybe we could send the admin a drupal_set_message that would tell them about the problem when visiting admin/themes too. Anonymous Previous comments: ------------------------------------------------------------------------ February 7, 2005 - 07:13 : chx Try putting a .theme file into themes/ without any subdir. Enable it (maybe just saving theme settings is enough), Nothing will work after this. To restore your site: remove the offending theme, issue an SQL: DELETE FROM {system} WHERE type='theme' and save theme settings again. ------------------------------------------------------------------------ February 7, 2005 - 07:14 : chx effects HEAD, too. ------------------------------------------------------------------------ February 7, 2005 - 12:33 : chx Attachment: http://drupal.org/files/issues/themesfix.patch (542 bytes) Here is a patch which fixes the problem. However, I do not have the feeling that this is "the" solution. Feel free to come up with something better. ------------------------------------------------------------------------ February 7, 2005 - 12:35 : chx Oops forgot to set to CVS, 'cos the fix is against HEAD. Not that 4.5.2 does not need a patch... -- View: http://drupal.org/node/16914 Edit: http://drupal.org/project/comments/add/16914

1 0

[drupal-devel] [task] Move forum settinqs to the right place
by drumm 07 Feb '05

07 Feb '05

Project: Drupal Version: 4.0.0 Component: forum.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/forum.module_0.diff (2 KB) Make it a local task, not a settings page. drumm -- View: http://drupal.org/node/16951 Edit: http://drupal.org/project/comments/add/16951

1 0

[drupal-devel] [bug] Fix up help module defintions
by drumm 07 Feb '05

07 Feb '05

Project: Drupal Version: cvs Component: help.module Category: bug reports Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/help.module.diff (1.53 KB) Closes an unclosed tag and makes a capitalization better. drumm -- View: http://drupal.org/node/16949 Edit: http://drupal.org/project/comments/add/16949

1 0