February 2005 - Development - lists.drupal.org

Re: [drupal-devel] forum page link lies
by Boris Mann 07 Feb '05

07 Feb '05

On Mon, 07 Feb 2005 19:18:46 +0000, Gabor Hojtsy <gabor(a)hojtsy.hu> wrote: > Who thinks these links (from forum module) are not lying? > > l(t('My forum discussions.'), "tracker/$user->uid") > l(t('Active forum discussions.'), 'tracker') > > I think they are. The links are not restricted to displaying forum > topics, so it is possible that the first page shown by the tracker does > not contain any forum topics at all (as it is with my site)... These > links are not correct... Ha. Yes, you're right. I had noticed that before, and may even have said something way back when, but I think we got stuck in "tracker filtering by node type". Which, of course, should be implemented, and the links could then be "tracker/forum/{uid}" and "tracker/forum". Unless we implement that filtering, the links should be removed completely. -- Boris Mann http://www.bryght.com

1 0

[drupal-devel] forum page link lies
by Gabor Hojtsy 07 Feb '05

07 Feb '05

Hi, Who thinks these links (from forum module) are not lying? l(t('My forum discussions.'), "tracker/$user->uid") l(t('Active forum discussions.'), 'tracker') I think they are. The links are not restricted to displaying forum topics, so it is possible that the first page shown by the tracker does not contain any forum topics at all (as it is with my site)... These links are not correct... Goba

1 0

[drupal-devel] [bug] Error while deleting user
by budda 07 Feb '05

07 Feb '05

Project: Drupal Version: cvs Component: user.module Category: bug reports Priority: normal Assigned to: chx Reported by: chx Updated by: budda Status: patch I also note that you can hit the 'delete' button as much as you want and the account will not be deleted. I see that you are required to first mark the account status to "block". Actually giving user feedback to say this would be handy. Currently clicking the 'delete' button just refreshes the user form. Maybe some javascript could be used to disable the 'delete' button until the status == 0 (blocked) ? Definitely increase usability then. Is this a related bug or a new issue? budda Previous comments: ------------------------------------------------------------------------ January 12, 2005 - 19:44 : chx Attachment: http://drupal.org/files/issues/user_delete_0.patch (875 bytes) Type error Date Wednesday, January 12, 2005 - 19:17 User chx Location /cvs/drupal/?q=user/2/edit Message array_keys(): The first argument should be an array in /var/www/cvs/drupal/modules/user.module on line 1048. Hostname 127.0.0.1 ------------------------------------------------------------------------ January 24, 2005 - 22:20 : Dries I can't reproduce this problem. ------------------------------------------------------------------------ February 7, 2005 - 18:00 : budda Problem is fixed by the patch here. Had no more problems since. Error was re-produced when trying to delete the same user account a number of times by hitting the 'delete' form button. -- View: http://drupal.org/node/15511 Edit: http://drupal.org/project/comments/add/15511

2 1

[drupal-devel] [bug] Error while deleting user
by budda 07 Feb '05

07 Feb '05

Project: Drupal Version: cvs Component: user.module Category: bug reports Priority: normal Assigned to: chx Reported by: chx Updated by: budda -Status: active +Status: patch Problem is fixed by the patch here. Had no more problems since. Error was re-produced when trying to delete the same user account a number of times by hitting the 'delete' form button. budda Previous comments: ------------------------------------------------------------------------ January 12, 2005 - 19:44 : chx Attachment: http://drupal.org/files/issues/user_delete_0.patch (875 bytes) Type error Date Wednesday, January 12, 2005 - 19:17 User chx Location /cvs/drupal/?q=user/2/edit Message array_keys(): The first argument should be an array in /var/www/cvs/drupal/modules/user.module on line 1048. Hostname 127.0.0.1 ------------------------------------------------------------------------ January 24, 2005 - 22:20 : Dries I can't reproduce this problem. -- View: http://drupal.org/node/15511 Edit: http://drupal.org/project/comments/add/15511

1 0

[drupal-devel] [bug] [QUICKFIX] Putting a .theme file into themes/ makes all themes not working
by chx 07 Feb '05

07 Feb '05

Project: Drupal -Version: 4.5.0 +Version: cvs Component: theme system Category: bug reports Priority: critical -Assigned to: Anonymous +Assigned to: chx Reported by: chx Updated by: chx -Status: active +Status: patch Attachment: http://drupal.org/files/issues/themesfix.patch (542 bytes) Here is a patch which fixes the problem. However, I do not have the feeling that this is "the" solution. Feel free to come up with something better. chx Previous comments: ------------------------------------------------------------------------ February 7, 2005 - 08:13 : chx Try putting a .theme file into themes/ without any subdir. Enable it (maybe just saving theme settings is enough), Nothing will work after this. To restore your site: remove the offending theme, issue an SQL: DELETE FROM {system} WHERE type='theme' and save theme settings again. ------------------------------------------------------------------------ February 7, 2005 - 08:14 : chx effects HEAD, too. -- View: http://drupal.org/node/16914 Edit: http://drupal.org/project/comments/add/16914

1 0

[drupal-devel] Howto enable webdav in your drupal directory
by Karsten Müller 07 Feb '05

07 Feb '05

It was not too easy to make webdav work in my drupal directory while using clean URLs so I like to share these instructions. Note: Using webdav without SSL is probably a security risk... Add this line to .htaccess just befor the RewriteRule line(s): RewriteCond %{REQUEST_METHOD} !(^PUT$|^DELETE$|^PROPFIND$) Add these lines to your httpd.conf to enable http::/yourhost/drupal-source as webdav location: <IfModule mod_dav.c> Alias /drupal-source /home/www/shiatsu/test45.0xc.net/docs <Location /drupal-source> AuthType Basic AuthName "drupal php" # change path to your path AuthUserFile /path/.htpasswd Require valid-user # Don't use handlers SetHandler default-handler RemoveHandler .php .html DAV On Options +Indexes Order allow,deny # change all to your IP address Allow from all # Lock down all actions except those that are read-only <LimitExcept GET HEAD OPTIONS> Allow from all # change admin to your username Require user admin </LimitExcept> </Location> </IfModule> Cheers!

8 17

[drupal-devel] [feature] RSS Feeds behind Firewall
by Bèr Kessels 07 Feb '05

07 Feb '05

Project: Drupal Version: 4.5.2 Component: base system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: jhefmv24 Updated by: Bèr Kessels Status: patch -1 on this. Please do not introduce more config options. IT makes no sense, since you only set that option once. Also: you solve a single case of fopen, please look for an overal solution that will solve all drupa fopens, rather than hack into the feed code to fix that specific issue. * either make the code smarter so it can detect proxy errors (http://drupal.org/node/9706) OR * add this to conf.php Bèr Kessels Previous comments: ------------------------------------------------------------------------ May 19, 2004 - 06:01 : jhefmv24 Attachment: http://drupal.org/files/issues/common.inc (37.11 KB) I think the RSS feeds don't work if there is proxy server running. The request/connection is somehow being blocked. The connection should be made first to the proxy and once it is established, then request can made. I think the core function drupal_http_request() under /includes/common.inc doesn't support this. One workaround is change the code from: <?php switch ($uri['scheme']) { case 'http': //$fp = @fsockopen($uri['host'], ($uri['port'] ? $uri['port'] : 80), $errno, $errstr, 15); ?> into: <?php //use proxy settings $fp = @fsockopen('proxy2', '8080'); ?> And then create the request by change from: <?php $request = "$method $path HTTP/1.0\r\n"; ?> Into: <?php $request = "$method ".$uri['scheme']."://".$uri['host'].$path." HTTP/1.1\r\n"; ?> And comment out the lines: <?php $request .= implode("\r\n", $defaults); ?> ------------------------------------------------------------------------ February 2, 2005 - 00:38 : Anonymous Did this ever get taken care of in 4.5.2. I can't seem to get any feed to work from behind a firewall. Getting error.... Failed to parse RSS feed Microsoft Security Info: 10060 A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.. At home this same feed works fine, so I know it's not the feed. Thanks, SlackNet ------------------------------------------------------------------------ February 4, 2005 - 05:24 : jhefmv24 Attachment: http://drupal.org/files/issues/common.inc_4.patch (1.37 KB) +1 on having a facility to modify proxy settings... here's a patch of /includes/common.inc for drupal-4.4.2 version ------------------------------------------------------------------------ February 4, 2005 - 05:25 : jhefmv24 Attachment: http://drupal.org/files/issues/system.module_2.patch (956 bytes) +1 on having a facility to modify proxy settings... here's a patch of /modules/system.module for drupal-4.4.2 version ------------------------------------------------------------------------ February 4, 2005 - 05:31 : jhefmv24 Attachment: http://drupal.org/files/issues/common.inc_5.patch (1.35 KB) patch for /includes/common.inc 4.5.2 version to facilitate rss feeds behind firewall ------------------------------------------------------------------------ February 4, 2005 - 05:32 : jhefmv24 Attachment: http://drupal.org/files/issues/system.module_3.patch (1.03 KB) patch of /modules/system.module 4.5.2 version to set proxy settings ------------------------------------------------------------------------ February 4, 2005 - 09:23 : Bèr Kessels hi, tso small issues. one is described at: http://drupal.org/node/9706 The other is that the code is not "drupal compliant". Drupal developrs are (luckily) very picky about spaces, indentation, etc. ------------------------------------------------------------------------ February 4, 2005 - 09:51 : jhefmv24 Attachment: http://drupal.org/files/issues/common.inc_6.patch (1.37 KB) i forgot to remove my hardcoded proxy name.. sorry Ber, which is not drupal compliant? ------------------------------------------------------------------------ February 4, 2005 - 22:22 : Anonymous Is there any way to hardcode my proxy server name? I can't seem to get the patches to work. I just get a blank page after I try to update the news feeds. ------------------------------------------------------------------------ February 4, 2005 - 23:51 : Anonymous Here's the error I get... warning: fsockopen(): unable to connect to :8080 in ....\includes\common.inc on line 228. ------------------------------------------------------------------------ February 5, 2005 - 08:09 : Steven 1) New features only get added to CVS/HEAD, not to the 4.5.x branch. 2) 'Blind' variables that cannot be changed through an admin interface are not a good idea. 3) Your proxy codepath ignores the $defaults array completely. At this point in the code, this doesn't just contain default headers but also any extra headers passed to drupal_http_request(). This is not good as they are simply not used anymore. 4) Code style: //use proxy settings There should be a space between '//' and text. MInd capitalization and punctuation. $request = "$method ".$uri['scheme']."://".$uri['host'].$path." HTTP/1.1\r\n"; Rules for string concatenation: never a space between . and a quote, always a space otherwise. Tab usage: we never use tabs due to editor differences. Your patch contains several. String quote usage: we prefer single quotes in Drupal to double quotes, except in the case where single quotes would be too hard to read (e.g. backslash escapes should be avoided as well). ------------------------------------------------------------------------ February 5, 2005 - 15:05 : Anonymous In a very tight setup, users must authenticate to access the proxy, to prevent unauthorised usage, or to track authorised usage. Can the proxy support also be modified to allow username/password to be supplied to the proxy? ------------------------------------------------------------------------ February 7, 2005 - 07:46 : jhefmv24 Attachment: http://drupal.org/files/issues/system.module_4.patch (1.01 KB) Thanks Steven. I hope this patch works and be accepted... This will allow proxy variables to be modified using the admin interface. ------------------------------------------------------------------------ February 7, 2005 - 07:47 : jhefmv24 Attachment: http://drupal.org/files/issues/common.inc_7.patch (1.38 KB) compliant patch for proxy suport, thanks Steven. -- View: http://drupal.org/node/7881 Edit: http://drupal.org/project/comments/add/7881

1 0

[drupal-devel] Themes causing database corruption?
by NSK 07 Feb '05

07 Feb '05

I am using Drupal 4.5.2 with the default Bluemarine theme. The database is MySQL 3.23. The site is this: http://portal.wikinerds.org I tried many of the themes that can be found at drupal.org, including Sunflower, Goofy, Kubrick, Interlaced and many more. After I tested many themes I decided to return to my default Bluemarine theme. When I loaded the Bluemarine again, everything was messed up: - The sidebar was on the left instead of on the right. - My site logo and name was not showing up - My site footer was hidden - My primary links and secondary links weren't showing up - The article titles were not clickable as before - When I checked some articles, I was seeing some random characters instead of the article text. It is not a caching issue on my browser because I tested it with many different computers. What I did then was to download the original Drupal 4.5.2 again and set-up the site from the beginning using the same database. So, I replaced all code, without of course copying the non-default themes. I had again a default Drupal installation using the same database. The display was still incorrect, which makes me to believe that somehow the database got corrupt. Note: I use the Feedback and Excerpt modules. One of the themes I tried was Goofy, and another user has posted this bug report: http://drupal.org/node/15400 However I don't know whether it was Goofy which caused the problem, because I tested many other themes too. I have a database backup from Feb-1, but it doesn't contain the newest content such as the GNU/Hurd article. I also tried the other default themes of Drupal and they don't work, either. Any help is appreciated. I would never imagine that testing some themes would cause these terrible problems! I can login to my site and change settings, but the display is all messed up. It isn't what my site readers would want to see. -- NSK http://portal.wikinerds.org

3 2

[drupal-devel] [feature] Proposed change to menu.inc that would allow modules to create custom menus
by andremolnar 07 Feb '05

07 Feb '05

Project: Drupal Version: cvs Component: menu system Category: feature requests Priority: normal Assigned to: andremolnar Reported by: andremolnar Updated by: andremolnar Status: patch Attachment: http://drupal.org/files/issues/menu_inc_3.patch (2.65 KB) Noticed patch was out of date - keeping it current. andremolnar Previous comments: ------------------------------------------------------------------------ January 6, 2005 - 07:13 : andremolnar Attachment: http://drupal.org/files/issues/menu_inc_2.patch (2.65 KB) See http://drupal.org/node/15153 and http://drupal.org/node/14120 for discussion on this proposed change. Patch is included here for further discussion (with the changes suggested by Dries). A patch is forthcoming for topics discussed in http://drupal.org/node/14120 which would make use of this patch. Status to be changed to patch later if there are no objections following discussion. andre ------------------------------------------------------------------------ January 8, 2005 - 21:16 : andremolnar Patch making use of this is now added to http://drupal.org/node/14120. andre ------------------------------------------------------------------------ January 10, 2005 - 07:29 : andremolnar Just realising that the rules for setting status to patch would allow this to be patch since its technically ready to go. (and it might actually get noticed if its on the dev list and patch queue). andre ------------------------------------------------------------------------ January 11, 2005 - 06:47 : Dries I'm OK with this patch but won't commit it yet until the book module patch is ready. ------------------------------------------------------------------------ January 20, 2005 - 02:07 : andremolnar I've uploaded the latest version of the patch to book. http://drupal.org/node/14120 andre ------------------------------------------------------------------------ January 27, 2005 - 17:38 : JonBob I'd prefer a solution that allowed modules to declare such menu items using the menu hook, but haven't been able to come up with such a solution. I'm okay with this approach until such time as someone has a brilliant idea to make the menu hook more powerful. ------------------------------------------------------------------------ January 28, 2005 - 00:00 : andremolnar JonBob, I'd be happy to work on a solution with you. Right now what I had to do in the proposed changes to book was build functions to insert data into the {menu} table by hand since there was no other handler available (e.g. hook_menu). And proposing this MENU_MODULE_MENU type was the only way I could think of to clearly distinguish where these new menu items were coming from (i.e. a module doing an insert into the menu system outside of the normal chanels). Would the creation of a new hook_ be in order. Perhaps hook_menu_block? While it would be a confusing hook name - it is does describe the desired outcome. i.e. Output from hook_menu_block would be inserted into the menu system and a block would be created for that menu. But even then I think these new menu types (or something similar) would have to be employed in some way. andre -- View: http://drupal.org/node/15198 Edit: http://drupal.org/project/comments/add/15198

1 0

[drupal-devel] [feature] RSS Feeds behind Firewall
by jhefmv24 07 Feb '05

07 Feb '05

Project: Drupal Version: 4.5.2 Component: base system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: jhefmv24 Updated by: jhefmv24 -Status: active +Status: patch Attachment: http://drupal.org/files/issues/common.inc_7.patch (1.38 KB) compliant patch for proxy suport, thanks Steven. jhefmv24 Previous comments: ------------------------------------------------------------------------ May 19, 2004 - 13:01 : jhefmv24 Attachment: http://drupal.org/files/issues/common.inc (37.11 KB) I think the RSS feeds don't work if there is proxy server running. The request/connection is somehow being blocked. The connection should be made first to the proxy and once it is established, then request can made. I think the core function drupal_http_request() under /includes/common.inc doesn't support this. One workaround is change the code from: <?php switch ($uri['scheme']) { case 'http': //$fp = @fsockopen($uri['host'], ($uri['port'] ? $uri['port'] : 80), $errno, $errstr, 15); ?> into: <?php //use proxy settings $fp = @fsockopen('proxy2', '8080'); ?> And then create the request by change from: <?php $request = "$method $path HTTP/1.0\r\n"; ?> Into: <?php $request = "$method ".$uri['scheme']."://".$uri['host'].$path." HTTP/1.1\r\n"; ?> And comment out the lines: <?php $request .= implode("\r\n", $defaults); ?> ------------------------------------------------------------------------ February 2, 2005 - 07:38 : Anonymous Did this ever get taken care of in 4.5.2. I can't seem to get any feed to work from behind a firewall. Getting error.... Failed to parse RSS feed Microsoft Security Info: 10060 A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.. At home this same feed works fine, so I know it's not the feed. Thanks, SlackNet ------------------------------------------------------------------------ February 4, 2005 - 12:24 : jhefmv24 Attachment: http://drupal.org/files/issues/common.inc_4.patch (1.37 KB) +1 on having a facility to modify proxy settings... here's a patch of /includes/common.inc for drupal-4.4.2 version ------------------------------------------------------------------------ February 4, 2005 - 12:25 : jhefmv24 Attachment: http://drupal.org/files/issues/system.module_2.patch (956 bytes) +1 on having a facility to modify proxy settings... here's a patch of /modules/system.module for drupal-4.4.2 version ------------------------------------------------------------------------ February 4, 2005 - 12:31 : jhefmv24 Attachment: http://drupal.org/files/issues/common.inc_5.patch (1.35 KB) patch for /includes/common.inc 4.5.2 version to facilitate rss feeds behind firewall ------------------------------------------------------------------------ February 4, 2005 - 12:32 : jhefmv24 Attachment: http://drupal.org/files/issues/system.module_3.patch (1.03 KB) patch of /modules/system.module 4.5.2 version to set proxy settings ------------------------------------------------------------------------ February 4, 2005 - 16:23 : Bèr Kessels hi, tso small issues. one is described at: http://drupal.org/node/9706 The other is that the code is not "drupal compliant". Drupal developrs are (luckily) very picky about spaces, indentation, etc. ------------------------------------------------------------------------ February 4, 2005 - 16:51 : jhefmv24 Attachment: http://drupal.org/files/issues/common.inc_6.patch (1.37 KB) i forgot to remove my hardcoded proxy name.. sorry Ber, which is not drupal compliant? ------------------------------------------------------------------------ February 5, 2005 - 05:22 : Anonymous Is there any way to hardcode my proxy server name? I can't seem to get the patches to work. I just get a blank page after I try to update the news feeds. ------------------------------------------------------------------------ February 5, 2005 - 06:51 : Anonymous Here's the error I get... warning: fsockopen(): unable to connect to :8080 in ....\includes\common.inc on line 228. ------------------------------------------------------------------------ February 5, 2005 - 15:09 : Steven 1) New features only get added to CVS/HEAD, not to the 4.5.x branch. 2) 'Blind' variables that cannot be changed through an admin interface are not a good idea. 3) Your proxy codepath ignores the $defaults array completely. At this point in the code, this doesn't just contain default headers but also any extra headers passed to drupal_http_request(). This is not good as they are simply not used anymore. 4) Code style: //use proxy settings There should be a space between '//' and text. MInd capitalization and punctuation. $request = "$method ".$uri['scheme']."://".$uri['host'].$path." HTTP/1.1\r\n"; Rules for string concatenation: never a space between . and a quote, always a space otherwise. Tab usage: we never use tabs due to editor differences. Your patch contains several. String quote usage: we prefer single quotes in Drupal to double quotes, except in the case where single quotes would be too hard to read (e.g. backslash escapes should be avoided as well). ------------------------------------------------------------------------ February 5, 2005 - 22:05 : Anonymous In a very tight setup, users must authenticate to access the proxy, to prevent unauthorised usage, or to track authorised usage. Can the proxy support also be modified to allow username/password to be supplied to the proxy? ------------------------------------------------------------------------ February 7, 2005 - 14:46 : jhefmv24 Attachment: http://drupal.org/files/issues/system.module_4.patch (1.01 KB) Thanks Steven. I hope this patch works and be accepted... This will allow proxy variables to be modified using the admin interface. -- View: http://drupal.org/node/7881 Edit: http://drupal.org/project/comments/add/7881

1 0