March 2005 - Development - lists.drupal.org

[drupal-devel] [bug] Opening Theme Administration Breaks Themes
by Junyor 28 Mar '05

28 Mar '05

Issue status update for http://drupal.org/node/13037 Project: Drupal -Version: 4.5.0 +Version: 4.5.2 Component: theme system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Anthony Townsend Updated by: Junyor Status: active I've only seen this problem in that single installation of Drupal 4.5.2. I'll have to check the PHP version tomorrow. However, if you look at the last comment in that thread, it would appear that someone has the problem with PHP 4.3.9, too. The problem started when one of the admins changed his account to use a different theme than the site default. I'm pretty sure I've done the exact same thing elsewhere and I haven't run into this problem. Junyor Previous comments: ------------------------------------------------------------------------ November 16, 2004 - 20:59 : Anthony Townsend Attachment: http://drupal.org/files/issues/Picture 2.pdf (62.66 KB) On a fresh 4.5.0 installation, even just selecting the Administer-> Theme menu item breaks the theme stylesheets. For an example see http//hurricane.wagner.nyu.edu Not sure what is causing this, but I've reinstalled and replicated on several different boxes. ------------------------------------------------------------------------ November 16, 2004 - 21:36 : Anthony Townsend Attachment: http://drupal.org/files/issues/Picture 1.pdf (122.32 KB) weirdly enough, the proper theme is used (and only there) on the Administer -> Theme selection page (see attached) ------------------------------------------------------------------------ March 3, 2005 - 16:07 : pildit I've got the same symptoms. ------------------------------------------------------------------------ March 21, 2005 - 15:35 : Junyor I've debugged the problem a bit. It seems that a null terminator is being inserted in the system table in the middle of the theme path. See the following for related discussion: http://drupal.org/node/4567 http://drupal.org/node/11761 http://drupal.org/node/12526 http://drupal.org/node/13005 ------------------------------------------------------------------------ March 21, 2005 - 16:20 : Junyor Here's the output from devel.module when loading admin/themes. The first query that shows a problem is "0.84 1 DELETE FROM system WHERE filename = 'themes/chameleon/chameleon\0theme' AND type = 'theme'", which comes from system_obtain_theme_info(). 1.08 1 SELECT * FROM url_alias 1.37 1 SELECT name, filename, throttle, bootstrap FROM system WHERE type = 'module' AND status = 1 0.8 1 SELECT uid FROM authmap WHERE authname = 'tim' 0.96 1 SELECT u.* FROM users u WHERE u.uid = 18 AND u.status < 3 LIMIT 0, 1 0.84 1 SELECT r.rid, r.name FROM role r INNER JOIN users_roles ur ON ur.rid = r.rid WHERE ur.uid = 18 2.03 1 SELECT DISTINCT(p.perm) FROM role r INNER JOIN permission p ON p.rid = r.rid INNER JOIN users_roles ur ON ur.rid = r.rid WHERE ur.uid = 18 1.65 1 SELECT * FROM system WHERE type = 'theme' ORDER BY name 6.47 1 SELECT data, created, headers FROM cache WHERE cid = 'menu:18' 1.27 1 DELETE FROM system WHERE type = 'theme_engine' 0.85 1 INSERT INTO system (name, type, filename, status, throttle, bootstrap) VALUES ('phptemplate', 'theme_engine', 'themes/engines/phptemplate/phptemplate.engine', 1, 0, 0) 0.75 1 INSERT INTO system (name, type, filename, status, throttle, bootstrap) VALUES ('xtemplate', 'theme_engine', 'themes/engines/xtemplate/xtemplate.engine', 1, 0, 0) 0.76 1 DELETE FROM variable WHERE name = 'phptemplate_extra_templates' 1.13 1 INSERT INTO variable (name, value) VALUES ('phptemplate_extra_templates', 'a:2:{s:14:\"themes/kubrick\";a:3:{s:30:\"themes/kubrick/comment.tpl.php\";O:8:\"stdClass\":2:{s:8:\"filename\";s:30:\"themes/kubrick/comment.tpl.php\";s:4:\"name\";s:11:\"comment.tpl\";}s:27:\"themes/kubrick/node.tpl.php\";O:8:\"stdClass\":2:{s:8:\"filename\";s:27:\"themes/kubrick/node.tpl.php\";s:4:\"name\";s:8:\"node.tpl\";}s:27:\"themes/kubrick/page.tpl.php\";O:8:\"stdClass\":2:{s:8:\"filename\";s:27:\"themes/kubrick/page.tpl.php\";s:4:\"name\";s:8:\"page.tpl\";}}s:12:\"themes/manji\";a:4:{s:24:\"themes/manji/box.tpl.php\";O:8:\"stdClass\":2:{s:8:\"filename\";s:24:\"themes/manji/box.tpl.php\";s:4:\"name\";s:7:\"box.tpl\";}s:28:\"themes/manji/comment.tpl.php\";O:8:\"stdClass\":2:{s:8:\"filename\";s:28:\"themes/manji/comment.tpl.php\";s:4:\"name\";s:11:\"comment.tpl\";}s:25:\"themes/manji/node.tpl.php\";O:8:\"stdClass\":2:{s:8:\"filename\";s:25:\"themes/manji/node.tpl.php\";s:4:\"name\";s:8:\"node.tpl\";}s:25:\"themes/manji/page.tpl.php\";O:8:\"stdClass\":2:{s:8:\"filename\";s:25:\"themes/manji/page.tpl.php\";s:4:\"name\";s:8:\"page.tpl\";}}}') 0.73 2 DELETE FROM cache WHERE cid = 'variables' 0.6 1 DELETE FROM variable WHERE name = 'phptemplate_extra_logic' 0.55 1 INSERT INTO variable (name, value) VALUES ('phptemplate_extra_logic', 'a:0:{}') 0.49 2 DELETE FROM cache WHERE cid = 'variables' 1.27 1 SELECT filename, type, status, throttle FROM system WHERE type = 'theme' 0.84 1 DELETE FROM system WHERE filename = 'themes/chameleon/chameleon\0theme' AND type = 'theme' 0.68 1 INSERT INTO system (name, description, type, filename, status, throttle, bootstrap) VALUES ('chameleon', '', 'theme', 'themes/chameleon/chameleon\0theme', 0, 0, 0) 0.69 1 DELETE FROM system WHERE filename = 'themes/kubrick/page.tpl.php' AND type = 'theme' 0.67 1 INSERT INTO system (name, description, type, filename, status, throttle, bootstrap) VALUES ('kubrick', 'themes/engines/phptemplate/phptemplate.engine', 'theme', 'themes/kubrick/page.tpl.php', 0, 0, 0) 0.68 1 DELETE FROM system WHERE filename = 'themes/manji/page.tpl.php' AND type = 'theme' 0.67 1 INSERT INTO system (name, description, type, filename, status, throttle, bootstrap) VALUES ('manji', 'themes/engines/phptemplate/phptemplate\0engine', 'theme', 'themes/manji/page.tpl.php', 0, 0, 0) 0.67 1 DELETE FROM system WHERE filename = 'themes/bluemarine/xtemplate.xtmpl' AND type = 'theme' 0.66 1 INSERT INTO system (name, description, type, filename, status, throttle, bootstrap) VALUES ('bluemarine', 'themes/engines/xtemplate/xtemplate.engine', 'theme', 'themes/bluemarine/xtemplate.xtmpl', 0, 0, 0) 0.68 1 DELETE FROM system WHERE filename = 'themes/pushbutton/xtemplate.xtmpl' AND type = 'theme' 0.66 1 INSERT INTO system (name, description, type, filename, status, throttle, bootstrap) VALUES ('pushbutton', 'themes/engines/xtemplate/xtemplate\0engine', 'theme', 'themes/pushbutton/xtemplate.xtmpl', 1, 0, 0) 0.68 1 DELETE FROM system WHERE filename = 'themes/pushbutton-new/xtemplate.xtmpl' AND type = 'theme' 0.67 1 INSERT INTO system (name, description, type, filename, status, throttle, bootstrap) VALUES ('pushbutton-new', 'themes/engines/xtemplate/xtemplate\0engine', 'theme', 'themes/pushbutton-new/xtemplate.xtmpl', 0, 0, 0) 0.67 1 DELETE FROM system WHERE filename = 'themes/chameleon/marvin/style.css' AND type = 'theme' 0.65 1 INSERT INTO system (name, description, type, filename, status, throttle, bootstrap) VALUES ('chameleon/marvin', 'chameleon', 'theme', 'themes/chameleon/marvin/style.css', 0, 0, 0) 0.68 1 DELETE FROM system WHERE filename = 'themes/manji/obsidian/style.css' AND type = 'theme' 0.65 1 INSERT INTO system (name, description, type, filename, status, throttle, bootstrap) VALUES ('manji/obsidian', 'manji', 'theme', 'themes/manji/obsidian/style.css', 0, 0, 0) 1 1 SELECT * FROM blocks WHERE (status = 1 OR custom = 1) ORDER BY weight, module ------------------------------------------------------------------------ March 21, 2005 - 17:41 : Carl McDade The devel.module works on 4.5.2? or are you using a personally modified version? ------------------------------------------------------------------------ March 21, 2005 - 17:58 : Junyor I used the CVS version. Worked fine. ------------------------------------------------------------------------ March 28, 2005 - 11:14 : TDobes Very strange... I can't seem to reproduce this. Can sombody clarify the following questions so I might help troubleshoot the problem? * Does this happen on CVS HEAD Drupal or is it limited to 4.5.x? * What verion of PHP are you using? This forum topic [1] seems to point to the idea that it might be related to old PHP versions. [1] http://drupal.org/node/13005

1 0

[drupal-devel] [bug] Database update fails if anonymous comment names contain single quotes
by Junyor 28 Mar '05

28 Mar '05

Issue status update for http://drupal.org/node/19432 Project: Drupal Version: cvs Component: database system Category: bug reports Priority: critical Assigned to: Junyor Reported by: Junyor Updated by: Junyor Status: patch Attachment: http://drupal.org/files/issues/updates_1.patch (2.22 KB) Parts of update_124 will fail if an anonymous commentor's name contains a single quote. To fix this, I updated update_sql to accept additional parameters that it sends on to db_query. I also moved update_sql to the top of the file. The only problem I could find with this approach is that the query displayed by update.php contains the substitute parameter (%s or %d), not the actual parameter. I'd appreciate if someone else could take a look and see if there's a better way to do this. I think that update_sql should have this functionality anyway, though. Junyor

2 6

[drupal-devel] [bug] Chameleon title tag shows nothing useful
by TDobes 28 Mar '05

28 Mar '05

Issue status update for http://drupal.org/node/19585 Project: Drupal Version: cvs Component: theme system Category: bug reports Priority: normal Assigned to: TDobes Reported by: TDobes Updated by: TDobes Status: patch Attachment: http://drupal.org/files/issues/chameleon-title-fix.patch (1018 bytes) In chameleon.theme (chameleon_page), code exists within the title tag to display a $title variable. However, at this point in the function $title has not yet been defined, so no page-specific titles are ever displayed. The attached patch fixes this by populating $title using drupal_get_title earlier in the function. Please review / commit before 4.6 release. TDobes

1 0

[drupal-devel] [bug] Strange message when creating multiple custom menus
by TDobes 28 Mar '05

28 Mar '05

Issue status update for http://drupal.org/node/12986 Project: Drupal Version: 4.5.0 Component: menu system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: potion Updated by: TDobes Status: active I can't seem to reproduce this, and I've used a wide variety of the contributed phptemplate themes... I can't imagine how that could have caused it anyway. Can you reproduce the error with an unmodified contrib and/or core theme? (and the unmodified phptemplate engine) TDobes Previous comments: ------------------------------------------------------------------------ November 15, 2004 - 16:30 : potion When I go to ?q=admin/menu there's a link there that says "list." Presumably when I click on that link it's supposed to list my menus, but it doesn't. In fact, my URL doesn't change when I click "list" -- I'm still at ?q=admin/menu. By contrast, when I click on "add menu", "add menu item" or "reset menus" I go to a different URL. So I theorize that the hyperlink for "list" is somehow broken, and I'm wondering what URL I need to visit to see a list of my menus so I can edit them. I'm also noticing some very bad behavior when I click "add menu" -- presumably that interface is for adding a menu and not a menu item. But when I add a menu there called "new menu3" the next screen I see says... * Created new menu item new menu3. * Since a menu item PoetryOnWalls.com already exists for , this new menu item was created as a shortcut to that location. That makes no sense, since PoetryOnWalls.com isn't a menu item, it's a menu, and something is missing after "for". Meanwhile, PoetryOnWalls.com does indeed appear among my blocks and can be activated and displayed, but there's no way to add items to it since I can't list/edit menus. Has anyone else seen this behavior in 4.5? ------------------------------------------------------------------------ November 16, 2004 - 08:11 : Anonymous There are two bug reports here. The first is "by design": "When I go to ?q=admin/menu there's a link there that says "list." Presumably when I click on that link it's supposed to list my menus, but it doesn't. In fact, my URL doesn't change when I click "list" -- I'm still at ?q=admin/menu." This is because "list" is the default tab, and you're already there. The page should be displaying a list of menu items already. This is how the tabs behave everywhere. As for the strange message when you add a new menu, that might be a legitimate bug. Retitling the issue to reflect the problem. ------------------------------------------------------------------------ November 16, 2004 - 13:30 : Anonymous Could you please provide concrete steps on how to reproduce this bug after clicking "Reset" on the "Reset Menus" tab? ------------------------------------------------------------------------ November 17, 2004 - 21:08 : potion this is only a problem for me when I'm using phptemplate. I switched to chameleon and now menus are listed -- no problemo. I went ahead and reset my menus, though, to see if that would help matters in phptemplate. There aren't really any steps to list to recreate the bug -- I just click on the menus link in the admin menu and none are listed. but they're there in chameleon. trying to think if I could have done anything to the code that could have caused this... no, I don't think so, I've really only messed with the css and the design templates -- node.tpl.php, block.tpl.php, etc. Nothing that should affect the admin system.

1 0

[drupal-devel] [bug] Opening Theme Administration Breaks Themes
by TDobes 28 Mar '05

28 Mar '05

Issue status update for http://drupal.org/node/13037 Project: Drupal Version: 4.5.0 Component: theme system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Anthony Townsend Updated by: TDobes Status: active Very strange... I can't seem to reproduce this. Can sombody clarify the following questions so I might help troubleshoot the problem? * Does this happen on CVS HEAD Drupal or is it limited to 4.5.x? * What verion of PHP are you using? This forum topic [1] seems to point to the idea that it might be related to old PHP versions. [1] http://drupal.org/node/13005 TDobes Previous comments: ------------------------------------------------------------------------ November 16, 2004 - 13:59 : Anthony Townsend Attachment: http://drupal.org/files/issues/Picture 2.pdf (62.66 KB) On a fresh 4.5.0 installation, even just selecting the Administer-> Theme menu item breaks the theme stylesheets. For an example see http//hurricane.wagner.nyu.edu Not sure what is causing this, but I've reinstalled and replicated on several different boxes. ------------------------------------------------------------------------ November 16, 2004 - 14:36 : Anthony Townsend Attachment: http://drupal.org/files/issues/Picture 1.pdf (122.32 KB) weirdly enough, the proper theme is used (and only there) on the Administer -> Theme selection page (see attached) ------------------------------------------------------------------------ March 3, 2005 - 09:07 : pildit I've got the same symptoms. ------------------------------------------------------------------------ March 21, 2005 - 08:35 : Junyor I've debugged the problem a bit. It seems that a null terminator is being inserted in the system table in the middle of the theme path. See the following for related discussion: http://drupal.org/node/4567 http://drupal.org/node/11761 http://drupal.org/node/12526 http://drupal.org/node/13005 ------------------------------------------------------------------------ March 21, 2005 - 09:20 : Junyor Here's the output from devel.module when loading admin/themes. The first query that shows a problem is "0.84 1 DELETE FROM system WHERE filename = 'themes/chameleon/chameleon\0theme' AND type = 'theme'", which comes from system_obtain_theme_info(). 1.08 1 SELECT * FROM url_alias 1.37 1 SELECT name, filename, throttle, bootstrap FROM system WHERE type = 'module' AND status = 1 0.8 1 SELECT uid FROM authmap WHERE authname = 'tim' 0.96 1 SELECT u.* FROM users u WHERE u.uid = 18 AND u.status < 3 LIMIT 0, 1 0.84 1 SELECT r.rid, r.name FROM role r INNER JOIN users_roles ur ON ur.rid = r.rid WHERE ur.uid = 18 2.03 1 SELECT DISTINCT(p.perm) FROM role r INNER JOIN permission p ON p.rid = r.rid INNER JOIN users_roles ur ON ur.rid = r.rid WHERE ur.uid = 18 1.65 1 SELECT * FROM system WHERE type = 'theme' ORDER BY name 6.47 1 SELECT data, created, headers FROM cache WHERE cid = 'menu:18' 1.27 1 DELETE FROM system WHERE type = 'theme_engine' 0.85 1 INSERT INTO system (name, type, filename, status, throttle, bootstrap) VALUES ('phptemplate', 'theme_engine', 'themes/engines/phptemplate/phptemplate.engine', 1, 0, 0) 0.75 1 INSERT INTO system (name, type, filename, status, throttle, bootstrap) VALUES ('xtemplate', 'theme_engine', 'themes/engines/xtemplate/xtemplate.engine', 1, 0, 0) 0.76 1 DELETE FROM variable WHERE name = 'phptemplate_extra_templates' 1.13 1 INSERT INTO variable (name, value) VALUES ('phptemplate_extra_templates', 'a:2:{s:14:\"themes/kubrick\";a:3:{s:30:\"themes/kubrick/comment.tpl.php\";O:8:\"stdClass\":2:{s:8:\"filename\";s:30:\"themes/kubrick/comment.tpl.php\";s:4:\"name\";s:11:\"comment.tpl\";}s:27:\"themes/kubrick/node.tpl.php\";O:8:\"stdClass\":2:{s:8:\"filename\";s:27:\"themes/kubrick/node.tpl.php\";s:4:\"name\";s:8:\"node.tpl\";}s:27:\"themes/kubrick/page.tpl.php\";O:8:\"stdClass\":2:{s:8:\"filename\";s:27:\"themes/kubrick/page.tpl.php\";s:4:\"name\";s:8:\"page.tpl\";}}s:12:\"themes/manji\";a:4:{s:24:\"themes/manji/box.tpl.php\";O:8:\"stdClass\":2:{s:8:\"filename\";s:24:\"themes/manji/box.tpl.php\";s:4:\"name\";s:7:\"box.tpl\";}s:28:\"themes/manji/comment.tpl.php\";O:8:\"stdClass\":2:{s:8:\"filename\";s:28:\"themes/manji/comment.tpl.php\";s:4:\"name\";s:11:\"comment.tpl\";}s:25:\"themes/manji/node.tpl.php\";O:8:\"stdClass\":2:{s:8:\"filename\";s:25:\"themes/manji/node.tpl.php\";s:4:\"name\";s:8:\"node.tpl\";}s:25:\"themes/manji/page.tpl.php\";O:8:\"stdClass\":2:{s:8:\"filename\";s:25:\"themes/manji/page.tpl.php\";s:4:\"name\";s:8:\"page.tpl\";}}}') 0.73 2 DELETE FROM cache WHERE cid = 'variables' 0.6 1 DELETE FROM variable WHERE name = 'phptemplate_extra_logic' 0.55 1 INSERT INTO variable (name, value) VALUES ('phptemplate_extra_logic', 'a:0:{}') 0.49 2 DELETE FROM cache WHERE cid = 'variables' 1.27 1 SELECT filename, type, status, throttle FROM system WHERE type = 'theme' 0.84 1 DELETE FROM system WHERE filename = 'themes/chameleon/chameleon\0theme' AND type = 'theme' 0.68 1 INSERT INTO system (name, description, type, filename, status, throttle, bootstrap) VALUES ('chameleon', '', 'theme', 'themes/chameleon/chameleon\0theme', 0, 0, 0) 0.69 1 DELETE FROM system WHERE filename = 'themes/kubrick/page.tpl.php' AND type = 'theme' 0.67 1 INSERT INTO system (name, description, type, filename, status, throttle, bootstrap) VALUES ('kubrick', 'themes/engines/phptemplate/phptemplate.engine', 'theme', 'themes/kubrick/page.tpl.php', 0, 0, 0) 0.68 1 DELETE FROM system WHERE filename = 'themes/manji/page.tpl.php' AND type = 'theme' 0.67 1 INSERT INTO system (name, description, type, filename, status, throttle, bootstrap) VALUES ('manji', 'themes/engines/phptemplate/phptemplate\0engine', 'theme', 'themes/manji/page.tpl.php', 0, 0, 0) 0.67 1 DELETE FROM system WHERE filename = 'themes/bluemarine/xtemplate.xtmpl' AND type = 'theme' 0.66 1 INSERT INTO system (name, description, type, filename, status, throttle, bootstrap) VALUES ('bluemarine', 'themes/engines/xtemplate/xtemplate.engine', 'theme', 'themes/bluemarine/xtemplate.xtmpl', 0, 0, 0) 0.68 1 DELETE FROM system WHERE filename = 'themes/pushbutton/xtemplate.xtmpl' AND type = 'theme' 0.66 1 INSERT INTO system (name, description, type, filename, status, throttle, bootstrap) VALUES ('pushbutton', 'themes/engines/xtemplate/xtemplate\0engine', 'theme', 'themes/pushbutton/xtemplate.xtmpl', 1, 0, 0) 0.68 1 DELETE FROM system WHERE filename = 'themes/pushbutton-new/xtemplate.xtmpl' AND type = 'theme' 0.67 1 INSERT INTO system (name, description, type, filename, status, throttle, bootstrap) VALUES ('pushbutton-new', 'themes/engines/xtemplate/xtemplate\0engine', 'theme', 'themes/pushbutton-new/xtemplate.xtmpl', 0, 0, 0) 0.67 1 DELETE FROM system WHERE filename = 'themes/chameleon/marvin/style.css' AND type = 'theme' 0.65 1 INSERT INTO system (name, description, type, filename, status, throttle, bootstrap) VALUES ('chameleon/marvin', 'chameleon', 'theme', 'themes/chameleon/marvin/style.css', 0, 0, 0) 0.68 1 DELETE FROM system WHERE filename = 'themes/manji/obsidian/style.css' AND type = 'theme' 0.65 1 INSERT INTO system (name, description, type, filename, status, throttle, bootstrap) VALUES ('manji/obsidian', 'manji', 'theme', 'themes/manji/obsidian/style.css', 0, 0, 0) 1 1 SELECT * FROM blocks WHERE (status = 1 OR custom = 1) ORDER BY weight, module ------------------------------------------------------------------------ March 21, 2005 - 10:41 : Carl McDade The devel.module works on 4.5.2? or are you using a personally modified version? ------------------------------------------------------------------------ March 21, 2005 - 10:58 : Junyor I used the CVS version. Worked fine.

1 0

[drupal-devel] [bug] Theme Selector Gets Confused If Multiple Subdirectories exist with same name
by TDobes 28 Mar '05

28 Mar '05

Issue status update for http://drupal.org/node/16674 Project: Drupal Version: cvs Component: theme system Category: bug reports Priority: minor Assigned to: Anonymous Reported by: Anonymous Updated by: TDobes -Status: active +Status: by design This is "by design". The Drupal theme system uses the directory name as the theme name. Theme names are meant to be mutually exclusive. (Two themes with the same name is illegal.) TDobes Previous comments: ------------------------------------------------------------------------ February 3, 2005 - 01:24 : Anonymous Hi, If I'm working with the new Drupal theme system, and create multiple directories with the same name, even in different subdirectories, then Drupal picks only one to display (the one in the deepest file hierarchy). This is reflected if you do the following: Go to the themes directory. Copy "bluemarine" to a name like "themeB". cd into chameleon. Copy "marvin" to a name like "themeB". Go to "Administer Themes" in the Drupal menu. You will notice that themeB in 'themes/chameleon/themeB' is the only one listed. The user would normally expect that two be listed: 'themes/themeB' and 'themes/chameleon/themeB'. VERY minor bug but a bug nonetheless. Thank you,

1 0

[drupal-devel] Module is ready for beta release, project created...what now?
by Scott Courtney 28 Mar '05

28 Mar '05

Good evening! I've had a rather productive couple of days this weekend, and a lot of Drupal- related fun. :-) In addition to contributing several bug-fix patches to other people's modules, I've taken some code that I originally wrote as standalone PHP for one of my web sites long before I ever heard of Drupal, and have turned it into a full-blown Drupal module compatible with version 4.5 and 4.6 (HEAD). It has fairly extensive documentation, both within the module and as an external set of text files (README.txt, INSTALL.txt, CHANGELOG.txt, TODO.txt). There is one known bug (a very minor one) in the module, but essentially it's feature-complete and ready for a public release. Currently the code is in my sandbox directory (my drupal.org username is "syscrusher"). I have updated the documentation, cleaned the code up to Drupal readability standards (or at least reasonably close), and have created a project on drupal.org. So....what do I do next? Is there a point at which I need to move this code from /contributions/sandbox/syscrusher/hof/ to /contributions/modules/hof/ ? And do I need to be tagging it with DRUPAL-4_5 or DRUPAL-4_6? If so, when do I do that? Is there someone I should notify that I'm ready to release this thing, or is that taken care of automatically by the fact that I created a project? What's the right CVS procedure to mark one code version for *both* Drupal versions, since it works without changes in each? Also, one other really silly question: When I asked for my CVS account, I chose the name "syscrusher" to match a Drupal login name that I picked on a whim. It occurs to me that if I'm going to be doing this much development, it may not be intuituve that "syscrusher" in CVS is "scott at 4th.com" on the email list. Should I be looking at changing my CVS account over to something like "scott_courtney" or something like that? If so, whom do I contact to request the change? (I know how to change my Drupal login name, of course.) Please pardon if these are dumb questions, and thanks for any advice. Now I move onto the "walkah" image.module enhancements and the new weblinks bundle. It's going to be a fun coding week. :-) Scott -- -----------------------+------------------------------------------------------ Scott Courtney | "I don't mind Microsoft making money. I mind them scott(a)4th.com | having a bad operating system." -- Linus Torvalds http://4th.com/ | ("The Rebel Code," NY Times, 21 February 1999) | PGP Public Key at http://4th.com/keys/scott.pubkey

2 1

[drupal-devel] [bug] Konqueror 3.3.x problems with forms input inside fieldset tags
by syscrusher 28 Mar '05

28 Mar '05

Issue status update for http://drupal.org/node/16729 Project: Drupal Version: cvs Component: node system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: syscrusher Updated by: syscrusher Status: active The bug also bit me on the drupal.org site. I finished a new module and tried to create a project to announce it, but one of the required fields in the node/add/... page for Project has the CSS bug. I had to switch to Firefox in order to create the project, because I couldn't enter the data from Konqueror. syscrusher Previous comments: ------------------------------------------------------------------------ February 4, 2005 - 00:33 : syscrusher Certain versions of the Konqueror browser have a serious problem with form input in Drupal 4.4.x and 4.5.x. The symptoms are that keyboard and mouse input is completely ignored in the affected "text" and "textarea" fields. The symptoms only occur on textual fields that occur within a <fieldset>...</fieldset> tag set. This occurs, for example, when the form_group() API function is invoked. I have tested several variants on the fieldset attributes, and as far as I can tell it doesn't matter what attributes are applied. I also tried it with a manually-created <fieldset><input type="text" ... /></fieldset> sequence, to eliminate the subtags such as legend, description, and title. The problem occurs even with a bare fieldset, and immediately goes away when the form elements are used without being in a fieldset. I further tested to ensure that the <table> tag was not involved, because a Google search suggested that there were problems with tables and fieldsets in Konqueror. Again, the problem is duplicable with no table in the fieldset. It took a lot of digging, but I have finally traced the problem to the file misc/drupal.css. Specifically, the following clause appears to be at fault: .node-form fieldset { display: inline; } If I comment out the "display: inline;" attribute, then the fields work correctly. There does not appear to be any ill effect from this so far, but I haven't tested extensively nor have I tested to see if this patch breaks any other browsers. I can duplicate this problem across several patch levels of Konqueror 3.3.0, and across Drupal 4.5.0 through 4.5.2. ------------------------------------------------------------------------ February 4, 2005 - 01:14 : syscrusher I've verified that the patch doesn't break Firefox 1.0, and also that it /does/ fix the problem with Konqueror 3.3.0 in Drupal 4.4, on one of my production sites. Incidentally, the problem doesn't occur with older Konqueror versions, as far as I can tell. ------------------------------------------------------------------------ March 26, 2005 - 14:15 : Steven I believe that piece of CSS is there for IE5, but I can't remember if it was for Windows or Mac. I'll do some testing later. ------------------------------------------------------------------------ March 26, 2005 - 15:00 : Junyor Works fine in Safari and Opera with or without that rule. IE 5 seems to have the same problem with or without it. In 4.5.2, the fieldsets aren't displayed at all. In HEAD, they cross the screen, pushing everything else down. In other words, it doesn't seem to have any bad effects on Mac browsers with or without that rule. ------------------------------------------------------------------------ March 26, 2005 - 15:09 : syscrusher BTW, I can also duplicate this bug with the CVS version of Drupal 4.6 as of 2005-03-24. ------------------------------------------------------------------------ March 27, 2005 - 07:28 : stefan nagtegaal I can verify that this works flawlesly with drupal 4.6 and any Mac browser.. It would be nice if this would be applied..

1 0

[drupal-devel] [bug] Content Admin renders wrong in Safari
by Steven 28 Mar '05

28 Mar '05

Issue status update for http://drupal.org/node/18517 Project: Drupal -Version: cvs +Version: 4.5.2 Component: admin.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: osmif Updated by: Steven -Status: active +Status: duplicate Duplicate of #17343 [1]. [1] http://drupal.org/node/17343 Steven Previous comments: ------------------------------------------------------------------------ March 7, 2005 - 20:53 : osmif Attachment: http://drupal.org/files/issues/safari-issue.jpg (36.77 KB) Take a look at the attached screenshot. Thanks.

1 0

[drupal-devel] [bug] system/test causes various problems on various hosts
by chx 28 Mar '05

28 Mar '05

Issue status update for http://drupal.org/node/19515 Project: Drupal Version: cvs Component: system.module Category: bug reports Priority: critical Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/system_test_patch (2.68 KB) 4.6 is only RC yet but I already got support requests on #drupal-support and at various Hungarian places about "admin/settings not displayed". Apparently, opening sockets is not a clean business. It has various problems in BSD jails, Windows boxes and who knows where else. I pray on my knees -- do not release 4.6 with the current test in admin/settings. It will be a support nightmare. My patch tries to load a random named gif which is of course a Drupal page which sets clean_url_ok to 1 and prints the 42 bytes required for a 1x1 GIF. Because it is random named, it is impossible that the information "no such information" gets cached in a stupid proxy or browser. When AJAX hits the core, we will be able to check whether the request is OK or not. For now, we can only check after submit. chx

4 7