March 2005 - Development - lists.drupal.org

[drupal-devel] [feature] Dependency system to solve forum without comment problem
by chx 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/18447 Project: Drupal Version: cvs Component: system.module Category: feature requests Priority: normal Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/depend.patch (3.22 KB) As discussed on the developer list. This was surprisingly easy. There is still an issue: t('The configuration options have been saved.') is displayed more than once if there is a dependency forced module switch on. I have tried something (you'll see) for some reason it does not work. Number of page reloads can be decreased if Drupal could be reinitialized after system_listing_save instead of redirecting but I doubt this would be feasible. Although I marked this is feature request, this is more a usability issue (for the forum-comment dependency) and as a side effect it is a useful feature, too (for any other module "bundles"). I want criticism! I'd like to get torn apart by wild animals. Heavy! Eaten by some squirrels. chx

14 45

[drupal-devel] [feature] New field type for profile: taxonomy
by wiz 15 Sep '05

15 Sep '05

Issue status update for http://drupal.org/node/19014 Project: Drupal Version: cvs Component: profile.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: wiz Updated by: wiz Status: patch Attachment: http://drupal.org/files/issues/profile-taxonomy.patch (3.87 KB) A new type of field in the profile: taxonomy, useful for a field to select zero or more terms from a vocabulary. This works like the type "selection" but multiple selection is possible, and the list of choices comes from a taxonomy. Unfortunately there is no field in the table profile_fields to store single/multiple selection - which would be nice for the type "selection", too. The selection is stored in a new table (profile_values_term) additionally to the column profile_values.value. This allows for easy processing of the selection the user made. I have not defined any indexes on this new table, which possibly would be required for large data sets. It has a small bug: when nothing is selected, it will automatically select the first entry. The fix would probably have to modify _taxonomy_term_select in taxonomy.module. wiz

2 2

[drupal-devel] [feature] OPML Import for Aggregator
by arnabdotorg 10 Sep '05

10 Sep '05

Project: Drupal Version: cvs Component: aggregator.module Category: feature requests Priority: normal Assigned to: arnabdotorg Reported by: arnabdotorg Updated by: arnabdotorg Status: patch Attachment: http://drupal.org/files/issues/import_opml.patch (3.96 KB) The aggregator supports OPML export for all feeds, but not import. This patch enables import of OPML lists, allowing people to import lists of RSS feeds they've already assembled in another RSS app. Demo: http://arnab.drupaldevs.org/aggregator Patch: http://arnab.drupaldevs.org/tmp/import_opml.patch arnabdotorg -- View: http://drupal.org/node/16282 Edit: http://drupal.org/project/comments/add/16282

5 6

[drupal-devel] [feature] introduce filapi hook
by Bèr Kessels 02 Sep '05

02 Sep '05

Issue status update for http://drupal.org/node/18934 Project: Drupal Version: 4.5.2 Component: file system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: Bèr Kessels Status: patch This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr Bèr Kessels

12 20

[drupal-devel] [bug] (4.6.0RC) Node stats wrongly displayed
by jeancf 31 Aug '05

31 Aug '05

Issue status update for http://drupal.org/node/19780 Project: Drupal Version: cvs Component: statistics.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: jeancf Updated by: jeancf Status: active I have the statistics module enabled but I want to see node counters only when I am logged in as super user. I don't want my users to see them. So I have "display counter values" set to enabled under administrer > settings > statistics and all roles unchecked under administer > access control > statistics module > access statistics. And still when I log out (anonymous user role) nodes display the node counter. I know this worked under 4.5.2. and was VERY convenient. Is this a feature or a bug in 4.6.0RC? Thanks, JC jeancf

3 2

[drupal-devel] [feature] Multiple select functionality in profile module
by mathias 28 Aug '05

28 Aug '05

Issue status update for http://drupal.org/node/19356 Project: Drupal Version: cvs Component: profile.module Category: feature requests Priority: normal Assigned to: mathias Reported by: mathias Updated by: mathias Status: patch Attachment: http://drupal.org/files/issues/profile-multiple-select.patch (7.48 KB) This patch adds a 'multiple select' checkbox to the 'list selection' field type interface, allowing users to select multiple items from a single list. It looks the same as the 'multiple select' checkbox used during vocabulary creation. Field values are stored separately in the profile_values table and thus don't need to be serialized, keeping search functionality in tact. Note: this patch is not intended for 4.6. mathias

3 5

[drupal-devel] [feature] Taxonomy rewrite
by chx 21 Aug '05

21 Aug '05

Project: Drupal Version: cvs Component: taxonomy.module Category: feature requests Priority: normal Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/taxonomy_db_rewrite.patch (6.71 KB) I'd like to present a use for db_rewrite_sql: taxonomy rewrites. If this goes through, it will be possible to create an access mechanism, languages and whatever for taxonomy. This is a very small change, I think, much smaller than the node_rewrite_sql megpatch was 'cos at the moment nothing changes. There are no DISTINCTs deleted. But this opens a door for future things. Also, this only affects taxonomy.module, 'cos no other module deals with term_data and vocabulary tables (well, forum.module does, but those queries does not need a rewrite). chx -- View: http://drupal.org/node/16452 Edit: http://drupal.org/project/comments/add/16452

8 21

[drupal-devel] [bug] Allow both postgres and mysql database connections from within the same site.
by adrian 17 Aug '05

17 Aug '05

Issue status update for http://drupal.org/node/19522 Project: Drupal Version: cvs Component: database system Category: bug reports Priority: normal Assigned to: adrian Reported by: adrian Updated by: adrian Status: patch Attachment: http://drupal.org/files/issues/multi-dbtype.diff (14.57 KB) When I originally coded the multiple database support I noted the caveat that only one database type was useable at a time due to the conflicting function names, so including both database.pgsql.inc and database.mysql.inc would cause a crash. This was also brought up again when someone reopened the multi-db functionality issue, and I am attaching the patch here. I would love for this patch to get into 4.6 if possible. I don't believe it's very invasive, and it fixes a long standing bug in the db api. I have been using some form of this patch on Bryght for the last 3-4 months, and have not found any ill effects related to it. I also clarified the db_set_active() comments a bit after I saw this issue (http://drupal.org/node/13115) adrian

3 4

[drupal-devel] [bug] welcome text appears when the query in node_page_default is rewritten to have an empty result
by chx 17 Aug '05

17 Aug '05

Issue status update for http://drupal.org/node/18340 Project: Drupal Version: cvs Component: node.module Category: bug reports Priority: normal Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/default_as_node.patch (8.55 KB) As discussed on IRC, I have moved the welcome text into node 0 as a PHP node. Although there is a check for whether this welcome node is present for every node_page_default call, it is only a variable_get, so it is cheap. Also at every node save we check for the same variable, and if the welcome node is present, it gets silently deleted. So, as soon as the first node gets created, the welcome text disappears as it should. The one liner in node_validate is very important when a node with nid=0 is present. Otherwise, consider it a minor speedup. This patch should have a little positive effect on the memory requirements of node.module -- a long, rarely used text is removed. This is not a new feature but a usability issue so let's get it into 4.6. Although there is change (two INSERTs) to database.mysql and database.pgsql it does not mandate an update.inc change 'cos most probably noone will bother with updating an empty site. I payed special attention to spaces this time. chx

6 15

[drupal-devel] [task] Make local tasks more themeable
by drumm 13 Aug '05

13 Aug '05

Project: Drupal Version: cvs Component: menu system Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch There is currently a lot of code that does some heavy lifting in the local task themeable functions. This is a bit of a simplification. No HTML is changed by this refactoring. To test this I tried making the local tasks hierarchical instead of two unordered lists. This was a easy change to do, with about 3 lines of changes. drumm -- View: http://drupal.org/node/17869 Edit: http://drupal.org/project/comments/add/17869

3 8