March 2005 - Development - lists.drupal.org

[drupal-devel] [bug] Post title written twice when posting using BloggerAPI
by david 13 Apr '05

13 Apr '05

Issue status update for http://drupal.org/node/19406 Project: Drupal Version: cvs Component: blogapi.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: david(a)puntbarra.com Updated by: david(a)puntbarra.com Status: patch Attachment: http://drupal.org/files/issues/blogapi.blogger.duptitle.patch (362 bytes) Wrong variable name causes post title not to be removed from the content and posted twice (in title and body). It only affects BloggerAPI posts, not metaWeblogAPI nor mtAPI. This bug affects all Drupal versions AFAIK. david(a)puntbarra.com

3 2

[drupal-devel] [feature] More changes to forum help text
by nysus 13 Apr '05

13 Apr '05

Issue status update for http://drupal.org/node/19434 Project: Drupal Version: cvs Component: forum.module Category: feature requests Priority: normal Assigned to: nysus Reported by: nysus Updated by: nysus Status: patch Attachment: http://drupal.org/files/issues/forum_help.patch (5.98 KB) Here's some more changes to help text in the forum.module by order of significance: "Parent" selection help text: Added help description for this form item found on "admin/forum/add/container" and "admin/forum/add/forum". The help description is different depending on whether the type of component being added is a forum or a container. This change required the modifcation to the argument list passed to an internal function to forum.module. Removed duplicate help language created by the change above. Cut the fat from the help blurb on the "create content" page. "Weight" selection help text on "admin/forum/add/container" and "admin/forum/add/forum": Improved wording and made it more detailed. Help language for "name" and "description" fields on "admin/forum/add/container" and "admin/forum/add/forum" pages made more consistent and concise. Changed instances of "topic discussions" to "discussion topics" nysus

5 9

[drupal-devel] [feature] Alternative caching for high traffic websites
by Jeremy 12 Apr '05

12 Apr '05

Issue status update for http://drupal.org/node/19298 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Jeremy(a)kerneltrap.org Reported by: Jeremy(a)kerneltrap.org Updated by: Jeremy(a)kerneltrap.org Status: patch Attachment: http://drupal.org/files/issues/database.mysql_1.patch (382 bytes) Drupal's existing caching mechanism doesn't perform well on highly dynamic websites in which the cache is flushed frequently. One example is a site that is under attack by a spambot that is posting spam comments every few seconds, causing all cached pages to be flushed every few seconds. The attached patches provide the following cache methods: 1) CACHE_DISABLED: no caching. This is unchanged from before. 2) CACHE_ENABLED_STRICT: This is Drupal's existing caching method, in which the cache is flushed immediately whenever it contains invalid data. 3) CACHE_ENABLED_LOOSE: This is the new caching method (feel free to suggest a better name, this is the best I could come up with tonight). Essentially, it immediately flushes the cache only for specific users who have modified cached data (whether or not they are logged in), delaying the flushing of data for other users by several minutes. This feature requires a new 'cache' field in the sessions table to track the cache status for each user, whether or not they are logged in. A one line change to the system.module updates the cache configuration settings to include an additional option for loose caching. The rest of the changes are in bootstrap.inc, as follows: - cache_clear_all: if strict caching is enabled, nothing is changed. If loose caching is enabled, we delay the flushing of the entire cache for 5 minutes. Instead, we update this user's cache field in the sessions table so we know any cache pages created before the current time are no longer valid for this user. We only set the global "cache_flush" variable if it's not already set. If the global "cache_flush" variable was set more than 5 minutes ago, we flush all cache pages that were expired when the "cache_flush" variable was set. - cache_get: if strict caching is enabled, nothing is changed. If loose caching is enabled, we first check the global "cache_flush" variable and if older than 5 minutes we do a garbage collection call to cache_clear_all. Next, we see if there is a valid cache entry for us. If the cache entry is older than our session table's "cache" field, we don't use it. This will cause the cache to be regenerated by the current user, and ultimately updated for all users. Attached is the patch to database.mysql. To add manually, execute the following: ALTER TABLE sessions ADD cache int(11) NOT NULL default '0' AFTER timestamp; Jeremy(a)kerneltrap.org

9 27

[drupal-devel] [feature] Add Folksonomy, or "Free Tagging", to Taxonomy
by Morbus Iff 11 Apr '05

11 Apr '05

Issue status update for http://drupal.org/node/19697 Project: Drupal Version: cvs Component: taxonomy.module Category: feature requests Priority: normal Assigned to: Morbus Iff Reported by: Morbus Iff Updated by: Morbus Iff Status: patch Attachment: http://drupal.org/files/issues/taxonomy_all.patch (19.53 KB) This patch adds folksonomy support to Drupal (named internally as "Free tagging"). In a nutshell, the core difference is the input method: unlike normal taxonomies which are administratively controlled, a "free tagging" vocabulary allows tag creation when the node is submitted. It does this through an text input box, as opposed to a dropdown or selectbox. This patch: Removes the useless "Preview form" of a vocabulary. Alters the vocabulary table to include a new "tags" column. Adds a new "Free tagging" preference on vocabulary creation/editing. Modifies the vocabulary overview to support pagers for free tagging vocabs. The new code integrates tightly with the existing taxonomy code. The only additional processing occurs on node save and edit, where we parse through the tags associated with a node. All other display (and thus, code) remains the same. The following screenshots illustrate the changes, integration, and workflow: Create/edit vocabulary screen. [1] Create/edit a node. [2] Result of previous screen. [3] The new admin/taxonomy. [4] Clicking on \"view terms\". [5] These patches were made during the exploration and customization of Drupal by http://www.NHPR.org. In loving support of open source software, http://www.NHPR.org will continue to contribute patches they feel the community will benefit from. Questions about this patch should be directed to morbus(a)disobey.com. [1] http://disobey.com/detergent/2005/drupal_folkdef.jpg [2] http://disobey.com/detergent/2005/drupal_folknodeedit.jpg [3] http://disobey.com/detergent/2005/drupal_folknodesubmit.jpg [4] http://disobey.com/detergent/2005/drupal_folkpager1.jpg [5] http://disobey.com/detergent/2005/drupal_folkpager2.jpg Morbus Iff

17 49

[drupal-devel] [bug] Patch for localized date in aggregator feed page
by carlosparamio 11 Apr '05

11 Apr '05

Issue status update for http://drupal.org/node/19109 Project: Drupal Version: cvs Component: aggregator.module Category: bug reports Priority: normal Assigned to: carlosparamio Reported by: carlosparamio Updated by: carlosparamio Status: patch Attachment: http://drupal.org/files/issues/aggregator_localized_date.path (407 bytes) Here is a patch for aggregator module so aggregator feed page shows dates with month name in localized version. carlosparamio

2 1

[drupal-devel] [bug] deleted users' nodes disappear
by menesis 11 Apr '05

11 Apr '05

Issue status update for http://drupal.org/node/19055 Project: Drupal Version: 4.5.2 Component: node.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: menesis Updated by: menesis Status: patch Attachment: http://drupal.org/files/issues/node_user_delete.diff (507 bytes) When a user is deleted, all nodes which he created can't be accessed anymore, because they have non-existing uid and queries which select from node and user tables fail. There are two ways to fix that: 1) also delete nodes. 2) reset nodes' author to Anonymous. 1 is most probably undesirable side effect. When I encountered such problem I was happy those nodes were still in database and I could bring them back by changing uid. Otherwise I would have lost the content. Here is a simple patch which implements 2) - sets node.uid to 0 (Anonymous). menesis

7 11

[drupal-devel] hi, etc
by Daniel Convissor 08 Apr '05

08 Apr '05

Hi: I'm new to Drupal, but have long involvement in the PHP community. For instance, I'm the lead maintainer of PEAR's DB package and am involved with the PEAR documentation and website teams. A client of mine needs a CMS and I'm very impressed with how well the Drupal website is organized. I'm also enjoying Drupal's code itself. I submitted two code maintenance patches: http://drupal.org/node/19609 http://drupal.org/node/19474 One more thing I would like to do is make multi-site installations easier by providing scripts for performing the table name prefix substitutions. As I move forward with helping this client, I'm sure I'll come across more ways to improve Drupal. To these ends, I'm interested in obtaining the ability to make commits to the repository, please. Hmm, now that I'm looking at http://drupal.org/node/19474 I see people have commented on it. That's great. I'm used to bug systems sending an email when someone comments. I didn't receive such emails in response to these people's comments. Does Drupal's system not do that or am I missing something? My email address is correct, since I got the initial confirmation when setting up my account. Sincerely, --Dan -- T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y data intensive web and database programming http://www.AnalysisAndSolutions.com/ 4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409

9 24

[drupal-devel] [feature] settings.php: better instructions for $db_url and $db_prefix
by danielc 08 Apr '05

08 Apr '05

Issue status update for http://drupal.org/node/19474 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: danielc Updated by: danielc Status: patch Attachment: http://drupal.org/files/issues/settings.diff (2.49 KB) Improves instructions in /drupal/sites/default/settings.php: * How to escape URL characters in $db_url. * How to use the array format of $db_prefix. danielc

5 7

[drupal-devel] [bug] comment stats don't update after approval in moderation queue
by ankur 08 Apr '05

08 Apr '05

Issue status update for http://drupal.org/node/18215 Project: Drupal Version: 4.5.2 Component: comment.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: ankur Updated by: ankur Status: patch Attachment: http://drupal.org/files/issues/comment.module_5.diff (861 bytes) I don't know if this is by design, but I experimenting with forcing anonymous comments through the comments approval queue. After I logged in as someone with appropriate permissions and marked the comment "published" in the comments approval queue, the link attached to the appropriate node teaser still said "add new comment" rather than "1 comment" or "1 new comment". Here's a patch for it. I believe the diff for the patch is taken against comment.module from 4.5.2. It makes some minor additions to function comment_admin_edit(). -Ankur ankur

6 13

[drupal-devel] [feature] Separate prefetch request log
by drumm 08 Apr '05

08 Apr '05

Issue status update for http://drupal.org/node/19781 Project: Drupal Version: cvs Component: statistics.module Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/statistics.module.diff (6.15 KB) So Google went and put prefetch in search results [1]. I predict that the semantic HTML with CSS community will start using this more and more. And we might find places to use it in Drupal. Since these prefetch requests aren't exactly the same as other requests we should probably have another log for those hits. [1] http://www.google.com/googleblog/2005/03/enhanced-searching-with-firefox.ht… drumm

2 1