March 2005 - Development - lists.drupal.org

[drupal-devel] [bug] List of bloggers
by Bèr Kessels 17 Mar '05

17 Mar '05

Issue status update for http://drupal.org/node/17030 Project: Drupal Version: cvs Component: blog.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: Bèr Kessels Status: patch Attachment: http://drupal.org/files/issues/blog_bloggers_list_2_0.patch (1.71 KB) sigh. something tells me i should stop working.... a silly "F" sneaked into the previous patch. Bèr Kessels Previous comments: ------------------------------------------------------------------------ February 9, 2005 - 00:27 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list.patch (1.66 KB) Small patch to show a list of bloggers. We all should know that blog.module is not meant for personal blogging, but that set aside, we do not have a way to show all bloggers, on a site as a list. This patch ads a few lines that will allow you to show that overview of blogging users. It ads a menu item, disabled by default that shows such a list. ------------------------------------------------------------------------ February 9, 2005 - 00:31 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list.png (4.02 KB) Here is a small screeny that shows what this is about. ------------------------------------------------------------------------ February 9, 2005 - 00:34 : Bèr Kessels Attachment: http://drupal.org/files/issues/list_bloggers_2.png (2.25 KB) hmm. error in my png file. Here is a correct one. ------------------------------------------------------------------------ February 19, 2005 - 21:13 : Emiliano Hi Bèr Kessels! Thanks for the patch! It's really useful! :-) I just noticed what I think is a little mistake in this line: $items[] = l($row->name, 'blog/'.$row->uid)." ".theme('xml_icon', url('blog/'.$row->uid.'/feed'), TRUE); Which I believe should end like: $items[] = l($row->name, 'blog/'.$row->uid)." ".theme('xml_icon', url*('blog/feed/'.$row->uid)*, TRUE); Ah, and BTW, "db_rewrite_sql" didn't work for me... I just cut it off... ;-) Cheers, Emiliano. ------------------------------------------------------------------------ March 17, 2005 - 23:17 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list_2.patch (1.81 KB) and here is the actual patch. (i think i really need some script that tells me i did not attach a patch ;) )

1 0

[drupal-devel] [bug] List of bloggers
by Bèr Kessels 17 Mar '05

17 Mar '05

Issue status update for http://drupal.org/node/17030 Project: Drupal Version: cvs Component: blog.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: Bèr Kessels -Status: active +Status: patch Attachment: http://drupal.org/files/issues/blog_bloggers_list_2.patch (1.81 KB) and here is the actual patch. (i think i really need some script that tells me i did not attach a patch ;) ) Bèr Kessels Previous comments: ------------------------------------------------------------------------ February 9, 2005 - 00:27 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list.patch (1.66 KB) Small patch to show a list of bloggers. We all should know that blog.module is not meant for personal blogging, but that set aside, we do not have a way to show all bloggers, on a site as a list. This patch ads a few lines that will allow you to show that overview of blogging users. It ads a menu item, disabled by default that shows such a list. ------------------------------------------------------------------------ February 9, 2005 - 00:31 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list.png (4.02 KB) Here is a small screeny that shows what this is about. ------------------------------------------------------------------------ February 9, 2005 - 00:34 : Bèr Kessels Attachment: http://drupal.org/files/issues/list_bloggers_2.png (2.25 KB) hmm. error in my png file. Here is a correct one. ------------------------------------------------------------------------ February 19, 2005 - 21:13 : Emiliano Hi Bèr Kessels! Thanks for the patch! It's really useful! :-) I just noticed what I think is a little mistake in this line: $items[] = l($row->name, 'blog/'.$row->uid)." ".theme('xml_icon', url('blog/'.$row->uid.'/feed'), TRUE); Which I believe should end like: $items[] = l($row->name, 'blog/'.$row->uid)." ".theme('xml_icon', url*('blog/feed/'.$row->uid)*, TRUE); Ah, and BTW, "db_rewrite_sql" didn't work for me... I just cut it off... ;-) Cheers, Emiliano.

1 0

[drupal-devel] Core Folksonomy: New Pager UI Available
by Morbus Iff 17 Mar '05

17 Mar '05

I've committed some new code. Screenshots below. The latest update is an attempt at a new administrative display for vocabularies and their terms. The goal here is to make something that is functional for a vocabulary with 1000+ terms. This code applies equally to folksonomy or a controlled vocab. Granted, a 1000+ term folksonomy is a lot easier to create than a 1000+ controlled vocab. But. Anyways. # the new "show vocabularies" screen. no terms. http://disobey.com/detergent/2005/drupal_folkpager1.jpg # the "view terms" screen. http://disobey.com/detergent/2005/drupal_folkpager2.jpg I realize the "Help" is now incorrect. It's on the TODO. I've also set the pager increment small so as to make a visual example of the new UI. The default increment will be 50, not 5. The screenshots don't show it, but the display of hierarchies is unchanged from core. This new pager code seems (feels like?) to take up more changes than the actual code necessary to make folksonomy work. It's required though. The code in CVS is crusty - I had some trouble getting the "add term" tab to function properly with the existing (equally crusty) code [1; Help!] I added a lot of TODOs today based on this new pager code, as well as discussions in #drupal regarding naming, phrasing, input expectations, etc., etc. Good stuff. But today's patch is definitely rougher than yesterday. I'll begin work anew sometime next week. [1] Help! I'm not sure how far I should go between fixing the crusty code, thus making the patch even bigger and much less about "only" folksonomy, or including equally crusty code to complement what's already there. Today's patch is all about complementing. -- Morbus Iff ( you are nothing without your robot car, NOTHING! ) Culture: http://www.disobey.com/ and http://www.gamegrene.com/ Spidering Hacks: http://amazon.com/exec/obidos/ASIN/0596005776/disobeycom icq: 2927491 / aim: akaMorbus / yahoo: morbus_iff / jabber.org: morbus

1 0

[drupal-devel] [task] search_preprocess shall use module_implements
by chx 17 Mar '05

17 Mar '05

Issue status update for http://drupal.org/node/19063 Project: Drupal Version: cvs Component: search.module Category: tasks Priority: normal Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/search_1.patch (852 bytes) This is trivial. chx

1 0

[drupal-devel] Core Folksonomy: First Code Available
by Morbus Iff 17 Mar '05

17 Mar '05

I've commited into sandbox/morbus/folksonomy_shared (along with a bunch of documentation and design decisions) the first, very rough and not heavily tested, version of folksonomy_shared. There are still a number of things to do (and a few known bugs to fix) but I wanted to show you what I have. Here is the new vocabulary definition screen: http://www.disobey.com/d/2005/drupal_folkdef.jpg My change is in yellow. Now, assume that we've got two vocabularies: a "Folksonomy Tags" (per the screenshot) and a "Controlled Test", which is a normal old Drupal taxonomy. They've both been assigned to node type "page". Here is the screenshot: http://disobey.com/detergent/2005/drupal_folknodenew.jpg Now, let's assume we've entered some data. We've chosen "Cheshire Cat" from the "Controlled Test", and entered the following for tags: "happy, sad, crazy, whoa!" Here is the resulting screenshot: http://disobey.com/detergent/2005/drupal_folknodesubmit.jpg Notice how three new "Folksonomy Tags" (trust me on the proper vid) terms were created (implying that "crazy" already existed in the "Folksonomy Tags" vocabulary). Likewise, note how they are treated equally in the node display ("Cheshire Cat" comes from our "Controlled Test" vocab). Finally, the edit screen, though there's nothing to exciting here: http://disobey.com/detergent/2005/drupal_folknodeedit.jpg More as I have it. -- Morbus Iff ( you are nothing without your robot car, NOTHING! ) Culture: http://www.disobey.com/ and http://www.gamegrene.com/ Spidering Hacks: http://amazon.com/exec/obidos/ASIN/0596005776/disobeycom icq: 2927491 / aim: akaMorbus / yahoo: morbus_iff / jabber.org: morbus

6 19

[drupal-devel] Core Folksonomy: Not Ready for term_node.uid?
by Morbus Iff 17 Mar '05

17 Mar '05

Seeing a few more hours left in the day, I started thinking about my proposed change to term_node, which would add a new "uid" column. The argument for it was, in a nutshell: * no duplication of data when the following occurs: * future possibility of "all users can tag any node" Besides the fact that I personally didn't /need/ the feature, I thought it was easy to code in, and provided a lot of future contrib possibilities. Because of this, I fought against questions by jbond and killes regarding "well, can't you just use node.uid to determine 'My Tags'?" I'm now leery on moving forward with this addition. It's a tricky bug, so I'll sum it up here: * administrators should be able to do everything. * administrators will not be able to delete an /individual/ uid's entry in the term_node table. the only solution would be a whole new set of UI screens. The problem isn't the INSERTs or backwards compatibility. Easy as pie. The big problem is that, on node save, the taxonomy code deletes all assigned nid/tids in the term_data, and then recreates them fresh from the incoming $edit data. This is a sensible thing to do - I've used the same trick before. With the addition of the term_node.uid though, it becomes not only "what nid/tids do I delete?", but also "what uid's nid/tids do I delete?". And THAT's the big problem. You are a normal user with node create capability. You add a brand new node, and you add some new terms. Your uid is saved into term_node.uid with these tids. A day later, you go back and edit the node, tweaking the terms. Taxonomy.module deletes all nid/tids matching your uid from term_node. Taxonomy.module resaves your tweaked nid/tids with your uid. So far, no big deal. A uid-aware DELETE would be: DELETE FROM {term_node} WHERE nid = $nid AND uid = $uid; Now, assume for the moment: You are an administrator and you'd like to edit the node. The folksonomy input becomes prefilled with ALL tids assigned. You fix the whatever and you save the node. Hilarity ensues. At first glance, this seems to do the "right thing". Since you're a different uid than the normal user, the _save DELETE will delete all nid/tids associated with your uid (in the previous example, none, as of yet). As the node is saved, brand new nid/tids entries are added associated with your uid. From the perspective of the very first two bullets of this email, Everything Is Perfect: two uids have tagged a node independently of each other. Awesome! But, there are two big issues: * ALL assigned nid/tids are placed in the folksonomy input. * The administrator can not modify another uid's nid/tids. At first glance, the easy answer to the first bullet is "well, instead of getting all nid/tids and showing them, just SELECT based on the current uid". And, yeah, that's a proper answer for a multi-user installation, especially considering that 5000 users could give one nid 5000 unique tids, and that'd make a prefilled input pretty unwieldly. But that fix breaks an important tenet: "an administrator should be able to do everything." There'd be no way, without a new and scalable UI, for the admin to say "Normal user has screwed up, and I'd like to modify his, not my, terms for this node." Conclusion for step #1: node.uid is in, term_node.uid is out. This is still a teensy problem, because an admin could edit someone's node adding new tids, and the "My Tags" feature would be slightly incorrect ("hey! the admin added that tag! not me!"). But, "Tags Associated With Nodes I've Created" just doesn't have the same ring to it. -- Morbus Iff ( you are nothing without your robot car, NOTHING! ) Culture: http://www.disobey.com/ and http://www.gamegrene.com/ Spidering Hacks: http://amazon.com/exec/obidos/ASIN/0596005776/disobeycom icq: 2927491 / aim: akaMorbus / yahoo: morbus_iff / jabber.org: morbus

2 6

[drupal-devel] Release critical bugs for March 16, 2005
by drupal-devel＠drupal.org 17 Mar '05

17 Mar '05

Bbcode / bug reports email spam filtering does not "see" email addresses when they are NOT preceded by a word age: 8 weeks 4 days url: http://drupal.org/node/15654 Buddylist / bug reports SQL errors using HEAD from CVS age: 2 weeks 1 day url: http://drupal.org/node/18160 Chatbox / support requests Cron run kills Chat? age: 14 weeks 1 day url: http://drupal.org/node/14032 Drupal / bug reports Bypass access via comments age: 1 hour 36 min url: http://drupal.org/node/19009 New submit error, non-admin user, postgresql database age: 1 week 1 day url: http://drupal.org/node/18552 Module-specific taxonomony support breaks existing sites assigned: walkah age: 1 week 3 days url: http://drupal.org/node/18471 PHP 4.3.11 and upload in IE age: 3 weeks 4 days url: http://drupal.org/node/17595 When I delete a user, any forum in which s/he has commented also disappears. assigned: Jill6q age: 4 weeks 3 hours url: http://drupal.org/node/17428 Path module allows one to override existing (non-aliased) paths. age: 4 weeks 1 day url: http://drupal.org/node/17386 problems with admin/user/configure/permission and 4.5.2 age: 4 weeks 3 days url: http://drupal.org/node/17282 Published poll doesnt show up in poll block if in submission queue age: 5 weeks 6 days url: http://drupal.org/node/16671 Adding two custom blocks with the same name produces a sql warning age: 5 weeks 6 days url: http://drupal.org/node/16659 Cache-Control header not set age: 6 weeks 6 days url: http://drupal.org/node/16295 updates.inc deleting profile_data when updating age: 8 weeks 3 days url: http://drupal.org/node/15686 Change to sesssion.inc violates UID database constraint age: 8 weeks 3 days url: http://drupal.org/node/15666 problem with forum.module with postgresql v7.4.1 age: 9 weeks 2 days url: http://drupal.org/node/15412 forum.module problem with postgresql v7.4.1 age: 9 weeks 2 days url: http://drupal.org/node/15411 PHP 5 gives error when session table has no session assigned: adschar age: 9 weeks 2 days url: http://drupal.org/node/15399 postgresql error age: 9 weeks 6 days url: http://drupal.org/node/15175 Entering an empty title broke drupal age: 17 weeks 2 days url: http://drupal.org/node/12974 Argument NOT must be type boolean age: 17 weeks 2 days url: http://drupal.org/node/12950 Private downloads aren't working age: 19 weeks 5 days url: http://drupal.org/node/12267 Comments in approval queue still show up in tracker age: 21 weeks 4 days url: http://drupal.org/node/11647 Drupal / feature requests Request New Password Security age: 5 days 18 hours url: http://drupal.org/node/18719 Taxonomy module should use nodeapi 'load' age: 1 week 3 hours url: http://drupal.org/node/18631 Auto PHP memory maximisation age: 3 weeks 2 days url: http://drupal.org/node/17663 Don't reset existing password on request, prevent DoS password reset abuse age: 5 weeks 2 days url: http://drupal.org/node/16909 User info exposed to anonymous user age: 15 weeks 4 days url: http://drupal.org/node/13545 Allow named anchors to work without specifying full path to node age: 1 year 16 weeks url: http://drupal.org/node/4213 Drupal / support requests Fatal error: Unknown column 'headers' in 'field list' query assigned: Eagle-i age: 1 day 5 hours url: http://drupal.org/node/18928 Strange session behavior age: 3 days 16 hours url: http://drupal.org/node/18821 user redirected to homepage when logging in age: 1 week 5 days url: http://drupal.org/node/18381 Problem with Forums age: 9 weeks 4 days url: http://drupal.org/node/15299 Drupal / tasks atom.module working version to 4.5.0 assigned: hugoromano age: 19 weeks 6 hours url: http://drupal.org/node/12496 Consistency assigned: stefan nagtegaal age: 24 weeks 5 days url: http://drupal.org/node/11045 Postgres Compatibility Update assigned: adrian age: 25 weeks 2 days url: http://drupal.org/node/10945 Drupal.org maintenance / bug reports drupaldocs.org and large fonts age: 1 week 5 days url: http://drupal.org/node/18367 Drupal.org print preview crashes Mozilla age: 2 weeks 8 hours url: http://drupal.org/node/18248 Konqueror problem age: 5 weeks 2 days url: http://drupal.org/node/16913 screenshots : page not found age: 5 weeks 5 days url: http://drupal.org/node/16752 Large Fonts problems age: 5 weeks 6 days url: http://drupal.org/node/16664 Drupal.org maintenance / feature requests Plain text posting age: 4 weeks 2 days url: http://drupal.org/node/17335 Event / bug reports Events for March 31, 2005 not showing up in calendar view age: 2 days 1 hour url: http://drupal.org/node/18885 Doesn't work with i18n hack/module age: 2 weeks 1 day url: http://drupal.org/node/18145 search over fields.inc fields conceptual error age: 19 weeks 5 days url: http://drupal.org/node/12259 fields.inc screws up with multible multiselect fields age: 19 weeks 5 days url: http://drupal.org/node/12257 Still GMT/TZ issues with CVS age: 20 weeks 6 days url: http://drupal.org/node/11870 Time entry is GMT even when site default is not age: 21 weeks 4 days url: http://drupal.org/node/11630 Start Time of Event is NOT Preserved age: 38 weeks 6 days url: http://drupal.org/node/8565 Feature / bug reports Menu item not showing age: 23 weeks 5 days url: http://drupal.org/node/11210 File / bug reports segmentation fault related to filestore age: 1 year 24 weeks url: http://drupal.org/node/3001 Filebrowser / bug reports em.. out of root? age: 1 week 16 hours url: http://drupal.org/node/18596 Filestore / support requests File store module - Overwriting Filename....Help needed assigned: harishkm age: 50 weeks 11 hours url: http://drupal.org/node/6827 Unserialize error at line 104 age: 1 year 4 weeks url: http://drupal.org/node/5857 Filestore module- sql errors rectified assigned: harishkm age: 1 year 5 weeks url: http://drupal.org/node/5619 Filestore Module Problems unaddressed assigned: harishkm age: 1 year 7 weeks url: http://drupal.org/node/5365 Gallery / bug reports Mini applet can't find gallery at url / age: 4 days 5 hours url: http://drupal.org/node/18785 "Cannot modify header information" age: 1 week 3 days url: http://drupal.org/node/18457 Fatal error: Undefined class name 'galleryembed' age: 3 weeks 1 day url: http://drupal.org/node/17746 Gallery / support requests Can't Embed Gallery into Drupal age: 2 weeks 3 days url: http://drupal.org/node/18029 Goofy / bug reports Blocks with no name age: 5 weeks 3 days url: http://drupal.org/node/16860 Groups / bug reports Drupal-4.4-rc breaks registration setups and groups.module age: 1 year 4 days url: http://drupal.org/node/6392 Image / bug reports Cannot upload .jpgs age: 2 weeks 2 days url: http://drupal.org/node/18076 Wrongly formed html in image gallery age: 3 weeks 6 days url: http://drupal.org/node/17462 Image.Module does not know the correct filename age: 17 weeks 1 day url: http://drupal.org/node/13032 SAFE MODE Restriction in effect... age: 20 weeks 6 days url: http://drupal.org/node/11843 Uploading jpeg makes Imagemagick do high compression age: 22 weeks 3 days url: http://drupal.org/node/11445 Image module failing on Preview because of a blank node id age: 24 weeks 4 days url: http://drupal.org/node/11069 Similar problem with Directory Upload Slow age: 24 weeks 4 days url: http://drupal.org/node/11064 Node Aggregator / bug reports Import doesn't like XML/RSS feeds with no Title element age: 41 weeks 4 days url: http://drupal.org/node/8128 Node Aggregator / feature requests RSS items overwriting edited items age: 39 weeks 5 days url: http://drupal.org/node/8455 Notify / feature requests Notify.module ignores the true submission queue age: 1 year 20 weeks url: http://drupal.org/node/3765 Online / support requests Need Help age: 3 weeks 6 days url: http://drupal.org/node/17475 Pdfview / feature requests Internationalization support for PDF assigned: TheLibrarian age: 50 weeks 1 day url: http://drupal.org/node/6795 Project / bug reports Invalid link to release files age: 3 weeks 3 days url: http://drupal.org/node/17625 blank page after install age: 6 weeks 1 day url: http://drupal.org/node/16575 "Page Not Found" when trying to view issues or add new release age: 14 weeks 6 days url: http://drupal.org/node/13815 Project pages display only title and description age: 17 weeks 1 hour url: http://drupal.org/node/13082 Fatal error: Cannot use string offset as an array in includes/tablesort.inc on line 113 assigned: publian age: 23 weeks 6 days url: http://drupal.org/node/11187 Can't create new project with issue tracker age: 30 weeks 15 hours url: http://drupal.org/node/10148 Project / support requests Help with everything - nothing seems to work in the latest build age: 16 weeks 2 days url: http://drupal.org/node/13310 Taxonomy dhtml / bug reports javascrip downloads square.gif for every category age: 4 weeks 1 day url: http://drupal.org/node/17366 TrackBack / bug reports Sends trackbacks for unpublished nodes age: 7 weeks 2 hours url: http://drupal.org/node/16239 Overly aggressive age: 14 weeks 5 days url: http://drupal.org/node/13865 trackback borks google and every other search engine age: 19 weeks 2 days url: http://drupal.org/node/12388 User experience / bug reports user interface problem http://drupal.org/forum/1?from=25 age: 2 weeks 13 hours url: http://drupal.org/node/18237 User experience / tasks WorkFlow and Action Module age: 3 weeks 5 days url: http://drupal.org/node/17517 Weblink / bug reports node_access_join_sql() error assigned: pancho age: 1 week 20 min url: http://drupal.org/node/18646 Weblink / feature requests Display of child categories on the weblink directory default page age: 4 weeks 6 days url: http://drupal.org/node/17132 Display of child categories on the weblink directory default page age: 4 weeks 6 days url: http://drupal.org/node/17130

7 10

[drupal-devel] [bug] Theme admin fix-up after multisite patch
by TDobes 17 Mar '05

17 Mar '05

Issue status update for http://drupal.org/node/13738 Project: Drupal Version: cvs Component: theme system Category: bug reports Priority: critical Assigned to: TDobes Reported by: TDobes Updated by: TDobes Status: patch Sorry about that... dumb mistake on my part. When will I learn to clear the menu cache regularly? +1 to jhriggs' patch, which fixes things as promised. (note that the menu cache also needs to be cleared to fix the bug) TDobes Previous comments: ------------------------------------------------------------------------ December 1, 2004 - 02:48 : TDobes Attachment: http://drupal.org/files/issues/fix-styles-after-multisite.patch (632 bytes) There was a major theming issue I missed in my bug-testing after the multi-site patch landed. Styles now seem to have their description field filled with the filename of their parent theme/template rather than the theme_key of the parent. This is a problem because init_theme still expected to see the theme_key and therefore dropped back to the base theme (no theme at all). The attached patch fixes this situation. ------------------------------------------------------------------------ December 1, 2004 - 03:04 : TDobes Note: This might also warrant an update.inc script. Because of this change, sites that were based on styles won't load the proper theme after upgrading until the admin visits the themes administration page an clicks "save." ------------------------------------------------------------------------ December 1, 2004 - 16:41 : Dries Committed. ------------------------------------------------------------------------ March 15, 2005 - 16:03 : TDobes Attachment: http://drupal.org/files/issues/themes-bugfix_and_cleanup.patch (8.77 KB) I did a bit more testing of the theme administration in 4.6 and found a few items that needed improvement. The attached patch fixes a couple bugs, removes some code rot, and cleans up the code a bit: * Fix a bug which would cause the "configure" link for styles to be broken. (missed this in the last patch) * Fix a bug with using drupal_get_filename for theme engines. Although this is not called anywhere in core, we should still fix it for contrib. (i.e. themes that may want to manually invoke a theme engine to create a hybrid theme) * Correct an inaccurate comment in theme.inc * Populate the default primary links with an "edit primary links" link for consistency with the secondary links * remove some unnecessary variables in the theme administration which had misleading and confusing names * replace time-consuming foreach when rendering theme admin page with a more efficient array_key_exists * usability: rather than completely removing the search box checkbox when search.module is disabled, simply disable it. (UI elements shouldn't appear/disappear.) Please commit and/or review prior to 4.6 release. ------------------------------------------------------------------------ March 16, 2005 - 21:04 : jhriggs Attachment: http://drupal.org/files/issues/theme_settings.patch (45 bytes) This patch was applied by Dries but not marked as fixed; however, it introduced a new bug. Theme-specific settings no longer work. The attached patch fixes this. ------------------------------------------------------------------------ March 16, 2005 - 21:06 : jhriggs Attachment: http://drupal.org/files/issues/theme_settings2.patch (722 bytes) Well /that/ didn't work. I'll try again.

1 0

[drupal-devel] [bug] Theme admin fix-up after multisite patch
by jhriggs 17 Mar '05

17 Mar '05

Issue status update for http://drupal.org/node/13738 Project: Drupal Version: cvs Component: theme system Category: bug reports Priority: critical Assigned to: TDobes Reported by: TDobes Updated by: jhriggs Status: patch Attachment: http://drupal.org/files/issues/theme_settings2.patch (722 bytes) Well /that/ didn't work. I'll try again. jhriggs Previous comments: ------------------------------------------------------------------------ December 1, 2004 - 02:48 : TDobes Attachment: http://drupal.org/files/issues/fix-styles-after-multisite.patch (632 bytes) There was a major theming issue I missed in my bug-testing after the multi-site patch landed. Styles now seem to have their description field filled with the filename of their parent theme/template rather than the theme_key of the parent. This is a problem because init_theme still expected to see the theme_key and therefore dropped back to the base theme (no theme at all). The attached patch fixes this situation. ------------------------------------------------------------------------ December 1, 2004 - 03:04 : TDobes Note: This might also warrant an update.inc script. Because of this change, sites that were based on styles won't load the proper theme after upgrading until the admin visits the themes administration page an clicks "save." ------------------------------------------------------------------------ December 1, 2004 - 16:41 : Dries Committed. ------------------------------------------------------------------------ March 15, 2005 - 16:03 : TDobes Attachment: http://drupal.org/files/issues/themes-bugfix_and_cleanup.patch (8.77 KB) I did a bit more testing of the theme administration in 4.6 and found a few items that needed improvement. The attached patch fixes a couple bugs, removes some code rot, and cleans up the code a bit: * Fix a bug which would cause the "configure" link for styles to be broken. (missed this in the last patch) * Fix a bug with using drupal_get_filename for theme engines. Although this is not called anywhere in core, we should still fix it for contrib. (i.e. themes that may want to manually invoke a theme engine to create a hybrid theme) * Correct an inaccurate comment in theme.inc * Populate the default primary links with an "edit primary links" link for consistency with the secondary links * remove some unnecessary variables in the theme administration which had misleading and confusing names * replace time-consuming foreach when rendering theme admin page with a more efficient array_key_exists * usability: rather than completely removing the search box checkbox when search.module is disabled, simply disable it. (UI elements shouldn't appear/disappear.) Please commit and/or review prior to 4.6 release. ------------------------------------------------------------------------ March 16, 2005 - 21:04 : jhriggs Attachment: http://drupal.org/files/issues/theme_settings.patch (45 bytes) This patch was applied by Dries but not marked as fixed; however, it introduced a new bug. Theme-specific settings no longer work. The attached patch fixes this.

1 0

[drupal-devel] [bug] Theme admin fix-up after multisite patch
by jhriggs 17 Mar '05

17 Mar '05

Issue status update for http://drupal.org/node/13738 Project: Drupal Version: cvs Component: theme system Category: bug reports Priority: critical Assigned to: TDobes Reported by: TDobes Updated by: jhriggs Status: patch Attachment: http://drupal.org/files/issues/theme_settings.patch (45 bytes) This patch was applied by Dries but not marked as fixed; however, it introduced a new bug. Theme-specific settings no longer work. The attached patch fixes this. jhriggs Previous comments: ------------------------------------------------------------------------ December 1, 2004 - 02:48 : TDobes Attachment: http://drupal.org/files/issues/fix-styles-after-multisite.patch (632 bytes) There was a major theming issue I missed in my bug-testing after the multi-site patch landed. Styles now seem to have their description field filled with the filename of their parent theme/template rather than the theme_key of the parent. This is a problem because init_theme still expected to see the theme_key and therefore dropped back to the base theme (no theme at all). The attached patch fixes this situation. ------------------------------------------------------------------------ December 1, 2004 - 03:04 : TDobes Note: This might also warrant an update.inc script. Because of this change, sites that were based on styles won't load the proper theme after upgrading until the admin visits the themes administration page an clicks "save." ------------------------------------------------------------------------ December 1, 2004 - 16:41 : Dries Committed. ------------------------------------------------------------------------ March 15, 2005 - 16:03 : TDobes Attachment: http://drupal.org/files/issues/themes-bugfix_and_cleanup.patch (8.77 KB) I did a bit more testing of the theme administration in 4.6 and found a few items that needed improvement. The attached patch fixes a couple bugs, removes some code rot, and cleans up the code a bit: * Fix a bug which would cause the "configure" link for styles to be broken. (missed this in the last patch) * Fix a bug with using drupal_get_filename for theme engines. Although this is not called anywhere in core, we should still fix it for contrib. (i.e. themes that may want to manually invoke a theme engine to create a hybrid theme) * Correct an inaccurate comment in theme.inc * Populate the default primary links with an "edit primary links" link for consistency with the secondary links * remove some unnecessary variables in the theme administration which had misleading and confusing names * replace time-consuming foreach when rendering theme admin page with a more efficient array_key_exists * usability: rather than completely removing the search box checkbox when search.module is disabled, simply disable it. (UI elements shouldn't appear/disappear.) Please commit and/or review prior to 4.6 release.

1 0