April 2005 - Development - lists.drupal.org

[drupal-devel] [feature] Taxonomy rewrite
by chx 21 Aug '05

21 Aug '05

Project: Drupal Version: cvs Component: taxonomy.module Category: feature requests Priority: normal Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/taxonomy_db_rewrite.patch (6.71 KB) I'd like to present a use for db_rewrite_sql: taxonomy rewrites. If this goes through, it will be possible to create an access mechanism, languages and whatever for taxonomy. This is a very small change, I think, much smaller than the node_rewrite_sql megpatch was 'cos at the moment nothing changes. There are no DISTINCTs deleted. But this opens a door for future things. Also, this only affects taxonomy.module, 'cos no other module deals with term_data and vocabulary tables (well, forum.module does, but those queries does not need a rewrite). chx -- View: http://drupal.org/node/16452 Edit: http://drupal.org/project/comments/add/16452

8 21

[drupal-devel] [feature] support for path alias chains in drupal_get_path_alias.
by aws 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/21239 Project: Drupal Version: 4.6.0 Component: base system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: aws Updated by: aws Status: patch Attachment: http://drupal.org/files/issues/includes_bootstrap.inc_0.patch (739 bytes) This is a small patch for function drupal_get_path_alias in bootstrap.inc. This allows a path to have a non-cyclic chain of aliases, and enables the path alias finder to walk up the chain to the top level alias. For example: taxonomy_menu/4/1/50 | topics/whats_new/events taxonomy/term/50 | taxonomy_menu/4/1/50 Now I can have all references to taxonomy/term/50 automatically point to the top-level alias, topics/whats_new/events. I am also posting a patch against Pathauto module which creates these multi-links automatically for categories when taxonomy_menu is present. (I will add followup with a link to that patch). Note that the inverse case (alias => path) is *not* necessary (in fact it would break the intention of this patch... --- There are several other ways to accomplish this; all of which are more involved. YMMV. I won't be insulted if this patch is rejected. :) An alternative solution would be to allow the destination column to accept non-unique entries. This would also require some sort of weighting otherwise the final resolution would be indefinate. A second alternative would be to have drupal generate taxonomy links in a more general manner, so that the taxonomy_menu module could change all the taxonomy links via the proper hooks. A *third* alternative would be to fix the menu system so that it does not require nested paths in the hiearchy, this way taxonomy_menu would not need to create its own paths. aws

3 4

[drupal-devel] [bug] Allow both postgres and mysql database connections from within the same site.
by adrian 17 Aug '05

17 Aug '05

Issue status update for http://drupal.org/node/19522 Project: Drupal Version: cvs Component: database system Category: bug reports Priority: normal Assigned to: adrian Reported by: adrian Updated by: adrian Status: patch Attachment: http://drupal.org/files/issues/multi-dbtype.diff (14.57 KB) When I originally coded the multiple database support I noted the caveat that only one database type was useable at a time due to the conflicting function names, so including both database.pgsql.inc and database.mysql.inc would cause a crash. This was also brought up again when someone reopened the multi-db functionality issue, and I am attaching the patch here. I would love for this patch to get into 4.6 if possible. I don't believe it's very invasive, and it fixes a long standing bug in the db api. I have been using some form of this patch on Bryght for the last 3-4 months, and have not found any ill effects related to it. I also clarified the db_set_active() comments a bit after I saw this issue (http://drupal.org/node/13115) adrian

3 4

[drupal-devel] [bug] welcome text appears when the query in node_page_default is rewritten to have an empty result
by chx 17 Aug '05

17 Aug '05

Issue status update for http://drupal.org/node/18340 Project: Drupal Version: cvs Component: node.module Category: bug reports Priority: normal Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/default_as_node.patch (8.55 KB) As discussed on IRC, I have moved the welcome text into node 0 as a PHP node. Although there is a check for whether this welcome node is present for every node_page_default call, it is only a variable_get, so it is cheap. Also at every node save we check for the same variable, and if the welcome node is present, it gets silently deleted. So, as soon as the first node gets created, the welcome text disappears as it should. The one liner in node_validate is very important when a node with nid=0 is present. Otherwise, consider it a minor speedup. This patch should have a little positive effect on the memory requirements of node.module -- a long, rarely used text is removed. This is not a new feature but a usability issue so let's get it into 4.6. Although there is change (two INSERTs) to database.mysql and database.pgsql it does not mandate an update.inc change 'cos most probably noone will bother with updating an empty site. I payed special attention to spaces this time. chx

6 15

[drupal-devel] [bug] _db_query() shows each query error twice
by danielc 16 Aug '05

16 Aug '05

Issue status update for http://drupal.org/node/19942 Project: Drupal Version: cvs Component: database system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: danielc Updated by: danielc Status: patch Attachment: http://drupal.org/files/issues/database.silence.query.diff (1.2 KB) In _db_query(), when a query error happens, the error messages are displayed twice. First at the point of the pg_query()/mysql_query() call and then at the track_errors() call. Since there is an error handling/reporting process in place, the query calls should suppress error output by placing @'s in front of them. The attached patch does that for both the database.mysql.inc and database.pgsql.inc files. danielc

3 8

[drupal-devel] [task] Make local tasks more themeable
by drumm 13 Aug '05

13 Aug '05

Project: Drupal Version: cvs Component: menu system Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch There is currently a lot of code that does some heavy lifting in the local task themeable functions. This is a bit of a simplification. No HTML is changed by this refactoring. To test this I tried making the local tasks hierarchical instead of two unordered lists. This was a easy change to do, with about 3 lines of changes. drumm -- View: http://drupal.org/node/17869 Edit: http://drupal.org/project/comments/add/17869

3 8

[drupal-devel] [bug] Menu system requires a local task to have more than 1 child in order to create secondary local tasks
by andremolnar 10 Aug '05

10 Aug '05

Project: Drupal Version: cvs Component: menu system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: andremolnar Updated by: andremolnar Status: patch Attachment: http://drupal.org/files/issues/menu_inc_1a.patch (826 bytes) This is a minor bug. The menu system requires a local task to have more than 1 child in order to create secondary local tasks. In other words if a local task only had 1 child, menu system would not create a secondary local task menu item. This patch fixes that with the addition of 1 character in the code. andre andremolnar -- View: http://drupal.org/node/17022 Edit: http://drupal.org/project/comments/add/17022

4 5

[drupal-devel] [feature] Trigger debug mode on-the-fly
by mathias 03 Aug '05

03 Aug '05

Issue status update for http://drupal.org/node/21379 Project: Drupal Version: cvs Component: other Category: feature requests Priority: normal Assigned to: Anonymous Reported by: mathias Updated by: mathias Status: patch Attachment: http://drupal.org/files/issues/devel_GET_params_core.patch (2.38 KB) This patch allows admins who are using devel.module to optionally toggle the page timer, query logger and page redirection for each request using GET parameters rather than navigating to admin/settings/devel and flipping the global settings back and forth. I added this since I usually don't need to print out this information for every page. Now I just use: http://example.com/index.php?q=node&dev_query=1 for the request I'm interested in. Two other params can also be toggled: dev_timer and dev_redirect. mathias

4 5

[drupal-devel] [task] GD2-specific functions should be moved to image.gd2.inc
by Junyor 01 Aug '05

01 Aug '05

Issue status update for http://drupal.org/node/19611 Project: Drupal Version: cvs Component: base system Category: tasks Priority: normal Assigned to: Junyor Reported by: Junyor Updated by: Junyor Status: patch Attachment: http://drupal.org/files/issues/system-image.patch (6.8 KB) The new image handling tools in core have a lot of GD2-specific logic, making image.inc overly cluttered and complicated. If gd2 were just treated like another toolkit (though the only one included by default), then the image.inc code would be much cleaner and more easily maintained. This patch removes all the GD2 stuff from image.inc and puts it into image.gd2.inc. The _settings hook is now doing what it sounds like it should, return settings for the toolkit. I've added a _check hook which will tell if the PHP functions needed are available. If _check fails, then the toolkit will not be listed on admin > settings and an error will be logged in watchdog. I've also update image.gd1.inc, image.imlib.inc, and image.imagick.inc with the same logic. Junyor

6 14

[drupal-devel] [bug] settings.php change to prevent PHPSESSID in URL
by kbahey 01 Aug '05

01 Aug '05

Issue status update for http://drupal.org/node/21170 Project: Drupal Version: 4.6.0 Component: other Category: bug reports Priority: normal Assigned to: kbahey Reported by: kbahey Updated by: kbahey Status: patch Attachment: http://drupal.org/files/issues/settings_0.patch (576 bytes) As per the workaround mentioned in discussion [1], the default settings.php file that is shipped does not always prevent PHP from adding the PHPSESSID in the URL. Although this is a hosting setting issue, a workaround exists for it: A patch is attached, and it just adds the following line to settings.php ini_set('url_rewriter.tags', ''); [1] http://drupal.org/node/17947#comment-36339 kbahey

3 3