May 2005 - Development - lists.drupal.org

[drupal-devel] Licence issues using GPL'ed SquirrelMail code in mailhandler.module?
by Mark Leicester 23 May '05

23 May '05

Hello all , I'm making improvements to the mailhandler (and fixing the drupal_special_chars problem by replacing with check_plain). SquirrelMail already implements a very thorough URL parser, attachment handler, and mail re-wrapper. SquirrelMail is GNU GPL, so I'm wondering if I can re-use that code rather than reinvent. What are the licence implications? Do we simply need to credit the SquirrelMail project and redistribute the licence intact? Regards, Mark

4 5

[drupal-devel] Throttle used in a theme
by Abalieno 23 May '05

23 May '05

I know I can but I don't have the knowledge to figure out how to do it. Is there an example I can see so that I can then adapt it to my needs? In a module I'd use something like: if (throttle_status() == 1) { } But where I put that and what I put inside? I currently use the default xtemplate engine and I don't know if I should put the code in the xtemplate.xtmpl or in the engine itself, or both. Can someone paste me a bit of code to show, for example, just an image after checking the throttle? -HRose / Abalieno

1 0

[drupal-devel] [task] Book module should use theme_stylesheet_import for print styles
by factoryjoe 23 May '05

23 May '05

Issue status update for http://drupal.org/node/23320 Project: Drupal Version: cvs Component: book.module Category: tasks Priority: normal Assigned to: factoryjoe Reported by: factoryjoe Updated by: factoryjoe Status: patch Attachment: http://drupal.org/files/issues/book.module_3.patch (570 bytes) I've made a simple patch so that the book module goes through the right hoops when outputting the print stylesheet. Why is this important? So that I can override the print stylesheet in my theme! factoryjoe

2 2

[drupal-devel] [task] theme_user_list is useless for advanced themeing. Patch changes that.
by factoryjoe 22 May '05

22 May '05

Issue status update for http://drupal.org/node/23383 Project: Drupal Version: 4.6.0 Component: theme system Category: tasks Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: factoryjoe Status: patch I will +1 if this simply means that the user array is passed on for theming, which I think it does. In which case, this is consistent w/ nodes and comments, so I think it's good. factoryjoe Previous comments: ------------------------------------------------------------------------ May 22, 2005 - 15:18 : Bèr Kessels Attachment: http://drupal.org/files/issues/user_module_theme_list.patch (1.88 KB) Since the function currently only receives a string of HTML there is no way to add inormation to a user list. You cannot do a user_load to add additional information, like the avatar. Pattern matching the UID from the url in the html is not an option, since a username could be aliassed, thus in order to get the UID you need a lot of quite heavy code. This patch changes the passed argument into an array of user objects. By default the objects need only to contain the name and UID. This patch also cleans up the online user list block, which had some inconsistent code. After his patch you can have fancy users lists like on my development ste: http://84.244.1.246 ------------------------------------------------------------------------ May 22, 2005 - 16:22 : Bèr Kessels forgot status patch

1 0

[drupal-devel] OpenId-compatible encryption in PHP
by Mark 22 May '05

22 May '05

Greetings all, I've been following the development of OpenId (http://www.danga.com/openid/) and I have a few questions regarding the practical implementation of it for Drupal. I realize that one of the goals of Drupal is that it can run on a variety of PHP installations/configurations. With that in mind, I'm wondering how common variouos encryption libraries are in the realm of PHP installations. Some of the technologies used by OpenId (or under consideration): DSA encryption (using PEM key formatting) RSA encryption (under consideration) SHA1 encryption DER encoding BASE64 encoding I'm vaguely familiar with many of these technologies, and have even used several of them. SHA1 is natively supported by PHP >= 4.3.0. BASE64 is natively supported by PHP As for RSA and DSA, I know that these key types are supported by OpenSSL. Is OpenSSL commonly supported in PHP? I know that it's fairly easy to install, but I also realize that many users don't have control over what their server supports. I suppose I'm doing a survey here to see if an OpenSSL requirement is beyond the scope of a Drupal core installation. If there are PHP-based alternatives to OpenSSL that could be bundled with (or linked to from) Drupal, please inform me about them. Thanks for your time, -Mark

4 6

[drupal-devel] [feature] List of bloggers
by Bèr Kessels 22 May '05

22 May '05

Issue status update for http://drupal.org/node/17030 Project: Drupal Version: cvs Component: blog.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: Bèr Kessels Status: patch To avoid confusion: this patch ads no blocks, but shows the list inline: as content! Bèr Kessels Previous comments: ------------------------------------------------------------------------ February 9, 2005 - 00:27 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list.patch (1.66 KB) Small patch to show a list of bloggers. We all should know that blog.module is not meant for personal blogging, but that set aside, we do not have a way to show all bloggers, on a site as a list. This patch ads a few lines that will allow you to show that overview of blogging users. It ads a menu item, disabled by default that shows such a list. ------------------------------------------------------------------------ February 9, 2005 - 00:31 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list.png (4.02 KB) Here is a small screeny that shows what this is about. ------------------------------------------------------------------------ February 9, 2005 - 00:34 : Bèr Kessels Attachment: http://drupal.org/files/issues/list_bloggers_2.png (2.25 KB) hmm. error in my png file. Here is a correct one. ------------------------------------------------------------------------ February 19, 2005 - 21:13 : Emiliano Hi Bèr Kessels! Thanks for the patch! It's really useful! :-) I just noticed what I think is a little mistake in this line: $items[] = l($row->name, 'blog/'.$row->uid)." ".theme('xml_icon', url('blog/'.$row->uid.'/feed'), TRUE); Which I believe should end like: $items[] = l($row->name, 'blog/'.$row->uid)." ".theme('xml_icon', url*('blog/feed/'.$row->uid)*, TRUE); Ah, and BTW, "db_rewrite_sql" didn't work for me... I just cut it off... ;-) Cheers, Emiliano. ------------------------------------------------------------------------ March 17, 2005 - 23:17 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list_2.patch (1.81 KB) and here is the actual patch. (i think i really need some script that tells me i did not attach a patch ;) ) ------------------------------------------------------------------------ March 17, 2005 - 23:19 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list_2_0.patch (1.71 KB) sigh. something tells me i should stop working.... a silly "F" sneaked into the previous patch. ------------------------------------------------------------------------ March 24, 2005 - 21:25 : Anonymous I applied the patch, reuploaded the blog.module and then deactivated and reactivated it. I cannot see a difference. How do I access the blog users page? Drupal 4.6rc thanks for the help. ------------------------------------------------------------------------ March 24, 2005 - 21:53 : Bèr Kessels look in the menu admin. ------------------------------------------------------------------------ May 18, 2005 - 14:38 : Bèr Kessels Nearly two months since the patch. If there is no need for this I will mark it won't fix. ------------------------------------------------------------------------ May 18, 2005 - 14:52 : tostinni I made a custom block for this, but it still need a little improvment (add "read more" for example). So I don't know if it's usefull but if anyone care : <?php $result = db_query("SELECT u.uid, u.name, COUNT(0) AS num FROM {node} n LEFT JOIN {users} u ON u.uid = n.uid WHERE n.type = 'blog' GROUP BY u.uid, u.name ORDER BY u.name ASC"); while ($blog = db_fetch_object($result)) { $output .= '<li />'.l($blog->name. ' ('.$blog->num.')', 'blog/'.$blog->uid); } return '<ul>'.$output.'</ul>'; ?> ------------------------------------------------------------------------ May 18, 2005 - 17:06 : Chris Johnson I think this is a useful feature. I've coded custom blocks in the past to provide it on my sites. ------------------------------------------------------------------------ May 21, 2005 - 06:23 : Andrzej7 I was a little afraid (poor PHP) to install the patch (March...), but I have made a block. And it's very nice. One question only. All the bloggers are shown, but the Admin (user No 1) is on the list and he has no blogs. What's that?

1 0

[drupal-devel] [task] theme_user_list is useless for advanced themeing. Patch changes that.
by Bèr Kessels 22 May '05

22 May '05

Issue status update for http://drupal.org/node/23383 Project: Drupal Version: 4.6.0 Component: theme system Category: tasks Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: Bèr Kessels -Status: active +Status: patch forgot status patch Bèr Kessels Previous comments: ------------------------------------------------------------------------ May 22, 2005 - 16:18 : Bèr Kessels Attachment: http://drupal.org/files/issues/user_module_theme_list.patch (1.88 KB) Since the function currently only receives a string of HTML there is no way to add inormation to a user list. You cannot do a user_load to add additional information, like the avatar. Pattern matching the UID from the url in the html is not an option, since a username could be aliassed, thus in order to get the UID you need a lot of quite heavy code. This patch changes the passed argument into an array of user objects. By default the objects need only to contain the name and UID. This patch also cleans up the online user list block, which had some inconsistent code. After his patch you can have fancy users lists like on my development ste: http://84.244.1.246

1 0

[drupal-devel] Bug#310084: drupal: Update Japanese po-debconf template trasnlation
by Hilko Bengen 22 May '05

22 May '05

Hideki Yamane <henrich(a)samba.gr.jp> writes: > I've updated ja.po to fix untranslated lines. > Could you apply it, please? [x] done. Do you want write access to the CVS repository at alioth.debian.org? Cheers, -Hilko

1 0

[drupal-devel] [feature] Replace $_SERVER["REMOTE_ADDR"] with a function which understands X-Forwarded-For
by Dries 22 May '05

22 May '05

Issue status update for http://drupal.org/node/20471 Project: Drupal Version: 4.6.0 Component: base system Category: feature requests Priority: normal Assigned to: degerrit Reported by: degerrit Updated by: Dries Status: patch Couple comments: Drupal supports non-Apache webservers: apache_request_headers() might not always be available. Does this patch need input checking? Depends on how/when/where the remote address data is used. Fact is that we don't want people to inject XSS-stuff through HTTP headers. Make sure to double-check this. I'd rename the function to remote_address(). We usually don't abbreviate words like 'address'. The word 'via' can't be translated. We write } else { and not } else {Just thinking up loud. Is it easy to fake or spoof X-Forwarded-For-headers? If it is, it would be easy to trick Drupal (eg. in the statistics.module's log pages we group by remote address). For the watchdog it doesn't matter, but for the statistics module it does. Maybe we need a toggle so remote_address() can be told not to return the 'true IP address'. Dries Previous comments: ------------------------------------------------------------------------ April 14, 2005 - 01:42 : degerrit In several modules, replace $_SERVER["REMOTE_ADDR"] with a function which understands X-Forwarded-For. Proxy servers often (sometimes, always?) insert "X-Forwarded-For" headers which contains the "real" client IP address. I think it is useful to log the client IP address in that situation. This little snippet works for me, and I'd suggest something similar be made into a function? $headers = apache_request_headers(); if (array_key_exists('X-Forwarded-For', $headers)){ $hostname=$headers['X-Forwarded-For'] . ' via ' . $_SERVER["REMOTE_ADDR"]; } else { $hostname=$_SERVER["REMOTE_ADDR"]; } I can make a patch proposal if people like the idea. ------------------------------------------------------------------------ May 21, 2005 - 23:44 : degerrit Attachment: http://drupal.org/files/issues/remote_addr.diff (6.07 KB) Here's my proposal for showing user IP addresses behind proxy servers, especially in log files. It adds a function remote_addr() and replaces all the uses of $_SERVER["REMOTE_ADDR"] with that function. This is my first patch for Drupal, don't be too harsh one me :-) A few notes: - I patched session.inc because $_SERVER["REMOTE_ADDR"] is also called in session.inc and common.inc is not available at that time it seems - maybe I replaced too vigorously in common.inc and sessions.inc, it works for me though - maybe it should be renamed http_remote_addr or apache_remote_addr

1 0

[drupal-devel] [feature] Replace $_SERVER["REMOTE_ADDR"] with a function which understands X-Forwarded-For
by degerrit 21 May '05

21 May '05

Issue status update for http://drupal.org/node/20471 Project: Drupal -Version: 4.5.2 +Version: 4.6.0 Component: base system Category: feature requests Priority: normal -Assigned to: Anonymous +Assigned to: degerrit Reported by: degerrit Updated by: degerrit -Status: active +Status: patch Attachment: http://drupal.org/files/issues/remote_addr.diff (6.07 KB) Here's my proposal for showing user IP addresses behind proxy servers, especially in log files. It adds a function remote_addr() and replaces all the uses of $_SERVER["REMOTE_ADDR"] with that function. This is my first patch for Drupal, don't be too harsh one me :-) A few notes: - I patched session.inc because $_SERVER["REMOTE_ADDR"] is also called in session.inc and common.inc is not available at that time it seems - maybe I replaced too vigorously in common.inc and sessions.inc, it works for me though - maybe it should be renamed http_remote_addr or apache_remote_addr degerrit Previous comments: ------------------------------------------------------------------------ April 14, 2005 - 00:42 : degerrit In several modules, replace $_SERVER["REMOTE_ADDR"] with a function which understands X-Forwarded-For. Proxy servers often (sometimes, always?) insert "X-Forwarded-For" headers which contains the "real" client IP address. I think it is useful to log the client IP address in that situation. This little snippet works for me, and I'd suggest something similar be made into a function? $headers = apache_request_headers(); if (array_key_exists('X-Forwarded-For', $headers)){ $hostname=$headers['X-Forwarded-For'] . ' via ' . $_SERVER["REMOTE_ADDR"]; } else { $hostname=$_SERVER["REMOTE_ADDR"]; } I can make a patch proposal if people like the idea.

1 0