May 2005 - Development - lists.drupal.org

[drupal-devel] [feature] List of bloggers
by Andrzej7 21 May '05

21 May '05

Issue status update for http://drupal.org/node/17030 Project: Drupal Version: cvs Component: blog.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: Andrzej7 Status: patch I was a little afraid (poor PHP) to install the patch (March...), but I have made a block. And it's very nice. One question only. All the bloggers are shown, but the Admin (user No 1) is on the list and he has no blogs. What's that? Andrzej7 Previous comments: ------------------------------------------------------------------------ February 8, 2005 - 23:27 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list.patch (1.66 KB) Small patch to show a list of bloggers. We all should know that blog.module is not meant for personal blogging, but that set aside, we do not have a way to show all bloggers, on a site as a list. This patch ads a few lines that will allow you to show that overview of blogging users. It ads a menu item, disabled by default that shows such a list. ------------------------------------------------------------------------ February 8, 2005 - 23:31 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list.png (4.02 KB) Here is a small screeny that shows what this is about. ------------------------------------------------------------------------ February 8, 2005 - 23:34 : Bèr Kessels Attachment: http://drupal.org/files/issues/list_bloggers_2.png (2.25 KB) hmm. error in my png file. Here is a correct one. ------------------------------------------------------------------------ February 19, 2005 - 20:13 : Emiliano Hi Bèr Kessels! Thanks for the patch! It's really useful! :-) I just noticed what I think is a little mistake in this line: $items[] = l($row->name, 'blog/'.$row->uid)." ".theme('xml_icon', url('blog/'.$row->uid.'/feed'), TRUE); Which I believe should end like: $items[] = l($row->name, 'blog/'.$row->uid)." ".theme('xml_icon', url*('blog/feed/'.$row->uid)*, TRUE); Ah, and BTW, "db_rewrite_sql" didn't work for me... I just cut it off... ;-) Cheers, Emiliano. ------------------------------------------------------------------------ March 17, 2005 - 22:17 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list_2.patch (1.81 KB) and here is the actual patch. (i think i really need some script that tells me i did not attach a patch ;) ) ------------------------------------------------------------------------ March 17, 2005 - 22:19 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list_2_0.patch (1.71 KB) sigh. something tells me i should stop working.... a silly "F" sneaked into the previous patch. ------------------------------------------------------------------------ March 24, 2005 - 20:25 : Anonymous I applied the patch, reuploaded the blog.module and then deactivated and reactivated it. I cannot see a difference. How do I access the blog users page? Drupal 4.6rc thanks for the help. ------------------------------------------------------------------------ March 24, 2005 - 20:53 : Bèr Kessels look in the menu admin. ------------------------------------------------------------------------ May 18, 2005 - 13:38 : Bèr Kessels Nearly two months since the patch. If there is no need for this I will mark it won't fix. ------------------------------------------------------------------------ May 18, 2005 - 13:52 : tostinni I made a custom block for this, but it still need a little improvment (add "read more" for example). So I don't know if it's usefull but if anyone care : <?php $result = db_query("SELECT u.uid, u.name, COUNT(0) AS num FROM {node} n LEFT JOIN {users} u ON u.uid = n.uid WHERE n.type = 'blog' GROUP BY u.uid, u.name ORDER BY u.name ASC"); while ($blog = db_fetch_object($result)) { $output .= '<li />'.l($blog->name. ' ('.$blog->num.')', 'blog/'.$blog->uid); } return '<ul>'.$output.'</ul>'; ?> ------------------------------------------------------------------------ May 18, 2005 - 16:06 : Chris Johnson I think this is a useful feature. I've coded custom blocks in the past to provide it on my sites.

1 0

[drupal-devel] [bug] file_check_location is not working on Windows 2000
by Rick Cogley 21 May '05

21 May '05

Issue status update for http://drupal.org/node/10885 Project: Drupal Version: cvs Component: file system Category: bug reports Priority: critical Assigned to: Anonymous Reported by: ccourtne Updated by: Rick Cogley Status: patch The patch fixed uploads for me as well on 4.6.0. Rick Cogley Previous comments: ------------------------------------------------------------------------ September 16, 2004 - 22:46 : ccourtne Currently file_check_location is always returning false when passed a file as the $source path. If a directory is passed in $soruce file_check_location works. I've tracked this down to realpath returning an empty string when passed a relative path which points to a file. This probably goes unnoticed if you are using the file.api's to construct relative paths to the druapl file directory since check_location failing just causes the durpal file directory to get added which is what you wanted in the first place. Replacing this line $source = realpath(dirname($source)); with this $source = realpath(dirname($source)); fixes it on my windows box using PHP 4.3.8. I don't have things set up to do patches on my windows boxes here at work yet. I'll submit a formal patch tonight. ------------------------------------------------------------------------ September 16, 2004 - 22:47 : ccourtne Dag nabit. Replace $source = realpath($source); with $source = realpath(dirname($source)); Craig ------------------------------------------------------------------------ September 16, 2004 - 22:56 : Anonymous Attachment: http://drupal.org/files/issues/file-inc-file_check_location.patch (639 bytes) The sooner there are patches, the better it is... I tested this approach on my server and it works. Steef ------------------------------------------------------------------------ September 17, 2004 - 10:34 : ccourtne Attachment: http://drupal.org/files/issues/checklocation.patch (666 bytes) Here is the patch. ------------------------------------------------------------------------ February 23, 2005 - 09:30 : dan90(a)drupal.org This also fixed my file upload problems with some nonstandard paths under Linux/apache, php 4.3.4 drupal 4.5.2. maybe we should remove mention of windows 2000? ------------------------------------------------------------------------ March 2, 2005 - 02:32 : killes(a)www.drop.org Still applies. ------------------------------------------------------------------------ April 18, 2005 - 20:10 : ec Is this patch still to be use with actual Drupal 4.6.0 ? Thanks. eric ------------------------------------------------------------------------ May 7, 2005 - 19:35 : Wes Cowley I hand applied the patch to my Linux based installation and it solved the problem I was having with filemanager/attachment. I assume it would fix the same problem I had with upload.module since the symptoms were identical. ------------------------------------------------------------------------ May 7, 2005 - 19:36 : Wes Cowley Meant to add, that was a 4.6.0 Linux installaion that this patch cleared up. ------------------------------------------------------------------------ May 14, 2005 - 16:59 : larryjhs Thanks, still, I'm a bit of a php newbie -- where do I put the patch -- into which bit of script? If it's not too obvious, tell me and I won't try! But if it's obvious, please give me the location L ------------------------------------------------------------------------ May 14, 2005 - 17:19 : ec This patch seem still to apply to 4.6 (I'm using it on my linux box too and it solve my problem with upload.module) it apply on "file.inc" that you will find in includes directory on top of your drupal root. Put the patch in the same directory as file.inc go in this directory too and apply the patch like this "patch -p0 < the_patch_to_apply" where patch is the command on *nix box. If you're not confortable you can either edit the file.inc by hand and make the change yourself, in the patch file, line beginning with "-" is the one to remove, line beginning with "+" is the one to add, other lines are the context so you're sure to find the right line. Hope this help. Regards. ------------------------------------------------------------------------ May 14, 2005 - 17:23 : ec BTW, IMHO this patch should be committed ASAP as it's solve the problem with upload.module that can't handle private directory outside drupal root. Tested on my sites ans work (for now ;-) like a charm. Regards. ------------------------------------------------------------------------ May 15, 2005 - 20:51 : Dries Don't we use file_create_path for that (it appends the 'files'-bit)? ------------------------------------------------------------------------ May 16, 2005 - 05:19 : ec On my linux box, I make an other test with the latest stock release of file.inc. I setup files directectory, with "private" check, outside drupal root and drupal complains The directory does not exist (I know this directory exists and is working because I'm using it !). It only works with the patch below. Sorry, I'm not confortable enought to answer your question Dries, but sure this patch is the only I found to have a real private directory working. Regards, eric. PS : I don't why but got an error each time I want to upload a file here ??? so here is the text against the latest release of file.inc i.e 1.39.2.2 --- ./file.inc 2005-05-15 21:52:40.758531811 +0200 +++ ./file_mod_ec.inc 2005-05-15 22:03:41.869608738 +0200 @@ -169,7 +169,7 @@ * @return 0 for invalid path or the real path of the source. */ function file_check_location($source, $directory = 0) { - $source = realpath($source); + $source = realpath(dirname($source)); $directory = realpath($directory); if ($directory && strpos($source, $directory) !== 0) { return 0; >/code>

1 0

[drupal-devel] [bug] Comment previews need a preview class
by factoryjoe 20 May '05

20 May '05

Issue status update for http://drupal.org/node/23285 Project: Drupal Version: 4.6.0 Component: comment.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: factoryjoe Updated by: factoryjoe Status: patch Tested and works as expected. +1. Awesome! factoryjoe Previous comments: ------------------------------------------------------------------------ May 20, 2005 - 16:55 : factoryjoe References: http://drupal.org/node/18792, http://drupal.org/node/18845 In Drupal 4.6, we got node previews -- with a nice wrapping div with a preview class. Unfortunately, comments didn't get the same treatment. Therefore, we need to consider the workflow issues of previewing *anything* since it's clear that from a theming and UI perspective, a comment preview really isn't any different from a node preview, no matter what the backend architecture looks like. Sorry I don't have code for this, but I would very much appreciate a solution. ------------------------------------------------------------------------ May 20, 2005 - 17:01 : Steven Attachment: http://drupal.org/files/issues/comment.preview.patch (1.5 KB) Untested patch.

1 0

[drupal-devel] [bug] Comment previews need a preview class
by Steven 20 May '05

20 May '05

Issue status update for http://drupal.org/node/23285 Project: Drupal Version: 4.6.0 Component: comment.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: factoryjoe Updated by: Steven -Status: active +Status: patch Attachment: http://drupal.org/files/issues/comment.preview.patch (1.5 KB) Untested patch. Steven Previous comments: ------------------------------------------------------------------------ May 20, 2005 - 18:55 : factoryjoe References: http://drupal.org/node/18792, http://drupal.org/node/18845 In Drupal 4.6, we got node previews -- with a nice wrapping div with a preview class. Unfortunately, comments didn't get the same treatment. Therefore, we need to consider the workflow issues of previewing *anything* since it's clear that from a theming and UI perspective, a comment preview really isn't any different from a node preview, no matter what the backend architecture looks like. Sorry I don't have code for this, but I would very much appreciate a solution.

1 0

Re: [drupal-devel] creating drupal-doc teams
by Kobus Myburgh 20 May '05

20 May '05

Charlie, I am subscribed to the drupal-docs list. Subscribed this morning. Be sure to let me know if there are things that I can do. I will monitor the list anyways and let you know when there is something I can do. Regards, Kobus >>> cel4145(a)cyberdash.com 5/20/2005 5:09 PM >>> Kobus wrote, "If there is a place where I can be involved, please let me know. I am not very big on the coding, so this is a good area for me to get involved in." Definitely, join the drupal-docs list if you aren't subscribes already. And I've got you written down for the project areas that you mentioned. Charlie

1 0

Re: [drupal-devel] creating drupal-doc teams
by Charlie Lowe 20 May '05

20 May '05

Thanks Steven, Gerhard, and Djun :) And you are right Steven. One thing I was thinking about is that it's much easier for two people to sort of keep things moving along because they can take turns. That, and my experience has been that when there are two people responsible for figuring out solutions to problems, those solutions tend to be more robust because of the different perspectives that each brings. I'll wait a day or two, and then post a list to the mailing lists of who volunteered for which project teams. Charlie

1 1

[drupal-devel] [bug] Remove PHP warnings.
by killes 20 May '05

20 May '05

Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org Status: patch Attachment: http://drupal.org/files/issues/tablesort-notices.patch (3.42 KB) Drupal emits an annoying number of PHP notices. The attached patch fixes a few of them in tablesort.inc. killes(a)www.drop.org -- View: http://drupal.org/node/16303 Edit: http://drupal.org/project/comments/add/16303

3 8

[drupal-devel] [bug] Nodes are repeated when asking for a list of taxonomy/term/x+y nodes
by matteo 20 May '05

20 May '05

Issue status update for http://drupal.org/node/22469 Project: Drupal Version: 4.6.0 Component: taxonomy.module Category: bug reports Priority: normal -Assigned to: Anonymous +Assigned to: matteo Reported by: matteo Updated by: matteo -Status: active +Status: patch Attachment: http://drupal.org/files/issues/taxonomy_distinct.patch (1.06 KB) Here is the patch for Drupal 4.6 to solve this problem. Matteo matteo Previous comments: ------------------------------------------------------------------------ May 9, 2005 - 22:39 : matteo When asking for a list of nodes linked to more than one term by using the syntax 'taxonomy/term/x+y', the same nodes are shown twice instead of only one time, when nodes are linked to both x and y term. Hoping I've been able to explain what happens..... Matteo PS: Maybe is it so by design.... ?? ------------------------------------------------------------------------ May 9, 2005 - 22:45 : matteo It looks like a distinct(n.nid) clause should be added to lines 839-840, which should sound like this: $sql = 'SELECT distinct(n.nid), n.sticky, n.title, n.created FROM {node} n INNER JOIN {term_node} tn ON n.nid = tn.nid WHERE tn.tid IN ('. $str_tids .') AND n.status = 1 ORDER BY n.sticky DESC, n.created DESC'; $sql_count = 'SELECT COUNT(distinct(n.nid)) FROM {node} n INNER JOIN {term_node} tn ON n.nid = tn.nid WHERE tn.tid IN ('. $str_tids .') AND n.status = 1'; this prints out the correct number of nodes. Matteo ------------------------------------------------------------------------ May 10, 2005 - 16:01 : JonBob I think your analysis is right. The DISTINCT() was probably removed because someone thought it was there for node permissions (the new db_rewrite() mechanism handles this now), but it is also necessary in the case of an OR query. ------------------------------------------------------------------------ May 20, 2005 - 09:10 : Cvbge Hello, I've used proposed change and it works as expected. ------------------------------------------------------------------------ May 20, 2005 - 09:22 : matteo Just to undesrtand what to do, should I create the patch, or is it assigned to someone else ?? Matteo

1 0

Re: [drupal-devel] Contact people for translations
by Kobus Myburgh 20 May '05

20 May '05

Hi, I am also willing to be coordinator for translations, if you wish (and the Drupal team approves), Gerhard. Regards, Kobus >>> killesreiter(a)physik.uni-freiburg.de 5/20/2005 12:14 PM >>> On Thu, 19 May 2005, Kieran Lal wrote: > Hi, we have been talking about how changes to admin help might effect > translation efforts. I think we have some proposals on the docs > list. Who should I speak with from the translation efforts to see if > what we are proposing is reasonable? That is a valid question. Although I recently proclaimed myself translations coordinator (mainly because I tell people how to get their translations into cvs and do some initial commits for them) I have very little contact to most of the translators. I think the best thing would be to post in the translations forum. If feedback turns out to be too low, we can draft a list of translators from the cvs commits and contact them directly. Cheers, Gerhard

1 0

[drupal-devel] Contact people for translations
by Kieran Lal 20 May '05

20 May '05

Hi, we have been talking about how changes to admin help might effect translation efforts. I think we have some proposals on the docs list. Who should I speak with from the translation efforts to see if what we are proposing is reasonable? Thanks, Kieran

2 1