May 2005 - Development - lists.drupal.org

[drupal-devel] [bug] DST support
by pyromanfo 17 May '05

17 May '05

Issue status update for http://drupal.org/node/23029 Project: Drupal Version: 4.6.0 Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: pyromanfo Updated by: pyromanfo Status: patch One quick and dirty way to fix Daylight Savings Time in Drupal would be to add the following line in the function format_date in common.inc <?php $timestamp += date("I")*3600; ?> It adjusts the timestamp if DST is currently active. It fixed it on my site, at any rate, it seems it'd handle both cases, DST enabled or not using DST at all. pyromanfo

3 3

[drupal-devel] [feature] Order taxonomy_select_nodes
by tostinni 17 May '05

17 May '05

Issue status update for http://drupal.org/node/20963 Project: Drupal Version: cvs Component: taxonomy.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: tostinni Updated by: tostinni Status: patch Attachment: http://drupal.org/files/issues/taxonomy_order-node.patch (2.36 KB) A very simple patch to provide an (too ?) easy way to configure how order selected nodes in a taxonomy_select_nodes call. I think we could provide such way for each module that make a call to this functions. tostinni

3 3

[drupal-devel] MySQL indices not being picked up
by Dries Buytaert 17 May '05

17 May '05

2 3

Re: [drupal-devel] Admin Help writing instructions - 60 patches coming soon
by Kobus Myburgh 17 May '05

17 May '05

Thanks a lot, Morten! Yes. I use poEdit. I will check it out. Regards, Kobus >>> wulff(a)psyke.org 5/17/2005 5:03 PM >>> Kobus Myburgh wrote: >>You can merge your translations against POT files from a later version >>and msgmerge will try to fit good matches to the new strings from the >>old ones. > A brief search for "msgmerge" got about 10000 results, and when refining this, I finally heard of one for Windows, but it is part of the Cygwin package. Isn't there a stand-alone Windows port of msgmerge that anyone know of? Once I get it, I will If you're using poEdit you can use "Catalog -> Update from POT File..." (I'm assuming poEdit since you mention Windows). Med venlig hilsen / Kind regards, Morten Wulff -- Self Injury Information and Support: http://www.psyke.org/ "I did not, you see, want to kill myself. Not at that time, anyway. But I wanted to know that if need be, if the desperation got so terribly bad, I could inflict harm on my body. And I could." - Elizabeth Wurtzel

1 0

Re: [drupal-devel] Admin Help writing instructions - 60 patches coming soon
by Kobus Myburgh 17 May '05

17 May '05

>> And here I just translated Drupal to Afrikaans and now all the help >> texts get updated. Bah! This will be a good time to figure out how >> to MAINTAIN an update. I have only started from scratch. > You can merge your translations against POT files from a later version > and msgmerge will try to fit good matches to the new strings from the > old ones. A brief search for "msgmerge" got about 10000 results, and when refining this, I finally heard of one for Windows, but it is part of the Cygwin package. Isn't there a stand-alone Windows port of msgmerge that anyone know of? Once I get it, I will >> I also have questions with regards to translating contributed >> modules. Where do we put them? Are these translations sent to the >> module developers directly? > They are put into a /po subdirectory. You need to create a POT file > first using the phpextractor script. Mail me if you want one for > specific contrib modules. I don't have CVS access, and I won't get it, so I can translate it, but can't put it in the /po subdirectory. I will play around with the extractor, so that I can do this myself, because I need to learn somehow, sometime :) Maybe I should invest a bit of time in getting myself a Linux machine. I have installed Linux once, but that is the same as saying I have installed Windows. Heh... Any fool can install it, but can any fool install it (and set it up) RIGHT? I have only translated Core, but another South African, Tiaan, has translated several modules. Since I can't upload it, can we do it again as we did the previous time with my translations, Gerhard? I will upload one zip file with all the translations. Regards, Kobus

3 2

Re: [drupal-devel] Admin Help writing instructions - 60 patches coming soon
by Kobus Myburgh 17 May '05

17 May '05

> IMO that would be more than enough power.I have not seen much po files that > actually had all the help translated, but then again, its been awhile since i > checked them all ;) YUP, been a while since you checked ;) All texts that poEdit showed in my files were translated! And here I just translated Drupal to Afrikaans and now all the help texts get updated. Bah! This will be a good time to figure out how to MAINTAIN an update. I have only started from scratch. I also have questions with regards to translating contributed modules. Where do we put them? Are these translations sent to the module developers directly? Regards, Kobus

2 1

Re: [drupal-devel] Docking Boxes.
by Kobus Myburgh 17 May '05

17 May '05

> I would like some more peoples ideas on this. Should we consider to include > this API in drupal for our javascript needs, rather then creating our own? Oh, absolutely. I have included JavaScript menus in several Drupal sites I have constructed. Since Drupal prefers not to have JavaScript (AFAIK), maybe just inot include it with core, or if it is included, have it disabled by default? Kobus

7 10

[drupal-devel] [bug] file_check_location problems
by chx 17 May '05

17 May '05

Issue status update for http://drupal.org/node/23028 Project: Drupal Version: cvs Component: file system Category: bug reports Priority: critical Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/file_check_location.patch (2.34 KB) Loosely based on walkah's idea I have changed a bit file_check_location. Most of the problems related to file_check_upload is gone now but still we have one: the system temporary directory. Please really look at the patch and let's decide whether file_check_upload is really necessary for $directory_temp or not. chx

2 1

[drupal-devel] [feature] Do not display "Active/New forum topic" if no topics at all
by Cvbge 16 May '05

16 May '05

Issue status update for http://drupal.org/node/23014 Project: Drupal Version: cvs Component: forum.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Cvbge Updated by: Cvbge Status: patch When there are no topics at all blocks are still displayed, although empty. Attached patch makes empty forum blocks not to be displayed (the same behaviour has e.g. comment's "Recent comments"). This also works with taxonomy_access module, when some roles do not have access to all forums/topics - there are forums/topics, but those people see only empty block. With this patch the don't see the block at all. Grr. I'll attach patches for 4.6.0 and cvs when the uploading issue is fixed. Cvbge

1 2

[drupal-devel] [bug] Do not execute functions in include files
by chx 16 May '05

16 May '05

Issue status update for http://drupal.org/node/18213 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: chx Reported by: killes(a)www.drop.org Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/bootstrap_3.patch (12.36 KB) chx Previous comments: ------------------------------------------------------------------------ March 2, 2005 - 00:09 : killes(a)www.drop.org Drupal currently executes functions in include files. This is very annoying if you want to include files from external scripts such as update scripts or other scripts that want to use Drupal as a framework. Offending files are: database.inc: db_set_active(); session.inc: session_set_save_handler("sess_open", "sess_close", "sess_read", "sess_write", "sess_destroy", "sess_gc"); session_start(); common.inc: A bunch of stuff at the bottom. All this should be moved into a start.inc file. ------------------------------------------------------------------------ March 27, 2005 - 08:44 : adrian I haven't done this recently, but back in 4.4 era I attempted something similar to this for the install api. A _lot_ of modifications were required to be able to use (for instance) the theme api without needing to have a database connection active. ------------------------------------------------------------------------ March 27, 2005 - 08:55 : adrian It's definately not a simple problem. For instance.. the db connection needs to be started during bootstrap, and during normal execution. I think the better idea is to include a DRUPAL_INIT constant we can check before executing the function. (or a DRUPAL_NO_INIT .. i'm not picky). ------------------------------------------------------------------------ April 28, 2005 - 23:53 : killes(a)www.drop.org Here's an old patch by me that illustrates what I want to do. http://lists.drupal.org/archives/drupal-devel/2005-03/txtq23pAcHATw.txt Instead of putting the stuff into index.php, alternative file names need to be found. ------------------------------------------------------------------------ May 4, 2005 - 19:36 : chx Attachment: http://drupal.org/files/issues/boot.patch (6.83 KB) Well, I have written something to address the issue. Now you can include everything to your hearts content just include init.inc as well and do an appropriate drupal_bootstrap. Alas, ATM database and bootstrap is very interwined. This interdependency could be obliterated if we'd not use variable_get('dev_query') in database.*.inc. cvs diff -u -N -F^f against cvs.drupal.org as CVSROOT failed to include to include the two new files, so I'll include them as followups. ------------------------------------------------------------------------ May 4, 2005 - 19:37 : chx Attachment: http://drupal.org/files/issues/boot_0.patch (10.31 KB) Hm, settings.php changes were ommited. ------------------------------------------------------------------------ May 4, 2005 - 19:37 : chx Attachment: http://drupal.org/files/issues/init.inc (3.46 KB) ------------------------------------------------------------------------ May 4, 2005 - 19:38 : chx Attachment: http://drupal.org/files/issues/settings_ini_set.php (850 bytes) ------------------------------------------------------------------------ May 4, 2005 - 19:44 : chx Attachment: http://drupal.org/files/issues/boot_1.patch (14.49 KB) Following advice from darix I have now created one patch. Still, I'd like to know how could I do this with cvs. ------------------------------------------------------------------------ May 4, 2005 - 20:01 : chx Attachment: http://drupal.org/files/issues/boot_2.patch (14.48 KB) Steef found that I had $$ in settings.php. He also asked what's this good for. Several things, but most advantages come when you use only parts of Drupal. If you want use, say, only our forms functions then now you can include('common.inc'); without side effects. If you need the database layer, you do a include('init.inc') and call drupal_bootstrap('database') ------------------------------------------------------------------------ May 5, 2005 - 23:03 : chx Attachment: http://drupal.org/files/issues/boot_3.patch (17.98 KB) The database layer is now totally independent of other parts of Drupal. ------------------------------------------------------------------------ May 15, 2005 - 21:37 : chx A very stupid bug related to variable init is fixed and I am sync'd to HEAD, so timer_init('page') is called.

1 0