July 2005 - Development - lists.drupal.org

[drupal-devel] [feature] Nice DB error screens
by drumm 28 Jul '05

28 Jul '05

Issue status update for http://drupal.org/node/27231 Post a follow up: http://drupal.org/project/comments/add/27231 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/theme.inc_1.diff (1.03 KB) Good catch, wiz. drupal_get_html_head() will actually work here. not sure why I didn't use that before. So this patch is an alternative solution to that lack of base problem. drumm Previous comments: ------------------------------------------------------------------------ Thu, 21 Jul 2005 22:43:16 +0000 : drumm Attachment: http://drupal.org/files/issues/screenshot2.png (96.1 KB) Screenshot. ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:21:31 +0000 : drumm Attachment: http://drupal.org/files/issues/screenshot_10.png (88.44 KB) ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:25:57 +0000 : drumm Attachment: http://drupal.org/files/issues/druplicon.png (3.98 KB) New Druplicon which will need to replace misc/druplicon.png. The current file in that location is a giant flat druplicon which isn't used anywhere. ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:26:26 +0000 : drumm Attachment: http://drupal.org/files/issues/maintenance.css (329 bytes) Some CSS ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:30:34 +0000 : drumm Attachment: http://drupal.org/files/issues/errorhandling.patch (8.47 KB) This patch makes the database errors which occur when the database connection information is wrong or the database isn't up much nicer and more explanatory. To do this it adds a themeable function, theme_maintenance_page(), and a way to get Drupal running without a theme but the ability to execute themeable functions in the usual way. This means we can use the same code to give upgrade.php a nicer look in the future. ------------------------------------------------------------------------ Fri, 22 Jul 2005 06:33:57 +0000 : kbahey I was about to do something similar on a less ambitious scale (mainly the connect function), because what we get now is ugly and looks unprofessional. +1 from me for this. Great job! ------------------------------------------------------------------------ Fri, 22 Jul 2005 06:52:30 +0000 : gordon +1, This looks great. Get this in and then we can do something with the upgrade.php system and it will look just great. ------------------------------------------------------------------------ Fri, 22 Jul 2005 19:36:39 +0000 : drumm Attachment: http://drupal.org/files/issues/errorhandling_0.patch (8.44 KB) New patch with a couple suggestions from chx. * $foo === NULL is faster than is_null($foo) * Removed 'bootstrap' from the function name since it is not really part of the bootstrap system. When testing/applying updates #2 and #3 of this issue need to be handled too. ------------------------------------------------------------------------ Fri, 22 Jul 2005 20:47:18 +0000 : stefan nagtegaal I indeed like the patch! you have some perfectly helptexts which asure that people *must* be foulish when they do not know how to setup drupal the correct way. On that, a very, very fine patch.. Though, code-wise I have one nit-pick, which is propably not even a real issue. Only, I think it looks better: + print theme('maintenance_page', 'We were able to connect to the MySQL database server (which means your username and password is okay) but not able to select the database. +The MySQL error was: '. mysql_error() .'. +Currently, the database is <code>'. substr($url['path'], 1) .'. The username is '. $url['user'] .' and the database server is '. $url['host'] .'. + + * Are you sure you have the correct database name? + * Are you sure the database exists? + * Are you sure the username has permission to access the database? + +For more help, see the Installation and upgrading handbook [1]. If you are unsure what these terms mean you should probably contact your hosting provider. '); Wouldn't it be nicer (code-wise) todo: $message[] = 'We were able to connect to the MySQL database server (which means your username and password is okay) but not able to select the database.'; $message[] = strtr('The MySQL error was: %error.', array('%error' => theme('placeholder', mysql_error()))); $message[] = etc, etc; print theme('maintenance_page', $message); Also would I encourage you to make a function theme_message($type, $message), like: function theme_message($type, $message) { switch($type) { case 'code': $output .= '<code>'. $message .'<code>'; break; case 'placeholder': $output .= ''. $message .''; break; case 'important': $output .= ''. $message .''; break; default: $output .= ''. $message .''; break; } } Which makes theme_placeholder() redundant and could be removed. Codesnippets could be handled in a more consistent way then we currently do (having a theme_placeholder() only is rediculous imo afterall). Also this function could be used to remove the hardcoded HTML from the helptexts.. The code is untested and needs some love here-and-there. But, when it's done, I think we will create (codewise) more consistency than we currently have! I look forward to see your idea's and hear your opinion about this.. [1] http://drupal.org/node/258 ------------------------------------------------------------------------ Fri, 22 Jul 2005 23:27:53 +0000 : drumm The theme_message() which stefan nagtegaal looks like it should be four separate themeable functions, one of which already exists. I think any such modifications are outside the scope of this patch. I am nearly finished preparing a patch to update.php which uses this patch, but I can not post it until this patch is resolved. ------------------------------------------------------------------------ Sat, 23 Jul 2005 09:35:03 +0000 : stefan nagtegaal Okay, I think I have to agree with Neill in here.. If this patch hits the trunk, I'll make a new issue and rolls a patch for introducing new functions which should improve code-wise consistency.. Let me introduce you to: function theme_placeholder($message) { return "$message"; } function theme_important($message) { return "$message"; } function theme_code($message) { return "<code>$message"; } function theme_text($message) { return "$message "; } Patches are soon to come in another issue, after this has hit the trunk.. ------------------------------------------------------------------------ Wed, 27 Jul 2005 00:40:00 +0000 : drumm Attachment: http://drupal.org/files/issues/errorhandling_1.patch (8.75 KB) Updated patch using theme_placeholder() where appropriate. ------------------------------------------------------------------------ Wed, 27 Jul 2005 01:59:01 +0000 : Steven Commited to HEAD. ------------------------------------------------------------------------ Wed, 27 Jul 2005 22:44:26 +0000 : wiz Attachment: http://drupal.org/files/issues/errorhandling_base.patch (825 bytes) Basically works nicely, but the function theme_maintenance_page doesn't set the BASE tag, which (at least in my setup with the site not at the root directory) fails to find the CSS files. The patch adds the same BASE tag as is present on normal pages (i.e., $base_url). ------------------------------------------------------------------------ Wed, 27 Jul 2005 22:51:24 +0000 : wiz That was too quick, I have some more info. The current CVS code does not work when not accessing the start page, e.g. http://drupal/, but something at a deeper level (with search engine friendly URLs turned on) like http://drupal/user/. This case can easily happen with deep links from another site. With the patch attached to my previous post the properly formatted error page appears in this case, too.

1 0

[drupal-devel] [feature] Nice DB error screens
by wiz 28 Jul '05

28 Jul '05

Issue status update for http://drupal.org/node/27231 Post a follow up: http://drupal.org/project/comments/add/27231 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: wiz Status: patch That was too quick, I have some more info. The current CVS code does not work when not accessing the start page, e.g. http://drupal/, but something at a deeper level (with search engine friendly URLs turned on) like http://drupal/user/. This case can easily happen with deep links from another site. With the patch attached to my previous post the properly formatted error page appears in this case, too. wiz Previous comments: ------------------------------------------------------------------------ Thu, 21 Jul 2005 22:43:16 +0000 : drumm Attachment: http://drupal.org/files/issues/screenshot2.png (96.1 KB) Screenshot. ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:21:31 +0000 : drumm Attachment: http://drupal.org/files/issues/screenshot_10.png (88.44 KB) ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:25:57 +0000 : drumm Attachment: http://drupal.org/files/issues/druplicon.png (3.98 KB) New Druplicon which will need to replace misc/druplicon.png. The current file in that location is a giant flat druplicon which isn't used anywhere. ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:26:26 +0000 : drumm Attachment: http://drupal.org/files/issues/maintenance.css (329 bytes) Some CSS ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:30:34 +0000 : drumm Attachment: http://drupal.org/files/issues/errorhandling.patch (8.47 KB) This patch makes the database errors which occur when the database connection information is wrong or the database isn't up much nicer and more explanatory. To do this it adds a themeable function, theme_maintenance_page(), and a way to get Drupal running without a theme but the ability to execute themeable functions in the usual way. This means we can use the same code to give upgrade.php a nicer look in the future. ------------------------------------------------------------------------ Fri, 22 Jul 2005 06:33:57 +0000 : kbahey I was about to do something similar on a less ambitious scale (mainly the connect function), because what we get now is ugly and looks unprofessional. +1 from me for this. Great job! ------------------------------------------------------------------------ Fri, 22 Jul 2005 06:52:30 +0000 : gordon +1, This looks great. Get this in and then we can do something with the upgrade.php system and it will look just great. ------------------------------------------------------------------------ Fri, 22 Jul 2005 19:36:39 +0000 : drumm Attachment: http://drupal.org/files/issues/errorhandling_0.patch (8.44 KB) New patch with a couple suggestions from chx. * $foo === NULL is faster than is_null($foo) * Removed 'bootstrap' from the function name since it is not really part of the bootstrap system. When testing/applying updates #2 and #3 of this issue need to be handled too. ------------------------------------------------------------------------ Fri, 22 Jul 2005 20:47:18 +0000 : stefan nagtegaal I indeed like the patch! you have some perfectly helptexts which asure that people *must* be foulish when they do not know how to setup drupal the correct way. On that, a very, very fine patch.. Though, code-wise I have one nit-pick, which is propably not even a real issue. Only, I think it looks better: + print theme('maintenance_page', 'We were able to connect to the MySQL database server (which means your username and password is okay) but not able to select the database. +The MySQL error was: '. mysql_error() .'. +Currently, the database is <code>'. substr($url['path'], 1) .'. The username is '. $url['user'] .' and the database server is '. $url['host'] .'. + + * Are you sure you have the correct database name? + * Are you sure the database exists? + * Are you sure the username has permission to access the database? + +For more help, see the Installation and upgrading handbook [1]. If you are unsure what these terms mean you should probably contact your hosting provider. '); Wouldn't it be nicer (code-wise) todo: $message[] = 'We were able to connect to the MySQL database server (which means your username and password is okay) but not able to select the database.'; $message[] = strtr('The MySQL error was: %error.', array('%error' => theme('placeholder', mysql_error()))); $message[] = etc, etc; print theme('maintenance_page', $message); Also would I encourage you to make a function theme_message($type, $message), like: function theme_message($type, $message) { switch($type) { case 'code': $output .= '<code>'. $message .'<code>'; break; case 'placeholder': $output .= ''. $message .''; break; case 'important': $output .= ''. $message .''; break; default: $output .= ''. $message .''; break; } } Which makes theme_placeholder() redundant and could be removed. Codesnippets could be handled in a more consistent way then we currently do (having a theme_placeholder() only is rediculous imo afterall). Also this function could be used to remove the hardcoded HTML from the helptexts.. The code is untested and needs some love here-and-there. But, when it's done, I think we will create (codewise) more consistency than we currently have! I look forward to see your idea's and hear your opinion about this.. [1] http://drupal.org/node/258 ------------------------------------------------------------------------ Fri, 22 Jul 2005 23:27:53 +0000 : drumm The theme_message() which stefan nagtegaal looks like it should be four separate themeable functions, one of which already exists. I think any such modifications are outside the scope of this patch. I am nearly finished preparing a patch to update.php which uses this patch, but I can not post it until this patch is resolved. ------------------------------------------------------------------------ Sat, 23 Jul 2005 09:35:03 +0000 : stefan nagtegaal Okay, I think I have to agree with Neill in here.. If this patch hits the trunk, I'll make a new issue and rolls a patch for introducing new functions which should improve code-wise consistency.. Let me introduce you to: function theme_placeholder($message) { return "$message"; } function theme_important($message) { return "$message"; } function theme_code($message) { return "<code>$message"; } function theme_text($message) { return "$message "; } Patches are soon to come in another issue, after this has hit the trunk.. ------------------------------------------------------------------------ Wed, 27 Jul 2005 00:40:00 +0000 : drumm Attachment: http://drupal.org/files/issues/errorhandling_1.patch (8.75 KB) Updated patch using theme_placeholder() where appropriate. ------------------------------------------------------------------------ Wed, 27 Jul 2005 01:59:01 +0000 : Steven Commited to HEAD. ------------------------------------------------------------------------ Wed, 27 Jul 2005 22:44:26 +0000 : wiz Attachment: http://drupal.org/files/issues/errorhandling_base.patch (825 bytes) Basically works nicely, but the function theme_maintenance_page doesn't set the BASE tag, which (at least in my setup with the site not at the root directory) fails to find the CSS files. The patch adds the same BASE tag as is present on normal pages (i.e., $base_url).

1 0

[drupal-devel] [feature] Nice DB error screens
by wiz 28 Jul '05

28 Jul '05

Issue status update for http://drupal.org/node/27231 Post a follow up: http://drupal.org/project/comments/add/27231 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: wiz -Status: fixed +Status: patch Attachment: http://drupal.org/files/issues/errorhandling_base.patch (825 bytes) Basically works nicely, but the function theme_maintenance_page doesn't set the BASE tag, which (at least in my setup with the site not at the root directory) fails to find the CSS files. The patch adds the same BASE tag as is present on normal pages (i.e., $base_url). wiz Previous comments: ------------------------------------------------------------------------ Thu, 21 Jul 2005 22:43:16 +0000 : drumm Attachment: http://drupal.org/files/issues/screenshot2.png (96.1 KB) Screenshot. ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:21:31 +0000 : drumm Attachment: http://drupal.org/files/issues/screenshot_10.png (88.44 KB) ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:25:57 +0000 : drumm Attachment: http://drupal.org/files/issues/druplicon.png (3.98 KB) New Druplicon which will need to replace misc/druplicon.png. The current file in that location is a giant flat druplicon which isn't used anywhere. ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:26:26 +0000 : drumm Attachment: http://drupal.org/files/issues/maintenance.css (329 bytes) Some CSS ------------------------------------------------------------------------ Thu, 21 Jul 2005 23:30:34 +0000 : drumm Attachment: http://drupal.org/files/issues/errorhandling.patch (8.47 KB) This patch makes the database errors which occur when the database connection information is wrong or the database isn't up much nicer and more explanatory. To do this it adds a themeable function, theme_maintenance_page(), and a way to get Drupal running without a theme but the ability to execute themeable functions in the usual way. This means we can use the same code to give upgrade.php a nicer look in the future. ------------------------------------------------------------------------ Fri, 22 Jul 2005 06:33:57 +0000 : kbahey I was about to do something similar on a less ambitious scale (mainly the connect function), because what we get now is ugly and looks unprofessional. +1 from me for this. Great job! ------------------------------------------------------------------------ Fri, 22 Jul 2005 06:52:30 +0000 : gordon +1, This looks great. Get this in and then we can do something with the upgrade.php system and it will look just great. ------------------------------------------------------------------------ Fri, 22 Jul 2005 19:36:39 +0000 : drumm Attachment: http://drupal.org/files/issues/errorhandling_0.patch (8.44 KB) New patch with a couple suggestions from chx. * $foo === NULL is faster than is_null($foo) * Removed 'bootstrap' from the function name since it is not really part of the bootstrap system. When testing/applying updates #2 and #3 of this issue need to be handled too. ------------------------------------------------------------------------ Fri, 22 Jul 2005 20:47:18 +0000 : stefan nagtegaal I indeed like the patch! you have some perfectly helptexts which asure that people *must* be foulish when they do not know how to setup drupal the correct way. On that, a very, very fine patch.. Though, code-wise I have one nit-pick, which is propably not even a real issue. Only, I think it looks better: + print theme('maintenance_page', 'We were able to connect to the MySQL database server (which means your username and password is okay) but not able to select the database. +The MySQL error was: '. mysql_error() .'. +Currently, the database is <code>'. substr($url['path'], 1) .'. The username is '. $url['user'] .' and the database server is '. $url['host'] .'. + + * Are you sure you have the correct database name? + * Are you sure the database exists? + * Are you sure the username has permission to access the database? + +For more help, see the Installation and upgrading handbook [1]. If you are unsure what these terms mean you should probably contact your hosting provider. '); Wouldn't it be nicer (code-wise) todo: $message[] = 'We were able to connect to the MySQL database server (which means your username and password is okay) but not able to select the database.'; $message[] = strtr('The MySQL error was: %error.', array('%error' => theme('placeholder', mysql_error()))); $message[] = etc, etc; print theme('maintenance_page', $message); Also would I encourage you to make a function theme_message($type, $message), like: function theme_message($type, $message) { switch($type) { case 'code': $output .= '<code>'. $message .'<code>'; break; case 'placeholder': $output .= ''. $message .''; break; case 'important': $output .= ''. $message .''; break; default: $output .= ''. $message .''; break; } } Which makes theme_placeholder() redundant and could be removed. Codesnippets could be handled in a more consistent way then we currently do (having a theme_placeholder() only is rediculous imo afterall). Also this function could be used to remove the hardcoded HTML from the helptexts.. The code is untested and needs some love here-and-there. But, when it's done, I think we will create (codewise) more consistency than we currently have! I look forward to see your idea's and hear your opinion about this.. [1] http://drupal.org/node/258 ------------------------------------------------------------------------ Fri, 22 Jul 2005 23:27:53 +0000 : drumm The theme_message() which stefan nagtegaal looks like it should be four separate themeable functions, one of which already exists. I think any such modifications are outside the scope of this patch. I am nearly finished preparing a patch to update.php which uses this patch, but I can not post it until this patch is resolved. ------------------------------------------------------------------------ Sat, 23 Jul 2005 09:35:03 +0000 : stefan nagtegaal Okay, I think I have to agree with Neill in here.. If this patch hits the trunk, I'll make a new issue and rolls a patch for introducing new functions which should improve code-wise consistency.. Let me introduce you to: function theme_placeholder($message) { return "$message"; } function theme_important($message) { return "$message"; } function theme_code($message) { return "<code>$message"; } function theme_text($message) { return "$message "; } Patches are soon to come in another issue, after this has hit the trunk.. ------------------------------------------------------------------------ Wed, 27 Jul 2005 00:40:00 +0000 : drumm Attachment: http://drupal.org/files/issues/errorhandling_1.patch (8.75 KB) Updated patch using theme_placeholder() where appropriate. ------------------------------------------------------------------------ Wed, 27 Jul 2005 01:59:01 +0000 : Steven Commited to HEAD.

1 0

[drupal-devel] [feature] Pass include and exclude parameters to cron.php for fine grained cron timing
by robertDouglass 27 Jul '05

27 Jul '05

Issue status update for http://drupal.org/node/19173 Post a follow up: http://drupal.org/project/comments/add/19173 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: robertDouglass Updated by: robertDouglass Status: patch Bèr, how can you adjust the interval then? If it is hardcoded how often the cron should run, administrators loose all control and you can't have different sites have different schedules, unless of course you have cron configuration in the interface itself. I think cron scheduling should be completely done with the cron tool itself, and that the URL or command that is given should be able to handle the fine tuning of which module's hooks get called. robertDouglass Previous comments: ------------------------------------------------------------------------ Sun, 20 Mar 2005 10:08:59 +0000 : robertDouglass Attachment: http://drupal.org/files/issues/cronpatch.txt (1.99 KB) Some sites need fine grained timing for cron runs. For example, a site that relies heavily on moblogging, mailhandler or any other email based function would want to connect with the email server pretty often, say ever 2-5 minutes. On another site I'm working on we generate flat files for all of a certain node type on a regular basis, though not every 2-5 minutes. Thus the need for cron tasks on different schedules. This patch allows you to make a list of modules to either include or exclude when running cron, so that several cron tasks for one site can be defined. The default behavior in the absence of both parameters is to run all, so the patch preserves backwards compatibility. * Examples: * * runs all hooks * http://mysite.com/cron.php * * runs all hooks except the search and aggregator modules * http://mysite.com/cron.php?exclude=search,aggregator * * runs only search, archive and aggregator modules * http://mysite.com/cron.php?includ=search,archive,aggregator ------------------------------------------------------------------------ Wed, 23 Mar 2005 21:23:59 +0000 : Dries Isn't it possible to run all cron functions every 2-5 minutes? The impact of that should be minimal. ------------------------------------------------------------------------ Wed, 23 Mar 2005 21:33:06 +0000 : moshe weitzman an alternative approach is to make a quick PHP page which simply calls mailhandler_cron and any others that need to be called more frequently than normal. then call that php page from cron every couple minutes ... not so sure this complexity is worth having. ------------------------------------------------------------------------ Thu, 24 Mar 2005 07:32:32 +0000 : robertDouglass Whether or not this "complexity" is needed depends a lot on what you expect to do with cron. As soon as one starts aggregating not tens but several hundred RSS feeds or more, it is impossible to run cron every 2 minutes. Yet if the site depends on mailhandler keeping user moblog submissions current, 2 minutes is already about the maximum latency time acceptable. Thus the need for crons on different schedules. In terms of usage, writing ?include=mailhandler,search,event isn't so complex. On the code level, splitting that list on comma and looping over the resultant array also isn't really that complex. The patch defaults to normal behavior for people who don't need the feature, and I've seen more than one site that had to solve this problem. ------------------------------------------------------------------------ Thu, 24 Mar 2005 10:48:09 +0000 : Robert Castelo Could different cron runs be set to run different tasks based on a cron ID number.... For instance, set up 3 separate cron to run every hour, each one calls the cron.php page including a number variable which runs a certain set of tasks. An Admin control panel would list all cron tasks and allow administrators to split them into separate cron runs based on the number variable passed to the script when calling cron.php. ------------------------------------------------------------------------ Thu, 24 Mar 2005 11:24:53 +0000 : robertDouglass Robert, the id parameter is already a practical necessity for this patch if cron_busy is to be effective. I'm open to suggestions as to how we would track various cron tasks and whether they are busy. First things first, though: does anyone except me need this? I'm not going to program an admin-configurable cron mechanism unless there is demand for it. Furthermore, such a system would really be incomplete unless there were some actual mechanism for setting these cron runs up from the admin interface as well. This wouldn't be such a bad idea, I know a lot of people who still type /cron.php into their browser every day or so to updated thier sites (yes I've mentioned poormanscron). Anyway, first reactions to this patch have been cold, so maybe nobody wants it. ------------------------------------------------------------------------ Thu, 24 Mar 2005 11:39:13 +0000 : Robert Castelo +1 from me. I'll be needing something like this once my email newsletter is released and starts hogging cron runs. ------------------------------------------------------------------------ Thu, 24 Mar 2005 16:06:31 +0000 : Chris Johnson It does seem like a good idea to allow running different cron tasks at different intervals, so as to be efficient and reduce web server loads. There is little point in running tasks that do not need to be run. Many cron tasks only need to be run once to a few times per day. Note also that cron job scheduling on most Unix-variants is only within a +/- 1 minute range, so trying to run a cron program every 2 minutes is approaching the crumbling edge of being "on time." ------------------------------------------------------------------------ Thu, 24 Mar 2005 16:37:39 +0000 : robertDouglass I think I am leaning in favor of extending cron.php in the following way: 1) Add admin screen which scans all modules for existence of cron hook 2) set a cron_interval variable for each one 3) allow admin to set an interval 4) check whether the current cron run falls outside of each module's interval before invoking its cron hook 5) before a module's cron hook gets called a {module_name}_cron_busy variable gets set. This would function like the current cron_busy now, just at a modular level. The admin would then set one cron tab to run at the smallest needed interval and could then decide on a module-by-module basis how often each is to run. How does this sound to people? ------------------------------------------------------------------------ Wed, 27 Jul 2005 16:18:23 +0000 : Bèr Kessels -1 on this one. I think the hook_cron should carry the logic whether or not it wants to be ran. Maybe aintroduce an API that allows theis checkto be done easier? drupal_elapsed_run($name, interval) that will check when $name was last updated, if it was longer then $interval ago, return TRUE, and update the last run of $name.

1 0

[drupal-devel] [task] Display referer with "page not found" warnings
by drumm 27 Jul '05

27 Jul '05

Issue status update for http://drupal.org/node/23651 Post a follow up: http://drupal.org/project/comments/add/23651 Project: Drupal Version: 4.6.2 Component: watchdog.module Category: tasks Priority: normal Assigned to: Anonymous Reported by: Thox Updated by: drumm Status: patch +1 for this functionality, but it needs to be a patch against Drupal CVS. drumm Previous comments: ------------------------------------------------------------------------ Thu, 26 May 2005 11:05:16 +0000 : Thox I get plenty of "page not found" warnings when I look at the admin page, but I have no way to fix them. The pages (rightfully) no longer exist, so I'd simply like to stop links pointing there. If the referering page was part of the message, that would be far more helpful. ------------------------------------------------------------------------ Tue, 26 Jul 2005 07:52:54 +0000 : ahoeben Referer / referrer loggin would be usefull for a more than just page not found warnings. I'ld say include them where available. ------------------------------------------------------------------------ Tue, 26 Jul 2005 09:20:13 +0000 : ahoeben This requires minor changes in bootstrap.inc (watchdog() function), the watchdog module, as well as an alteration to the watchdog table. I'll try to make a patch ------------------------------------------------------------------------ Wed, 27 Jul 2005 21:06:52 +0000 : ahoeben Attachment: http://drupal.org/files/issues/watchdog-referrer.patch (1.6 KB) Here's the patch against 4.6.2. First, you need to execute this SQL statement to alter the watchdog table: ALTER TABLE `watchdog` ADD COLUMN `referer` varchar (128) NOT NULL Next, the patch includes two one-line changes, one each for includes/bootstrap.inc and modules/watchdog.module (you may have to split up the patch file and run them one by one or manually)

1 0

[drupal-devel] [task] Remove dead code
by drumm 27 Jul '05

27 Jul '05

Issue status update for http://drupal.org/node/27627 Post a follow up: http://drupal.org/project/comments/add/27627 Project: Drupal Version: cvs Component: search.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/search.module_0.diff (460 bytes) Since $type isn't used in that function again these three lines of code are not needed. drumm

1 0

[drupal-devel] [bug] Wrong function called, which breaks search.
by drumm 27 Jul '05

27 Jul '05

Issue status update for http://drupal.org/node/27626 Post a follow up: http://drupal.org/project/comments/add/27626 Project: Drupal Version: cvs Component: search.module Category: bug reports Priority: critical Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/search.module.diff (685 bytes) http://cvs.drupal.org/viewcvs/drupal/drupal/modules/search.module?r1=1.129&… That changed string_length() to drupal_substr(). We really want drupal_strlen(). drumm

1 0

[drupal-devel] [task] Display referer with "page not found" warnings
by ahoeben 27 Jul '05

27 Jul '05

Issue status update for http://drupal.org/node/23651 Post a follow up: http://drupal.org/project/comments/add/23651 Project: Drupal Version: 4.6.2 Component: watchdog.module -Category: feature requests +Category: tasks Priority: normal Assigned to: Anonymous Reported by: Thox Updated by: ahoeben -Status: active +Status: patch Attachment: http://drupal.org/files/issues/watchdog-referrer.patch (1.6 KB) Here's the patch against 4.6.2. First, you need to execute this SQL statement to alter the watchdog table: ALTER TABLE `watchdog` ADD COLUMN `referer` varchar (128) NOT NULL Next, the patch includes two one-line changes, one each for includes/bootstrap.inc and modules/watchdog.module (you may have to split up the patch file and run them one by one or manually) ahoeben Previous comments: ------------------------------------------------------------------------ Thu, 26 May 2005 11:05:16 +0000 : Thox I get plenty of "page not found" warnings when I look at the admin page, but I have no way to fix them. The pages (rightfully) no longer exist, so I'd simply like to stop links pointing there. If the referering page was part of the message, that would be far more helpful. ------------------------------------------------------------------------ Tue, 26 Jul 2005 07:52:54 +0000 : ahoeben Referer / referrer loggin would be usefull for a more than just page not found warnings. I'ld say include them where available. ------------------------------------------------------------------------ Tue, 26 Jul 2005 09:20:13 +0000 : ahoeben This requires minor changes in bootstrap.inc (watchdog() function), the watchdog module, as well as an alteration to the watchdog table. I'll try to make a patch

1 0

[drupal-devel] [task] Remove a line of dead code
by drumm 27 Jul '05

27 Jul '05

Issue status update for http://drupal.org/node/27624 Post a follow up: http://drupal.org/project/comments/add/27624 Project: Drupal Version: cvs Component: comment.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/comment.module_12.diff (922 bytes) Loading that node doesn't seem to be needed. drumm

1 0

[drupal-devel] [bug] node_search doesn't node_view, causing bad snippets.
by chx 27 Jul '05

27 Jul '05

Issue status update for http://drupal.org/node/26458 Post a follow up: http://drupal.org/project/comments/add/26458 Project: Drupal Version: cvs Component: node.module Category: bug reports Priority: normal Assigned to: Morbus Iff Reported by: Morbus Iff Updated by: chx Status: patch The patch applies, does what is described and it is needed. +1 chx Previous comments: ------------------------------------------------------------------------ Wed, 06 Jul 2005 15:08:32 +0000 : Morbus Iff Attachment: http://drupal.org/files/issues/_p_nodesearch.patch (1010 bytes) During search indexing, the node.module invokes node_view and node view api before indexing it for content (see node_update_index). This, however, doesn't happen on node_search, which assumes that the body exists to get a snippet from. This causes an empty snippet on flexinode nodes, or anything else that requires a node view api. This patch simply adds the same block from node_update_index to node_search. ------------------------------------------------------------------------ Tue, 19 Jul 2005 14:16:50 +0000 : Morbus Iff Attachment: http://drupal.org/files/issues/_p_26458_nodesearch.patch (996 bytes) Updated for HEAD.

1 0