August 2005 - Development - lists.drupal.org

[drupal-devel] [task] Remove old bugfix code
by drumm 16 Aug '05

16 Aug '05

Issue status update for http://drupal.org/node/28944 Post a follow up: http://drupal.org/project/comments/add/28944 Project: Drupal Version: cvs Component: base system Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch (code needs review) Attachment: http://drupal.org/files/issues/update.php.diff (967 bytes) killes, who wrote the origional patch, said this code is okay to be removed. It was probably for the 4.4 -> 4.5 update. drumm

2 1

[drupal-devel] [feature] Patch: add ability to limit searches to given taxonomy(ies)
by jsaints 15 Aug '05

15 Aug '05

Issue status update for http://drupal.org/node/28933 Post a follow up: http://drupal.org/project/comments/add/28933 Project: Drupal Version: 4.6.0 Component: search.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: jsaints Updated by: jsaints Status: patch (code needs review) Attachment: http://drupal.org/files/issues/search_by_taxonomy_patches.zip (3.09 KB) Here is a quick patch to the search.module and node.module That allows for site search to be limited by taxonomy. Taxonomy limited searches would be available via a URL like: 1) http://my.site.com/search/node/taxonomy/term/1+5+6/my+search+text 2) http://my.site.com/search/node/taxonomy/term/1,5,6/my+search+text These two searches would return respectivly: 1) nodes matching "my search text" in taxonomies 1 or 5 or 6 2) nodes matching "my search text" in taxonomies 1 and 5 and 6 This functionality will not interfere with the current search syntax http://my.site.com/search/node/my+search+text. which will continue to return all nodes that match the text "my search here". The patches are for Drupal version 4.6. If the community likes this functionality, I would like to commit it to CVS jsaints

1 1

[drupal-devel] [bug] drupal base and E_NOTICE
by Thomas Ilsche 15 Aug '05

15 Aug '05

Issue status update for http://drupal.org/node/28540 Post a follow up: http://drupal.org/project/comments/add/28540 Project: Drupal Version: 4.6.0 Component: base system Category: bug reports Priority: minor Assigned to: Anonymous Reported by: hlslaughter Updated by: Thomas Ilsche Status: patch (code needs review) > just curious, any special reason you're using "!empty()" instead of "isset()"? i'd think that an empty string is technically a valid value (though the end result is the same codewise). I wanted to keep it semantically equivalent to if($var). isset is not. This might be especially critical against boolean values. The very problem is the fact that many properties of objects / indexes of arrays are not initialized. !empty is simply on the safe side. I think with the patches it is important to do them from the main drupal dir and not subdirs (but I'm not sure either, a faq/tut/introduction would be cool) Thomas Ilsche Previous comments: ------------------------------------------------------------------------ Tue, 09 Aug 2005 19:19:33 +0000 : hlslaughter ok, instead of whining in the forums, i'll submit a ticket. i'm sure i'm not the first person to bring this up, and i apologize in advance if this issue is already decided/closed. but my issue is this: would it be possible to review the core modules and clean up code to the point that it would be feasible to run drupal with notices turned on (at least in a dev environment)? i think it would be pretty trivial to clean most/all of these errors from the code base. the cost of this effort would be relatively teeny, and the benefits would be great. admins would no longer panic if they happen to see these messages; with an option added to the settings screen, developers could turn on notices and would write cleaner code, which would probably result in fewer bugs in 3rd party modules; etc... you know the routine 8*) after turning on E_NOTICE in common.inc, i see the following notice messages when accessing the homepage of my site: occurences - message ----V--------------V-------- 12 notice: Undefined index: field in /var/www/html/includes/tablesort.inc on line 114. 10 notice: Undefined variable: teaser in /var/www/html/modules/opt/attachment.module on line 37. 6 notice: Undefined variable: count in /var/www/html/modules/opt/attachment.module on line 120. 6 notice: Undefined index: field in /var/www/html/includes/tablesort.inc on line 176. 4 notice: Undefined variable: rows in /var/www/html/modules/opt/attachment.module on line 352. 4 notice: Undefined variable: count in /var/www/html/modules/opt/attachment.module on line 123. 4 notice: Undefined variable: attachments in /var/www/html/modules/opt/attachment.module on line 279. 1 notice: Undefined variable: node in /var/www/html/modules/node.module on line 1950. 1 notice: Undefined offset: 0 in /var/www/html/includes/pager.inc on line 59. 1 notice: Undefined index: op in /var/www/html/modules/node.module on line 1636. 1 notice: Undefined index: node.taxonomy in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: node.picture in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: header.title in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: header.site_slogan in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: header.mission in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: header.help in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: from in /var/www/html/includes/pager.inc on line 53. 1 notice: Undefined index: footer.message in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: footer.blocks in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: edit in /var/www/html/modules/node.module on line 1637. 1 notice: Undefined index: 2 in /var/www/html/modules/filter.module on line 629. 1 notice: Undefined index: in /var/www/html/includes/common.inc on line 506. 1 notice: Trying to get property of non-object in /var/www/html/modules/node.module on line 1950. again, no offense, and sorry if i'm trying to bring a dead horse back to life. ------------------------------------------------------------------------ Tue, 09 Aug 2005 19:22:44 +0000 : killes(a)www.drop.org This is being worked on for the next Drupal version. Please install yourself a test site on cvs and submit individual patches. ------------------------------------------------------------------------ Tue, 09 Aug 2005 19:32:57 +0000 : hlslaughter thanks, i'll do this. i take it patches are just posted here? do i just post a diff -N, title it patch and mark the component appropriately? ------------------------------------------------------------------------ Tue, 09 Aug 2005 19:39:08 +0000 : killes(a)www.drop.org Yes, attach here or create new issue. diff -up is what we usually use. Thanks. ------------------------------------------------------------------------ Tue, 09 Aug 2005 20:24:16 +0000 : hlslaughter Attachment: http://drupal.org/files/issues/test.patch (25.21 KB) attached is results of: harry@penny:~/cvs/third_party/drupal/drupal> diff -Naurp . /var/www/html/drupal_cvs/ > ../test.patch ok, would this type of patch be suitable? it includes fixes for all the E_NOTICE messages generated when accessing the homepage of a new, unmodified drupal installation straight from CVS (as of Aug 9 13:14) ------------------------------------------------------------------------ Tue, 09 Aug 2005 21:01:37 +0000 : killes(a)www.drop.org You are almost there. How to best prepare patches is to run Drupal directly from a cvs checkout. then you can fix the checkout and then run cvs diff -up This way the unrelated files in the patch won't be included. ------------------------------------------------------------------------ Thu, 11 Aug 2005 16:29:12 +0000 : Thomas Ilsche Attachment: http://drupal.org/files/issues/node.user.e_notice.path.txt (1.79 KB) I have a small patch for node.module and user.module that fixes 3 notices in the current HEAD. Please especially have a look at node_access_view_all_nodes, I simply do not get the current use of $node->nid (do I need some more sleep or is this really bogus?) ------------------------------------------------------------------------ Thu, 11 Aug 2005 16:36:22 +0000 : Thomas Ilsche About the newlines at eof: Sorry didn't notcied this as phped removed them manually, is there any reason for them, I got them in many drupal files? Maybe worth a fix aswell? ------------------------------------------------------------------------ Sun, 14 Aug 2005 15:12:00 +0000 : Thomas Ilsche Attachment: http://drupal.org/files/issues/common.inc.enotice.patch.txt (668 bytes) Another patch for common inc. ------------------------------------------------------------------------ Mon, 15 Aug 2005 17:30:34 +0000 : hlslaughter just curious, any special reason you're using "!empty()" instead of "isset()"? i'd think that an empty string is technically a valid value (though the end result is the same codewise). also, sorry i haven't submitted patches, i guess i'm not confident i understand the correct method to submit. is it as follows? 1) cd $drupal_cvs/somedir/ (optionally: cvs update .) 2) edit some.file 3) cvs diff -up > some.file.patch 4) attach some.file.patch to appropriate thread at drupal.org 5) assumming patch is good and correct, pray that someone notices the patch and applies it within CVS ?

1 0

[drupal-devel] [bug] drupal base and E_NOTICE
by hlslaughter 15 Aug '05

15 Aug '05

Issue status update for http://drupal.org/node/28540 Post a follow up: http://drupal.org/project/comments/add/28540 Project: Drupal Version: 4.6.0 Component: base system Category: bug reports Priority: minor Assigned to: Anonymous Reported by: hlslaughter Updated by: hlslaughter Status: patch (code needs review) just curious, any special reason you're using "!empty()" instead of "isset()"? i'd think that an empty string is technically a valid value (though the end result is the same codewise). also, sorry i haven't submitted patches, i guess i'm not confident i understand the correct method to submit. is it as follows? 1) cd $drupal_cvs/somedir/ (optionally: cvs update .) 2) edit some.file 3) cvs diff -up > some.file.patch 4) attach some.file.patch to appropriate thread at drupal.org 5) assumming patch is good and correct, pray that someone notices the patch and applies it within CVS ? hlslaughter Previous comments: ------------------------------------------------------------------------ Tue, 09 Aug 2005 19:19:33 +0000 : hlslaughter ok, instead of whining in the forums, i'll submit a ticket. i'm sure i'm not the first person to bring this up, and i apologize in advance if this issue is already decided/closed. but my issue is this: would it be possible to review the core modules and clean up code to the point that it would be feasible to run drupal with notices turned on (at least in a dev environment)? i think it would be pretty trivial to clean most/all of these errors from the code base. the cost of this effort would be relatively teeny, and the benefits would be great. admins would no longer panic if they happen to see these messages; with an option added to the settings screen, developers could turn on notices and would write cleaner code, which would probably result in fewer bugs in 3rd party modules; etc... you know the routine 8*) after turning on E_NOTICE in common.inc, i see the following notice messages when accessing the homepage of my site: occurences - message ----V--------------V-------- 12 notice: Undefined index: field in /var/www/html/includes/tablesort.inc on line 114. 10 notice: Undefined variable: teaser in /var/www/html/modules/opt/attachment.module on line 37. 6 notice: Undefined variable: count in /var/www/html/modules/opt/attachment.module on line 120. 6 notice: Undefined index: field in /var/www/html/includes/tablesort.inc on line 176. 4 notice: Undefined variable: rows in /var/www/html/modules/opt/attachment.module on line 352. 4 notice: Undefined variable: count in /var/www/html/modules/opt/attachment.module on line 123. 4 notice: Undefined variable: attachments in /var/www/html/modules/opt/attachment.module on line 279. 1 notice: Undefined variable: node in /var/www/html/modules/node.module on line 1950. 1 notice: Undefined offset: 0 in /var/www/html/includes/pager.inc on line 59. 1 notice: Undefined index: op in /var/www/html/modules/node.module on line 1636. 1 notice: Undefined index: node.taxonomy in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: node.picture in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: header.title in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: header.site_slogan in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: header.mission in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: header.help in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: from in /var/www/html/includes/pager.inc on line 53. 1 notice: Undefined index: footer.message in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: footer.blocks in /var/www/html/themes/engines/xtemplate/xtemplate.inc on line 164. 1 notice: Undefined index: edit in /var/www/html/modules/node.module on line 1637. 1 notice: Undefined index: 2 in /var/www/html/modules/filter.module on line 629. 1 notice: Undefined index: in /var/www/html/includes/common.inc on line 506. 1 notice: Trying to get property of non-object in /var/www/html/modules/node.module on line 1950. again, no offense, and sorry if i'm trying to bring a dead horse back to life. ------------------------------------------------------------------------ Tue, 09 Aug 2005 19:22:44 +0000 : killes(a)www.drop.org This is being worked on for the next Drupal version. Please install yourself a test site on cvs and submit individual patches. ------------------------------------------------------------------------ Tue, 09 Aug 2005 19:32:57 +0000 : hlslaughter thanks, i'll do this. i take it patches are just posted here? do i just post a diff -N, title it patch and mark the component appropriately? ------------------------------------------------------------------------ Tue, 09 Aug 2005 19:39:08 +0000 : killes(a)www.drop.org Yes, attach here or create new issue. diff -up is what we usually use. Thanks. ------------------------------------------------------------------------ Tue, 09 Aug 2005 20:24:16 +0000 : hlslaughter Attachment: http://drupal.org/files/issues/test.patch (25.21 KB) attached is results of: harry@penny:~/cvs/third_party/drupal/drupal> diff -Naurp . /var/www/html/drupal_cvs/ > ../test.patch ok, would this type of patch be suitable? it includes fixes for all the E_NOTICE messages generated when accessing the homepage of a new, unmodified drupal installation straight from CVS (as of Aug 9 13:14) ------------------------------------------------------------------------ Tue, 09 Aug 2005 21:01:37 +0000 : killes(a)www.drop.org You are almost there. How to best prepare patches is to run Drupal directly from a cvs checkout. then you can fix the checkout and then run cvs diff -up This way the unrelated files in the patch won't be included. ------------------------------------------------------------------------ Thu, 11 Aug 2005 16:29:12 +0000 : Thomas Ilsche Attachment: http://drupal.org/files/issues/node.user.e_notice.path.txt (1.79 KB) I have a small patch for node.module and user.module that fixes 3 notices in the current HEAD. Please especially have a look at node_access_view_all_nodes, I simply do not get the current use of $node->nid (do I need some more sleep or is this really bogus?) ------------------------------------------------------------------------ Thu, 11 Aug 2005 16:36:22 +0000 : Thomas Ilsche About the newlines at eof: Sorry didn't notcied this as phped removed them manually, is there any reason for them, I got them in many drupal files? Maybe worth a fix aswell? ------------------------------------------------------------------------ Sun, 14 Aug 2005 15:12:00 +0000 : Thomas Ilsche Attachment: http://drupal.org/files/issues/common.inc.enotice.patch.txt (668 bytes) Another patch for common inc.

1 0

[drupal-devel] [task] Starting a forum topic should display signature just like in comments
by webchick 15 Aug '05

15 Aug '05

Issue status update for http://drupal.org/node/10938 Post a follow up: http://drupal.org/project/comments/add/10938 Project: Drupal Version: cvs Component: forum.module Category: tasks Priority: normal Assigned to: Anonymous Reported by: robertDouglass Updated by: webchick -Status: active +Status: patch (code needs review) Attachment: http://drupal.org/files/issues/forum_signature.patch (947 bytes) Here is a very simple patch that just does this the same way as it's done in comment.module. webchick Previous comments: ------------------------------------------------------------------------ Sun, 19 Sep 2004 12:11:23 +0000 : robertDouglass I don't see any reason why the user signature that is provided when writing comments shouldn't be there when forum topics are created as well.

1 0

[drupal-devel] [bug] statistics.module - Menu issue
by Jeremy 15 Aug '05

15 Aug '05

Issue status update for http://drupal.org/node/28446 Post a follow up: http://drupal.org/project/comments/add/28446 Project: Drupal Version: 4.6.0 Component: statistics.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: jacauc Updated by: Jeremy(a)kerneltrap.org -Status: active +Status: patch (code needs review) Attachment: http://drupal.org/files/issues/statistics.module-cvs.patch (1.62 KB) Here is the patch for cvs. Jeremy(a)kerneltrap.org Previous comments: ------------------------------------------------------------------------ Mon, 08 Aug 2005 13:25:15 +0000 : jacauc Attachment: http://drupal.org/files/issues/Untitled_0.jpg (30.26 KB) I am busy upgrading to the latest version of drupal, and i noticed the the following 4 menu items show up directly under the Site Navigation Menu for normal authenticated users (it should only be available for Admin users, and it should show under Administer>logs menu top pages top visitors recent hits referrers Thanks for the help! Cheers jacauc http://www.dieinter.net (current production site) http://www.dieinter.net/backup/sandpit/beta3 (new site - giving me problems) ------------------------------------------------------------------------ Wed, 10 Aug 2005 12:45:55 +0000 : jacauc Has anyone seen this issue before? FYI, i have moved the test site into production, so it is now running on http://www.dieinter.net Please help! Thanks jacauc ------------------------------------------------------------------------ Sat, 13 Aug 2005 21:26:28 +0000 : killes(a)www.drop.org I think it could have happended that the user in question did not have the "access administarion pages" permission but the "access statistics" permission. ------------------------------------------------------------------------ Mon, 15 Aug 2005 15:48:51 +0000 : Jeremy(a)kerneltrap.org Attachment: http://drupal.org/files/issues/statistics.module-4.6.patch (1.64 KB) Indeed, easily duplicated. Part of the confision is that pre-4.6 there were two options, "access statistics" and "administer statistics". The former made content view counters visible, the latter made the accesslog visible. The problem was that "access statistics" was redundant with another "make content view counters visible" option on the statistics module configuration page. Unfortunately, I believe the wrong permission was removed. On my site, I want to be able to let registered users view the view counters (primarily as they are interested in their personal blogs), but not anonymous users. The attached patch removes the option on the statistics module configuration page, and renames the "access statistics" permission to "access accesslog". Additionally, it adds a new "access content view counters" permission. By default, if content view counters are enabled only the administrator will be able to see them until the permission is assigend to other roles. I've attached a patch for 4.6.3, as that's what the bug is against. But I'll post another patch for cvs.

1 0

[drupal-devel] [feature] new date formats...
by Tobias Maier 15 Aug '05

15 Aug '05

Issue status update for http://drupal.org/node/28901 Post a follow up: http://drupal.org/project/comments/add/28901 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Tobias Maier Updated by: Tobias Maier Status: patch (code needs review) Attachment: http://drupal.org/files/issues/system.module_9.patch (1.6 KB) There should be more date formats available. here is a list just to fulfill the german rules (DIN 5008)... http://de.wikipedia.org/wiki/Datumsformat 15.08.2005 - 14:47 --> d.m.Y - H:i 15.08.05 - 14:47 --> d.m.y - H:i 15. Aug. 2005 - 14:47 --> j. M. 2005 - H:i Mo. 15.08.2005 - 14:47 --> D. d.m.Y - H:i Mo. 15.08.05 - 14:47 --> D. d.m.y - H:i 15. August 2005 - 14:47 --> j. F Y - H:i Montag, 15. August 2005 - 14:47 --> l, j. F Y - 14:47 this patch provides the new formats... I think it would be great to introduce three additional textfields where the user can customize the date-field by himself Because it is much work to include _every_ countries special dateformats what do YOU think about it? greets tobias Tobias Maier

1 0

[drupal-devel] [bug] your personal contact form link is broken
by Tobias Maier 15 Aug '05

15 Aug '05

Issue status update for http://drupal.org/node/28728 Post a follow up: http://drupal.org/project/comments/add/28728 Project: Drupal Version: cvs Component: contact.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: watermark Updated by: Tobias Maier -Status: patch (code needs review) +Status: patch (ready to be committed) it works for me... :D so please include it Tobias Maier Previous comments: ------------------------------------------------------------------------ Fri, 12 Aug 2005 00:50:29 +0000 : watermark On my drupal site, if I got to my account->edit and scroll down to *Contact settings* I see a link with the name *your personal contact form*. This link goes to http://www.example.com/user/1/contact instead of http://www.example.com?q=user/1/contact. Hope this helps and it is not a duplicate post. Cheers, Mark ------------------------------------------------------------------------ Fri, 12 Aug 2005 14:22:16 +0000 : tostinni Attachment: http://drupal.org/files/issues/contact_help.patch (1.49 KB) This patch correct the malformed url in the Contact module help.

1 0

[drupal-devel] [bug] UI allows longer role name than database
by plj 15 Aug '05

15 Aug '05

Issue status update for http://drupal.org/node/18616 Post a follow up: http://drupal.org/project/comments/add/18616 Project: Drupal -Version: 4.6.2 +Version: 4.6.3 Component: database system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: plj Updated by: plj Status: patch (code needs work) I've no idea how the update.inc's update numbering works. But it should excecute a statement like this: alter table role alter column name type varchar(64) plj Previous comments: ------------------------------------------------------------------------ Wed, 09 Mar 2005 13:38:12 +0000 : plj The Postgresql database script shipped with Drupal 4.5.2 has a 32 characters long varchar value for role name. The relevant UI form field, however, has attribute maxlength="64". This naturally causes an SQL error, if too long name is entered. The SQL part is still same in CVS version, but I don't know if the UI part has been fixed. Related SQL: CREATE TABLE role ( rid SERIAL, name varchar(32) NOT NULL default '', PRIMARY KEY (rid), UNIQUE (name) ); ------------------------------------------------------------------------ Tue, 28 Jun 2005 16:51:15 +0000 : plj Changing version to 4.6.1, and component to database system (perhaps more relevant than user system), as the problem still exists. It also seems that the length of the field in question is only 32 in both database.mysql and database.pgsql, even though the UI allows 64. Either UI or the database scripts should be fixed. ------------------------------------------------------------------------ Tue, 28 Jun 2005 17:06:18 +0000 : plj Attachment: http://drupal.org/files/issues/database_1.patch (660 bytes) On a second thought, here is a patch against both DBs. Both are untested, but the change is tiny. ------------------------------------------------------------------------ Sat, 06 Aug 2005 20:36:10 +0000 : Cvbge There should be also a patch for database/updates.inc

1 0

[drupal-devel] Re: [drupal-infrastructure] Project module at drupal.org
by Dries Buytaert 15 Aug '05

15 Aug '05

On 15 Aug 2005, at 11:47, Dries Buytaert wrote: > Any idea why the project module at drupal.org is fubar? I upgraded > the project module to HEAD but apparently that was a bad idea. From the looks, this is a nodeapi problem. It relates to the node_get_module_name() changes. As a result, node_invoke() invokes project_load() rather than project_project_load() or project_issue_load() because node_get_module_name() returns 'project' rather than the node types 'project_project' and 'project_issue'. As a quick workaround I made the following change to node.module at drupal.org: 225,226c226,232 < < return $modules[$type]; --- > > if ($modules[$type] == 'project') { > return $type; > } > else { > return $modules[$type]; > } What is the suggested solution? Do we need to create dispatch functions project_load(), project_insert(), project_update() or is this a bug in the node system? -- Dries Buytaert :: http://www.buytaert.net/

2 1